r254510 - Traverse the NestedNameSpecifier(Loc) of NamespaceAliasDecls.

2015-12-02 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Wed Dec 2 07:57:46 2015 New Revision: 254510 URL: http://llvm.org/viewvc/llvm-project?rev=254510&view=rev Log: Traverse the NestedNameSpecifier(Loc) of NamespaceAliasDecls. Review: http://reviews.llvm.org/D15149 Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor

Re: [PATCH] D15149: Traverse the nested name specifier (loc) of namespace alias declarations.

2015-12-02 Thread Daniel Jasper via cfe-commits
djasper closed this revision. djasper added a comment. Submitted as r254510. http://reviews.llvm.org/D15149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15062: [clang-format] Add test for AlignAfterOpenBracket = AlwaysBreak in C++.

2015-12-06 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D15062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

r254933 - clang-format: Make wrapping after "./->" cheaper, even if the element

2015-12-07 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 7 13:50:48 2015 New Revision: 254933 URL: http://llvm.org/viewvc/llvm-project?rev=254933&view=rev Log: clang-format: Make wrapping after "./->" cheaper, even if the element before it is not a closing parenthesis. Otherwise, this frequently leads to "hanging" indents

r255099 - clang-format: Improve documentation of AlignOperands.

2015-12-09 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Wed Dec 9 01:56:52 2015 New Revision: 255099 URL: http://llvm.org/viewvc/llvm-project?rev=255099&view=rev Log: clang-format: Improve documentation of AlignOperands. Modified: cfe/trunk/include/clang/Format/Format.h Modified: cfe/trunk/include/clang/Format/Format.h URL:

Re: [PATCH] D15370: [scan-view] replace deprecated optparse with argparse

2015-12-10 Thread Daniel Jasper via cfe-commits
djasper added a comment. I know nothing about this code. http://reviews.llvm.org/D15370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15445: clang-format: Fix WebKit BeforeElse brace wrapping style

2015-12-11 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Funny that we don't seem to have a test for this. http://reviews.llvm.org/D15445 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH]: git-clang-format

2015-12-11 Thread Daniel Jasper via cfe-commits
Please submit patches to clang-format to reviews.llvm.org. Also, any change no matter how easy it is to deduce from the code itself deserves a proper change description :-). Bullet points are fine. On Fri, Dec 11, 2015 at 4:26 PM, Manuel Klimek wrote: > +djasper > > On Fri, Dec 11, 2015 at 3:40

r255484 - clang-format: Fix style default for WebKit and Linux styles.

2015-12-14 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 14 02:24:16 2015 New Revision: 255484 URL: http://llvm.org/viewvc/llvm-project?rev=255484&view=rev Log: clang-format: Fix style default for WebKit and Linux styles. Brought up in codereviews: http://reviews.llvm.org/D15445 http://reviews.llvm.org/D15485 Modified:

Re: [PATCH] D15445: clang-format: Fix WebKit BeforeElse brace wrapping style

2015-12-14 Thread Daniel Jasper via cfe-commits
djasper closed this revision. djasper added a comment. Submitted as r255484. http://reviews.llvm.org/D15445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r255485 - clang-format: Extend Linux-brace-wrapping test.

2015-12-14 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 14 02:33:07 2015 New Revision: 255485 URL: http://llvm.org/viewvc/llvm-project?rev=255485&view=rev Log: clang-format: Extend Linux-brace-wrapping test. Modified: cfe/trunk/unittests/Format/FormatTest.cpp Modified: cfe/trunk/unittests/Format/FormatTest.cpp URL:

Re: [PATCH] D15485: [clang-format] BraceWrapping.BeforeElse is incorrect for BS_Linux

2015-12-14 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Submitted as r255484 and r255485. http://reviews.llvm.org/D15485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

r255486 - clang-format: Add test for AlignAfterOpenBracket = AlwaysBreak in C++.

2015-12-14 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 14 02:41:18 2015 New Revision: 255486 URL: http://llvm.org/viewvc/llvm-project?rev=255486&view=rev Log: clang-format: Add test for AlignAfterOpenBracket = AlwaysBreak in C++. Revision 251405 added AlwaysBreak to support Google's JavaScript style. This changeset compl

Re: [PATCH] D15062: [clang-format] Add test for AlignAfterOpenBracket = AlwaysBreak in C++.

2015-12-14 Thread Daniel Jasper via cfe-commits
djasper closed this revision. djasper added a comment. Submitted in r255486. Thank you. http://reviews.llvm.org/D15062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-12-14 Thread Daniel Jasper via cfe-commits
djasper added a comment. I think we can add the option AlwaysBreakAfterReturnType but still be backwards compatible. If clang-format finds only the old option in a configuration file, it can choose the appropriate value of the new option. I also like using just this one option better than using

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-12-14 Thread Daniel Jasper via cfe-commits
djasper added a comment. I'd just prefer the setting of the new option and ignore the old one then, but I don't think it matters to much. Warning or err'ing out also seems like a reasonable approach. http://reviews.llvm.org/D10370 ___ cfe-commits

r255757 - clang-format: Extend header sort category implementation.

2015-12-16 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Wed Dec 16 04:10:16 2015 New Revision: 255757 URL: http://llvm.org/viewvc/llvm-project?rev=255757&view=rev Log: clang-format: Extend header sort category implementation. Specifically, it is sometimes necessary to keep certain #includes as the first #include, even before the

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-12-18 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Generally looks good. Comment at: include/clang/Format/Format.h:166 @@ +165,3 @@ + enum ReturnTypeBreakingStyle { +/// Break after return type automatically. +/// \

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

2015-12-21 Thread Daniel Jasper via cfe-commits
djasper added a comment. Ping. What's the state of this? http://reviews.llvm.org/D12407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r256148 - clang-format: Extend detection of the "main" #include to use the filename

2015-12-21 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 21 06:14:17 2015 New Revision: 256148 URL: http://llvm.org/viewvc/llvm-project?rev=256148&view=rev Log: clang-format: Extend detection of the "main" #include to use the filename Before, the first (non-system) header in a file was considered to be the main include. Th

r256153 - clang-format: Only try to find the "main" include in the first block of

2015-12-21 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 21 07:40:49 2015 New Revision: 256153 URL: http://llvm.org/viewvc/llvm-project?rev=256153&view=rev Log: clang-format: Only try to find the "main" include in the first block of includes. Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unittests/Format/Sort

r256154 - clang-format: [JS] Change Google-style default for aligning operands.

2015-12-21 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 21 07:52:19 2015 New Revision: 256154 URL: http://llvm.org/viewvc/llvm-project?rev=256154&view=rev Log: clang-format: [JS] Change Google-style default for aligning operands. The style guide allows both, but apparently, this is the more dominant use. Modified: cf

r256170 - clang-format: Only consider the first #include that looks right to be

2015-12-21 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 21 11:28:24 2015 New Revision: 256170 URL: http://llvm.org/viewvc/llvm-project?rev=256170&view=rev Log: clang-format: Only consider the first #include that looks right to be the main #include. Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unittests/Form

r256175 - clang-format: Properly set the BlockKind for more blocks.

2015-12-21 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 21 12:31:15 2015 New Revision: 256175 URL: http://llvm.org/viewvc/llvm-project?rev=256175&view=rev Log: clang-format: Properly set the BlockKind for more blocks. Before: void f() { struct Dummy { }; f(); } After: void f() { struct Dummy {}; f();

r256245 - clang-format: [JS] "operator" is not a keyword in Java/JavaScript.

2015-12-22 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Tue Dec 22 09:47:56 2015 New Revision: 256245 URL: http://llvm.org/viewvc/llvm-project?rev=256245&view=rev Log: clang-format: [JS] "operator" is not a keyword in Java/JavaScript. Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unittests/Format/FormatTestJS.cpp

r256246 - clang-format: [JS] Conservatively introduce column layout for JS array

2015-12-22 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Tue Dec 22 09:48:15 2015 New Revision: 256246 URL: http://llvm.org/viewvc/llvm-project?rev=256246&view=rev Log: clang-format: [JS] Conservatively introduce column layout for JS array initializers. For now, only use it for 20 items or more. Otherwise, clang-format formats thes

r256247 - clang-format: [JS] Support arrays of object-type literals.

2015-12-22 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Tue Dec 22 09:48:35 2015 New Revision: 256247 URL: http://llvm.org/viewvc/llvm-project?rev=256247&view=rev Log: clang-format: [JS] Support arrays of object-type literals. Before: interface I { o: {} []; } After: interface I { o: {}[]; } Modified: cf

r256342 - clang-format: Fix incorrect pointer detection.

2015-12-23 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Wed Dec 23 12:01:29 2015 New Revision: 256342 URL: http://llvm.org/viewvc/llvm-project?rev=256342&view=rev Log: clang-format: Fix incorrect pointer detection. Before: return * this += 1; After: return *this += 1; Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp

r256343 - clang-format: Lower penalty for breaking between array subscripts.

2015-12-23 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Wed Dec 23 12:01:43 2015 New Revision: 256343 URL: http://llvm.org/viewvc/llvm-project?rev=256343&view=rev Log: clang-format: Lower penalty for breaking between array subscripts. Before: a[aaa()][bbb( )]

r256412 - clang-format: [TableGen] Support ;-less include lines.

2015-12-25 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Fri Dec 25 02:53:31 2015 New Revision: 256412 URL: http://llvm.org/viewvc/llvm-project?rev=256412&view=rev Log: clang-format: [TableGen] Support ;-less include lines. Modified: cfe/trunk/include/clang/Format/Format.h cfe/trunk/lib/Format/Format.cpp cfe/trunk/lib/

r256488 - clang-format: Fix incorrect function type detection.

2015-12-27 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 28 01:44:25 2015 New Revision: 256488 URL: http://llvm.org/viewvc/llvm-project?rev=256488&view=rev Log: clang-format: Fix incorrect function type detection. Before: int x = f (&h)(); After: int x = f(&h)(); Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp

<    3   4   5   6   7   8