https://github.com/cyndyishida commented:
Thank you for cleaning this up!!
https://github.com/llvm/llvm-project/pull/120149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/120149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -,8 +,15 @@ bool Parser::TryAnnotateTypeOrScopeTokenAfterScopeSpec(
}
}
- if (SS.isEmpty())
+ if (SS.isEmpty()) {
+if (getLangOpts().ObjC && !getLangOpts().CPlusPlus &&
cyndyishida wrote:
I'm wondering if it's valid for C code to enter
@@ -150,3 +150,23 @@ clang::parseDarwinSDKInfo(llvm::vfs::FileSystem &VFS,
StringRef SDKRootPath) {
return llvm::make_error("invalid SDKSettings.json",
llvm::inconvertibleErrorCode());
}
+
+// For certain platforms/environments al
https://github.com/cyndyishida approved this pull request.
https://github.com/llvm/llvm-project/pull/119908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2539,6 +2550,18 @@ void DarwinClang::AddClangSystemIncludeArgs(const
llvm::opt::ArgList &DriverArgs
llvm::sys::path::append(P, "usr", "include");
addExternCSystemInclude(DriverArgs, CC1Args, P.str());
}
+
+ // Add default framework search paths
+ auto addFramew
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/118543
* Use the centralized API to add `SubFrameworks` for driverkit targets.
>From 764bf57ac39fddef74d45d16fffc14035bbbff72 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Tue, 3 Dec 2024 11:15:37 -0800
Subjec
cyndyishida wrote:
> Current patch breaks test:
>
> ```
> // We pass --sysroot="" to defeat any -DDEFAULT_SYSROOT parameter.
> ```
>
> I think that just a pure hack in the test case, we can just update the test.
> @cyndyishida what do you think about the current approach?
SGTM too. I don't se
@@ -843,7 +864,7 @@ void ModuleDepCollectorPP::addModuleDep(
!MDC.isPrebuiltModule(Import)) {
cyndyishida wrote:
In hindsight, I wish I made this a stacked diff against the real repo.
I have an implementation that addresses this in
https://github.com/c
cyndyishida wrote:
>From the previous PR:
> This implementation adds some overhead for two reasons.
>
> It deserializes out more content from prebuilt pcm files.
> When a module path is fully realized, it traverses down into the leaf
> dependency and updates whether they are in the sysroot.
>
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/132237
>From ccbcd77e5bd6712531a23bcd79fc9380fdc3d9bf Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 12 Mar 2025 21:26:36 -0700
Subject: [PATCH 1/2] [clang][DependencyScanning] Track dependencies from
preb
@@ -739,6 +748,12 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module
*M) {
MDC.ScanInstance.getASTReader()->visitInputFileInfos(
*MF, /*IncludeSystem=*/true,
[&](const serialization::InputFileInfo &IFI, bool IsSystem) {
+if (MD.IsInSysroot) {
+
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/130634
>From aca254a154489fda68292f6d06a866ae7011a7f6 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 10 Mar 2025 09:06:32 -0700
Subject: [PATCH 1/4] [clang][DependencyScanning] Track modules that resolve
f
@@ -843,7 +864,7 @@ void ModuleDepCollectorPP::addModuleDep(
!MDC.isPrebuiltModule(Import)) {
cyndyishida wrote:
Added a test for this, modified from the working patch.
https://github.com/llvm/llvm-project/pull/130634/files#diff-06c3b647f63ed03628260e6d
@@ -739,6 +748,12 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module
*M) {
MDC.ScanInstance.getASTReader()->visitInputFileInfos(
*MF, /*IncludeSystem=*/true,
[&](const serialization::InputFileInfo &IFI, bool IsSystem) {
+if (MD.IsInSysroot) {
+
@@ -157,6 +157,32 @@ static void optimizeCWD(CowCompilerInvocation
&BuildInvocation, StringRef CWD) {
}
}
+/// Check a subset of invocation options to determine whether the current
+/// context can safely be considered as shareable.
+static bool areOptionsInSharedDir(CowCom
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/130634
>From aca254a154489fda68292f6d06a866ae7011a7f6 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 10 Mar 2025 09:06:32 -0700
Subject: [PATCH 1/5] [clang][DependencyScanning] Track modules that resolve
f
@@ -739,6 +795,12 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module
*M) {
MDC.ScanInstance.getASTReader()->visitInputFileInfos(
*MF, /*IncludeSystem=*/true,
[&](const serialization::InputFileInfo &IFI, bool IsSystem) {
+if (MD.IsShareable) {
+
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/131688
This allows clients to reference more read-only attributes, like
IsInStableDirectories.
>From 99d2648f4c786e56d1fba51751a418e6858d2f7b Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 10 Mar 2025 11:
@@ -5834,9 +5834,13 @@ bool ASTReader::readASTFileControlBlock(
break;
case INPUT_FILE:
bool Overridden = static_cast(Record[3]);
+ size_t FilenameLen = ModuleDir.size() + Record[7] + 1;
auto Filename = ResolveImportedPath(PathBuf
cyndyishida wrote:
ping
https://github.com/llvm/llvm-project/pull/132237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/132968
This type can be exposed from C APIs, where instantiations of this type are not
expected to mutate after creation. To support this, mark the lazy computation
of build arguments mutable, as that is not inten
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/132968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/132237
>From ccbcd77e5bd6712531a23bcd79fc9380fdc3d9bf Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 12 Mar 2025 21:26:36 -0700
Subject: [PATCH 1/3] [clang][DependencyScanning] Track dependencies from
preb
@@ -5834,9 +5834,13 @@ bool ASTReader::readASTFileControlBlock(
break;
case INPUT_FILE:
bool Overridden = static_cast(Record[3]);
+ size_t FilenameLen = ModuleDir.size() + Record[7] + 1;
auto Filename = ResolveImportedPath(PathBuf
@@ -6067,14 +6062,21 @@ llvm::Error ASTReader::ReadSubmoduleBlock(ModuleFile &F,
if (OptionalFileEntryRef CurFile = CurrentModule->getASTFile()) {
// Don't emit module relocation error if we have -fno-validate-pch
if (!bool(PP.getPreprocessorOpts().D
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/132237
>From 3aaaf3371215de0f214836da32f862518f223760 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 12 Mar 2025 21:26:36 -0700
Subject: [PATCH 1/2] [clang][DependencyScanning] Track dependencies from
preb
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/132237
>From 3aaaf3371215de0f214836da32f862518f223760 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 12 Mar 2025 21:26:36 -0700
Subject: [PATCH 1/3] [clang][DependencyScanning] Track dependencies from
preb
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/132237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/134475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
Talked a bit offline, but the patch LGTM, assuming it is purely restoring the
previous behavior before
https://github.com/llvm/llvm-project/commit/55323ca6c8b9d21d85591f3499b299b62463321f,
which would result in performance parity with the release compiler.
> I suggest we
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/130634
>From aca254a154489fda68292f6d06a866ae7011a7f6 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 10 Mar 2025 09:06:32 -0700
Subject: [PATCH 1/3] [clang][DependencyScanning] Track modules that resolve
f
@@ -739,6 +748,12 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module
*M) {
MDC.ScanInstance.getASTReader()->visitInputFileInfos(
*MF, /*IncludeSystem=*/true,
[&](const serialization::InputFileInfo &IFI, bool IsSystem) {
+if (MD.IsInSysroot) {
+
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/130634
>From aca254a154489fda68292f6d06a866ae7011a7f6 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 10 Mar 2025 09:06:32 -0700
Subject: [PATCH 1/2] [clang][DependencyScanning] Track modules that resolve
f
cyndyishida wrote:
> I have a similar concern to @jansvoboda11 that we probably need to check the
> invocation paths as well.
> The situation this covers is how likely is it that the build system is going
> to determine this needs to be rebuilt, and that happens (in most cases)
> purely based
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/130634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5834,13 +5847,27 @@ bool ASTReader::readASTFileControlBlock(
break;
case INPUT_FILE:
bool Overridden = static_cast(Record[3]);
- const size_t FilenameAsRequestedLength = Record[7] + 1;
- auto ResolvedFilenameAsRequested = Resolv
@@ -237,6 +237,17 @@ class ASTReaderListener {
return true;
}
+ /// Overloaded member function of \c visitInputFile that should
+ /// be defined when the input file contains both the virtual and external
+ /// paths, for example when deserializing input files from AST
cyndyishida wrote:
> This PR temporarily turns off negative directory caching to fix the build
> failures.
What does temporarily mean here? Is it until the project identified with errors
can resolve themselves? Is it until error detection in the build system can
catch cases where negative sta
https://github.com/cyndyishida approved this pull request.
LGTM, a minor non-blocking question. Thank you!
https://github.com/llvm/llvm-project/pull/134475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/135704
Pass a reference to `StableDirs` when creating ModuleDepCollector. This avoids
needing to create one from the same ScanInstance for each call to
`handleTopLevelModule` & reduces the amount of potential down
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/135687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -92,16 +92,10 @@ bool Preprocessor::EnterSourceFile(FileID FID,
ConstSearchDirIterator CurDir,
}
Lexer *TheLexer = new Lexer(FID, *InputFile, *this, IsFirstIncludeOfFile);
- if (getPreprocessorOpts().DependencyDirectivesForFile &&
- FID != PredefinesFileID) {
-
https://github.com/cyndyishida approved this pull request.
LGTM, though you may want to wait a bit longer for someone more familiar to
also take a look.
https://github.com/llvm/llvm-project/pull/136178
___
cfe-commits mailing list
cfe-commits@lists.l
@@ -92,16 +92,10 @@ bool Preprocessor::EnterSourceFile(FileID FID,
ConstSearchDirIterator CurDir,
}
Lexer *TheLexer = new Lexer(FID, *InputFile, *this, IsFirstIncludeOfFile);
- if (getPreprocessorOpts().DependencyDirectivesForFile &&
- FID != PredefinesFileID) {
-
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/136612
>From 046b60179ee5eddc6db2193406bfc2ef10fda3df Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 21 Apr 2025 13:20:12 -0700
Subject: [PATCH 1/4] [clang][Modules] Report when` lookupModuleFile` fails and
@@ -3311,11 +3312,22 @@ ASTReader::ReadControlBlock(ModuleFile &F,
SignatureBytes.end());
Blob = Blob.substr(ASTFileSignature::size);
+// Use BaseDirectoryAsWritten to ensure we use the same path in the
+
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/136612
>From 046b60179ee5eddc6db2193406bfc2ef10fda3df Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 21 Apr 2025 13:20:12 -0700
Subject: [PATCH 1/5] [clang][Modules] Report when` lookupModuleFile` fails and
@@ -3349,10 +3351,29 @@ ASTReader::ReadControlBlock(ModuleFile &F,
.getModuleCache()
.getInMemoryModuleCache()
.isPCMFinal(F.FileName);
- if (isDiagnosedResult
@@ -3349,10 +3351,29 @@ ASTReader::ReadControlBlock(ModuleFile &F,
.getModuleCache()
.getInMemoryModuleCache()
.isPCMFinal(F.FileName);
- if (isDiagnosedResult
cyndyishida wrote:
> Does the described test case look like a build system problem? In my
> understanding at step 4 we should have re-scanned B to know that we need some
> B'.pcm depending on A-2.pcm. Regardless of the answer I don't want to block
> the change as it is still an improvement. Ju
@@ -0,0 +1,62 @@
+/// This tests the expected error case when there is a mismatch between the
pcm dependencies passed in
+/// the command line with `fmodule-file` and whats encoded in the pcm.
+
+/// The steps are:
+/// 1. Build module (A-1) with no dependencies.
+/// 2. Build
https://github.com/cyndyishida approved this pull request.
https://github.com/llvm/llvm-project/pull/136601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -861,9 +864,13 @@ class CompilerInstance : public ModuleLoader {
///
/// Explicitly-specified \c VFS takes precedence over the VFS of this
instance
/// when creating the clone and also prevents \c FileManager sharing.
- std::unique_ptr cloneForModuleCompile(
- S
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/136612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida approved this pull request.
https://github.com/llvm/llvm-project/pull/137059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -357,6 +357,32 @@ static void canonicalizeDefines(PreprocessorOptions
&PPOpts) {
std::swap(PPOpts.Macros, NewMacros);
}
+class ActualDependencyDirectivesGetter : public DependencyDirectivesGetter {
cyndyishida wrote:
nit: s/ActualDependencyDirectivesGet
https://github.com/cyndyishida approved this pull request.
https://github.com/llvm/llvm-project/pull/136178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -115,6 +115,15 @@ struct ModuleID {
}
};
+struct ExtendedModuleID {
cyndyishida wrote:
for that `using DepInfo = std::pair` achieves the same thing,
right?
& you can unpack it like `auto [MID, isExported] = ClangModuleDeps.first()`
I don't feel that st
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/137421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -115,6 +115,15 @@ struct ModuleID {
}
};
+struct ExtendedModuleID {
cyndyishida wrote:
For case 1.
i'd argue that
`for (const auto &Info : ClangModuleDeps)` is less readable than
`for (const auto &[ID, isExported] : ClangModuleDeps)`
For case 3, that
https://github.com/cyndyishida approved this pull request.
https://github.com/llvm/llvm-project/pull/137421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/138610
Previously, diagnostics like `error: 'fNew' is unavailable: introduced in macOS
11 unknown` were getting emitted when the active target triple didn't have an
environment tied to it. Instead, add a guard aga
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/137068
In an explicit build, the dependency scanner generates invocations with
dependencies to module files to use during compilation. The pcm's passed in the
invocations should match the ones that were imported b
@@ -3311,11 +3312,22 @@ ASTReader::ReadControlBlock(ModuleFile &F,
SignatureBytes.end());
Blob = Blob.substr(ASTFileSignature::size);
+// Use BaseDirectoryAsWritten to ensure we use the same path in the
+
@@ -3311,11 +3312,22 @@ ASTReader::ReadControlBlock(ModuleFile &F,
SignatureBytes.end());
Blob = Blob.substr(ASTFileSignature::size);
+// Use BaseDirectoryAsWritten to ensure we use the same path in the
+
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/137068
>From bb548cb398714ae77b6fd2f782b172d8b9032a2f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 23 Apr 2025 14:47:17 -0700
Subject: [PATCH] [clang][Modules] Diagnose mismatching pcm dependencies in
ex
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/135704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/135704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
> To be clear, this PR is basically cherry-picking
> https://github.com/swiftlang/llvm-project/pull/9076
AFAICT that patch special-cased for framework directories while this one
disables much more. Is that not the case?
https://github.com/llvm/llvm-project/pull/134698
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/135687
None
>From d105489358661b0cd38b447592ff3e69a5641a7c Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 14 Apr 2025 15:01:45 -0700
Subject: [PATCH] [clang][tests] Add missing FileCheck check, NFC
---
c
https://github.com/cyndyishida approved this pull request.
AFAICT this seems like a good cleanup for detangling sdk dependencies where its
safe to.
https://github.com/llvm/llvm-project/pull/137432
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/137068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/137068
>From bb548cb398714ae77b6fd2f782b172d8b9032a2f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 23 Apr 2025 14:47:17 -0700
Subject: [PATCH 1/3] [clang][Modules] Diagnose mismatching pcm dependencies in
@@ -115,6 +115,15 @@ struct ModuleID {
}
};
+struct ExtendedModuleID {
cyndyishida wrote:
nit: why not use a `std::pair`? It comes with operator overloads.
Also, assuming this field is only intended for representing objects in
`ClangModuleDeps`, maybe the
@@ -0,0 +1,164 @@
+// Test correctly reporting what a module exports during dependency scanning.
+// Module A depends on modules B, C and D, but only exports B and C.
+// Module E depends on modules B, C and D, and exports all of them.
+
+// RUN: rm -rf %t
+// RUN: split-file %s %
@@ -183,7 +192,7 @@ struct ModuleDeps {
///
/// This may include modules with a different context hash when it can be
/// determined that the differences are benign for this compilation.
- std::vector ClangModuleDeps;
+ std::vector ClangModuleDeps;
cynd
https://github.com/cyndyishida approved this pull request.
https://github.com/llvm/llvm-project/pull/135737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -861,9 +864,13 @@ class CompilerInstance : public ModuleLoader {
///
/// Explicitly-specified \c VFS takes precedence over the VFS of this
instance
/// when creating the clone and also prevents \c FileManager sharing.
- std::unique_ptr cloneForModuleCompile(
- S
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/136612
* Report when lookupModuleFile fails and there's an alternate module file to use
In an explicit build, the dependency scanner generates invocations with
dependencies to module files to use during compilatio
@@ -0,0 +1,62 @@
+/// This tests the expected error case when there is a mismatch between the
pcm dependencies passed in
+/// the command line with `fmodule-file` and whats encoded in the pcm.
+
+/// The steps are:
+/// 1. Build module (A-1) with no dependencies.
+/// 2. Build
cyndyishida wrote:
> What would happen if both A-1.pcm and A-2.pcm are built for the same files
> (e.g., from Sysroot) but have different file names? Not saying it is a valid
> use case to support, just curious what would happen.
I tried this, where basically `A-1.pcm` is built again but with
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/136612
>From 046b60179ee5eddc6db2193406bfc2ef10fda3df Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 21 Apr 2025 13:20:12 -0700
Subject: [PATCH 1/3] [clang][Modules] Report when` lookupModuleFile` fails and
@@ -0,0 +1,62 @@
+/// This tests the expected error case when there is a mismatch between the
pcm dependencies passed in
+/// the command line with `fmodule-file` and whats encoded in the pcm.
+
+/// The steps are:
+/// 1. Build module (A-1) with no dependencies.
+/// 2. Build
@@ -3349,9 +3351,14 @@ ASTReader::ReadControlBlock(ModuleFile &F,
.getModuleCache()
.getInMemoryModuleCache()
.isPCMFinal(F.FileName);
- if (isDiagnosedResult(
cyndyishida wrote:
> This approach becomes a problem when trying to run such tests on a
cross-compiling build of clang on a darwin platform. When no darwin
targets are included in the build, the tests will still run on a darwin
host and fail spuriously because of the missing target.
This doesn't
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/130634
That patch tracks whether all the file & module dependencies of a module
resolve to a sysroot location. This information will later be queried by build
systems for determining where to store the accompanyin
cyndyishida wrote:
> but I'm concerned that this does not guarantee the resulting command line
> only refers to inputs in the sysroot. Imagine that we run this without the
> header search and VFS pruning optimizations - the command line will likely
> refer to unused project-specific source/bui
@@ -1213,11 +1213,17 @@ void GetDependenciesByModuleNameAction::ExecuteAction()
{
Preprocessor &PP = CI.getPreprocessor();
SourceManager &SM = PP.getSourceManager();
FileID MainFileID = SM.getMainFileID();
- SourceLocation FileStart = SM.getLocForStartOfFile(MainFileID)
@@ -748,17 +751,21 @@ bool DependencyScanningWorker::computeDependencies(
InMemoryFS->setCurrentWorkingDirectory(WorkingDirectory);
SmallString<128> FakeInputPath;
// TODO: We should retry the creation if the path already exists.
- llvm::sys::fs::createUniquePath(ModuleN
https://github.com/cyndyishida approved this pull request.
thanks!
https://github.com/llvm/llvm-project/pull/127839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/128446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -492,8 +492,23 @@ static std::string getModuleContextHash(const ModuleDeps
&MD,
auto &FSOpts = const_cast(CI.getFileSystemOpts());
if (CWD && !IgnoreCWD)
HashBuilder.add(*CWD);
- else
+ else {
FSOpts.WorkingDir.clear();
+auto &CGOpts = const_cast(CI.getCo
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/132237
When a module is being scanned, it can depend on modules that have already been
built from a pch dependency. When this happens, the pcm files are reused for
the module dependencies. When this is the case, c
https://github.com/cyndyishida approved this pull request.
LGTM. I was a bit worried about the fallout that other target triples using the
same sdks would now opt into this behavior but if that were the case they'd
already be running into modularization errors (e.g.
`found_incompatible_headers
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/139087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/138610
>From d642c83835743409395a2b7a091eac8bf5c948c4 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 5 May 2025 16:09:00 -0700
Subject: [PATCH 1/2] [clang] Remove "unknown" from availability diags
Previous
cyndyishida wrote:
> The change looks reasonable but can you add a test? thanks!
Open to other suggestions @cor3ntin, but I didn't figure out a way to ensure
part of a diagnostic was omitted with cc1's `-verify` so its a driver test that
uses `FIleCheck`
https://github.com/llvm/llvm-project/p
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/138610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/139637
None
>From ef70cfb8d8a468f87758b4f2f8c6efd85e5023ba Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 12 May 2025 16:02:22 -0700
Subject: [PATCH] [clang] update diagnostic to say 'modification time' in
301 - 400 of 478 matches
Mail list logo
