@@ -38,7 +38,9 @@ AST_MATCHER(Type, sugaredNullptrType) {
StatementMatcher makeCastSequenceMatcher(llvm::ArrayRef NameList) {
auto ImplicitCastToNull = implicitCastExpr(
anyOf(hasCastKind(CK_NullToPointer),
hasCastKind(CK_NullToMemberPointer)),
-
unless(hasImplic
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/109436
None
>From abac0e695412e0613cdb50a9e59e84f224e4138d Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 20 Sep 2024 23:03:57 +0800
Subject: [PATCH] [clang][NFC] add static for internal linkage function a
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/109436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/109436
>From 011a64ce5d228bc8945f719f37350a9c6663e283 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Sat, 21 Sep 2024 07:06:06 +0800
Subject: [PATCH] add static
---
clang/lib/Sema/SemaDecl.cpp | 2 +-
clang/l
https://github.com/HerrCai0907 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/109169
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/109302
>From cc2c798193722b3a537c76e74981ff767d064efa Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 19 Sep 2024 23:46:16 +0800
Subject: [PATCH 1/4] [clang-tidy][bugprone-posix-return] support integer
lite
@@ -38,7 +38,9 @@ AST_MATCHER(Type, sugaredNullptrType) {
StatementMatcher makeCastSequenceMatcher(llvm::ArrayRef NameList) {
auto ImplicitCastToNull = implicitCastExpr(
anyOf(hasCastKind(CK_NullToPointer),
hasCastKind(CK_NullToMemberPointer)),
-
unless(hasImplic
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/108792
>From 795b3ae677210ff50f7710a0cf73d435889b68ae Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 16 Sep 2024 13:47:10 +0800
Subject: [PATCH] [clang-tidy] insert ``static`` keyword in correct position
f
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/110200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/110200
>From aee3cc16d9c36d2cc56247ec14f72730c7b65e80 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 26 Sep 2024 17:48:48 +0800
Subject: [PATCH 1/3] [clang-tidy][NFC] optimize unused using decls performance
HerrCai0907 wrote:
> LGTM, thanks for splitting the patch!
>
> Personally I don't quite see the added value of having the quotes, I actually
> find them a bit noisy. It would have been good to write the motivation for
> this change in the commit message.
>
> But this is quite subjective so if
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/109159
Fixes: #109083
>From 4fc1d24c4ff22a8da22454aebe7053ea76419767 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 18 Sep 2024 23:26:02 +0800
Subject: [PATCH] [clang-tidy] loop convert can handle lambda
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/109159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/109068
>From 66be189c281db7a49c5238c2fe09df64842c1e25 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 17 Sep 2024 23:01:17 +0800
Subject: [PATCH 1/2] add quotation
---
.../modernize/AvoidCArraysCheck.cpp
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/109068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3Ro
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/109068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3Ro
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3Ro
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3Ro
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3Ro
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3Ro
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= ,
=?utf-8?b?R8OhYm9yIFTDs3Ro
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/109302
Refactor matches to give more generic checker.
>From cc2c798193722b3a537c76e74981ff767d064efa Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 19 Sep 2024 23:46:16 +0800
Subject: [PATCH] [clang-tidy]
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/108792
>From 795b3ae677210ff50f7710a0cf73d435889b68ae Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 16 Sep 2024 13:47:10 +0800
Subject: [PATCH] [clang-tidy] insert ``static`` keyword in correct position
f
HerrCai0907 wrote:
friendly ping @5chmidti and other person who has time to review PR.
https://github.com/llvm/llvm-project/pull/108792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/109159
>From 4fc1d24c4ff22a8da22454aebe7053ea76419767 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 18 Sep 2024 23:26:02 +0800
Subject: [PATCH 1/2] [clang-tidy] loop convert can handle lambda init capture
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/109159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/109159
>From 4fc1d24c4ff22a8da22454aebe7053ea76419767 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 18 Sep 2024 23:26:02 +0800
Subject: [PATCH 1/2] [clang-tidy] loop convert can handle lambda init capture
@@ -980,3 +980,30 @@ namespace PR78381 {
}
}
}
+
+namespace GH109083 {
+void test() {
+ const int N = 6;
+ int Arr[N] = {1, 2, 3, 4, 5, 6};
+
+ for (int I = 0; I < N; ++I) {
+auto V = [T = Arr[I]]() {};
+ }
+ // CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/108792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/115275
Fixed: #115175.
`dependent type` are not the same even pointers are the same.
>From 06fb72b3720e3c457fc672c38258474879006682 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Nov 2024 15:21:48 +0800
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/115180
`hasSimpleCopyConstructor` series of functions are not reliable when these
functions are not resolved. We need to manually resolve the status of these
functions from its base classes.
Fixes: #111985.
>Fro
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/117474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/117482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/117479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/115180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -102,6 +102,211 @@ void BranchCloneCheck::registerMatchers(MatchFinder
*Finder) {
this);
Finder->addMatcher(switchStmt().bind("switch"), this);
Finder->addMatcher(conditionalOperator().bind("condOp"), this);
+ Finder->addMatcher(
+ ifStmt((hasThen(hasDescend
@@ -102,6 +102,211 @@ void BranchCloneCheck::registerMatchers(MatchFinder
*Finder) {
this);
Finder->addMatcher(switchStmt().bind("switch"), this);
Finder->addMatcher(conditionalOperator().bind("condOp"), this);
+ Finder->addMatcher(
+ ifStmt((hasThen(hasDescend
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/114715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -43,7 +43,7 @@ void test(void) {
}
extern void g3(int); // expected-note{{previous declaration is here}}
-static void g3(int x) { } // expected-error{{static declaration of 'g3'
follows non-static declaration}}
+static void g3(int x) { } // expected-error{{static declarati
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/117945
>From a3ca8316f9a64b89631226015f75aa3a627735a0 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 28 Nov 2024 08:15:34 +0800
Subject: [PATCH] [clang-tidy][use-internal-linkage]fix false positives for
gl
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/117901
>From d1d0722e833a9b66206c008a4cd3f6c5b4548b5c Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 27 Nov 2024 23:08:55 +0800
Subject: [PATCH 1/4] [ast-matcher] add `exportDecl` matcher
---
clang/docs/R
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/117945
>From 7d0f420940240cf8522269fdde3682ff1f5d03e6 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 28 Nov 2024 08:15:34 +0800
Subject: [PATCH] [clang-tidy][use-internal-linkage]fix false positives for
gl
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/117945
>From a5c9f45fe2470a77c81d7eb0502053145ad854ca Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 28 Nov 2024 08:15:34 +0800
Subject: [PATCH] [clang-tidy][use-internal-linkage]fix false positives for
gl
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/117945
>From 4cbe6e08f950d9d3075fa7a1da889b7566bef6c5 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 28 Nov 2024 08:15:34 +0800
Subject: [PATCH] [clang-tidy][use-internal-linkage]fix false positives for
gl
@@ -119,14 +122,55 @@ void UseUsingCheck::check(const MatchFinder::MatchResult
&Result) {
return;
}
- PrintingPolicy PrintPolicy(getLangOpts());
- PrintPolicy.SuppressScope = true;
- PrintPolicy.ConstantArraySizeAsWritten = true;
- PrintPolicy.UseVoidForZeroParams =
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/117734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -179,7 +179,8 @@ Changes in existing checks
- Improved :doc:`bugprone-return-const-ref-from-parameter
` check to
diagnose potential dangling references when returning a ``const &`` parameter
- by using the conditional operator ``cond ? var1 : var2``.
+ by using the con
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/117901
- **[ast-matcher] add `exportDecl` matcher**
- **[clang-tidy][use-internal-linkage]fix false positives for `ExportDecl`**
>From d1d0722e833a9b66206c008a4cd3f6c5b4548b5c Mon Sep 17 00:00:00 2001
From: Congco
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/117901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/117901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/117901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/117901
>From d1d0722e833a9b66206c008a4cd3f6c5b4548b5c Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 27 Nov 2024 23:08:55 +0800
Subject: [PATCH 1/3] [ast-matcher] add `exportDecl` matcher
---
clang/docs/R
HerrCai0907 wrote:
> I'm a little bit worried about the behavior of the C++ Core Guideline check
> in clang-tidy though as it's now wholly redundant
I think the checker can be removed if clang has this kind of compilation time
warning and can totally cover the checker.
> IMO, this is useful as
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/117942
None
>From 65d7cd18a67fba41fe8cfe191217765830829bc9 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 28 Nov 2024 07:42:37 +0800
Subject: [PATCH] [ast-matcher][NFC] make dump_ast_matchers.py run in any
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/117945
None
>From 5654b7c96bf5f2e9ef739279f559b1d800afc5ec Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 28 Nov 2024 08:15:34 +0800
Subject: [PATCH] [clang-tidy][use-internal-linkage]fix false positives f
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/117942
>From 4f6e87664c01ff6277824a0c45089795a1ad30b6 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 28 Nov 2024 07:42:37 +0800
Subject: [PATCH] [ast-matcher][NFC] make dump_ast_matchers.py run in any path
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/117945
>From 5654b7c96bf5f2e9ef739279f559b1d800afc5ec Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 28 Nov 2024 08:15:34 +0800
Subject: [PATCH 1/2] [clang-tidy][use-internal-linkage]fix false positives for
@@ -449,7 +449,8 @@ void
ExceptionAnalyzer::ExceptionInfo::reevaluateBehaviour() {
ExceptionAnalyzer::ExceptionInfo ExceptionAnalyzer::throwsException(
const FunctionDecl *Func, const ExceptionInfo::Throwables &Caught,
llvm::SmallSet &CallStack) {
- if (!Func || CallS
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/116635
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/116635
>From 74c7a62a93c435a25fa524b1d1ede1fc9fe40a07 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 18 Nov 2024 23:06:19 +0800
Subject: [PATCH 1/2] [clang-tidy][NFC] fix typo in ExceptionAnalyzer; replace
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/116643
`ExceptionAnalyzer` can ignore `consteval` function even if it will throw
exception. `consteval` function must produce compile-time constant. But throw
statement cannot appear in constant evaluation.
Fixed:
HerrCai0907 wrote:
I agree cppcoreguideline wants to check it. but since we have already allow the
to unsigned cast later according to [conv.intergral] before c++20, I think here
the behavior should be the same. we should either remove or accept both
limitation.
https://github.com/llvm/llvm-p
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/116591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Félix-Antoine?= Constantin,
=?utf-8?q?Félix-Antoine?= Constantin,
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
HerrCai0907 wrote:
I am not the expect of cpp standard, in my opinion, enum is not a type alias.
it is a new type.
https://github.com/llvm/llvm-project/pul
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/116591
None
>From ba1a73e0220937e26618ce0417a7aeadd0ed3792 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 18 Nov 2024 15:09:34 +0800
Subject: [PATCH] [clang-tidy] fix cppcoreguidelines-narrowing-conversion
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/116588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/116635
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/116635
None
>From 74c7a62a93c435a25fa524b1d1ede1fc9fe40a07 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 18 Nov 2024 23:06:19 +0800
Subject: [PATCH] [clang-tidy][NFC] fix typo in ExceptionAnalyzer; replac
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/116033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/115275
>From 06fb72b3720e3c457fc672c38258474879006682 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Nov 2024 15:21:48 +0800
Subject: [PATCH 1/2] [clang-tidy] fix bugprone-sizeof-expression when sizeof
e
@@ -269,6 +473,21 @@ void BranchCloneCheck::check(const
MatchFinder::MatchResult &Result) {
return;
}
+ if (const auto *IS = Result.Nodes.getNodeAs("ifWithDescendantIf")) {
+const Stmt *Then = IS->getThen();
+auto CS = dyn_cast(Then);
+if (CS && (!CS->body_
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/114255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/115051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 requested changes to this pull request.
I don't think it is a good way to suppress all warning when we find gtest macro.
1. it will confuse user who really want to check even in test file.
2. the user can disable this rules in test folder or even use nolint the test
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/115180
>From 428283c7b61ca50d40ffd3ddc5c08aca39f39533 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Nov 2024 00:35:47 +0800
Subject: [PATCH 1/2] [clang-tidy] fix false positive when detecting templated
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/115180
>From 428283c7b61ca50d40ffd3ddc5c08aca39f39533 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Nov 2024 00:35:47 +0800
Subject: [PATCH 1/2] [clang-tidy] fix false positive when detecting templated
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/114544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -30,6 +30,17 @@ struct NotLengthExprForStringNode {
IntegerLiteralSizeNode->getValue().getZExtValue();
}
+ if (const auto *DeclRefNode = Node.get()) {
HerrCai0907 wrote:
llvm code guideline wants to ignore `{}` for `if` / `for` wi
https://github.com/HerrCai0907 approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/116033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -171,10 +182,64 @@ void UseStartsEndsWithCheck::registerMatchers(MatchFinder
*Finder) {
hasRHS(lengthExprForStringNode("needle")
.bind("expr"),
this);
+
+ Finder->addMatcher(
+ cxxOperatorCallExpr(
+ hasAnyOper
@@ -266,3 +269,53 @@ void test(std::string s, std::string_view sv, sub_string
ss, sub_sub_string sss,
s.compare(0, 1, "ab") == 0;
s.rfind(suffix, 1) == s.size() - suffix.size();
}
+
+void test_substr() {
+std::string str("hello world");
+std::string prefix = "hello
@@ -266,3 +269,53 @@ void test(std::string s, std::string_view sv, sub_string
ss, sub_sub_string sss,
s.compare(0, 1, "ab") == 0;
s.rfind(suffix, 1) == s.size() - suffix.size();
}
+
+void test_substr() {
+std::string str("hello world");
+std::string prefix = "hello
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/115180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/115180
>From 428283c7b61ca50d40ffd3ddc5c08aca39f39533 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Nov 2024 00:35:47 +0800
Subject: [PATCH 1/3] [clang-tidy] fix false positive when detecting templated
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/116588
It is introduced in https://reviews.llvm.org/D59528, but I don't find any usage
of clang in clang tidy test.
>From 88cdc050337d45a8d80926de3cfbc68cc2ca8831 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/95797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/97080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/116643
>From 529e5af068588e18e061aa399a28cd146816fc80 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 18 Nov 2024 23:50:22 +0800
Subject: [PATCH 1/2] [clang-tidy] ignore consteval function in
`ExceptionAnal
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/117479
Detected by misc-use-internal-linkage
>From c3c37db297c2db4e8e4d8009e30819cdabf05df8 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Sun, 24 Nov 2024 19:42:51 +0800
Subject: [PATCH] [clang][tablegen][NFC
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/117490
If in one TU, function only have declaration without body, this function should
be external linkage.
Fixed #117488
>From a1f2a6523c69bf09f39e478a8108a621ba959c20 Mon Sep 17 00:00:00 2001
From: Congcong Cai
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/117484
None
>From 35938c24d9adf12ef6276dd3c7fb25ab1f40c33c Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Sun, 24 Nov 2024 21:46:13 +0800
Subject: [PATCH] [clang-tidy][NFC] fix release note order
---
clang-to
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/117484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/117430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/117467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/117467
None
>From adfb09e1b3fa69ce0f9a8350fe74c0781d1f7b78 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Sun, 24 Nov 2024 14:45:15 +0800
Subject: [PATCH] [clang][analysis][NFC]place the comment to correct posi
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/117474
It is unclear for `ExprMutationAnalyzer::isUnevaluated` to accept 2 Stmt.
Redesign the API to accept only 1 Stmt and the API will only check whether stmt
is substmt of an unevaluated stmt.
>From b41b8eaa76
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/117474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/117481
Detected by misc-use-internal-linkage
>From 2d44ea29cb0cb51cebbd23ba49f8e424859ce46f Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Sun, 24 Nov 2024 20:23:55 +0800
Subject: [PATCH] [clang][analysis][NFC
701 - 800 of 1291 matches
Mail list logo
