HerrCai0907 wrote:
ping @erichkeane @AaronBallman @shafik @cor3ntin
https://github.com/llvm/llvm-project/pull/70886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/71640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -23,6 +23,10 @@ namespace clang::tidy::performance {
namespace {
+AST_MATCHER(EnumDecl, hasEnumerators) {
+ return Node.enumerator_begin() != Node.enumerator_end();
HerrCai0907 wrote:
```suggestion
return !Node.enumerators().empty();
```
https://githu
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/75061
Fixes: #71767
>From e710a0568c73e87296b4df03ac6746766bd87c3a Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 11 Dec 2023 23:32:32 +0800
Subject: [PATCH] [clang-tidy][misleading-indentation]ignore fals
@@ -15,6 +15,76 @@
namespace clang {
using namespace ast_matchers;
+static bool canResolveToExprImpl(const Expr *Node, const Expr *Target) {
+
+ const auto IgnoreDerivedToBase = [](const Expr *E, auto Matcher) {
+if (Matcher(E))
+ return true;
+if (const auto *Ca
@@ -15,6 +15,76 @@
namespace clang {
using namespace ast_matchers;
+static bool canResolveToExprImpl(const Expr *Node, const Expr *Target) {
HerrCai0907 wrote:
This function is hard to understand because it used matcher style naming but
logic operator style
@@ -15,6 +15,76 @@
namespace clang {
using namespace ast_matchers;
+static bool canResolveToExprImpl(const Expr *Node, const Expr *Target) {
+
+ const auto IgnoreDerivedToBase = [](const Expr *E, auto Matcher) {
+if (Matcher(E))
+ return true;
+if (const auto *Ca
=?utf-8?q?Bj=C3=B6rn?= Svensson
Message-ID:
In-Reply-To:
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/72553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/HerrCai0907 approved this pull request.
LGTM except release note
https://github.com/llvm/llvm-project/pull/70709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/70709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/70886
Fixes #21483
>From 73471336857b84c69e51d4561838e588c7162bfa Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 31 Oct 2023 17:27:35 +0800
Subject: [PATCH 1/2] [clang]get non-injected-class before findin
@@ -429,3 +429,19 @@ namespace qualified_friend_no_match {
friend void Y::f(double); // expected-error {{friend declaration of 'f'
does not match any declaration in 'qualified_friend_no_match::Y'}}
};
}
+
+namespace gh21483 {
+template
+struct B {
+ struct mixin {
+
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/70886
>From 73471336857b84c69e51d4561838e588c7162bfa Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 31 Oct 2023 17:27:35 +0800
Subject: [PATCH 1/3] [clang]get non-injected-class before finding instantiated
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/71006
isAssignmentToMemberOf will return `std::make_pair(nullptr, nullptr)` when
failed.
Using `std::optional` can describe failed case clearly.
>From 69b7688f56f7fe96031201eef1c3804f391c5abe Mon Sep 17 00:00:00 2
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/71006
>From 69b7688f56f7fe96031201eef1c3804f391c5abe Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 2 Nov 2023 08:49:22 +0800
Subject: [PATCH 1/2] [NFC][clang-tidy]refactor isAssignmentToMemberOf in
Prefer
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/71006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/70600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/75061
>From c3938da3a94ed9a9cc86d006d4b39dc5b73e7114 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 11 Dec 2023 23:32:32 +0800
Subject: [PATCH] [clang-tidy][misleading-indentation]ignore false-positives
fo
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/70886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/75061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/77073
Fixes: #77071
`SubstituteDeducedTypeTransform` will transform type and it will visit
uninstantiated `ExceptionSpecInfo`, which will cause odd behavior
>From 04ef8fd566491024c8163ad3b901f8c4cebaf890 Mon Sep 1
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/77073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/77073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/72705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/77335
using decls can be used in cpp
>From 39fae7adcdc97b4781911097f5f09c5bf8266d1c Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 9 Jan 2024 00:25:44 +0800
Subject: [PATCH] [clang-tidy]unused using decls
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/77335
>From 832bb78fd8cac372ec5560bb280f11e11be8d2e6 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 9 Jan 2024 00:41:33 +0800
Subject: [PATCH] [clang-tidy]unused using decls only check cpp files
---
clang
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/77335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/77416
Fixes: #77411
When substituting deduced type, noexcept expr in method should be instantiated
and evaluated.
ThisScrope should be switched to method context instead of origin sema context
>From 0637a482c881f5
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/77416
>From 0637a482c881f5ce31fd1debbc8dcc40a05c66ba Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 9 Jan 2024 14:53:25 +0800
Subject: [PATCH 1/3] [clang]use correct this scope to evaluate noexcept expr
wh
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/77416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/77587
Fixes: #77583
bcd51aaaf8bde4b0ae7a4155d9ce3dec78fe2598 fixed part of template instantiation
dependent name issues but still missing some cases This patch want to enhance
the dependent name check
>From f6b9a
@@ -0,0 +1,30 @@
+//===--- DonotreturnzerocheckCheck.h - clang-tidy ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,50 @@
+//===--- DonotreturnzerocheckCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,50 @@
+//===--- DonotreturnzerocheckCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,50 @@
+//===--- DonotreturnzerocheckCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/77587
>From f6b9afa26fabb5f9dcea5615c92914bed93ef474 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 10 Jan 2024 19:27:31 +0800
Subject: [PATCH 1/2] [clang]not lookup name containing a dependent type
Fixes:
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/77587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84922
>From d760b280a79be973642a0549db0e5a8838c397fd Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 12 Mar 2024 22:33:18 +0800
Subject: [PATCH 1/3] [clang-tidy]bugprone-unused-return-value ignore `++` and
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84922
>From d760b280a79be973642a0549db0e5a8838c397fd Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 12 Mar 2024 22:33:18 +0800
Subject: [PATCH 1/4] [clang-tidy]bugprone-unused-return-value ignore `++` and
@@ -169,16 +176,13 @@ void UnusedReturnValueCheck::registerMatchers(MatchFinder
*Finder) {
callee(functionDecl(
// Don't match void overloads of checked functions.
unless(returns(voidType())),
- // Don't match copy or move ass
HerrCai0907 wrote:
> Should this check really ignore postfix increment/decrement? Or maybe this
> check ignores it and a new check diagnoses `it++` vs `++it` (where possible).
> What are your thoughts on this?
@5chmidti What does `a new check diagnoses `it++` vs `++it` (where possible)`
mean
HerrCai0907 wrote:
It should be another check in maybe performance, since this check wants to
detect unused return instead of iterator.
https://github.com/llvm/llvm-project/pull/84922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/84922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/86129
Fixes: #85243.
>From 4e0845a143a820d4a68ffbdced206654c7593359 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 15 Mar 2024 08:07:47 +0800
Subject: [PATCH] [clang-tidy] add new check readability-enum-i
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/86129
>From 4e0845a143a820d4a68ffbdced206654c7593359 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 15 Mar 2024 08:07:47 +0800
Subject: [PATCH 1/2] [clang-tidy] add new check readability-enum-initial-value
@@ -0,0 +1,82 @@
+//===--- EnumInitialValueCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,82 @@
+//===--- EnumInitialValueCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/86129
>From 4e0845a143a820d4a68ffbdced206654c7593359 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 15 Mar 2024 08:07:47 +0800
Subject: [PATCH 1/5] [clang-tidy] add new check readability-enum-initial-value
@@ -0,0 +1,193 @@
+//===--- EnumInitialValueCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/86129
>From 4e0845a143a820d4a68ffbdced206654c7593359 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 15 Mar 2024 08:07:47 +0800
Subject: [PATCH 1/6] [clang-tidy] add new check readability-enum-initial-value
HerrCai0907 wrote:
> Try getting rid of findNextTokenSkippingComments, and maybe just jump to
> begin() + token width
Do you think it is a good idea to use
`ECD->getLocation().getLocWithOffset(ECD->getName().size())`?
https://github.com/llvm/llvm-project/pull/86129
___
HerrCai0907 wrote:
> > Try getting rid of findNextTokenSkippingComments, and maybe just jump to
> > begin() + token width
>
> Do you think it is a good idea to use
> `ECD->getLocation().getLocWithOffset(ECD->getName().size())`?
It doesn't work for macro. I think the most precise way is to fix
@@ -0,0 +1,199 @@
+//===--- EnumInitialValueCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/86129
>From 4e0845a143a820d4a68ffbdced206654c7593359 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 15 Mar 2024 08:07:47 +0800
Subject: [PATCH 1/7] [clang-tidy] add new check readability-enum-initial-value
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/86129
>From 4e0845a143a820d4a68ffbdced206654c7593359 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 15 Mar 2024 08:07:47 +0800
Subject: [PATCH 1/8] [clang-tidy] add new check readability-enum-initial-value
@@ -0,0 +1,200 @@
+//===--- EnumInitialValueCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/86129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/78598
>From 8fa3dc43e770025308da47f6aff309fa58c47fc3 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 18 Jan 2024 23:12:23 +0800
Subject: [PATCH 1/4] [clang] reject to capture variable in
`RequiresExprBodyDe
@@ -19706,22 +19706,29 @@ static void buildLambdaCaptureFixit(Sema &Sema,
LambdaScopeInfo *LSI,
}
}
+static DeclContext *ignoreReuquiresBodyDecl(DeclContext *DC) {
HerrCai0907 wrote:
I think inline it will be better since we only call it once.
https://git
@@ -0,0 +1,7 @@
+// RUN: %clang_cc1 -fsyntax-only -Wunused-lambda-capture
-Wused-but-marked-unused -Wno-uninitialized -verify -std=c++20 %s
+
+void test() {
+ int i;
+ auto explicit_by_value_unused_requires = [i] (auto) requires requires { i; }
{}; // expected-warning{{lambda
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/81560
Fixes: #77684.
>From 35dba54b1d6d158118c34d0f1bd8038b64c9bda4 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 13 Feb 2024 09:11:06 +0800
Subject: [PATCH] [clang-tidy] fix incorrect hint for InitListEx
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/81563
Fixes: #81419.
>From fefe52614837d14858d056783dca8b08745de9d4 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 13 Feb 2024 09:47:52 +0800
Subject: [PATCH] [clang-tidy] ignore local variable with [maybe
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/81563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/84095
Fixes: #84092
>From 160add4d95f34608a3d423482ad50fb45f6db522 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 6 Mar 2024 06:55:30 +0800
Subject: [PATCH 1/2] [clang-tidy][NFC]refactor AssertSideEffectCh
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84095
>From 160add4d95f34608a3d423482ad50fb45f6db522 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 6 Mar 2024 06:55:30 +0800
Subject: [PATCH 1/3] [clang-tidy][NFC]refactor AssertSideEffectCheck logic
---
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84095
>From 160add4d95f34608a3d423482ad50fb45f6db522 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 6 Mar 2024 06:55:30 +0800
Subject: [PATCH 1/4] [clang-tidy][NFC]refactor AssertSideEffectCheck logic
---
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/84095
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/83930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/84333
String without `$` end causes incorrectly match results, For example
`std::unique` can match `std::unique_ptr::unique_ptr`.
It causes false negative.
Fixes: #84314.
>From f96e0c7a37b0ef60e4a208725a40d0585c5
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/84333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84333
>From aaa9ea1db21b5de5d8be454ce1b1d05b219cccfc Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Mar 2024 23:28:40 +0800
Subject: [PATCH] [clang-tidy]avoid bugprone-unused-return-value false negative
https://github.com/HerrCai0907 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/77246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84333
>From aaa9ea1db21b5de5d8be454ce1b1d05b219cccfc Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Mar 2024 23:28:40 +0800
Subject: [PATCH 1/2] [clang-tidy]avoid bugprone-unused-return-value false
negat
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/84333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/84489
Fixes: #84480
We assuem assignemnt at most of time, operator overloading means the value is
assigned to the other variable, then clang-tidy should suppress warning even if
this operator overloading match the
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84489
>From 265db5ee772772bef4099cc97b69995cfa67b3f2 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 8 Mar 2024 22:15:20 +0800
Subject: [PATCH] [clang-tidy]avoid bugprone-unused-return-value false positive
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84489
>From 265db5ee772772bef4099cc97b69995cfa67b3f2 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 8 Mar 2024 22:15:20 +0800
Subject: [PATCH 1/2] [clang-tidy]avoid bugprone-unused-return-value false
posit
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84489
>From 265db5ee772772bef4099cc97b69995cfa67b3f2 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 8 Mar 2024 22:15:20 +0800
Subject: [PATCH 1/3] [clang-tidy]avoid bugprone-unused-return-value false
posit
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/84489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/84922
Fixes: #84705
>From d760b280a79be973642a0549db0e5a8838c397fd Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 12 Mar 2024 22:33:18 +0800
Subject: [PATCH] [clang-tidy]bugprone-unused-return-value ignor
HerrCai0907 wrote:
> Please mention changes in Release Notes.
release notes already includes this change.
https://github.com/llvm/llvm-project/pull/84922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/84922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84922
>From d760b280a79be973642a0549db0e5a8838c397fd Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 12 Mar 2024 22:33:18 +0800
Subject: [PATCH 1/2] [clang-tidy]bugprone-unused-return-value ignore `++` and
@@ -165,20 +165,20 @@ void
UnusedReturnValueCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
void UnusedReturnValueCheck::registerMatchers(MatchFinder *Finder) {
auto MatchedDirectCallExpr = expr(
- callExpr(
- callee(functionDecl(
- // Do
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/82952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/78598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/83055
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/82689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/82673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/83716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HerrCai0907 wrote:
I agree to fix false positive reported in #68105. But for capturing in lambda
be reference and do forward in lambda, It is just like create a record by ref
instead of using forward and do forward in some member function. I don't think
it is an expected false positive.
```c++
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/83930
Fixes: #83845
Capturing variable in lambda by reference and doing forward in lambda body are
like constructing a struct by reference and using std::forward in some member
function. It is dangerous if the lif
HerrCai0907 wrote:
> Capture by reference makes t in parameter same with it in lambda body
That is definitely wrong.
It will get an error for this code if address sanitize is enabled.
```c++
#include
#include
template
auto f(T &&t) {
return [&]() {
return std::forward(t);
};
}
stru
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/83987
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -156,7 +156,8 @@ Changes in existing checks
- Improved :doc:`cppcoreguidelines-missing-std-forward
` check by no longer
- giving false positives for deleted functions.
+ giving false positives for deleted functions and fix false negative when one
+ parameter is forward
https://github.com/HerrCai0907 approved this pull request.
LGTM since it is helpful to improve this check.
But I still take a negative view about use `std::forward` in lambda body.
https://github.com/llvm/llvm-project/pull/83987
___
cfe-commits mailing
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/71701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Danny =?utf-8?q?M=C3=B6sch?=
Message-ID:
In-Reply-To:
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/80537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
HerrCai0907 wrote:
ping @erichkeane @cor3ntin
https://github.com/llvm/llvm-project/pull/78598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 1258 matches
Mail list logo
