[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang-tools-extra.

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 updated this revision to Diff 551030. HerrCai0907 added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonConstPa

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 updated this revision to Diff 551344. HerrCai0907 added a comment. update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonCons

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

HerrCai0907 created this revision. HerrCai0907 added reviewers: njames93, PiotrZSL, aaron.ballman, Eugene.Zelenko. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-e

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

HerrCai0907 updated this revision to Diff 551379. HerrCai0907 added a comment. update release-note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158244/new/ https://reviews.llvm.org/D158244 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG9be33de4f397: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 updated this revision to Diff 551802. HerrCai0907 added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonConstParameterC

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

HerrCai0907 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixed:

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 updated this revision to Diff 552199. HerrCai0907 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonConstParameterC

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c9412441b87: [clang-tidy]mark record initList as non-const param (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

HerrCai0907 updated this revision to Diff 552227. HerrCai0907 added a comment. update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158480/new/ https://reviews.llvm.org/D158480 Files: clang-tools-extra/clang-tidy/readability/BracesA

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b6859dc89b9: [clang-tidy][readability-braces-around-statements] ignore false-positive for… (authored by HerrCai0907). Repository: rG LLVM Github

[PATCH] D151515: [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization

HerrCai0907 added a comment. ping @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D151515: [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization

HerrCai0907 abandoned this revision. HerrCai0907 added a comment. https://github.com/llvm/llvm-project/pull/65918 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515 __

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505096. HerrCai0907 added a comment. add more testcase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/fold_expr_typo.cpp Index:

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. Should I add release note in `clang/docs/ReleaseNotes.rst` or any other way? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505105. HerrCai0907 added a comment. add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505111. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/fold_expr_typo.cpp Index: clang/test/SemaCXX/

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505122. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/fold_expr_typo.cpp Index: clang/test/SemaCXX/

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505126. HerrCai0907 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/f

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505129. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/fold_expr_typo.cpp Index: clang/test/SemaCXX/

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505134. HerrCai0907 added a comment. rebase to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp clang/test/SemaCXX/f

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. I don't have write access now. Could you kindly help me to commit it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. HerrCai0907 and congcongcai0...@163.com Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. Hello Erichkeane, I have the access now, maybe I can push it by myself. Thanks again! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 ___ cfe-commits mailing list cfe-co

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe417f02b5159: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag (authored by HerrCai0907). Repository: rG LLVM Github Mono

[PATCH] D146885: [clang-tidy][NFC] add debug log when clean empty namespace

HerrCai0907 created this revision. HerrCai0907 added a reviewer: njames93. Herald added a subscriber: xazax.hun. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding debug log when clean empty name

[PATCH] D145834: typo statment to statement

HerrCai0907 created this revision. HerrCai0907 added a reviewer: aaron.ballman. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix typo in some comments Repository: rG LLVM Github Monorepo http

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 created this revision. HerrCai0907 added reviewers: erichkeane, aaron.ballman. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR #61326 CorrectDelayedTyposInExpr will clean all typo erro

[PATCH] D145834: typo statment to statement

HerrCai0907 added a comment. Thanks, you can use my name HerrCai0907 (congcongcai0...@163.com) as patch attribution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145834/new/ https://reviews.llvm.org/D145834 __

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. The idea is that: 1. If function return an invalid ExprResult, this error should be handled in the callee 2. If function return valid Expr, the potential error should be handled in the caller, in this case, is ActOnExprStmt. If callee handles error, when caller fin

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. I cannot find an example that throw `error: expression contains unexpanded parameter pack 'T'` in fold expression because code like ` (foo(10 + (static_cast(1))) + ...);` can be unpack both `T` and `U` in same `...` operator But this code can be diagnosed correctly

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. remove

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:70 + File.data() + LocInfo.second, File.end()); + L.SetCommentRetentionState(WithComment); + // Find the token. This part of code cop

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 marked 3 inline comments as done. HerrCai0907 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:49 const LangOptions &LangOpts) { // FIXME: This logic breaks when there is a c

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 509860. HerrCai0907 marked an inline comment as done. HerrCai0907 added a comment. refactor some code and add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/ https://reviews.llvm.org/

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

HerrCai0907 created this revision. HerrCai0907 added a reviewer: LegalizeAdulthood. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra.

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

HerrCai0907 added a comment. In D147315#4236403 , @PiotrZSL wrote: > Add test with scoped enums, to validate that it works correctly. > In theory this change should suport them also. scoped enum not support to visit by member. `EnumName::` is needed for

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

HerrCai0907 updated this revision to Diff 510241. HerrCai0907 added a comment. update description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147315/new/ https://reviews.llvm.org/D147315 Files: clang-tools-extra/clang-tidy/readability/StaticA

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

HerrCai0907 added a comment. In D147315#4238596 , @carlosgalvezp wrote: > Would it make sense to add a scoped enum to the test, to ensure it doesn't > warn/fix? It is not possible to visit scoped enum by instance. I think adding an invalid expression

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

This revision was automatically updated to reflect the committed changes. Closed by commit rGedd6a33984ee: [clang-tidy] support unscoped enumerations in readability-static-accessed… (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 510658. HerrCai0907 edited the summary of this revision. HerrCai0907 added a comment. add feature update close comment in fixhint update acc. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 511757. HerrCai0907 added a comment. Herald added a subscriber: ChuanqiXu. update according to comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/ https://reviews.llvm.org/D147194 Files: cl

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 511763. HerrCai0907 marked 4 inline comments as done. HerrCai0907 added a comment. reorder fixhint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/ https://reviews.llvm.org/D147194 Files: clang-

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 marked 2 inline comments as done. HerrCai0907 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:88 + StringRef TokText = getRawStringRef(TokRange, SM, LangOpts); + if (TokText != "// namespace " + ND->getNameA

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG92910a51b904: [clang-tidy] fix concat-nest-namespace fix hint remove the macro (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14719

[PATCH] D147843: [clang-tidy] fix hint use correct range to replace last NamespaceDecl

HerrCai0907 created this revision. HerrCai0907 added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a sub

[PATCH] D147843: [clang-tidy] fix hint use correct range to replace last NamespaceDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9b71d11b91: [clang-tidy] fix hint use correct range to replace last NamespaceDecl (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D147857: [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

HerrCai0907 created this revision. HerrCai0907 added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a sub

[PATCH] D147857: [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

HerrCai0907 added a comment. It should fix https://github.com/llvm/llvm-project/issues/57530 due to side effect instead of root cause.\ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147857/new/ https://reviews.llvm.org/D147857 ___

[PATCH] D147857: [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

HerrCai0907 updated this revision to Diff 512004. HerrCai0907 edited the summary of this revision. HerrCai0907 added a comment. merge items in release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147857/new/ https://reviews.llvm.org/D147857

[PATCH] D147857: [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf7fd8297bc: [clang-tidy] fix false positve for namespace with attrs in modernize-concat… (authored by HerrCai0907). Repository: rG LLVM Github M

[PATCH] D147893: [clang-tidy] avoid colon in namespace cause false positve

HerrCai0907 created this revision. HerrCai0907 added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a sub

[PATCH] D147893: [clang-tidy] avoid colon in namespace cause false positve

HerrCai0907 updated this revision to Diff 512116. HerrCai0907 added a comment. remove debug log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147893/new/ https://reviews.llvm.org/D147893 Files: clang-tools-extra/clang-tidy/modernize/ConcatNested

[PATCH] D147893: [clang-tidy] avoid colon in namespace cause false positve

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72777dc000ac: [clang-tidy] avoid colon in namespace cause false positve (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D147946: [clang-tidy] support inline namespace in c++20

HerrCai0907 created this revision. HerrCai0907 added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a sub

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

HerrCai0907 updated this revision to Diff 512165. HerrCai0907 added a comment. remove lamda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147946/new/ https://reviews.llvm.org/D147946 Files: clang-tools-extra/clang-tidy/modernize/ConcatNestedName

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

HerrCai0907 updated this revision to Diff 512231. HerrCai0907 added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147946/new/ https://reviews.llvm.org/D147946 Files: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespac

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

HerrCai0907 updated this revision to Diff 512541. HerrCai0907 added a comment. update acc. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147946/new/ https://reviews.llvm.org/D147946 Files: clang-tools-extra/clang-tidy/modernize/ConcatNe

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rG32aaacc609e7: [clang-tidy] support nested inline namespace in c++20 for modernize-concat… (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

HerrCai0907 created this revision. HerrCai0907 added reviewers: aaron.ballman, cjdb. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed: https://github.com/llvm/llvm-project/issues/62122 This chan

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

HerrCai0907 added a comment. > While this will fix the crash I am a little concerned that I don't a > diagnostic for each place we call ActOnParamDefaultArgumentError(...), there > is only once place where we diagnose this the rest don't. So I wonder if this > was purposeful or not. No, before

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 523870. HerrCai0907 added a comment. revert untill first version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 524001. HerrCai0907 added a comment. simplify test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. @rsmith could you review it again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D149612: [Sema] avoid merge error type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef107afd48a9: [Sema] avoid merge error type (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 updated this revision to Diff 524582. HerrCai0907 added a comment. update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sem

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5902ffc971: [Sema] `setInvalidDecl` for error deduction declaration (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 reopened this revision. HerrCai0907 added a comment. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 _

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 updated this revision to Diff 524824. HerrCai0907 added a comment. add std option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sem

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 updated this revision to Diff 524849. HerrCai0907 added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca9683651e52: [Sema] `setInvalidDecl` for error deduction declaration (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D151365: [Sema] cast to CXXRecoradDecl correctly when diag a default comparison method

HerrCai0907 created this revision. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed: https://github.com/llvm/llvm-project/issues/62791 in c++20, default comparison is supported. `getLexicalDeclC

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 added a comment. In D151365#4369605 , @erichkeane wrote: > As Richard says, we should just be taking the first parameter type and using > that instead (obviously de-qualified and removing reference if necessary). But we still can find the c

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525333. HerrCai0907 added a comment. change solution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTem

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525452. HerrCai0907 added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateInst

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525718. HerrCai0907 added a comment. Herald added subscribers: pmatos, asb, aheejin, jgravelle-google, sbc100, dschuff. getLocallyUnqualifiedSingleStepDesugaredType to find the whole record name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:969 << (int)DFK.asComparison() -<< Context.getTagDeclType( - cast(FD->getLexicalDeclContext())); +<< Context.getRecordType(RecordType->

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525752. HerrCai0907 added a comment. avoid desurger Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525754. HerrCai0907 added a comment. remove not related change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Se

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5df593a35471: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method (authored by HerrCai0907). Repository: rG LLVM Github M

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

HerrCai0907 created this revision. HerrCai0907 added reviewers: shafik, erichkeane, aaron.ballman. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed: https://github.com/llvm/llvm-project/issues/6

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

HerrCai0907 updated this revision to Diff 526245. HerrCai0907 added a comment. add cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515 Files: clang/lib/Sema/SemaInit.cpp clang/test/CodeGenCXX/cxx20-p

[PATCH] D151515: [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4433 +// where H is the initializer list. +Sequence.AddQualificationConversionStep(cv1T1, VK_XValue); + } erichkeane wrote: > Is `VK_XValue` correct here? The standar

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. ping @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added a comment. Dependent type for CPP is a common case due to template. But for `mergeTypes` in C, dependent type cannot be handled correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D14961

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 519671. HerrCai0907 added a comment. getConstantArrayType instal QualType() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 519675. HerrCai0907 added a comment. use nullpt as SizeExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2582 } else if (ArraySize->isTypeDependent() || ArraySize->isValueDependent()) { -T = Context.getDependentSizedArrayType(T, ArraySize, ASM, Quals, Brackets); +if (getLangOpts().CPlusPlus) { +

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 updated this revision to Diff 519847. HerrCai0907 added a comment. return Diag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/S

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 519972. HerrCai0907 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaType.cpp c

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added a comment. > So I'm still not sure this is the 'right' away about it. I think we should > instead properly handle the containsErrors case and just always create a > non-dependent sized array, except with the RecoveryExpr having the correct > type. You are right. Fix as your s

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2583 +if (ArraySize->containsErrors()) { + RecoveryExpr *RE = RecoveryExpr::Create( + Context, ArraySize->getType(), ArraySize->getBeginLoc(), erichkeane wrote: > Actuall

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 520496. HerrCai0907 marked 2 inline comments as done. HerrCai0907 added a comment. use 1 replace 0 as length Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 520807. HerrCai0907 added a comment. add more test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 520808. HerrCai0907 added a comment. add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sem

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2583 +if (ArraySize->containsErrors()) { + RecoveryExpr *RE = RecoveryExpr::Create( + Context, ArraySize->getType(), ArraySize->getBeginLoc(), erichkeane wrote: > HerrCai

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

  1   2   >