[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added inline comments. Comment at: clang/test/Driver/baremetal.cpp:348 +// RUN: %clang %s -### --target=powerpc-unknown-eabi 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-PPCEABI %s MaskRay wrote: > MaskRay wrote: > > Without a sysroot, we may pic

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther created this revision. cwalther added reviewers: MaskRay, jroelofs. cwalther added projects: clang, PowerPC. Herald added subscribers: luismarques, steven.zhang, s.egerton, shchenz, abidh, PkmX, simoncook, asb, kristof.beyls, arichardson, nemanjai. Herald added a project: All. cwalther re

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. Should I be worried about the build and test failures? At a glance, they look unrelated to my changes, so unless told otherwise I’m going to ignore them. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:168 + + if (Triple.getVendor() != llvm::Tr

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. Thanks for the comments. Yes, `powerpc-*-eabi` should be valid (sorry if I was unclear about that – my parenthetical was only about AArch64). There is a PowerPC EABI: https://www.nxp.com/docs/en/application-note/PPCEABI.pdf . I wouldn’t know if Clang/LLD obey it, but i

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. > I think `&&` is cleaner: `return Triple.getOS() == llvm::Triple::UnknownOS && > ...`; Totally agree. I was just following precedent there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther updated this revision to Diff 539033. cwalther added a comment. Updated patch according to current discussion: - remove check for vendor, any vendor is accepted - replace cascaded `if` by `&&` - rebase on main a3f9ce6

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther updated this revision to Diff 539132. cwalther added a comment. Oops, forgot to run git-clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org/D154357 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/test/Driver/baremetal.cpp

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. I am unable to provoke any problem with my tests by putting various things in `/usr/lib/gcc/`, and I also can’t find any code that would go looking there on the code path that is exercised by these tests. Can you give me a hint where that code is, so I can try harder t

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. That summary wasn’t intended to be a commit message at all, but a description of the problem and start of the discussion. My commit message was part of the uploaded patch (since I generated it using `git show`) and said > [Driver] Recognize powerpc-*-unknown-eabi as a

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. I have gone ahead and removed the last paragraph of the summary, assuming that was what was requested. Happy to make other edits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org/D154357 __

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. Okay. No, I don’t have write access (as far as I know) and would appreciate if you (or any other maintainer) could land the patch, with any commit message you deem appropriate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. Christian Walther CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org/D154357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. Thank you! So I guess next time I submit a patch here (nothing planned at the moment), I should put the proposed commit message into the summary field and the backstory and start of discussion / open questions into a first comment. But maybe the point is moot as I und