[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-31 Thread Christian Kandeler via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbbddbe580bca: [clangd] Add semantic token for angle brackets (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://revi

[PATCH] D143260: [clangd] Add semantic token for labels

2023-02-03 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

2023-01-16 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D139926#4056585 , @kadircet wrote: > Especially as this comes as two different `HighlightingKind`s and they're > likely to get colored differently, and having your matching brackets in > different colors is quite annoying.

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-17 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 489722. ckandeler marked 2 inline comments as done. ckandeler retitled this revision from "[clangd] Add semantic tokens for angle brackets" to "[clangd] Add semantic token for angle brackets". ckandeler added a comment. Added test cases, merged the two High

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-19 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 490457. ckandeler marked 2 inline comments as done. ckandeler added a comment. Made token name more generic, added test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.or

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-19 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D139926#4064769 , @kadircet wrote: >> We can easily check the actual character at the given position in the >> client, so I could just merge the two highlighting kinds. > > Thanks! Note that it might not be as easy at the fa

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

2023-01-19 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. With this, I now get: FAILED: bin/clangd-fuzzer : && /usr/lib/icecream/libexec/icecc/bin/c++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializer

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

2022-06-12 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:847-849 +} else if (const auto Iface = + dyn_cast(Decl)) { + if (Iface->isThisDeclarationADefinition()) dgoldman wrot

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

2022-06-14 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 436678. ckandeler added a comment. Objective-C improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files: clang-tools-extra/clangd/SemanticHighlighting.

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

2022-06-22 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. There's no reason that argum

[PATCH] D127217: [include-cleaner] Fix build error in unit test

2022-06-07 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. ckandeler requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D127217: [include-cleaner] Fix build error in unit test

2022-06-09 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. Can you please merge it? I don't have the rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127217/new/ https://reviews.llvm.org/D127217 ___ cfe-commits mailing list cfe-co

[PATCH] D127397: [pseudo] Fix unit test build

2022-06-09 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. ckandeler added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Analogous to 632545e8ce8

[PATCH] D127397: [pseudo] Fix unit test build

2022-06-09 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. Can you please merge it? I don't have the rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127397/new/ https://reviews.llvm.org/D127397 ___ cfe-commits mailing list cfe-co

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

2022-06-09 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

2022-06-09 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 435547. ckandeler added a comment. Indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang-t

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

2022-06-09 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 435561. ckandeler added a comment. Addressed clang-format complaints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files: clang-tools-extra/clangd/SemanticHigh

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-07-28 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 545054. ckandeler added a comment. Addressed review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files: clang-tools-extra/clangd/unittests/XRefsTests.

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-07-28 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:150 +ParentDC, +unsigned(SymbolRole::NameReference)); + } kadircet wrote: > nridge wrote: > > `NameReference` was i

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-07-31 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 545551. ckandeler added a comment. Addressed another review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files: clang-tools-extra/clangd/unittests/XRe

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-08-01 Thread Christian Kandeler via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG535f34dd80c2: [index][clangd] Consider labels when indexing function bodies (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-08-01 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. Build failures seem unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-11-21 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D136594#3940143 , @nridge wrote: > A couple of high-level thoughts on this: > > 1. Based on the discussion in https://github.com/clangd/clangd/issues/1115, I > believe highlighting of **built-in** operators should be out of

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-11-21 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, sammccall wrote: > sammccall wrote: > > sammccall wrote: > > > Can you give some background here or on the bug tracker a

[PATCH] D137943: [clangd] Mark "override" and "final" as modifiers

2022-11-21 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 476843. ckandeler marked 3 inline comments as done. ckandeler retitled this revision from "[clangd] Mark "override" and "final" as keywords" to "[clangd] Mark "override" and "final" as modifiers". ckandeler edited the summary of this revision. ckandeler adde

[PATCH] D137943: [clangd] Mark "override" and "final" as modifiers

2022-11-21 Thread Christian Kandeler via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG699a59aa5865: [clangd] Mark "override" and "final" as modifiers (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-11-22 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 477178. ckandeler added a comment. Make highlighting of built-in operators conditional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files: clang-tools-extra/cl

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-11-22 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. > Should I perhaps add the augmentsSyntaxTokens option and rebase this patch to > make it its first user? So I went ahead and did this. Opinions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-11-25 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D136594#3950334 , @nridge wrote: > The current patch will produce an operator token in the operator case but not > the declarator case, thereby achieving an effect that client-side > highlighting couldn't. As such, I guess

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-11-25 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 477919. ckandeler added a comment. Added template example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files: clang-tools-extra/clangd/SemanticHighlighting.cp

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-11-25 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, sammccall wrote: > sammccall wrote: > > nridge wrote: > > > ckandeler wrote: > > > > ckandeler wrote: > > > > > sammccall w

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-11-25 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, sammccall wrote: > ckandeler wrote: > > sammccall wrote: > > > sammccall wrote: > > > > nridge wrote: > > > > > ckandele

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-11-28 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 478146. ckandeler added a comment. Using operators on expressions with dependent types now considered "complex", Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Fil

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-11-28 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. Now seems to do what we want. Should I switch the modifier around? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 ___ cfe-commits ma

[PATCH] D143260: [clangd] Add semantic token for labels

2023-02-27 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143260/new/ https://reviews.llvm.org/D143260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D143260: [clangd] Add semantic token for labels

2023-04-12 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. Hello? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143260/new/ https://reviews.llvm.org/D143260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D143260: [clangd] Add semantic token for labels

2023-04-14 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In my opinion, it is not possible to have a competitive client if you limit yourself to the official LSP feature set; you just need language-specific extensions in practice. And while of course not every silly idea should be blindly accepted, I think this "lowest comm

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

2023-05-22 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:519 +if (RenameDecl.getKind() != Decl::Function && +RenameDecl.getKind() != Decl::CXXMethod) { if (auto *Conflict = lookupSiblingWithName(ASTCtx, RenameDecl, NewName)) ---

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

2023-05-22 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 524203. ckandeler added a comment. Added test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/new/ https://reviews.llvm.org/D150685 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-t

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

2023-05-22 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 524206. ckandeler added a comment. Formatting glitch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/new/ https://reviews.llvm.org/D150685 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

2023-05-22 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 524214. ckandeler added a comment. Fixed clang-format complaints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/new/ https://reviews.llvm.org/D150685 Files: clang-tools-extra/clangd/refactor/Rename.

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

2023-05-22 Thread Christian Kandeler via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG008cb29f87f3: [clangd] Renaming: Treat member functions like other functions (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/ne

[PATCH] D143260: [clangd] Add semantic token for labels

2023-02-13 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D143260#4122523 , @kadircet wrote: > at hindsight i can't see why `goto X;` and `X:` is not enough for clients to > implement this without any need for semantic analysis. are there contexts > where this kind of syntactical

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-05-08 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. ckandeler added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added projects: clang, clang-tools-extra. It's

[PATCH] D143260: [clangd] Add semantic token for labels

2023-05-09 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D143260#4328948 , @kadircet wrote: > Considering that we have added a bunch of token kinds, let me ask you another > question then, how many more new token kinds do we expect to have? e.g. if > label is the last one sure, b

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-05-11 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D150124#4329163 , @ilya-biryukov wrote: > In `clangd` we also have `findExplicitReferences` and `targetDecl` functions > that seem to handle the `GoToStmt`. According to the commit message of the patch that added this, it

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-05-12 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 521577. ckandeler marked 2 inline comments as done. ckandeler added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files: c

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

2023-05-16 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. ckandeler added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. ...

[PATCH] D143260: [clangd] Add semantic token for labels

2023-06-07 Thread Christian Kandeler via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe72baa76b91f: [clangd] Add semantic token for labels (authored by ckandeler). Changed prior to commit: https://reviews.llvm.org/D143260?vs=494583&id=529234#toc Repository: rG LLVM Github Monorepo CH

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

2023-06-12 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-12-05 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-12-06 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D136594#3973812 , @sammccall wrote: > For my part, I still need to understand why we want the > `builtin`/`UserModified` modifier. (The `operator` highlight kind seems > obvious to me). We make this distinction in our clie

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-12-12 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 482055. ckandeler added a comment. Added more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-12-12 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D136594#3987852 , @nridge wrote: > - Does the implementation handle explicit operator calls, e.g. > `a.operator+(b)`? If so, it would be nice to add some test coverage. It does now. Repository: rG LLVM Github Monorepo

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-12-12 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 482103. ckandeler added a comment. Renamed modifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cl

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-12-12 Thread Christian Kandeler via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG647d314eb059: [clangd] Add support for semantic token type "operator" (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ htt

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

2022-12-13 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

2022-12-13 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D136594#3991530 , @hokein wrote: > This patch causes a clangd crash on dependent code (e.g. running on > `ASTMatchers.h`), fixed in > https://github.com/llvm/llvm-project/commit/bcb457c68e20120f0bdd0a59e4b4ce90b8121310. Th

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

2022-12-13 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 482422. ckandeler added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang-tools

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

2022-02-02 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fall-through is no

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

2022-02-02 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 405240. ckandeler added a comment. Fixed unintentional whitespace change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118782/new/ https://reviews.llvm.org/D118782 Files: clang-tools-extra/clangd/refactor

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 339948. ckandeler added a comment. Herald added a subscriber: cfe-commits. Addressed clang-tidy and clang-format comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D10

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 339994. ckandeler added a comment. Fixed TU traversal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D101057 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-too

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 339995. ckandeler marked 2 inline comments as done. ckandeler added a comment. "top-level" -> "root" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D101057 Files: clang-

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 340014. ckandeler added a comment. Fixed remaining issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101057/new/ https://reviews.llvm.org/D101057 Files: clang-tools-extra/clangd/ClangdServer.cpp clang

[PATCH] D101057: [clangd] Allow AST request without range

2021-04-23 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D101057#2711997 , @sammccall wrote: > Want me to land this for you? Yes, please. I don't have push privileges. Thanks for the prompt and helpful review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

2021-04-30 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. According to the s

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

2021-05-03 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. Would you mind pushing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101616/new/ https://reviews.llvm.org/D101616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

2021-05-10 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. ping. Any chance of getting this pushed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101616/new/ https://reviews.llvm.org/D101616 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

2021-05-10 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. No problem, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101616/new/ https://reviews.llvm.org/D101616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

<    1   2