[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

ckandeler created this revision. ckandeler added a reviewer: nik. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Let this function (try to) evaluate expressions, in addition to declarations and compound statements. Repository: rG LLVM Github Monorepo https://r

[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

ckandeler added a comment. Thanks for the quick review. I don't have commit access, so can someone please commit it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80279/new/ https://reviews.llvm.org/D80279 ___

[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

ckandeler added a comment. A kind reminder that I need someone with commit rights to merge this for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80279/new/ https://reviews.llvm.org/D80279 ___ cfe-

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler added a comment. I suppose it boils down to whether the visit() function is supposed to except null arguments or not. Since I don't know the answer to that, I added the check at the caller. From the description of the linked patch, it appears that other places are also calling the fun

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler added a comment. In D82629#2134521 , @jkorous wrote: > @ckandeler do you have commit access or do you want me to land the patch? I do not, so it'd be great if you could do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler created this revision. ckandeler added a reviewer: milianw. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. When a variable-length array is being captured in a lambda, the AST contains two captures, the first one having a null init expression. Visiting tha

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler updated this revision to Diff 274071. ckandeler added a comment. Fixed formatting issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82629/new/ https://reviews.llvm.org/D82629 Files: clang/test/Index/evaluate-cursor.cpp clang/tool

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:863 + Tok.addModifier(HighlightingModifier::Declaration); +if (const auto Func = dyn_cast(Decl)) { + if (Func->isThisDeclarationADefinition())

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

ckandeler updated this revision to Diff 440650. ckandeler marked 2 inline comments as done. ckandeler added a comment. Improvements as per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128329/new/ https://reviews.llvm.org/D128329

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

ckandeler added a comment. In D128329#3617172 , @nridge wrote: > I'm going to take the liberty of approving this, as it seems straightforward > and unlikely to be contentious in any way. Thanks! > Please let me know if you need me to commit it. Yes, p

[PATCH] D128892: [clangd] Also mark output arguments of array subscript expressions

ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. ... with the "usedAsMutableR

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. That is, mark constructor pa

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler updated this revision to Diff 442257. ckandeler marked 4 inline comments as done. ckandeler added a comment. Implemented reviewer suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977 Fil

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:541 + return Base::TraverseConstructorInitializer(Init); +if (const auto Member = Init->getMember()) { + const auto MemberType = Member->getType(); nridge

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. Note that the build failure seems unrelated, as it's due to a failing clang-tidy test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977 _

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. Can you please merge it as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. In D128977#3638198 , @nridge wrote: > Yes, I plan to. I'm just building it locally to verify the tests are passing. > (And sometimes, for reasons I don't understand, LLVM's build system triggers > a full rebuild even though I'

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 448655. ckandeler added a comment. Addressed remaining Objective-C issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files: clang-tools-extra/clangd/Semantic

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/ https://reviews.llvm.org/D130015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler created this revision. ckandeler added reviewers: sammccall, nridge. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: cl

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added a comment. IMO the relevant point is the (non-)const-ness of the corresponding parameter, i.e. can the passed object get mutated or not. The fact that there's an ampersand at the call site (which is not even the case if the variable is itself a pointer) does not tell me that.

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler updated this revision to Diff 451420. ckandeler marked an inline comment as done. ckandeler added a comment. Fixed style issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/ https://reviews.llvm.org/D130015 Files: clang-to

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:603 H.addExtraModifier(*Location, - HighlightingModifier::UsedAsMutableReference); + IsRef ? HighlightingModifier::UsedAsMutableRe

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. ... if there is a

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

ckandeler updated this revision to Diff 405893. ckandeler added a comment. Improved code as per review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118782/new/ https://reviews.llvm.org/D118782 Files: clang-tools-extra/clangd/refactor/t

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler added a comment. > This is assuming a semantic connection that we don't know exists. > Without any more specific reason to draw this connection, this seems like a > heuristic that could equally be applied by the client. The difference being that the client would have to poke around in

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler updated this revision to Diff 405911. ckandeler added a comment. Formatting & logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118976/new/ https://reviews.llvm.org/D118976 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp Index

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1011 // We never consider refactorings etc as preferred. CodeAction *OnlyFix = nullptr; for (auto &Action : Actions) { sammccall wrote: > This loo

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler updated this revision to Diff 405929. ckandeler added a comment. Simplified code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118976/new/ https://reviews.llvm.org/D118976 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp Index: c

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

ckandeler abandoned this revision. ckandeler added a comment. Fair enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118782/new/ https://reviews.llvm.org/D118782 ___ cfe-commits mailing list cfe-comm

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler updated this revision to Diff 406359. ckandeler added a comment. Fixed Lint complaints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118976/new/ https://reviews.llvm.org/D118976 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp Ind

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler added a comment. It'd be great if you could merge this, as I don't have the necessary privileges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118976/new/ https://reviews.llvm.org/D118976 ___

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Counterpart to "usedAsMutabl

[PATCH] D110324: clangd: Do not report inline overrides twice

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. ... in textDocumen

[PATCH] D110324: clangd: Do not report inline overrides twice

ckandeler updated this revision to Diff 374520. ckandeler added a comment. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110324/new/ https://reviews.llvm.org/D110324 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra

[PATCH] D110324: clangd: Do not report inline overrides twice

ckandeler updated this revision to Diff 374526. ckandeler added a comment. Re-formatting, take two. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110324/new/ https://reviews.llvm.org/D110324 Files: clang-tools-extra/clangd/XRefs.cpp clang-tool

[PATCH] D110324: clangd: Do not report inline overrides twice

ckandeler added a comment. Can you please merge it, too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110324/new/ https://reviews.llvm.org/D110324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110324: clangd: Do not report inline overrides twice

ckandeler added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110324/new/ https://reviews.llvm.org/D110324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D107137: clangd: Provide hover info for include directives

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. It's quite useful

[PATCH] D107145: clangd: Add new semantic token modifier "virtual"

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is needed for

[PATCH] D107145: clangd: Add new semantic token modifier "virtual"

ckandeler updated this revision to Diff 363031. ckandeler added a comment. Extended test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107145/new/ https://reviews.llvm.org/D107145 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp c

[PATCH] D107137: clangd: Provide hover info for include directives

ckandeler updated this revision to Diff 363083. ckandeler added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107137/new/ https://reviews.llvm.org/D107137 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-ext

[PATCH] D107145: clangd: Add new semantic token modifier "virtual"

ckandeler updated this revision to Diff 363106. ckandeler added a comment. Fixed lit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107145/new/ https://reviews.llvm.org/D107145 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cla

[PATCH] D107137: clangd: Provide hover info for include directives

ckandeler updated this revision to Diff 363442. ckandeler added a comment. Addressed lint comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107137/new/ https://reviews.llvm.org/D107137 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D107145: clangd: Add new semantic token modifier "virtual"

ckandeler added a comment. Can someone please merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107145/new/ https://reviews.llvm.org/D107145 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D107365: clangd: Make documentation property of completion items more similar

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. ... to the one of

[PATCH] D107145: clangd: Add new semantic token modifier "virtual"

ckandeler added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107145/new/ https://reviews.llvm.org/D107145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D107365: clangd: Make documentation property of completion items more similar

ckandeler updated this revision to Diff 364412. ckandeler added a comment. Addressed lint complaints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107365/new/ https://reviews.llvm.org/D107365 Files: clang-tools-extra/clangd/CodeComplete.cpp I

[PATCH] D107365: clangd: Make documentation property of completion items more similar

ckandeler updated this revision to Diff 364790. ckandeler added a comment. Added test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107365/new/ https://reviews.llvm.org/D107365 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-t

[PATCH] D107137: clangd: Provide hover info for include directives

ckandeler added a comment. Thanks for the review. Can you please merge it? I don't have the permissions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107137/new/ https://reviews.llvm.org/D107137 ___ cfe

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler created this revision. ckandeler added a reviewer: sammccall. ckandeler requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Real-world use case: The Qt framework's headers have the same name as the respective class defined in them, an

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. I hope this isn't too controversial. After all, the files are located in include directories, so there shouldn't be any random garbage getting picked up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. > WDYT about detecting QT headers specifically? It seems hacky, but I don't see > a way out of this that doesn't involve hardcoding some filenames. Are they in > a directory like `"qt-11/QFoo"` that we can recognize? Even Q followed by > another capital letter might b

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler updated this revision to Diff 384407. ckandeler added a comment. Limited the matching to Qt headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. >> For framework builds, the directory would be "Headers", which also seems >> safe. > > I agree extensionless headers in frameworks seem fine to show. > We already know which includepath entries are frameworks, so we can just use > that info directly (see line 9674)

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler updated this revision to Diff 384485. ckandeler added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 Files: clang/lib/Sema/SemaCodeComplete.cpp Index: clang/l

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:9619 +const bool ExtensionlessHeaders = IsSystem || isQt +|| Dir.endswith(".framework/Headers"); std::error_code EC; I'm just noticing that this is often a symlink i

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. In D112996#3106459 , @sammccall wrote: > can we the tests again though? Sorry, I don't understand what you mean by that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler updated this revision to Diff 385453. ckandeler added a comment. Addressed formatting comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 Files: clang/lib/Sema/SemaCodeComplete.cpp Ind

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. Can someone please merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler updated this revision to Diff 385826. ckandeler added a comment. Added test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeC

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. In D127403#3863713 , @nridge wrote: > In D127403#3863686 , @thakis wrote: > >> In D127403#3863641 , @nridge wrote: >> >>> Landed https://reviews

[PATCH] D134728: [clangd] Add highlighting modifier "constructorOrDestructor"

ckandeler updated this revision to Diff 468465. ckandeler retitled this revision from "[clangd] Add highlighting modifiers "constructor" and "destructor"" to "[clangd] Add highlighting modifier "constructorOrDestructor"". ckandeler edited the summary of this revision. ckandeler added a comment.

[PATCH] D134728: [clangd] Add highlighting modifier "constructorOrDestructor"

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b3668754c88: [clangd] Add highlighting modifier "constructorOrDestructor" (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134728/new/

[PATCH] D136454: [clangd] Make file limit for textDocument/rename configurable

ckandeler created this revision. ckandeler added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Without th

[PATCH] D136454: [clangd] Make file limit for textDocument/rename configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ed4a543b8b3: [clangd] Make file limit for textDocument/rename configurable (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136454/new

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:546 + bool VisitPredefinedExpr(PredefinedExpr *E) { +H.addToken(E->getLocation(), HighlightingKind::Macro); +return true; sammccall wrote: > actually, would Hi

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler updated this revision to Diff 453648. ckandeler added a comment. Use variable instead of macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131175/new/ https://reviews.llvm.org/D131175 Files: clang-tools-extra/clangd/SemanticHighligh

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler marked an inline comment as not done. ckandeler added a comment. Thanks for the review. Can you please merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131175/new/ https://reviews.llvm.org/D131175 _

[PATCH] D132135: [clangd] Support hover on __func__ etc (PredefinedExpr)

ckandeler accepted this revision. ckandeler added a comment. This revision is now accepted and ready to land. Works fine for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132135/new/ https://reviews.llvm.org/D132135 ___

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler added a comment. By the way: How do I change the commit message when using arc? It seems to ignore all subsequent changes other than in the code itself, and now the patch is in the repo with a misleading commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

ckandeler added a comment. In D134728#3822653 , @sammccall wrote: > It doesn't scale very well though: we're limited to 30 modifiers in total, > this patch brings us up to 16, if we followed this class.constructor > precedent for function.operator, clas

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

ckandeler added a comment. In D134728#3822898 , @sammccall wrote: > If the distinction isn't important, maybe we should add a single "constructor > or destructor" modifier... No, it's not. I will update the patch accordingly. Repository: rG LLVM Git

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 464170. ckandeler marked 3 inline comments as done. ckandeler added a comment. Adapted according to latest comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:79 + if (auto *Var = dyn_cast(Decl)) +return !isa(Var) && Var->isThisDeclarationADefinition(); + return isa(Decl) || isa(Decl); I'm not 100% sure about this one,

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. So, is this okay to merge now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 466510. ckandeler marked 2 inline comments as done. ckandeler added a comment. Use modifier also for parameters, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Fil

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 466731. ckandeler added a comment. Template parameters are definitions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files: clang-tools-extra/clangd/SemanticHig

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. Everything good now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. Could you please land it for me? I don't have the privileges. (How does one attain those, by the way?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 _

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler added a comment. In D139926#4030782 , @nridge wrote: > It's true that there is an ambiguity between `<` and `>` as operators, vs. > template arg/param list delimiters, but, at least in terms of user > understanding of code, my sense is that th

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler added a comment. In D139926#4033152 , @nridge wrote: > In D139926#4032473 , @ckandeler > wrote: > >> In D139926#4030782 , @nridge wrote: >> >>> It's true that t

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:592 + Arg = IC->getSubExprAsWritten(); +if (auto *UO = dyn_cast(Arg)) { + if (UO->getOpcode() == UO_AddrOf) nridge wrote: > Could you add a test case that

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler updated this revision to Diff 473603. ckandeler marked an inline comment as done. ckandeler added a comment. Rebased and updated comment as indicated in review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/ https://reviews.llv

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bf960aef08e: [clangd] Add "usedAsMutablePointer" highlighting modifier (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/ h

[PATCH] D137943: [clangd] Mark "override" and "final" as keywords

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 491718. ckandeler marked an inline comment as done. ckandeler added a comment. Added test cases from review comment and made them pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://review

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. Thanks for the test cases! All fixed, except: > // variable template specialization > // parameter and argument lists are missing semantic tokens > template <> > constexpr int V = 5; Argument list fixed. I didn't manage to make the parameter list work. Repository:

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. In D139926#4076057 , @nridge wrote: > One other thought that has occurred to me is that as we add more semantic > tolens for punctuation, the test cases in `GetsCorrectTokens` become harder > to read. > > What would you think

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. In D139926#4084801 , @nridge wrote: > Function calls are still missing some cases: > > I would have expected these to be handled by VisitDeclRefExpr(), but they aren't. Any idea? Repository: rG LLVM Github Monorepo CHA

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 492670. ckandeler marked 3 inline comments as done. ckandeler added a comment. Handled more cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files: clang-to

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. In D139926#4084868 , @nridge wrote: > I figured I might as well look through the AST API for classes with > getLAngleLoc/getRAngleLoc methods. > > It looks like we've got almost all of them (including the ones mentioned in > r

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:1026 +concept $Concept_decl[[C2]] = true; +template $Bracket[[<]]C2$Bracket[[<]]int$Bracket[[>]] $TemplateParameter_def[[A]]$Bracket[[>]] +class

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 493247. ckandeler added a comment. Support more cases as per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files: clang-tools-extra/clangd/Sema

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 493594. ckandeler marked an inline comment as done. ckandeler added a comment. Improved implementation as per review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:382 + +// For the inner element of a nested template instantiation with no space +// between the '>' characters, TemplateSpecializationLocInfo::RAngleLoc has ka

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 493610. ckandeler added a comment. Incorporated review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files: clang-tools-extra/clangd/SemanticHighlighti

  1   2   >