Author: bruno
Date: Fri Aug 17 20:22:11 2018
New Revision: 340117
URL: http://llvm.org/viewvc/llvm-project?rev=340117&view=rev
Log:
Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker"
This reverts commit a786521fa66c72edd308baff0c08961b6d964fb1.
Bots haven't caught up
Hi George,
This broke the modules build, reverted in r340117 for now. I can help
you figure out any module map change if necessary next week.
Thanks,
On Fri, Aug 17, 2018 at 6:46 PM George Karpenkov via cfe-commits
wrote:
>
> Author: george.karpenkov
> Date: Fri Aug 17 18:45:50 2018
> New Revisi
Author: bruno
Date: Wed May 16 10:00:24 2018
New Revision: 332491
URL: http://llvm.org/viewvc/llvm-project?rev=332491&view=rev
Log:
[Modules] Do not diagnose missing import in recovery mode if there isn't a decl
to lookup
Clang often tries to create implicit module import for error recovery,
whi
On Fri, May 18, 2018 at 11:54 AM Vedant Kumar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On May 18, 2018, at 11:48 AM, Eric Liu wrote:
>
>
> So I have reverted this with r332751.
>
>
> Thanks!
>
>
> I can't see how this introduced cyclic dependencies in module build, as
> the dependen
On Fri, May 18, 2018 at 12:46 PM Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
>
>
> On Fri, May 18, 2018 at 11:54 AM Vedant Kumar via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On May 18, 2018, at 11:48 AM, Eric Liu wrote:
>>
>>
>> So I have reverted this with r332751.
>>
>>
Hi,
On Mon, Oct 9, 2017 at 9:58 AM, Ilya Biryukov via cfe-commits
wrote:
> Author: ibiryukov
> Date: Mon Oct 9 09:58:16 2017
> New Revision: 315214
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315214&view=rev
> Log:
> [clangd] Added a command-line arg to mirror clangd input into a file.
>
>
Author: bruno
Date: Mon Oct 9 13:22:05 2017
New Revision: 315242
URL: http://llvm.org/viewvc/llvm-project?rev=315242&view=rev
Log:
Revert r315214 since diff -Z isn't portable, this is breaking:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive
http://green.lab.llvm.org/green/jo
Hi Egor,
On Tue, Mar 21, 2017 at 6:20 AM, Egor Churaev via cfe-commits
wrote:
> Author: echuraev
> Date: Tue Mar 21 08:20:57 2017
> New Revision: 298369
>
> URL: http://llvm.org/viewvc/llvm-project?rev=298369&view=rev
> Log:
> [OpenCL] Added diagnostic for checking length of vector
>
> Reviewers:
On Tue, Oct 10, 2017 at 2:08 AM, Ilya Biryukov via cfe-commits
wrote:
> Author: ibiryukov
> Date: Tue Oct 10 02:08:47 2017
> New Revision: 315287
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315287&view=rev
> Log:
> Revert "Revert r315214 since diff -Z isn't portable, this is breaking:"
>
> Th
On Thu, Oct 12, 2017 at 8:39 AM, Anastasia Stulova
wrote:
>
> I think this bit is a bit confusing to us. Some of our original OpenCL
> checks were removed in some places because in some cases OpenCL semantic was
> adopted elsewhere.
It's confusing indeed. We should probably enhance the docs for
s
Author: bruno
Date: Fri Oct 13 10:11:13 2017
New Revision: 315712
URL: http://llvm.org/viewvc/llvm-project?rev=315712&view=rev
Log:
Revert "[lit] Raise the logic for enabling clang & lld substitutions to llvm."
This reverts commit r315627, fixing bot failures:
http://green.lab.llvm.org/green/job/
Hi Zachary,
I reverted this in r315712, since it's making one of our bots red
since yesterday (more explanations in the commit):
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA
Cheers,
On Thu, Oct 12, 2017 at 2:56 PM, Zachary Turner via cfe-commits
wrote:
> Author: zturner
> Date:
Author: bruno
Date: Sat Oct 14 15:14:23 2017
New Revision: 315829
URL: http://llvm.org/viewvc/llvm-project?rev=315829&view=rev
Log:
Mark test as unsupported until r315808 is fixed
This is causing:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/43381
Modified:
cfe/trunk
Hi Eric,
This is also failing
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/39697/
Can you take a look?
Thanks,
On Tue, Oct 17, 2017 at 9:07 AM, Eric Fiselier via cfe-commits
wrote:
> These shadowing warnings should be fixed now.
>
> /Eric
>
> On Tue, Oct 17, 2017 at 10:03 AM,
Author: bruno
Date: Tue Oct 17 10:54:57 2017
New Revision: 316016
URL: http://llvm.org/viewvc/llvm-project?rev=316016&view=rev
Log:
[OpenCL] Restrict swizzle length check to OpenCL mode
Changes behavior introduced in r298369 to only error out on
vector component invalid length access on OpenCL mo
Author: bruno
Date: Mon Sep 10 22:17:13 2018
New Revision: 341902
URL: http://llvm.org/viewvc/llvm-project?rev=341902&view=rev
Log:
[Modules] Add imported modules to the output of -module-file-info
Fix a bug in the deserialization of IMPORTS section and allow for
imported modules to also be print
Author: bruno
Date: Thu Jul 19 05:32:06 2018
New Revision: 337447
URL: http://llvm.org/viewvc/llvm-project?rev=337447&view=rev
Log:
[PCH+Modules] Load -fmodule-map-file content before including PCHs
Consider:
1) Generate PCH with -fmodules and -fmodule-map-file
2) Use PCH with -fmodules and the s
Author: bruno
Date: Fri Jul 20 07:46:10 2018
New Revision: 337555
URL: http://llvm.org/viewvc/llvm-project?rev=337555&view=rev
Log:
[www] Add CodeCompass and CodeChecker to Clang Related Projects page
Modified:
cfe/trunk/www/related.html
Modified: cfe/trunk/www/related.html
URL:
http://llvm
Author: bruno
Date: Mon Feb 12 15:43:21 2018
New Revision: 324965
URL: http://llvm.org/viewvc/llvm-project?rev=324965&view=rev
Log:
[Modules] Fix remapping from Foo.Private to Foo_Private to happen before typo
correction
Typo correction is the last step here, remapping should come first.
rdar:/
Author: bruno
Date: Wed Feb 14 11:01:03 2018
New Revision: 325154
URL: http://llvm.org/viewvc/llvm-project?rev=325154&view=rev
Log:
[Modules] Add more language features to be used with requires-declaration
Features added: c99, c11, c17, cplusplus14 and cplusplus17.
rdar://problem/36328787
rdar:/
Author: bruno
Date: Thu Feb 15 16:12:57 2018
New Revision: 325305
URL: http://llvm.org/viewvc/llvm-project?rev=325305&view=rev
Log:
[Modules] Extend -fmodule-name semantic for frameworks with private modules
Assume Foo.framework with two module maps and two modules Foo and
Foo_Private.
Framework
Any specific reason why this doesn't contain a testcase?
On Tue, May 23, 2017 at 4:37 AM, Ilya Biryukov via cfe-commits
wrote:
> Author: ibiryukov
> Date: Tue May 23 06:37:52 2017
> New Revision: 303630
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303630&view=rev
> Log:
> Allow to use vfs::Fi
Author: bruno
Date: Tue May 23 18:53:17 2017
New Revision: 303705
URL: http://llvm.org/viewvc/llvm-project?rev=303705&view=rev
Log:
[Modules] Fix overly conservative assertion for import diagnostic
We currenltly assert when want to diagnose a missing import and the decl
in question is already vis
On Wed, May 24, 2017 at 12:18 AM, Ilya Biryukov wrote:
> We test it in clangd (https://reviews.llvm.org/D33416).
> Logically, it's a single change, split into two part: for cfe and
> clang-tools-extra.
I see, thanks!
>
> On Wed, May 24, 2017 at 1:48 AM, Bruno Cardoso Lopes
> wrote:
>>
>> Any s
On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits
wrote:
> SGTM too. Regarding Duncan's last question -- I can't think of any such
> customer. :) If you all think the right thing for clang to do is to infer
> LLP64 behavior on LP64 (Darwin) + ms_extensions, then that is fine with
On Tue, Jun 13, 2017 at 8:13 PM, Bruno Cardoso Lopes
wrote:
> On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits
> wrote:
>> SGTM too. Regarding Duncan's last question -- I can't think of any such
>> customer. :) If you all think the right thing for clang to do is to infer
>> LLP6
On Fri, Jun 16, 2017 at 5:08 PM, Duncan P. N. Exon Smith
wrote:
>
> On Jun 16, 2017, at 11:02, Reid Kleckner wrote:
>
> We should fix it.
>
>
> Agreed.
>
> We just need a new character code in the builtin function prototype
> encoding. Currently there is no encoding for a portable int32_t that
>
Author: bruno
Date: Tue Jun 20 21:20:40 2017
New Revision: 305874
URL: http://llvm.org/viewvc/llvm-project?rev=305874&view=rev
Log:
Run dos2unix on ms-intrinsics-rotations.c test. NFC
Modified:
cfe/trunk/test/CodeGen/ms-intrinsics-rotations.c
Modified: cfe/trunk/test/CodeGen/ms-intrinsics-ro
Author: bruno
Date: Tue Jun 20 21:20:46 2017
New Revision: 305875
URL: http://llvm.org/viewvc/llvm-project?rev=305875&view=rev
Log:
Support MS builtins using 'long' on LP64 platforms
This allows for -fms-extensions to work the same on LP64. For example,
_BitScanReverse is expected to be 32-bit, m
Hi Richard,
Somehow this commit caused some methods in ObjC to do not become
visible in an interface when compiling with modules on. I filed
https://bugs.llvm.org/show_bug.cgi?id=33552, any idea what could have
gone wrong here? `hasVisibleDeclarationImpl` doesn't seem to have
changed the logic.
T
On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith wrote:
> On 21 June 2017 at 14:51, Bruno Cardoso Lopes
> wrote:
>>
>> Hi Richard,
>>
>> Somehow this commit caused some methods in ObjC to do not become
>> visible in an interface when compiling with modules on. I filed
>> https://bugs.llvm.org/show_
On Wed, Jun 21, 2017 at 4:56 PM, Richard Smith wrote:
> On 21 June 2017 at 16:55, Bruno Cardoso Lopes
> wrote:
>>
>> On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith
>> wrote:
>> > On 21 June 2017 at 14:51, Bruno Cardoso Lopes
>> > wrote:
>> >>
>> >> Hi Richard,
>> >>
>> >> Somehow this commit ca
Author: bruno
Date: Thu Dec 21 18:53:30 2017
New Revision: 321337
URL: http://llvm.org/viewvc/llvm-project?rev=321337&view=rev
Log:
[Modules] Change private modules rules and warnings
We used to advertise private modules to be declared as submodules
(Foo.Private). This has proven to not scale wel
Author: bruno
Date: Thu Dec 21 21:04:43 2017
New Revision: 321342
URL: http://llvm.org/viewvc/llvm-project?rev=321342&view=rev
Log:
[Modules] Map missing private submodules from Foo.Private to Foo_Private
In case `@import Foo.Private` fails because the submodule doesn't exist,
look for `Foo_Priva
Author: bruno
Date: Wed Jan 3 18:17:40 2018
New Revision: 321781
URL: http://llvm.org/viewvc/llvm-project?rev=321781&view=rev
Log:
[Modules] Allow modules specified by -fmodule-map-file to shadow implicitly
found ones
When modules come from module map files explicitly specified by
-fmodule-map-
Author: bruno
Date: Wed Jan 3 23:31:24 2018
New Revision: 321786
URL: http://llvm.org/viewvc/llvm-project?rev=321786&view=rev
Log:
Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow
implicitly found ones"
This reverts r321781 until I fix the leaks pointed out by bots:
htt
Author: bruno
Date: Thu Jan 4 18:33:18 2018
New Revision: 321855
URL: http://llvm.org/viewvc/llvm-project?rev=321855&view=rev
Log:
Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to
shadow implicitly found ones
When modules come from module map files explicitly specified
Author: bruno
Date: Fri Jan 5 14:13:56 2018
New Revision: 321906
URL: http://llvm.org/viewvc/llvm-project?rev=321906&view=rev
Log:
Track shadow modules with a generation counter.
This is a follow up to r321855, closing the gap between our internal shadow
modules implementation and upstream. It h
Hi Eric,
On Mon, Jan 8, 2018 at 9:31 PM, Eric Fiselier wrote:
> I haven't done a ton of investigation yet, but I suspect this commit is
> responsible for breaking my LLVM module selfhost build, which uses libc++ as
> the STL, and builds LLD (No bots appear to test this configuration).
>
> The err
Author: bruno
Date: Thu May 31 18:26:18 2018
New Revision: 333718
URL: http://llvm.org/viewvc/llvm-project?rev=333718&view=rev
Log:
[Modules] Warning for module declarations lacking 'framework' qualifier
When a module declaration for a framework lacks the 'framework'
qualifier, the listed headers
Author: bruno
Date: Thu Jun 14 11:20:04 2018
New Revision: 334747
URL: http://llvm.org/viewvc/llvm-project?rev=334747&view=rev
Log:
[CMAKE][c-index-test] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2
On MacOS, if CMAKE_OSX_SYSROOT is used and the user has command line tools
installed
Author: bruno
Date: Fri Jun 15 13:13:28 2018
New Revision: 334859
URL: http://llvm.org/viewvc/llvm-project?rev=334859&view=rev
Log:
[Modules] Improve .Private fix-its to handle 'explicit' and 'framework'
When in the context of suggestion the fix-it from .Private to _Private
for private modules, t
Author: bruno
Date: Wed Jun 20 14:16:37 2018
New Revision: 335177
URL: http://llvm.org/viewvc/llvm-project?rev=335177&view=rev
Log:
Add python tool to dump and construct header maps
Header maps are binary files used by Xcode, which are used to map
header names or paths to other locations. Clang h
Author: bruno
Date: Wed Jun 20 15:11:59 2018
New Revision: 335184
URL: http://llvm.org/viewvc/llvm-project?rev=335184&view=rev
Log:
Warning for framework headers using double quote includes
Introduce -Wquoted-include-in-framework-header, which should fire a warning
whenever a quote include appear
Hi Stella,
On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator
wrote:
>
> stella.stamenova added a comment.
>
> This breaks the clang tests on Windows when building using Visual Studio as
> none of the updated tests can find hmaptool.
Yes. I contacted Galina about that but maybe it
Author: bruno
Date: Wed Jun 20 16:08:43 2018
New Revision: 335190
URL: http://llvm.org/viewvc/llvm-project?rev=335190&view=rev
Log:
Fix hmaptool cmake file to work on Windows
Unbreak a few windows buildbots:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11315
http://lab.llvm.org:8
Attempted a fix in r335190, watching the bots.
On Wed, Jun 20, 2018 at 3:53 PM Bruno Cardoso Lopes
wrote:
>
> Hi Stella,
>
> On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator
> wrote:
> >
> > stella.stamenova added a comment.
> >
> > This breaks the clang tests on Windows when buil
On Wed, Jun 20, 2018 at 5:42 PM Stella Stamenova wrote:
>
> Thanks Bruno,
>
> I ran a build as well and I can see that hmaptool is now in the correct bin
> directory. The tests still failed though because on Windows, at least, you
> need to explicitly call python to run a script e.g. "python hma
Author: bruno
Date: Wed Jun 20 18:23:42 2018
New Revision: 335194
URL: http://llvm.org/viewvc/llvm-project?rev=335194&view=rev
Log:
Revert "Fix hmaptool cmake file to work on Windows"
This reverts commit 63711c3cd337a0d22617579a904af07481139611, due to
breaking bots:
http://lab.llvm.org:8011/bui
Author: bruno
Date: Wed Jun 20 18:23:51 2018
New Revision: 335195
URL: http://llvm.org/viewvc/llvm-project?rev=335195&view=rev
Log:
Revert "Warning for framework headers using double quote includes"
This reverts commit 9b5ff2db7e31c4bb11a7d468260b068b41c7c285.
Broke bots:
http://lab.llvm.org:80
Author: bruno
Date: Wed Jun 20 18:23:58 2018
New Revision: 335196
URL: http://llvm.org/viewvc/llvm-project?rev=335196&view=rev
Log:
Revert "Add python tool to dump and construct header maps"
This reverts commit fcfa2dd517ec1a6045a81e8247e346d630a22618.
Broke bots:
http://lab.llvm.org:8011/build
Author: bruno
Date: Thu Jun 21 14:45:24 2018
New Revision: 335295
URL: http://llvm.org/viewvc/llvm-project?rev=335295&view=rev
Log:
Re-apply: Add python tool to dump and construct header maps
Header maps are binary files used by Xcode, which are used to map
header names or paths to other location
Thanks Ben!
On Fri, Jun 22, 2018 at 2:51 AM Benjamin Kramer via cfe-commits
wrote:
>
> Author: d0k
> Date: Fri Jun 22 02:46:40 2018
> New Revision: 335330
>
> URL: http://llvm.org/viewvc/llvm-project?rev=335330&view=rev
> Log:
> [hmaptool] Turn %hmaptool into a proper substitution
>
> This is stil
Author: bruno
Date: Fri Jun 22 11:05:17 2018
New Revision: 335375
URL: http://llvm.org/viewvc/llvm-project?rev=335375&view=rev
Log:
Re-apply: Warning for framework headers using double quote includes
Introduce -Wquoted-include-in-framework-header, which should fire a warning
whenever a quote incl
Hi Nico,
> Why not enable it by default, or put it in -Wall at least? We don't like
> off-by-default warnings :-)
Thanks for double checking. There's an explanation/discussion in the
review: https://reviews.llvm.org/D47157, let me know if you have
additional questions.
Cheers,
--
Bruno Cardos
Author: bruno
Date: Mon Dec 10 11:03:12 2018
New Revision: 348789
URL: http://llvm.org/viewvc/llvm-project?rev=348789&view=rev
Log:
[constexpr][c++2a] Try-catch blocks in constexpr functions
Implement support for try-catch blocks in constexpr functions, as
proposed in http://wg21.link/P1002 and v
Author: bruno
Date: Tue Sep 18 10:11:13 2018
New Revision: 342499
URL: http://llvm.org/viewvc/llvm-project?rev=342499&view=rev
Log:
[Modules] Add platform and environment features to requires clause
Allows module map writers to add build requirements based on
platform/os. This helps when target f
Author: bruno
Date: Tue Sep 5 16:50:58 2017
New Revision: 312595
URL: http://llvm.org/viewvc/llvm-project?rev=312595&view=rev
Log:
[Darwin] Enable -fstack-protector (back) by default with -ffreestanding
Go back to behavior prior to r289005.
rdar://problem/32987198
Modified:
cfe/trunk/lib/D
Author: bruno
Date: Tue Sep 5 17:44:10 2017
New Revision: 312599
URL: http://llvm.org/viewvc/llvm-project?rev=312599&view=rev
Log:
Fix indentation mistake from r312595
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL:
http://llvm.o
On Tue, Sep 5, 2017 at 4:58 PM, Joerg Sonnenberger via cfe-commits
wrote:
> On Tue, Sep 05, 2017 at 11:50:58PM -0000, Bruno Cardoso Lopes via cfe-commits
> wrote:
>> Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-proj
Author: bruno
Date: Mon Sep 16 15:00:29 2019
New Revision: 372039
URL: http://llvm.org/viewvc/llvm-project?rev=372039&view=rev
Log:
[Modules][Objective-C] Use complete decl from module when diagnosing missing
import
Summary:
Otherwise the definition (first found) for ObjCInterfaceDecl's might
pr
Author: bruno
Date: Mon Apr 16 12:42:32 2018
New Revision: 330152
URL: http://llvm.org/viewvc/llvm-project?rev=330152&view=rev
Log:
Use export_as for autolinking frameworks
framework module SomeKitCore {
...
export_as SomeKit
}
Given the module above, while generting autolink information dur
Author: bruno
Date: Tue Apr 17 23:07:49 2018
New Revision: 330240
URL: http://llvm.org/viewvc/llvm-project?rev=330240&view=rev
Log:
[Modules] Turn on system header validation for implicit modules
After r300027 implicit builds might fail when updating the SDK on
darwin. Make validation of system h
Author: bruno
Date: Fri Apr 27 11:01:23 2018
New Revision: 331063
URL: http://llvm.org/viewvc/llvm-project?rev=331063&view=rev
Log:
[Modules][ObjC] ASTReader should add protocols for class extensions
During deserialization clang is currently missing the merging of
protocols into the canonical int
Author: bruno
Date: Mon Apr 30 15:14:29 2018
New Revision: 331232
URL: http://llvm.org/viewvc/llvm-project?rev=331232&view=rev
Log:
[Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl
Support for ObjC/C ODR-like semantics with structural equivalence
checking was added back in r306918.
Author: bruno
Date: Mon Apr 30 15:57:02 2018
New Revision: 331233
URL: http://llvm.org/viewvc/llvm-project?rev=331233&view=rev
Log:
[Modules] Fix testcases from r331232
Modified:
cfe/trunk/test/Modules/Inputs/non-ambiguous-enum/A.framework/Modules/module.modulemap
cfe/trunk/test/Modules/
Author: bruno
Date: Tue May 1 19:25:03 2018
New Revision: 331322
URL: http://llvm.org/viewvc/llvm-project?rev=331322&view=rev
Log:
[Modules] Allow @import to reach submodules in private module maps
A @import targeting a top level module from a private module map file
(@import Foo_Private), would
Author: bruno
Date: Mon Jun 25 15:24:17 2018
New Revision: 335542
URL: http://llvm.org/viewvc/llvm-project?rev=335542&view=rev
Log:
Warning for framework include violation from Headers to PrivateHeaders
Framework vendors usually layout their framework headers in the
following way:
Foo.framework/
Author: bruno
Date: Mon Jun 25 15:25:48 2018
New Revision: 335543
URL: http://llvm.org/viewvc/llvm-project?rev=335543&view=rev
Log:
Fix tests from r335542 to use %hmaptool
Modified:
cfe/trunk/test/Modules/framework-public-includes-private.m
Modified: cfe/trunk/test/Modules/framework-public-i
Author: bruno
Date: Wed Jun 27 13:29:36 2018
New Revision: 335780
URL: http://llvm.org/viewvc/llvm-project?rev=335780&view=rev
Log:
[Modules][ObjC] Warn on the use of '@import' in framework headers
Using @import in framework headers inhibit the use of such headers
when not using modules, this is
Author: bruno
Date: Fri Jun 29 17:49:27 2018
New Revision: 336031
URL: http://llvm.org/viewvc/llvm-project?rev=336031&view=rev
Log:
Add protocol redefinition to the current scope/context
Not doing so causes the AST writter to assert since the decl in question
never gets emitted. This is fine when
Author: bruno
Date: Thu Jul 12 10:38:48 2018
New Revision: 336920
URL: http://llvm.org/viewvc/llvm-project?rev=336920&view=rev
Log:
Revert "[modules] Fix 37878; Autoload subdirectory modulemaps with specific
LangOpts"
This reverts commit f40124d4f05ecf4f880cf4e8f26922d861f705f3 / r336660.
This
Author: bruno
Date: Wed Jul 18 16:21:19 2018
New Revision: 337430
URL: http://llvm.org/viewvc/llvm-project?rev=337430&view=rev
Log:
Reapply r336660: [Modules] Autoload subdirectory modulemaps with specific
LangOpts
Summary:
Reproducer and errors:
https://bugs.llvm.org/show_bug.cgi?id=37878
look
Author: bruno
Date: Mon Oct 14 16:02:03 2019
New Revision: 374841
URL: http://llvm.org/viewvc/llvm-project?rev=374841&view=rev
Log:
[Modules][PCH] Hash input files content
Summary:
When files often get touched during builds, the mtime based validation
leads to different problems in implicit modul
mitting file data ..done
> Committing transaction...
> Committed revision 374842.
> Committed 175b1b856ea to svn.
>
> Sorry for the inconvenience!
>
> -eric
>
> On Mon, Oct 14, 2019 at 3:59 PM Bruno Cardoso Lopes via cfe-commits
> wrote:
> >
> > Aut
Author: bruno
Date: Tue Oct 15 07:23:55 2019
New Revision: 374895
URL: http://llvm.org/viewvc/llvm-project?rev=374895&view=rev
Log:
Reapply: [Modules][PCH] Hash input files content
Summary:
When files often get touched during builds, the mtime based validation
leads to different problems in impli
Author: Bruno Cardoso Lopes
Date: 2020-04-21T15:45:54-07:00
New Revision: d892eec710caae84099f38fdb89d32ca15a23c1a
URL:
https://github.com/llvm/llvm-project/commit/d892eec710caae84099f38fdb89d32ca15a23c1a
DIFF:
https://github.com/llvm/llvm-project/commit/d892eec710caae84099f38fdb89d32ca15a23c1a
bruno marked an inline comment as done.
Comment at: lib/Sema/SemaExpr.cpp:8084
@@ +8083,3 @@
+ *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast);
+ return LHSType;
+}
ahatanak wrote:
> My understanding is that, when we have a compound
bruno updated this revision to Diff 71869.
bruno marked an inline comment as done.
bruno added a comment.
Update after Akira's comment
https://reviews.llvm.org/D24472
Files:
lib/Sema/SemaExpr.cpp
test/Sema/vector-cast.c
Index: test/Sema/vector-cast.c
===
bruno updated this revision to Diff 71870.
bruno added a comment.
Update again (now with the right patch) after Akira's comment
https://reviews.llvm.org/D24472
Files:
lib/Sema/SemaExpr.cpp
test/Sema/vector-cast.c
Index: test/Sema/vector-cast.c
==
bruno added inline comments.
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
Why removing StatsFile here? IIUC, at this point StatsFile is still the
bruno added a comment.
Maybe add some docs to explain the new flags?
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
MatzeB wrote:
> bruno wrote:
bruno added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8090
@@ +8089,3 @@
+ *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast);
+ return VecType;
+}
ahatanak wrote:
> Sorry I wasn't clear, but I was asking whether you were plan
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks Matthias
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D24820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
bruno added a comment.
Ping
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a subscriber: bruno.
Comment at: lib/Headers/module.modulemap:133
@@ -131,2 +132,3 @@
explicit module aes {
+ export sse2
header "__wmmintrin_aes.h"
The mmx case above makes sense to me, but I find conceptually odd that we need
to re-
bruno added a subscriber: bruno.
bruno added a comment.
Hi Daniel,
This is very nice.
In https://reviews.llvm.org/D24861#553606, @danielmarjamaki wrote:
> Compiling 2064 projects resulted in 904 warnings
>
> Here are the results:
> https://drive.google.com/file/d/0BykPmWrCOxt2N04tYl8zVHA3MXc/v
bruno added a comment.
@rnk, do you have any concerns about this patch?
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Fri Sep 30 17:19:38 2016
New Revision: 282968
URL: http://llvm.org/viewvc/llvm-project?rev=282968&view=rev
Log:
[Sema] Support lax conversions for compound assignments
Support lax convertions on compound assignment expressions like:
typedef __attribute__((vector_size(8))) d
bruno closed this revision.
bruno added a comment.
Thanks Reid & Akira,
Committed r282968
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added inline comments.
> eladcohen wrote in module.modulemap:133
> emmintrin.h is already included explicitly in wmmintrin.h & __wmmintrin_aes.h.
>
> If a user includes / there is no problem, since the
> intel submodule has an 'export *' directive and both aes & sse2 will be
> imported.
bruno added a reviewer: bruno.
bruno added a comment.
Hi Elad,
Is there any reason why you can't explicit model this in your build system by
pre-building the intrinsics and pointing to a module cache path containing the
pcm files? By doing that we don't need to have a specific compile flag.
h
bruno added a reviewer: bruno.
bruno added a comment.
Testcase?
> clang.rst:398
> + Print the library path for the currently used compiler runtime library
> + ("libgcc.a" or "libclang_rt.builtins.*.a" appropriately).
>
You can probably drop the "appropriately"
> Options.td:1865
> + HelpT
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
bruno added a reviewer: bruno.
bruno added inline comments.
Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td:2306
+ "vector operands do not have the same elements sizes (%0 and %1)">,
+ InGroup>, DefaultError;
def err_ext_vector_component_exceeds_length
bruno accepted this revision.
bruno added a comment.
LGTM
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a reviewer: bruno.
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
You should keep
bruno added inline comments.
Comment at: CMakeLists.txt:198
+set(CLANG_DEFAULT_LINKER "" CACHE STRING
+ "Default linker to use (\"bfd\" or \"gold\" or \"lld\", empty for platform
default")
mgorny wrote:
> Is there a reason not to allow using the absolute path
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
mgorny wrote:
> bruno wrote:
> > You should kee
1 - 100 of 607 matches
Mail list logo
