[PATCH] D48981: Add caching when looking up coroutine_traits

This revision was automatically updated to reflect the committed changes. Closed by commit rL337103: Add caching when looking up coroutine_traits (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48981 Files: cfe/t

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

modocache added a subscriber: lewissbaker. modocache added a comment. > Is that maybe intentional, and is the code not intended to compile? It looks like it should work to me, but maybe @lewissbaker or @GorNishanov can answer definitively. Comment at: cfe/trunk/lib/Sema/SemaC

[PATCH] D69144: [Format] Add format check for throwing negative numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f704320b058: [Format] Add format check for throwing negative numbers (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69144/new/ http

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Excellent, thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82928/new/ https://reviews.llvm.org/D82928 __

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/ https://reviews.llvm.org/D82986 __

[PATCH] D83788: Removed unused variable in clang

modocache added a comment. This LGTM! Looks like the last time this variable was touched was in 2010 as part of a mechanical renaming, https://github.com/llvm/llvm-project/commit/a771f46c82d7. At that point it was used, as a parameter to the static function `MakeObjCStringLiteralFixItHint`. Th

[PATCH] D83788: Removed unused variable in clang

modocache added a comment. By the way, I tried to accept this diff and leave the following inline comment on `SemaExpr.cpp:15799`: > I guess this assert was never capable of being hit previously, since the > `FixItHint::isNull` would always return true? I wonder if we'll now see some > genuine

[PATCH] D83788: Removed unused variable in clang

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. No problem, thanks for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 ___ cfe-comm

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

modocache added a reviewer: junparser. modocache added a subscriber: junparser. modocache added a comment. Excellent, thank you! The test failures on the diff appear to be legitimate, they reproduce for me when I apply this patch to my local checkout and run `ninja check-clang`. Could you take a

[PATCH] D81885: [Coroutines] Return false on error of buildSuspends

modocache requested changes to this revision. modocache added a comment. This revision now requires changes to proceed. I don't have a preference as to whether `Sema::ActOnCoroutineBodyStart` returns `true` or `false` to indicate failure, although I think returning `true` for failures is a bit o

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Sweet! Thanks for the reviews/responses, LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/ https://reviews.llvm.org/D82029

[PATCH] D82332: [Coroutines] Handle dependent promise types for final_suspend non-throw check

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82332/new/ https://reviews.llvm.org/D82332 ___

[PATCH] D36492: [RFC][time-report] Add preprocessor timer

modocache created this revision. `gcc -ftime-report` provides a breakdown of how much time GCC spends doing preprocessing, parsing, template instantiation, and more: g++ -ftime-report foo.cpp Execution times (seconds) phase setup : 0.00 ( 0%) usr 0.00 ( 0%) sys 0.00 ( 0%)

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

modocache created this revision. Add documentation for `clang::ParseAST` parameters `PrintStats` and `SkipFunctionBodies`. Also, remove a tiny bit of trailing whitespace. https://reviews.llvm.org/D36530 Files: include/clang/Parse/ParseAST.h Index: include/clang/Parse/ParseAST.h

[PATCH] D36531: [Parse] Document Parser::SkipFunctionBodies

modocache created this revision. https://reviews.llvm.org/D36531 Files: include/clang/Parse/Parser.h Index: include/clang/Parse/Parser.h === --- include/clang/Parse/Parser.h +++ include/clang/Parse/Parser.h @@ -253,6 +253,10 @@

[PATCH] D36492: [RFC][time-report] Add preprocessor timer

modocache added a reviewer: vsk. modocache planned changes to this revision. modocache added a comment. Thanks for the feedback, @vsk, I really appreciate it! I have some other work done for this on my local checkout, but I was going a little bonkers working on it without knowing whether people

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

modocache added a comment. Oops, sorry. I couldn't find anyone recent in the commit history. I hope no one minds if I just go ahead and commit this. https://reviews.llvm.org/D36530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

This revision was automatically updated to reflect the committed changes. Closed by commit rL310609: [Parse] Document PrintStats, SkipFunctionBodies (authored by modocache). Repository: rL LLVM https://reviews.llvm.org/D36530 Files: cfe/trunk/include/clang/Parse/ParseAST.h Index: cfe/trun

[PATCH] D36531: [Parse] Document Parser::SkipFunctionBodies

This revision was automatically updated to reflect the committed changes. Closed by commit rL310627: [Parse] Document Parser::SkipFunctionBodies (authored by modocache). Repository: rL LLVM https://reviews.llvm.org/D36531 Files: cfe/trunk/include/clang/Parse/Parser.h Index: cfe/trunk/incl

[PATCH] D36492: [time-report] Add preprocessor timer

modocache updated this revision to Diff 95. modocache retitled this revision from "[RFC][time-report] Add preprocessor timer" to "[time-report] Add preprocessor timer". modocache edited the summary of this revision. modocache removed subscribers: vsk, mzolotukhin. modocache added a comment. A

[PATCH] D36492: [time-report] Add preprocessor timer

modocache added subscribers: vsk, mzolotukhin. modocache added a comment. Oops, sorry, didn't mean to remove the subscribers. `arc diff --verbatim` strikes again. https://reviews.llvm.org/D36492 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D36492: [time-report] Add preprocessor timer

modocache added a comment. Friendly ping! I think this is ready to be reviewed. It adds an additional row, `Preprocessing`, to the `Miscellaneous Ungrouped Timers` section of the `clang -ftime-report` output: ===-===

[PATCH] D36492: [time-report] Add preprocessor timer

modocache planned changes to this revision. modocache added inline comments. Comment at: lib/Lex/Preprocessor.cpp:746 void Preprocessor::Lex(Token &Result) { + llvm::TimeRegion(PPOpts->getTimer()); + erik.pilkington wrote: > Doesn't this just start a timer and

[PATCH] D36848: [CodeGen] Use RefCntTimer to time IR generation

modocache created this revision. Use the reference-counted timer abstraction from https://reviews.llvm.org/D36847 instead of manually keeping track of the number of times `startTimer()` and `stopTimer()` should be called. Test plan: Run `clang -ftime-report` and confirm the time measurements are

[PATCH] D36492: [time-report] Add preprocessor timer

modocache added inline comments. Comment at: include/clang/Lex/PreprocessorOptions.h:165 public: - PreprocessorOptions() : UsePredefines(true), DetailedRecord(false), + PreprocessorOptions() : PPTimer("preprocessor", "Preprocessing"), + UsePredefines(t

[PATCH] D36848: [CodeGen] Use reentrant methods to time IR gen

modocache updated this revision to Diff 112187. modocache retitled this revision from "[CodeGen] Use RefCntTimer to time IR generation" to "[CodeGen] Use reentrant methods to time IR gen". modocache edited the summary of this revision. modocache added a comment. Use `startReentrantTimer` and `sto

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache marked an inline comment as done. modocache added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitPass())); + MPM.addPass(createModuleToFunctionPassAdaptor(CoroElidePas

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache planned changes to this revision. modocache marked 2 inline comments as done and an inline comment as not done. modocache added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitP

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache added a comment. I'm currently working on ensuring that CGSCC optimizations are rerun to optimize coroutine funclets -- the primary feedback I received on this and on D71899 -- but I just realized I didn't respond to one comment on this set of reviews

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236245. modocache removed a subscriber: wenlei. modocache added a comment. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Thanks for the reviews. Based on my latest revision of D71899 , the coro-split di

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236889. modocache added a comment. Update tests -- we now re-run the SCC pass, but don't insert the coroutine funclets into the SCC, so we no longer see the funclets in the output being tested here. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236967. modocache added a comment. Initialize PipelineTuningOptions properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: clang/lib/CodeGen/BackendUtil.c

[PATCH] D70555: [coroutines] Don't build promise init with no args

modocache added a comment. Of course, your approval is very welcome! 😄 I'll go ahead and land this today, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://reviews.llvm.org/D70555 __

[PATCH] D70555: [coroutines] Don't build promise init with no args

This revision was automatically updated to reflect the committed changes. Closed by commit rG627e01feb718: [coroutines] Don't build promise init with no args (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://r

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

This revision was automatically updated to reflect the committed changes. Closed by commit rG048239e46e49: [Coroutines][6/6] Clang schedules new passes (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache created this revision. modocache added reviewers: rsmith, RKSimon, aaron.ballman, wenlei. Herald added a project: clang. A closed-source C++ codebase I help maintain began hitting a Clang ICE with a stack trace that referenced `clang::OverloadCandidate::getNumParams`: https://gist.github

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache marked an inline comment as done. modocache added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:7371 return; } @rsmith I'd definitely appreciate any pointers here -- if initializing `IsSurrogate` with a value as I do in this pa

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache updated this revision to Diff 227808. modocache added a comment. Rebasing onto the monorepo. @rsmith, I confirmed the test cases that this diff adds still fail on trunk, and that the Clang source changes made in this diff fix the test case failures. Tomorrow I plan on poking around to

[PATCH] D70555: [coroutines] Don't build promise init with no args

modocache created this revision. modocache added reviewers: GorNishanov, rsmith, lewissbaker. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. modocache edited the summary of this revision. In the case of a coroutine that takes no arguments, `Sema::buildCoroutinePromis

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

modocache requested changes to this revision. modocache added a comment. This revision now requires changes to proceed. Sorry for the slow response here, @junparser! The test case you came up with here is great! I can see the issue is that `ScopeInfo->CoroutineParameterMoves` are built up when C

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

modocache created this revision. modocache added reviewers: GorNishanov, rsmith, lewissbaker. Herald added a subscriber: EricWF. Herald added a project: clang. In https://reviews.llvm.org/D62550 @rsmith pointed out that there are many situations in which a coroutine body statement may be transform

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. LGTM, thanks! Please let me know if you'd like me to commit this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022

[PATCH] D62035: [AST] const-ify ObjC inherited class search

modocache abandoned this revision. modocache added a comment. I'm not super interested in this patch anymore, someone else feel free to work on this! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62035/new/ https://reviews.llvm.org/D62035 _

[PATCH] D59765: [Lex] Warn about invisible Hangul whitespace

modocache abandoned this revision. modocache added a comment. I'm not super interested in this patch anymore, someone else feel free to work on this! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59765/new/ https://reviews.llvm.org/D59765 _

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. LGTM! Let me know if you'd like me to commit this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69180/new/ https://reviews.llvm.or

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b3d1d1348da: [coroutines] Remove assert on CoroutineParameterMoves in Sema… (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

modocache added a comment. Thanks again for the patch @junparser! And sorry the review took so long! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022 ___ cfe-com

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8682d29a2877: [Format] Add format check for coroutine keywords with negative numbers (authored by modocache). Changed prior to commit: https://reviews.llvm.org/D69180?vs=225672&id=231596#toc Repository

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

modocache added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1761 + tok::kw_case, tok::at, tok::l_brace, tok::kw_throw, + tok::kw_co_return, tok_kw_co_yield)) return TT_UnaryOperator;

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

modocache added a comment. @GorNishanov, @rsmith, friendly ping! @rsmith this patch addresses your requests from https://reviews.llvm.org/D62550. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://reviews.llvm.org/D70579 _

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

modocache added a comment. This seems like a outright improvement, but as mentioned above it would be nice to get @rsmith's take on it since I'm not an expert. Two nitpicks, though: 1. Could you please run clang-format on the lines you added/modified? 2. Could you apply these changes on top of t

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

This revision was automatically updated to reflect the committed changes. Closed by commit rG376cf43729c8: [coroutines][PR41909] Generalize fix from D62550 (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://rev

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

modocache added a comment. Thanks for the review! Much appreciated :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://reviews.llvm.org/D70579 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D71542: [coroutines][PR41909] don't build dependent coroutine statements if the coroutine still has a dependent promise type

modocache requested changes to this revision. modocache added a comment. This revision now requires changes to proceed. Great minds think alike! This looks like the patch I sent in November, D70579 . I only just committed it two days ago in rG376cf43

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

modocache requested changes to this revision. modocache added subscribers: jroelofs, echristo. modocache added a comment. This revision now requires changes to proceed. Grepping for "dump-tokens", I can see one regression test that exercises this option: clang/test/Lexer/dollar-idents.c. "dump-co

[PATCH] D71731: [Format] fix dereference of pointers in co_yeld and co_return statements

modocache added a comment. Nice! Thanks for this. This looks good to me, but I'll defer to the other reviewers you specified, since I think they're more familiar with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71731/new/ https://r

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

modocache added a subscriber: mehdi_amini. modocache added a comment. Ah, I'm sorry I wasn't clear -- instead of changing a lot of tests to use the new names exclusively, my suggestion was to change one or two tests to use the new canonical name, and have the remaining tests keep using the alias

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache created this revision. modocache added reviewers: GorNishanov, lewissbaker, chandlerc, junparser. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. Depends on https://reviews.llvm.org/D71902. The last in a series of six patches that ports the LLVM coroutines

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache added a comment. Friendly ping! `OverloadCandidate` has uninitialized members and so can cause UB if used incorrectly in another part of the compiler, so I feel this is a fairly straightforward patch: prevent UB by initializing all members. But I'd like some review to confirm. @rsmith

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache abandoned this revision. modocache added a comment. Awesome, thanks! > Alternatively, I considered modifying the `clang::OverloadCandidate` > constructor to initialize `IsSurrogate` with a false value. I feel doing so > would be safer, but I stuck with what appears to be the conventio

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

modocache added a comment. I may be wrong, but I believe this breaks `check-llvm` when run with the following configuration: `cmake -DLLVM_BINUTILS_INCDIR=/path/to/binutils/include`: Failing Tests (6): LLVM :: tools/gold/X86/common_thinlto.ll LLVM :: tools/gold/X86/emit-llvm.ll

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

modocache added a comment. Awesome, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 244566. modocache added a comment. Clean up coroutine intrinsics as part of the ThinLTO pre-link pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: cl

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 245054. modocache removed a reviewer: wenlei. modocache removed subscribers: wenlei, hiraditya. modocache removed a project: LLVM. modocache added a comment. Rebase on top of the latest version of D71902 . Repository: rG

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

modocache added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:137 + + Value *Insert(Value *V, const Twine& = "") const { +if (Instruction *I = dyn_cast(V)) I experienced a tiny regression after applying this patch, and I think this line migh

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 239437. modocache added a comment. Rebase past D72547 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: clang/lib/CodeGen/Ba

[PATCH] D44915: [coroutines] Fix invalid source range in co_await call expressions.

modocache added a comment. Excellent, thank you! I think this might fix PR34982 ? Repository: rC Clang https://reviews.llvm.org/D44915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D37115: [coroutines] Do not attempt to typo-correct when coroutine is looking for required members

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Excellent, thanks! https://reviews.llvm.org/D37115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D45120: [coroutines] Add __builtin_coro_noop => llvm.coro.noop

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Great, thanks! https://reviews.llvm.org/D45120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D44552: [Coroutines] Find custom allocators in class scope

This revision was automatically updated to reflect the committed changes. Closed by commit rC328949: [Coroutines] Find custom allocators in class scope (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D44552?vs=138663&id=140600#toc Repository: rC Clan

[PATCH] D44552: [Coroutines] Find custom allocators in class scope

modocache marked 2 inline comments as done. modocache added a comment. Thanks for the review, @GorNishanov! I adopted your suggestions and made the commit. Repository: rC Clang https://reviews.llvm.org/D44552 ___ cfe-commits mailing list cfe-com

[PATCH] D43927: [Coroutines] Schedule coro-split before asan

This revision was automatically updated to reflect the committed changes. Closed by commit rC328951: [Coroutines] Schedule coro-split before asan (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D43927?vs=136463&id=140603#toc Repository: rC Clang htt

[PATCH] D34865: [ORE] Use LLVM's "diagnostics hotness" spelling

modocache created this revision. Depends on https://reviews.llvm.org/D34864. To unify Clang and LLVM's spelling of "diagnostic[s] hotness", use the new "diagnostics hotness" spelling in LLVM, which was added in https://reviews.llvm.org/D34864. https://reviews.llvm.org/D34865 Files: lib/CodeG

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

modocache created this revision. Herald added a subscriber: fhahn. Depends on https://reviews.llvm.org/D34867. Add a Clang frontend option to enable optimization remark hotness thresholds, which were added to LLVM in https://reviews.llvm.org/D34867. This prevents diagnostics that do not meet a mi

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

modocache updated this revision to Diff 104964. modocache marked 4 inline comments as done. modocache added a comment. Address comments, for the most part. As for the documentation: I think this is OK for now, but there are definitely a few more options that I'd like to document, and those will

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

modocache added a comment. Awesome, thank you for all the reviews! https://reviews.llvm.org/D34868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34928: Add docs for -foptimization-record-file=

modocache created this revision. The Clang option was previously not included in the User's Manual. https://reviews.llvm.org/D34928 Files: docs/UsersManual.rst Index: docs/UsersManual.rst === --- docs/UsersManual.rst +++ docs/U

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache created this revision. Herald added a subscriber: mgorny. When searching for Git version control information, libBasic's CMake checks for the path '.git/logs/HEAD'. However, when LLVM is included as a Git submodule, this path does not exist. Instead, it contains a '.git' file with the fo

[PATCH] D34928: Add docs for -foptimization-record-file=

modocache added a comment. Thanks for the review, Hal! :) https://reviews.llvm.org/D34928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache planned changes to this revision. modocache added a comment. Oh, nice catch @jordan_rose, you're absolutely right. I just tried updating my Git submodule reference for Clang and rebuilding my project, but the commit hash shown for Clang didn't change accordingly. I'll need to find a f

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache updated this revision to Diff 105673. modocache added a comment. Use submodule's .git directory. https://reviews.llvm.org/D34955 Files: lib/Basic/CMakeLists.txt Index: lib/Basic/CMakeLists.txt === --- lib/Basic/CMakeL

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache updated this revision to Diff 105674. modocache edited the summary of this revision. modocache removed a subscriber: pcc. modocache added a comment. Update commit message. https://reviews.llvm.org/D34955 Files: lib/Basic/CMakeLists.txt Index: lib/Basic/CMakeLists.txt =

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache updated this revision to Diff 106367. modocache added a comment. Use CMAKE_MATCH_0 instead of using REGEX REPLACE. Thanks for the suggestion! https://reviews.llvm.org/D34955 Files: lib/Basic/CMakeLists.txt Index: lib/Basic/CMakeLists.txt ===

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache added a comment. Friendly ping! I'm pretty excited about this change, it helps a pet project of mine, which builds Clang and LLVM checked out as submodules, display correct revision information. Let me know if I can modify this change at all, to make it easier to accept. https://rev

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache added a comment. Awesome, thanks @jordan_rose! https://reviews.llvm.org/D34955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41980: Add tests for llvm-bcanalyzer stream types

modocache created this revision. modocache added reviewers: pcc, aprantl, mehdi_amini. Herald added a subscriber: a.sidorin. Add tests for the improved stream type detection added to `llvm-bcanalyzer` in https://reviews.llvm.org/D41979. Test Plan: `check-clang` Repository: rC Clang https://r

[PATCH] D41980: Add tests for llvm-bcanalyzer stream types

modocache added inline comments. Comment at: test/PCH/include-stream-type.cpp:7 +// RUN: cp %S/Inputs/pragma-once2.h %t-dir +// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %t-dir/pragma-once2-pch.h +// RUN: llvm-bcanalyzer -dump %t | FileCheck %s aprantl wrote:

[PATCH] D42001: [Driver] Add "did you mean?" suggestions to -cc1as

modocache created this revision. modocache added reviewers: v.g.vassilev, bruno. In https://reviews.llvm.org/D41733, the driver was modified such that, when a user provided a mispelled option such as `-hel`, it would suggest a valid option with a nearby edit distance: "did you mean '-help'?". Add

[PATCH] D42004: [Driver] Suggest valid integrated tools

modocache created this revision. modocache added reviewers: sepavloff, bkramer, phosek. There are only two valid integrated Clang driver tools: `-cc1` and `-cc1as`. If a user asks for an unknown tool, such as `-cc1asphalt`, an error message is displayed to indicate that there is no such tool, but

[PATCH] D42005: [docs] Use monospace for PCH option flags

modocache created this revision. modocache added reviewers: sepavloff, aaron.ballman. Use monospace for option flags in the PCH section, instead of the italics that were being used previously. I believe these used to be links, for which single backticks would have been appropriate, but since they

[PATCH] D42001: [Driver] Add "did you mean?" suggestions to -cc1as

This revision was automatically updated to reflect the committed changes. Closed by commit rL322445: [Driver] Add "did you mean?" suggestions to -cc1as (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42001 Files:

[PATCH] D42001: [Driver] Add "did you mean?" suggestions to -cc1as

modocache added a comment. Thanks, @v.g.vassilev! Repository: rL LLVM https://reviews.llvm.org/D42001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42005: [docs] Use monospace for PCH option flags

This revision was automatically updated to reflect the committed changes. Closed by commit rC322447: [docs] Use monospace for PCH option flags (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D42005?vs=129675&id=129768#toc Repository: rC Clang https:

[PATCH] D42005: [docs] Use monospace for PCH option flags

modocache added a comment. Great, thanks for the review, @aaron.ballman! Repository: rC Clang https://reviews.llvm.org/D42005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

modocache updated this revision to Diff 129785. modocache added a comment. Thanks for the great review, @GorNishanov! You were exactly right, I had to remove the assert. I've taken all of your other suggestions as well. Let me know if anything else stands out at you. Also, thanks for the questio

[PATCH] D42004: [Driver] Suggest valid integrated tools

This revision was automatically updated to reflect the committed changes. Closed by commit rC322517: [Driver] Suggest valid integrated tools (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D42004?vs=129668&id=129902#toc Repository: rC Clang https://

[PATCH] D42004: [Driver] Suggest valid integrated tools

modocache added a comment. Great, thanks for the review @bkramer! Repository: rC Clang https://reviews.llvm.org/D42004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rC323381: [coroutines] Pass coro func args to promise ctor (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D41820?vs=129785&id=131351#toc Repository: rC Clang

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rL323381: [coroutines] Pass coro func args to promise ctor (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D41820 Files: c

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

modocache added a comment. Great, thanks for the reviews! Repository: rC Clang https://reviews.llvm.org/D41820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   >