Re: [PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

2020-01-08 Thread Ben D. Jones via cfe-commits
Sure. Will do. Thanks! > On Jan 7, 2020, at 5:17 PM, Akira Hatanaka wrote: > >  >> >>> On Jan 7, 2020, at 2:45 PM, Ben D. Jones via Phabricator via cfe-commits >>> wrote: >>> >>> bendjones added a comment. >>> >>> In D70284#1752806 , @bendjones >>>

Re: [PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

2019-11-20 Thread Ben D. Jones via cfe-commits
Yup will do. Sent from my iPhone - Ben D. Jones > On Nov 19, 2019, at 6:32 PM, Akira Hatanaka wrote: > > Can you check the `#0` at the end of the globals and other strings that > precede that? If you do so, we can also check that `no_dead_strip` isn’t > added. > >> On Nov 19, 2019, at 6:0