https://github.com/asudarsa approved this pull request.
LGTM. Thanks
https://github.com/llvm/llvm-project/pull/137070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -32,10 +32,12 @@ namespace object {
/// The producer of the associated offloading image.
enum OffloadKind : uint16_t {
OFK_None = 0,
- OFK_OpenMP,
- OFK_Cuda,
- OFK_HIP,
- OFK_LAST,
+ OFK_OpenMP = (1 << 1),
+ OFK_FIRST = OFK_OpenMP,
asudarsa wrote:
@@ -923,10 +923,9 @@ Expected> linkAndWrapDeviceFiles(
});
auto LinkerArgs = getLinkerArgs(Input, BaseArgs);
-DenseSet ActiveOffloadKinds;
+uint16_t ActiveOffloadKindMask = 0u;
asudarsa wrote:
I think it is a good optimization to have (16-
@@ -32,10 +32,12 @@ namespace object {
/// The producer of the associated offloading image.
enum OffloadKind : uint16_t {
OFK_None = 0,
- OFK_OpenMP,
- OFK_Cuda,
- OFK_HIP,
- OFK_LAST,
+ OFK_OpenMP = (1 << 1),
asudarsa wrote:
Addressed in c0bc6890a68b7b
asudarsa wrote:
Hi @jhuber6
Thanks so much for feedback so far. I have added a separate PR
(https://github.com/llvm/llvm-project/pull/135809) for improving OffloadKind
implementation. Kindly take a look.
Thanks
https://github.com/llvm/llvm-project/pull/135683
___
https://github.com/asudarsa created
https://github.com/llvm/llvm-project/pull/135809
Following are the changes:
1. Make OffloadKind enum values to be powers of two so we can use them like a
bitfield
2. Include OFK_SYCL enum value
3. Modify ActiveOffloadKinds support in clang-linker-wrapper to
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/135683
>From 226d96d4e66e0a1e9d4f42df413d11a6ece4fec9 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 14 Apr 2025 14:16:05 -0700
Subject: [PATCH 1/2] [SYCL] Add clang-linker-wrapper changes to call
clang-
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/135809
>From ec072a0ef5b699c58dd2ac404c90a5078f4a774a Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Tue, 15 Apr 2025 09:27:27 -0700
Subject: [PATCH 1/3] [Offload][SYCL] Refactor OffloadKind implementation
Si
https://github.com/asudarsa converted_to_draft
https://github.com/llvm/llvm-project/pull/135683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asudarsa closed
https://github.com/llvm/llvm-project/pull/129973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -78,7 +77,7 @@ class LLVM_LIBRARY_VISIBILITY SPIRVToolChain : public
ToolChain {
bool useIntegratedAs() const override { return true; }
- bool IsIntegratedBackendDefault() const override { return false; }
+ bool IsIntegratedBackendDefault() const override { return tru
https://github.com/asudarsa approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/129545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/133967
>From 0ab40315cd5ca320d84f87c99b8f23d9b6e8ed36 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 31 Mar 2025 14:31:24 -0700
Subject: [PATCH 1/5] [SYCL][SPIR-V Backend][clang-sycl-linker] Add SPIR-V
b
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/133967
>From 0ab40315cd5ca320d84f87c99b8f23d9b6e8ed36 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 31 Mar 2025 14:31:24 -0700
Subject: [PATCH 1/6] [SYCL][SPIR-V Backend][clang-sycl-linker] Add SPIR-V
b
asudarsa wrote:
@sarnex, @jhuber6
Thanks much for your kind feedbacks. This is ready to be merged. Can one of you
please help?
Sincerely
https://github.com/llvm/llvm-project/pull/133967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/133967
>From 0ab40315cd5ca320d84f87c99b8f23d9b6e8ed36 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 31 Mar 2025 14:31:24 -0700
Subject: [PATCH 1/6] [SYCL][SPIR-V Backend][clang-sycl-linker] Add SPIR-V
b
asudarsa wrote:
For the test failures, please resync with the tip of the repo and the test
failure should disappear.
https://github.com/llvm/llvm-project/pull/133194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -163,6 +220,15 @@ static inline bool IsAMDOffloadArch(OffloadArch A) {
return A >= OffloadArch::GFX600 && A < OffloadArch::Generic;
}
+static inline bool IsIntelCPUArch(OffloadArch Arch) {
asudarsa wrote:
For sake of completion, can you please add IsInte
101 - 118 of 118 matches
Mail list logo
