[PATCH] D68072: Reference qualifiers in member templates causing extra indentation.

2019-09-25 Thread Andreas Wass via Phabricator via cfe-commits
AndWass created this revision. AndWass added reviewers: klimek, owenpan, krasimir, timwoj. AndWass added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following code struct f { template void bar() && noexcept {} }; will be format

[PATCH] D68072: Reference qualifiers in member templates causing extra indentation.

2019-09-26 Thread Andreas Wass via Phabricator via cfe-commits
AndWass added a comment. @klimek I don't have commit access yet, could you please commit it for me? Thanks Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68072/new/ https://reviews.llvm.org/D68072 ___ c

[PATCH] D68072: Reference qualifiers in member templates causing extra indentation.

2019-09-28 Thread Andreas Wass via Phabricator via cfe-commits
AndWass updated this revision to Diff 87. AndWass added a comment. Updated to fix test failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68072/new/ https://reviews.llvm.org/D68072 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index: cla

[PATCH] D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.

2019-09-28 Thread Andreas Wass via Phabricator via cfe-commits
AndWass updated this revision to Diff 99. AndWass added a comment. Removed the manual paranthesis-tracking, using NestingLevel instead. Moved tests to the already existing `UnderstandsFunctionRefQualification` test case. Clarified what is being matched against in `TokenAnnotator::spaceRequir

[PATCH] D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.

2019-09-28 Thread Andreas Wass via Phabricator via cfe-commits
AndWass marked 4 inline comments as done. AndWass added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1375 +} + // Line.MightBeFunctionDecl can only be true after the parentheses of a MyDeveloperDay wrote: > could this be done using th

[PATCH] D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.

2019-09-29 Thread Andreas Wass via Phabricator via cfe-commits
AndWass marked 2 inline comments as done. AndWass added a comment. Thanks! @MyDeveloperDay could you commit as well? Don't have access for that yet CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68072/new/ https://reviews.llvm.org/D68072 ___