If there are no objections I would like to revert this old commit that coverts
error about implicit function declaration into a warning.
We have decided to generate an error for this https://reviews.llvm.org/D31745
because for OpenCL variadic prototypes are disallowed (section 6.9.e,
https://w
OpenCL off-list and Richard proposed to use
"-Werror=implicit-function-declaration" command line option if error
is required. Will it work for you?
Thanks,
Alexey
On Tue, Aug 21, 2018 at 5:41 PM Anastasia Stulova via cfe-commits
wrote:
>
> If there are no objections I would
unction declarations as an extension
in all C dialects. Remove OpenCL special case.
On Tue, 21 Aug 2018 at 07:41, Anastasia Stulova via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
If there are no objections I would like to revert this old commit that coverts
error about im
e OpenCL special case.
On Wed, 22 Aug 2018 at 06:55, Anastasia Stulova via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Hi Richard,
> This is incorrect. Implicit function declarations declare unprototyped
> functions, which are *not* variadic, and are in fact supported by
Author: stulova
Date: Wed May 9 06:23:26 2018
New Revision: 331877
URL: http://llvm.org/viewvc/llvm-project?rev=331877&view=rev
Log:
[OpenCL] Add constant address space to __func__ in AST.
Added string literal helper function to obtain the type
attributed by a constant address space.
Also fixed
Author: stulova
Date: Wed Sep 27 07:37:00 2017
New Revision: 314304
URL: http://llvm.org/viewvc/llvm-project?rev=314304&view=rev
Log:
[OpenCL] Handle address space conversion while setting type alignment.
Added missing addrspacecast case in alignment computation
logic of pointer type emission in
Author: stulova
Date: Wed Sep 27 10:03:35 2017
New Revision: 314317
URL: http://llvm.org/viewvc/llvm-project?rev=314317&view=rev
Log:
[OpenCL] Fixed CL version in failing test.
Modified:
cfe/trunk/test/CodeGenOpenCL/vectorLoadStore.cl
Modified: cfe/trunk/test/CodeGenOpenCL/vectorLoadStore.c
I think this bit is a bit confusing to us. Some of our original OpenCL checks
were removed in some places because in some cases OpenCL semantic was adopted
elsewhere. But I think this should indeed go under OpenCL check.
Thanks,
Anastasia
From: Bruno Cardoso Lo
, Anastasia Stulova via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Hi Richard,
There was a change in the spec to disallow unprototyped functions, which was
made this year. Unfortunately it seems it didn't make into the Khronos registry
yet to appear publicly. I will
Author: stulova
Date: Mon Jun 5 06:27:03 2017
New Revision: 304708
URL: http://llvm.org/viewvc/llvm-project?rev=304708&view=rev
Log:
[OpenCL] Fix pipe size in TypeInfo.
Pipes are now the size of pointers rather than the size
of the type that they contain.
Patch by Simon Perretta!
Differential
Author: stulova
Date: Tue Jun 20 09:50:45 2017
New Revision: 305798
URL: http://llvm.org/viewvc/llvm-project?rev=305798&view=rev
Log:
[OpenCL] Diagnose scoped address-space qualified variables
Produce an error if variables qualified with a local or
a constant address space are not declared in the
Author: stulova
Date: Fri Jun 22 08:45:08 2018
New Revision: 335358
URL: http://llvm.org/viewvc/llvm-project?rev=335358&view=rev
Log:
[Sema] Updated note for address spaces to print the type.
This allows to reuse the same diagnostic for OpenCL or CUDA.
Modified:
cfe/trunk/include/clang/Basi
Author: stulova
Date: Fri Jun 22 09:20:21 2018
New Revision: 335362
URL: http://llvm.org/viewvc/llvm-project?rev=335362&view=rev
Log:
[OpenCL] Fixed parsing of address spaces for C++.
Added address space tokens to C++ parsing code to be able
to parse declarations that start from an address space
Author: stulova
Date: Wed Oct 10 09:05:22 2018
New Revision: 344148
URL: http://llvm.org/viewvc/llvm-project?rev=344148&view=rev
Log:
[OpenCL] Fixed address space cast in C style cast of C++ parsing
C style cast in OpenCL C++ was ignoring the address space
conversions from OpenCL C and as a resul
It seems like it caused a bug:
https://bugs.llvm.org/show_bug.cgi?id=39486
From: cfe-commits on behalf of Matt
Arsenault via cfe-commits
Sent: 03 October 2018 03:01
To: cfe-commits@lists.llvm.org
Subject: r343653 - OpenCL: Mark printf format string argument
A
Author: stulova
Date: Mon Jan 14 03:44:22 2019
New Revision: 351053
URL: http://llvm.org/viewvc/llvm-project?rev=351053&view=rev
Log:
[OpenCL] Set generic addr space of 'this' in special class members.
Set address spaces of 'this' param correctly for implicit special
class members.
This also cha
Author: stulova
Date: Fri Jan 18 03:38:16 2019
New Revision: 351546
URL: http://llvm.org/viewvc/llvm-project?rev=351546&view=rev
Log:
[OpenCL] Fix overloading ranking rules for addrspace conversions.
Extend ranking to work with address spaces correctly when
resolving overloads.
Differential Revi
Author: stulova
Date: Mon Jan 21 08:01:38 2019
New Revision: 351747
URL: http://llvm.org/viewvc/llvm-project?rev=351747&view=rev
Log:
[OpenCL] Allow address spaces as method qualifiers.
Methods can now be qualified with address spaces to prevent
undesirable conversions to generic or to provide cu
Author: stulova
Date: Mon Jan 28 03:37:49 2019
New Revision: 352349
URL: http://llvm.org/viewvc/llvm-project?rev=352349&view=rev
Log:
Rename getTypeQualifiers to getMethodQualifiers.
Use more descriptive name for the method qualifiers getter.
Differential Revision: https://reviews.llvm.org/D5679
Author: stulova
Date: Wed Jan 30 03:18:08 2019
New Revision: 352617
URL: http://llvm.org/viewvc/llvm-project?rev=352617&view=rev
Log:
[OpenCL] Add generic addr space to the return of implicit assignment.
When creating the prototype of implicit assignment operators the
returned reference to the cl
Author: stulova
Date: Thu Jan 31 07:23:48 2019
New Revision: 352760
URL: http://llvm.org/viewvc/llvm-project?rev=352760&view=rev
Log:
[OpenCL] Fixed addr space manging test.
Fixed typo in the Filecheck directive and changed the
test to verify output correctly.
Fixes PR40029!
Modified:
cfe/
Author: stulova
Date: Fri Nov 16 08:22:56 2018
New Revision: 347059
URL: http://llvm.org/viewvc/llvm-project?rev=347059&view=rev
Log:
[OpenCL] Enable address spaces for references in C++
Added references to the addr spaces deduction and enabled
CL2.0 features (program scope variables and storage
Author: stulova
Date: Mon Nov 19 03:00:14 2018
New Revision: 347189
URL: http://llvm.org/viewvc/llvm-project?rev=347189&view=rev
Log:
[OpenCL] Fix address space deduction in template args.
Don't deduce address spaces for non-pointer-like types
in template args.
Fixes PR38603!
Differential Revis
ere
LangAS ImpAddr;
On Mon, Nov 19, 2018 at 12:02 PM Anastasia Stulova via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: stulova
Date: Mon Nov 19 03:00:14 2018
New Revision: 347189
URL: http://llvm.org/viewvc/llvm-project?rev=347189&view=rev
Log:
[OpenCL] Fix address s
Author: stulova
Date: Mon Nov 19 04:43:39 2018
New Revision: 347196
URL: http://llvm.org/viewvc/llvm-project?rev=347196&view=rev
Log:
Fixed uninitialized variable issue.
This commit should fix failing bots.
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Sema/SemaType.cpp
Author: stulova
Date: Thu Nov 29 06:11:15 2018
New Revision: 347865
URL: http://llvm.org/viewvc/llvm-project?rev=347865&view=rev
Log:
[OpenCL] Improve diags for addr spaces in templates
Fix ICEs on template instantiations that were leading to
the creation of invalid code patterns with address spa
Author: stulova
Date: Wed Dec 5 09:02:22 2018
New Revision: 348382
URL: http://llvm.org/viewvc/llvm-project?rev=348382&view=rev
Log:
[OpenCL] Diagnose conflicting address spaces in templates.
Added new diagnostic when templates are instantiated with
different address space from the one provided
Author: stulova
Date: Wed Mar 6 05:02:41 2019
New Revision: 355499
URL: http://llvm.org/viewvc/llvm-project?rev=355499&view=rev
Log:
[PR40778] Add addr space conversion when binding reference to a temporary.
This change fixes temporary materialization to happen in the right
(default) address spa
Author: stulova
Date: Thu Mar 7 08:23:15 2019
New Revision: 355606
URL: http://llvm.org/viewvc/llvm-project?rev=355606&view=rev
Log:
[PR40778] Preserve addr space in Derived to Base cast.
The address space for the Base class pointer when up-casting
from Derived should be taken from the Derived c
Author: stulova
Date: Thu Mar 7 08:43:41 2019
New Revision: 355608
URL: http://llvm.org/viewvc/llvm-project?rev=355608&view=rev
Log:
[PR40778][Sema] Adjust addr space of operands in builtin operators.
Adjust address space for references and pointer operands of builtin operators.
Currently this
Author: stulova
Date: Thu Mar 7 09:06:30 2019
New Revision: 355609
URL: http://llvm.org/viewvc/llvm-project?rev=355609&view=rev
Log:
[Sema] Change addr space diagnostics in casts to follow C++ style.
This change adds a new diagnostic for mismatching address spaces
to be used for C++ casts (only
Author: stulova
Date: Tue Mar 12 05:46:56 2019
New Revision: 355915
URL: http://llvm.org/viewvc/llvm-project?rev=355915&view=rev
Log:
[PR41007][OpenCL] Allow printf in C++ mode.
As for OpenCL C, we need to allow using printf and toolchain variadic
functions (prefixed by "__") in C++ mode.
Differ
Author: stulova
Date: Tue Mar 19 06:04:17 2019
New Revision: 356450
URL: http://llvm.org/viewvc/llvm-project?rev=356450&view=rev
Log:
[OpenCL] Improved testing of default header.
Improved some checks and moved testing of the default header
in C++ mode into the Headers folder.
Differential Revisi
Author: stulova
Date: Tue Mar 19 09:50:21 2019
New Revision: 356475
URL: http://llvm.org/viewvc/llvm-project?rev=356475&view=rev
Log:
[Sema] Adjust addr space of reference operand in compound assignment
When we create overloads for the builtin compound assignment operators
we need to preserve add
Author: stulova
Date: Tue Mar 19 10:09:06 2019
New Revision: 356479
URL: http://llvm.org/viewvc/llvm-project?rev=356479&view=rev
Log:
[OpenCL] Minor improvements in default header testing
Differential Revision: https://reviews.llvm.org/D59544
Modified:
cfe/trunk/test/Headers/opencl-c-header
Author: stulova
Date: Mon Mar 25 04:54:02 2019
New Revision: 356888
URL: http://llvm.org/viewvc/llvm-project?rev=356888&view=rev
Log:
[OpenCL] Allow addr space spelling without __ prefix in C++.
For backwards compatibility we allow alternative spelling of address
spaces - 'private', 'local', 'glo
Author: stulova
Date: Tue Mar 26 04:22:37 2019
New Revision: 356987
URL: http://llvm.org/viewvc/llvm-project?rev=356987&view=rev
Log:
[OpenCL] Allow variadic macros as Clang feature.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
cfe/trunk/lib/Lex/PPDirectives.cpp
cfe/
Author: stulova
Date: Thu Mar 28 04:47:14 2019
New Revision: 357162
URL: http://llvm.org/viewvc/llvm-project?rev=357162&view=rev
Log:
[PR41247] Fixed parsing of private keyword in C++.
Fixed bug in C++ to prevent parsing 'private' as a
valid address space qualifier.
Differential Revision: https:
Author: stulova
Date: Thu Apr 4 03:48:36 2019
New Revision: 357682
URL: http://llvm.org/viewvc/llvm-project?rev=357682&view=rev
Log:
[PR41276] Fixed incorrect generation of addr space cast for 'this' in C++.
Improved classification of address space cast when qualification
conversion is performe
Author: stulova
Date: Thu Apr 4 04:08:51 2019
New Revision: 357684
URL: http://llvm.org/viewvc/llvm-project?rev=357684&view=rev
Log:
[PR41157][OpenCL] Prevent implicit init of local addr space var in C++ mode.
Prevent adding initializers implicitly to variables declared in
local address space. T
Author: stulova
Date: Thu May 2 07:40:40 2019
New Revision: 359789
URL: http://llvm.org/viewvc/llvm-project?rev=359789&view=rev
Log:
[OpenCL] Deduce static data members to __global addr space.
Similarly to static variables in OpenCL, static class data
members should be deduced to __global addr s
Author: stulova
Date: Thu May 2 09:10:50 2019
New Revision: 359798
URL: http://llvm.org/viewvc/llvm-project?rev=359798&view=rev
Log:
[OpenCL] Fix initialisation of this via pointer.
When the expression used to initialise 'this' has a pointer type,
check the address space of the pointee type inst
Author: stulova
Date: Tue May 7 07:22:34 2019
New Revision: 360152
URL: http://llvm.org/viewvc/llvm-project?rev=360152&view=rev
Log:
[OpenCL] Prevent mangling kernel functions.
Kernel function names have to be preserved as in the original
source to be able to access them from the host API side.
Author: stulova
Date: Wed May 8 07:23:49 2019
New Revision: 360258
URL: http://llvm.org/viewvc/llvm-project?rev=360258&view=rev
Log:
[Sema][OpenCL] Make address space conversions a bit stricter.
The semantics for converting nested pointers between address
spaces are not very well defined. Some c
Author: stulova
Date: Thu May 9 03:25:45 2019
New Revision: 360325
URL: http://llvm.org/viewvc/llvm-project?rev=360325&view=rev
Log:
[SPIR] Simplified target checking.
Switched to Triple::isSPIR() helper to simplify code.
Patch by kpet (Kevin Petit)!
Differential revision: https://reviews.llvm
Author: stulova
Date: Thu May 9 04:55:24 2019
New Revision: 360330
URL: http://llvm.org/viewvc/llvm-project?rev=360330&view=rev
Log:
[OpenCL] Switched CXX mode to be derived from C++17
Differential revision: https://reviews.llvm.org/D61506
Modified:
cfe/trunk/include/clang/Frontend/LangSta
Author: stulova
Date: Thu May 9 06:55:44 2019
New Revision: 360342
URL: http://llvm.org/viewvc/llvm-project?rev=360342&view=rev
Log:
[OpenCL] Make global ctor init function a kernel
We need to be able to enqueue internal function that initializes
global constructors on the host side. Therefore i
Author: stulova
Date: Mon Sep 24 07:21:56 2018
New Revision: 342885
URL: http://llvm.org/viewvc/llvm-project?rev=342885&view=rev
Log:
Revert "We allow implicit function declarations as an extension in all C
dialects. Remove OpenCL special case."
Discussed on cfe-commits (Week-of-Mon-20180820), t
Author: stulova
Date: Tue Feb 5 03:32:58 2019
New Revision: 353160
URL: http://llvm.org/viewvc/llvm-project?rev=353160&view=rev
Log:
Fix ICE on reference binding with mismatching addr spaces.
When we attempt to add an addr space qual to a type already
qualified by an addr space ICE is triggered.
Author: stulova
Date: Thu Feb 7 09:32:37 2019
New Revision: 353431
URL: http://llvm.org/viewvc/llvm-project?rev=353431&view=rev
Log:
[OpenCL][PR40603] In C++ preserve compatibility with OpenCL C v2.0
Valid OpenCL C code should still compile in C++ mode.
This change enables extensions and OpenCL
Author: stulova
Date: Fri Feb 15 04:07:57 2019
New Revision: 354121
URL: http://llvm.org/viewvc/llvm-project?rev=354121&view=rev
Log:
[OpenCL][PR40707] Allow OpenCL C types in C++ mode.
Allow all OpenCL types to be parsed in C++ mode.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticParseK
Author: stulova
Date: Thu Sep 7 10:00:33 2017
New Revision: 312728
URL: http://llvm.org/viewvc/llvm-project?rev=312728&view=rev
Log:
[OpenCL] Handle taking an address of block captures.
Block captures can have different physical locations
in memory segments depending on the use case (as a functi
Author: stulova
Date: Thu May 30 08:18:07 2019
New Revision: 362102
URL: http://llvm.org/viewvc/llvm-project?rev=362102&view=rev
Log:
[OpenCL] Fix OpenCL/SPIR version metadata in C++ mode.
C++ is derived from OpenCL v2.0 therefore set the versions
identically.
Differential Revision: https://revi
Author: stulova
Date: Mon Jun 3 08:42:36 2019
New Revision: 362409
URL: http://llvm.org/viewvc/llvm-project?rev=362409&view=rev
Log:
[PR41567][Sema] Fixed cast kind in addr space conversions
This change sets missing cast kind correctly in the address
space conversion case.
Differential Revision
Author: stulova
Date: Wed Jun 5 07:03:34 2019
New Revision: 362604
URL: http://llvm.org/viewvc/llvm-project?rev=362604&view=rev
Log:
[Sema] Prevent binding incompatible addr space ref to temporaries
References to arbitrary address spaces can't always be bound to
temporaries. This change extends
Author: stulova
Date: Wed Jun 5 07:50:01 2019
New Revision: 362611
URL: http://llvm.org/viewvc/llvm-project?rev=362611&view=rev
Log:
[OpenCL][PR42031] Prevent deducing addr space in type alias.
Similar to typedefs we shouldn't deduce addr space in
type alias.
Differential Revision: https://re
Author: stulova
Date: Wed Jun 5 10:29:00 2019
New Revision: 362623
URL: http://llvm.org/viewvc/llvm-project?rev=362623&view=rev
Log:
[Clang] Fix pretty printing of CUDA address spaces
Patch by richardmembarth (Richard Membarth)!
Differential Revision: https://reviews.llvm.org/D54258
Modified:
Author: stulova
Date: Thu Jun 20 09:23:28 2019
New Revision: 363944
URL: http://llvm.org/viewvc/llvm-project?rev=363944&view=rev
Log:
[Sema] Diagnose addr space mismatch while constructing objects
If we construct an object in some arbitrary non-default addr space
it should fail unless either:
- T
Author: stulova
Date: Mon Jul 15 04:58:10 2019
New Revision: 366059
URL: http://llvm.org/viewvc/llvm-project?rev=366059&view=rev
Log:
[OpenCL][PR41727] Prevent ICE on global dtors
Pass NULL to pointer arg of __cxa_atexit if addr space
is not matching with its param. This doesn't align yet
with ho
Author: stulova
Date: Mon Jul 15 06:02:21 2019
New Revision: 366063
URL: http://llvm.org/viewvc/llvm-project?rev=366063&view=rev
Log:
[OpenCL] Deduce addr space for pointee of dependent types in instantiation.
Since pointee doesn't require context sensitive addr space deduction
it's easier to han
Author: stulova
Date: Wed Jul 17 10:21:31 2019
New Revision: 366351
URL: http://llvm.org/viewvc/llvm-project?rev=366351&view=rev
Log:
[Docs][OpenCL] Documentation of C++ for OpenCL mode
Added documentation of C++ for OpenCL mode into Clang
User Manual and Language Extensions document.
Differenti
Author: stulova
Date: Thu Jul 18 02:12:49 2019
New Revision: 366417
URL: http://llvm.org/viewvc/llvm-project?rev=366417&view=rev
Log:
[OpenCL][PR42033] Fix addr space deduction with template parameters
If dependent types appear in pointers or references we allow addr
space deduction because the a
Author: stulova
Date: Thu Jul 18 03:02:35 2019
New Revision: 366421
URL: http://llvm.org/viewvc/llvm-project?rev=366421&view=rev
Log:
[OpenCL] Update comments/diagnostics to refer to C++ for OpenCL
Clang doesn't implement OpenCL C++, change the comments to
reflect that.
Differential Revision: ht
+ cfe-commits
From: Anastasia Stulova
Sent: 23 July 2019 15:16
To: Hans Wennborg
Cc: Marco Antognini
Subject: Re: r366694 - [NFC] Relaxed regression tests for PR42665
@Hans, would it be possible to merge this commit along with r366670 to the
release 9.0?
FY
Great! Thanks!
From: Hans Wennborg
Sent: 23 July 2019 15:58
To: Anastasia Stulova
Cc: Marco Antognini ; Clang Commits
; nd
Subject: Re: r366694 - [NFC] Relaxed regression tests for PR42665
Merged them both in r366814.
Thanks,
Hans
On Tue, Jul 23, 2019 at 7:
Author: stulova
Date: Thu Jul 25 04:04:29 2019
New Revision: 367008
URL: http://llvm.org/viewvc/llvm-project?rev=367008&view=rev
Log:
[OpenCL] Rename lang mode flag for C++ mode
Rename lang mode flag to -cl-std=clc++/-cl-std=CLC++
or -std=clc++/-std=CLC++.
This aligns with OpenCL C conversion an
Author: stulova
Date: Fri Aug 2 04:19:35 2019
New Revision: 367675
URL: http://llvm.org/viewvc/llvm-project?rev=367675&view=rev
Log:
[OpenCL] Allow OpenCL C style vector initialization in C++
Allow creating vector literals from other vectors.
float4 a = (float4)(1.0f, 2.0f, 3.0f, 4.0f);
float
Author: stulova
Date: Mon Aug 5 02:50:28 2019
New Revision: 367823
URL: http://llvm.org/viewvc/llvm-project?rev=367823&view=rev
Log:
[OpenCL] Fix vector literal test broken in rL367675.
Avoid checking alignment unnecessary that is not portable
among targets.
Modified:
cfe/trunk/test/CodeGe
Anastasia,
This commit broke ARMv8 bots, logs are available here:
http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/14655/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Avector_literals_valid.cl
Thanks,
Yvan
On Fri, 2 Aug 2019 at 13:18, Anastasia Stulova via cfe-commits
wrote
Author: stulova
Date: Mon Aug 12 03:44:07 2019
New Revision: 368552
URL: http://llvm.org/viewvc/llvm-project?rev=368552&view=rev
Log:
[OpenCL] Fix lang mode predefined macros for C++ mode.
In C++ mode we should only avoid adding __OPENCL_C_VERSION__,
all other predefined macros about the language
Hi Hans,
Can this be merged into the release 9.0 branch please?
Thank you!
Anastasia
From: cfe-commits on behalf of Sven van
Haastregt via cfe-commits
Sent: 12 August 2019 13:44
To: cfe-commits@lists.llvm.org
Subject: r368561 - [OpenCL] Ignore parentheses fo
Hi Hans,
Can this be merged into the release 9.0 branch please?
Thank you!
Anastasia
From: cfe-commits on behalf of Anastasia
Stulova via cfe-commits
Sent: 12 August 2019 11:44
To: cfe-commits@lists.llvm.org
Subject: r368552 - [OpenCL] Fix lang mode
Author: stulova
Date: Mon Aug 19 04:43:16 2019
New Revision: 369251
URL: http://llvm.org/viewvc/llvm-project?rev=369251&view=rev
Log:
[OpenCL] Fix addr space deduction for pointers/references to arrays.
Rewrite the logic for detecting if we are deducing addr space of
a pointee type to take into a
Hi Hans,
Is it still possible to port this fix to the release branch?
Thanks,
Anastasia
From: cfe-commits on behalf of Anastasia
Stulova via cfe-commits
Sent: 19 August 2019 12:43
To: cfe-commits@lists.llvm.org
Subject: r369251 - [OpenCL] Fix addr space
Author: stulova
Date: Fri Jun 21 03:50:02 2019
New Revision: 364023
URL: http://llvm.org/viewvc/llvm-project?rev=364023&view=rev
Log:
[Sema] Improved diagnostic for qualifiers in reference binding
Improved wording and also simplified by using printing
method from qualifiers.
Differential Revisio
Author: stulova
Date: Fri Jun 21 04:36:15 2019
New Revision: 364032
URL: http://llvm.org/viewvc/llvm-project?rev=364032&view=rev
Log:
[Sema] Fix diagnostic for addr spaces in reference binding
Extend reference binding behavior to account for address spaces.
Differential Revision: https://reviews
Author: stulova
Date: Fri Jun 21 09:19:16 2019
New Revision: 364071
URL: http://llvm.org/viewvc/llvm-project?rev=364071&view=rev
Log:
[OpenCL][PR41963] Add generic addr space to old atomics in C++ mode
Add overloads with generic address space pointer to old atomics.
This is currently only added f
Author: stulova
Date: Fri Jan 4 03:50:36 2019
New Revision: 350386
URL: http://llvm.org/viewvc/llvm-project?rev=350386&view=rev
Log:
[Basic] Extend DiagnosticEngine to store and format Qualifiers.
Qualifiers can now be streamed into the DiagnosticEngine using
regular << operator. If Qualifiers
Author: stulova
Date: Wed Jan 9 03:25:09 2019
New Revision: 350703
URL: http://llvm.org/viewvc/llvm-project?rev=350703&view=rev
Log:
Use DeclSpec for quals in DeclaratorChunk::FunctionTypeInfo.
Rather than duplicating data fields, use DeclSpec directly to store
the qualifiers for the functions/m
Author: stulova
Date: Thu Apr 12 07:17:04 2018
New Revision: 329911
URL: http://llvm.org/viewvc/llvm-project?rev=329911&view=rev
Log:
[OpenCL] Added -std/-cl-std=c++
This is std option for OpenCL C++ v1.0.
Differential Revision: https://reviews.llvm.org/D45363
Modified:
cfe/trunk/include/c
Author: Anastasia Stulova
Date: 2020-07-27T15:18:49+01:00
New Revision: 92fa91bb402921a5705507c38f583e9b8e9d84e4
URL:
https://github.com/llvm/llvm-project/commit/92fa91bb402921a5705507c38f583e9b8e9d84e4
DIFF:
https://github.com/llvm/llvm-project/commit/92fa91bb402921a5705507c38f583e9b8e9d84e4.d
Author: Anastasia Stulova
Date: 2020-06-04T13:29:30+01:00
New Revision: 4a4402f0d72167477a6252e4c3daf5089ebc8f9a
URL:
https://github.com/llvm/llvm-project/commit/4a4402f0d72167477a6252e4c3daf5089ebc8f9a
DIFF:
https://github.com/llvm/llvm-project/commit/4a4402f0d72167477a6252e4c3daf5089ebc8f9a.d
Author: Anastasia Stulova
Date: 2020-07-10T19:04:49+01:00
New Revision: 8c8a2fd1f015525d048444610a6e27c66aa96293
URL:
https://github.com/llvm/llvm-project/commit/8c8a2fd1f015525d048444610a6e27c66aa96293
DIFF:
https://github.com/llvm/llvm-project/commit/8c8a2fd1f015525d048444610a6e27c66aa96293.d
Author: Anastasia Stulova
Date: 2020-07-13T11:44:38+01:00
New Revision: 6050c156ab4f13a3c54ca6ec297a72ece95966d7
URL:
https://github.com/llvm/llvm-project/commit/6050c156ab4f13a3c54ca6ec297a72ece95966d7
DIFF:
https://github.com/llvm/llvm-project/commit/6050c156ab4f13a3c54ca6ec297a72ece95966d7.d
Author: Anastasia Stulova
Date: 2020-04-28T12:46:36+01:00
New Revision: fe667e8522a6be5f73b2aed1adf4ec92d0470695
URL:
https://github.com/llvm/llvm-project/commit/fe667e8522a6be5f73b2aed1adf4ec92d0470695
DIFF:
https://github.com/llvm/llvm-project/commit/fe667e8522a6be5f73b2aed1adf4ec92d0470695.d
Author: Anastasia Stulova
Date: 2020-08-12T16:17:54+01:00
New Revision: 3c8a4ee0764cafb2ba204c7cb7d8b37e6adf72a8
URL:
https://github.com/llvm/llvm-project/commit/3c8a4ee0764cafb2ba204c7cb7d8b37e6adf72a8
DIFF:
https://github.com/llvm/llvm-project/commit/3c8a4ee0764cafb2ba204c7cb7d8b37e6adf72a8.d
Author: Anastasia Stulova
Date: 2020-05-18T12:07:54+01:00
New Revision: a6a237f2046ad8993db30481c8b61aeb2f73a5ad
URL:
https://github.com/llvm/llvm-project/commit/a6a237f2046ad8993db30481c8b61aeb2f73a5ad
DIFF:
https://github.com/llvm/llvm-project/commit/a6a237f2046ad8993db30481c8b61aeb2f73a5ad.d
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
https://reviews.llvm.org/D24626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7600
@@ +7599,3 @@
+// Do not diagnose half type since it is diagnosed as invalid argument
+// type for any function eleswhere.
+if (!PT->isHalfType())
-> elsewhere
https://reviews.ll
Anastasia added a comment.
In https://reviews.llvm.org/D21698#546733, @yaxunl wrote:
> In https://reviews.llvm.org/D21698#540237, @Anastasia wrote:
>
> > I have made an experiment with a simple kernel:
> >
> > void foo1(void);
> > void foo2(void);
> > void foo3(void);
> > void foo4(void);
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Anastasia added inline comments.
Comment at: include/clang/Basic/OpenCLOptions.h:39
@@ +38,3 @@
+
+ void set(llvm::StringRef Ext, bool Enable = true) {
+assert(!Ext.empty() && "Extension is empty.");
yaxunl wrote:
> Better add a comments for this function abo
Anastasia added a comment.
Sam, I ran a few more tests and understood that the overhead mainly comes from
extra initialization (in Sema::Initialize()). Therefore, it's more noticeable
on a very small kernels. However, I agree we can probably neglect the overhead
as it account for only a couple
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D25123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Anastasia added a comment.
> Regarding the improvement proposed by us which "flatten" captured variables
> into invoke_function argument list and block_literal pointer wouldn't be
> passed as first argument(to invoke_function) anymore. The reason why it
> doesn't require global memory managem
Anastasia added a comment.
However, it seems like we didn't provide quite complete implementation with
respect to the captures yet as it's not possible at the moment for
__enqueue_kernel_XXX to know the size of the captures or even the block literal
struct itself to be able to copy the block da
Anastasia added a comment.
Do you have any code example where Clang/LLVM performs wrong optimizations with
respect to the control flow of SPMD execution?
My understanding from the earlier discussion we have had:
https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg22643.html that
nodupli
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/CodeGenOpenCL/partial_initializer.cl:5
+
+// CHECK: @GA = addrspace(1) global [6 x [6 x float]] {{[[][[]}}6 x float]
[float 1.00e+00, float
Author: Anastasia Stulova
Date: 2022-09-01T10:22:47+01:00
New Revision: 6b1a04529c8fba4019b3a7f56fe6e4938f3a188a
URL:
https://github.com/llvm/llvm-project/commit/6b1a04529c8fba4019b3a7f56fe6e4938f3a188a
DIFF:
https://github.com/llvm/llvm-project/commit/6b1a04529c8fba4019b3a7f56fe6e4938f3a188a.d
Author: Anastasia Stulova
Date: 2021-07-22T16:47:38+01:00
New Revision: b510e0127da38d47b9224b082842e827c04947a8
URL:
https://github.com/llvm/llvm-project/commit/b510e0127da38d47b9224b082842e827c04947a8
DIFF:
https://github.com/llvm/llvm-project/commit/b510e0127da38d47b9224b082842e827c04947a8.d
1 - 100 of 637 matches
Mail list logo
