Do you plan to fix diagnostic emission for cases like "bool b : 4" in the
near future, or it makes sense to revert this change until we reach
consensus on the rules, and implementation?
On Fri, Sep 18, 2015 at 11:17 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Sep
samsonov added a subscriber: samsonov.
samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
LGTM
http://reviews.llvm.org/D12840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
samsonov added a subscriber: samsonov.
samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
This revision is now accepted and ready to land.
OK to submit after compiler-rt support is submitted.
http://reviews.llvm.org/D13109
_
samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D13122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
samsonov added inline comments.
Comment at: runtime/CMakeLists.txt:33
@@ -32,1 +32,3 @@
+ )
+set(cmake_3_4_USES_TERMINAL USES_TERMINAL 1)
endif()
Should this also be named cmake_3_4_USES_TERMINAL_OPTIONS?
Comment at: runtime/CMakeList
samsonov added a comment.
Driver changes look good.
http://reviews.llvm.org/D11857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov created this revision.
samsonov added a reviewer: EricWF.
samsonov added a subscriber: cfe-commits.
We are going to remove the former soon.
http://reviews.llvm.org/D12117
Files:
test/libcxx/containers/sequences/vector/asan.pass.cpp
Index: test/libcxx/containers/sequences/vector/asan.
samsonov added a comment.
Yes. Is this is an issue?
http://reviews.llvm.org/D12117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245467: Replace __asan_set_error_exit_code() with
__sanitizer_set_death_callback() (authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D12117?vs=32456&id=32572#toc
Repository:
rL
Author: samsonov
Date: Wed Aug 19 12:28:01 2015
New Revision: 245467
URL: http://llvm.org/viewvc/llvm-project?rev=245467&view=rev
Log:
Replace __asan_set_error_exit_code() with __sanitizer_set_death_callback()
Summary: We are going to remove the former soon.
Reviewers: EricWF
Subscribers: cfe-c
samsonov added a comment.
Please upload the patch with more context (see
http://llvm.org/docs/Phabricator.html).
Comment at: tools/clang/include/clang/Driver/Options.td:610
@@ -608,1 +609,3 @@
+ Flags<[CC1Option, CoreOption]>,
+
samsonov created this revision.
samsonov added reviewers: rsmith, pcc.
samsonov added a subscriber: cfe-commits.
http://reviews.llvm.org/D12215
Files:
lib/ubsan/ubsan_checks.inc
lib/ubsan/ubsan_diag.cc
lib/ubsan/ubsan_diag.h
lib/ubsan/ubsan_flags.inc
lib/ubsan/ubsan_handlers.cc
lib/ub
samsonov added a comment.
See https://llvm.org/bugs/show_bug.cgi?id=24443 (it's worth including this
reference to change description).
http://reviews.llvm.org/D12181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
samsonov added a comment.
Overall, this looks reasonable to me, but I'd like Richard to confirm he's fine
with this change as well.
Comment at: docs/UsersManual.rst:1121
@@ +1120,3 @@
+ Instruct code generator to emit a function call to the specified
+ function name instead
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_flags.inc:26
@@ +25,2 @@
+UBSAN_FLAG(bool, report_error_type, false,
+"Print specific error type instead of 'undefined-behavior' in
summary.")
filcab wrote:
> Do we care that much about keeping t
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, "%0 null pointer of type %1")
<< TypeCheckKinds[Data->TypeCheckKind] << Data->Type;
--
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, "%0 null pointer of type %1")
<< TypeCheckKinds[Data->TypeCheckKind] << Data->Type;
--
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245897: [UBSan] Add the ability to print more precise error
kind in summary line. (authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D12215?vs=32753&id=33019#toc
Repository:
rL
samsonov added a comment.
See my comment in a different CL - I would strongly prefer to not touch
autoconf build system unless absolutely necessary.
Repository:
rL LLVM
http://reviews.llvm.org/D12401
___
cfe-commits mailing list
cfe-commits@list
Author: samsonov
Date: Thu Sep 3 14:11:42 2015
New Revision: 246795
URL: http://llvm.org/viewvc/llvm-project?rev=246795&view=rev
Log:
Add -target flag to Clang invocations in this test.
ASan may not be supported for the default target triple.
Modified:
cfe/trunk/test/Driver/fsanitize-blackl
Author: samsonov
Date: Thu Sep 3 15:53:14 2015
New Revision: 246804
URL: http://llvm.org/viewvc/llvm-project?rev=246804&view=rev
Log:
Add target flag to clang-cl invocation in this test.
Modified:
cfe/trunk/test/Driver/fsanitize-coverage.c
Modified: cfe/trunk/test/Driver/fsanitize-coverage.
samsonov added inline comments.
Comment at: runtime/CMakeLists.txt:41
@@ +40,3 @@
+
+ add_custom_target(compiler-rt-clear
+DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/compiler-rt-cleared
So, that's the target that you can invoke manually to clean compiler-rt build?
samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.
Looks pretty good. I'm still not convinced with your -Werror arguments, and
will be unavailable during the next week, so feel free to land it, provided
we'll return to the discussion later
After this change I am unable to configure libcxx as external project from
compiler-rt with extra build flags.
The problem is gen_link_script.py is invoked with incorrect number of
arguments: LIBCXX_CXX_ABI_LIBNAME is automatically deduced to be "none",
and LIBCXX_CXX_ABI_LIBRARY which is passed to
Seems to work now, thanks for the quick fix!
On Thu, Oct 22, 2015 at 1:57 PM, Eric Fiselier wrote:
> Hi Alexey,
>
> Please confirm that this works for you now after r251063. Sorry for the
> breakage.
>
> /Eric
>
> On Thu, Oct 22, 2015 at 9:23 AM, Alexey Samsonov
> wrote:
>
>> After this change
Do we need to port this to CMake as well?
On Fri, Oct 30, 2015 at 9:30 AM, Tim Northover via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: tnorthover
> Date: Fri Oct 30 11:30:51 2015
> New Revision: 251712
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251712&view=rev
> Log:
> Supp
samsonov added a subscriber: samsonov.
Comment at: lib/CodeGen/CGExpr.cpp:2494
@@ +2493,3 @@
+ llvm::Value *ValidVtable = nullptr;
+ if (CheckAndAppendValidVtable) {
+llvm::Value *AllVtables = llvm::MetadataAsValue::get(
This is really ugly. Why are you not
samsonov added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2642
@@ +2641,3 @@
+ llvm::MDString::get(CGM.getLLVMContext(), "all-vtables"));
+ llvm::Value *ValidVtable = Builder.CreateZExt(
+ Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::bitset_test),
-
samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/CGClass.cpp:2608
@@ -2607,3 +2607,3 @@
auto TypeId = CGM.CreateCfiIdForTypeMetadata(MD);
if (CGM.ge
I see bogus boostrap build failures when we're trying to use just-built
Clang to build libc++:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/22540/steps/bootstrap%20clang/logs/stdio
Do you think it can be related to one of your changes? I'm pretty sure the
contents of /usr/inclu
Author: samsonov
Date: Fri Feb 12 19:02:59 2016
New Revision: 260779
URL: http://llvm.org/viewvc/llvm-project?rev=260779&view=rev
Log:
Disable two tests that use a lot of stack under ASan.
Modified:
cfe/trunk/test/Index/index-many-call-ops.cpp
cfe/trunk/test/Index/index-many-logical-ops.c
Author: samsonov
Date: Wed Mar 9 18:20:37 2016
New Revision: 263081
URL: http://llvm.org/viewvc/llvm-project?rev=263081&view=rev
Log:
EmitCXXStructorCall -> EmitCXXDestructorCall. NFC.
This function is only used in Microsoft ABI and only to emit
destructors. Rename/simplify it accordingly.
Modi
Author: samsonov
Date: Wed Mar 9 18:20:33 2016
New Revision: 263080
URL: http://llvm.org/viewvc/llvm-project?rev=263080&view=rev
Log:
Remove unused function arguments. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGExprCXX.cpp
Modified: cfe/trunk/lib/CodeGen/CGExprCXX.cpp
URL:
http://llvm.org/view
On Mon, Mar 14, 2016 at 9:50 AM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 14 Mar 2016 6:28 a.m., "Benjamin Kramer via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Author: d0k
> > Date: Mon Mar 14 08:23:58 2016
> > New Revision: 263429
> >
> > URL: http
On Mon, Mar 14, 2016 at 8:55 AM, Evgenii Stepanov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Mar 14, 2016 at 8:48 AM, Benjamin Kramer
> wrote:
> > On Mon, Mar 14, 2016 at 3:59 PM, David Blaikie
> wrote:
> >> Yeah - how are they relying on them in a non-asserts build anyway?
>
samsonov added a comment.
Cool, great to see this coming. I'll let Kuba sign this off.
Comment at: test/Driver/fsanitize.c:220
@@ -219,1 +219,3 @@
+// RUN: %clang -target x86_64-apple-darwin10 -fsanitize=thread %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-TSAN-X86-64-DARW
Heads-up: I see segmentation faults in Clang following this revision. I
will try to come up with a standalone reproducer and update
https://llvm.org/bugs/show_bug.cgi?id=26942, possibly reverting this change.
On Thu, Mar 24, 2016 at 6:30 AM, Amjad Aboud via cfe-commits <
cfe-commits@lists.llvm.org
I've been using no-asserts build, and it led to segfault, so probably it
was required. I see that Reid already proceeded with the revert. I will
still work on a reproducer.
On Thu, Mar 24, 2016 at 1:43 PM, Aboud, Amjad wrote:
> I believe it is safe to disable the assertion.
>
> I added this asse
On Fri, Mar 25, 2016 at 10:55 AM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: sbenza
>> Date: Fri Mar 25 12:46:02 2016
>> New Revision: 264428
>>
>> U
Interesting. Do we run test/asan/TestCases/suppressions-interceptor.cc on
Windows? Seems so: I don't see an XFAIL there, and it also uses
suppressions, but with single quote, followed by double quote:
%env_asan_opts=suppressions='"%t.supp"'
Why does it work there?
On Tue, Dec 22, 2015 at 4:35 PM
samsonov added a comment.
Sorry, lost track of this.
Comment at: lib/Driver/ToolChains.cpp:368
@@ +367,3 @@
+ StringRef OS = "";
+ if (isTargetMacOS())
+OS = "osx";
zaks.anna wrote:
> samsonov wrote:
> > Wait, this looks horrible. Can we teach toolchain to
samsonov added a comment.
Sorry for delay.
Comment at: lib/CodeGen/CGExpr.cpp:2543
@@ +2542,3 @@
+ // RE: Bug: 25682
+ if(!CGM.getCodeGenOpts().MergeTraps ||
!CGM.getCodeGenOpts().OptimizationLevel || !TrapBB) {
+// If we aren't merging traps, set the function to not be o
On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote:
> thakis added a comment.
>
> After some more debugging, the only thing in this test that's still
> faiilng on Windows is the "unsigned-integer-overflow:do_overflow"
> suppression -- when llvm-symbolizer gets symbols from PDBs it currently
> req
samsonov added a comment.
Thanks.
Comment at: lib/Driver/ToolChains.cpp:322
@@ -321,1 +321,3 @@
+StringRef Darwin::getOSLibraryNameSuffix() const {
+ if (isTargetMacOS())
Fun fact: if TargetPlatform is `TvOSSimulator`, this function will return
`iossim` beca
On Thu, Jan 21, 2016 at 10:20 AM, Nico Weber wrote:
> On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov
> wrote:
>
>>
>> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote:
>>
>>> thakis added a comment.
>>>
>>> After some more debugging, the only thing in this test that's still
>>> faiilng on W
samsonov added a comment.
In http://reviews.llvm.org/D15225#328218, @zaks.anna wrote:
> > I see, so essentially you want to use a different approach for determining
> > sanitizer availability (on OS X for now): if the library is present, then
> > we support
>
> > sanitizer, otherwise we don't
On Thu, Jan 21, 2016 at 10:58 AM, Reid Kleckner wrote:
> On Thu, Jan 21, 2016 at 10:47 AM, Nico Weber wrote:
>
>> Oh, ok, let's not depend on lld then. So, we need to either determine if
>>> DIA SDK is available at compiler-rt configure time, or teach
>>> llvm-symbolizer.exe to tell us that (as
Author: samsonov
Date: Thu Jan 21 19:35:45 2016
New Revision: 258476
URL: http://llvm.org/viewvc/llvm-project?rev=258476&view=rev
Log:
[Docs] Slightly update LSan documentation.
Modified:
cfe/trunk/docs/AddressSanitizer.rst
cfe/trunk/docs/LeakSanitizer.rst
Modified: cfe/trunk/docs/Addres
samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
LGTM
Comment at: lib/Driver/ToolChains.cpp:339
@@ +338,3 @@
+ }
+}
+
You might need `llvm_unreachable` at the very end to suppress GCC warnings
(http://llvm.org/doc
Thank you for fixing this!
On Fri, Jan 22, 2016 at 12:30 PM, Nico Weber wrote:
> I implemented Reid's suggestion in 258545. I tested that the test runs and
> passes when the DIA SDK is around (this is usually the case), and doesn't
> run when it isn't.
>
> On Thu, Jan 21, 2016 at 2:09 PM, Alexey
Author: samsonov
Date: Fri Jan 29 17:07:14 2016
New Revision: 259260
URL: http://llvm.org/viewvc/llvm-project?rev=259260&view=rev
Log:
[UBSan] Add documentation for runtime issue suppression.
Modified:
cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
Modified: cfe/trunk/docs/UndefinedBehaviorSa
Hans, do you think it makes sense to merge this patch into 3.8?
On Fri, Jan 29, 2016 at 3:07 PM, Alexey Samsonov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: samsonov
> Date: Fri Jan 29 17:07:14 2016
> New Revision: 259260
>
> URL: http://llvm.org/viewvc/ll
e:
> > Hans, do you think it makes sense to merge this patch into 3.8?
> >
> > On Fri, Jan 29, 2016 at 3:07 PM, Alexey Samsonov via cfe-commits
> > wrote:
> >>
> >> Author: samsonov
> >> Date: Fri Jan 29 17:07:14 2016
> >> New Revision
Author: samsonov
Date: Fri Jan 29 18:54:42 2016
New Revision: 259278
URL: http://llvm.org/viewvc/llvm-project?rev=259278&view=rev
Log:
Remove references to autotools build.
Modified:
cfe/trunk/CODE_OWNERS.TXT
cfe/trunk/www/get_started.html
Modified: cfe/trunk/CODE_OWNERS.TXT
URL:
http:/
Author: samsonov
Date: Fri Jan 29 19:11:42 2016
New Revision: 259281
URL: http://llvm.org/viewvc/llvm-project?rev=259281&view=rev
Log:
[docs] Remove references to autoconf build.
Modified:
libcxx/trunk/docs/BuildingLibcxx.rst
Modified: libcxx/trunk/docs/BuildingLibcxx.rst
URL:
http://llvm.o
Looks like Clang::Index/index-many-call-ops.cpp still uses too much stack
in ASan mode:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/10177/steps/check-clang%20asan/logs/stdio
ASan increases the stack usage, so do you think there's more to fix here,
or we should just di
Unfortunately, that change breaks the Clang compilation, see r254041 review
thread.
On Tue, Nov 24, 2015 at 3:54 PM, Richard Smith
wrote:
> On Tue, Nov 24, 2015 at 1:16 PM, Alexey Samsonov
> wrote:
>
>> Looks like Clang::Index/index-many-call-ops.cpp still uses too much stack
>> in ASan mode:
>
Hm, looks like we can't compile Clang itself after this change (with GCC):
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/12237
On Tue, Nov 24, 2015 at 3:50 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Nov 24 17:50:
Unfortunately, the bot still seems to be unhappy:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/12246/steps/build%20fresh%20clang/logs/stdio
On Tue, Nov 24, 2015 at 6:45 PM, Richard Smith
wrote:
> Hah, looks like a rejects-valid, but it found a real bug, so *shrug*. =)
samsonov added a comment.
I agree with Richard here.
Repository:
rL LLVM
http://reviews.llvm.org/D15208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: samsonov
Date: Thu Dec 3 18:38:13 2015
New Revision: 254672
URL: http://llvm.org/viewvc/llvm-project?rev=254672&view=rev
Log:
[Docs] Sanitizer docs migrated from code.google.com to github.com.
Modified:
cfe/trunk/docs/AddressSanitizer.rst
cfe/trunk/docs/LeakSanitizer.rst
cfe/
Author: samsonov
Date: Fri Dec 4 11:30:29 2015
New Revision: 254733
URL: http://llvm.org/viewvc/llvm-project?rev=254733&view=rev
Log:
Clang documentation for UBSan.
Summary:
Create a separate page describing UBSan tool, move the description of
fine-grained checks there, provide extra information
samsonov added a comment.
Thanks! Addressed the comments.
Repository:
rL LLVM
http://reviews.llvm.org/D15217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
samsonov marked 5 inline comments as done.
Closed by commit rL254733: Clang documentation for UBSan. (authored by
samsonov).
Changed prior to commit:
http://reviews.llvm.org/D15217?vs=41823&id=41891#toc
Repository:
rL
Author: samsonov
Date: Fri Dec 4 11:35:47 2015
New Revision: 254734
URL: http://llvm.org/viewvc/llvm-project?rev=254734&view=rev
Log:
[Docs] Remove false claim: UBSan can also be combined with TSan/MSan.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
samsonov created this revision.
samsonov added reviewers: pcc, kcc.
samsonov added a subscriber: cfe-commits.
Before that, all sections were considered a subsection of
"Introduction".
[Docs] Move the list of CFI schemes down to CFI doc, and update it.
http://reviews.llvm.org/D15237
Files:
doc
samsonov updated this revision to Diff 41905.
samsonov marked 3 inline comments as done.
samsonov added a comment.
- Address pcc's comments.
http://reviews.llvm.org/D15237
Files:
docs/ControlFlowIntegrity.rst
docs/UsersManual.rst
Index: docs/UsersManual.rst
samsonov added inline comments.
Comment at: docs/ControlFlowIntegrity.rst:23
@@ -22,6 +22,3 @@
To enable Clang's available CFI schemes, use the flag ``-fsanitize=cfi``.
-As currently implemented, all of Clang's CFI schemes (``cfi-vcall``,
-``cfi-derived-cast``, ``cfi-unrelated-ca
Author: samsonov
Date: Fri Dec 4 15:30:58 2015
New Revision: 254771
URL: http://llvm.org/viewvc/llvm-project?rev=254771&view=rev
Log:
[Docs] Move the list of CFI schemes down to CFI doc, and update it.
Use proper headling levels in CFI doc. Before that, all sections
were considered a subsection
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254771: [Docs] Move the list of CFI schemes down to CFI doc,
and update it. (authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D15237?vs=41905&id=41933#toc
Repository:
rL LLVM
samsonov created this revision.
samsonov added reviewers: eugenis, kcc.
samsonov added a subscriber: cfe-commits.
1. Move MSan-specific flags and features from user manual to MSan page.
2. Update current status / list of supported platforms.
http://reviews.llvm.org/D15246
Files:
docs/MemorySan
samsonov marked 2 inline comments as done.
samsonov added a comment.
Addressed, thanks!
http://reviews.llvm.org/D15246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: samsonov
Date: Fri Dec 4 16:50:44 2015
New Revision: 254788
URL: http://llvm.org/viewvc/llvm-project?rev=254788&view=rev
Log:
[Docs] Update MSan docs
Summary:
1. Move MSan-specific flags and features from user manual to MSan page.
2. Update current status / list of supported platforms.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254788: [Docs] Update MSan docs (authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D15246?vs=41941&id=41946#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15246
Files:
cfe/
Author: samsonov
Date: Fri Dec 4 17:13:14 2015
New Revision: 254798
URL: http://llvm.org/viewvc/llvm-project?rev=254798&view=rev
Log:
[Docs] One more cleanup of -fsanitize= section.
Describe -fsanitize-blacklist flags in separate paragraphs, move
notes about importance of clang++ for vptr down t
samsonov added inline comments.
Comment at: include/clang/Driver/ToolChain.h:410
@@ -407,1 +409,3 @@
+ /// (don't require runtime library).
+ virtual SanitizerMask getSanitizersRequiringTrap() const;
};
I don't think this is relevant to ToolChain at all. `Sanit
Author: samsonov
Date: Mon Dec 7 16:45:36 2015
New Revision: 254961
URL: http://llvm.org/viewvc/llvm-project?rev=254961&view=rev
Log:
Add llvm-objdump to compiler-rt test deps.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.txt
URL:
http://llvm.org/viewvc
Thanks for taking care of this!
On Mon, Dec 7, 2015 at 12:04 PM, Justin Bogner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bogner
> Date: Mon Dec 7 14:04:57 2015
> New Revision: 254935
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254935&view=rev
> Log:
> AST: defer to Type
samsonov added a comment.
Sorry for the late response. Ugh, flag naming is hard, and it's far too
complicated for sanitizers already.
However, I'm opposed to passing this down as `-fsanitize=` option =/. So far
we're trying to make values of `-fsanitize=` correspond *only* to different
kinds o
samsonov added a comment.
That is, I presume it's highly unlikely user will need to have fine-grained
setup for deciding which UBSan checks should be merged, and which should not.
So, probably having a single `-fsanitize-merge-traps` /
`-fno-sanitize-merge-traps` option would be enough. I'd li
samsonov added a comment.
That is, I presume it's highly unlikely user will need to have fine-grained
setup for deciding which UBSan checks should be merged, and which should not.
So, probably having a single `-fsanitize-merge-traps` /
`-fno-sanitize-merge-traps` option would be enough. I'd li
samsonov created this revision.
samsonov added reviewers: rsmith, kcc.
samsonov added a subscriber: cfe-commits.
Add the ability to suppress UBSan reports for files/functions/modules
at runtime. The user can now pass UBSAN_OPTIONS=suppressions=supp.txt
with the contents of the form:
signed-intege
samsonov added a comment.
Please consider adding a test case.
Comment at: include/clang/Basic/LangOptions.h:95
@@ -94,1 +94,3 @@
+ /// \brief Flag controlling whether or not trap calls are merged
+ /// at the end of each function.
Why is it a language, not c
samsonov added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2543
@@ +2542,3 @@
+ // RE: Bug: 25682
+ if(!getLangOpts().mergeTraps) {
+ llvm::InlineAsm *EmptyAsm =
llvm::InlineAsm::get(llvm::FunctionType::get(CGM.VoidTy, false),
danielaustin wrote:
samsonov added inline comments.
Comment at: test/Driver/fsanitize.c:221
@@ +220,3 @@
+// RUN: %clang -target x86_64-apple-darwin10
-resource-dir=%S/Inputs/resource_dir -fsanitize=memory -fsanitize=thread,memory
%s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN-TSAN-MSAN-DARW
samsonov added a comment.
Richard, could you take a look at this?
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov added a comment.
Kostya, PTAL. IIRC it was your feature request :)
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov created this revision.
samsonov added reviewers: rafael, compnerd.
samsonov added a subscriber: cfe-commits.
After this change, AddCXXStdlibLibArgs will check the presence of
-static-libstdc++ flag and, if necessary, wrap -lc++/-lstdc++ in
-Bstatic/-Bdynamic to force static linking of C++
samsonov added a subscriber: samsonov.
Comment at: lib/Driver/ToolChains.cpp:368
@@ +367,3 @@
+ StringRef OS = "";
+ if (isTargetMacOS())
+OS = "osx";
Wait, this looks horrible. Can we teach toolchain to give us OS name?
http://reviews.llvm.org/D15624
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256018: [UBSan] Implement runtime suppressions (PR25066).
(authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D15363?vs=42250&id=43254#toc
Repository:
rL LLVM
http://reviews.llv
samsonov added a comment.
In http://reviews.llvm.org/D15598#314127, @rafael wrote:
> I am not sure what is "expected" is here:
Interesting.
I was assuming that Clang tends to understand "-lstdc++" as a special argument
that says "link against C++ standard library", not "link against
libstdc++
On Fri, Dec 18, 2015 at 3:20 PM, Rafael Espíndola <
rafael.espind...@gmail.com> wrote:
> On 18 December 2015 at 18:13, Alexey Samsonov wrote:
> > samsonov added a comment.
> >
> > In http://reviews.llvm.org/D15598#314127, @rafael wrote:
> >
> >> I am not sure what is "expected" is here:
> >
> >
>
92 matches
Mail list logo
