r262696 - [OPENMP] Simplify handling of clauses with postupdates, NFC.

2016-03-03 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Mar 4 01:21:16 2016 New Revision: 262696 URL: http://llvm.org/viewvc/llvm-project?rev=262696&view=rev Log: [OPENMP] Simplify handling of clauses with postupdates, NFC. Clauses with post-update expressions always have pre-init statement. So OMPClauseWithPreInit now is th

r262699 - [OPENMP 4.0] Codegen for 'declare reduction' construct.

2016-03-04 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Mar 4 03:22:22 2016 New Revision: 262699 URL: http://llvm.org/viewvc/llvm-project?rev=262699&view=rev Log: [OPENMP 4.0] Codegen for 'declare reduction' construct. Emit function for 'combiner' part of 'declare reduction' construct and 'initialilzer' part, if any. Added:

Re: [PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

2016-03-08 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D17979: [OPENMP] Add regression test for codegen of distribute pragma for NVPTX

2016-03-08 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D17979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-08 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentName, Missed 'virt

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

2016-03-08 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:51-52 @@ +50,4 @@ + + // just emit the statements in the teams region, no need for outlining + CGF.EmitStmt(cast(D.getAssociatedStmt())->getCapturedStmt()); +} This will cause a cras

r263002 - [OPENMP 4.5] Codegen for data members in 'linear' clause.

2016-03-09 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Mar 9 03:49:00 2016 New Revision: 263002 URL: http://llvm.org/viewvc/llvm-project?rev=263002&view=rev Log: [OPENMP 4.5] Codegen for data members in 'linear' clause. OpenMP 4.5 allows to use data members in private clauses. Patch adds codegen support for 'linear' clause.

r263003 - [OPENMP 4.5] Codegen for data members in 'linear' clause

2016-03-09 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Mar 9 03:49:09 2016 New Revision: 263003 URL: http://llvm.org/viewvc/llvm-project?rev=263003&view=rev Log: [OPENMP 4.5] Codegen for data members in 'linear' clause OpenMP 4.5 allows privatization of non-static data members in OpenMP constructs. Patch adds proper codegen

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

2016-03-09 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Add tests with captured globals to check that this problem is resolved Repository: rL LLVM http://reviews.llvm.org/D17963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-09 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentName,

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-09 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

2016-03-10 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.h:32-59 @@ +31,30 @@ + /// \param ThreadLimit An integer expression of threads. + virtual void emitNumTeamsClause(CodeGenFu

Re: [PATCH] D18112: [OpenMP] Replace offloading option that start with -o with -fo.

2016-03-13 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D18112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D18105: [OPENMP] Support for codegen of private clause of target, host side

2016-03-13 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D18105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

2016-03-15 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:3466 @@ -3465,1 +3465,3 @@ }; + +/// \brief This represents clause 'from' in the '#pragma omp ...' New clauses must be added in separate patches http://reviews.llvm.org/D15944 _

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

2016-03-15 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:9779-9780 @@ +9778,4 @@ +if (DKind == OMPD_target) { + if(VD && DSAStack->isPrivate(VD)) { +auto DVar = DSAStack->getTopDSA(VD, false); +Diag(ELoc, diag::err_omp_variable_in_map_and_dsa) --

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

2016-03-19 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D18203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D17840: [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation

2016-03-19 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D17840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: r259776 - [OPENMP 4.0] Fixed support of array sections/array subscripts.

2016-03-19 Thread Alexey Bataev via cfe-commits
ist somewhen? > > Thanks, > Jonas > >> -Original Message- >> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf >> Of Alexey Bataev via cfe-commits >> Sent: Thursday, February 04, 2016 12:27 PM >> To: cfe-commits@lists.llvm.org >

r263706 - [OPENMP 4.5] Allow to use private data members in 'copyprivate' clause.

2016-03-19 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Mar 17 05:50:17 2016 New Revision: 263706 URL: http://llvm.org/viewvc/llvm-project?rev=263706&view=rev Log: [OPENMP 4.5] Allow to use private data members in 'copyprivate' clause. OpenMP 4.5 allows privatization of non-static data members in non-static member functions.

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

2016-03-19 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Samuel, this will be captured. But foo() will use original A. This cannot be changed. But Inside the region all reference to this->A will be replaced by the CapturedDecl A. It will allow proper codegen for inner captured contexts. For example, such code won't be handled

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

2016-03-19 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Samuel, I have a patch that improves handling of map clauses with data members. Unfortunately, I cannot commit it because I can't create tests for it. Please, apply this patch to your map clause codegen changes. It uses common technique for handling non-static data memb

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

2016-03-20 Thread Alexey Bataev via cfe-commits
Samuel, this is true for device part of codegen. But what about host? If this code must be executed on host, will it be handled correctly? Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 18.03.2016 23:03, Samuel Antao пишет: > sfantao added a comment. > > Hi Alexe

Re: [PATCH] D18276: [OpenMP] Allow reduction on pointer dereference

2016-03-20 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGStmtOpenMP.cpp:913-929 @@ -912,9 +912,19 @@ }); - } else if (auto *ASE = dyn_cast(IRef)) { -auto *Base = ASE->getBase()->IgnoreParenImpCasts(); -while (auto *TempASE = dyn_cast(Base)) -

Re: [PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

2016-03-20 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:53-57 @@ -52,2 +52,7 @@ auto &&CodeGen = [&D](CodeGenFunction &CGF) { +CodeGenFunction::OMPPrivateScope PrivateScope(CGF); +(void)CGF.EmitOMPFirstprivateClause(D, PrivateScope); +CGF.Emi

r264569 - [OPENMP] Allow runtime insert its own code inside OpenMP regions.

2016-03-28 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Mar 28 04:53:43 2016 New Revision: 264569 URL: http://llvm.org/viewvc/llvm-project?rev=264569&view=rev Log: [OPENMP] Allow runtime insert its own code inside OpenMP regions. Solution unifies interface of RegionCodeGenTy type to allow insert runtime-specific code before/a

r264570 - Revert "[OPENMP] Allow runtime insert its own code inside OpenMP regions."

2016-03-28 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Mar 28 05:12:03 2016 New Revision: 264570 URL: http://llvm.org/viewvc/llvm-project?rev=264570&view=rev Log: Revert "[OPENMP] Allow runtime insert its own code inside OpenMP regions." This reverts commit 3ee791165100607178073f14531a0dc90c622b36. Modified: cfe/trunk/l

r264576 - [OPENMP] Allow runtime insert its own code inside OpenMP regions.

2016-03-28 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Mar 28 07:52:58 2016 New Revision: 264576 URL: http://llvm.org/viewvc/llvm-project?rev=264576&view=rev Log: [OPENMP] Allow runtime insert its own code inside OpenMP regions. Solution unifies interface of RegionCodeGenTy type to allow insert runtime-specific code before/a

r264577 - Revert "[OPENMP] Allow runtime insert its own code inside OpenMP regions."

2016-03-28 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Mar 28 07:58:34 2016 New Revision: 264577 URL: http://llvm.org/viewvc/llvm-project?rev=264577&view=rev Log: Revert "[OPENMP] Allow runtime insert its own code inside OpenMP regions." Reverting because of failed tests. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.

r264700 - [OPENMP] Allow runtime insert its own code inside OpenMP regions.

2016-03-28 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Mar 29 00:34:15 2016 New Revision: 264700 URL: http://llvm.org/viewvc/llvm-project?rev=264700&view=rev Log: [OPENMP] Allow runtime insert its own code inside OpenMP regions. Solution unifies interface of RegionCodeGenTy type to allow insert runtime-specific code before/a

r264709 - [OPENMP] Remove extra code transformation.

2016-03-29 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Mar 29 03:58:54 2016 New Revision: 264709 URL: http://llvm.org/viewvc/llvm-project?rev=264709&view=rev Log: [OPENMP] Remove extra code transformation. For better support of some specific GNU extensions some extra transformation of AST nodes were introduced. These transfo

r264715 - [OPENMP 4.5] Allow data members in 'aligned' clause.

2016-03-29 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Mar 29 05:59:56 2016 New Revision: 264715 URL: http://llvm.org/viewvc/llvm-project?rev=264715&view=rev Log: [OPENMP 4.5] Allow data members in 'aligned' clause. OpenMP 4.5 allows privatization of data members OpenMP clauses. Patch adds support for data members in 'aligne

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2015-12-29 Thread Alexey Bataev via cfe-commits
ABataev marked 2 inline comments as done. Comment at: test/Sema/attr-x86-interrupt.c:54 @@ +53,3 @@ + foo8((int *)argv); // expected-error {{interrupt service routine can't be used directly}} + return 0; +} aaron.ballman wrote: > I'd like to see a test li

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2015-12-29 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 43727. ABataev added a comment. Update after review http://reviews.llvm.org/D15709 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/TargetInfo.cpp lib/Sema/SemaDeclAttr.cpp

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

2015-12-29 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Hello Michael, Thanks for working on this. I still think we don't need OMPDeclareTargetDecl here and we can handle everything with an attribute. Try to implement everything just with an attribute and without OMPDeclareTargetDecl. http://reviews.llvm.org/D15321 _

r256639 - [OPENMP 4.5] Allow 'ordered' clause on 'loop simd' constructs.

2015-12-30 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Dec 30 06:06:23 2015 New Revision: 256639 URL: http://llvm.org/viewvc/llvm-project?rev=256639&view=rev Log: [OPENMP 4.5] Allow 'ordered' clause on 'loop simd' constructs. OpenMP 4.5 allows to use 'ordered' clause without parameter on 'loop simd' constructs. Modified:

r256666 - [OPENMP 4.5] Codegen for 'schedule' clause with monotonic/nonmonotonic modifiers.

2015-12-30 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Dec 31 00:52:34 2015 New Revision: 25 URL: http://llvm.org/viewvc/llvm-project?rev=25&view=rev Log: [OPENMP 4.5] Codegen for 'schedule' clause with monotonic/nonmonotonic modifiers. OpenMP 4.5 adds support for monotonic/nonmonotonic modifiers in 'schedule' claus

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2015-12-31 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Aaron, thanks for the review! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2504 @@ -2493,3 +2503,3 @@ // Availability attribute def warn_availability_unknown_platform : Warning< aaron.ballman wrote: > >> It would be good to

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2015-12-31 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 43828. ABataev added a comment. Fix after review. After some discussion with gcc guys it was decided to allow to use static member functions as interrupt handler. http://reviews.llvm.org/D15709 Files: include/clang/Basic/Attr.td include/clang/Basic/Att

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2016-01-01 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 43843. ABataev added a comment. Update after review http://reviews.llvm.org/D15709 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/TargetInfo.cpp lib/Sema/SemaDeclAttr.cpp

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

2016-01-11 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Kelvin, thanks for the patch! One more comment: what about nesting of regions? You need to add a corresponding code and tests Comment at: include/clang/AST/OpenMPClause.h:3196 @@ -3195,1 +3195,3 @@ +/// \brief This represents clause 'from' in the '#pr

Re: [PATCH] D15989: [OpenMP] Parsing + sema for "target enter data" and "target exit data" directives.

2016-01-11 Thread Alexey Bataev via cfe-commits
ABataev added a comment. You need to add the code/tests for nesting of regions. Comment at: include/clang-c/Index.h:2283 @@ +2282,3 @@ + */ + CXCursor_OMPTargetExitDataDirective= 262, + Target exit and target enter constructs must be implemented in differ

Re: [PATCH] D16065: Fix infinite recursion for invalid declaration

2016-01-12 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257461: Fix infinite recursion for invalid declaration, by Dmitry Polukhin (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D16065?vs=44499&id=44608#toc Repository: rL LLVM ht

r257461 - Fix infinite recursion for invalid declaration, by Dmitry Polukhin

2016-01-12 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Jan 12 03:01:25 2016 New Revision: 257461 URL: http://llvm.org/viewvc/llvm-project?rev=257461&view=rev Log: Fix infinite recursion for invalid declaration, by Dmitry Polukhin Fix for a case found by fuzzing PR23057 (comment #25 https://llvm.org/bugs/show_bug.cgi?id=23057

r257462 - PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute, by Dmitry Polukhin

2016-01-12 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Jan 12 03:12:20 2016 New Revision: 257462 URL: http://llvm.org/viewvc/llvm-project?rev=257462&view=rev Log: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute, by Dmitry Polukhin Fix binary compatibility issue with GCC. Differential Revisi

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

2016-01-12 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257462: PR18513: make gcc compatible layout for bit-fields with explicit aligned… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D14980?vs=41866&id=44609#toc Repository: rL L

r257586 - [OPENMP] Fix for declarative/standalone directives use.

2016-01-13 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Jan 13 05:18:54 2016 New Revision: 257586 URL: http://llvm.org/viewvc/llvm-project?rev=257586&view=rev Log: [OPENMP] Fix for declarative/standalone directives use. Fixes processing of declarative directives and standalone executable directives. Declarative directives sho

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2016-01-13 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 44754. ABataev added a comment. Update after review http://reviews.llvm.org/D15709 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/TargetInfo.cpp lib/Sema/SemaDeclAttr.cpp

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

2016-01-13 Thread Alexey Bataev via cfe-commits
ABataev removed a subscriber: rsmith. ABataev updated this revision to Diff 44833. ABataev added a comment. Updated to latest version http://reviews.llvm.org/D10599 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td include/cla

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

2016-01-14 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 44848. ABataev added a comment. Updated to latest version + some fixes and improvements http://reviews.llvm.org/D11182 Files: include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/AST/DeclOpenMP.h include/clang/AST/RecursiveASTVisit

r257867 - [X86] Support 'interrupt' attribute for x86

2016-01-14 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jan 14 22:06:31 2016 New Revision: 257867 URL: http://llvm.org/viewvc/llvm-project?rev=257867&view=rev Log: [X86] Support 'interrupt' attribute for x86 This attribute may be attached to a function definition and instructs the backend to generate appropriate function entr

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2016-01-14 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257867: [X86] Support 'interrupt' attribute for x86 (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D15709?vs=44754&id=44961#toc Repository: rL LLVM http://reviews.llvm.org/D

r257868 - PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration, by Denis Zobnin

2016-01-14 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jan 14 22:36:32 2016 New Revision: 257868 URL: http://llvm.org/viewvc/llvm-project?rev=257868&view=rev Log: PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration, by Denis Zobnin Allow "mode" attribute to be applied to VarDecl, not ValueDecl

Re: [PATCH] D16112: PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration

2016-01-14 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257868: PR26111: segmentation fault with __attribute__((mode(QI))) on function… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D16112?vs=44859&id=44963#toc Repository: rL LLV

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

2016-01-14 Thread Alexey Bataev via cfe-commits
ABataev added a comment. LG Repository: rL LLVM http://reviews.llvm.org/D15220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15989: [OpenMP] Parsing + sema for "target enter data" and "target exit data" directives.

2016-01-17 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/Sema/Sema.h:7767-7768 @@ -7766,2 +7766,4 @@ bool StrictlyPositive = true); + /// \brief Check for existence of a map clause + bool HasMapClause(ArrayRef Clauses);

Re: [PATCH] D16280: [OpenMP] Detect implicit map type to report unspecified map type for target enter/exit data directives.

2016-01-17 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:8587 @@ -8583,4 +8586,3 @@ Diag(StartLoc, diag::err_omp_invalid_map_type_for_directive) << - // TODO: Need to determine if map type is implicitly determined - (0) << + static_cast(

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

2016-01-17 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 45149. ABataev added a comment. Simplified handling of private copies in C/C++. Now all outpup parameters of UDR must be passed by pointer, not by reference (better compatibility with C) http://reviews.llvm.org/D11182 Files: include/clang/AST/DeclBase.h

Re: [PATCH] D16216: Fix infinite loop when ::new or ::delete are found in member initializer list

2016-01-19 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258290: Fix infinite loop when ::new or ::delete are found in member initializer list… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D16216?vs=45295&id=45347#toc Repository:

r258290 - Fix infinite loop when ::new or ::delete are found in member initializer list, by Denis Zobnin

2016-01-19 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Jan 19 23:25:51 2016 New Revision: 258290 URL: http://llvm.org/viewvc/llvm-project?rev=258290&view=rev Log: Fix infinite loop when ::new or ::delete are found in member initializer list, by Denis Zobnin Fix for an infinite loop on parsing ::new or ::delete in member init

r258299 - [OPENMP 4.5] Allow to use non-static data members in non-static member functions in 'private' clause.

2016-01-20 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Jan 20 03:07:54 2016 New Revision: 258299 URL: http://llvm.org/viewvc/llvm-project?rev=258299&view=rev Log: [OPENMP 4.5] Allow to use non-static data members in non-static member functions in 'private' clause. OpenMP 4.5 allows to use non-static members of current class

r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

2016-01-20 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Jan 20 06:29:47 2016 New Revision: 258307 URL: http://llvm.org/viewvc/llvm-project?rev=258307&view=rev Log: [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive. Allow to emit code for 'cancel' directive within 'sections' directive with single s

Re: [PATCH] D16385: [OpenMP] Update map clause SEMA to support OpenMP 4.5 possible list items.

2016-01-20 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Please, update your workspace to latest version, many changes are in trunk already http://reviews.llvm.org/D16385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: D16358: [OpenMP] Parsing + Sema for nowait clause on target directive

2016-01-20 Thread Alexey Bataev via cfe-commits
Ok, thanks Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 21.01.2016 10:16, Hahnfeld, Jonas пишет: > Hi Alexey, > > Phabricator doesn't send mails when only the review state changes as mentioned > in documentation. This makes following the current status hard when

Re: [PATCH] D16400: [OpenMP] Sema for depend clause on target enter data directive.

2016-01-21 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Add tests for templates to test/OpenMP/target_enter_data_depend_messages.cpp http://reviews.llvm.org/D16400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258394 - [OPENMP] Fix crash on reduction for complex variables.

2016-01-21 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jan 21 06:35:58 2016 New Revision: 258394 URL: http://llvm.org/viewvc/llvm-project?rev=258394&view=rev Log: [OPENMP] Fix crash on reduction for complex variables. reworked codegen for reduction operation for complex types to avoid crash Modified: cfe/trunk/lib/CodeGe

r258396 - Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only.

2016-01-21 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jan 21 06:54:48 2016 New Revision: 258396 URL: http://llvm.org/viewvc/llvm-project?rev=258396&view=rev Log: Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only. Modified: cfe/trunk/lib/Sema/SemaExpr.cp

Re: [PATCH] D16400: [OpenMP] Sema for depend clause on target enter data directive.

2016-01-21 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: r258394 - [OPENMP] Fix crash on reduction for complex variables.

2016-01-21 Thread Alexey Bataev via cfe-commits
r merging? If yes, do you > want to go ahead and merge with utils/release/merge.sh? > > On Thu, Jan 21, 2016 at 4:35 AM, Alexey Bataev via cfe-commits > wrote: >> Author: abataev >> Date: Thu Jan 21 06:35:58 2016 >> New Revision: 258394 >> >> URL: htt

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

2016-01-21 Thread Alexey Bataev via cfe-commits
k suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that > this should be merged to 3.8. > > Alexey, you're the code owner here. OK for merging? If yes, do you > want to go ahead and merge with utils/release/merge.sh? > > On Wed, Jan 20, 2016 at 4:29 AM, Alexey Bataev via

Re: [PATCH] D16385: [OpenMP] Update map clause SEMA to support OpenMP 4.5 possible list items.

2016-01-21 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r258495 - [OPENMP] Generalize codegen for 'sections'-based directive.

2016-01-22 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Jan 22 02:56:50 2016 New Revision: 258495 URL: http://llvm.org/viewvc/llvm-project?rev=258495&view=rev Log: [OPENMP] Generalize codegen for 'sections'-based directive. If 'sections' directive has only one sub-section, the code for 'single'-based directive was emitted. Re

Re: [PATCH] D16401: [OpenMP] Sema for depend clause on target exit data directive.

2016-01-22 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r258668 - Fixed processing of GNU extensions to C99 designated initializers

2016-01-24 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Sun Jan 24 23:14:03 2016 New Revision: 258668 URL: http://llvm.org/viewvc/llvm-project?rev=258668&view=rev Log: Fixed processing of GNU extensions to C99 designated initializers Clang did not handles correctly inner parts of arrays/structures initializers in GNU extensions t

Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-24 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:3408-3409 @@ +3407,4 @@ +Kind(Kind), KindLoc(KLoc) { +Modifier = M; +ModifierLoc = MLoc; + } Why these are not initialized in initializer list, along with Kind, KindLoc e

r258669 - Allow capture typedefs/type aliases for VLAs in lambdas/captured statements chain.

2016-01-24 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Jan 25 01:06:23 2016 New Revision: 258669 URL: http://llvm.org/viewvc/llvm-project?rev=258669&view=rev Log: Allow capture typedefs/type aliases for VLAs in lambdas/captured statements chain. Previous it was allowed to capture VLAs/types with arrays of runtime bounds onl

Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-25 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D16553: [OpenMP] Parsing + sema for target parallel directive.

2016-01-25 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r258804 - [OPENMP 4.5] Allow arrays in 'reduction' clause.

2016-01-26 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Jan 26 06:20:39 2016 New Revision: 258804 URL: http://llvm.org/viewvc/llvm-project?rev=258804&view=rev Log: [OPENMP 4.5] Allow arrays in 'reduction' clause. OpenMP 4.5, alogn with array sections, allows to use variables of array type in reductions. Modified: cfe/tru

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

2016-01-28 Thread Alexey Bataev via cfe-commits
ix, that will fix all 'sections' >>>> related troubles, including this one. So I don't think it is necessary >>>> to merge it >>>> >>>> Best regards, >>>> Alexey Bataev >>>> = >>>> Software Enginee

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

2016-01-28 Thread Alexey Bataev via cfe-commits
Alexey Bataev >>>> wrote: >>>>> Later today I will post another fix, that will fix all 'sections' >>>>> related troubles, including this one. So I don't think it is >>>>> necessary >>>>> to merge it >>>>>

Re: [PATCH] D16758: [OpenMP] Prevent nesting of target constructs within target code execution regions.

2016-01-31 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

2015-11-16 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 40253. ABataev marked 3 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D13336 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h inclu

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

2015-11-16 Thread Alexey Bataev via cfe-commits
ABataev marked 4 inline comments as done. Comment at: include/clang/Basic/AttrDocs.td:1620 @@ +1619,3 @@ + let Content = [{ +The declare simd construct can be applied to a function to enable the creation of one or more versions that can process multiple arguments using SIMD ins

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

2015-11-16 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 40255. ABataev marked 4 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D10599 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td include/clang

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

2015-11-16 Thread Alexey Bataev via cfe-commits
ABataev marked 2 inline comments as done. Comment at: include/clang/Basic/DiagnosticParseKinds.td:995 @@ -994,1 +994,3 @@ +def err_omp_expected_reduction_identifier : Error< + "expected identifier or one of the following operators: '+', '-', '*', '&', '|', '^', '&&' and '||'">;

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

2015-11-16 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 40262. ABataev marked 2 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D11182 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/AS

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

2015-11-17 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:2660-2662 @@ +2659,5 @@ + /// + /// \param StartLoc Starting location of the clause. + /// \param EndLoc Ending location of the clause. + /// \param N Number of the variables in the clause. + ///

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

2015-11-18 Thread Alexey Bataev via cfe-commits
ABataev added a comment. John, any comments? http://reviews.llvm.org/D13336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

2015-11-19 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253551: PR10235: support for vector mode attributes + warning, by Dmitry Polukhin. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D14744?vs=40506&id=40618#toc Repository: rL

r253551 - PR10235: support for vector mode attributes + warning, by Dmitry Polukhin.

2015-11-19 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Nov 19 04:13:11 2015 New Revision: 253551 URL: http://llvm.org/viewvc/llvm-project?rev=253551&view=rev Log: PR10235: support for vector mode attributes + warning, by Dmitry Polukhin. Add support for vector mode attributes like "attribute((mode(V4SF)))". Also add warning

Re: [PATCH] D14467: [MS] Fix for bug 25013 - #pragma vtordisp is unknown inside functions.

2015-11-19 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253650: [MS] Fix for bug 25013 - #pragma vtordisp is unknown inside functions, by… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D14467?vs=40380&id=40745#toc Repository: rL

r253650 - [MS] Fix for bug 25013 - #pragma vtordisp is unknown inside functions, by Denis Zobnin.

2015-11-19 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Nov 20 01:02:57 2015 New Revision: 253650 URL: http://llvm.org/viewvc/llvm-project?rev=253650&view=rev Log: [MS] Fix for bug 25013 - #pragma vtordisp is unknown inside functions, by Denis Zobnin. This patch adds support of #pragma vtordisp inside functions in attempt to

[PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-20 Thread Alexey Bataev via cfe-commits
ABataev created this revision. ABataev added reviewers: rjmccall, DavidKreitzer, mkuper. ABataev added a subscriber: cfe-commits. For MCU only C calling convention is allowed, all other calling conventions are not supported. http://reviews.llvm.org/D14864 Files: lib/Basic/Targets.cpp test/S

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

2015-11-20 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D14134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

2015-11-22 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Chandler, gcc buildbot greenified, tests for clang are fixed. Hans Wennborg accepted this patch. Could accept this patch? http://reviews.llvm.org/D13802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

2015-11-23 Thread Alexey Bataev via cfe-commits
ABataev marked an inline comment as done. Comment at: lib/Sema/SemaPseudoObject.cpp:1627 @@ -1579,1 +1626,3 @@ +cast(Base->IgnoreParens())->getBaseExpr()); +return MSPropertyRefRebuilder(S, BaseOVE->getSourceExpr()).rebuild(E); } else { rjmccall wro

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

2015-11-23 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 40901. ABataev marked an inline comment as done. http://reviews.llvm.org/D13336 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/StmtNodes.td include/clang/Ser

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-23 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Ok, extracted all MCU specific changes to separate target class. http://reviews.llvm.org/D14864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-23 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 40904. http://reviews.llvm.org/D14864 Files: lib/Basic/Targets.cpp test/Sema/callingconv-iamcu.c Index: lib/Basic/Targets.cpp === --- lib/Basic/Targets.cpp +++ lib/Basic/Targets.cpp @@ -3391

<    10   11   12   13   14   15   16   17   18   19   >