Re: [PATCH] D11361: [OpenMP] Target directive host codegen

ABataev added a comment. Another one thing I forget to mention. Current implementation of CGOpenMPRuntime is libomp-specific. You're trying to add functionality that is libtarget-specific. Maybe it is a good idea to separate support for libomp and libtarget runtime libraries? http://reviews.l

r245692 - [OPENMP 4.1] Initial support for 'simdlen' clause.

Author: abataev Date: Fri Aug 21 06:14:16 2015 New Revision: 245692 URL: http://llvm.org/viewvc/llvm-project?rev=245692&view=rev Log: [OPENMP 4.1] Initial support for 'simdlen' clause. Add parsing/sema analysis for 'simdlen' clause in simd directives. Also add check that if both 'safelen' and 'si

r245693 - [OPENMP 4.1] Add ast-print tests for 'val', 'uval' and 'ref' modifiers.

Author: abataev Date: Fri Aug 21 06:32:42 2015 New Revision: 245693 URL: http://llvm.org/viewvc/llvm-project?rev=245693&view=rev Log: [OPENMP 4.1] Add ast-print tests for 'val', 'uval' and 'ref' modifiers. Modified: cfe/trunk/test/OpenMP/simd_ast_print.cpp Modified: cfe/trunk/test/OpenMP/sim

r245697 - [OPENMP 4.1] Add codegen for 'simdlen' clause.

Author: abataev Date: Fri Aug 21 07:19:04 2015 New Revision: 245697 URL: http://llvm.org/viewvc/llvm-project?rev=245697&view=rev Log: [OPENMP 4.1] Add codegen for 'simdlen' clause. Add emission of metadata for simd loops in presence of 'simdlen' clause. If 'simdlen' clause is provided without 'saf

r245823 - [OPENMP] Info about OpenMP Support in Users Manual, NFC.

Author: abataev Date: Mon Aug 24 00:31:10 2015 New Revision: 245823 URL: http://llvm.org/viewvc/llvm-project?rev=245823&view=rev Log: [OPENMP] Info about OpenMP Support in Users Manual, NFC. Differential Revision: http://reviews.llvm.org/D12152 Modified: cfe/trunk/docs/UsersManual.rst Modifi

Re: [PATCH] D12152: [OPENMP] Info about OpenMP Support in Users Manual

This revision was automatically updated to reflect the committed changes. Closed by commit rL245823: [OPENMP] Info about OpenMP Support in Users Manual, NFC. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D12152?vs=32790&id=32933#toc Repository: rL LLVM http://revie

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

ABataev marked 15 inline comments as done. ABataev added a comment. Richard, thanks for the review! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7680 @@ +7679,3 @@ +def err_omp_section_length_undefined : Error< + "section length is unspecified, but subscripted value i

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

ABataev updated this revision to Diff 32974. ABataev marked 10 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D10732 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/AST/DataRecu

Re: [PATCH] D12134: [DEBUG INFO] Source correlation for lambda captured values.

ABataev added a subscriber: ABataev. ABataev added a comment. Yes, you're right, and it will be 13, 14, 15. It is implemented already and this patch does not break this. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 25.08.2015 9:00, Eric Christopher пишет: >

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

ABataev added a comment. Samuel, Yes, I thought about different files and different classes. Runtime for offloading codegen is not a part of libomp and it would be good to have separate runtime handler class for target codegen also. We need to think about it in future. Commen

r245937 - [OPENMP 4.0] Initial support for array sections.

Author: abataev Date: Tue Aug 25 09:24:04 2015 New Revision: 245937 URL: http://llvm.org/viewvc/llvm-project?rev=245937&view=rev Log: [OPENMP 4.0] Initial support for array sections. Adds parsing/sema analysis/serialization/deserialization for array sections in OpenMP constructs (introduced in O

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

This revision was automatically updated to reflect the committed changes. ABataev marked an inline comment as done. Closed by commit rL245937: [OPENMP 4.0] Initial support for array sections. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D10732?vs=32974&id=33077#toc R

r245939 - Fix possible crash on null base or type for array elements.

Author: abataev Date: Tue Aug 25 10:15:12 2015 New Revision: 245939 URL: http://llvm.org/viewvc/llvm-project?rev=245939&view=rev Log: Fix possible crash on null base or type for array elements. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/test/OpenMP/task_depend_messages.cpp Modi

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev marked 7 inline comments as done. ABataev added a comment. Richard, thanks for the review! Comment at: include/clang/Basic/Attr.td:2074-2078 @@ +2073,7 @@ + let Documentation = [OMPDeclareSimdDocs]; + let AdditionalMembers = [{ + void printPrettyPragma(raw_ostream &OS

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev updated this revision to Diff 33181. ABataev marked 7 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D10599 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td include/clang

r246278 - [OPENMP 4.0] Codegen for array sections.

Author: abataev Date: Fri Aug 28 01:09:05 2015 New Revision: 246278 URL: http://llvm.org/viewvc/llvm-project?rev=246278&view=rev Log: [OPENMP 4.0] Codegen for array sections. Added codegen for array section in 'depend' clause of 'task' directive. It emits to pointers, one for the begin of array s

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2991-3005 @@ +2990,17 @@ + +/// \brief Values for bit flags used to specify the mapping type for +/// offloading. +enum OpenMPOffloadMappingFlags { + /// \brief Allocate memory on the device and move data

r246422 - [OPENMP 4.0] Codegen for array sections.

Author: abataev Date: Mon Aug 31 02:32:19 2015 New Revision: 246422 URL: http://llvm.org/viewvc/llvm-project?rev=246422&view=rev Log: [OPENMP 4.0] Codegen for array sections. Added codegen for array section in 'depend' clause of 'task' directive. It emits to pointers, one for the begin of array s

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

ABataev added a comment. Seems good to me, but it would be good if John McCall could look at the patch. http://reviews.llvm.org/D11361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

ABataev added a comment. LGTM http://reviews.llvm.org/D12262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r246747 - [OPENMP 4.1] Parsing/sema analysis for extended format of 'if' clause.

Author: abataev Date: Thu Sep 3 02:23:48 2015 New Revision: 246747 URL: http://llvm.org/viewvc/llvm-project?rev=246747&view=rev Log: [OPENMP 4.1] Parsing/sema analysis for extended format of 'if' clause. OpenMP 4.1 added special 'directive-name-modifier' to the 'if' clause. Format of 'if' clause

r246748 - [OPENMP 4.1] Codegen for extended format of 'if' clause.

Author: abataev Date: Thu Sep 3 03:45:56 2015 New Revision: 246748 URL: http://llvm.org/viewvc/llvm-project?rev=246748&view=rev Log: [OPENMP 4.1] Codegen for extended format of 'if' clause. Fixed codegen for extended format of 'if' clauses with special 'directive-name-modifier' + ast-print tests

r246757 - [OPENMP] Fix for http://llvm.org/PR24687: ICE on compilation of R package TPmsm.

Author: abataev Date: Thu Sep 3 05:21:46 2015 New Revision: 246757 URL: http://llvm.org/viewvc/llvm-project?rev=246757&view=rev Log: [OPENMP] Fix for http://llvm.org/PR24687: ICE on compilation of R package TPmsm. Fixed capturing of VLAs in 'private' clause of the OpenMP directives. Modified:

[PATCH] D12594: [X86-64] Allow additional register names in inline assembler.

ABataev created this revision. ABataev added reviewers: rjmccall, echristo. ABataev added a subscriber: cfe-commits. Patch allows to recognize additional registers x8d, x8b, x8w - x15d, x15b, x15w in inline assembler, already recognized by backend http://reviews.llvm.org/D12594 Files: lib/Bas

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev added a comment. Ping http://reviews.llvm.org/D10599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a comment. Ping http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12594: [X86-64] Allow additional register names in inline assembler.

ABataev added a comment. Eric, thanks for the review! Will do! http://reviews.llvm.org/D12594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r246835 - [X86-64] Allow additional register names in inline assembler.

Author: abataev Date: Thu Sep 3 22:42:23 2015 New Revision: 246835 URL: http://llvm.org/viewvc/llvm-project?rev=246835&view=rev Log: [X86-64] Allow additional register names in inline assembler. Patch allows to recognize additional registers x8d, x8b, x8w - x15d, x15b, x15w in inline assembler,

Re: [PATCH] D12594: [X86-64] Allow additional register names in inline assembler.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246835: [X86-64] Allow additional register names in inline assembler. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D12594?vs=33926&id=34011#toc Repository: rL LLVM http://

r246846 - [OPENMP] Fix for http://llvm.org/PR24674: assertion failed and and abort trap

Author: abataev Date: Fri Sep 4 06:26:21 2015 New Revision: 246846 URL: http://llvm.org/viewvc/llvm-project?rev=246846&view=rev Log: [OPENMP] Fix for http://llvm.org/PR24674: assertion failed and and abort trap Fix processing of shared variables with reference types in OpenMP constructs. Previou

r246853 - [OPENMP] Fix false diagnostic on instantiation-dependent exprs for atomic constructs.

Author: abataev Date: Fri Sep 4 07:55:50 2015 New Revision: 246853 URL: http://llvm.org/viewvc/llvm-project?rev=246853&view=rev Log: [OPENMP] Fix false diagnostic on instantiation-dependent exprs for atomic constructs. Some of instantiation-dependent expressions could cause false diagnostic to b

Re: [PATCH] D11619: [OPENMP] allow static local variable on data-sharing attribute clause

ABataev added a comment. LG http://reviews.llvm.org/D11619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13375: [MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double invocations of foo() when compiling foo()->propertyName

ABataev added a comment. Ping http://reviews.llvm.org/D13375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:323 @@ +322,3 @@ + /// far. + struct OffloadEntriesInfoManagerTy { +CodeGenModule &CGM; Maybe it is better to make it a class if it has some non-public members? http://reviews.llvm.or

[PATCH] D13546: [ATTR] Automatic line feed after pragma-like attribute, NFC.

ABataev created this revision. ABataev added a reviewer: aaron.ballman. ABataev added a subscriber: cfe-commits. Automatically insert line feed after pretty printing of all pragma-like attributes. http://reviews.llvm.org/D13546 Files: include/clang/Basic/Attr.td utils/TableGen/ClangAttrEmit

r249672 - [OPENMP 4.1] Codegen for array sections/subscripts in 'reduction' clause.

Author: abataev Date: Thu Oct 8 04:10:53 2015 New Revision: 249672 URL: http://llvm.org/viewvc/llvm-project?rev=249672&view=rev Log: [OPENMP 4.1] Codegen for array sections/subscripts in 'reduction' clause. OpenMP 4.1 adds support for array sections/subscripts in 'reduction' clause. Patch adds c

Re: [PATCH] D13546: [ATTR] Automatic line feed after pragma-like attribute.

ABataev retitled this revision from "[ATTR] Automatic line feed after pragma-like attribute, NFC." to "[ATTR] Automatic line feed after pragma-like attribute.". ABataev updated this revision to Diff 36850. ABataev added a comment. Printing of pragma-like attributes for declarations did not worke

Re: [PATCH] D13546: [ATTR] Automatic line feed after pragma-like attribute.

ABataev marked 2 inline comments as done. Comment at: lib/AST/DeclPrinter.cpp:197 @@ -196,3 +196,3 @@ -void DeclPrinter::prettyPrintAttributes(Decl *D) { +void DeclPrinter::prettyPrintAttributes(Decl *D, bool PrintPragmas) { if (Policy.PolishForDeclaration) a

Re: [PATCH] D13546: [ATTR] Automatic line feed after pragma-like attribute.

ABataev updated this revision to Diff 36924. ABataev marked 2 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D13546 Files: include/clang/Basic/Attr.td lib/AST/DeclPrinter.cpp test/Misc/ast-print-pragmas.cpp utils/TableGen/ClangAttrEmitter.c

[PATCH] D13582: [DEBUG INFO] Emit debug info for type used in explicit cast only.

ABataev created this revision. ABataev added a reviewer: echristo. ABataev added a subscriber: cfe-commits. Currently debug info for types used in explicit cast only is not emitted. It happened after a patch for better alignment handling. This patch fixes this bug. http://reviews.llvm.org/D13582

Re: [PATCH] D13546: [ATTR] Automatic line feed after pragma-like attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250017: [ATTR] Automatic line feed after pragma-like attribute. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13546?vs=36924&id=37080#toc Repository: rL LLVM http://review

r250017 - [ATTR] Automatic line feed after pragma-like attribute.

Author: abataev Date: Mon Oct 12 01:59:48 2015 New Revision: 250017 URL: http://llvm.org/viewvc/llvm-project?rev=250017&view=rev Log: [ATTR] Automatic line feed after pragma-like attribute. Automatically insert line feed after pretty printing of all pragma-like attributes + fix printing of pragma

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev marked 3 inline comments as done. Comment at: include/clang/Basic/Attr.td:2098-2102 @@ +2097,7 @@ + let Documentation = [OMPDeclareSimdDocs]; + let AdditionalMembers = [{ + void printPrettyPragma(raw_ostream &OS, const PrintingPolicy &Policy) const { +OS << "\n"; +

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev updated this revision to Diff 37218. ABataev marked 3 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D10599 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td include/clang

Re: [PATCH] D13375: [MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double invocations of foo() when compiling foo()->propertyName

ABataev added a comment. I see, no problems, thanks! Best regards, Alexey Bataev = Software Engineer Intel Compiler Team Intel Corp. http://reviews.llvm.org/D13375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D13375: [MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double invocations of foo() when compiling foo()->propertyName

This revision was automatically updated to reflect the committed changes. Closed by commit rL250265: [MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13375?vs=36331&id=37319#toc Repository: rL LLVM

r250265 - [MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double invocations of foo() when compiling foo()->propertyName

Author: abataev Date: Tue Oct 13 23:05:42 2015 New Revision: 250265 URL: http://llvm.org/viewvc/llvm-project?rev=250265&view=rev Log: [MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double invocations of foo() when compiling foo()->propertyName Removes extra codegen for base express

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev added a comment. In http://reviews.llvm.org/D13336#257628, @rnk wrote: > I think fundamentally we are doing too much declspec property lowering in > Sema. We might want to back up and figure out how to do it in IRGen. Right > now we have bugs like this, which are probably more important

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev marked 40 inline comments as done. ABataev added a comment. Richard, thanks for the review! Tried to fix all your comments. Comment at: include/clang/AST/DeclOpenMP.h:95 @@ +94,3 @@ +/// #pragma omp declare reduction (foo : int,float : omp_out += omp_in) +/// initializer

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev updated this revision to Diff 37321. ABataev marked 16 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D11182 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/A

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1962 @@ +1961,3 @@ +[LineNum][ColNum]; +assert(Entry.Order != -1u && "Entry not initialized!"); +assert(!Entry.Addr && !Entry.ID && "Entry registered alre

Re: [PATCH] D13582: [DEBUG INFO] Emit debug info for type used in explicit cast only.

ABataev added reviewers: rjmccall, dblaikie. ABataev updated this revision to Diff 37476. ABataev added a comment. Update after review http://reviews.llvm.org/D13582 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprAgg.cpp lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CGExprComplex.cpp lib/Cod

[PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

ABataev created this revision. ABataev added a reviewer: chandlerc. ABataev added subscribers: hfinkel, fraggamuffin, ejstotzer, cfe-commits, llvm-commits. Patch turns on OpenMP support in clang by default after fixing OpenMP buildbots. http://reviews.llvm.org/D13802 Files: configure docs/G

[PATCH] D13803: [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part

ABataev created this revision. ABataev added a reviewer: chandlerc. ABataev added subscribers: hfinkel, fraggamuffin, ejstotzer, cfe-commits. Patch turns on OpenMP support in clang by default after fixing OpenMP buildbots. http://reviews.llvm.org/D13803 Files: CMakeLists.txt docs/UsersManual

r250684 - [OPENMP] Fix for http://llvm.org/PR25221: Infinite loop while parsing OpenMP directive

Author: abataev Date: Mon Oct 19 01:40:17 2015 New Revision: 250684 URL: http://llvm.org/viewvc/llvm-project?rev=250684&view=rev Log: [OPENMP] Fix for http://llvm.org/PR25221: Infinite loop while parsing OpenMP directive Clang skipped annot_pragma_openmp token, while it should be considered as a

r250795 - [DEBUG INFO] Emit debug info for type used in explicit cast only.

Author: abataev Date: Mon Oct 19 23:24:12 2015 New Revision: 250795 URL: http://llvm.org/viewvc/llvm-project?rev=250795&view=rev Log: [DEBUG INFO] Emit debug info for type used in explicit cast only. Currently debug info for types used in explicit cast only is not emitted. It happened after a pat

Re: [PATCH] D13582: [DEBUG INFO] Emit debug info for type used in explicit cast only.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250795: [DEBUG INFO] Emit debug info for type used in explicit cast only. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13582?vs=37476&id=37825#toc Repository: rL LLVM htt

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev updated this revision to Diff 37854. ABataev added a comment. Update after review http://reviews.llvm.org/D13336 Files: include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/Serialization/ASTBitCodes.h lib/AST/ASTContext.cpp lib/AST/Type.cpp lib/AST

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev updated this revision to Diff 38232. ABataev marked 4 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D13336 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h inclu

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

ABataev marked an inline comment as done. ABataev added a comment. Hi Chandler, thanks for the review. In http://reviews.llvm.org/D13802#272053, @chandlerc wrote: > Some minor issues below. Also, Hans and Tom should have a glance at the > release bits of this, I don't know any of that stuff. >

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

ABataev added reviewers: hans, tstellarAMD. ABataev updated this revision to Diff 38374. ABataev marked an inline comment as done. http://reviews.llvm.org/D13802 Files: autoconf/configure.ac configure docs/GettingStarted.rst docs/ReleaseProcess.rst utils/release/test-release.sh Index:

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

ABataev added a comment. In http://reviews.llvm.org/D13802#277270, @jhowarth wrote: > The proposed patches here to change the default behavior of -fopenmp from > -fopenmp=libgomp to -fopenmp=libomp seem to only handle the configure-based > build. The following change required to switch over the

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

ABataev added a comment. In http://reviews.llvm.org/D13802#276755, @hfinkel wrote: > In http://reviews.llvm.org/D13802#275471, @chandlerc wrote: > > > In http://reviews.llvm.org/D13802#274847, @ABataev wrote: > > > > > Hi Chandler, thanks for the review. > > > > > > In http://reviews.llvm.org/D13

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:2628 @@ +2627,3 @@ + friend class OMPClauseWriter; + friend class Sema; + I don't like the idea of friend Sema. If Sema needs some interfaces, they must be public. Com

r244209 - [OPENMP 4.1] Allow references in init expression for loop-based constructs.

Author: abataev Date: Thu Aug 6 07:30:57 2015 New Revision: 244209 URL: http://llvm.org/viewvc/llvm-project?rev=244209&view=rev Log: [OPENMP 4.1] Allow references in init expression for loop-based constructs. OpenMP 4.1 allows to use variables with reference types in private clauses and, theref

Re: [PATCH] D11828: [MSVC] Crash fix: assigning of overloaded member function pointer caused assertion

ABataev updated the summary for this revision. ABataev updated this revision to Diff 31631. ABataev added a comment. Update after review http://reviews.llvm.org/D11828 Files: lib/Sema/SemaCast.cpp test/CodeGenCXX/microsoft-abi-member-pointers.cpp Index: lib/Sema/SemaCast.cpp ==

r244428 - [MSVC] Crash fix: assigning of overloaded member function pointer caused assertion

Author: abataev Date: Sun Aug 9 23:07:49 2015 New Revision: 244428 URL: http://llvm.org/viewvc/llvm-project?rev=244428&view=rev Log: [MSVC] Crash fix: assigning of overloaded member function pointer caused assertion Original class was not marked with inheritance attribute and it causes a crash

Re: [PATCH] D11828: [MSVC] Crash fix: assigning of overloaded member function pointer caused assertion

This revision was automatically updated to reflect the committed changes. Closed by commit rL244428: [MSVC] Crash fix: assigning of overloaded member function pointer caused… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D11828?vs=31631&id=31632#toc Repository: rL L

Re: [PATCH] D22487: [OpenMP] Ignore parens in atomic capture

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D22479: [OpenMP] Sema and parsing for 'target simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D22481: [OpenMP] Allow negative lower bound in array sections based on pointers

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

r275945 - [OPENMP] Improved processing of 'priority' clause, NFC.

Author: abataev Date: Mon Jul 18 23:21:09 2016 New Revision: 275945 URL: http://llvm.org/viewvc/llvm-project?rev=275945&view=rev Log: [OPENMP] Improved processing of 'priority' clause, NFC. Removed some old comments + improved handling of 'priority' clause value during codegen after comments from

r275947 - [OPENMP] Removed loop statement as its body executes at most once, NFC.

Author: abataev Date: Tue Jul 19 00:06:39 2016 New Revision: 275947 URL: http://llvm.org/viewvc/llvm-project?rev=275947&view=rev Log: [OPENMP] Removed loop statement as its body executes at most once, NFC. Removed not required loop statement, addressing comments from Richard Smith. Modified:

Re: [PATCH] D22690: [OpenMP] Add support for mapping array sections through pointer references.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5280 @@ -5279,5 +5279,3 @@ BP = CGF.EmitLoadOfPointerLValue(PtrAddr.getAddress(), -

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

ABataev requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/AST/OpenMPClause.h:4252 @@ -4237,1 +4251,3 @@ + + /// \brief Build clause with number of variables \a NumVars. /// No \brief

Re: [PATCH] D22785: [OpenMP] diagnose orphaned teams construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/Sema/SemaOpenMP.cpp:3360-3366 @@ -3356,5 +3359,9 @@ if (NestingProhibited) { - SemaRef.Diag(StartLoc, diag::err_omp_prohibited_region

Re: [PATCH] D22787: [OpenMP] Add support to map member expressions with references to pointers.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D22788: [OpenMP] Code generation for the is_device_ptr clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with some nits Comment at: include/clang/AST/OpenMPClause.h:4419 @@ -4405,1 +4418,3 @@ + } + /// \brief Build clause with number of variables \a NumVars. /// ---

Re: [PATCH] D22895: [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

ABataev created this revision. ABataev added reviewers: rnk, rsmith, majnemer. ABataev added subscribers: cfe-commits, andreybokhanko. MSVC actively uses unqualified lookup in dependent bases, lookup at the instantiation point (non-dependent names may be resolved on things declared later) etc. a

Re: [PATCH] D23189: [OpenMP] Sema and parsing for 'teams distribute' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: include/clang/Sema/Sema.h:8254 @@ -8253,1 +8253,3 @@ llvm::DenseMap &VarsWithImplicitDSA); + /// \brief Called on well-formed '\#pragma omp

Re: [PATCH] D22955: [MSVC] Improved late parsing of template functions.

ABataev added a comment. Ping https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259465 - [OPENMP 4.0] Allow to use 'omp simd' directive inside other simd-regions.

Author: abataev Date: Mon Feb 1 22:59:52 2016 New Revision: 259465 URL: http://llvm.org/viewvc/llvm-project?rev=259465&view=rev Log: [OPENMP 4.0] Allow to use 'omp simd' directive inside other simd-regions. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp cfe/trunk/test/OpenMP/nesting_of_regi

Re: [PATCH] D16759: [OpenMP] Parsing + sema for target parallel for directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with small comment Comment at: lib/Parse/ParseOpenMP.cpp:185 @@ -182,3 +184,3 @@ /// 'distribute' | 'target enter data' | 'target exit data' | -/// 'targ

Re: [PATCH] D16801: [OpenMP] Change in initial size of DSAStackTy::StackTy

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG. Will you commit it yourself or you want me to do this? http://reviews.llvm.org/D16801 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeCommon.h:1 @@ +1,2 @@ +//=== CGOpenMPRuntimeCommon.h - Helpers for OpenMP Runtimes Codegen ==// +// I don't think we need this new file and new namespace. If some (currently) internal

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a comment. Richard? http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev added a comment. Richard? http://reviews.llvm.org/D10599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259750 - PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression, by Dmitry Polukhin

Author: abataev Date: Wed Feb 3 22:22:09 2016 New Revision: 259750 URL: http://llvm.org/viewvc/llvm-project?rev=259750&view=rev Log: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression, by Dmitry Polukhin Differential Revision: http://reviews.llvm.org/D16572

Re: [PATCH] D16572: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression

ABataev added a subscriber: ABataev. ABataev closed this revision. ABataev added a comment. Committed in http://reviews.llvm.org/rL259750 http://reviews.llvm.org/D16572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:340-341 @@ +339,4 @@ + case llvm::Triple::nvptx64: +assert(CGM.getLangOpts().OpenMPIsDevice && + "OpenMP NVPTX is only prepared to deal with device code."); +return createCGOpenMPRuntimeN

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:552-555 @@ -551,2 +551,6 @@ + /// \brief Create specialized OpenMP runtime code generation class for NVPTX + /// targets. + static CGOpenMPRuntime *createCGOpenMPRuntimeNVPTX(CodeGenModule &CGM); + publ

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:552-555 @@ -551,2 +551,6 @@ + /// \brief Create specialized OpenMP runtime code generation class for NVPTX + /// targets. + static CGOpenMPRuntime *createCGOpenMPRuntimeNVPTX(CodeGenModule &CGM); + publ

r259776 - [OPENMP 4.0] Fixed support of array sections/array subscripts.

Author: abataev Date: Thu Feb 4 05:27:03 2016 New Revision: 259776 URL: http://llvm.org/viewvc/llvm-project?rev=259776&view=rev Log: [OPENMP 4.0] Fixed support of array sections/array subscripts. Codegen for array sections/array subscripts worked only for expressions with arrays as base. Patch f

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:218 @@ -204,1 +217,3 @@ + } + return; } I think this must be removed Comment at: lib/Frontend/CompilerInvocation.cpp:1837 @@ +1836,3 @@ + Diags.Report(clang::diag::

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:1837 @@ +1836,3 @@ + Diags.Report(clang::diag::err_drv_omp_host_or_device_target_not_supported) + << TargetOpts.Triple << /*Device=*/false; + break; No, I mean do we

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r260077 - [OPENMP 4.5] Ccapture/codegen of private non-static data members.

Author: abataev Date: Mon Feb 8 03:29:13 2016 New Revision: 260077 URL: http://llvm.org/viewvc/llvm-project?rev=260077&view=rev Log: [OPENMP 4.5] Ccapture/codegen of private non-static data members. OpenMP 4.5 introduces privatization of non-static data members of current class in non-static mem

Re: r260077 - [OPENMP 4.5] Ccapture/codegen of private non-static data members.

, 2016 at 6:33 PM Alexey Bataev via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: abataev Date: Mon Feb 8 03:29:13 2016 New Revision: 260077 URL: http://llvm.org/viewvc/llvm-project?rev=260077&view=rev Log: [OPENMP 4.5] Ccapture/codegen of private non-static data members.

<    7   8   9   10   11   12   13   14   15   16   >