[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-23 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 339973. bader marked an inline comment as done. bader added a comment. Generalize getStringLiteralAddressSpace to GetGlobalConstantAddressSpace Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-04-23 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 340011. bader added a comment. Incorporate https://reviews.llvm.org/D89909 review feedback. Allow one way implicit conversion only for now. >From named address space to default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-23 Thread Alexey Bader via Phabricator via cfe-commits
bader marked 5 inline comments as done. bader added a comment. @Anastasia, I've updated https://reviews.llvm.org/D99488 and refactored `getStringLiteralAddressSpace` to handle non-string constants as well. Please, take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-26 Thread Alexey Bader via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. bader marked an inline comment as done. Closed by commit rG7818906ca134: [SYCL] Implement SYCL address space attributes handling (authored by bader). Changed prior to

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-04-26 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 340526. bader added a comment. Rebased patch to unblock commit. This patch had a dependency on D99190 , which adds SYCLSupport.rst document. To unblock commit of D99488 , I switched the order o

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

2021-04-26 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 340528. bader added a comment. Rebase on ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/Address

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

2021-04-26 Thread Alexey Bader via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb52e69c42681: [SYCL][Doc] Add design document for SYCL mode (authored by bader). Changed prior to commit: https://reviews.llvm.org/D99488?vs=34052

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

2021-04-29 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D99488#2725435 , @Anastasia wrote: > If I build docs now I get the following output: > > llvm-project/build-doc/tools/clang/docs/SYCLSupport.rst:102: WARNING: Error > in "code-block" directive: > 1 argument(s) required, 0 sup

[PATCH] D101549: [Doc] Fix sphynx warnings about wrong code-block format

2021-04-29 Thread Alexey Bader via Phabricator via cfe-commits
bader created this revision. bader added a reviewer: Anastasia. Herald added a subscriber: ebevhan. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101549 Files: clan

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

2021-04-29 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. Thanks! I've uploaded this version to https://reviews.llvm.org/D101549. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 ___ cfe-commits mai

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

2021-04-30 Thread Alexey Bader via Phabricator via cfe-commits
bader abandoned this revision. bader added a comment. Herald added a subscriber: ldrumm. Committed alternative version - https://reviews.llvm.org/D89909. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80932/new/ https://reviews.llvm.org/D80932

[PATCH] D101549: [Doc] Fix sphynx warnings about wrong code-block format

2021-04-30 Thread Alexey Bader via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG76f84e772978: [Doc] Fix sphinx warnings about wrong code-block format (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101549/new/ https:/

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

2021-05-11 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 344393. bader added a comment. Apply code review suggestions and rebase on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files: clang/docs/SYCLSupport.rst cl

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

2021-05-11 Thread Alexey Bader via Phabricator via cfe-commits
bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/test/SemaSYCL/address-space-conversions.cpp:74 + GLOB = GLOB_DEVICE; + GLOB_DEVICE = GLOB; // expected-error {{assigning '__global int *' to '__global_device int *' changes address space of

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

2021-05-11 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 344399. bader marked an inline comment as done. bader added a comment. Added explicit cast checks to Sema tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files:

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

2021-12-07 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D110622#3174113 , @tra wrote: > The patch looks OK for the time being. That said, I do have concerns that we > may be organically growing something that will be troublesome to deal with > long-term. > > TBH, I still can't quite

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

2021-12-08 Thread Alexey Bader via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae5810b53c2: [HIPSPV] Convert HIP kernels to SPIR-V kernels (authored by linjamaki, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10981

[PATCH] D99190: [SYCL] Add design document for SYCL mode

2021-03-23 Thread Alexey Bader via Phabricator via cfe-commits
bader created this revision. Herald added subscribers: mstorsjo, Anastasia, ebevhan, yaxunl. bader requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Initial version of the document covers most of t

[PATCH] D99258: [OpenCL] Fix AST check in address-space-templates test

2021-03-24 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99258/new/ https://reviews.llvm.org/D99258 ___ cfe-commits mailing list cfe-comm

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-03-25 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 333247. bader added a comment. [NFC] Align address space map names with AMDGPU target. Rename SPIRAddrSpaceMap and SYCLAddrSpaceMap to SPIRDefIsPrivMap and SPIRDefIsGenMap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-03-25 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. Let's take a look at compilation output for the following program: c++ void foo(int *p) {} OpenCL compiler produces following LLVM IR for SPIR target: LLVM define dso_local spir_func void @_Z3fooPU3AS4i(i32 addrspace(4)* nocapture %0) local_unnamed_addr #0 {

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

2021-03-25 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 333279. bader marked 16 inline comments as done. bader added a comment. Apply most of the comments from Ronan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/ https://reviews.llvm.org/D99190 Files: cl

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

2021-03-25 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. @keryell, thanks for the feedback. I applied your suggestions with two exceptions: 1. I'm not sure if other back-ends need special processing for kernel function parameters we apply for SPIR kernels. 2. I'm looking for suggestions on "OpenCL extensions" clarification.

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

2021-03-25 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 333502. bader added a comment. Resolve "OpenCL extensions" ambiguity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/ https://reviews.llvm.org/D99190 Files: clang/docs/SYCLSupport.md clang/docs/imag

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

2021-03-25 Thread Alexey Bader via Phabricator via cfe-commits
bader marked an inline comment as done. bader added a comment. In D99190#2652054 , @keryell wrote: >> ! In D99190#2650326 , @bader wrote: >> >> 2. I'm looking for suggestions on "OpenCL extensions" clarification. >

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-03-25 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D89909#2624284 , @aaron.ballman wrote: > Based on the discussion so far, would these be acceptable steps to take? > > 0) Complete review on this patch for any technical concerns related to it and > commit when it's ready (this u

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

2021-03-26 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 333581. bader added a comment. Add links to SYCL specification with address space behavior description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/ https://reviews.llvm.org/D99190 Files: clang/doc

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-03-26 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. > Yesterday, we chatted offline and agreed that the main issue is missing > documentation for Clang extensions being added for SYCL. To address this > issue we are adding SYCL architecture design document, which we are going to > update along with adding new features. I'

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-03-29 Thread Alexey Bader via Phabricator via cfe-commits
bader created this revision. bader added reviewers: Anastasia, keryell, Naghasan. Herald added subscribers: ebevhan, yaxunl. bader requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

2021-03-29 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 333780. bader added a comment. Move address space handling section to https://reviews.llvm.org/D99488 to address https://reviews.llvm.org/D89909#2653452. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-03-29 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D99488#2655326 , @Anastasia wrote: > Thanks. I am guessing you will address relevant review comments from D99190 > in here? Yes. I'm working on it. I wanted to make it in a separate update, so i

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-03-29 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 333853. bader added a comment. Applied code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Files: clang/docs/SYCLSupport.md Index: clang/docs/SYCLSup

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

2021-03-29 Thread Alexey Bader via Phabricator via cfe-commits
bader marked 8 inline comments as done. bader added a comment. @Anastasia, I've addressed the comments for the address space section in https://reviews.llvm.org/D99488. Let's move discussion there. Comment at: clang/docs/SYCLSupport.md:861 +space for types with no address spac

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

2021-03-30 Thread Alexey Bader via Phabricator via cfe-commits
bader added a subscriber: ABataev. bader added inline comments. Comment at: clang/docs/SYCLSupport.md:73 +the integration header is used (included) by the SYCL runtime implementation, so +the header must be available before the host compilation starts.* + Naghas

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-03-31 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 334420. bader marked 24 inline comments as done. bader added a comment. Applied code review suggestions Resolved merge conflicts with D99190 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-03-31 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/docs/SYCLSupport.md:821 +SYCL compiler toolchain. Section 3.8.2 of SYCL 2020 specification defines +[memory model](https://www.khronos.org/registry/SYCL/specs/sycl-2020/html/sycl-2020.html#_sycl_device_memory_model), +section 4.7.7

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-03-31 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 334433. bader added a comment. Convert document to ReST format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Files: clang/docs/SYCLSupport.rst Index: clang/docs/SYC

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

2021-04-01 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. + Naghasan wrote: > ABataev wrote: > > ba

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-04-01 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 334689. bader marked 3 inline comments as done. bader added a comment. Applied code review suggestions from @Naghasan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Fil

[PATCH] D99190: [SYCL] Add design document for SYCL mode

2021-04-01 Thread Alexey Bader via Phabricator via cfe-commits
bader marked an inline comment as done. bader added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. +

[PATCH] D99190: [SYCL] Add design document for SYCL mode

2021-04-01 Thread Alexey Bader via Phabricator via cfe-commits
bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/docs/SYCLSupport.md:51 +virtual calls), generates LLVM IR for the device code only and an "integration +header" which provides information like kernel name, parameters order and data +type for

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-04-02 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 334927. bader marked 4 inline comments as done. bader added a comment. Address comments from @Anastasia. - Removed controversial clarifications. - Reshuffled text to keep language semantics clarifications closer to each other. Repository: rG LLVM Github Mo

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-04-02 Thread Alexey Bader via Phabricator via cfe-commits
bader marked 4 inline comments as done. bader added inline comments. Comment at: clang/docs/SYCLSupport.rst:243 +Similar to other single-source C++-based GPU programming modes like +OpenMP/CUDA/HIP, SYCL uses clang's "default" address space for types with no +explicit address spa

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-04-06 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 335596. bader marked 7 inline comments as done. bader added a comment. Add ReST marks to hyperlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Files: clang/docs/S

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

2021-04-07 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D99488#2671906 , @Anastasia wrote: > LGTM! Thanks for working on this. The expected sematic seems fairly clear now. Thanks for review! I also fixed external hyperlinks formatting. > We might add a few more details while refining

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-09 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 336543. bader marked 32 inline comments as done. bader added a comment. Applied code review suggestions. Rebased on ToT and updated commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https:

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-09 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || Anastasia wrote: >

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-12 Thread Alexey Bader via Phabricator via cfe-commits
bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:488 (A == LangAS::opencl_global && (B == LangAS::opencl_global_device || B == LangAS::opencl_global_host)) ||

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-13 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 337180. bader marked 16 inline comments as done. bader added a comment. Applied more code review suggestions. Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-13 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || Anastasia wrote: >

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

2021-04-13 Thread Alexey Bader via Phabricator via cfe-commits
bader created this revision. Herald added subscribers: Naghasan, ldrumm, dexonsmith, kerbowa, Anastasia, ebevhan, yaxunl, nhaehnle, jvesely, jholewinski. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mo

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-13 Thread Alexey Bader via Phabricator via cfe-commits
bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:488 (A == LangAS::opencl_global && (B == LangAS::opencl_global_device || B == LangAS::opencl_global_host)) ||

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-14 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 337441. bader marked 5 inline comments as done. bader added a comment. Applied more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-14 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2379 unsigned TargetAS = Context.getASTContext().getTargetAddressSpace(AS); - if (TargetAS != 0) + if (TargetAS != 0 || Context.getASTContext().getLangOpts().SYCLIsDevice) ASString

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-19 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); Anastasia wr

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-19 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); Anastasia wr

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-20 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); Anastasia wr

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-21 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 339484. bader marked 7 inline comments as done. bader added a comment. Applied more review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/includ

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-22 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 339515. bader marked an inline comment as done. bader added a comment. Added SYCL address spaces mangling for targets without address space map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://rev

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-04-22 Thread Alexey Bader via Phabricator via cfe-commits
bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:140 +// space must be compatible with the generic address space +return LangAS::sycl_global; + } Anastasia wrote: > This needs a language guar

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-01-13 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D89909#2448443 , @Anastasia wrote: > If you prefer to continue this route then you should just document your > dialect sematic somewhere publicly accessible and avoid aliasing to OpenCL, > or target address spaces. So it would b

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-01-13 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 316447. bader added a comment. Re-base patch and fix lit test failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang/AST/Type.h clang/in

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

2021-01-20 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

2021-10-06 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D109144#3042247 , @Anastasia wrote: > 1. Implementing SPIR-V target as SPIR target. @bader do you suggest that we > add `spirv` triple to clang and map it into SPIR taget or do you suggest > something different? What I have i

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

2021-10-13 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:45 + /// accessor class. + static bool isSyclAccessorType(const QualType &Ty); + erichkeane wrote: > Isn't there a big rewrite going on downstream of these with > `sycl_special_class`? Why a

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

2021-10-14 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D71016#3063457 , @tschuett wrote: > It feels like you are doing codegen(OpenCL kernel) in Sema. Are OpenCL > kernels the only approach. We need to update the description of the patch to clarify that it applies to other GPU prog

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

2021-10-14 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D71016#3063762 , @tschuett wrote: > Would a codegenSYCL directory help you to separate Sema from code generation? Moving wrapper kernel function generation to CodeGen library make sense to me. > Doesn't this make AST non-represe

[PATCH] D111566: [SYCL] Fix function pointer address space

2021-10-20 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. @vlastik, your commit fixes function pointers on AVR - https://github.com/llvm/llvm-project/commit/57fd86de879cf2b4c7001b6d0a09df60877ce24d. I suppose this change is required for fixing lvalue r

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

2021-08-25 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Basic/Targets/SPIR.h:146 +// See comment on the SPIRDefIsGenMap table. +bool IsHIPSPV = Opts.HIP && Opts.CUDAIsDevice; // FIXME: SYCL s

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

2021-08-26 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

2021-09-13 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in keryell wr

<    1   2   3   4