[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:227 +(TSTy = Ty->getAs())) + Result.addOuterTemplateArguments(const_cast(FTD), + TSTy->template_arguments(), er

[PATCH] D143781: [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: efriedma, aaron.ballman, mibintc. alexander-shaposhnikov created this object with visibility "All Users". Herald added a subscriber: kristof.beyls. Herald added a project: All. alexander-shaposhnikov requested rev

[PATCH] D143781: [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64

alexander-shaposhnikov added a comment. sure, will do! thanks for the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143781/new/ https://reviews.llvm.org/D143781 ___ cfe-commits mailing list cfe-co

[PATCH] D143781: [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f5d81585aa9: [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64 (authored by alexander-shaposhnikov). Changed prior to commit:

[PATCH] D149906: [Clang] Update release notes

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: rsmith, erichkeane, ilya-biryukov. alexander-shaposhnikov created this object with visibility "All Users". Herald added a project: All. alexander-shaposhnikov requested review of this revision. Herald added a proj

[PATCH] D149906: [Clang] Update release notes

alexander-shaposhnikov updated this revision to Diff 519660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149906/new/ https://reviews.llvm.org/D149906 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst ===

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. Reverted in https://github.com/llvm/llvm-project/commit/3b9ed6e5323176550925f3b0a2c50ced1b61438d, it'll take time to investigate this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://r

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 519708. alexander-shaposhnikov added a comment. Add more tests, Fix HandlePartialClassTemplateSpec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Fil

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 519711. alexander-shaposhnikov added a comment. Remove dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/include/clang/AST/Decl

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:133 } +Response HandlePartialClassTemplateSpec( alexander-shaposhnikov wrote: > HandlePartialClassTemplateSpec is from Erich's diff > (https://reviews.llvm.or

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/test/SemaTemplate/concepts-out-of-line-def.cpp:348 + +namespace MultilevelTemplateWithPartialSpecialization { +template (new tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @davidtgoldblatt - thanks for the report. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___ cfe-commits mailing list c

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:133 } +Response HandlePartialClassTemplateSpec( alexander-shaposhnikov wrote: > alexander-shaposhnikov wrote: > > HandlePartialClassTemplateSpec is from Erich'

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:133 } +Response HandlePartialClassTemplateSpec( alexander-shaposhnikov wrote: > alexander-shaposhnikov wrote: > > alexander-shaposhnikov wrote: > > > HandlePar

[PATCH] D150285: Fix CRTP partial specialization instantiation crash.

alexander-shaposhnikov accepted this revision. alexander-shaposhnikov added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150285/new/ https://reviews.llvm.org/D150285 ___ cfe-comm

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - I'll have stable internet ~soon and will try to look into the reported issue (but help would be greatly appreciated). To the best of my knowledge there are other problems with libstdc++'s ranges (even without this diff), but yeah, this regres

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - I took your example and tried to reduce it further https://godbolt.org/z/jEx9vdj7K It's kind of a difficult situation - both gcc and msvc accept it, yet /* very very cautiously */ it might happen that the code is actually invalid ... (i'd nee

[PATCH] D150730: [Clang][Sema] Substitute constraints only for declarations with different lexical contexts

alexander-shaposhnikov created this revision. alexander-shaposhnikov added a reviewer: erichkeane. alexander-shaposhnikov created this object with visibility "All Users". Herald added a project: All. alexander-shaposhnikov requested review of this revision. Herald added a project: clang. Herald add

[PATCH] D150730: [Clang][Sema] Substitute constraints only for declarations with different lexical contexts

alexander-shaposhnikov updated this revision to Diff 522856. alexander-shaposhnikov added a comment. Include context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150730/new/ https://reviews.llvm.org/D150730 Files: clang/lib/Sema/SemaConcept.cp

[PATCH] D150730: [Clang][Sema] Substitute constraints only for declarations with different lexical contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rG122b938944ce: [Clang][Sema] Substitute constraints only for declarations with different… (authored by alexander-shaposhnikov). Changed prior to commit: https://reviews.llvm.org/D150730?vs=522856&id=5231

[PATCH] D149906: [Clang] Update release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4677f20704: [Clang] Update release notes (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149906/new/ https://reviews.l

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:263 + if (SubstitutedAtomicExpr.get()->isValueDependent()) +return SubstitutedAtomicExpr; erichkeane wrote: > alexander-shaposhnikov wrote: > > erichkeane wrote: > > >

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:263 + if (SubstitutedAtomicExpr.get()->isValueDependent()) +return SubstitutedAtomicExpr; alexander-shaposhnikov wrote: > erichkeane wrote: > > alexander-shaposhnikov

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 514745. alexander-shaposhnikov added a comment. New version (address some comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/incl

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:781 + /*ForConstraintInstantiation=*/true, /*SkipForSpecialization*/ false); + Sema::SFINAETrap SFINAE(S, /*AccessCheckingSFINAE=*/false); + std::optional ThisScope; r

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:781 + /*ForConstraintInstantiation=*/true, /*SkipForSpecialization*/ false); + Sema::SFINAETrap SFINAE(S, /*AccessCheckingSFINAE=*/false); + std::optional ThisScope; a

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:263 + if (SubstitutedAtomicExpr.get()->isValueDependent()) +return SubstitutedAtomicExpr; alexander-shaposhnikov wrote: > alexander-shaposhnikov wrote: > > erichkeane

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. Yeah, things appear to work for the current version of this diff (including GH62110). However, while doing some internal testing I've discovered one suspicious issue (sigh, sigh), but haven't been able to create a standalone repro yet. Need more time for d

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. reduced test case (that is currently blocking this diff) : namespace outer::internal { template concept myconcept = true; } namespace outer { template class Foo; template struct Bar { template friend class Foo; };

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov planned changes to this revision. alexander-shaposhnikov added a comment. /* working on it */ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. /* will update the diff ~soon */ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___ cfe-commits mailing list cfe-commit

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 517513. alexander-shaposhnikov added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/include/clang/AST/DeclTem

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3b1083e00e6: [Clang][Sema] Fix comparison of constraint expressio

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - thanks! I'll send a diff for the release notes ~soon (~this week). (P.S. just in case - I'll be out of office for ~2 weeks) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://r

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - feel free to take over this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___ cfe-commits mailin

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. reduced test case: template concept Concept = false; struct Foo { template struct result {}; template requires(Concept<_Tp>) struct result<_Tp>; }; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. upd. In the reduced example above MLTAL is incorrect (lldb) p MLTAL.dump() NumRetainedOuterLevels: 1 1: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 518966. alexander-shaposhnikov added a comment. 1. If innermost != nullptr (in getTemplateInstantiationArgs) and NS is a ClassTemplatePartialSpecializationDecl we were incorrectly adding the inner level of template args twice (once as an array

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 518990. alexander-shaposhnikov added a comment. Simplify code a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/include/clan

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:133 } +Response HandlePartialClassTemplateSpec( HandlePartialClassTemplateSpec is from Erich's diff (https://reviews.llvm.org/D147722) Comm

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - thanks, then I'm going to give it another try. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___ cfe-com

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. P.S. Landed. If it survives in the trunk this time - I'll send a follow-up diff with the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov created this revision. alexander-shaposhnikov added a reviewer: tra. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: mattd, carlosgalvezp, yaxunl. Herald added a project: All. alexander-shaposhnikov requested review of this re

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov added inline comments. Comment at: clang/test/SemaCUDA/neon-attrs.cu:2 +// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature +neon -x cuda -fsyntax-only -DNO_DIAG -verify %s +// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature -neon -x cuda -

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8168 +IsTargetCUDAAndHostARM = +!AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + } tra wrote: > Should it be `AuxTI && (AuxTI->getTriple().

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov updated this revision to Diff 529794. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152403/new/ https://reviews.llvm.org/D152403 Files: clang/lib/Sema/SemaType.cpp

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov updated this revision to Diff 529795. alexander-shaposhnikov marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152403/new/ https://reviews.llvm.org/D152403 Files: clang/lib/Sema/SemaType.cpp c

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov updated this revision to Diff 529801. alexander-shaposhnikov added a comment. Add missing parentheses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152403/new/ https://reviews.llvm.org/D152403 Files: clang/lib/Sema/SemaTyp

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b0ea4874093: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap created this revision. alexshap added reviewers: beanz, bogner. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. Herald added a subscriber: mgorny. This diff fixes the clean build of the target generate-order-file. In llvm/tools/clang/CMa

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap updated this revision to Diff 82703. alexshap added a comment. minor changes Repository: rL LLVM https://reviews.llvm.org/D28153 Files: CMakeLists.txt utils/perf-training/CMakeLists.txt Index: utils/perf-training/CMakeLists.txt =

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap added inline comments. Comment at: utils/perf-training/CMakeLists.txt:61 +message(FATAL_ERROR "Output clang order file is not set") + endif() + mehdi_amini wrote: > I'm missing something: the code in the main CMakeLists seems to allows to > have an

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap added inline comments. Comment at: CMakeLists.txt:436 + + if(CLANG_ORDER_FILE AND NOT EXISTS ${CLANG_ORDER_FILE}) +string(FIND "${CLANG_ORDER_FILE}" "${CMAKE_CURRENT_BINARY_DIR}" PATH_START) mehdi_amini wrote: > So why `if(CLANG_ORDER_FILE ` here?

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap removed rL LLVM as the repository for this revision. alexshap updated this revision to Diff 82715. alexshap added a comment. upd https://reviews.llvm.org/D28153 Files: CMakeLists.txt utils/perf-training/CMakeLists.txt Index: utils/perf-training/CMakeLists.txt

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap added inline comments. Comment at: utils/perf-training/CMakeLists.txt:61 +message(FATAL_ERROR "Output clang order file is not set") + endif() + alexshap wrote: > mehdi_amini wrote: > > I'm missing something: the code in the main CMakeLists seems to

[PATCH] D28153: [clang] Fix clean build of generate-order-file

This revision was automatically updated to reflect the committed changes. Closed by commit rL290781: [clang] Fix clean build of generate-order-file (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D28153?vs=82715&id=82755#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D28226: threading_support: introduce __libcpp_recursive_mutex_t

alexshap added inline comments. Comment at: include/__threading_support:82 +typename = typename _VSTD::enable_if::value>::type> + _LIBCPP_CONSTEXPR indentation looks a bit strange Repository: rL LLVM https://reviews.llvm.org/D28226 _

[PATCH] D28269: [clang] Update lit config in utils/perf-training

alexshap created this revision. alexshap added reviewers: mehdi_amini, beanz, bogner. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. This diff removes --driver-mode=cpp from utils/perf-training/order-files.lit.cfg and utils/perf-training/lit.cf

[PATCH] D28269: [clang] Update lit config in utils/perf-training

alexshap added a comment. it works for me, i have just double checked. Although to generate a file which provides any measurable improvements (was i measuring the total build time of LLVM (using the new binary)) i had to make some extra changes (on OSX 10.12.1) (slightly change dtrace script, r

[PATCH] D28269: [clang] Update lit config in utils/perf-training

alexshap added a comment. btw: --driver-mode=g++ works as well Repository: rL LLVM https://reviews.llvm.org/D28269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28269: [clang] Update lit config in utils/perf-training

alexshap updated this revision to Diff 82986. alexshap added a comment. switch to --driver-mode=g++ Repository: rL LLVM https://reviews.llvm.org/D28269 Files: utils/perf-training/lit.cfg utils/perf-training/order-files.lit.cfg Index: utils/perf-training/order-files.lit.cfg

[PATCH] D28269: [clang] Update lit config in utils/perf-training

This revision was automatically updated to reflect the committed changes. Closed by commit rL290936: [clang] Update lit config in utils/perf-training (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D28269?vs=82986&id=82999#toc Repository: rL LLVM https://reviews.ll

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

alexshap added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:563 + // Create a replacement merely for retrieving file path and start offset. + const auto R = createReplacement(Start, Start, "", *Result.SourceManager); MoveNamespace MoveNs; ---

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

alexshap added a comment. thx, LGTM https://reviews.llvm.org/D28282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

alexshap added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:527 + if (ReturnSymbol) +for (AllocatedDataTy::iterator I = ASet.begin(), E = ASet.end(); + I != E; ++I) { nit: auto I = ...

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

alexshap added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:527 + if (ReturnSymbol) +for (AllocatedDataTy::iterator I = ASet.begin(), E = ASet.end(); + I != E; ++I) { alexshap wrote: >

[PATCH] D28461: [clang] Enable using --section-ordering-file option of ld.gold

alexshap updated this revision to Diff 83582. alexshap added a comment. This revision is now accepted and ready to land. Address comments Repository: rL LLVM https://reviews.llvm.org/D28461 Files: CMakeLists.txt Index: CMakeLists.txt ==

[PATCH] D28461: [clang] Enable using --section-ordering-file option of ld.gold

This revision was automatically updated to reflect the committed changes. Closed by commit rL291449: [clang] Enable using --section-ordering-file option of ld.gold (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D28461?vs=83582&id=83637#toc Repository: rL LLVM http

[PATCH] D28081: Make GetStyle return Expected instead of FormatStyle

alexshap added inline comments. Comment at: lib/Format/Format.cpp:424 +llvm::Error make_string_error(const llvm::Twine &Message) { + return llvm::make_error(Message, amaiorano wrote: > ioeric wrote: > > Maybe make this `inline`? > Yes. regarding this function

[PATCH] D31492: Add `replace` interface with range in AtomicChange.

alexshap added a comment. to avoid misunderstanding - are the tools like clang-rename, change-namespace and clang-reorder-fields supposed to use AtomicChange (via the methods insert, replace etc) ? (i am asking just to make sure i understand correctly the intentions behind AtomicChange interfac

[PATCH] D31840: [analyzer] Fix crash on access to property

alexshap created this revision. alexshap created this object with visibility "All Users". Preliminary context about unions: at the moment for unions the static analyzer creates default bindings (as a compoundVal). If a union has only one field x which is initialized to zero this is handled as an

[PATCH] D31840: [analyzer] Fix crash on access to property

alexshap updated this revision to Diff 94713. alexshap added a comment. 1. update the patch following NoQ@ suggestion 2. rerun the tests: make check-all - they are green Repository: rL LLVM https://reviews.llvm.org/D31840 Files: lib/StaticAnalyzer/Core/CallEvent.cpp test/Analysis/propert

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

alexshap added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:965 + +// Performing operator `&' on an lvalue expression is essentially a no-op. +// Then, if we are taking addresses of fields or elements, these are also "Addre

[PATCH] D32063: [clang-move] cleanup: create ClangMoveActionFactory on the stack

alexshap created this revision. alexshap created this object with visibility "All Users". This diff removes unnecessary using of unique_ptr with ClangMoveActionFactory (pico cleanup). NFC Repository: rL LLVM https://reviews.llvm.org/D32063 Files: tool/ClangMoveMain.cpp Index: tool/Clang

[PATCH] D32063: [clang-move] cleanup: create ClangMoveActionFactory on the stack

This revision was automatically updated to reflect the committed changes. Closed by commit rL300356: [clang-move] Create ClangMoveActionFactory on stack (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D32063?vs=95233&id=95326#toc Repository: rL LLVM https://reviews

[PATCH] D32112: [clang] Register isConstexpr matcher

alexshap created this revision. alexshap created this object with visibility "All Users". I was working on some analyzer / clang-tidy code and noticed that isConstexpr was not available in clang-query. This diff registers this matcher. F3226452: Screen Shot 2017-04-15 at 4.21.23 PM.png

[PATCH] D32112: [clang] Register isConstexpr matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rL300427: [clang] Register isConstexpr matcher (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D32112?vs=95385&id=95411#toc Repository: rL LLVM https://reviews.llvm.org/D3211

[PATCH] D34496: [clang] Fix printf check for CFIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rL306343: [clang] Enable printf check for CFIndex (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D34496?vs=103536&id=104038#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

alexshap added inline comments. Comment at: tools/extra/clang-rename/tool/ClangRename.cpp:167 FindingAction.getUSRList(); const std::vector &PrevNames = FindingAction.getUSRSpellings(); if (PrintName) { 1. nit: this line caught my eye (not directly r

[PATCH] D35041: [analyzer] Fix modeling bool-based types

alexshap created this revision. Herald added a subscriber: xazax.hun. This is a follow up for one of the previous diffs https://reviews.llvm.org/D32328. getTypeSize and with getIntWidth are not equivalent for bool (see https://clang.llvm.org/doxygen/ASTContext_8cpp_source.html#l08444), this caus

[PATCH] D35041: [analyzer] Fix modeling of bool based types

alexshap added a comment. thanks, 1. evalCastFromNonLoc is actually called there (and that's how i ran into this issue) because of (a bit unexpected to me) ImplicitCastExpr 'LValueToRValue' inside switch: F3629685: Screen Shot 2017-07-06 at 11.01.39 AM.png

[PATCH] D35041: [analyzer] Fix modeling of bool based types

alexshap added a comment. >> In https://reviews.llvm.org/D35041#801073, @alexshap wrote: >> evalCastFromNonLoc is actually called there (and that's how i ran into this >> issue) because of (a bit unexpected to me) ImplicitCastExpr 'LValueToRValue' >> inside switch > > Yeah, but the NonLoc that'

[PATCH] D35041: [analyzer] Fix modeling of bool based types

alexshap updated this revision to Diff 105524. alexshap added a comment. Add a test where evalCastFromLoc is called and the line unsigned BitWidth = Context.getIntWidth(castTy); is hit. I am planning to update this patch once again with a proper test where the path inside evalCastFromNonLoc is e

[PATCH] D35041: [analyzer] Fix modeling of bool based types

alexshap updated this revision to Diff 105562. alexshap added a comment. Add a test where SimpleSValBuilder::evalCastFromNonLoc is called and we hit the line unsigned castSize = Context.getIntWidth(castTy); Repository: rL LLVM https://reviews.llvm.org/D35041 Files: include/clang/StaticAna

[PATCH] D35041: [analyzer] Fix modeling of bool based types

alexshap updated this revision to Diff 105597. Repository: rL LLVM https://reviews.llvm.org/D35041 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/enum.cpp Index: test/Analysis/enum.cpp =

[PATCH] D35041: [analyzer] Fix modeling of bool based types

alexshap added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D35041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

alexshap added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:810 +public: + CollectReachableSymbolsCallback(ProgramStateRef State) {} + const InvalidatedSymbols &getSymbols() const { return Symbols; } explicit ? https://reviews.llvm.org/

[PATCH] D35041: [analyzer] Fix modeling of bool based types

This revision was automatically updated to reflect the committed changes. Closed by commit rL307604: [analyzer] Start fixing modeling of bool based types (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D35041?vs=105597&id=105947#toc Repository: rL LLVM https://revi

[PATCH] D35329: [clang-reorder-fields] Enable reordering for plain C structs

alexshap created this revision. This diff adds support for reordering fields in structs when the code compiles as plain C, in particular we switch to using RecordDecl instead of CXXRecordDecl where it's appropriate. Test plan: make check-all Repository: rL LLVM https://reviews.llvm.org/D35

[PATCH] D35378: [clang] Add getSignedSizeType method

alexshap created this revision. C11 standard refers to the signed counterpart of the size_t type in the paragraph 7.21.6.1 where it defines d, i, o, u, x, or x conversion specifiers (in printf format string). In Clang there is a FIXME (in lib/Analysis/PrintfFormatString.cpp) for this case (which

[PATCH] D35378: [clang] Add getSignedSizeType method

alexshap updated this revision to Diff 106496. alexshap added a comment. make comments consistent Repository: rL LLVM https://reviews.llvm.org/D35378 Files: include/clang/AST/ASTContext.h include/clang/Basic/TargetInfo.h lib/AST/ASTContext.cpp Index: lib/AST/ASTContext.cpp ==

[PATCH] D35378: [clang] Add getSignedSizeType method

This revision was automatically updated to reflect the committed changes. Closed by commit rL308037: [clang] Add getSignedSizeType method (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D35378?vs=106496&id=106662#toc Repository: rL LLVM https://reviews.llvm.org/D35

[PATCH] D35427: [clang] Fix handling of "%zd" format specifier

alexshap created this revision. This diff addresses FIXME in lib/Analysis/PrintfFormatString.cpp and makes Clang warn on incorrect using of "%zd" format specifier. Test plan: make check-all Repository: rL LLVM https://reviews.llvm.org/D35427 Files: lib/Analysis/PrintfFormatString.cpp te

[PATCH] D35427: [clang] Fix handling of "%zd" format specifier

alexshap updated this revision to Diff 106694. alexshap added a comment. Address comments Repository: rL LLVM https://reviews.llvm.org/D35427 Files: lib/Analysis/PrintfFormatString.cpp test/FixIt/format.m Index: test/FixIt/format.m ==

[PATCH] D35427: [clang] Fix handling of "%zd" format specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL308067: [clang] Fix handling of "%zd" format specifier (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D35427?vs=106694&id=106726#toc Repository: rL LLVM https://reviews.ll

[PATCH] D35427: [clang] Fix handling of "%zd" format specifier

alexshap added a comment. @chapuni - many thanks! Repository: rL LLVM https://reviews.llvm.org/D35427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35329: [clang-reorder-fields] Enable reordering for plain C structs

alexshap added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D35329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35329: [clang-reorder-fields] Enable reordering for plain C structs

alexshap updated this revision to Diff 107143. alexshap added a comment. update the comments Repository: rL LLVM https://reviews.llvm.org/D35329 Files: clang-reorder-fields/ReorderFieldsAction.cpp test/clang-reorder-fields/PlainCStructFieldsOrder.c Index: test/clang-reorder-fields/Plain

[PATCH] D35652: [clang] Fix handling of "%zd" format specifier in scanf

alexshap created this revision. This is a follow-up for https://reviews.llvm.org/D35427 ScanfFormatString.cpp has the same issue (incorrect handling of the specifiers for ssize_t) and this diff fixes it and adds tests. Test plan: make check-all Repository: rL LLVM https://reviews.llvm.org/D3

[PATCH] D35652: [clang] Fix handling of "%zd" format specifier in scanf

alexshap added inline comments. Comment at: test/Sema/format-strings-fixit-ssize_t.c:4 +// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -std=c99 -fsyntax-only -pedantic -Wall -Werror %t +// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -std=c99 -E -o - %t | FileCheck %s

<    1   2   3   4   >