Author: alexfh
Date: Mon Apr 8 09:29:43 2019
New Revision: 357921
URL: http://llvm.org/viewvc/llvm-project?rev=357921&view=rev
Log:
Remove a useless assertion in clang-check.
Re-commit r357915 with a fix for windows.
The assertion prevents it from applying fixes when used along with compilation
Author: alexfh
Date: Mon Apr 8 09:34:38 2019
New Revision: 357922
URL: http://llvm.org/viewvc/llvm-project?rev=357922&view=rev
Log:
Remove a bogus sed option in test.
Modified:
cfe/trunk/test/Tooling/clang-check-fixit.cpp
Modified: cfe/trunk/test/Tooling/clang-check-fixit.cpp
URL:
http://l
Author: alexfh
Date: Wed Apr 17 09:19:47 2019
New Revision: 358589
URL: http://llvm.org/viewvc/llvm-project?rev=358589&view=rev
Log:
[clang-tidy] Fix invalid location in readability-misleading-indentation
diagnostic
Before this patch readability-misleading-indentation could issue diagnostics
wit
Author: alexfh
Date: Wed Apr 17 15:35:36 2019
New Revision: 358621
URL: http://llvm.org/viewvc/llvm-project?rev=358621&view=rev
Log:
[clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros
Before the patch calling clang-tidy with -header-filter=.* -system-headers would
result in
Author: alexfh
Date: Wed Apr 17 17:36:51 2019
New Revision: 358630
URL: http://llvm.org/viewvc/llvm-project?rev=358630&view=rev
Log:
[clang-format] Remove unused Environment constructor.
Modified:
cfe/trunk/lib/Format/TokenAnalyzer.h
Modified: cfe/trunk/lib/Format/TokenAnalyzer.h
URL:
http:
It looks like this commit breaks buildbots (e.g.
http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6711).
Could you take a look?
On Mon, Sep 17, 2018 at 2:33 PM Idriss Riouak via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: idrissrio
> Date: Mon Sep 17 05:29:29 2018
>
(If there's no clear idea of how to fix this, reverting until the fix is
found is usually the best strategy.)
On Mon, Sep 17, 2018 at 3:14 PM Alexander Kornienko
wrote:
> It looks like this commit breaks buildbots (e.g.
> http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6711).
>
Ah, now I see your fix in r342389. Thanks!
On Mon, Sep 17, 2018 at 3:15 PM Alexander Kornienko
wrote:
> (If there's no clear idea of how to fix this, reverting until the fix is
> found is usually the best strategy.)
>
> On Mon, Sep 17, 2018 at 3:14 PM Alexander Kornienko
> wrote:
>
>> It looks
>
> Now on my Mac it compile and all the tests are ok.
> Should I try anything else ?
>
> Il giorno 17 set 2018, alle ore 15:14, Alexander Kornienko via cfe-commits
> ha scritto:
>
> It looks like this commit breaks buildbots (e.g.
> http://lab.llvm.org:8011/builders/clang-cma
Author: alexfh
Date: Tue Oct 2 04:38:41 2018
New Revision: 343578
URL: http://llvm.org/viewvc/llvm-project?rev=343578&view=rev
Log:
[clang-tidy] Ignore singe bit bitfield -> bool conversion in
readability-implicit-bool-conversion
Modified:
clang-tools-extra/trunk/clang-tidy/readability/Imp
Author: alexfh
Date: Thu Feb 7 02:34:43 2019
New Revision: 353382
URL: http://llvm.org/viewvc/llvm-project?rev=353382&view=rev
Log:
[clang-tidy] Expand and clarify the NOLINT documentation a bit.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/d
Author: alexfh
Date: Mon Feb 11 07:17:13 2019
New Revision: 353711
URL: http://llvm.org/viewvc/llvm-project?rev=353711&view=rev
Log:
Fixed header underline in docs.
+ Removed trailing whitespace.
Modified:
cfe/trunk/docs/analyzer/checkers.rst
Modified: cfe/trunk/docs/analyzer/checkers.rst
U
Author: alexfh
Date: Fri Feb 15 15:07:43 2019
New Revision: 354183
URL: http://llvm.org/viewvc/llvm-project?rev=354183&view=rev
Log:
clang-format with UseTab: Always sometimes doesn't insert the right amount of
tabs.
Trailing comments are not always aligned properly when UseTab is set to Always.
Author: alexfh
Date: Mon Feb 18 04:50:35 2019
New Revision: 354266
URL: http://llvm.org/viewvc/llvm-project?rev=354266&view=rev
Log:
[clang-tidy] Fix links in docs.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst
URL:
h
Author: alexfh
Date: Mon Feb 25 08:08:46 2019
New Revision: 354795
URL: http://llvm.org/viewvc/llvm-project?rev=354795&view=rev
Log:
Make static counters in ASTContext non-static.
Summary:
Fixes a data race and makes it possible to run clang-based tools in
multithreaded environment with TSan.
Re
On Fri, Sep 8, 2017 at 2:33 AM, Rafael Espindola via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rafael
> Date: Thu Sep 7 17:33:39 2017
> New Revision: 312769
>
> URL: http://llvm.org/viewvc/llvm-project?rev=312769&view=rev
> Log:
> Update for PrintHelpMessage not calling exit.
>
>
Author: alexfh
Date: Wed Sep 13 07:55:13 2017
New Revision: 313150
URL: http://llvm.org/viewvc/llvm-project?rev=313150&view=rev
Log:
[clang-tidy] fixed misc-unused-parameters omitting parameters default value
Summary:
Bug: https://bugs.llvm.org/show_bug.cgi?id=34450
**Problem:**
Clang-tidy chec
Author: alexfh
Date: Wed Sep 13 10:03:58 2017
New Revision: 313156
URL: http://llvm.org/viewvc/llvm-project?rev=313156&view=rev
Log:
Update users of llvm::sys::ExecuteAndWait etc.
Summary: Clang part of https://reviews.llvm.org/D37563
Reviewers: bkramer
Subscribers: vsk, cfe-commits
Differenti
Author: alexfh
Date: Wed Sep 13 10:45:51 2017
New Revision: 313162
URL: http://llvm.org/viewvc/llvm-project?rev=313162&view=rev
Log:
Attempt to fix MSVC build.
Modified:
cfe/trunk/lib/Driver/Job.cpp
Modified: cfe/trunk/lib/Driver/Job.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/li
Author: alexfh
Date: Fri Sep 15 04:28:28 2017
New Revision: 313355
URL: http://llvm.org/viewvc/llvm-project?rev=313355&view=rev
Log:
[clang-tidy] Fixed misc-unused-parameters omitting parameters square brackets
Summary:
Bug: https://bugs.llvm.org/show_bug.cgi?id=34449
**Problem:**
Clang-tidy ch
Author: alexfh
Date: Wed Sep 20 05:16:35 2017
New Revision: 313752
URL: http://llvm.org/viewvc/llvm-project?rev=313752&view=rev
Log:
[clang-tidy] Fix linkage-related compiler errors in clang-tidy tests
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-inefficient-algorithm.cpp
clang-
Author: alexfh
Date: Mon Jul 1 11:55:10 2019
New Revision: 364837
URL: http://llvm.org/viewvc/llvm-project?rev=364837&view=rev
Log:
Fixed two issues in clang-tidy -help.
HeaderFilter -> HeaderFilterRegex
Modified:
cfe/trunk/lib/Tooling/CommonOptionsParser.cpp
Modified: cfe/trunk/lib/Toolin
Author: alexfh
Date: Mon Jul 1 11:55:10 2019
New Revision: 364837
URL: http://llvm.org/viewvc/llvm-project?rev=364837&view=rev
Log:
Fixed two issues in clang-tidy -help.
HeaderFilter -> HeaderFilterRegex
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
clang-tools-ext
Author: alexfh
Date: Thu Dec 20 05:50:04 2018
New Revision: 349758
URL: http://llvm.org/viewvc/llvm-project?rev=349758&view=rev
Log:
[clang-tidy] Use translationUnitDecl() instead of a custom matcher.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp
cl
Author: alexfh
Date: Tue Jan 8 08:55:13 2019
New Revision: 350638
URL: http://llvm.org/viewvc/llvm-project?rev=350638&view=rev
Log:
Fix use-after-free bug in Tooling.
Summary:
`buildASTFromCodeWithArgs()` was creating a memory buffer referencing a
stack-allocated string. This diff changes the i
Author: alexfh
Date: Wed Jan 9 07:00:06 2019
New Revision: 350727
URL: http://llvm.org/viewvc/llvm-project?rev=350727&view=rev
Log:
Remove dependency-related arguments in clang-check.
This is the default behavior of clang tools, but clang-check overrides default
argument adjusters for some reaso
On Thu, Apr 12, 2018 at 7:44 AM Zinovy Nis via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: zinovy.nis
> Date: Wed Apr 11 22:41:24 2018
> New Revision: 329873
>
> URL: http://llvm.org/viewvc/llvm-project?rev=329873&view=rev
> Log:
> [clang-tidy] [modernize-use-auto] Get only a length
Author: alexfh
Date: Mon Apr 30 11:12:15 2018
New Revision: 331207
URL: http://llvm.org/viewvc/llvm-project?rev=331207&view=rev
Log:
Regenerated AST Matchers doc.
Backported a minor fix to the comment in the header.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/
Author: alexfh
Date: Thu May 3 07:40:37 2018
New Revision: 331456
URL: http://llvm.org/viewvc/llvm-project?rev=331456&view=rev
Log:
[clang-tidy] Remove AnalyzeTemporaryDtors option.
Remove the `AnalyzeTemporaryDtors` option, since the corresponding
`cfg-temporary-dtors` option of the Static Anal
Author: alexfh
Date: Thu May 3 08:59:39 2018
New Revision: 331460
URL: http://llvm.org/viewvc/llvm-project?rev=331460&view=rev
Log:
Add a trailing period in release notes.
Modified:
clang-tools-extra/trunk/clang-tidy/add_new_check.py
Modified: clang-tools-extra/trunk/clang-tidy/add_new_chec
Author: alexfh
Date: Thu May 3 09:01:49 2018
New Revision: 331461
URL: http://llvm.org/viewvc/llvm-project?rev=331461&view=rev
Log:
Added trailing periods.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/v
Author: alexfh
Date: Fri May 4 07:13:14 2018
New Revision: 331520
URL: http://llvm.org/viewvc/llvm-project?rev=331520&view=rev
Log:
Remove explicit cfg-temporary-dtors=true
Summary:
Remove explicit -analyzer-config cfg-temporary-dtors=true in analyzer tests,
since this option defaults to true si
It looks like this commit has introduced an assertion failure. See
https://bugs.llvm.org/show_bug.cgi?id=37357.
On Fri, May 4, 2018 at 10:56 PM Artem Dergachev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dergachev
> Date: Fri May 4 13:52:39 2018
> New Revision: 331556
>
> URL:
Author: alexfh
Date: Wed Jun 27 07:30:55 2018
New Revision: 335736
URL: http://llvm.org/viewvc/llvm-project?rev=335736&view=rev
Log:
[clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is
mutated within a statement.
Summary:
(Originally started as a clang-tidy check but th
Author: alexfh
Date: Wed Jun 27 07:56:12 2018
New Revision: 335740
URL: http://llvm.org/viewvc/llvm-project?rev=335740&view=rev
Log:
[analyzer] Allow registering custom statically-linked analyzer checkers
Summary:
Add an extension point to allow registration of statically-linked Clang Static
Anal
Thank you for fixing the test!
On Thu, Jun 28, 2018 at 2:23 AM Douglas Yung via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dyung
> Date: Wed Jun 27 17:19:12 2018
> New Revision: 335799
>
> URL: http://llvm.org/viewvc/llvm-project?rev=335799&view=rev
> Log:
> Fixup test to compile
Author: alexfh
Date: Thu Jun 28 05:15:17 2018
New Revision: 335845
URL: http://llvm.org/viewvc/llvm-project?rev=335845&view=rev
Log:
Fix formatting. NFC.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/ExprMutationAnalyzerTest.cpp
Modified:
clang-tools-extra/trunk/unittests/clang-tid
Author: alexfh
Date: Thu Jun 28 05:18:42 2018
New Revision: 335846
URL: http://llvm.org/viewvc/llvm-project?rev=335846&view=rev
Log:
Remove explicit type from an initializer list. NFC.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/ExprMutationAnalyzerTest.cpp
Modified:
clang-tools-
Thanks! I was going to push the same fix, but you also explained why it's
needed ;)
On Thu, Jun 28, 2018 at 3:36 PM Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Thu Jun 28 06:31:36 2018
> New Revision: 335854
>
> URL: http://llvm.org/viewvc/llvm-proje
Author: alexfh
Date: Thu Jun 28 08:21:25 2018
New Revision: 335863
URL: http://llvm.org/viewvc/llvm-project?rev=335863&view=rev
Log:
[clang-tidy] misc-unused-parameters - retain old behavior under StrictMode
Summary: This addresses https://bugs.llvm.org/show_bug.cgi?id=37467.
Reviewers: klimek,
usr/local/google/home/tra/local/clang/bin/ld.lld: error: undefined
> > symbol: clang::PCHContainerOperations::PCHContainerOperations()
> >
> >>>> referenced by new_allocator.h:136
> (/usr/lib/gcc/x86_64-linux-gnu/7.3.0/../../../../include/c++/7.3.0/ext/new_allocator.h:136)
We've started seeing assertion failures after this commit.
assert.h assertion failed at
llvm/tools/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:485 in static
clang::ento::ProgramStateRef
clang::ento::ExprEngine::elideDestructor(clang::ento::ProgramStateRef,
const clang::CXXBindTemporaryExpr *, cons
We've started seeing an assertion failure after this commit:
assert.h assertion failed at llvm/tools/clang/lib/Analysis/CFG.cpp:1266 in
void (anonymous namespace)::CFGBuilder::findConstructionContexts(const
clang::ConstructionContextLayer *, clang::Stmt *): CE->getNumArgs() == 1
The stack trace is
Author: alexfh
Date: Wed Jul 4 08:19:49 2018
New Revision: 336283
URL: http://llvm.org/viewvc/llvm-project?rev=336283&view=rev
Log:
[clang-tidy] Fix http://llvm.org/PR38055
Modified:
clang-tools-extra/trunk/clang-tidy/misc/UnusedParametersCheck.cpp
clang-tools-extra/trunk/test/clang-tidy
Filed https://bugs.llvm.org/show_bug.cgi?id=38072 with an isolated test
case.
On Wed, Jul 4, 2018 at 4:18 PM Alexander Kornienko
wrote:
> We've started seeing assertion failures after this commit.
> assert.h assertion failed at
> llvm/tools/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:485 in sta
Author: Alexander Kornienko
Date: 2020-04-13T06:19:09+02:00
New Revision: 8dda0f91995955bb8f484f8d41374aff59118355
URL:
https://github.com/llvm/llvm-project/commit/8dda0f91995955bb8f484f8d41374aff59118355
DIFF:
https://github.com/llvm/llvm-project/commit/8dda0f91995955bb8f484f8d41374aff59118355
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thank you for the cleanup! Please clang-format-diff the files before
submitting. Otherwise looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D24881
__
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Thank you for the updates!
Please re-run the check on LLVM to see what has changed.
Comment at: clang-tidy/misc/SuspiciousEnumUsageCheck.cpp:53
@@ +52,3 @@
+}
+stat
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Awesome, thanks!
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:303
@@ +302,3 @@
+if (!Loc.isMacroID())
+ break;
+Loc = SM.getImmediateExpansionRange(Loc)
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
If this kind of an error is not too frequent, it might make sense as a clang
diagnostic, indeed. Having it in clang-tidy until then doesn't hurt, though.
Comment at
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:39
@@ -38,2 +38,3 @@
// generate a non-definition FunctionDecl too. Ignore those.
- unless
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
https://reviews.llvm.org/D24893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
alexfh added inline comments.
Comment at: clang-tidy/readability/RedundantSmartptrGetCheck.cpp:64
@@ -63,3 +63,3 @@
const auto IsAKnownSmartptr = recordDecl(
anyOf(hasName("::std::unique_ptr"), hasName("::std::shared_ptr")));
BTW, this can be done usin
alexfh added a comment.
Still LG.
https://reviews.llvm.org/D24893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a reviewer: alexfh.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
https://reviews.llvm.org/D2
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D24652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-rename/RenamingAction.cpp:73
@@ -73,1 +72,3 @@
llvm::Error Err = FileToReplaces[Replace.getFilePath()].add(Replace);
+ // FIXME: As for clang-rename, replacement
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
> add_new_check.py:58
> +f.write(b'//===--- ')
> +f.write((os.path.basename(filename)).encode())
> +f.write(b' - clang-tidy')
Too many parentheses.
> add_new_check
alexfh accepted this revision.
alexfh added a comment.
LG
https://reviews.llvm.org/D25238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:331
+void UseAutoCheck::replaceExpr(const DeclStmt *D, ASTContext *Context,
+ Ty
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:39
+ bool MultiVar = false;
+ if (const auto *VD = dyn_cast(D)) {
+if (VD && VD->getPrevi
alexfh updated this revision to Diff 74160.
alexfh marked 6 inline comments as done.
alexfh added a comment.
Herald added subscribers: mgorny, beanz.
- Addressed review comments
https://reviews.llvm.org/D24572
Files:
clang-tidy/CMakeLists.txt
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyD
alexfh added a comment.
The change seems to be reasonable, and the size increase is not huge. However,
I'm not sure who should make the call.
https://reviews.llvm.org/D25429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:252-254
+ anyOf(hasType(autoType()),
+hasType(pointerType(pointee(autoType(,
+hasType(referenceType(pointee(autoType())
alexfh added inline comments.
Comment at: clang-tidy/google/NonConstReferences.cpp:73
+ [&](llvm::StringRef WhiteListType) {
+ return ReferencedType.getCanonicalType().getAsString(
+Result.Context->getPrintingP
Author: alexfh
Date: Thu Nov 23 04:08:53 2017
New Revision: 318905
URL: http://llvm.org/viewvc/llvm-project?rev=318905&view=rev
Log:
clang-tidy/rename_check.py: support for moving between modules
Modified:
clang-tools-extra/trunk/clang-tidy/rename_check.py
Modified: clang-tools-extra/trunk/c
Author: alexfh
Date: Thu Nov 23 05:49:14 2017
New Revision: 318916
URL: http://llvm.org/viewvc/llvm-project?rev=318916&view=rev
Log:
[clang-tidy] rename_check.py misc-string-constructor bugprone-string-constructor
Summary:
Rename misc-string-constructor to bugprone-string-constructor +
manually u
Author: alexfh
Date: Thu Nov 23 06:05:32 2017
New Revision: 318918
URL: http://llvm.org/viewvc/llvm-project?rev=318918&view=rev
Log:
[clang-tidy] rename_check.py: Update '=...' line in the docs.
Modified:
clang-tools-extra/trunk/clang-tidy/rename_check.py
Modified: clang-tools-extra/trun
Author: alexfh
Date: Thu Nov 23 06:59:19 2017
New Revision: 318922
URL: http://llvm.org/viewvc/llvm-project?rev=318922&view=rev
Log:
[clang-tidy] rename_check.py: fix a bug in check presence detection
Modified:
clang-tools-extra/trunk/clang-tidy/rename_check.py
Modified: clang-tools-extra/tr
Author: alexfh
Date: Thu Nov 23 09:02:48 2017
New Revision: 318926
URL: http://llvm.org/viewvc/llvm-project?rev=318926&view=rev
Log:
[clang-tidy] rename_check.py misc-argument-comment bugprone-argument-comment
Summary: + manually convert the unit test to lit test.
Reviewers: hokein
Reviewed By:
Author: alexfh
Date: Fri Nov 24 01:52:05 2017
New Revision: 318941
URL: http://llvm.org/viewvc/llvm-project?rev=318941&view=rev
Log:
[clang-tidy] rename_check.py misc-dangling-handle bugprone-dangling-handle
Reviewers: hokein
Reviewed By: hokein
Subscribers: mgorny, xazax.hun, cfe-commits
Diff
Author: alexfh
Date: Fri Nov 24 06:33:06 2017
New Revision: 318951
URL: http://llvm.org/viewvc/llvm-project?rev=318951&view=rev
Log:
[clang-tidy] rename_check.py: fix header guard handling
Modified:
clang-tools-extra/trunk/clang-tidy/rename_check.py
Modified: clang-tools-extra/trunk/clang-ti
Author: alexfh
Date: Sat Nov 25 00:49:04 2017
New Revision: 318971
URL: http://llvm.org/viewvc/llvm-project?rev=318971&view=rev
Log:
[clang-tidy] Actually fix header guard handling in scripts
Modified:
clang-tools-extra/trunk/clang-tidy/add_new_check.py
clang-tools-extra/trunk/clang-tidy/
Author: alexfh
Date: Sat Nov 25 00:52:42 2017
New Revision: 318972
URL: http://llvm.org/viewvc/llvm-project?rev=318972&view=rev
Log:
[clang-tidy] Fix link error (http://llvm.org/PR35417).
Modified:
clang-tools-extra/trunk/clang-tidy/hicpp/CMakeLists.txt
Modified: clang-tools-extra/trunk/clan
Author: alexfh
Date: Mon Nov 27 04:42:04 2017
New Revision: 319021
URL: http://llvm.org/viewvc/llvm-project?rev=319021&view=rev
Log:
[clang-tidy] readability-non-const-parameter fixes should update all
declarations
Fixes http://llvm.org/PR34410.
Modified:
clang-tools-extra/trunk/clang-tidy/
Author: alexfh
Date: Mon Nov 27 05:06:28 2017
New Revision: 319023
URL: http://llvm.org/viewvc/llvm-project?rev=319023&view=rev
Log:
[clang-tidy] Move checks from misc- to performance-
Summary:
rename_check.py misc-move-constructor-init performance-move-constructor-init
rename_check.py misc-ineff
Author: alexfh
Date: Mon Nov 27 07:17:13 2017
New Revision: 319034
URL: http://llvm.org/viewvc/llvm-project?rev=319034&view=rev
Log:
[clang-tidy] Fix link error in clang-tidy after the recent check renames.
Modified:
clang-tools-extra/trunk/clang-tidy/cert/CMakeLists.txt
Modified: clang-tool
Author: alexfh
Date: Mon Nov 27 09:59:26 2017
New Revision: 319062
URL: http://llvm.org/viewvc/llvm-project?rev=319062&view=rev
Log:
[clang-tidy] Rename qualified references to check class + support inconsistent
names
Modified:
clang-tools-extra/trunk/clang-tidy/rename_check.py
Modified: cl
Author: alexfh
Date: Tue Nov 28 08:41:03 2017
New Revision: 319183
URL: http://llvm.org/viewvc/llvm-project?rev=319183&view=rev
Log:
[clang-tidy] Move more checks from misc- to performance-
Summary:
rename_check.py misc-move-const-arg performance-move-const-arg
rename_check.py misc-noexcept-move-
Author: alexfh
Date: Wed Nov 29 09:16:09 2017
New Revision: 319325
URL: http://llvm.org/viewvc/llvm-project?rev=319325&view=rev
Log:
[clang-tidy] make readability-simplify-bool-expr completely ignore macros
Modified:
clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp
Author: alexfh
Date: Mon Dec 11 11:02:26 2017
New Revision: 320406
URL: http://llvm.org/viewvc/llvm-project?rev=320406&view=rev
Log:
[clang-tidy] Correctly classify constant arrays and constant strings as
constants when checking identifiers naming
Summary:
They are not locally const qualified so
Author: Alexander Kornienko
Date: 2022-09-13T12:18:07+02:00
New Revision: 637da9de4c6619c0e179c2c2f0dbfebd08ac2a0f
URL:
https://github.com/llvm/llvm-project/commit/637da9de4c6619c0e179c2c2f0dbfebd08ac2a0f
DIFF:
https://github.com/llvm/llvm-project/commit/637da9de4c6619c0e179c2c2f0dbfebd08ac2a0f
Author: Alexander Kornienko
Date: 2024-01-24T21:42:38+01:00
New Revision: 6e4930c67508a90bdfd756f6e45417b5253cd741
URL:
https://github.com/llvm/llvm-project/commit/6e4930c67508a90bdfd756f6e45417b5253cd741
DIFF:
https://github.com/llvm/llvm-project/commit/6e4930c67508a90bdfd756f6e45417b5253cd741
I suspect that this patch makes analysis much slower in certain cases. For
example, the clang/test/Analysis/pr37802.cpp test has become ~5 times
slower in some configurations in our environment. This happened somewhere
between r369520 and r369679, and your series of patches seems most
suspicious :)
Author: alexfh
Date: Wed Sep 4 09:19:32 2019
New Revision: 370919
URL: http://llvm.org/viewvc/llvm-project?rev=370919&view=rev
Log:
[clang-tidy] Fix bugprone-argument-comment bug if there are marcos.
Summary:
Fix bugprone-argument-comment bug if there are marcos.
For example:
```
void j(int a,
Author: alexfh
Date: Thu Sep 5 07:13:57 2019
New Revision: 371072
URL: http://llvm.org/viewvc/llvm-project?rev=371072&view=rev
Log:
[clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not
checked.
Summary:
For example:
```
void foo(int a);
foo(-2);
```
should be fixed as:
Author: alexfh
Date: Thu Sep 5 07:48:31 2019
New Revision: 371076
URL: http://llvm.org/viewvc/llvm-project?rev=371076&view=rev
Log:
[clang-tidy] Make most ArgumentCommentCheck options local, as they should be
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/ArgumentCommentCheck.cpp
Author: alexfh
Date: Thu Sep 5 07:48:23 2019
New Revision: 371075
URL: http://llvm.org/viewvc/llvm-project?rev=371075&view=rev
Log:
Add a bugprone-argument-comment option: IgnoreSingleArgument.
Summary:
Add bugprone-argument-comment option: IgnoreSingleArgument.
When true, the check will ignore
Author: alexfh
Date: Fri Jul 28 05:46:02 2017
New Revision: 309379
URL: http://llvm.org/viewvc/llvm-project?rev=309379&view=rev
Log:
[clang-tidy] readability-redundant-declaration: ignore friends and macros
Added:
clang-tools-extra/trunk/test/clang-tidy/readability-redundant-declaration-igno
Author: alexfh
Date: Fri Jul 28 05:46:08 2017
New Revision: 309380
URL: http://llvm.org/viewvc/llvm-project?rev=309380&view=rev
Log:
[clang-tidy] Expand readability-redundant-function-ptr-dereference test
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-redundant-function-ptr-de
Author: alexfh
Date: Mon Jul 31 08:21:26 2017
New Revision: 309569
URL: http://llvm.org/viewvc/llvm-project?rev=309569&view=rev
Log:
Fix -Wshadow false positives with function-local classes.
Summary:
Fixes http://llvm.org/PR33947.
https://godbolt.org/g/54XRMT
void f(int a) {
struct A {
vo
This change causes an assertion failure on valid code. Could you take a
look at fixing this?
A reduced test case:
$ cat /tmp/SemaTemplateInstantiateDecl-crash2.cpp
template
constexpr void f(T) {
f(0);
}
$ clang -fsyntax-only -std=c++11 /tmp/SemaTemplateInstantiateDecl-crash2.cpp
assert.h asser
Thank you for the analysis! It would be nice if you could implement a short
term workaround to avoid crashes. Maybe Richard has ideas on what a proper
solution should look like.
On Wed, Aug 2, 2017 at 8:05 PM, Serge Pavlov wrote:
> At first thank you for the nice test case.
>
> This crash is not
Author: alexfh
Date: Wed Aug 9 09:00:31 2017
New Revision: 310491
URL: http://llvm.org/viewvc/llvm-project?rev=310491&view=rev
Log:
[clang-tidy] Ignore newlines in checks list
This is a follow up to https://reviews.llvm.org/D30567 where I overlooked that
LLVM YAML parser doesn't support multilin
Author: alexfh
Date: Thu Aug 10 03:06:16 2017
New Revision: 310576
URL: http://llvm.org/viewvc/llvm-project?rev=310576&view=rev
Log:
[Lexer] Finding beginning of token with escaped new line
Summary:
Lexer::GetBeginningOfToken produced invalid location when
backtracking across escaped new lines.
Author: alexfh
Date: Thu Aug 10 05:19:05 2017
New Revision: 310584
URL: http://llvm.org/viewvc/llvm-project?rev=310584&view=rev
Log:
[clang-tidy] Add modernize-use-emplace.IgnoreImplicitConstructors option
Added:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-emplace-ignore-implicit-c
Author: alexfh
Date: Thu Aug 10 05:24:52 2017
New Revision: 310585
URL: http://llvm.org/viewvc/llvm-project?rev=310585&view=rev
Log:
[clang-tidy] Enable test for http://llvm.org/PR26228
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-braces-around-statements.cpp
Modified:
cla
Author: alexfh
Date: Thu Aug 10 05:38:46 2017
New Revision: 310586
URL: http://llvm.org/viewvc/llvm-project?rev=310586&view=rev
Log:
[clang-tidy] Add a test.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/ReadabilityModuleTest.cpp
Modified: clang-tools-extra/trunk/unittests/clang-tid
Author: alexfh
Date: Thu Aug 10 05:54:05 2017
New Revision: 310587
URL: http://llvm.org/viewvc/llvm-project?rev=310587&view=rev
Log:
[clang-tidy] Updated docs and release notes for r310584
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
clang-tools-extra/trunk/docs/clang-tidy/chec
Thanks for noticing this! Committed in r310587.
On Thu, Aug 10, 2017 at 2:33 PM, Haojian Wu wrote:
> I think you also need to add the doc for the option in
> modernize-use-emplace.rst.
>
> On Thu, Aug 10, 2017 at 2:19 PM, Alexander Kornienko via cfe-commits <
> cfe-commits@lis
101 - 200 of 1885 matches
Mail list logo
