[compiler-rt] [llvm] [clang] [flang] [clang-tools-extra] [mlir] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/69266 >From ded7435220d2c3527c4798d1b328a5f2940e279a Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 16 Oct 2023 22:43:55 +0100 Subject: [PATCH] Handle trying to bind a generic reference to a template parameter o

[compiler-rt] [llvm] [clang] [flang] [clang-tools-extra] [mlir] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/69266 >From ded7435220d2c3527c4798d1b328a5f2940e279a Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 16 Oct 2023 22:43:55 +0100 Subject: [PATCH 1/2] Handle trying to bind a generic reference to a template paramet

[mlir] [clang] [flang] [clang-tools-extra] [llvm] [compiler-rt] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

AlexVlx wrote: Gentle ping. https://github.com/llvm/llvm-project/pull/69266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [mlir] [flang] [clang] [compiler-rt] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/69266 >From ded7435220d2c3527c4798d1b328a5f2940e279a Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 16 Oct 2023 22:43:55 +0100 Subject: [PATCH 1/3] Handle trying to bind a generic reference to a template paramet

[clang] Add SPIRV support to HIPAMD toolchain (PR #75357)

AlexVlx wrote: > > > Is generic the best name here? I feel like that's going to be heavily > > > overloaded. I'd much prefer a new architecture that just treats "SPIR-V" > > > as a single architecture. E.g. `--offload-arch=spirv` or something. > > For HIPAMD toolchain, `--offload-arch=generic`

[clang] Add SPIRV support to HIPAMD toolchain (PR #75357)

@@ -209,6 +210,13 @@ void AMDGCN::Linker::ConstructJob(Compilation &C, const JobAction &JA, if (JA.getType() == types::TY_LLVM_BC) return constructLlvmLinkCommand(C, JA, Inputs, Output, Args); + if (Args.getLastArgValue(options::OPT_mcpu_EQ) == "generic") { +llvm::

[llvm] [compiler-rt] [flang] [clang-tools-extra] [clang] [mlir] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/69266 >From ded7435220d2c3527c4798d1b328a5f2940e279a Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 16 Oct 2023 22:43:55 +0100 Subject: [PATCH 1/3] Handle trying to bind a generic reference to a template paramet

[clang] [compiler-rt] [mlir] [llvm] [flang] [clang-tools-extra] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/69266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

@@ -0,0 +1,22 @@ +// REQUIRES: spirv-registered-target +// RUN: %clang_cc1 -triple spirv64-unknown-unknown -fcuda-is-device -emit-llvm -o - %s | FileCheck %s +struct x { AlexVlx wrote: Done. https://github.com/llvm/llvm-project/pull/85460 __

[clang] [llvm] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

@@ -0,0 +1,22 @@ +// REQUIRES: spirv-registered-target +// RUN: %clang_cc1 -triple spirv64-unknown-unknown -fcuda-is-device -emit-llvm -o - %s | FileCheck %s +struct x { + double b; + long a; +}; + +void testva(int n, ...) { + __builtin_va_list ap; + __builtin_va_start(ap, n)

[clang] [llvm] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

@@ -0,0 +1,22 @@ +// REQUIRES: spirv-registered-target AlexVlx wrote: I was not certain and erred on the side of caution. You are correct (as far as I can tell), and have removed the requirement. Thank you for pointing it out! https://github.com/llvm/llvm-proje

[clang] [llvm] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

@@ -1713,7 +1716,7 @@ def int_coro_subfn_addr : DefaultAttrsIntrinsic< ///===-- Other Intrinsics --===// // -// TODO: We should introduce a new memory kind fo traps (and other side effects +// TODO: We should introduce a new m

[clang] [llvm] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

@@ -700,10 +700,13 @@ class MSBuiltin { //===--- Variable Argument Handling Intrinsics ===// // -def int_vastart : DefaultAttrsIntrinsic<[], [llvm_ptr_ty], [], "llvm.va_start">; -def int_vacopy : DefaultAttrsIntrinsic<[], [llvm_ptr_ty, llvm_ptr_t

[clang] [llvm] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

@@ -700,10 +700,13 @@ class MSBuiltin { //===--- Variable Argument Handling Intrinsics ===// // -def int_vastart : DefaultAttrsIntrinsic<[], [llvm_ptr_ty], [], "llvm.va_start">; -def int_vacopy : DefaultAttrsIntrinsic<[], [llvm_ptr_ty, llvm_ptr_t

[clang] [llvm] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

@@ -700,10 +700,13 @@ class MSBuiltin { //===--- Variable Argument Handling Intrinsics ===// // -def int_vastart : DefaultAttrsIntrinsic<[], [llvm_ptr_ty], [], "llvm.va_start">; -def int_vacopy : DefaultAttrsIntrinsic<[], [llvm_ptr_ty, llvm_ptr_t

[clang] [llvm] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

@@ -1318,16 +1318,16 @@ define void @instructions.va_arg(i8* %v, ...) { %ap2 = bitcast i8** %ap to i8* call void @llvm.va_start(i8* %ap2) - ; CHECK: call void @llvm.va_start(ptr %ap2) + ; CHECK: call void @llvm.va_start.p0(ptr %ap2) va_arg i8* %ap2, i32 ; CHECK:

[clang] [llvm] [mlir] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

AlexVlx wrote: > CI looks unhappy, mlir also seems to need updates: > > MLIR :: Target/LLVMIR/llvmir.mlir MLIR :: mlir-cpu-runner/x86-varargs.mlir Done. https://github.com/llvm/llvm-project/pull/85460 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [llvm] [mlir] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/85460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

AlexVlx wrote: Thank you everyone for the reviews. https://github.com/llvm/llvm-project/pull/85460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [clang] [flang] [llvm] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/76955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [llvm] [lld] [clang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

https://github.com/AlexVlx approved this pull request. LGTM in general, versioning seems fine; I had a pair of very minor nits/questions, but they're not blocking concerns. Thanks! https://github.com/llvm/llvm-project/pull/76955 ___ cfe-commits mailin

[flang] [llvm] [lld] [clang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

@@ -49,6 +49,11 @@ constexpr uint32_t VersionMajorV5 = 1; /// HSA metadata minor version for code object V5. constexpr uint32_t VersionMinorV5 = 2; +/// HSA metadata major version for code object V6. +constexpr uint32_t VersionMajorV6 = 1; +/// HSA metadata minor version for c

[clang] [lld] [llvm] [flang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

@@ -139,10 +139,10 @@ bool AMDGPURemoveIncompatibleFunctions::checkFunction(Function &F) { const GCNSubtarget *ST = static_cast(TM->getSubtargetImpl(F)); - // Check the GPU isn't generic. Generic is used for testing only - // and we don't want this pass to interfere

[clang] [HIP][Driver] Automatically include `hipstdpar` forwarding header (PR #78915)

https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/78915 The forwarding header used by `hipstdpar` on AMDGPU targets is now pacakged with `rocThrust`. This change augments the ROCm Driver component so that it can automatically pick up the packaged header iff the user

[clang] [HIP][Driver] Automatically include `hipstdpar` forwarding header (PR #78915)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/78915 >From 37453ff13fd7a61f2072069cf94615497c748089 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Sun, 21 Jan 2024 21:52:52 + Subject: [PATCH 1/2] Add automated inclusion for the forwarding header packaged with

[clang] [HIP][Driver] Automatically include `hipstdpar` forwarding header (PR #78915)

https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/78915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/69266 >From ded7435220d2c3527c4798d1b328a5f2940e279a Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 16 Oct 2023 22:43:55 +0100 Subject: [PATCH] Handle trying to bind a generic reference to a template parameter o

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699 >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in t

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699 >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in t

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699 >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in t

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699 >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in t

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9a40858 - [HIP][Clang][Driver] Add Driver support for `hipstdpar`

Author: Alex Voicu Date: 2023-10-03T13:14:46+01:00 New Revision: 9a408588d1b8b7899eff593c537de539a4a12651 URL: https://github.com/llvm/llvm-project/commit/9a408588d1b8b7899eff593c537de539a4a12651 DIFF: https://github.com/llvm/llvm-project/commit/9a408588d1b8b7899eff593c537de539a4a12651.diff LO

[clang] c0f8748 - [HIP][Clang][Preprocessor] Add Preprocessor support for `hipstdpar`

Author: Alex Voicu Date: 2023-10-03T13:18:31+01:00 New Revision: c0f8748d448be69748fee73014a60ada22b41b0d URL: https://github.com/llvm/llvm-project/commit/c0f8748d448be69748fee73014a60ada22b41b0d DIFF: https://github.com/llvm/llvm-project/commit/c0f8748d448be69748fee73014a60ada22b41b0d.diff LO

[clang] 4d680f5 - [HIP][Clang][Sema] Add Sema support for `hipstdpar`

Author: Alex Voicu Date: 2023-10-03T13:29:12+01:00 New Revision: 4d680f56475ce17d8fb793655eb3d77ac8aee1b9 URL: https://github.com/llvm/llvm-project/commit/4d680f56475ce17d8fb793655eb3d77ac8aee1b9 DIFF: https://github.com/llvm/llvm-project/commit/4d680f56475ce17d8fb793655eb3d77ac8aee1b9.diff LO

[clang] 3e3cf77 - [HIP][Clang][Driver] Fix build failure introduced by https://reviews.llvm.org/rG9a408588d1b8b7899eff593c537de539a4a12651

Author: Alex Voicu Date: 2023-10-03T13:45:32+01:00 New Revision: 3e3cf77cbebab237b3f9379fc07d4b1af391f874 URL: https://github.com/llvm/llvm-project/commit/3e3cf77cbebab237b3f9379fc07d4b1af391f874 DIFF: https://github.com/llvm/llvm-project/commit/3e3cf77cbebab237b3f9379fc07d4b1af391f874.diff LO

[clang] 0701ee6 - [HIP][Clang][Driver] Disable `hipstdpar` driver test on Mac & Windows, since `hipstdpar` is Linux only at the moment.

Author: Alex Voicu Date: 2023-10-03T17:26:15+01:00 New Revision: 0701ee69f7ac82b49a9709e610227ebf387f1d30 URL: https://github.com/llvm/llvm-project/commit/0701ee69f7ac82b49a9709e610227ebf387f1d30 DIFF: https://github.com/llvm/llvm-project/commit/0701ee69f7ac82b49a9709e610227ebf387f1d30.diff LO

[clang] 3cbdd9f - [HIP][Clang][Driver] Disable `hipstdpar` driver test on Hexagon & PS5, since `hipstdpar` is not going to be available on either of them.

Author: Alex Voicu Date: 2023-10-03T19:06:56+01:00 New Revision: 3cbdd9f1e3b40761e5d5db428d66e71591444f18 URL: https://github.com/llvm/llvm-project/commit/3cbdd9f1e3b40761e5d5db428d66e71591444f18 DIFF: https://github.com/llvm/llvm-project/commit/3cbdd9f1e3b40761e5d5db428d66e71591444f18.diff LO

[clang] dce54ea - [HIP][Clang][Driver] Disable `hipstdpar` driver test on SCEI to unblock build bot, pending test refactor.

Author: Alex Voicu Date: 2023-10-03T22:17:12+01:00 New Revision: dce54eae46685116ca0fe60f1dcabced2d0d297e URL: https://github.com/llvm/llvm-project/commit/dce54eae46685116ca0fe60f1dcabced2d0d297e DIFF: https://github.com/llvm/llvm-project/commit/dce54eae46685116ca0fe60f1dcabced2d0d297e.diff LO

[clang] 1cfaa86 - [HIP][Clang][Driver] Disable `hipstdpar` driver test on SIE to unblock build bot, pending test refactor.

Author: Alex Voicu Date: 2023-10-03T23:00:13+01:00 New Revision: 1cfaa863bc36d25625114b432e2ddf35d2302452 URL: https://github.com/llvm/llvm-project/commit/1cfaa863bc36d25625114b432e2ddf35d2302452 DIFF: https://github.com/llvm/llvm-project/commit/1cfaa863bc36d25625114b432e2ddf35d2302452.diff LO

[clang] 9f406e4 - [HIP][Clang][Driver] Correctly specify test requirements as Linux + x86 + AMDGPU; temporarily retain targeted XFAILs for Hexagon & PS.

Author: Alex Voicu Date: 2023-10-04T12:04:13+01:00 New Revision: 9f406e450b6dfebe41be54cc7a7a6861b8eaf618 URL: https://github.com/llvm/llvm-project/commit/9f406e450b6dfebe41be54cc7a7a6861b8eaf618 DIFF: https://github.com/llvm/llvm-project/commit/9f406e450b6dfebe41be54cc7a7a6861b8eaf618.diff LO

[clang] 8acdcf4 - [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

Author: Alex Voicu Date: 2023-07-19T18:04:31+01:00 New Revision: 8acdcf4016876d122733991561be706b64026e73 URL: https://github.com/llvm/llvm-project/commit/8acdcf4016876d122733991561be706b64026e73 DIFF: https://github.com/llvm/llvm-project/commit/8acdcf4016876d122733991561be706b64026e73.diff LO

[clang] f385abf - [Clang][CodeGen] Follow-up for `vtable`, `typeinfo` et al. are globals

Author: Alex Voicu Date: 2023-07-19T23:57:12+01:00 New Revision: f385abf131e01b12b14ac3bc7214eb119b40523e URL: https://github.com/llvm/llvm-project/commit/f385abf131e01b12b14ac3bc7214eb119b40523e DIFF: https://github.com/llvm/llvm-project/commit/f385abf131e01b12b14ac3bc7214eb119b40523e.diff LO

[clang] Handle template parameter objects with explicit address spaces (PR #69266)

https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/69266 For certain cases (e.g. when their address is observable at run time) it is necessary to provide physical backing for non-type template parameter objects. Said backing comes in the form of a global variable. For

[clang] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/69266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dd5d65a - [HIP][Clang][CodeGen] Add CodeGen support for `hipstdpar`

Author: Alex Voicu Date: 2023-10-17T11:41:36+01:00 New Revision: dd5d65adb6413122a5ba1ed04c5c2c0b4951b76c URL: https://github.com/llvm/llvm-project/commit/dd5d65adb6413122a5ba1ed04c5c2c0b4951b76c DIFF: https://github.com/llvm/llvm-project/commit/dd5d65adb6413122a5ba1ed04c5c2c0b4951b76c.diff LO

[clang] 791b890 - [HIP][Clang][CodeGen] Simplify test for `hipstdpar`

Author: Alex Voicu Date: 2023-10-17T15:42:28+01:00 New Revision: 791b890c468e5784113507f1f2fe7fed694c3962 URL: https://github.com/llvm/llvm-project/commit/791b890c468e5784113507f1f2fe7fed694c3962 DIFF: https://github.com/llvm/llvm-project/commit/791b890c468e5784113507f1f2fe7fed694c3962.diff LO

[clang] 51a014c - [Clang][CodeGen] `__builtin_alloca`s should care about address spaces

Author: Alex Voicu Date: 2023-08-01T21:55:36+01:00 New Revision: 51a014cb2d9c6f8303f9b11ffc035d69cbeb9e21 URL: https://github.com/llvm/llvm-project/commit/51a014cb2d9c6f8303f9b11ffc035d69cbeb9e21 DIFF: https://github.com/llvm/llvm-project/commit/51a014cb2d9c6f8303f9b11ffc035d69cbeb9e21.diff LO

[clang] 7240008 - [Clang][CodeGen] `__dynamic_cast` should care about `type_info`'s address space

Author: Alex Voicu Date: 2023-08-03T23:25:06+01:00 New Revision: 7240008c0afa3e2d12f3f51cfe0235668feb6ef3 URL: https://github.com/llvm/llvm-project/commit/7240008c0afa3e2d12f3f51cfe0235668feb6ef3 DIFF: https://github.com/llvm/llvm-project/commit/7240008c0afa3e2d12f3f51cfe0235668feb6ef3.diff LO

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/65699: This change is symmetric with the one reviewed in and handles the exception handling specific intrinsic, which slipped through the cracks, in the same way, by inserting an ad

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx review_requested https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx labeled https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx review_requested https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx review_requested https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx review_requested https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699: >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in the

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

@@ -1149,7 +1149,10 @@ static void emitCatchDispatchBlock(CodeGenFunction &CGF, assert(handler.Type.Flags == 0 && "landingpads do not support catch handler flags"); assert(typeValue && "fell into catch-all case!"); -typeValue = CGF.Builder.CreateBitCast(t

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699: >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx resolved https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699: >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx resolved https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx resolved https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9c760ca - [Clang][CodeGen] `typeid` needs special care when `type_info` is not in the default AS

Author: Alex Voicu Date: 2023-08-28T20:44:06+01:00 New Revision: 9c760ca8ecfd570212b47a5e980d38575b879029 URL: https://github.com/llvm/llvm-project/commit/9c760ca8ecfd570212b47a5e980d38575b879029 DIFF: https://github.com/llvm/llvm-project/commit/9c760ca8ecfd570212b47a5e980d38575b879029.diff LO

[clang] 29663e2 - [clang][CodeGen] Account for VTT address space

Author: Alex Voicu Date: 2023-06-05T03:06:25+01:00 New Revision: 29663e2b8c4edcd850a4245b1f9509f974220906 URL: https://github.com/llvm/llvm-project/commit/29663e2b8c4edcd850a4245b1f9509f974220906 DIFF: https://github.com/llvm/llvm-project/commit/29663e2b8c4edcd850a4245b1f9509f974220906.diff LO

[clang] [llvm] [clang][CodeGen][AMDGPU] Enable AMDGPU `printf` for `spirv64-amd-amdhsa` (PR #97132)

@@ -5888,12 +5888,16 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__builtin_printf: case Builtin::BIprintf: if (getTarget().getTriple().isNVPTX() || -getTarget().getTriple().isAMDGCN()) { +getTarget

[clang] [llvm] [clang][CodeGen][AMDGPU] Enable AMDGPU `printf` for `spirv64-amd-amdhsa` (PR #97132)

https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/97132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][CodeGen][AMDGPU] Enable AMDGPU `printf` for `spirv64-amd-amdhsa` (PR #97132)

AlexVlx wrote: > LLVM Buildbot has detected a new failure on builder `sanitizer-ppc64le-linux` > running on `ppc64le-sanitizer` while building `clang,llvm` at step 2 > "annotate". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/72/builds/839 > > Here is the rele

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

@@ -335,6 +335,9 @@ class LLVM_LIBRARY_VISIBILITY SPIRV32TargetInfo : public BaseSPIRVTargetInfo { PointerWidth = PointerAlign = 32; SizeType = TargetInfo::UnsignedInt; PtrDiffType = IntPtrType = TargetInfo::SignedInt; +// SPIR-V has core support for atomic ops

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

@@ -766,8 +766,17 @@ static void EmitAtomicOp(CodeGenFunction &CGF, AtomicExpr *Expr, Address Dest, // LLVM atomic instructions always have synch scope. If clang atomic // expression has no scope operand, use default LLVM synch scope. if (!ScopeModel) { +llvm::SyncSc

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

@@ -188,6 +192,41 @@ void SPIRVTargetCodeGenInfo::setCUDAKernelCallingConvention( } } +llvm::SyncScope::ID +SPIRVTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &, SyncScope Scope, + llvm::AtomicOrdering, +

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

@@ -188,6 +192,41 @@ void SPIRVTargetCodeGenInfo::setCUDAKernelCallingConvention( } } +llvm::SyncScope::ID +SPIRVTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &, SyncScope Scope, + llvm::AtomicOrdering, +

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

@@ -766,8 +766,17 @@ static void EmitAtomicOp(CodeGenFunction &CGF, AtomicExpr *Expr, Address Dest, // LLVM atomic instructions always have synch scope. If clang atomic // expression has no scope operand, use default LLVM synch scope. if (!ScopeModel) { +llvm::SyncSc

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

AlexVlx wrote: > Thank you for the PR! I'd like to better understand motivation and > justification of SPIR-V BE-related changes though. The goal would be to > understand whether AllSvmDevices is indeed a better choice (for whom?) than > Device as a default mem scope value in SPIR-V BE. > > 1

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/102776 The AMDGPU kernel ABI is not directly representable in SPIR-V, since it relies on passing aggregates `byref`, and SPIR-V only encodes `byval` (which the AMDGPU BE disallows for kernel arguments). As a temporary

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

https://github.com/AlexVlx ready_for_review https://github.com/llvm/llvm-project/pull/102776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/102776 >From d41faf6da8a9eed8c32f6a62fa9ebf38d5824c2c Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Sun, 11 Aug 2024 01:39:46 +0300 Subject: [PATCH 1/2] Tweak AMDGCNSPIRV ABI to allow for the correct handling of agg

[clang] [Clang] Add `__CLANG_GPU_DISABLE_MATH_WRAPPERS` macro for offloading math (PR #98234)

https://github.com/AlexVlx approved this pull request. https://github.com/llvm/llvm-project/pull/98234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

https://github.com/AlexVlx commented: > > but empirically robust and guaranteed to work as the AMDGPU BE retains > > handling of direct passing for legacy reasons. I would like to get rid of that someday... I share the sentiment, but as far as I can see this is one of those things that has b

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/102776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/102776 >From d41faf6da8a9eed8c32f6a62fa9ebf38d5824c2c Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Sun, 11 Aug 2024 01:39:46 +0300 Subject: [PATCH 1/2] Tweak AMDGCNSPIRV ABI to allow for the correct handling of agg

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/88182 At the moment, Clang is rather liberal in assuming that 0 (and by extension unqualified) is always a safe default. This does not work for targets that actually use a different value for the default / generic AS

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/88182 >From 426e74cabb003eb5dc83adf347a5800d49bc87b7 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 18 Mar 2024 11:49:12 + Subject: [PATCH 1/5] Start migrating away from the embedded assumption that the defa

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/88182 >From 426e74cabb003eb5dc83adf347a5800d49bc87b7 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 18 Mar 2024 11:49:12 + Subject: [PATCH 1/6] Start migrating away from the embedded assumption that the defa

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx commented: > Why can't we just declare that the "generic" address-space must always be 0? > The specific numbers we use for address-spaces are completely arbitrary > anyway. If we were to do this, some targets would need to change to accomodate it; it would also p

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/88182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx commented: > It's very uncommon for LLVM to need to come up with an address space on its > own, as opposed to just propagating the original address space of some memory > / operation as chosen by the frontend. LLVM occasionally creates new storage > allocations, but

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/88182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/88182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx commented: > > querying a modules global AS from the target, rather than from the data > > layout (some DL's are incomplete, e.g. SPIRV's) That is a bug in those DataLayouts Do we spell out the requirement somewhere? I am only asking because, for example, [neither

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

AlexVlx wrote: > > I'm not quite sure how to parse this comment, could you explain what you > > have in mind here? The problem is precisely that the FE assumes 0 is fine / > > picks it by default, which ends up into dangerzones when e.g. a target > > happened to use 0 to point to private (stac

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

AlexVlx wrote: > > I'm not quite sure how to parse this comment, could you explain what you > > have in mind here? The problem is precisely that the FE assumes 0 is fine / > > picks it by default, which ends up into dangerzones when e.g. a target > > happened to use 0 to point to private (stac

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/88182 >From 426e74cabb003eb5dc83adf347a5800d49bc87b7 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 18 Mar 2024 11:49:12 + Subject: [PATCH 1/7] Start migrating away from the embedded assumption that the defa

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

@@ -4551,6 +4554,7 @@ llvm::Constant *CodeGenModule::GetOrCreateLLVMFunction( llvm::Function *F = llvm::Function::Create(FTy, llvm::Function::ExternalLinkage, + getDataLayout().getProgramAddressSpace(), AlexVlx wrote: Whoop

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

@@ -2216,7 +2216,7 @@ static llvm::Value *EmitTypeidFromVTable(CodeGenFunction &CGF, const Expr *E, } llvm::Value *CodeGenFunction::EmitCXXTypeidExpr(const CXXTypeidExpr *E) { - llvm::Type *PtrTy = llvm::PointerType::getUnqual(getLLVMContext()); + llvm::Type *PtrTy = Int8Pt

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

@@ -3581,8 +3582,10 @@ ConstantAddress CodeGenModule::GetAddrOfTemplateParamObject( isExternallyVisible(TPO->getLinkageAndVisibility().getLinkage()) ? llvm::GlobalValue::LinkOnceODRLinkage : llvm::GlobalValue::InternalLinkage; - auto *GV = new llvm::

[clang] [clang][CodeGen] Add AS for Globals to SPIR & SPIRV datalayouts (PR #88455)

https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/88455 Currently neither the SPIR nor the SPIRV targets specify the AS for globals in their datalayout strings. This is problematic because CodeGen/LLVM will default to AS0 in this case, which produces Globals that end

[clang] [clang][CodeGen] Add AS for Globals to SPIR & SPIRV datalayouts (PR #88455)

AlexVlx wrote: > The change seems reasonable. > > > CodeGen/LLVM will default to AS0 in this case, which produces Globals that > > end up in the private address space for e.g. OCL, HIPSPV or SYCL. > > Can we add a test checking LLVM address space for globals emitted from > OCL/HIPSPV/SYCL, pl

[clang] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

@@ -3581,8 +3582,10 @@ ConstantAddress CodeGenModule::GetAddrOfTemplateParamObject( isExternallyVisible(TPO->getLinkageAndVisibility().getLinkage()) ? llvm::GlobalValue::LinkOnceODRLinkage : llvm::GlobalValue::InternalLinkage; - auto *GV = new llvm::

[clang] [clang][CodeGen] Add AS for Globals to SPIR & SPIRV datalayouts (PR #88455)

AlexVlx wrote: > Thanks @AlexVlx for this change. This should work fine for > SPIRV-LLVM-Translator (and SPIR-V backend). Adding @michalpaszkowski for > input from SPIR-V backend side. Recently, this restriction on LLVM IR input > to our translator was docuemnted: > https://github.com/Khronos

  1   2   3   4   5   6   7   >