[PATCH] D26278: Avoid -Wshadow warnings for shadowed variables that aren't captured by lambdas with an explicit capture list

arphaman created this revision. arphaman added reviewers: rsmith, rnk. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch avoids the -Wshadow warning for variables which shadow variables that aren't captured by lambdas with an explicit c

[PATCH] D21126: Fix crash when rewriting call to match placeholder

arphaman added a comment. This has already been fixed in r276352. I closed PR25961. https://reviews.llvm.org/D21126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22770: [Sema, NFC] Reset HasFallthroughStmt when clearing FunctionScopeInfo

arphaman accepted this revision. arphaman added a reviewer: arphaman. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks. https://reviews.llvm.org/D22770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D22770: [Sema, NFC] Reset HasFallthroughStmt when clearing FunctionScopeInfo

arphaman added a comment. I looked at the way `HasFallthroughStmt` is used, and it didn't seem so, no. It's used in the following manner in AnalysisBasedWarnings.cpp: bool FallThroughDiagFull = !Diags.isIgnored(diag::warn_unannotated_fallthrough, D->getLocStart()); bool FallThroughDiag

r286121 - [www] Update the link to the 'include what you use' project

Author: arphaman Date: Mon Nov 7 10:56:19 2016 New Revision: 286121 URL: http://llvm.org/viewvc/llvm-project?rev=286121&view=rev Log: [www] Update the link to the 'include what you use' project Modified: cfe/trunk/www/related.html Modified: cfe/trunk/www/related.html URL: http://llvm.org/v

[PATCH] D26278: Avoid -Wshadow warnings for shadowed variables that aren't captured by lambdas with an explicit capture list

arphaman updated this revision to Diff 77201. arphaman added a comment. The updated patch preserves the old behaviour in `-Wshadow-all` Repository: rL LLVM https://reviews.llvm.org/D26278 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaCXX/warn-shadow-i

[PATCH] D26278: Avoid -Wshadow warnings for shadowed variables that aren't captured by lambdas with an explicit capture list

arphaman updated this revision to Diff 77205. arphaman marked 2 inline comments as done. arphaman added a comment. The updated patch introduces a new warning group named `-Wshadow-uncaptured-local` that was suggested by Reid. Repository: rL LLVM https://reviews.llvm.org/D26278 Files: incl

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

arphaman added a comment. I'm not sure that it's required, but shouldn't we have also have a test that checks for the usage of this flag as well? Adding a test case with `#pragma clang diagnostic ignored "-Wduplicate-protocol"` and some code to a file like "test/SemaObjC/check-dup-objc-decls-1.

[PATCH] D26435: Use unique_ptr for cached tokens for default arguments in C++.

arphaman added inline comments. Comment at: include/clang/Sema/DeclSpec.h:1313 void freeParams() { for (unsigned I = 0; I < NumParams; ++I) { +Params[I].DefaultArgTokens.release(); You can elide the curly braces here now that the loop has just

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

arphaman accepted this revision. arphaman added a reviewer: arphaman. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

r286354 - [Sema] Avoid -Wshadow warnings for shadowed variables that aren't captured

Author: arphaman Date: Wed Nov 9 04:38:57 2016 New Revision: 286354 URL: http://llvm.org/viewvc/llvm-project?rev=286354&view=rev Log: [Sema] Avoid -Wshadow warnings for shadowed variables that aren't captured by lambdas with an explicit capture list This commit avoids the -Wshadow warning for va

[PATCH] D26278: Avoid -Wshadow warnings for shadowed variables that aren't captured by lambdas with an explicit capture list

This revision was automatically updated to reflect the committed changes. Closed by commit rL286354: [Sema] Avoid -Wshadow warnings for shadowed variables that aren't captured (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26278?vs=77205&id=77328#toc Repository: r

[PATCH] D26448: Avoid -Wshadow warnings for shadowed variables that aren't captured by lambdas with a default capture specifier

arphaman created this revision. arphaman added reviewers: rnk, rsmith. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This is a follow-up patch to r286354. This patch avoids the -Wshadow warning for variables which shadow variables that aren't

[PATCH] D26071: [CodeCompletion] Show block invocation result for block property setters

This revision was automatically updated to reflect the committed changes. Closed by commit rL286363: [CodeCompletion] Show block invocation results for block property setters (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26071?vs=76178&id=77337#toc Repository: rL

r286363 - [CodeCompletion] Show block invocation results for block property setters

Author: arphaman Date: Wed Nov 9 07:43:18 2016 New Revision: 286363 URL: http://llvm.org/viewvc/llvm-project?rev=286363&view=rev Log: [CodeCompletion] Show block invocation results for block property setters This commit changes the code completion results for block property setters: The default

r286365 - [AST] Dump dependent scope member expression with its member name

Author: arphaman Date: Wed Nov 9 08:02:18 2016 New Revision: 286365 URL: http://llvm.org/viewvc/llvm-project?rev=286365&view=rev Log: [AST] Dump dependent scope member expression with its member name Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/test/Misc/ast-dump-stmt.cpp Modifie

[PATCH] D16533: Bug 20796 - GCC's -Wstrict-prototypes warning not implemented in Clang

arphaman added reviewers: rsmith, bruno. arphaman set the repository for this revision to rL LLVM. arphaman updated this revision to Diff 77351. arphaman added a comment. I rebased the patch, adjusted the test and added a test case for Objective-C blocks. Repository: rL LLVM https://reviews.

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

arphaman added a comment. In https://reviews.llvm.org/D26406#590741, @kastiglione wrote: > Thanks @arphaman, are you able to commit this? Yes, I can commit this for you. Let me know what commit message I should use. https://reviews.llvm.org/D26406 __

[PATCH] D26503: [Parser][ObjC] Improve diagnostics and recovery when C++ keywords are used as identifiers in Objective-C++

arphaman created this revision. arphaman added reviewers: manmanren, bruno. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch improves the 'expected identifier' errors that are presented when a C++ keyword is used as an identifier in Ob

[PATCH] D26448: Avoid -Wshadow warnings for shadowed variables that aren't captured by lambdas with a default capture specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL286465: [Sema] Avoid -Wshadow warnings for shadowed variables that (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26448?vs=77335&id=77492#toc Repository: rL LLVM https://

r286465 - [Sema] Avoid -Wshadow warnings for shadowed variables that

Author: arphaman Date: Thu Nov 10 10:19:11 2016 New Revision: 286465 URL: http://llvm.org/viewvc/llvm-project?rev=286465&view=rev Log: [Sema] Avoid -Wshadow warnings for shadowed variables that aren't captured by lambdas with a default capture specifier This commit is a follow-up to r286354. It a

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

arphaman added a comment. It seems sufficient enough, I will commit it with the summary. Thanks! https://reviews.llvm.org/D26406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r286487 - Add -Wduplicate-protocol for existing diagnostic

Author: arphaman Date: Thu Nov 10 12:30:26 2016 New Revision: 286487 URL: http://llvm.org/viewvc/llvm-project?rev=286487&view=rev Log: Add -Wduplicate-protocol for existing diagnostic Expose a warning flag for warn_duplicate_protocol_def. This allows control over the severity of duplicate protoco

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rL286487: Add -Wduplicate-protocol for existing diagnostic (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26406?vs=77232&id=77514#toc Repository: rL LLVM https://reviews.ll

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

arphaman added inline comments. Comment at: clang/test/CodeGen/block-with-perdefinedexpr.cpp:66 +}; + } +}; I think you should maybe add/change one of the tests to be a block inside of a lambda. https://reviews.llvm.org/D26522 _

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

arphaman added inline comments. Comment at: clang/lib/AST/Expr.cpp:531 +llvm::raw_svector_ostream Out(Buffer); +if (auto *DCFunc = dyn_cast(DC)) { + Out << ComputeName(IT, DCFunc); I think it's possible to avoid the braces by simplifying down to some

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks https://reviews.llvm.org/D26522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[clang] 116c1be - [clang][macho] add clang frontend support for emitting macho files with two build version load commands

Author: Alex Lorenz Date: 2022-02-02T08:30:39-08:00 New Revision: 116c1bea65ac268bc46a2373220c81d02fc0a256 URL: https://github.com/llvm/llvm-project/commit/116c1bea65ac268bc46a2373220c81d02fc0a256 DIFF: https://github.com/llvm/llvm-project/commit/116c1bea65ac268bc46a2373220c81d02fc0a256.diff L

[clang] 979d0ee - [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token

Author: Alex Lorenz Date: 2022-02-02T11:16:11-08:00 New Revision: 979d0ee8ab30a175220af3b39a6df7d56de9d2c8 URL: https://github.com/llvm/llvm-project/commit/979d0ee8ab30a175220af3b39a6df7d56de9d2c8 DIFF: https://github.com/llvm/llvm-project/commit/979d0ee8ab30a175220af3b39a6df7d56de9d2c8.diff L

[clang] 6cc6204 - [clang][driver] Use the provided arch name for a Darwin target triple

Author: Alex Lorenz Date: 2021-04-26T11:31:50-07:00 New Revision: 6cc62043c8bf4daa27664a2e1674abbe8d0492c6 URL: https://github.com/llvm/llvm-project/commit/6cc62043c8bf4daa27664a2e1674abbe8d0492c6 DIFF: https://github.com/llvm/llvm-project/commit/6cc62043c8bf4daa27664a2e1674abbe8d0492c6.diff L

[clang] ab0df6c - Revert "[clang][driver] Use the provided arch name for a Darwin target triple"

Author: Alex Lorenz Date: 2021-04-26T14:57:00-07:00 New Revision: ab0df6c0346e515291a381467527621ab0ccf953 URL: https://github.com/llvm/llvm-project/commit/ab0df6c0346e515291a381467527621ab0ccf953 DIFF: https://github.com/llvm/llvm-project/commit/ab0df6c0346e515291a381467527621ab0ccf953.diff L

[clang] 2509f9f - [clang] Don't crash when loading invalid VFS for the module dep collector

Author: Alex Lorenz Date: 2021-04-26T17:05:22-07:00 New Revision: 2509f9fbad0d37e3e5fea934c0ae7af3877ba4ae URL: https://github.com/llvm/llvm-project/commit/2509f9fbad0d37e3e5fea934c0ae7af3877ba4ae DIFF: https://github.com/llvm/llvm-project/commit/2509f9fbad0d37e3e5fea934c0ae7af3877ba4ae.diff L

[clang] 6b938d2 - Recommit "[clang][driver] Use the provided arch name for a Darwin target triple

Author: Alex Lorenz Date: 2021-04-29T15:00:40-07:00 New Revision: 6b938d2ead2cb0465436496c0171c7d750e11773 URL: https://github.com/llvm/llvm-project/commit/6b938d2ead2cb0465436496c0171c7d750e11773 DIFF: https://github.com/llvm/llvm-project/commit/6b938d2ead2cb0465436496c0171c7d750e11773.diff L

[clang] 8fc5f07 - [clang][driver][darwin] use the deployment target version as the SDK version

Author: Alex Lorenz Date: 2021-04-30T18:54:02-07:00 New Revision: 8fc5f07fc0aee95ff9f79e91035d115690177dc1 URL: https://github.com/llvm/llvm-project/commit/8fc5f07fc0aee95ff9f79e91035d115690177dc1 DIFF: https://github.com/llvm/llvm-project/commit/8fc5f07fc0aee95ff9f79e91035d115690177dc1.diff L

[clang] 2669aba - [clang][CodeGen] Use llvm::stable_sort for multi version resolver options

Author: Alex Lorenz Date: 2021-05-03T20:07:00-07:00 New Revision: 2669abaecfc47d4d2436559ab8c1fb49ad6e35c3 URL: https://github.com/llvm/llvm-project/commit/2669abaecfc47d4d2436559ab8c1fb49ad6e35c3 DIFF: https://github.com/llvm/llvm-project/commit/2669abaecfc47d4d2436559ab8c1fb49ad6e35c3.diff L

[clang] 809c6a5 - [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

Author: Egor Zhdan Date: 2022-01-05T17:00:03-08:00 New Revision: 809c6a5a1d2f4366ab0e602c9d963b73f380b74e URL: https://github.com/llvm/llvm-project/commit/809c6a5a1d2f4366ab0e602c9d963b73f380b74e DIFF: https://github.com/llvm/llvm-project/commit/809c6a5a1d2f4366ab0e602c9d963b73f380b74e.diff LO

[clang] d672d52 - Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

Author: Alex Lorenz Date: 2021-03-17T17:27:41-07:00 New Revision: d672d5219a72d2e13dcc257116876d41955e36b2 URL: https://github.com/llvm/llvm-project/commit/d672d5219a72d2e13dcc257116876d41955e36b2 DIFF: https://github.com/llvm/llvm-project/commit/d672d5219a72d2e13dcc257116876d41955e36b2.diff L

[clang] c1554f3 - [clang][FileManager] Support empty file name in getVirtualFileRef for serialized diagnostics

Author: Alex Lorenz Date: 2021-04-14T11:29:25-07:00 New Revision: c1554f32e3b3fafab64698fdb5b806b1bda4aa8a URL: https://github.com/llvm/llvm-project/commit/c1554f32e3b3fafab64698fdb5b806b1bda4aa8a DIFF: https://github.com/llvm/llvm-project/commit/c1554f32e3b3fafab64698fdb5b806b1bda4aa8a.diff L

<    2   3   4   5   6   7