Author: amccarth
Date: Mon Jan 8 08:33:42 2018
New Revision: 322005
URL: http://llvm.org/viewvc/llvm-project?rev=322005&view=rev
Log:
Emit Function IDs table for Control Flow Guard
Adds option /guard:cf to clang-cl and -cfguard to cc1 to emit function IDs
of functions that have their address tak
Author: amccarth
Date: Mon Jan 8 09:12:01 2018
New Revision: 322008
URL: http://llvm.org/viewvc/llvm-project?rev=322008&view=rev
Log:
Revert "Emit Function IDs table for Control Flow Guard"
The new test fails on the Hexagon bot. Reverting while I investigate.
This reverts https://reviews.llvm.
Author: amccarth
Date: Tue Jan 9 15:49:30 2018
New Revision: 322136
URL: http://llvm.org/viewvc/llvm-project?rev=322136&view=rev
Log:
Reland "Emit Function IDs table for Control Flow Guard"
Adds option /guard:cf to clang-cl and -cfguard to cc1 to emit function IDs
of functions that have their ad
Author: amccarth
Date: Wed Sep 13 13:53:55 2017
New Revision: 313192
URL: http://llvm.org/viewvc/llvm-project?rev=313192&view=rev
Log:
Mark static member functions as static in CodeViewDebug
Summary:
To improve CodeView quality for static member functions, we need to make the
static explicit. In
Author: Adrian McCarthy
Date: 2020-07-17T09:43:06-07:00
New Revision: 14dde438d69c81ab4651157a94d32ee804ff
URL:
https://github.com/llvm/llvm-project/commit/14dde438d69c81ab4651157a94d32ee804ff
DIFF:
https://github.com/llvm/llvm-project/commit/14dde438d69c81ab4651157a94d32ee804ff.dif
I completed the bisect, and it is indeed the change in spacing between the
`>`s that triggers the problem with the visualizers.
That said, I'm still suspicious that the std::map visualizer isn't quite
right with how it uses the wild cards and the template parameter
placeholder(s), but I don't thin
Author: Adrian McCarthy
Date: 2020-05-13T14:20:18-07:00
New Revision: a549c0d00486bf01cb485e343d778fe4a3649a43
URL:
https://github.com/llvm/llvm-project/commit/a549c0d00486bf01cb485e343d778fe4a3649a43
DIFF:
https://github.com/llvm/llvm-project/commit/a549c0d00486bf01cb485e343d778fe4a3649a43.dif
If I had to guess, my money would be on a deadlock. To unblock, I'd
propose reverting this patch until we can figure it out.
During the review, a deadlock was fixed related to the watcher thread, but
perhaps we missed one for the notifier thread.
On Tue, Oct 13, 2020 at 8:40 AM Hans Wennborg via
I didn't design VFS. I just fixed a bunch of portability bugs that
prevented us from running most of the VFS tests on Windows. If I were
designing it, I (hope) I wouldn't have done it this way. But the horse is
already out of the barn.
Here's my background with VFS (and, specifically, the redi
BTW, I hope I didn't come across as overly negative in my previous
response. I'd love to see the situation improved. I just don't know what
that would look like.
> One thing I see, but wasn't obvious from your description, is that the
mixed/hybrid separator behaviour only happens for `defined(_W
Author: Adrian McCarthy
Date: 2019-11-14T08:48:47-08:00
New Revision: 1275ab1620b665eb06231ce3c4e5068c97d9b618
URL:
https://github.com/llvm/llvm-project/commit/1275ab1620b665eb06231ce3c4e5068c97d9b618
DIFF:
https://github.com/llvm/llvm-project/commit/1275ab1620b665eb06231ce3c4e5068c97d9b618.dif
Author: Adrian McCarthy
Date: 2019-12-18T11:38:04-08:00
New Revision: 9d38fd8d0be3074af036e9e3e36489f5b854faf4
URL:
https://github.com/llvm/llvm-project/commit/9d38fd8d0be3074af036e9e3e36489f5b854faf4
DIFF:
https://github.com/llvm/llvm-project/commit/9d38fd8d0be3074af036e9e3e36489f5b854faf4.dif
Author: Adrian McCarthy
Date: 2019-12-18T11:38:04-08:00
New Revision: 738b5c9639b4323f75b03e21494bef13d9adfa86
URL:
https://github.com/llvm/llvm-project/commit/738b5c9639b4323f75b03e21494bef13d9adfa86
DIFF:
https://github.com/llvm/llvm-project/commit/738b5c9639b4323f75b03e21494bef13d9adfa86.dif
Author: Adrian McCarthy
Date: 2020-02-05T11:38:20-08:00
New Revision: da45bd232165eab5d6ec4f1f4f18db8644289142
URL:
https://github.com/llvm/llvm-project/commit/da45bd232165eab5d6ec4f1f4f18db8644289142
DIFF:
https://github.com/llvm/llvm-project/commit/da45bd232165eab5d6ec4f1f4f18db8644289142.dif
amccarth updated this revision to Diff 68114.
amccarth added a comment.
Added a test.
https://reviews.llvm.org/D23462
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGenCXX/debug-info-dllimport-base-class.cpp
Index: test/CodeGenCXX/debug-info-dllimport-base-class.cpp
==
amccarth added a comment.
Thank, dblaikie, for correcting my terminology.
https://reviews.llvm.org/D23462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amccarth updated this revision to Diff 68225.
amccarth added a comment.
Add comment as requested.
https://reviews.llvm.org/D23462
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGenCXX/debug-info-dllimport-base-class.cpp
Index: test/CodeGenCXX/debug-info-dllimport-base-class.cpp
==
amccarth added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1688-1689
@@ -1687,3 +1687,4 @@
- if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass())
+ if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass() &&
+ !CXXDecl->hasAttr())
return true;
---
Author: amccarth
Date: Tue Aug 16 17:11:18 2016
New Revision: 278861
URL: http://llvm.org/viewvc/llvm-project?rev=278861&view=rev
Log:
Emit debug info for dynamic classes if they are imported from a DLL.
With -debug-info-kind=limited, we omit debug info for dynamic classes that live
in other TUs
amccarth closed this revision.
amccarth added a comment.
Closed by r278861
https://reviews.llvm.org/D23462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amccarth created this revision.
amccarth added a subscriber: cfe-commits.
Clang tracks only start columns, not start-end ranges. CodeView allows for
that, but the VS debugger doesn't handle anything less than a complete range
well--it either highlights the wrong part of a statement or truncates
amccarth added a comment.
I don't know enough C# to review for language usage. I was mostly reading for
understandability. Overall, I think this looks really nice.
Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:67
@@ +66,3 @@
+if (ParentPath == null)
+
Author: amccarth
Date: Thu Aug 25 13:24:35 2016
New Revision: 279765
URL: http://llvm.org/viewvc/llvm-project?rev=279765&view=rev
Log:
Omit column info for CodeView by default
Clang tracks only start columns, not start-end ranges. CodeView allows for
that, but the VS debugger doesn't handle anyt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279765: Omit column info for CodeView by default (authored
by amccarth).
Changed prior to commit:
https://reviews.llvm.org/D23720?vs=68713&id=69274#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
amccarth added inline comments.
Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:68
@@ +67,3 @@
+return Name_;
+return ParentPath + "-" + Name_;
+}
OK, cool. I assumed that the root had a name. Thus a node with no
Thanks. I was trying to be consistent with how the prefixes were used in
this particular file, where the prefix was modeled after the case-sensitive
flags being tested.
On Mon, Aug 29, 2016 at 8:49 AM, David Blaikie wrote:
>
>
> On Thu, Aug 25, 2016 at 11:32 AM Adrian McCarthy via cf
Sorry, no, I don't have plans to implement column ranges at this time.
On Mon, Aug 29, 2016 at 2:10 PM, Adrian Prantl wrote:
>
> > On Aug 25, 2016, at 11:24 AM, Adrian McCarthy via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Author: amccarth
amccarth created this revision.
amccarth added reviewers: rnk, dblaikie.
amccarth added a subscriber: cfe-commits.
Unreferenced nested structs and classes were omitted from the debug info. In
DWARF, this was intentional, to avoid bloat. But, for CodeView, we want this
information to be consist
amccarth updated this revision to Diff 64761.
amccarth added a comment.
Addressed feedback.
https://reviews.llvm.org/D22577
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenCXX/debug-info-dup-fwd-decl.cpp
test/CodeGenCXX/debug-info-ms-abi.cpp
test/Modules/Modul
amccarth marked 2 inline comments as done.
amccarth added a comment.
https://reviews.llvm.org/D22577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: amccarth
Date: Thu Jul 21 08:16:14 2016
New Revision: 276271
URL: http://llvm.org/viewvc/llvm-project?rev=276271&view=rev
Log:
Include unreferenced nested types in member list only for CodeView
Unreferenced nested structs and classes were omitted from the debug info. In
DWARF, this was
Author: amccarth
Date: Thu Jul 21 08:41:25 2016
New Revision: 276279
URL: http://llvm.org/viewvc/llvm-project?rev=276279&view=rev
Log:
Revert "Include unreferenced nested types in member list only for CodeView"
Patch broke ModuleDebugInfo test on the build bots (but not locally). Again.
svn rev
Author: amccarth
Date: Thu Jul 21 13:43:20 2016
New Revision: 276317
URL: http://llvm.org/viewvc/llvm-project?rev=276317&view=rev
Log:
Reroll "Include unreferenced nested types in member list only for CodeView"
Another attempt at r276271, hopefully without breaking ModuleDebugInfo test.
Modified
amccarth created this revision.
amccarth added a reviewer: rnk.
amccarth added a subscriber: cfe-commits.
With -debug-info-kind=limited, we omit debug info for abstract classes that
live in other TUs. This reduces duplicate type information. When statically
linked, the type information comes t
amccarth created this revision.
amccarth added a reviewer: rnk.
amccarth added a subscriber: cfe-commits.
`-fms-compatibility-version` was defaulting to 18 (VS 2013), which is a pain if
your environment is pointing to version 19 (VS 2015) libraries.
If cl.exe can be found, this patch uses its ve
amccarth added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:477
@@ +476,3 @@
+ std::vector VersionBlock(VersionSize);
+ if (!::GetFileVersionInfoA(ClExe.c_str(), 0, VersionSize,
+ VersionBlock.data())) {
thakis wrote:
> W
amccarth added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:472
@@ +471,3 @@
+
+ const DWORD VersionSize = ::GetFileVersionInfoSizeA(ClExe.c_str(), nullptr);
+ if (VersionSize == 0) {
majnemer wrote:
> Why not use the `GetFileVersionInfoSizeW` varia
amccarth updated this revision to Diff 56833.
amccarth marked an inline comment as done.
amccarth added a comment.
Addressed most comments: now using wide-chars for WinAPI calls, made
getMSVCVersionFromExe a virtual method, removed extraneous typo-correction.
http://reviews.llvm.org/D20136
Fil
amccarth marked 4 inline comments as done.
Comment at: lib/Driver/MSVCToolChain.cpp:478
@@ +477,3 @@
+
+ const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(),
+ nullptr);
Yes, it looks in the e
amccarth added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:478
@@ +477,3 @@
+
+ const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(),
+ nullptr);
thakis wrote:
> amccarth wrote:
>
amccarth added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:478
@@ +477,3 @@
+
+ const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(),
+ nullptr);
amccarth wrote:
> thakis wrote:
>
amccarth added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:478
@@ +477,3 @@
+
+ const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(),
+ nullptr);
thakis wrote:
> amccarth wrote:
>
amccarth added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:478
@@ +477,3 @@
+
+ const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(),
+ nullptr);
amccarth wrote:
> thakis wrote:
>
amccarth added a comment.
Are there any remaining concerns with this patch? Is everyone satisfied with
the performance numbers?
http://reviews.llvm.org/D20136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
amccarth marked 2 inline comments as done.
Comment at: lib/Driver/MSVCToolChain.cpp:42
@@ -40,1 +41,3 @@
+
+ #pragma comment(lib, "version.lib")
#endif
aaron.ballman wrote:
> Eh, I am lightening up on this sort of thing, so this is fine by me.
I was following th
amccarth updated this revision to Diff 57196.
amccarth marked an inline comment as done.
amccarth added a comment.
Addressed additional comments.
http://reviews.llvm.org/D20136
Files:
include/clang/Driver/ToolChain.h
lib/Driver/MSVCToolChain.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.
amccarth added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:481
@@ +480,3 @@
+
+ std::vector VersionBlock(VersionSize);
+ if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize,
majnemer wrote:
> It might be nicer to use a `SmallVector`,
> or
amccarth marked an inline comment as done.
Comment at: lib/Driver/MSVCToolChain.cpp:481
@@ +480,3 @@
+
+ std::vector VersionBlock(VersionSize);
+ if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize,
majnemer wrote:
> amccarth wrote:
> > majnemer wrote:
This revision was automatically updated to reflect the committed changes.
amccarth marked an inline comment as done.
Closed by commit rL269515: Get default -fms-compatibility-version from cl.exe's
version (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D20136?vs=57196&i
Author: amccarth
Date: Fri May 13 18:20:11 2016
New Revision: 269515
URL: http://llvm.org/viewvc/llvm-project?rev=269515&view=rev
Log:
Get default -fms-compatibility-version from cl.exe's version
-fms-compatibility-version was defaulting to 18 (VS 2013), which is a pain if
your environment is po
amccarth created this revision.
amccarth added a reviewer: rnk.
amccarth added a subscriber: cfe-commits.
A baby step toward translating DIType records to CodeView.
This does not (yet) combine the record length with the record data. I'm going
back and forth trying to determine if that's a good
amccarth created this revision.
amccarth added a reviewer: majnemer.
amccarth added a subscriber: cfe-commits.
This fixes the problem where the driver will look for cl.exe.exe while walking
the PATH.
I looked into changing the Windows implementation of
llvm::sys::fs::can_execute(), but there wa
Author: amccarth
Date: Fri May 20 10:46:23 2016
New Revision: 270226
URL: http://llvm.org/viewvc/llvm-project?rev=270226&view=rev
Log:
Eliminate unnecessary file access checks in Clang driver on Windows
Differential Revision: http://reviews.llvm.org/D20454
Modified:
cfe/trunk/lib/Driver/MSVC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270226: Eliminate unnecessary file access checks in Clang
driver on Windows (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D20454?vs=57872&id=57936#toc
Repository:
rL LLVM
Author: amccarth
Date: Wed Apr 20 11:43:34 2016
New Revision: 266887
URL: http://llvm.org/viewvc/llvm-project?rev=266887&view=rev
Log:
Add warning about CR+LF line endings on Windows.
s/checkout/check out/ when used as a verb.
Differential Revision: http://reviews.llvm.org/D19285
Modified:
amccarth created this revision.
amccarth added a reviewer: rnk.
amccarth added a subscriber: cfe-commits.
Creates codeview type records for arrays and adds a simple test for one.
http://reviews.llvm.org/D21107
Files:
lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
lib/CodeGen/AsmPrinter/CodeViewD
amccarth added inline comments.
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785
@@ +784,3 @@
+ TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ?
+ TypeIndex(SimpleTypeKind::UInt64) :
+ TypeIndex(SimpleTypeKind::UInt32);
majnemer wrote:
>
amccarth created this revision.
amccarth added a reviewer: rnk.
amccarth added a subscriber: cfe-commits.
This includes nested types in the member list, even if there are no members of
that type. Note that structs and classes have themselves as an "implicit
struct" as the first member, so we sk
amccarth marked 2 inline comments as done.
amccarth added a comment.
http://reviews.llvm.org/D21705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amccarth updated this revision to Diff 62283.
amccarth added a comment.
Applied suggestion from the comments, which eliminates the need to alter the
ObjectiveC test.
http://reviews.llvm.org/D21705
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenCXX/debug-info-dup
Author: amccarth
Date: Wed Jul 6 09:46:42 2016
New Revision: 274628
URL: http://llvm.org/viewvc/llvm-project?rev=274628&view=rev
Log:
Include debug info for nested structs and classes
This includes nested types in the member list, even if there are no members of
that type. Note that structs and
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274628: Include debug info for nested structs and classes
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D21705?vs=62283&id=62869#toc
Repository:
rL LLVM
http://reviews.llv
Author: amccarth
Date: Wed Jul 6 10:15:38 2016
New Revision: 274633
URL: http://llvm.org/viewvc/llvm-project?rev=274633&view=rev
Log:
Revert "Include debug info for nested structs and classes"
This reverts commit 0af5ee9631c7c167dc40498b415876553e314c95.
Modified:
cfe/trunk/lib/CodeGen/CGDe
Reverted because this depended upon an LLVM patch that was reverted because
of test failures on the buildbots. I'm still investigating the root cause.
SVN revision was rL274628.
On Wed, Jul 6, 2016 at 8:15 AM, Adrian McCarthy via cfe-commits <
cfe-commits@lists.llvm.org> wrote
Author: amccarth
Date: Wed Jul 6 17:39:15 2016
New Revision: 274698
URL: http://llvm.org/viewvc/llvm-project?rev=274698&view=rev
Log:
Retry "Include debug info for nested structs and classes"
This should work now that the LLVM-side of the change has landed successfully.
Original Differential Re
Author: amccarth
Date: Wed Jul 6 18:28:34 2016
New Revision: 274706
URL: http://llvm.org/viewvc/llvm-project?rev=274706&view=rev
Log:
Revert "Retry "Include debug info for nested structs and classes""
Reverting because it causes a test failure on build bots
(Modules/ModuleDebugInfo.cpp). Failu
t;
> Under what conditions do nested types appear in the member list? (my
> simple test case on a fresh clang didn't seem to produce anything about the
> nested type: struct outer { struct inner { int i; }; int j; }; outer o; )
>
> On Wed, Jul 6, 2016 at 7:46 AM, Adrian McCart
Author: Alessandro Vergani
Date: 2021-04-20T11:17:29-07:00
New Revision: 6e77a67171e68d9eda811799d5b1c2530282478e
URL:
https://github.com/llvm/llvm-project/commit/6e77a67171e68d9eda811799d5b1c2530282478e
DIFF:
https://github.com/llvm/llvm-project/commit/6e77a67171e68d9eda811799d5b1c2530282478e.
68 matches
Mail list logo