[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

abhina.sreeskantharajan updated this revision to Diff 285362. abhina.sreeskantharajan added a comment. Thanks Hubert and Fanbo for reviewing. I updated the comment to Hubert's suggestion, and updated both testcases as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

abhina.sreeskantharajan marked 3 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2791 + Opts.Trigraphs = + (!Opts.GNUMode && !Opts.MSVCCompat && !Opts.CPlusPlus17) || T.isOSzOS(); Opts.Trigraph

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

abhina.sreeskantharajan updated this revision to Diff 285399. abhina.sreeskantharajan added a comment. Thanks Hubert for the suggestion. I've updated the lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85722/new/ https://reviews.llvm.org/D8

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

abhina.sreeskantharajan updated this revision to Diff 285427. abhina.sreeskantharajan added a comment. Thanks for catching that. I fixed up the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85722/new/ https://reviews.llvm.org/D85722 File

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:730 +MacroBuilder &Builder) const override { +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_OPEN_DEFAULT"); hubert.reinterpretca

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan updated this revision to Diff 286014. abhina.sreeskantharajan added a comment. Addressed Hubert's comments, and removed some macros that are unnecessary with system header updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan updated this revision to Diff 286092. abhina.sreeskantharajan added a comment. Thanks MaskRay. I moved the zos testcase to a new file called init-zos.c instead and reduced the number of RUN commands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/test/Preprocessor/init.c:1041 // +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=s390x-none-zos -fno-signed-char < /dev/null | FileCheck -match-full-line

[PATCH] D106890: [z/OS] Make MinGlobalAlign consistent with SystemZ

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106890/new/ https://reviews.llvm.org/D106890 _

[PATCH] D121628: Only run this test for x86 registed targets.

abhina.sreeskantharajan created this revision. Herald added a project: All. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121628 Files: clang/test

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. this LGTM from a systemz perspective! thanks for refactoring Comment at: clang/lib/Headers/CMakeLists.txt:173 __wmmintrin_pclmul.h x86

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:173 __wmmintrin_pclmul.h x86gprintrin.h x86intrin.h qiongsiwu1 wrote: > abhina.sreeskantharajan wrote: > > nit: There are some x86 headers here that appear to be

[PATCH] D87624: [SystemZ][z/OS] Set default wchar_t type for zOS

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: abdulras, uweigand, hubert.reinterpretcast, fanbo-meng, Kai, ro, zibi, SeanP. Herald added a project: clang. Herald added a subscriber: cfe-commits. abhina.sreeskantharajan requested review of this revision. S

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:773-774 } + +this->PlatformName = llvm::Triple::getOSTypeName(Triple.getOS());; } There is an extra semi-colon. CHANGES SINCE LAST ACTION https://review

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87611/new/ https://reviews.llvm.org/D87611 ___

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rG2240ca0bd150: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS (authored by fanbo-meng, committed by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D87624: [SystemZ][z/OS] Set default wchar_t type for zOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fb97fd6a4f2: [SystemZ][z/OS] Set default wchar_t type for zOS (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87624/new

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan updated this revision to Diff 286853. abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added a comment. Thanks Hubert, I updated the comments, and also the check-prefix to your suggestion. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan marked 3 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +Builder.defineMacro("__BOOL__"); +Builder.defineMacro("__LONGNAME__"); --

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan updated this revision to Diff 287043. abhina.sreeskantharajan added a comment. Thanks for reviewing. I've updated the comments and removed ISOC99_SOURCE macro. I've updated the lit test to reflect these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan marked 5 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +// FIXME: __BOOL__ should be defined under strict -std=c89. +Builder.defineMa

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan updated this revision to Diff 287338. abhina.sreeskantharajan added a comment. Thanks Hubert, I fixed the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85324/new/ https://reviews.llvm.org/D85324 Files: clang/lib/

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan added a comment. In D85324#2234712 , @hubert.reinterpretcast wrote: > In D85324#2233290 , > @abhina.sreeskantharajan wrote: > >> Thanks Hubert, I fixed the comment. > > Got it; I'll look in

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan added inline comments. Comment at: clang/test/Preprocessor/init-zos.c:4 + +// S390X-ZOS-GNUXX:#define _EXT 1 +// S390X-ZOS:#define _LONG_LONG 1 MaskRay wrote: > --match-full-lines is different from --match-full-lines --strict-whitespace.

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: Kai, uweigand, hubert.reinterpretcast, stevewan, SeanP, lalovic. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. abhina.sreeskantharajan requested review of this revision. This pa

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Driver/ToolChains/ZOS.h:25 + + bool isPICDefault() const override { return false; } + bool isPIEDefault() const override { return false; }

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

abhina.sreeskantharajan updated this revision to Diff 289148. abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added a comment. Thanks Hubert, I removed the lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86707/

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e1e5f54492d: [SystemZ][z/OS] Adding initial toolchain for z/OS (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86707/ne

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, dang, hiraditya, mgorny. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch enables the fexec-charset opt

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 311911. abhina.sreeskantharajan added a comment. Thanks for your quick reviews! I haven't addressed all the comments yet but I plan to address all of them. I put up this patch early because it has a few major changes: - moves LiteralTranslat

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 9 inline comments as done. abhina.sreeskantharajan added a comment. In D93031#2447230 , @rsmith wrote: > I'm overall pretty happy about how clean and non-invasive the changes > required here are. But please make sure you don

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 313112. abhina.sreeskantharajan added a comment. Thanks for your patience, I've addressed some more comments. Here is the summary of the changes in this patch: - add translation for UCN strings, update testcase - fix helptext for fexec-charse

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 11 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Driver/Options.td:3583-3584 +def fexec_charset : Separate<["-"], "fexec-charset">, MetaVarName<"">, + HelpText<"Set the execution for str

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1322-1323 + TranslationState = translationState; + if (Kind == tok::wide_string_literal) +TranslationState = TranslateToSystemCharset; + else if (isUTFLiteral(Kind)) ---

[PATCH] D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder

abhina.sreeskantharajan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. abhina.sreeskantharajan requested review of this revision. This patch creates a SystemZ folder in clang/test/CodeGen to contain systemz-related lit tests. Repository: rG LLVM

[PATCH] D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder

abhina.sreeskantharajan updated this revision to Diff 305781. abhina.sreeskantharajan added a comment. Add one more testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91628/new/ https://reviews.llvm.org/D91628 Files: clang/test/CodeGen/Syst

[PATCH] D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG057e6bb5540b: [SystemZ][NFC] Group SystemZ tests in SystemZ folder (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHA

[PATCH] D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88845/new/ https://reviews.llvm.org/D88845 ___

[PATCH] D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target

This revision was automatically updated to reflect the committed changes. Closed by commit rGc781dc74a8b2: [SystemZ][z/OS] Set default alignment rules for z/OS target (authored by fanbo-meng, committed by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88963: [SystemZ][z/OS] Add test of zero length bitfield type size larger than target zero length bitfield boundary

This revision was automatically updated to reflect the committed changes. Closed by commit rG9908ee567059: [SystemZ][z/OS] Add test of zero length bitfield type size larger than target… (authored by fanbo-meng, committed by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89127/new/ https://reviews.llvm.org/D89127 ___

[PATCH] D91565: Guard init_priority attribute within libc++

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c7e24c4b689: Guard init_priority attribute within libc++ (authore

[PATCH] D92048: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: fanbo-meng, Kai, uweigand, Jonathan.Crowther, muiez. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. abhina.sreeskantharajan requested review of this revision. This patch moves all s

[PATCH] D92048: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c

This revision was automatically updated to reflect the committed changes. Closed by commit rGf770ec1a4e8d: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92048

[PATCH] D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89801/new/ https://reviews.llvm.org/D89801 ___ cfe-co

[PATCH] D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bc02e892f54: [SystemZ][z/OS] Set short-enums as the default for z/OS (authored by Jonathan.Crowther, committed by abhina.sreeskantharajan). Reposit

[PATCH] D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder

abhina.sreeskantharajan added a comment. In D91628#2762190 , @MaskRay wrote: > .ll -> .s tests should be placed in llvm/test/CodeGen/SystemZ, not in clang Sorry for the late reply, I was on vacation. Is there a specific test you are referring to? All the

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: fanbo-meng, anirudhp, muiez, Kai, yusra.syeda. Herald added subscribers: rupprecht, steven_wu, hiraditya, sbc100. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added a reviewer:

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

This revision was automatically updated to reflect the committed changes. Closed by commit rG520b5ecf8561: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit… (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan reopened this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. In D95246#2518989 , @jhenderson wrote: > Sorry, could you revert this please. I don't think this is a good fix, as >

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan added a comment. In D95246#2519729 , @jhenderson wrote: > In D95246#2519642 , > @abhina.sreeskantharajan wrote: > >> In D95246#2518989 , @jhenderson

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319048. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a reviewer: grimar. abhina.sreeskantharajan added a comment. Herald added subscribers: sstefan1, delcypher. Herald added a reviewer: jdoerfert. I

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319078. abhina.sreeskantharajan added a comment. FIx CI, check if host_triple exists. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246 Files: clang/tes

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319276. abhina.sreeskantharajan added a comment. Herald added subscribers: mgorny, emaste. This patch makes the following changes: - Define LLVM_HOST_TRIPLE for lld tests. (This was the project that didn't have host defined.) - Change %err_no

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan requested review of this revision. abhina.sreeskantharajan marked 4 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:349-354 +if (re.match(r's390x-.*-zos', triple)): +

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319309. abhina.sreeskantharajan added a comment. Fix CI: Other projects like flang also do not specify LLVM_HOST_TRIPLE. If this is not specified, set the triple to an empty string. I also added one more error code %errc_EISDIR and updated th

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added a comment. Herald added a reviewer: jansvoboda11. ping :) Is there any more feedback on the implementation inside ProcessCharEscape()? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://reviews.llvm.org/D

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319543. abhina.sreeskantharajan added a comment. I've changed the host check to use python's sys.platform to determine the host as an alternative to using LLVM_HOST_TRIPLE. It will save us the effort of making sure it's defined in all project

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:349-351 +triple = "" +if hasattr(self.config, 'host_triple'): +triple = self.config.host_triple -

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319547. abhina.sreeskantharajan added a comment. Fix CI: Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246 Files: clang/test/Driver/clang-offload

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:349-351 +triple = "" +if hasattr(self.config, 'host_triple'): +triple = self.config.host_triple jhenderson wrote: > abhina.sreeskantharajan wr

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319839. abhina.sreeskantharajan added a comment. Address syntax comments, and add a list of supported error code substitutions in the guide. If these changes are ok, I would like to start making changes to all affected testcases. Repositor

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan added a comment. In D95246#2527961 , @jhenderson wrote: > One nit, but otherwise looks good to me, thanks! Please go ahead with the > other test updates. Do you plan on doing them in this patch? This was my initial thought. But if

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319844. abhina.sreeskantharajan added a comment. Add currently in TestingGuide. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246 Files: clang/test/Driv

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan updated this revision to Diff 319873. abhina.sreeskantharajan retitled this revision from "[SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued" to "[test] Use host platform specific error message substitution in lit tests ". abh

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42a21778f61c: [test] Use host platform specific error message substitution in lit tests (authored by abhina.sreeskantharajan). Repository: rG LLVM

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: muiez, fanbo-meng, Kai, jhenderson, grimar. Herald added subscribers: delcypher, emaste. abhina.sreeskantharajan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay.

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 320571. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Herald added subscribers: rupprecht, arphaman, steven_wu, hiraditya. I've previously changed Permission denied errors before. Fixing t

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 320745. abhina.sreeskantharajan added a comment. Thank you for reminding me, I've updated the TestingGuide.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95808/new/ https://reviews.llvm.org/

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

abhina.sreeskantharajan added inline comments. Comment at: clang/test/CodeGenCXX/global-init.cpp:84 // CHECK-NEXT: store i32 [[CALL]], i32* @_ZN5test41xE - // CHECK-NEXT: store i64 1, i64* @_ZGVN5test41xE + // CHECK-NEXT: store i8 1, i8* bitcast (i64* @_ZGVN5test41xE to i8*)

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95822/new/ https://reviews.llvm.org/D95822 _

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe59d336e75f4: [test] Use host platform specific error message substitution in lit tests… (authored by abhina.sreeskantharajan). Repository: rG LLV

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan created this revision. Herald added a reviewer: JDevlieghere. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is a continuation of https://reviews.llvm.org/D67696. The f

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan updated this revision to Diff 322479. abhina.sreeskantharajan added a comment. Remove ARCMigrate change in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/ https://reviews.llvm.org/D96363 Files: clang/

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan updated this revision to Diff 322658. abhina.sreeskantharajan added a comment. Rerun CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/ https://reviews.llvm.org/D96363 Files: clang/lib/Driver/Driver.cpp clang/l

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan updated this revision to Diff 323093. abhina.sreeskantharajan added a comment. Thanks for reviewing! Addressing inline comments by adding /*Binary*/ comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/ https://r

[PATCH] D96363: Mark output as text if it is really text

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdb640ea30d4: Mark output as text if it is really text (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. In D95246#2564137 , @ASDenysPetrov wrote: > This patch causes fails in a bunch of test files. When I roll it back, it > passes. > Below you can see fail output of `ubsan-blacklist-vfs.c` and > `basic-block-sectio

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. In D95246#2566029 , @ASDenysPetrov wrote: > In D95246#2565351 , > @abhina.sreeskantharajan wrote: > >> > > > >> Do you know what is different between your environments whi

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. In D95246#2568084 , @ASDenysPetrov wrote: > @jhenderson > >> @ASDenysPetrov, could you provide your link command-line for one of the >> tools that produces the failing message, please, e.g. llvm-ar? > > Here is ou

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. @ASDenysPetrov are you running python inside MSYS bash that is installed by > pacman -S --needed base-devel mingw-w64-x86_64-toolchain ? I learned that the python should give different output >>> sys.platform msys >>> platform.system() MSYS_NT-10

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. In D95246#2587452 , @jhenderson wrote: > In D95246#2587410 , @ASDenysPetrov > wrote: > >> @jhenderson >> I think I'm done. >> Here is output: F15648076: linker_trace_output.

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. I created the following review https://reviews.llvm.org/D97472 which I think should fix the error on all platforms. Let me know if this fixes the issue on MSYS2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, hiraditya. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch https://reviews.llvm.org/D102876 caused som

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

abhina.sreeskantharajan added inline comments. Comment at: llvm/lib/Support/Path.cpp:1295 SmallString<128> ResultPath; - if (std::error_code EC = - createUniqueFile(Model, FD, ResultPath, OF_Delete, Mode)) + if (std::error_code EC = createUniqueFile(Model, FD, Resul

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

abhina.sreeskantharajan updated this revision to Diff 350386. abhina.sreeskantharajan added a comment. Address rnk's comments and rename to ExtraFlags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103806/new/ https://reviews.llvm.org/D103806 Files

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e8506debae3: [SystemZ][z/OS] Pass OpenFlags when creating tmp files (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo C

[PATCH] D107189: [z/OS]Remove overriding default attribute aligned value

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107189/new/ https://reviews.llvm.org/D107189 ___ cfe-commits ma

[PATCH] D107565: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test"

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107565/new/ https://reviews.llvm.org/D107565 _

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 327470. abhina.sreeskantharajan added a comment. Thanks for the feedback! I haven't addressed all the comments yet but I've made major renaming changes and hope to get feedback on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 6 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:191 +Preprocessor &PP, tok::TokenKind kind, +ConversionState TranslationState = Tr

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added a comment. Hi Tom, @tahonermann I renamed the LiteralTranslator class to LiteralConverter.cpp and have renamed a lot of the functions. Let me know what you think. I agree that the setConverters function is awkward, the problem stems from initializing the member ear

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, martong, thopre, hiraditya. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch consists of changes to hel

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan updated this revision to Diff 327790. abhina.sreeskantharajan added a comment. Remove some changes that cause lit failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ https://reviews.llvm.org/D97785 Files: c

[PATCH] D97796: [test] Fix apparent typo in clang/test/Driver/std.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9403b59a7dbb: [test] Fix apparent typo in clang/test/Driver/std.c (authored by DanielMcIntosh-IBM, committed by abhina.sreeskantharajan). Repositor

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 328151. abhina.sreeskantharajan added a comment. Addressing some more comments. Updating the argument parsing, lit tests, some more renaming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 4 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:145 ModuleLoader &TheModuleLoader; + LiteralConverter LT; rsmith wrote: > Please give this a lo

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan requested review of this revision. abhina.sreeskantharajan added a comment. This issue has been fixed in https://reviews.llvm.org/D97472. @ASDenysPetrov I'm unable to close this revision and the other one https://reviews.llvm.org/D95808. Repository: rG LLVM Github Mono

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:841 } } amccarth wrote: > The preceding block that detects the type of line separator seems ripe for > factoring out into a separate function. It's a lot

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan updated this revision to Diff 328483. abhina.sreeskantharajan added reviewers: amccarth, MaskRay, jhenderson. abhina.sreeskantharajan added a comment. Fix formatting from lint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97

  1   2   3   >