https://github.com/MacDue closed
https://github.com/llvm/llvm-project/pull/105608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue closed
https://github.com/llvm/llvm-project/pull/130761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MacDue wrote:
Thanks for the report :+1: It looks like all we have to do is set the
legalization rule for f32 to "Promote". Looks like there's actually already
logic to do this for a bunch of other nodes:
>From X86ISelLowering.cpp:
```c++
// On 32 bit MSVC, `fmodf(f32)` is not defined - only
https://github.com/MacDue created
https://github.com/llvm/llvm-project/pull/129885
Reverts llvm/llvm-project#127987
Original description:
This updates the existing modf[f|l] builtin to be lowered via the llvm.modf.*
intrinsic (rather than directly to a library call).
The legalization issues e
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/127183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/127183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue closed
https://github.com/llvm/llvm-project/pull/127183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue updated
https://github.com/llvm/llvm-project/pull/126750
>From eee5bc815c4b6b7e5a18503959b2a2354d73058b Mon Sep 17 00:00:00 2001
From: Benjamin Maxwell
Date: Tue, 11 Feb 2025 15:32:23 +
Subject: [PATCH 1/4] [clang] Lower modf builtin using `llvm.modf` intrinsic
Th
MacDue wrote:
> So to handle this, we need different lowering in strictfp mode, probably to a
> "constrained" intrinsic.
I've updated the lowering to simply bail out when
`Builder.getIsFPConstrained()` set (which I think corresponds to `strictfp`).
So now in the `HAS_MAYTRAP` case the lowerin
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/126750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4096,6 +4114,15 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl
GD, unsigned BuiltinID,
case Builtin::BI__builtin_frexpf128:
case Builtin::BI__builtin_frexpf16:
return RValue::get(emitFrexpBuiltin(*this, E, Intrinsic::frexp));
+ case Builtin::BImodf:
+
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/126750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue updated
https://github.com/llvm/llvm-project/pull/127065
>From f98f80df7b93722581c04d181eea4273d4f1 Mon Sep 17 00:00:00 2001
From: Benjamin Maxwell
Date: Thu, 13 Feb 2025 14:23:33 +
Subject: [PATCH 1/2] [clang] Add `__builtin_sincospi` that lowers to
`llvm.sin
https://github.com/MacDue updated
https://github.com/llvm/llvm-project/pull/126750
>From eee5bc815c4b6b7e5a18503959b2a2354d73058b Mon Sep 17 00:00:00 2001
From: Benjamin Maxwell
Date: Tue, 11 Feb 2025 15:32:23 +
Subject: [PATCH 1/5] [clang] Lower modf builtin using `llvm.modf` intrinsic
Th
MacDue wrote:
I've disabled the intrinsic lowering for both `sincos`/`sincospi` when strictfp
is enabled (and added a test for that).
I think I might need to cherry-pick the `sincos` fix onto the release 20.x
branch too.
https://github.com/llvm/llvm-project/pull/127065
__
MacDue wrote:
> From this patch? https://lab.llvm.org/buildbot/#/builders/72/builds/8380
>
> FYI @fmayer
Looks like it, I had missed it in the log but the actual error is:
> ExpandFloatResult #0: t57: ppcf128,ppcf128 = fmodf
> ConstantFP:ppcf128,
> llvm-project/compiler-rt/lib/msan/tests/msan
MacDue wrote:
I think this patch should fix the issue:
https://github.com/llvm/llvm-project/pull/127895
https://github.com/llvm/llvm-project/pull/126750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
MacDue wrote:
I think with the `AllowMisalignedMemAccesses` check (preventing this applying
when `+strict-align` is set) this _probably_ okay. The `LDR ZPR` notes:
> The load is performed as contiguous byte accesses, with no endian conversion
> and no guarantee of single-copy atomicity larger
https://github.com/MacDue updated
https://github.com/llvm/llvm-project/pull/127065
>From a9631573a2b6d26e8b41de67fac67247ce0b0829 Mon Sep 17 00:00:00 2001
From: Benjamin Maxwell
Date: Thu, 13 Feb 2025 14:23:33 +
Subject: [PATCH 1/2] [clang] Add `__builtin_sincospi` that lowers to
`llvm.sin
https://github.com/MacDue created
https://github.com/llvm/llvm-project/pull/127987
Reverts llvm/llvm-project#126750
Revering while I investigate:
https://lab.llvm.org/buildbot/#/builders/72/builds/8406
>From e082cbf5fd4f889762e12062d2544f862339b959 Mon Sep 17 00:00:00 2001
From: Benjamin Max
https://github.com/MacDue closed
https://github.com/llvm/llvm-project/pull/127987
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue closed
https://github.com/llvm/llvm-project/pull/127065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue closed
https://github.com/llvm/llvm-project/pull/133375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue approved this pull request.
https://github.com/llvm/llvm-project/pull/133375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MacDue wrote:
> This makes a lot of sense to me, just wondering why you chose
> `clang/lib/CodeGen/BuiltinTargets/` rather than
> `clang/lib/CodeGen/TargetBuiltins/`? The former shounds like it contains the
> list of all builtin targets, rather than the codegen for target-specific
> builtins.
https://github.com/MacDue commented:
I double-checked the functions added cover up to 2.40 -- I think they do :+1::
Generally, LGTM -- but I'll leave final approval to Sander/Paul.
https://github.com/llvm/llvm-project/pull/143696
___
cfe-commits maili
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/143696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue approved this pull request.
Thanks! LGTM!
https://github.com/llvm/llvm-project/pull/146453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -34,6 +34,7 @@ page](https://llvm.org/releases/).
* -floop-interchange is now recognized by flang.
* -floop-interchange is enabled by default at -O2 and above.
+* -fveclib=libmvec is supported for AArch64 (same as Flang/x86 and
Clang/AArch64)
MacDue wrote:
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/146453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/146453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue commented:
You may also want to change `Options.td` currently the note about needing GLIBC
2.40 is only displayed for Clang as it's under `
HelpTextForVariants<[ClangOption, CC1Option]`:
https://github.com/llvm/llvm-project/blob/cb806510914ed909b934d285062a9efb13b1cea4
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/146453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue closed
https://github.com/llvm/llvm-project/pull/150333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/150592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue created
https://github.com/llvm/llvm-project/pull/150917
This is handled by the instcombine added in #147930; there is no need for any
clang-specific folding. NFC as all clang tests for `__arm_in_streaming_mode()`
used -O1, which applies the LLVM instcombines.
>From
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/150592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sme
-fsyntax-only -verify %s
+
+#include
+
+void test_streaming(svint32_t *out, svint32_t *in) __arm_streaming {
+ *out = *in;
+}
+
+void test_non_streaming(svint32_t *out, svint32_t *in) {
+
@@ -5988,11 +5988,9 @@ bool clang::IsArmStreamingFunction(const FunctionDecl
*FD,
if (FD->hasAttr())
return true;
- if (const Type *Ty = FD->getType().getTypePtrOrNull())
MacDue wrote:
> If for example, I were to call FD->dump() in this function,
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/150592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5988,11 +5988,9 @@ bool clang::IsArmStreamingFunction(const FunctionDecl
*FD,
if (FD->hasAttr())
return true;
- if (const Type *Ty = FD->getType().getTypePtrOrNull())
MacDue wrote:
> operator-> that returns the Type* has an explicit assert tha
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/150592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/150592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,54 @@
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sme
-fsyntax-only -verify %s
+
+#include
+
+void test_streaming(svint32_t *out, svint32_t *in) __arm_streaming {
+ *out = *in;
+}
+
+void test_non_streaming(svint32_t *out, svint32_t *in) {
+
https://github.com/MacDue closed
https://github.com/llvm/llvm-project/pull/150917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 245 of 245 matches
Mail list logo
