[clang] [Basic] Drop const from a return type (NFC) (PR #146382)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes We don't need const on a return type. --- Full diff: https://github.com/llvm/llvm-project/pull/146382.diff 1 Files Affected: - (modified) clang/include/clang/Basic/TargetInfo.h (+1-1) ``d

[clang] [libc] [llvm] [DebugInfo][RemoveDIs] Suppress getNextNonDebugInfoInstruction (PR #144383)

2025-06-30 Thread Nikita Popov via cfe-commits
nikic wrote: Reverse ping :) https://github.com/llvm/llvm-project/pull/144383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 0f291e5 - [clang-tidy] Add flag to specify an alternative to std::move in cppcoreguidelines-rvalue-reference-param-not-moved (#138757)

2025-06-30 Thread via cfe-commits
Author: Dimitrije Dobrota Date: 2025-06-30T22:36:23+03:00 New Revision: 0f291e5787a593a06f2e19a003ece7255f4957b4 URL: https://github.com/llvm/llvm-project/commit/0f291e5787a593a06f2e19a003ece7255f4957b4 DIFF: https://github.com/llvm/llvm-project/commit/0f291e5787a593a06f2e19a003ece7255f4957b4.d

[clang-tools-extra] [clang-tidy] Add flag to specify an alternative to std::move in cppcoreguidelines-rvalue-reference-param-not-moved (PR #138757)

2025-06-30 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/138757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add flag to specify an alternative to std::move in cppcoreguidelines-rvalue-reference-param-not-moved (PR #138757)

2025-06-30 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. https://github.com/llvm/llvm-project/pull/138757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add flag to specify an alternative to std::move in cppcoreguidelines-rvalue-reference-param-not-moved (PR #138757)

2025-06-30 Thread via cfe-commits
github-actions[bot] wrote: @DimitrijeDobrota Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with

[clang] Disable -fdollars-in-identifiers by default (PR #135407)

2025-06-30 Thread Richard Smith via cfe-commits
zygoloid wrote: > This will indeed break building the Linux kernel for x86_64 at least in my > brief test [...] > ``` > In file included from arch/x86/kernel/acpi/wakeup_64.S:11: > arch/x86/include/asm/nospec-branch.h:80:7: warning: '$' in identifier; did > you mean to enable '-fdollars-in-iden

[clang-tools-extra] [clang-doc] serialize friends (PR #146165)

2025-06-30 Thread Erick Velez via cfe-commits
https://github.com/evelez7 edited https://github.com/llvm/llvm-project/pull/146165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Disable -fdollars-in-identifiers by default (PR #135407)

2025-06-30 Thread Richard Smith via cfe-commits
zygoloid wrote: (I guess we could also warn if an object-like macro is expanded and the macro name is preceded or followed by a `$` with no whitespace, since that would also behave differently under `-fdollars-in-identifiers`, but I suspect that's not worth worrying about in practice.) https:

[clang-tools-extra] [clang-doc] serialize friends (PR #146165)

2025-06-30 Thread Erick Velez via cfe-commits
evelez7 wrote: ### Merge activity * **Jun 30, 7:42 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/146165). https://github.com/llvm/llvm-project/pull/146165

[clang-tools-extra] a68e447 - [clang-doc] serialize friends (#146165)

2025-06-30 Thread via cfe-commits
Author: Erick Velez Date: 2025-06-30T12:43:52-07:00 New Revision: a68e4470c16b4d45f78b6f69f59013c89bdf7ec2 URL: https://github.com/llvm/llvm-project/commit/a68e4470c16b4d45f78b6f69f59013c89bdf7ec2 DIFF: https://github.com/llvm/llvm-project/commit/a68e4470c16b4d45f78b6f69f59013c89bdf7ec2.diff L

[clang] [Clang] Fix '-Wformat-overflow' FP when floats had field-width and plus prefix (PR #144274)

2025-06-30 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/144274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 96b9b2e - [Clang] Fix '-Wformat-overflow' FP when floats had field-width and plus prefix (#144274)

2025-06-30 Thread via cfe-commits
Author: Baranov Victor Date: 2025-06-30T22:43:47+03:00 New Revision: 96b9b2e21de466490ba733a23e8bb6cbd39ad58c URL: https://github.com/llvm/llvm-project/commit/96b9b2e21de466490ba733a23e8bb6cbd39ad58c DIFF: https://github.com/llvm/llvm-project/commit/96b9b2e21de466490ba733a23e8bb6cbd39ad58c.diff

[clang-tools-extra] [clang-doc] serialize friends (PR #146165)

2025-06-30 Thread Erick Velez via cfe-commits
https://github.com/evelez7 closed https://github.com/llvm/llvm-project/pull/146165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't use raw source location in DeclarationName, NFC (PR #146412)

2025-06-30 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/146412 Converting back and forth for the source location raw encoding is unnecessary. >From 21619dbe7f13c73c8657fac0410fe87ab8baeea4 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 30 Jun 2025 17:06:01 +0200 Subj

[clang] [clang] Don't use raw source location in DeclarationName, NFC (PR #146412)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes Converting back and forth for the source location raw encoding is unnecessary. --- Full diff: https://github.com/llvm/llvm-project/pull/146412.diff 1 Files Affected: - (modified) clang/include/clang/AST/Decl

[clang] [clang-tools-extra] [libcxx] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-30 Thread via cfe-commits
@@ -2767,6 +2767,10 @@ class DependentBitIntTypeLoc final : public InheritingConcreteTypeLoc {}; +class PredefinedSugarTypeLoc final +: public InheritingConcreteTypeLoc {}; YexuanXiao wrote: I've simplified its definition, and now it's similar to `BTF

[clang] 6bd9ff0 - [ARM] Add neon vector support for round

2025-06-30 Thread David Green via cfe-commits
Author: David Green Date: 2025-06-30T17:15:26+01:00 New Revision: 6bd9ff04afdfbef1cf753f2cdd8a4e85ef6685eb URL: https://github.com/llvm/llvm-project/commit/6bd9ff04afdfbef1cf753f2cdd8a4e85ef6685eb DIFF: https://github.com/llvm/llvm-project/commit/6bd9ff04afdfbef1cf753f2cdd8a4e85ef6685eb.diff L

[clang] [CodeGen] Remove an unnecessary cast (NFC) (PR #146380)

2025-06-30 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/146380 E is already of Expr * and shares the same declaration among all these cases. >From 3af2bd3b3743d16c45f759ecc38eaa0167e777d4 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 29 Jun 2025 12:15:46 -0

[clang] [Clang] Partially fix m68k alignments (PR #144740)

2025-06-30 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave approved this pull request. LGTM thanks. Sorry this PR slipped under my radar. Just a little bit more context: 68k GCC actually uses a different ABI than 68k's SysV ABI: https://m680x0.github.io/doc/abi#scalar-types . And we decided to implement GCC's ABI for now.

[clang] [CodeGen] Remove an unnecessary cast (NFC) (PR #146380)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes E is already of Expr * and shares the same declaration among all these cases. --- Full diff: https://github.com/llvm/llvm-project/pull/146380.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CG

[clang] [CodeGen] Remove an unnecessary cast (NFC) (PR #146380)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Kazu Hirata (kazutakahirata) Changes E is already of Expr * and shares the same declaration among all these cases. --- Full diff: https://github.com/llvm/llvm-project/pull/146380.diff 1 Files Affected: - (modified) clang/lib/Co

[clang] [Basic] Drop const from a return type (NFC) (PR #146382)

2025-06-30 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/146382 We don't need const on a return type. >From a43c0a81e99d409f8e7beb4c13be86accb57b3b6 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 29 Jun 2025 19:28:38 -0700 Subject: [PATCH] [Basic] Drop const

[clang] d1ba269 - [LLVM][Clang] Enable strict mode for `getTrailingObjects` (#144930)

2025-06-30 Thread via cfe-commits
Author: Rahul Joshi Date: 2025-06-30T07:23:34-07:00 New Revision: d1ba2692ee523de2da502753e8e666d2ef530df3 URL: https://github.com/llvm/llvm-project/commit/d1ba2692ee523de2da502753e8e666d2ef530df3 DIFF: https://github.com/llvm/llvm-project/commit/d1ba2692ee523de2da502753e8e666d2ef530df3.diff L

[clang] [Clang][attr] Add cfi_salt attribute (PR #141846)

2025-06-30 Thread Bill Wendling via cfe-commits
@@ -3639,6 +3639,64 @@ make the function's CFI jump table canonical. See :ref:`the CFI documentation }]; } +def CFISaltDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +Use ``__attribute__((cfi_salt("")))`` on a function declaration, function ---

[clang] [llvm] [LLVM][Clang] Enable strict mode for `getTrailingObjects` (PR #144930)

2025-06-30 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/144930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][AArch64] Parse more features in getHostCPUFeatures (PR #146323)

2025-06-30 Thread Elvina Yakubova via cfe-commits
ElvinaYakubova wrote: Thank you! https://github.com/llvm/llvm-project/pull/146323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-30 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > Right, I don't see any semantic reason why `__builtin_cpu_is` or > `__builtin_cpu_supports` shouldn't be resolved statically if we have that > information on hand. `-mcpu` / `-march` are not usually sufficient for > folding `__builtin_cpu_is`, since those attributes just speci

[clang-tools-extra] 6a57af8 - [clang-tidy] Add flag to specify an alternative to std::forward (#138755)

2025-06-30 Thread via cfe-commits
Author: Dimitrije Dobrota Date: 2025-06-30T22:13:33+03:00 New Revision: 6a57af8d0367eb22e3da9fc0957d74cb2f61c45c URL: https://github.com/llvm/llvm-project/commit/6a57af8d0367eb22e3da9fc0957d74cb2f61c45c DIFF: https://github.com/llvm/llvm-project/commit/6a57af8d0367eb22e3da9fc0957d74cb2f61c45c.d

[clang-tools-extra] [clang-tidy] Add flag to specify an alternative to std::forward (PR #138755)

2025-06-30 Thread via cfe-commits
github-actions[bot] wrote: @DimitrijeDobrota Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with

[clang-tools-extra] [clang-tidy] Add flag to specify an alternative to std::forward (PR #138755)

2025-06-30 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/138755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] AMDGPU: Implement ds_atomic_async_barrier_arrive_b64/ds_atomic_barrier_arrive_rtn_b64 (PR #146409)

2025-06-30 Thread Changpeng Fang via cfe-commits
https://github.com/changpeng created https://github.com/llvm/llvm-project/pull/146409 These two instructions are supported by gfx1250. We define the instructions and implement the corresponding intrinsic and builtin. >From ea949512b4c2234dffad366cf782f6e5c62f37d7 Mon Sep 17 00:00:00 2001 Fro

[clang-tools-extra] [clang-tidy] Add flag to specify an alternative to std::move in cppcoreguidelines-rvalue-reference-param-not-moved (PR #138757)

2025-06-30 Thread Baranov Victor via cfe-commits
vbvictor wrote: Please fix merge conflicts that occurred after merge of `std::forward` PR https://github.com/llvm/llvm-project/pull/138757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [llvm] AMDGPU: Implement ds_atomic_async_barrier_arrive_b64/ds_atomic_barrier_arrive_rtn_b64 (PR #146409)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Changpeng Fang (changpeng) Changes These two instructions are supported by gfx1250. We define the instructions and implement the corresponding intrinsic and builtin. --- Patch is 20.34 KiB, truncated to 20.00 KiB below, full v

[clang] [llvm] AMDGPU: Implement ds_atomic_async_barrier_arrive_b64/ds_atomic_barrier_arrive_rtn_b64 (PR #146409)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Changpeng Fang (changpeng) Changes These two instructions are supported by gfx1250. We define the instructions and implement the corresponding intrinsic and builtin. --- Patch is 20.34 KiB, truncated to 20.00 KiB below, full version:

[clang-tools-extra] [clang-tidy] Add flag to specify an alternative to std::move in cppcoreguidelines-rvalue-reference-param-not-moved (PR #138757)

2025-06-30 Thread Dimitrije Dobrota via cfe-commits
https://github.com/DimitrijeDobrota updated https://github.com/llvm/llvm-project/pull/138757 >From 28723cca6270be1cb2ebaddc23e47b3a7b38e6a4 Mon Sep 17 00:00:00 2001 From: Dimitrije Dobrota Date: Tue, 6 May 2025 22:42:04 +0200 Subject: [PATCH 1/4] Add flag to specify an alternative to std::move

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/146390 >From 7c294619f38984e26264d25524f6f5e79397f297 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 30 Jun 2025 11:45:43 -0500 Subject: [PATCH 1/2] [STLForwardCompat] Implement llvm::type_identity, NFC

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/146390 >From 7c294619f38984e26264d25524f6f5e79397f297 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 30 Jun 2025 11:45:43 -0500 Subject: [PATCH 1/3] [STLForwardCompat] Implement llvm::type_identity, NFC

[clang] [clang-tools-extra] WIP: Extend SourceLocation to 64 bits. (PR #146314)

2025-06-30 Thread Haojian Wu via cfe-commits
hokein wrote: > Sorry for being dumb... how are we getting away with only storing 40 bits? > Does that not just artificially limit our source-location size for > statements? And, frankly, then our entire space? I guess 8 2x-increases in > source-location size are nice, but I was sort of hoping

[clang] [CIR] Implement ArraySubscript for ComplexType (PR #146283)

2025-06-30 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/146283 >From f3fabc1028cecff6d7833f8e92b41f4e340c44e8 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sun, 29 Jun 2025 20:05:05 +0200 Subject: [PATCH 1/2] [CIR] Implement ArraySubscript for ComplexType --- cla

[clang] [CodeGen] Remove an unnecessary cast (NFC) (PR #146380)

2025-06-30 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Precommit friends test (PR #146164)

2025-06-30 Thread Erick Velez via cfe-commits
https://github.com/evelez7 ready_for_review https://github.com/llvm/llvm-project/pull/146164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Precommit friends test (PR #146164)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/146164.diff 1 Files Affected: - (modified) clang-tools-extra/test/clang-doc/json/class.cpp (+41) ``diff diff --git a/clang-to

[clang-tools-extra] [clang-doc] mangle template specialization file names (PR #144617)

2025-06-30 Thread Erick Velez via cfe-commits
https://github.com/evelez7 closed https://github.com/llvm/llvm-project/pull/144617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang: Forward exception_model flag for bitcode inputs (PR #146342)

2025-06-30 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: (FWIW I have the alternative fix here: https://github.com/jansvoboda11/llvm-project/commit/45f21d8adec34fdc13e86d529a133189ec1b1d15; happy to create a PR after yours lands.) https://github.com/llvm/llvm-project/pull/146342 ___ cfe

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-30 Thread John McCall via cfe-commits
rjmccall wrote: > Slightly independently, cpu_supports might turn out a bit difficult to use, > at least for us (and I suspect other targets), as the feature definitions are > often ad hoc and sadly mutable. Hmm. Well, you get to define what feature names you recognize in `__builtin_cpu_suppo

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-30 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > Alex, can you talk about why your design decides to check for specific > builtins rather than building out the set of features supported by > `__builtin_cpu_supports`? I went into it a bit above without having seen your question (race condition I guess:) ), but to have it in

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

2025-06-30 Thread Maksim Ivanov via cfe-commits
https://github.com/emaxx-google closed https://github.com/llvm/llvm-project/pull/144796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

2025-06-30 Thread Maksim Ivanov via cfe-commits
emaxx-google wrote: Superseded by #146153. Thanks. https://github.com/llvm/llvm-project/pull/144796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Sema] Suggest [[noreturn]] for void functions that always throw (PR #146234)

2025-06-30 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. 1 nit, else this is ok. please make sure the comment gets added, but then feel free to merge. https://github.com/llvm/llvm-project/pull/146234 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-30 Thread via cfe-commits
@@ -2660,6 +2644,122 @@ void X86AsmPrinter::emitCallInstruction(const llvm::MCInst &MCI) { OutStreamer->emitInstruction(MCI, getSubtargetInfo()); } +// Checks whether a NOP is required after a CALL and inserts the NOP, if +// necessary. +void X86AsmPrinter::maybeEmitNopAfte

[clang] [Clang][CodeGen][X86] don't coerce int128 into `{i64,i64}` for SysV-like ABIs (PR #135230)

2025-06-30 Thread via cfe-commits
https://github.com/T0b1-iOS updated https://github.com/llvm/llvm-project/pull/135230 >From 36ee902227e66c24cd7de42ed6a26637f440b4a3 Mon Sep 17 00:00:00 2001 From: T0b1 Date: Thu, 10 Apr 2025 19:16:00 +0200 Subject: [PATCH 1/4] [Clang][CodeGen][X86] don't coerce int128 into `{i64,i64}` for SysV

[clang] [llvm] [openmp] [OpenMP][clang] 6.0: codegen+runtime for num_threads strict (PR #146346)

2025-06-30 Thread Robert Imschweiler via cfe-commits
@@ -1214,6 +1214,12 @@ void __kmp_serialized_parallel(ident_t *loc, kmp_int32 global_tid) { // Reset for next parallel region this_thr->th.th_set_proc_bind = proc_bind_default; + // OpenMP 6.0 12.1.2 requires the num_threads 'strict' modifier to also have + // effect wh

[clang] [clang] Fix broken autocomplete test (PR #146326)

2025-06-30 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I landed it in https://github.com/llvm/llvm-project/commit/5186d4aeeeca56a77404c2842e494524b7cdd4ba https://github.com/llvm/llvm-project/pull/146326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [clang] Fix broken autocomplete test (PR #146326)

2025-06-30 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/146326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] WIP: Extend SourceLocation to 64 bits. (PR #146314)

2025-06-30 Thread Haojian Wu via cfe-commits
hokein wrote: > I did a light pass of the 1st 1/4 of this or so. The smuggling back and forth > to raw-encoding seems strange? WHy are we doing that here? In this patch, to keep AST node size as small as possible, we're using 40 bits of `StmtBits` to store the SourceLocation, we need this back

[clang] [clang] [modules] Add err_main_in_named_module (PR #146247)

2025-06-30 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Didn't know it. I'll revert this. @ashwinbanwari it looks like you need to remove the diagnostics with `extern "C++" main` and apply it with libc++ and land this finally. https://github.com/llvm/llvm-project/pull/146247 ___ cfe-com

[clang] [clang-tools-extra] WIP: Extend SourceLocation to 64 bits. (PR #146314)

2025-06-30 Thread Haojian Wu via cfe-commits
@@ -742,8 +742,12 @@ class CXXBoolLiteralExpr : public Expr { SourceLocation getBeginLoc() const { return getLocation(); } SourceLocation getEndLoc() const { return getLocation(); } - SourceLocation getLocation() const { return CXXBoolLiteralExprBits.Loc; } - void setLoc

[clang-tools-extra] [clang-tidy] Add flag to specify an alternative to std::move in cppcoreguidelines-rvalue-reference-param-not-moved (PR #138757)

2025-06-30 Thread Dimitrije Dobrota via cfe-commits
https://github.com/DimitrijeDobrota updated https://github.com/llvm/llvm-project/pull/138757 >From 28723cca6270be1cb2ebaddc23e47b3a7b38e6a4 Mon Sep 17 00:00:00 2001 From: Dimitrije Dobrota Date: Tue, 6 May 2025 22:42:04 +0200 Subject: [PATCH 1/3] Add flag to specify an alternative to std::move

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-30 Thread John McCall via cfe-commits
rjmccall wrote: > > On a different point: I don't think this builtin is actually semantically > > different from `__builtin_cpu_is`. As long as we're not treating it as > > `constexpr`, the fact that it's lowered by the compiler and doesn't need a > > runtime check is just a happy property of

[clang] [alpha.webkit.UncountedCallArgsChecker] Treat CFEqual as a safe function (PR #146369)

2025-06-30 Thread Ryosuke Niwa via cfe-commits
@@ -0,0 +1,11 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s + rniwa wrote: You wanna add: ``` // expected-no-diagnostics ``` https://github.com/llvm/llvm-project/pull/146369 ___

[clang] [Clang][CodeGen][X86] don't coerce int128 into `{i64,i64}` for SysV-like ABIs (PR #135230)

2025-06-30 Thread via cfe-commits
@@ -2595,6 +2595,14 @@ GetX86_64ByValArgumentPair(llvm::Type *Lo, llvm::Type *Hi, ABIArgInfo X86_64ABIInfo:: classifyReturnType(QualType RetTy) const { + // return int128 as i128 + if (const BuiltinType *BT = RetTy->getAs()) { +BuiltinType::Kind k = BT->getKind(); +

[clang] [llvm] [RISCV] Added the MIPS prefetch extensions for MIPS RV64 P8700. (PR #145647)

2025-06-30 Thread Craig Topper via cfe-commits
@@ -2742,6 +2742,9 @@ bool RISCVInstrInfo::verifyInstruction(const MachineInstr &MI, case RISCVOp::OPERAND_UIMM9_LSB000: Ok = isShiftedUInt<6, 3>(Imm); break; +case RISCVOp::OPERAND_UIMM9: topperc wrote: This is still unres

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-30 Thread John McCall via cfe-commits
rjmccall wrote: Alex, can you talk about why your design decides to check for specific builtins rather than building out the set of features supported by `__builtin_cpu_supports`? https://github.com/llvm/llvm-project/pull/134016 ___ cfe-commits maili

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-adt Author: Krzysztof Parzyszek (kparzysz) Changes A basic implementation until we get it in `std` in C++20. --- Full diff: https://github.com/llvm/llvm-project/pull/146390.diff 2 Files Affected: - (modified) clang/inc

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-30 Thread Dmitry Sidorov via cfe-commits
MrSidims wrote: Let me add my few cents here. > In the case where the target features are known during clang codegen, > lowering is easy: you just skip generating the bodies of the if statements > that don't match. If you want to some kind of "runtime" (actual runtime, or > SPIR-V compilation

[clang] efc561c - [CodeGen] Remove an unnecessary cast (NFC) (#146380)

2025-06-30 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-06-30T10:11:07-07:00 New Revision: efc561c061bc15036f923f5b0b24133be54a6395 URL: https://github.com/llvm/llvm-project/commit/efc561c061bc15036f923f5b0b24133be54a6395 DIFF: https://github.com/llvm/llvm-project/commit/efc561c061bc15036f923f5b0b24133be54a6395.diff L

[clang] [CodeGen] Remove an unnecessary cast (NFC) (PR #146380)

2025-06-30 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/146380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add flag to specify an alternative to std::forward (PR #138755)

2025-06-30 Thread Dimitrije Dobrota via cfe-commits
https://github.com/DimitrijeDobrota updated https://github.com/llvm/llvm-project/pull/138755 >From b6d3a401284022bca317079154764c80b18dcbdd Mon Sep 17 00:00:00 2001 From: Dimitrije Dobrota Date: Tue, 6 May 2025 22:18:43 +0200 Subject: [PATCH 1/3] Add flag to specify an alternative to std::forwa

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/146390 A basic implementation until we get it in `std` in C++20. >From 7c294619f38984e26264d25524f6f5e79397f297 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 30 Jun 2025 11:45:43 -0500 Subject: [PATCH

[clang] [HLSL] Remove dead code in Type.cpp [NFC] (PR #146365)

2025-06-30 Thread Steven Perron via cfe-commits
s-perron wrote: The test failures are unrelated to this change. https://github.com/llvm/llvm-project/pull/146365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] de7c2f2 - [HLSL] Remove dead code in Type.cpp [NFC] (#146365)

2025-06-30 Thread via cfe-commits
Author: Steven Perron Date: 2025-06-30T13:31:27-04:00 New Revision: de7c2f29405ff08a91a34bc0f152cfa1cd0d9801 URL: https://github.com/llvm/llvm-project/commit/de7c2f29405ff08a91a34bc0f152cfa1cd0d9801 DIFF: https://github.com/llvm/llvm-project/commit/de7c2f29405ff08a91a34bc0f152cfa1cd0d9801.diff

[clang] [HLSL] Remove dead code in Type.cpp [NFC] (PR #146365)

2025-06-30 Thread Steven Perron via cfe-commits
https://github.com/s-perron closed https://github.com/llvm/llvm-project/pull/146365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Fix typeof handling in enum declarations (PR #146394)

2025-06-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/146394 We have a parsing helper function which parses either a parenthesized expression or a parenthesized type name. This is used when parsing a unary operator such as sizeof, for example. The problem this solv

[clang] [C23] Fix typeof handling in enum declarations (PR #146394)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes We have a parsing helper function which parses either a parenthesized expression or a parenthesized type name. This is used when parsing a unary operator such as sizeof, for example. The problem this

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-30 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > Let me add my few cents here. > > > In the case where the target features are known during clang codegen, > > lowering is easy: you just skip generating the bodies of the if statements > > that don't match. If you want to some kind of "runtime" (actual runtime, or > > SPIR-V

[clang] [Basic] Drop const from a return type (NFC) (PR #146382)

2025-06-30 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/146382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] 'update' construct lowering + a few clauses (PR #146378)

2025-06-30 Thread Valentin Clement バレンタイン クレメン via cfe-commits
https://github.com/clementval approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0494f93 - [Basic] Drop const from a return type (NFC) (#146382)

2025-06-30 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-06-30T10:42:31-07:00 New Revision: 0494f934345f105f01f01a111c1f9f529acd26f5 URL: https://github.com/llvm/llvm-project/commit/0494f934345f105f01f01a111c1f9f529acd26f5 DIFF: https://github.com/llvm/llvm-project/commit/0494f934345f105f01f01a111c1f9f529acd26f5.diff L

[clang] [Basic] Drop const from a return type (NFC) (PR #146382)

2025-06-30 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/146382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-30 Thread Joseph Huber via cfe-commits
jhuber6 wrote: High liklihood that I'll need something similar for my GPU libraries so I'd prefer something not explicitly tied to SPIR-V. https://github.com/llvm/llvm-project/pull/134016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [mlir] [OpenACC][CIR] Implement 'rest' of update clause lowering (PR #146414)

2025-06-30 Thread Valentin Clement バレンタイン クレメン via cfe-commits
https://github.com/clementval approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Handle consteval constructors with default initialization. (PR #144970)

2025-06-30 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: ActOnCXXExitDeclInitializer does three things: - Some scope handling which isn't relevant in this context. - Does some special handling for variables, to compute whether the variable's initializer is manifestly constant-evaluated. - Calls PopExpressionEvaluationContext The

[clang] Reapply "[cmake] Refactor clang unittest cmake" (PR #134195)

2025-06-30 Thread Reid Kleckner via cfe-commits
rnk wrote: > Do I understand correctly that, as a result of this commit, the SemaTests > target no longer exists, and to work on / run the tests that it used to > include (such as HeuristicResolverTest.cpp), I have to build the > ClangdUnitTests target, which requires building 1000+ test sourc

[clang] f205e35 - [CIR] Upstream GenericSelectionExpr for ComplexType (#146265)

2025-06-30 Thread via cfe-commits
Author: Amr Hesham Date: 2025-06-30T22:25:01+02:00 New Revision: f205e354ae3e002158060c830778d8c5409a9984 URL: https://github.com/llvm/llvm-project/commit/f205e354ae3e002158060c830778d8c5409a9984 DIFF: https://github.com/llvm/llvm-project/commit/f205e354ae3e002158060c830778d8c5409a9984.diff LO

[clang] [CIR] Upstream GenericSelectionExpr for ComplexType (PR #146265)

2025-06-30 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/146265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross` running on `suse-gary-m68k-cross` while building `clang,llvm` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/12328 Here is the relevant p

[clang] [CodeGen] Remove unnecessary casts (NFC) (PR #146463)

2025-06-30 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/146463 Both of these functions return void. >From ad23a71d5148d200f1db8c307ca3d60d1c229a56 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 30 Jun 2025 10:15:12 -0700 Subject: [PATCH] [CodeGen] Remove unn

[clang] [llvm] [RISCV] Added the MIPS prefetch extensions for MIPS RV64 P8700. (PR #145647)

2025-06-30 Thread via cfe-commits
https://github.com/ukalappa-mips edited https://github.com/llvm/llvm-project/pull/145647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-06-30 Thread Yaxun Liu via cfe-commits
@@ -635,5 +635,66 @@ TARGET_BUILTIN(__builtin_amdgcn_bitop3_b16, "IUi", "nc", "bitop3-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_bf16_f32, "V2yV2yfUiIb", "nc", "f32-to-f16bf16-cvt-sr-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_f16_f32, "V2hV2hfUiIb", "nc", "f32-to-

[clang] [llvm] [RISCV] Added the MIPS prefetch extensions for MIPS RV64 P8700. (PR #145647)

2025-06-30 Thread via cfe-commits
https://github.com/ukalappa-mips edited https://github.com/llvm/llvm-project/pull/145647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analysis] Use range-based for loops (NFC) (PR #146466)

2025-06-30 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/146466 None >From 1480b40e0ea317111b432465493b746c10706ffc Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 29 Jun 2025 12:27:42 -0700 Subject: [PATCH] [Analysis] Use range-based for loops (NFC) --- clan

[clang] [Analysis] Use range-based for loops (NFC) (PR #146466)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/146466.diff 7 Files Affected: - (modified) clang/include/clang/Analysis/CFG.h (+3-4) - (modified) clang/lib/Analysis/CFG.cpp (+2-3) - (modi

[clang] ce159d2 - [RISCV] Put REQUIRES: riscv-registered-target in the first line of the file. NFC.

2025-06-30 Thread Jim Lin via cfe-commits
Author: Jim Lin Date: 2025-07-01T12:18:16+08:00 New Revision: ce159d20e52add25e51f2aa8c504726221b204ba URL: https://github.com/llvm/llvm-project/commit/ce159d20e52add25e51f2aa8c504726221b204ba DIFF: https://github.com/llvm/llvm-project/commit/ce159d20e52add25e51f2aa8c504726221b204ba.diff LOG:

[clang] [libcxx] [clang] [modules] Implement P3618R0: Allow attaching main to the global module (PR #146461)

2025-06-30 Thread Ashwin Banwari via cfe-commits
https://github.com/ashwinbanwari updated https://github.com/llvm/llvm-project/pull/146461 >From 845f99834c6c9a78c05396a0337051273b1ae138 Mon Sep 17 00:00:00 2001 From: Ashwin Banwari Date: Mon, 30 Jun 2025 20:45:39 -0700 Subject: [PATCH 1/4] Implement P3618R0 --- clang/docs/ReleaseNotes.rst

[clang] [libcxx] [clang] [modules] Implement P3618R0: Allow attaching main to the global module (PR #146461)

2025-06-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD libcxx/utils/libcxx/test/features.py `` View the diff from darke

[clang] WIP: fix assert in hasInitWithSideEffects (PR #146468)

2025-06-30 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn created https://github.com/llvm/llvm-project/pull/146468 This fixes another instance of `Assertion failed: (NumCurrentElementsDeserializing == 0 && "should not be called while already deserializing")`. I ran into it while importing clang modules from Swift, but I h

[clang] WIP: fix assert in hasInitWithSideEffects (PR #146468)

2025-06-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Henrik G. Olsson (hnrklssn) Changes This fixes another instance of `Assertion failed: (NumCurrentElementsDeserializing == 0 && "should not be called while already deserializing")`. I ran into it while importing clang modules from Swift,

[clang] [RISCV] Add missing intrinsicis vrgatherei16/vslideup/vslidedown support for Zvfbfmin (PR #146309)

2025-06-30 Thread Jim Lin via cfe-commits
tclin914 wrote: > > LLVM IR intrinsicis for vrgatherei16/vslideup/vslidedown have been > > supported. > > Sorry, I found LLVM IR intrinsicis for vrgatherei16/vslideup/vslidedown > actually haven't been supported. LLVM IR intrinsicis for vrgatherei16/vslideup/vslidedown have been supported no

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-06-30 Thread via cfe-commits
https://github.com/sivadeilra updated https://github.com/llvm/llvm-project/pull/144745 >From 2bd3af28675d0033b92ea0b1c976aa47026b1e98 Mon Sep 17 00:00:00 2001 From: Arlie Davis Date: Fri, 13 Jun 2025 12:45:34 -0700 Subject: [PATCH] Fix IP2State tables style: revert one change Adjust tests ad

<    1   2   3   4   5   >