[clang] Revert "[HIP] use offload wrapper for non-device-only non-rdc (#132869)" (PR #143432)

2025-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes This breaks a lot of new driver HIP compilation. We should probably revert this for now until we can make a fixed version. ```c++ static __global__ void print() { printf("%s\n", "foo"); } void b();

[clang] [llvm] [AArch64TargetParser]Fix reconstructFromParsedFeatures ignoring negative features (PR #142236)

2025-06-09 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: > The original situation looks something like: > > ``` > #include > > void foo() { >// ... >uint8x16_t x = {}; >vreinterpretq_u8_s8(x); > } > ``` > > Compiled with `clang -target aarch64-redhat-linux-gnu > -march=-march=armv9-a+sve2+fp16+fp16fml+crypto+bf16+sm4+i8

[clang] Remove delayed typo expressions (PR #143423)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -1,29 +0,0 @@ -// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s -// Don't crash (PR13394). efriedma-quic wrote: Is this just not worth keeping because it's strongly connected to delayed typo correction? Or did this move? https://github.com/llvm/llvm-p

[clang] Remove delayed typo expressions (PR #143423)

2025-06-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/143423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove delayed typo expressions (PR #143423)

2025-06-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: Briefly looked over the test changes. Mostly seems fine, but it seems like we're losing typo correction in a few places that don't seem related to delayed typo correction, at least at first glance. https://github.com/llvm/llvm-project/pull/143423 __

[clang] Remove delayed typo expressions (PR #143423)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -58,10 +58,8 @@ struct Base { }; struct Derived final : Base { - virtual ~Derived() = defaul; // #default + virtual ~Derived() = defaul; // expected-error {{use of undeclared identifier 'defaul'}} efriedma-quic wrote: I would sort of expect us to try to

[clang] Remove delayed typo expressions (PR #143423)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -649,12 +647,12 @@ class AddObservation { // expected-note {{declared here}} namespace testNonStaticMemberHandling { struct Foo { - bool usesMetadata; // expected-note {{'usesMetadata' declared here}} + bool usesMetadata; }; int test(Foo f) { if (UsesMetadata) // e

[clang] Remove delayed typo expressions (PR #143423)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -1888,10 +1888,11 @@ namespace PR15884 { } namespace AfterError { - constexpr int error() { + constexpr int error() { // pre-cxx23-error {{no return statement in constexpr function}} efriedma-quic wrote: It would be nice to suppress this diagnostic: if

[clang] Remove delayed typo expressions (PR #143423)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -207,7 +207,7 @@ namespace PR15045 { // Show that recovery has happened by also triggering typo correction e->Func(); // expected-error {{member reference type 'bar' is not a pointer; did you mean to use '.'?}} \ -// expected-error {{no member name

[clang] [SPIRV] enable and copy device implementation for logb and scalbn builtins (PR #143431)

2025-06-09 Thread via cfe-commits
https://github.com/choikwa created https://github.com/llvm/llvm-project/pull/143431 Copied from previous AMDGPU implementation #77de8a0 >From 304ce3e865dc407133ff67dc93e5562f7d163092 Mon Sep 17 00:00:00 2001 From: Kevin Choi Date: Mon, 9 Jun 2025 11:30:25 -0500 Subject: [PATCH] [SPIRV] enable

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/143433 We need to make sure we aren't vulnerable to [PYSEC-2020-73](https://osv.dev/vulnerability/PYSEC-2020-73) and [PYSEC-2019-41](https://osv.dev/vulnerability/PYSEC-2019-41). >From 4cfcb16f7680a31ff040de37dbd9de45

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,23 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir +// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-llvm %s -o %t-cir.ll +// RUN:

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -365,6 +422,19 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, if (isa(retCIRTy)) return getUndefRValue(retTy); switch (getEvaluationKind(retTy)) { + case cir::TEK_Aggregate: { +Address destPtr = returnValue.getValue(); + +if (!destPt

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,23 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir +// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-llvm %s -o %t-cir.ll +// RUN:

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -240,6 +284,43 @@ void AggExprEmitter::emitNullInitializationToLValue(mlir::Location loc, cgf.emitNullInitialization(loc, lv.getAddress(), lv.getType()); } +void AggExprEmitter::VisitCallExpr(const CallExpr *e) { + if (e->getCallReturnType(cgf.getContext())->isReference

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,23 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir +// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-llvm %s -o %t-cir.ll +// RUN:

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -60,6 +60,23 @@ CIRGenCallee CIRGenCallee::prepareConcreteCallee(CIRGenFunction &cgf) const { return *this; } +void CIRGenFunction::emitAggregateStore(mlir::Value value, Address dest) { + // In LLVM codegen: andykaylor wrote: ```suggestion // In clas

[clang] [Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (PR #142409)

2025-06-09 Thread via cfe-commits
https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/142409 >From c0cc666ab8864b665539a857dbdae6c592266227 Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Mon, 2 Jun 2025 10:21:22 +0100 Subject: [PATCH 1/8] [Frontend][PCH]-Add support for ignoring PCH options (-ignore

[clang] [flang] [mlir] [flang] Add support for -mrecip[=] (PR #143418)

2025-06-09 Thread Cameron McInally via cfe-commits
https://github.com/mcinally updated https://github.com/llvm/llvm-project/pull/143418 >From f4812aacb17aaf535f454c82e4ef29c5c9950a12 Mon Sep 17 00:00:00 2001 From: Cameron McInally Date: Mon, 9 Jun 2025 11:19:36 -0700 Subject: [PATCH 1/2] [flang] Add support for -mrecip[=] This patch adds suppo

[clang] f12e4f2 - [CIR][NFS] Add test cases for VecShuffle with -1 index (#143304)

2025-06-09 Thread via cfe-commits
Author: Amr Hesham Date: 2025-06-09T22:08:55+02:00 New Revision: f12e4f2faf404a7f44b5505b0a4c14e3a003d2d1 URL: https://github.com/llvm/llvm-project/commit/f12e4f2faf404a7f44b5505b0a4c14e3a003d2d1 DIFF: https://github.com/llvm/llvm-project/commit/f12e4f2faf404a7f44b5505b0a4c14e3a003d2d1.diff LO

[clang] [CIR][NFS] Add test cases for VecShuffle with -1 index (PR #143304)

2025-06-09 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/143304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIRV] enable and copy device implementation for logb and scalbn builtins (PR #143431)

2025-06-09 Thread via cfe-commits
https://github.com/choikwa edited https://github.com/llvm/llvm-project/pull/143431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-09 Thread via cfe-commits
sivadeilra wrote: @efriedma-quic This latest change should address your feedback around idioms like `&g_foo[10]`. https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [CIR] Add support for accessing members of base classes (PR #143195)

2025-06-09 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/143195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6559831 - [CIR] Add support for accessing members of base classes (#143195)

2025-06-09 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-06-09T13:11:12-07:00 New Revision: 6559831025711a21fd1f6a4065c4f3ac53f16875 URL: https://github.com/llvm/llvm-project/commit/6559831025711a21fd1f6a4065c4f3ac53f16875 DIFF: https://github.com/llvm/llvm-project/commit/6559831025711a21fd1f6a4065c4f3ac53f16875.diff L

[clang] Add sycl_external attribute (PR #140282)

2025-06-09 Thread via cfe-commits
https://github.com/schittir updated https://github.com/llvm/llvm-project/pull/140282 >From abdbf8905d324f9b935b34bbc97c508ede5ac028 Mon Sep 17 00:00:00 2001 From: "Chittireddy, Sindhu" Date: Fri, 16 May 2025 08:51:06 -0700 Subject: [PATCH 1/7] Add sycl_external attribute --- clang/include/cla

[clang] [Clang] Link libgcc_s.1.dylib when building for macOS 10.5 and older (PR #141401)

2025-06-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-asan` running on `sanitizer-buildbot8` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/9304 Here is the releva

[clang-tools-extra] [llvm] [llvm][ADT] Add wrappers to `std::includes` (PR #143297)

2025-06-09 Thread Longsheng Mou via cfe-commits
@@ -1881,6 +1881,19 @@ OutputIt move(R &&Range, OutputIt Out) { return std::move(adl_begin(Range), adl_end(Range), Out); } +/// Provide wrappers to std::includes which take ranges instead of having to +/// pass begin/end explicitly. +template bool includes(R1 &&Range1, R2 &

[clang] [Clang] Clarify the `[[trivial_abi]]` documentation. (PR #143243)

2025-06-09 Thread Shafik Yaghmour via cfe-commits
@@ -4431,7 +4431,11 @@ destroy the object before returning. The lifetime of the copy of the parameter in the caller ends without a destructor call when the call begins. If a type is trivial for the purpose of calls, it is assumed to be trivially -relocatable for the purpose o

[clang] [Clang] Clarify the `[[trivial_abi]]` documentation. (PR #143243)

2025-06-09 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/143243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Refactor AutoConvert.h to remove large MVS guard (PR #143174)

2025-06-09 Thread via cfe-commits
@@ -25,6 +26,16 @@ #define CCSID_UTF_8 1208 #define CCSID_ISO8859_1 819 +#ifndef STDIN_FILENO +#define STDIN_FILENO 0 +#endif +#ifndef STDOUT_FILENO +#define STDOUT_FILENO 1 +#endif +#ifndef STDERR_FILENO +#define STDERR_FILENO 2 +#endif tltao wrote: Why do w

[clang] [Clang] Implement CWG2496 (PR #142975)

2025-06-09 Thread Corentin Jabot via cfe-commits
@@ -215,3 +215,32 @@ void (*q)() throw() = S(); // since-cxx17-error@-1 {{no viable conversion from 'S' to 'void (*)() throw()'}} // since-cxx17-note@#cwg2486-conv {{candidate function}} } // namespace cwg2486 + + +namespace cwg2496 { // cwg2496: 21 +#if __cplusplus >= 20110

[clang] [Clang] Implement CWG2496 (PR #142975)

2025-06-09 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/142975 >From d4294fbb02932ec8b1870ac2960856bbbf299eb5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 5 Jun 2025 16:15:33 +0200 Subject: [PATCH 1/4] [Clang] Implement CWG2496 https://cplusplus.github.io/CWG/

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-09 Thread Morris Hafner via cfe-commits
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/142981 >From 939ad27d0d0dacc5b796e36ca9bca32d26f6b714 Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Mon, 9 Jun 2025 14:52:55 +0200 Subject: [PATCH 1/4] [CIR] Upstream minimal builtin function call support This patch

[clang] [ARM] enable FENV_ACCESS pragma support for hard-float targets (PR #137101)

2025-06-09 Thread Erik Enikeev via cfe-commits
https://github.com/Varnike updated https://github.com/llvm/llvm-project/pull/137101 >From 1b9b2011bbd9ac1ac38d631da83932aa11a01d29 Mon Sep 17 00:00:00 2001 From: Erik Enikeev Date: Mon, 9 Jun 2025 12:08:15 -0400 Subject: [PATCH] Added support for FENV_ACCESS pragma on hard-float ARM platforms.

[clang] [CIR] Upstream CreateOp for ComplexType with folder (PR #143192)

2025-06-09 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/143192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
@@ -110,20 +110,81 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } +static bool hasGCCToolChainAlongSideClang(const Driver &D) { + SmallString<128> GCCDir; + llvm::sys::path::append(GCCDir, D.Dir, "..", D.g

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
quic-garvgupt wrote: > I've done another review pass. Mostly some small stylistic comments. > > I'm finding it difficult to follow the code with the various different > code-paths with similar names. I've made some suggestions on renaming. We may > also be able to add some more comments to mak

[clang] [llvm] [SystemZ][z/OS] Refactor AutoConvert.h to remove large MVS guard (PR #143174)

2025-06-09 Thread Abhina Sree via cfe-commits
@@ -25,6 +26,16 @@ #define CCSID_UTF_8 1208 #define CCSID_ISO8859_1 819 +#ifndef STDIN_FILENO +#define STDIN_FILENO 0 +#endif +#ifndef STDOUT_FILENO +#define STDOUT_FILENO 1 +#endif +#ifndef STDERR_FILENO +#define STDERR_FILENO 2 +#endif abhina-sree wrote: Th

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt updated https://github.com/llvm/llvm-project/pull/121829 >From 0ffc48d7367a37a9a02333456a9dbfc20ab9e71f Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Fri, 13 Dec 2024 05:31:56 -0800 Subject: [PATCH] [Driver] Teach Barmetal toolchain about GCC installation T

[clang] [Clang] Implement CWG2496 (PR #142975)

2025-06-09 Thread Vlad Serebrennikov via cfe-commits
@@ -215,3 +215,32 @@ void (*q)() throw() = S(); // since-cxx17-error@-1 {{no viable conversion from 'S' to 'void (*)() throw()'}} // since-cxx17-note@#cwg2486-conv {{candidate function}} } // namespace cwg2486 + + +namespace cwg2496 { // cwg2496: 21 +#if __cplusplus >= 20110

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [CIR] Implement folder for VecShuffleOp (PR #143260)

2025-06-09 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/143260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIRV] Use resource names (PR #143412)

2025-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Steven Perron (s-perron) Changes --- Patch is 46.79 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/143412.diff 21 Files Affected: - (modified) clang/lib/CodeGen/CGHLSLRuntime.cpp (+2-2) -

[clang] [CIR][NFS] Add test cases for VecShuffle with -1 index (PR #143304)

2025-06-09 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/143304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][flang-driver] Support flag -finstrument-functions (PR #137996)

2025-06-09 Thread Anchu Rajendran S via cfe-commits
anchuraj wrote: > Hi @anchuraj! Nice patch! Are you interesting in extending the front-end > handling to support: > > ``` > -finstrument-functions-exclude-function-list=sym,sym,... > ``` > > ``` > -finstrument-functions-exclude-file-list=file,file,... > ``` > > In my experience, if found that

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt updated https://github.com/llvm/llvm-project/pull/121829 >From c4d61f3eafe108d705a67a9b8b7ca640119afe78 Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Fri, 13 Dec 2024 05:31:56 -0800 Subject: [PATCH] [Driver] Teach Barmetal toolchain about GCC installation T

[clang] [CIR] Implement folder for VecCreateOp (PR #143355)

2025-06-09 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/143355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-09 Thread Garvit Gupta via cfe-commits
quic-garvgupt wrote: Hi @petrhosek, while petrsmith is reviewing this PR, if you don’t have any further suggestions, comments, or feedback, could you please provide an LGTM? That would help us proceed with merging the PR promptly once petr approves it. Thanks so much! https://github.com/llvm/

[clang] [CIR] Implement folder for VecCreateOp (PR #143355)

2025-06-09 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor commented: Can you add a test that directly verifies this folder? https://github.com/llvm/llvm-project/pull/143355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [CIR] Implement folder for VecCreateOp (PR #143355)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -1533,6 +1533,17 @@ LogicalResult cir::GetMemberOp::verify() { // VecCreateOp //===--===// +OpFoldResult cir::VecCreateOp::fold(FoldAdaptor adaptor) { + auto elements = getElements(); and

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -1589,25 +1589,74 @@ namespace { void EmitConditionalDtorDeleteCall(CodeGenFunction &CGF, llvm::Value *ShouldDeleteCondition, bool ReturnAfterDelete) { +const CXXDestructorDecl *Dtor = cast(CGF.C

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -2885,6 +2886,16 @@ class CXXDestructorDecl : public CXXMethodDecl { return getCanonicalDecl()->OperatorDelete; } + const FunctionDecl *getOperatorGlobalDelete() const { +return getCanonicalDecl()->OperatorGlobalDelete; + } + + void setOperatorGlobalDelete(Func

[clang] [WebKit checkers] Treat passing of a member variable which is capable of CheckedPtr as safe. (PR #142485)

2025-06-09 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: Thank you for the review! https://github.com/llvm/llvm-project/pull/142485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e5fa38b - [WebKit checkers] Treat passing of a member variable which is capable of CheckedPtr as safe. (#142485)

2025-06-09 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2025-06-09T07:32:15-07:00 New Revision: e5fa38b02bb7c769347a90b94a76aa0accc1e819 URL: https://github.com/llvm/llvm-project/commit/e5fa38b02bb7c769347a90b94a76aa0accc1e819 DIFF: https://github.com/llvm/llvm-project/commit/e5fa38b02bb7c769347a90b94a76aa0accc1e819.diff

[clang-tools-extra] [clang-tidy][NFC] run clang-format over clang-tidy checks and tool code. (PR #143324)

2025-06-09 Thread via cfe-commits
EugeneZelenko wrote: `polly` enforces formatting as part of build. Maybe same should be doe for Clang-Tidy? https://github.com/llvm/llvm-project/pull/143324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang-tools-extra] [llvm] [llvm][ADT] Add wrappers to `std::includes` (PR #143297)

2025-06-09 Thread Longsheng Mou via cfe-commits
@@ -1881,6 +1881,19 @@ OutputIt move(R &&Range, OutputIt Out) { return std::move(adl_begin(Range), adl_end(Range), Out); } +/// Provide wrappers to std::includes which take ranges instead of having to +/// pass begin/end explicitly. +template bool includes(R1 &&Range1, R2 &

[clang] [Clang] Clarify the `[[trivial_abi]]` documentation. (PR #143243)

2025-06-09 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/143243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Clarify the `[[trivial_abi]]` documentation. (PR #143243)

2025-06-09 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/143243 >From 9b6128211ea4a442ecded830c77c60387245bb89 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Sat, 7 Jun 2025 10:24:26 +0200 Subject: [PATCH 1/2] [Clang] Clarify the `[[trivial_abi]]` documentation. Fixes

[clang] [C23][N3006] Documented behavior of underspecified object declarations (PR #140911)

2025-06-09 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/140911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable WPD without lto (PR #141777)

2025-06-09 Thread Teresa Johnson via cfe-commits
teresajohnson wrote: > Hi @teresajohnson what do you think? For the case of PGO, I think we may > disable it. I think The speculative devirtualization is useful for cases > where we don't have enough information. Yes I think the spec results are promising. I'd suggest also trying with a large

[clang] [Clang] Explain why a type is not replaceable. (PR #143265)

2025-06-09 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/143265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 02f0f5c - [Clang] Explain why a type is not replaceable. (#143265)

2025-06-09 Thread via cfe-commits
Author: Corentin Jabot Date: 2025-06-09T17:05:25+02:00 New Revision: 02f0f5c3eccd1add188d0d1fb7207c0cb14e1190 URL: https://github.com/llvm/llvm-project/commit/02f0f5c3eccd1add188d0d1fb7207c0cb14e1190 DIFF: https://github.com/llvm/llvm-project/commit/02f0f5c3eccd1add188d0d1fb7207c0cb14e1190.diff

[clang-tools-extra] [llvm] [llvm][ADT] Add wrappers to `std::includes` (PR #143297)

2025-06-09 Thread Longsheng Mou via cfe-commits
@@ -1881,6 +1881,19 @@ OutputIt move(R &&Range, OutputIt Out) { return std::move(adl_begin(Range), adl_end(Range), Out); } +/// Provide wrappers to std::includes which take ranges instead of having to +/// pass begin/end explicitly. +template bool includes(R1 &&Range1, R2 &

[clang] [alpha.webkit.NoUnretainedMemberChecker] Recognize NS_REQUIRES_PROPERTY_DEFINITIONS (PR #141293)

2025-06-09 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/141293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable WPD without lto (PR #141777)

2025-06-09 Thread Hassnaa Hamdi via cfe-commits
hassnaaHamdi wrote: > > Hi @teresajohnson what do you think? For the case of PGO, I think we may > > disable it. I think The speculative devirtualization is useful for cases > > where we don't have enough information. > > Yes I think the spec results are promising. I'd suggest also trying with

[clang] [Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (PR #142409)

2025-06-09 Thread via cfe-commits
MaggieYingYi wrote: > This is missing a Release note, please add it before merging. Added in the commit https://github.com/MaggieYingYi/llvm-project/commit/8a7df93f999633b7e237714a83811f2000d8351e. @mizvekov, could you please help me review the release note? Thanks https://github.com/llvm/llv

[clang] [Clang] Non-polymorphic trivially relocatable types can have [[trivial_abi]] (PR #143111)

2025-06-09 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/143111 >From fa44f6d3b231409ea4f44119e77050c024af190c Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Fri, 6 Jun 2025 13:09:40 +0200 Subject: [PATCH 1/2] [Clang] Non-polymorphic trivially relocatable types can ha

[clang] [CIR] Implement folder for VecCreateOp (PR #143355)

2025-06-09 Thread Amr Hesham via cfe-commits
@@ -77,12 +77,8 @@ void foo() { // CIR: %[[VEC_F:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["f", init] // CIR: %[[VEC_G:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["g", init] // CIR: %[[VEC_H:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["h", ini

[clang] [clang-format] Handle templates in qualified typenames (PR #143194)

2025-06-09 Thread Ben Dunkin via cfe-commits
https://github.com/bdunkin updated https://github.com/llvm/llvm-project/pull/143194 >From 0168891771b3cdfc6f6305b046005fb335cbff01 Mon Sep 17 00:00:00 2001 From: Ben Dunkin Date: Fri, 6 Jun 2025 12:29:13 -0700 Subject: [PATCH] Fix identifiers not being marked as constructor/destructor names if

[clang] [Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (PR #142409)

2025-06-09 Thread Matheus Izvekov via cfe-commits
@@ -324,6 +324,8 @@ New Compiler Flags - New option ``-Wnrvo`` added and disabled by default to warn about missed NRVO opportunities. +- New option ``-ignore-pch`` added to disable precompiled headers, override ``-emit-pch`` and ``-include-pch`` (#GH142409, `PCHDocs

[clang] [CIR] Implement folder for VecShuffleOp (PR #143260)

2025-06-09 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/143260 >From 14ffd458c4896bd4d5fb73f97c5745db70c8360e Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 7 Jun 2025 14:43:16 +0200 Subject: [PATCH 1/4] [CIR] Implement folder for VecShuffleOp --- clang/inclu

[clang] [CIR] Extend VecShuffleOp verifier to catch invalid index (PR #143262)

2025-06-09 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/143262 >From 5f98861a88e544ec80bbaf5fe0ffb650c2d71e67 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 7 Jun 2025 14:57:53 +0200 Subject: [PATCH 1/3] [CIR] Extend VecShuffleOp verifier to catch invalid index

[clang] [Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (PR #142409)

2025-06-09 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. https://github.com/llvm/llvm-project/pull/142409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implicit resource binding for cbuffers (PR #139022)

2025-06-09 Thread Shafik Yaghmour via cfe-commits
@@ -539,19 +537,29 @@ static void initializeBuffer(CodeGenModule &CGM, llvm::GlobalVariable *GV, } static void initializeBufferFromBinding(CodeGenModule &CGM, -llvm::GlobalVariable *GV, unsigned Slot, -

[clang] [CIR] Upstream CreateOp for ComplexType with folder (PR #143192)

2025-06-09 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/143192 >From 0ee92db03198e2364ade53e5c0bbd0f844fe634f Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Fri, 6 Jun 2025 20:56:49 +0200 Subject: [PATCH 1/4] [CIR] Upstream CreateOp for ComplexType with folder ---

[clang] 59ef2c3 - [CUDA] Disallow use of address_space(N) on CUDA device variables. (#142857)

2025-06-09 Thread via cfe-commits
Author: Artem Belevich Date: 2025-06-09T10:39:04-07:00 New Revision: 59ef2c34a12ea53bb7fa386a598f1299ccc1f8d5 URL: https://github.com/llvm/llvm-project/commit/59ef2c34a12ea53bb7fa386a598f1299ccc1f8d5 DIFF: https://github.com/llvm/llvm-project/commit/59ef2c34a12ea53bb7fa386a598f1299ccc1f8d5.diff

[clang] [CUDA] Disallow use of address_space(N) on CUDA device variables. (PR #142857)

2025-06-09 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B closed https://github.com/llvm/llvm-project/pull/142857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][HLSL][DXIL] Move D3D12.h enums and flags to DXILABI (PR #143041)

2025-06-09 Thread Finn Plummer via cfe-commits
@@ -99,6 +99,128 @@ enum class SamplerFeedbackType : uint32_t { const unsigned MinWaveSize = 4; const unsigned MaxWaveSize = 128; +// Definition of the various d3d12.h enumerations and flags. The definitions of +// all values here correspond to their description in the d3d12.h

[clang] [CIR][NFC] Use actual operand name in adaptor-obtained operands (PR #143028)

2025-06-09 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/143028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][HLSL][DXIL] Move D3D12.h enums and flags to DXILABI (PR #143041)

2025-06-09 Thread Finn Plummer via cfe-commits
@@ -99,6 +99,128 @@ enum class SamplerFeedbackType : uint32_t { const unsigned MinWaveSize = 4; const unsigned MaxWaveSize = 128; +// Definition of the various d3d12.h enumerations and flags. The definitions of +// all values here correspond to their description in the d3d12.h

[clang] [flang] [llvm] [mlir] [DebugInfo][RemoveDIs] Rip out the UseNewDbgInfoFormat flag (PR #143207)

2025-06-09 Thread Jeremy Morse via cfe-commits
jmorse wrote: Removing the `--experimental-debuginfo-iterators` flag from 1 flang and 1 mlir test too -- the flag has been a dummy for a month and doesn't do anything, the extra RUNlines were just extra coverage for when intrinsic support was still feasible. https://github.com/llvm/llvm-proje

[clang] [Clang] Implement CWG2496 (PR #142975)

2025-06-09 Thread Vlad Serebrennikov via cfe-commits
@@ -215,3 +215,32 @@ void (*q)() throw() = S(); // since-cxx17-error@-1 {{no viable conversion from 'S' to 'void (*)() throw()'}} // since-cxx17-note@#cwg2486-conv {{candidate function}} } // namespace cwg2486 + + +namespace cwg2496 { // cwg2496: 21 +#if __cplusplus >= 20110

[clang] [llvm] [NFC][HLSL][DXIL] Move D3D12.h enums and flags to DXILABI (PR #143041)

2025-06-09 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/143041 >From e9d782af7335af47b83db3bffcc6b91a6465ee6f Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Thu, 5 Jun 2025 18:40:36 + Subject: [PATCH 1/6] move defs to DXILABI --- .../llvm/Frontend/HLSL/HLSLRootSign

[clang-tools-extra] Follow style configuration in clangd when inserting missing includes (PR #140594)

2025-06-09 Thread via cfe-commits
Harald-R wrote: Created https://github.com/llvm/llvm-project/pull/143411 to do the filtering based on the spelling instead of the resolved path. https://github.com/llvm/llvm-project/pull/140594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [llvm] [HLSL][SPIRV] Use resource names (PR #143412)

2025-06-09 Thread Steven Perron via cfe-commits
https://github.com/s-perron created https://github.com/llvm/llvm-project/pull/143412 None >From 20eb30e74884a8327f2f0fa7f357a1434347b0c4 Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Mon, 9 Jun 2025 12:53:06 -0400 Subject: [PATCH] [HLSL][SPIRV] Use resource names --- clang/lib/CodeGen/C

[clang] [C++20][Modules] Implement P1857R3 Modules Dependency Discovery (PR #107168)

2025-06-09 Thread via cfe-commits
yronglin wrote: friendly ping~ https://github.com/llvm/llvm-project/pull/107168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIRV] Use resource names (PR #143412)

2025-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Steven Perron (s-perron) Changes --- Patch is 46.79 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/143412.diff 21 Files Affected: - (modified) clang/lib/CodeGen/CGHLSLRuntime.cpp (+

[clang] [llvm] [HLSL][SPIRV] Use resource names (PR #143412)

2025-06-09 Thread Steven Perron via cfe-commits
https://github.com/s-perron updated https://github.com/llvm/llvm-project/pull/143412 >From fadeeac5a79cbae0edffbabbe383d7451c254afb Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Mon, 9 Jun 2025 12:53:06 -0400 Subject: [PATCH] [HLSL][SPIRV] Use resource names The SPIR-V backend does not ha

<    1   2   3   4   5   >