[clang] Thread Safety Analysis: Warn when using negative reentrant capability (PR #141599)

2025-06-05 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert commented: On a related note, do we emit `-Wthread-safety-negative` for reentrant locks? I don't remember that we carved out an exception for that, and we probably should. https://github.com/llvm/llvm-project/pull/141599 __

[clang] [clang][dep-scan] Resolve lexer crash from a permutation of invalid tokens (PR #142452)

2025-06-05 Thread Argyrios Kyrtzidis via cfe-commits
https://github.com/akyrtzi edited https://github.com/llvm/llvm-project/pull/142452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Thread Safety Analysis: Warn when using negative reentrant capability (PR #141599)

2025-06-05 Thread Aaron Puchert via cfe-commits
@@ -4222,6 +4222,11 @@ def warn_fun_requires_lock_precise : InGroup, DefaultIgnore; def note_found_mutex_near_match : Note<"found near match '%0'">; +// Pedantic thread safety warnings enabled by default +def warn_thread_reentrant_with_negative_capability : Warning< + "%0 i

[clang] [flang] [Driver] Move CommonArgs to a location visible by the Frontend Drivers (PR #142800)

2025-06-05 Thread Cameron McInally via cfe-commits
https://github.com/mcinally updated https://github.com/llvm/llvm-project/pull/142800 >From 918b853de8c43dacebecb42cafa6d3b8fec15b47 Mon Sep 17 00:00:00 2001 From: Cameron McInally Date: Tue, 3 Jun 2025 11:12:42 -0700 Subject: [PATCH 1/5] [Driver] Move CommonArgs to a location visible by the Fr

[clang] [clang][dep-scan] Resolve lexer crash from a permutation of invalid tokens (PR #142452)

2025-06-05 Thread Argyrios Kyrtzidis via cfe-commits
https://github.com/akyrtzi edited https://github.com/llvm/llvm-project/pull/142452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Implement member exprs for 'copy' lowering (PR #142998)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -226,6 +228,10 @@ class OpenACCClauseCIREmitter final mlir::Location exprLoc = cgf.cgm.getLoc(curVarExpr->getBeginLoc()); llvm::SmallVector bounds; +std::string exprString; +llvm::raw_string_ostream os(exprString); +e->printPretty(os, nullptr, cgf.getCon

[clang] [OpenACC][CIR] Implement member exprs for 'copy' lowering (PR #142998)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -754,12 +754,320 @@ void acc_compute(int parmVar) { // CHECK-NEXT: %[[ZERO_CONST:.*]] = arith.constant 0 : i64 // CHECK-NEXT: %[[ONE_CONST2:.*]] = arith.constant 1 : i64 // CHECK-NEXT: %[[BOUNDS3:.*]] = acc.bounds lowerbound(%[[ONE_CAST]] : si32) extent(%[[ONE_CAST2]]

[clang] [OpenACC][CIR] Implement member exprs for 'copy' lowering (PR #142998)

2025-06-05 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. Nice job with the testing! I had a moment of panic seeing the size of this change, only to find that it's mostly test cases. I have a couple of questions, but it looks good. https://github.com/llvm/llvm-project/pull/142998 _

[clang] [OpenACC][CIR] Implement member exprs for 'copy' lowering (PR #142998)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -754,12 +754,320 @@ void acc_compute(int parmVar) { // CHECK-NEXT: %[[ZERO_CONST:.*]] = arith.constant 0 : i64 // CHECK-NEXT: %[[ONE_CONST2:.*]] = arith.constant 1 : i64 // CHECK-NEXT: %[[BOUNDS3:.*]] = acc.bounds lowerbound(%[[ONE_CAST]] : si32) extent(%[[ONE_CAST2]]

[clang] [OpenACC][CIR] Implement member exprs for 'copy' lowering (PR #142998)

2025-06-05 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/142998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Implement member exprs for 'copy' lowering (PR #142998)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -226,6 +228,10 @@ class OpenACCClauseCIREmitter final mlir::Location exprLoc = cgf.cgm.getLoc(curVarExpr->getBeginLoc()); llvm::SmallVector bounds; +std::string exprString; +llvm::raw_string_ostream os(exprString); +e->printPretty(os, nullptr, cgf.getCon

[clang] [CIR] Implement folder for VecTernaryOp (PR #142946)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -138,10 +138,10 @@ void CIRCanonicalizePass::runOnOperation() { assert(!cir::MissingFeatures::complexRealOp()); assert(!cir::MissingFeatures::complexImagOp()); assert(!cir::MissingFeatures::callOp()); -// CastOp, UnaryOp, VecExtractOp and VecShuffleDynamicOp

[clang] [OpenACC][CIR] Implement member exprs for 'copy' lowering (PR #142998)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -754,12 +754,320 @@ void acc_compute(int parmVar) { // CHECK-NEXT: %[[ZERO_CONST:.*]] = arith.constant 0 : i64 // CHECK-NEXT: %[[ONE_CONST2:.*]] = arith.constant 1 : i64 // CHECK-NEXT: %[[BOUNDS3:.*]] = acc.bounds lowerbound(%[[ONE_CAST]] : si32) extent(%[[ONE_CAST2]]

[clang] [CIR] Implement folder for VecTernaryOp (PR #142946)

2025-06-05 Thread Amr Hesham via cfe-commits
@@ -138,10 +138,10 @@ void CIRCanonicalizePass::runOnOperation() { assert(!cir::MissingFeatures::complexRealOp()); assert(!cir::MissingFeatures::complexImagOp()); assert(!cir::MissingFeatures::callOp()); -// CastOp, UnaryOp, VecExtractOp and VecShuffleDynamicOp

[clang] [clang] Fixed Constant Evaluation don't Call Destructor (PR #140278)

2025-06-05 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/140278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 49386f4 - [Clang] Run destructors of variables declared in the second part of a `for` loop during constant evaluation (#140278)

2025-06-05 Thread via cfe-commits
Author: Vincent Date: 2025-06-05T23:50:20+02:00 New Revision: 49386f40dd66ababe9bfde64c14cf3bfba5774c1 URL: https://github.com/llvm/llvm-project/commit/49386f40dd66ababe9bfde64c14cf3bfba5774c1 DIFF: https://github.com/llvm/llvm-project/commit/49386f40dd66ababe9bfde64c14cf3bfba5774c1.diff LOG:

[clang] [CIR] Implement folder for VecTernaryOp (PR #142946)

2025-06-05 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/142946 >From ac8277b48d0affa78f5e5e943e0179c27dd033ec Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 5 Jun 2025 13:08:57 +0200 Subject: [PATCH 1/3] [CIR] Implement folder for VecTernaryOp --- clang/inclu

[clang] [OpenACC][CIR] Implement member exprs for 'copy' lowering (PR #142998)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -754,12 +754,320 @@ void acc_compute(int parmVar) { // CHECK-NEXT: %[[ZERO_CONST:.*]] = arith.constant 0 : i64 // CHECK-NEXT: %[[ONE_CONST2:.*]] = arith.constant 1 : i64 // CHECK-NEXT: %[[BOUNDS3:.*]] = acc.bounds lowerbound(%[[ONE_CAST]] : si32) extent(%[[ONE_CAST2]]

[clang] [llvm] Reland "[HLSL][RootSignature] Implement serialization of RootConstants and RootFlags" (PR #143019)

2025-06-05 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/143019 >From 2f7da28354a3c892ea11d1e2136a2a965996631a Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Thu, 29 May 2025 10:31:08 -0700 Subject: [PATCH 1/3] [HLSL][RootSignature] Implement serialization of `RootConsta

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-06-05 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Please call it "nested-namespaces" instead of "c++17". https://github.com/llvm/llvm-project/pull/124265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [StaticAnalyzer] Fix tryExpandAsInteger's failures on PCH macros (PR #142722)

2025-06-05 Thread Balazs Benics via cfe-commits
@@ -129,11 +129,19 @@ std::optional tryExpandAsInteger(StringRef Macro, const Preprocessor &PP) { // Parse an integer at the end of the macro definition. const Token &T = FilteredTokens.back(); - // FIXME: EOF macro token coming from a PCH file on macOS while marked as -

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr (PR #134188)

2025-06-05 Thread Baranov Victor via cfe-commits
@@ -39,21 +39,28 @@ intCastExpression(bool IsSigned, // std::cmp_{} functions trigger a compile-time error if either LHS or RHS // is a non-integer type, char, enum or bool // (unsigned char/ signed char are Ok and can be used). - auto IntTypeExpr = expr(hasType(hasCanon

[clang] [StaticAnalyzer] Fix tryExpandAsInteger's failures on PCH macros (PR #142722)

2025-06-05 Thread Ziqing Luo via cfe-commits
ziqingluo-90 wrote: Thank you for reviewing [steakhal](https://github.com/steakhal)! https://github.com/llvm/llvm-project/pull/142722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StaticAnalyzer] Fix tryExpandAsInteger's failures on PCH macros (PR #142722)

2025-06-05 Thread Balazs Benics via cfe-commits
steakhal wrote: FYI the CI checks are red, I don't think its related to this PR. It had this line: ``` 2025-06-05T08:01:02.4802924Z PASS: Clang :: Analysis/pch_macro.cpp (1263 of 21496) ``` So we should be good to merge, any time you want. https://github.com/llvm/llvm-project/pull/142722 __

[clang] Revert "[clang-repl] Ensure clang-repl accepts all C keywords supported in all language models (#142749) (PR #142933)

2025-06-05 Thread Anutosh Bhat via cfe-commits
anutosh491 wrote: Needed a revert as we added a test for running `_Float16` with clang-repl only to realize later that it should be conditionally ignored for platforms such as ppc64le and AIX https://github.com/llvm/llvm-project/pull/142933 ___ cfe-c

[libclc] [NFC][libclc] Simplify clc_dot and dot implementation (PR #142922)

2025-06-05 Thread Wenju He via cfe-commits
https://github.com/wenju-he created https://github.com/llvm/llvm-project/pull/142922 llvm-diff shows no change to amdgcn--amdhsa.bc >From 42c4efab1a163624d7a3b327742d7e38bb7197b3 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Thu, 5 Jun 2025 01:14:38 -0700 Subject: [PATCH] [NFC][libclc] Simplif

[clang] [llvm] [NFC][LLVM] Refactor IRBuilder::Create{VScale,ElementCount,TypeSize}. (PR #142803)

2025-06-05 Thread David Sherwood via cfe-commits
@@ -120,23 +120,30 @@ IRBuilderBase::createCallHelper(Function *Callee, ArrayRef Ops, return CI; } -Value *IRBuilderBase::CreateVScale(Constant *Scaling, const Twine &Name) { - assert(isa(Scaling) && "Expected constant integer"); - if (cast(Scaling)->isZero()) -return

[clang] [llvm] [NFC][LLVM] Refactor IRBuilder::Create{VScale,ElementCount,TypeSize}. (PR #142803)

2025-06-05 Thread David Sherwood via cfe-commits
@@ -120,23 +120,30 @@ IRBuilderBase::createCallHelper(Function *Callee, ArrayRef Ops, return CI; } -Value *IRBuilderBase::CreateVScale(Constant *Scaling, const Twine &Name) { - assert(isa(Scaling) && "Expected constant integer"); - if (cast(Scaling)->isZero()) -return

[clang] [llvm] [NFC][LLVM] Refactor IRBuilder::Create{VScale,ElementCount,TypeSize}. (PR #142803)

2025-06-05 Thread David Sherwood via cfe-commits
@@ -4793,11 +4793,7 @@ Value *CodeGenFunction::EmitAArch64SVEBuiltinExpr(unsigned BuiltinID, case SVE::BI__builtin_sve_svlen_u64: { SVETypeFlags TF(Builtin->TypeModifier); auto VTy = cast(getSVEType(TF)); david-arm wrote: nit: Is it worth strengthen

[clang] [clang-format] Handle requires clause following a pointer type (PR #142893)

2025-06-05 Thread Owen Pan via cfe-commits
owenca wrote: > For all sane code this works. Although there are valid codes where a star can > preceed a requires expression. Sure, but I think that's also true for the existing `tok::greater` and `tok::amp` cases. https://github.com/llvm/llvm-project/pull/142893

[clang] [StaticAnalyzer] Fix tryExpandAsInteger's failures on PCH macros (PR #142722)

2025-06-05 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/142722 >From 3bd12ac6bb3c47b5e977cffec019df15a15426fc Mon Sep 17 00:00:00 2001 From: Ziqing Luo Date: Wed, 4 Jun 2025 12:29:53 +0800 Subject: [PATCH 1/3] [StaticAnalyzer] Fix tryExpandAsInteger's failures on macros f

[clang] [StaticAnalyzer] Fix tryExpandAsInteger's failures on PCH macros (PR #142722)

2025-06-05 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/142722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StaticAnalyzer] Fix tryExpandAsInteger's failures on PCH macros (PR #142722)

2025-06-05 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. Looks great. Much cleaner this way. Thank you! FYI: I also proposed a slight declarative simplification to the RUN lines, I hope you like it. https://github.com/llvm/llvm-project/pull/142722 ___

[clang] [StaticAnalyzer] Fix tryExpandAsInteger's failures on PCH macros (PR #142722)

2025-06-05 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,45 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -x c++ -triple x86_64-apple-macosx10.15.0 -emit-pch -o %t/header.pch %t/header.h +// RUN: %clang_analyze_cc1 -triple x86_64-apple-macosx10.15.0 -include-pch %t/header.pch \ +

[clang] [Clang] Preserve CXXParenListInitExpr in TreeTransform. (PR #138518)

2025-06-05 Thread Alexander Kornienko via cfe-commits
alexfh wrote: > > @alexfh I don't have the resources to look into this issue. Please revert > > if you need to. > > This has been in trunk for a long time, a revert here would be HIGHLY > unfortunate. I would vastly prefer someone spend time trying to figure out > why we are confused with the

[libclc] [libclc] Add (fast) normalize to CLC; add half overloads (PR #139759)

2025-06-05 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/139759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] af82e50 - [CIR][NFCI] Update RValue class to reflect changes in classic CodeGen (#142779)

2025-06-05 Thread via cfe-commits
Author: Morris Hafner Date: 2025-06-05T11:06:09+02:00 New Revision: af82e50a77a2474d2ed5f209f3e29a2510fa9552 URL: https://github.com/llvm/llvm-project/commit/af82e50a77a2474d2ed5f209f3e29a2510fa9552 DIFF: https://github.com/llvm/llvm-project/commit/af82e50a77a2474d2ed5f209f3e29a2510fa9552.diff

[clang] [CIR][NFCI] Update RValue class to reflect changes in classic CodeGen (PR #142779)

2025-06-05 Thread Morris Hafner via cfe-commits
https://github.com/mmha closed https://github.com/llvm/llvm-project/pull/142779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Mark disambiguate-decl-stmt.cpp as UNSUPPORTED on ppc64le and AIX (PR #142923)

2025-06-05 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 converted_to_draft https://github.com/llvm/llvm-project/pull/142923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang-repl] Ensure clang-repl accepts all C keywords supported in all language models (#142749) (PR #142933)

2025-06-05 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 created https://github.com/llvm/llvm-project/pull/142933 This reverts commit 7ca7bcb7d8dcf26fc0281697fe47aa6cdb3884c0. >From 6652fcc6d8b61e66cae4dc05a4192c0668b1eb11 Mon Sep 17 00:00:00 2001 From: anutosh491 Date: Thu, 5 Jun 2025 14:31:53 +0530 Subject: [PATCH]

[clang] 599b2a3 - [CIR] Add support for derived class declarations (#142823)

2025-06-05 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-06-05T10:10:39-07:00 New Revision: 599b2a3475f1c40b34f2414e55de68c67ebe9d21 URL: https://github.com/llvm/llvm-project/commit/599b2a3475f1c40b34f2414e55de68c67ebe9d21 DIFF: https://github.com/llvm/llvm-project/commit/599b2a3475f1c40b34f2414e55de68c67ebe9d21.diff L

[clang] [CIR] Defer emitting function definitions (PR #142862)

2025-06-05 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/142862 >From 217f3a01f9ed161eb3afa3f7e6a594720e8a2840 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Mon, 2 Jun 2025 17:11:55 -0700 Subject: [PATCH 1/3] [CIR] Defer emitting function definitions This change imple

[clang] [CIR] Add support for derived class declarations (PR #142823)

2025-06-05 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/142823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Driver] Move CommonArgs to a location visible by the Frontend Drivers (PR #142800)

2025-06-05 Thread Cameron McInally via cfe-commits
https://github.com/mcinally updated https://github.com/llvm/llvm-project/pull/142800 >From 918b853de8c43dacebecb42cafa6d3b8fec15b47 Mon Sep 17 00:00:00 2001 From: Cameron McInally Date: Tue, 3 Jun 2025 11:12:42 -0700 Subject: [PATCH 1/2] [Driver] Move CommonArgs to a location visible by the Fr

[clang] Fix an error introduced in #138518 (PR #142988)

2025-06-05 Thread Alexander Kornienko via cfe-commits
alexfh wrote: @cor3ntin PTAL https://github.com/llvm/llvm-project/pull/142988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MemProf] Split MemProfiler into Instrumentation and Use. (PR #142811)

2025-06-05 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot3` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/12020 Here is the relevant p

[clang] b3ed428 - [HLSL][RootSignature] Metadata generation of StaticSampler (#142642)

2025-06-05 Thread via cfe-commits
Author: Finn Plummer Date: 2025-06-05T10:18:49-07:00 New Revision: b3ed4288bd2a7e7f4d0494793b64c81df6e93f95 URL: https://github.com/llvm/llvm-project/commit/b3ed4288bd2a7e7f4d0494793b64c81df6e93f95 DIFF: https://github.com/llvm/llvm-project/commit/b3ed4288bd2a7e7f4d0494793b64c81df6e93f95.diff

[clang] [flang] [Driver] Move CommonArgs to a location visible by the Frontend Drivers (PR #142800)

2025-06-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/lib/Driver/MultilibBuilder.cpp clang/lib/Driv

[clang] [llvm] [HLSL][RootSignature] Metadata generation of StaticSampler (PR #142642)

2025-06-05 Thread Finn Plummer via cfe-commits
https://github.com/inbelic closed https://github.com/llvm/llvm-project/pull/142642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23][N3006] Documented behavior of underspecified object declarations (PR #140911)

2025-06-05 Thread Guillot Tony via cfe-commits
https://github.com/to268 updated https://github.com/llvm/llvm-project/pull/140911 >From 11832e8337e6785f887a8fafad7af558ff701f71 Mon Sep 17 00:00:00 2001 From: Guillot Tony Date: Wed, 21 May 2025 16:58:31 +0200 Subject: [PATCH 1/4] Documented N3006 feature --- clang/docs/LanguageExtensions.rs

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-05 Thread Peter Smith via cfe-commits
@@ -110,20 +110,81 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } +static bool hasGCCToolChainAlongSideClang(const Driver &D) { + SmallString<128> GCCDir; + llvm::sys::path::append(GCCDir, D.Dir, "..", D.g

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-05 Thread Peter Smith via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-05 Thread Peter Smith via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-05 Thread Peter Smith via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-05 Thread Peter Smith via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-05 Thread Peter Smith via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-05 Thread Peter Smith via cfe-commits
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } -BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: ToolChain(D, Triple, Arg

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-05 Thread Peter Smith via cfe-commits
https://github.com/smithp35 edited https://github.com/llvm/llvm-project/pull/121829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-06-05 Thread Amr Hesham via cfe-commits
@@ -0,0 +1,41 @@ + +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-06-05 Thread Peter Smith via cfe-commits
https://github.com/smithp35 commented: I've done another review pass. Mostly some small stylistic comments. I'm finding it difficult to follow the code with the various different code-paths with similar names. I've made some suggestions on renaming. We may also be able to add some more comment

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-05 Thread Paul Kirth via cfe-commits
@@ -208,37 +208,105 @@ static json::Value extractValue(const TypedefInfo &I) { } static json::Value extractValue(const CommentInfo &I) { - assert((I.Kind == "BlockCommandComment" || I.Kind == "FullComment" || - I.Kind == "ParagraphComment" || I.Kind == "TextComment")

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-05 Thread Paul Kirth via cfe-commits
@@ -316,8 +316,13 @@ static llvm::Error parseRecord(const Record &R, unsigned ID, static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, CommentInfo *I) { switch (ID) { - case COMMENT_KIND: -return decodeRecord(

[clang] [llvm] [RISCV] Add support for -mtune=andes-45-series (PR #142900)

2025-06-05 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/142900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][RISCV] Make zvknhb imply zvknha (PR #142896)

2025-06-05 Thread Craig Topper via cfe-commits
topperc wrote: @4vtomat you did the opposite of this in 65dc96c2cfa480b070c7913ac5e313c98ca96520. What changed now? https://github.com/llvm/llvm-project/pull/142896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [AArch64][FMV] Enable PAuth and BTI hardening of resolver functions (PR #141573)

2025-06-05 Thread Alexandros Lamprineas via cfe-commits
@@ -0,0 +1,25 @@ +// RUN: %clang_cc1 -triple aarch64-linux-gnu -mbranch-target-enforce -msign-return-address=all -emit-llvm %s -o - | FileCheck --check-prefixes=CHECK,BTI-SIGNRA %s labrinea wrote: No, I am not asking existing tests to be moved, but when we

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-06-05 Thread Thorsten Klein via cfe-commits
https://github.com/thorsten-klein updated https://github.com/llvm/llvm-project/pull/124265 >From 4f44b9294bf290332faf3223d17999565cbea4d4 Mon Sep 17 00:00:00 2001 From: "Klein, Thorsten (GDE-EDSI1)" Date: Fri, 24 Jan 2025 13:46:24 +0100 Subject: [PATCH] added option AllowNoNamespaceComments for

[clang] [Docs] Explicitly document libclang ABI and API stability (PR #141657)

2025-06-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/141657 >From c7a41997f41daea5669e1a5b003e0b42699c56d4 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Tue, 27 May 2025 14:52:35 -0400 Subject: [PATCH 1/5] [Docs] Explicitly document libclang ABI and API stabili

[clang] [Clang] Fix constant eval of assignment operators with an explicit object parameter (PR #142964)

2025-06-05 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/142964 Fixes #142835 >From af369cdf235c0a334498da428e05140a5eee0b30 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 5 Jun 2025 15:35:22 +0200 Subject: [PATCH] [Clang] Fix constant eval of assignent operators

[clang] Fix error that reference to PointerType is ambiguous in clang/lib/Analysis/UnsafeBufferUsage.cpp (PR #142966)

2025-06-05 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/142966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for derived class declarations (PR #142823)

2025-06-05 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/142823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Reduce LateInstantiatedAttrVec vector default size. (PR #142840)

2025-06-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, wow, that's a really nice win for such an easy change. Thank you! https://github.com/llvm/llvm-project/pull/142840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-06-05 Thread Henrich Lauko via cfe-commits
@@ -1883,6 +1884,60 @@ mlir::LogicalResult CIRToLLVMVecCmpOpLowering::matchAndRewrite( return mlir::success(); } +mlir::LogicalResult CIRToLLVMVecSplatOpLowering::matchAndRewrite( +cir::VecSplatOp op, OpAdaptor adaptor, +mlir::ConversionPatternRewriter &rewriter) co

[clang] 2d7f53b - Thread Safety Analysis: Use replaceLock instead of removeLock+addLock (#141500)

2025-06-05 Thread via cfe-commits
Author: Marco Elver Date: 2025-06-05T16:05:59+02:00 New Revision: 2d7f53bc27c345b844013b0a64040119bd362e51 URL: https://github.com/llvm/llvm-project/commit/2d7f53bc27c345b844013b0a64040119bd362e51 DIFF: https://github.com/llvm/llvm-project/commit/2d7f53bc27c345b844013b0a64040119bd362e51.diff L

[clang] [clang] Remove the experimental prefix from -fexperimental-relative-c++-abi-vtables (PR #142845)

2025-06-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: The changes should come with a release note to let the users know this is no longer experimental. That said, I think we're still missing something for this to no longer be experimental: documentation. I can't find any mention of this flag in `Languag

[clang] [Docs] Explicitly document libclang ABI and API stability (PR #141657)

2025-06-05 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/141657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Thread Safety Analysis: Warn when using negative reentrant capability (PR #141599)

2025-06-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thanks for the new diagnostic! I think you should also add a release note to `clang/docs/ReleaseNotes.rst` so users know about the new diagnostic group. https://github.com/llvm/llvm-project/pull/141599 ___ cf

[clang] Thread Safety Analysis: Use replaceLock instead of removeLock+addLock (PR #141500)

2025-06-05 Thread Marco Elver via cfe-commits
https://github.com/melver closed https://github.com/llvm/llvm-project/pull/141500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix error that reference to PointerType is ambiguous in clang/lib/Analysis/UnsafeBufferUsage.cpp (PR #142966)

2025-06-05 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/142966 >From f536c944cf6526676e5034471ff238b1ce3b0d13 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Thu, 5 Jun 2025 09:41:54 -0400 Subject: [PATCH 1/2] fix error that reference to PointerType is ambi

[clang] [analyzer][NFCI] Remove pointless program point tagging (PR #142980)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Donát Nagy (NagyDonat) Changes Previously some checkers attached explicitly created program point tags to some of the exploded graph nodes that they created. In most of the checkers this ad-hoc tagging only affected the debug dump of the

[clang] [analyzer][NFCI] Remove pointless program point tagging (PR #142980)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Donát Nagy (NagyDonat) Changes Previously some checkers attached explicitly created program point tags to some of the exploded graph nodes that they created. In most of the checkers this ad-hoc tagging only affected the

[clang] Add sycl_external attribute (PR #140282)

2025-06-05 Thread via cfe-commits
https://github.com/schittir updated https://github.com/llvm/llvm-project/pull/140282 >From abdbf8905d324f9b935b34bbc97c508ede5ac028 Mon Sep 17 00:00:00 2001 From: "Chittireddy, Sindhu" Date: Fri, 16 May 2025 08:51:06 -0700 Subject: [PATCH 1/6] Add sycl_external attribute --- clang/include/cla

[clang] Fix an error introduced in #138518 (PR #142988)

2025-06-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. 1 nit, else this LGTM. @cor3ntin should have a quick look, but I'm happy with this. Thank you so much! https://github.com/llvm/llvm-project/pull/142988 ___ cfe-commits mailing list cfe-commits

[clang] Fix an error introduced in #138518 (PR #142988)

2025-06-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/142988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix an error introduced in #138518 (PR #142988)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -2160,6 +2160,11 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool UseGlobal, "paren init for non-call init"); Exprs = MultiExprArg(List->getExprs(), List->getNumExprs()); } + if (auto *List = dyn_cast_or_null(Initializer)) { erichke

[clang] Fix an error introduced in #138518 (PR #142988)

2025-06-05 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh updated https://github.com/llvm/llvm-project/pull/142988 >From c7154b0b2bd6457d908bb7fbedc028219f8b5e6d Mon Sep 17 00:00:00 2001 From: Alexander Kornienko Date: Thu, 5 Jun 2025 15:10:39 + Subject: [PATCH 1/2] Fix an error introduced in #138518 --- clang/lib/Sema/

[clang] [compiler-rt] [llvm] [DRAFT][memprof][darwin] Support memprof on Darwin platform and add binary access profile (PR #142884)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-pgo Author: None (SharonXSharon) Changes The patch has two main parts, 1) add support for memprof on Darwin platform 2) add a new binary access profile, including the format definition, the serialization from the memprof comp

[clang] [compiler-rt] [llvm] [DRAFT][memprof][darwin] Support memprof on Darwin platform and add binary access profile (PR #142884)

2025-06-05 Thread via cfe-commits
https://github.com/SharonXSharon ready_for_review https://github.com/llvm/llvm-project/pull/142884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][FMV] Enable PAuth and BTI hardening of resolver functions (PR #141573)

2025-06-05 Thread Oliver Hunt via cfe-commits
@@ -0,0 +1,25 @@ +// RUN: %clang_cc1 -triple aarch64-linux-gnu -mbranch-target-enforce -msign-return-address=all -emit-llvm %s -o - | FileCheck --check-prefixes=CHECK,BTI-SIGNRA %s ojhunt wrote: none of the other ptrauth tests are in a subdirectory, are yo

[clang] [CIR] Upstream minimal builtin function call support (PR #142981)

2025-06-05 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,453 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR][NFC] Use `getType()` instead of more verbose `getResult().getType()` (PR #143024)

2025-06-05 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. Thanks for the cleanup! https://github.com/llvm/llvm-project/pull/143024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add empty handlers for Using and UsingShadow decls (PR #143032)

2025-06-05 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/143032 This adds emitTopLevelDecl "handlers" for Using and UsingShadow. These don't actually need any handling, but they need to be present in the switch to avoid hitting the default handler, which issues a diagnos

[clang] [CIR] Add empty handlers for Using and UsingShadow decls (PR #143032)

2025-06-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This adds emitTopLevelDecl "handlers" for Using and UsingShadow. These don't actually need any handling, but they need to be present in the switch to avoid hitting the default

[clang] [llvm] [CodeGen][AArch64] ptrauth intrinsic to safely construct relative ptr (PR #142047)

2025-06-05 Thread Abhay Kanhere via cfe-commits
AbhayKanhere wrote: @ahmedbougacha @jroelofs @rjmccall https://github.com/llvm/llvm-project/pull/142047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove separate evaluation step for static class member init. (PR #142713)

2025-06-05 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: > or is there more? No, that's it, basically. (Except for the C++98 codepath.) https://github.com/llvm/llvm-project/pull/142713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [clang] Remove separate evaluation step for static class member init. (PR #142713)

2025-06-05 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/142713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove separate evaluation step for static class member init. (PR #142713)

2025-06-05 Thread Eli Friedman via cfe-commits
@@ -143,3 +143,8 @@ namespace fold_initializer { const float A::f = __builtin_is_constant_evaluated(); static_assert(fold(A::f == 1.0f)); } + +struct GH99680 { + static const int x = 1/(1-__builtin_is_constant_evaluated()); // expected-error {{in-class initializer for sta

[clang] [CIR] Add decl case for template specialization (PR #143029)

2025-06-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/143029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add decl case for template specialization (PR #143029)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -0,0 +1,88 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-cir %s -o %t.cir +// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-llvm %s -o

[clang] [CIR] Add decl case for template specialization (PR #143029)

2025-06-05 Thread Erich Keane via cfe-commits
@@ -0,0 +1,88 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-cir %s -o %t.cir +// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-llvm %s -o

[clang] [CIR] Add decl case for template specialization (PR #143029)

2025-06-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. 2 nits, else lgtm. https://github.com/llvm/llvm-project/pull/143029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >