[clang] [ubsan] Add more -fsanitize-annotate-debug-info checks (PR #141997)

2025-06-03 Thread Thurston Dang via cfe-commits
@@ -2817,7 +2817,9 @@ void CodeGenFunction::EmitVTablePtrCheckForCall(const CXXRecordDecl *RD, RD = LeastDerivedClassWithSameLayout(RD); auto [Ordinal, _] = SanitizerInfoFromCFICheckKind(TCK); - ApplyDebugLocation ApplyTrapDI(*this, SanitizerAnnotateDebugInfo(Ordinal))

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines Author: Adrian Vogelsgesang (vogelsgesang) Changes This commit is a major overhaul of the documentation on debugging C++ coroutines with the following goals: * Make it more accessible to casual C++ programmers, i.e. non-toolchain developers

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Adrian Vogelsgesang via cfe-commits
https://github.com/vogelsgesang unassigned https://github.com/llvm/llvm-project/pull/142651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Adrian Vogelsgesang via cfe-commits
https://github.com/vogelsgesang unassigned https://github.com/llvm/llvm-project/pull/142651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-06-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/141305 >From 77641f88c5047c990df649658b6bd5fba0d395cd Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sat, 31 May 2025 15:59:59 +0300 Subject: [PATCH 1/2] [Clang] add fix-it hints for unknown attributes ---

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/142288 >From 1080f1cb13950b3fbeb1536227ee61e2ade9eac7 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 31 May 2025 19:53:56 +0200 Subject: [PATCH 1/6] [CIR] Upstream ShuffleOp for VectorType --- clang/incl

[clang] [llvm] [HLSL][RootSignature] Metadata generation of StaticSampler (PR #142642)

2025-06-03 Thread via cfe-commits
https://github.com/joaosaffran approved this pull request. https://github.com/llvm/llvm-project/pull/142642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't evaluate the initializer of constexpr-unknown parameters. (PR #142498)

2025-06-03 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic milestoned https://github.com/llvm/llvm-project/pull/142498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added explanation why a is trivial copyable evaluated to false. (PR #142341)

2025-06-03 Thread Shamshura Egor via cfe-commits
@@ -2083,6 +2086,87 @@ static void DiagnoseNonTriviallyRelocatableReason(Sema &SemaRef, SemaRef.Diag(D->getLocation(), diag::note_defined_here) << D; } +static void DiagnoseNonTriviallyCopyableReason(Sema &SemaRef, + SourceLocat

[clang] [Clang] Added explanation why a is trivial copyable evaluated to false. (PR #142341)

2025-06-03 Thread Shamshura Egor via cfe-commits
@@ -2083,6 +2086,87 @@ static void DiagnoseNonTriviallyRelocatableReason(Sema &SemaRef, SemaRef.Diag(D->getLocation(), diag::note_defined_here) << D; } +static void DiagnoseNonTriviallyCopyableReason(Sema &SemaRef, + SourceLocat

[clang] [Clang] Added explanation why a is trivial copyable evaluated to false. (PR #142341)

2025-06-03 Thread Shamshura Egor via cfe-commits
https://github.com/egorshamshura edited https://github.com/llvm/llvm-project/pull/142341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ubsan] Add more -fsanitize-annotate-debug-info checks (PR #141997)

2025-06-03 Thread Thurston Dang via cfe-commits
@@ -1134,18 +1136,32 @@ void ScalarExprEmitter::EmitIntegerTruncationCheck(Value *Src, QualType SrcType, (!SrcSigned && DstSigned)) return; - CodeGenFunction::SanitizerScope SanScope(&CGF); - std::pair> - Check = - EmitIntegerTruncationCheckHelper(

[clang] [Doc] Fix a typo in SanitizerSpecialCaseList.rst (PR #142494)

2025-06-03 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao updated https://github.com/llvm/llvm-project/pull/142494 >From 32bb142819fa2295546166ad9e6639204cd03884 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 2 Jun 2025 22:20:20 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF

[clang-tools-extra] [clangd] Improve Markup Rendering (PR #140498)

2025-06-03 Thread via cfe-commits
@@ -118,8 +138,8 @@ class Document { BulletList &addBulletList(); /// Doesn't contain any trailing newlines. - /// We try to make the markdown human-readable, e.g. avoid extra escaping. - /// At least one client (coc.nvim) displays the markdown verbatim!

[clang] [ubsan] Add more -fsanitize-annotate-debug-info checks (PR #141997)

2025-06-03 Thread Thurston Dang via cfe-commits
@@ -1134,18 +1136,32 @@ void ScalarExprEmitter::EmitIntegerTruncationCheck(Value *Src, QualType SrcType, (!SrcSigned && DstSigned)) return; - CodeGenFunction::SanitizerScope SanScope(&CGF); - std::pair> - Check = - EmitIntegerTruncationCheckHelper(

[clang] modulemap: add arm64 intrinsics header (PR #142653)

2025-06-03 Thread Fabrice de Gans via cfe-commits
https://github.com/Steelskin created https://github.com/llvm/llvm-project/pull/142653 The header was missing from the modulemap definition, resulting in a breakage for Swift with recent Windows SDK headers. >From 3324034754b7877258be3f8a806ac3ab8ada3ab6 Mon Sep 17 00:00:00 2001 From: Fabrice d

[clang] [AArch64] Add MSVC-style mangling for SVE types. (PR #141887)

2025-06-03 Thread Hans Wennborg via cfe-commits
https://github.com/zmodem approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/141887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] modulemap: add arm64 intrinsics header (PR #142653)

2025-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fabrice de Gans (Steelskin) Changes The header was missing from the modulemap definition, resulting in a breakage for Swift with recent Windows SDK headers. --- Full diff: https://github.com/llvm/llvm-project/pull/142653.diff 1 Files Af

[clang] modulemap: add arm64 intrinsics header (PR #142653)

2025-06-03 Thread Fabrice de Gans via cfe-commits
https://github.com/Steelskin updated https://github.com/llvm/llvm-project/pull/142653 >From bd1690f9ed915e382ed44ac7e14a1820f0ca1206 Mon Sep 17 00:00:00 2001 From: Fabrice de Gans Date: Tue, 3 Jun 2025 11:26:04 -0700 Subject: [PATCH] modulemap: add arm64 intrinsics header The header was missin

[clang-tools-extra] [clang-tidy] NFCI: remove non-functional matcher from SizeofExpressionCheck (PR #142654)

2025-06-03 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/142654 This matcher would never match anything, because all record types as-written would be wrappen in an ElaboratedType. Just fixing that leads to a matcher which has too many false positives to be useful. The wa

[clang-tools-extra] [clang-tidy] NFCI: remove non-functional matcher from SizeofExpressionCheck (PR #142654)

2025-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Matheus Izvekov (mizvekov) Changes This matcher would never match anything, because all record types as-written would be wrappen in an ElaboratedType. Just fixing that leads to a matcher which has too many false positives to be usef

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Adrian Vogelsgesang via cfe-commits
https://github.com/vogelsgesang ready_for_review https://github.com/llvm/llvm-project/pull/142651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Jan Finis via cfe-commits
@@ -8,470 +8,966 @@ Debugging C++ Coroutines Introduction -For performance and other architectural reasons, the C++ Coroutines feature in -the Clang compiler is implemented in two parts of the compiler. Semantic -analysis is performed in Clang, and Coroutine cons

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Jan Finis via cfe-commits
@@ -8,470 +8,966 @@ Debugging C++ Coroutines Introduction -For performance and other architectural reasons, the C++ Coroutines feature in -the Clang compiler is implemented in two parts of the compiler. Semantic -analysis is performed in Clang, and Coroutine cons

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Jan Finis via cfe-commits
@@ -8,470 +8,966 @@ Debugging C++ Coroutines Introduction -For performance and other architectural reasons, the C++ Coroutines feature in -the Clang compiler is implemented in two parts of the compiler. Semantic -analysis is performed in Clang, and Coroutine cons

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Jan Finis via cfe-commits
@@ -8,470 +8,966 @@ Debugging C++ Coroutines Introduction -For performance and other architectural reasons, the C++ Coroutines feature in -the Clang compiler is implemented in two parts of the compiler. Semantic -analysis is performed in Clang, and Coroutine cons

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Jan Finis via cfe-commits
@@ -8,470 +8,966 @@ Debugging C++ Coroutines Introduction -For performance and other architectural reasons, the C++ Coroutines feature in -the Clang compiler is implemented in two parts of the compiler. Semantic -analysis is performed in Clang, and Coroutine cons

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Jan Finis via cfe-commits
@@ -8,470 +8,966 @@ Debugging C++ Coroutines Introduction -For performance and other architectural reasons, the C++ Coroutines feature in -the Clang compiler is implemented in two parts of the compiler. Semantic -analysis is performed in Clang, and Coroutine cons

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-06-03 Thread via cfe-commits
@@ -3027,9 +3027,13 @@ static LValue EmitFunctionDeclLValue(CodeGenFunction &CGF, const Expr *E, GlobalDecl GD) { const FunctionDecl *FD = cast(GD.getDecl()); llvm::Constant *V = CGF.CGM.getFunctionPointer(GD); + auto ETy = E->getType(

[clang] [Clang][Driver][AArch64] Add support for aarch64-amazon-linux triple (PR #109263)

2025-06-03 Thread Peter Waller via cfe-commits
peterwaller-arm wrote: > As the comment specifies, we really should not add new elements to *Dirs > arrays in Generic_GCC::GCCInstallationDetector::CollectLibDirsAndTriples. Thanks for following up again @MaskRay. Forgive me for asking, but I didn't see a clear justification for "why" along si

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Jan Finis via cfe-commits
@@ -8,470 +8,966 @@ Debugging C++ Coroutines Introduction -For performance and other architectural reasons, the C++ Coroutines feature in -the Clang compiler is implemented in two parts of the compiler. Semantic -analysis is performed in Clang, and Coroutine cons

[clang-tools-extra] [clang-tidy] NFCI: remove non-functional matcher from SizeofExpressionCheck (PR #142654)

2025-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Matheus Izvekov (mizvekov) Changes This matcher would never match anything, because all record types as-written would be wrappen in an ElaboratedType. Just fixing that leads to a matcher which has too many false positives to b

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-06-03 Thread via cfe-commits
@@ -8253,6 +8275,19 @@ inline bool Type::isObjectPointerType() const { return false; } +inline bool Type::isCFIUncheckedCalleeFunctionType() const { + if (const auto *Fn = getAs()) +return Fn->hasCFIUncheckedCallee(); + return false; +} + +inline bool Type::isPointer

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-06-03 Thread via cfe-commits
@@ -8253,6 +8275,19 @@ inline bool Type::isObjectPointerType() const { return false; } +inline bool Type::isCFIUncheckedCalleeFunctionType() const { + if (const auto *Fn = getAs()) +return Fn->hasCFIUncheckedCallee(); + return false; +} + +inline bool Type::isPointer

[clang] [Doc] Fix a typo in SanitizerSpecialCaseList.rst (PR #142494)

2025-06-03 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao updated https://github.com/llvm/llvm-project/pull/142494 >From 32bb142819fa2295546166ad9e6639204cd03884 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 2 Jun 2025 22:20:20 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF

[clang] 50f9b8a - [Doc][NFC] Fix a typo in SanitizerSpecialCaseList.rst (#142494)

2025-06-03 Thread via cfe-commits
Author: Qinkun Bao Date: 2025-06-03T15:09:22-04:00 New Revision: 50f9b8acafdca48e87e6b8e393c1f116a2d193ee URL: https://github.com/llvm/llvm-project/commit/50f9b8acafdca48e87e6b8e393c1f116a2d193ee DIFF: https://github.com/llvm/llvm-project/commit/50f9b8acafdca48e87e6b8e393c1f116a2d193ee.diff LO

[clang] [ubsan] Add more -fsanitize-annotate-debug-info checks (PR #141997)

2025-06-03 Thread Thurston Dang via cfe-commits
@@ -1134,18 +1136,32 @@ void ScalarExprEmitter::EmitIntegerTruncationCheck(Value *Src, QualType SrcType, (!SrcSigned && DstSigned)) return; - CodeGenFunction::SanitizerScope SanScope(&CGF); - std::pair> - Check = - EmitIntegerTruncationCheckHelper(

[clang] [llvm] [AArch64TargetParser]Fix reconstructFromParsedFeatures ignoring negative features (PR #142236)

2025-06-03 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB updated https://github.com/llvm/llvm-project/pull/142236 >From 92da4def0f7c39a6348669387cfc874ee03f8471 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Fri, 30 May 2025 16:19:16 -0700 Subject: [PATCH 1/3] [AArch64TargetParser]Fix reconstructFromParsedFeatures igno

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Jan Finis via cfe-commits
@@ -8,470 +8,966 @@ Debugging C++ Coroutines Introduction -For performance and other architectural reasons, the C++ Coroutines feature in -the Clang compiler is implemented in two parts of the compiler. Semantic -analysis is performed in Clang, and Coroutine cons

[clang] [Doc] Fix a typo in SanitizerSpecialCaseList.rst (PR #142494)

2025-06-03 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao closed https://github.com/llvm/llvm-project/pull/142494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Force expressions with UO_Not to not be non-negative (PR #126846)

2025-06-03 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: > > Could you help me understand why clang is emitting the warning? > > Isn't it semantically equivalent to the following code? > > ``` > > unsigned int foo(unsigned char x) > > { > > int i = ~(1< > return i; // no -Wimplicit-int-conversion warning. > > } > > ``` > > Th

[clang] [Clang] Added explanation why a is trivial copyable evaluated to false. (PR #142341)

2025-06-03 Thread Shamshura Egor via cfe-commits
https://github.com/egorshamshura updated https://github.com/llvm/llvm-project/pull/142341 >From 2e423a75e5ee8b5ecc450d4457fc677fd0c08ad2 Mon Sep 17 00:00:00 2001 From: Shamshura Egor Date: Mon, 2 Jun 2025 07:25:26 + Subject: [PATCH 1/9] [Clang] Added explanation why a is trivial copyable e

[clang] [Doc] Fix a typo in SanitizerSpecialCaseList.rst (PR #142494)

2025-06-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `clang` at step 17 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/6206 Here is the relevant piece o

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-03 Thread Erick Velez via cfe-commits
https://github.com/evelez7 updated https://github.com/llvm/llvm-project/pull/142483 >From fa8b80f9bfe2b7faf765ed4cf60fb8cec30e1d48 Mon Sep 17 00:00:00 2001 From: Erick Velez Date: Mon, 2 Jun 2025 12:53:36 -0700 Subject: [PATCH 1/2] [clang-doc] add a JSON generator --- clang-tools-extra/clang-

[clang] [Sanitizer][Doc][NFI] Update the doc for prefix:*=sanitize (PR #142659)

2025-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qinkun Bao (qinkunbao) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/142659.diff 2 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+3-1) - (modified) clang/docs/SanitizerSpecialCaseList.rst (+16-2)

[clang] [Sanitizer][Doc][NFI] Update the doc for prefix:*=sanitize (PR #142659)

2025-06-03 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao created https://github.com/llvm/llvm-project/pull/142659 None >From c3e6f0f64be652259065c4c57b9dec7cc30502d0 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Tue, 3 Jun 2025 19:29:54 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[clang] [Sanitizer][Doc][NFI] Update the doc for prefix:*=sanitize (PR #142659)

2025-06-03 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao updated https://github.com/llvm/llvm-project/pull/142659 >From c3e6f0f64be652259065c4c57b9dec7cc30502d0 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Tue, 3 Jun 2025 19:29:54 + Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF

[clang] modulemap: add arm64 intrinsics header (PR #142653)

2025-06-03 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/142653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sanitizer][Doc][NFI] Update the doc for prefix:*=sanitize (PR #142659)

2025-06-03 Thread Qinkun Bao via cfe-commits
qinkunbao wrote: I don't think the doc build broken is related to this PR. https://github.com/llvm/llvm-project/actions/runs/15426207709/job/43413626057?pr=142659 But I will look into the issue. https://github.com/llvm/llvm-project/pull/142659 ___ c

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-06-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk ready_for_review https://github.com/llvm/llvm-project/pull/141305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] rename "AST" to precompiled in diagnostic messages NFCI (PR #142635)

2025-06-03 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/142635 >From f91e978a380ab3455843c120c4df66aa20ca8807 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Mon, 2 Jun 2025 19:38:28 -0700 Subject: [PATCH 1/2] [clang][modules] rename "AST" to precompiled in diagnosti

[clang] [clang][AST] Reduce some AST node size. (PR #142585)

2025-06-03 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/142585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0d02150 - [clang][AST] Reduce some AST node size. (#142585)

2025-06-03 Thread via cfe-commits
Author: Haojian Wu Date: 2025-06-03T21:44:08+02:00 New Revision: 0d02150c3d7e8960ad0fe247baecfa76c7ce1129 URL: https://github.com/llvm/llvm-project/commit/0d02150c3d7e8960ad0fe247baecfa76c7ce1129 DIFF: https://github.com/llvm/llvm-project/commit/0d02150c3d7e8960ad0fe247baecfa76c7ce1129.diff LO

[clang] [clang] Correct FixIt ranges for unused capture warnings (PR #141148)

2025-06-03 Thread Oliver Hunt via cfe-commits
@@ -1,5 +1,5 @@ // RUN: cp %s %t -// RUN: %clang_cc1 -x c++ -Wunused-lambda-capture -Wno-unused-value -std=c++1z -fixit %t +// RUN: %clang_cc1 -x c++ -Wno-vla-cxx-extension -Wunused-lambda-capture -Wno-unused-value -std=c++1z -fixit %t ojhunt wrote: ah no, th

[clang] [clang][CGObjC] Sign the v-table pointer in ObjC exception RTTI. (PR #135562)

2025-06-03 Thread Oliver Hunt via cfe-commits
@@ -7676,10 +7676,26 @@ CGObjCNonFragileABIMac::GetInterfaceEHType(const ObjCInterfaceDecl *ID, } llvm::Value *VTableIdx = llvm::ConstantInt::get(CGM.Int32Ty, 2); + llvm::Constant *VTablePtr = llvm::ConstantExpr::getInBoundsGetElementPtr( + VTableGV->getValueType(),

[clang-tools-extra] [clang-doc] Fix brittle check in test (PR #142665)

2025-06-03 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#142665** https://app.graphite.dev/github/pr/llvm/llvm-project/142665?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> šŸ‘ˆ https://app.graphite.dev/github/pr/llvm/llvm-project/1426

[clang-tools-extra] [clang-doc] Fix brittle check in test (PR #142665)

2025-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Paul Kirth (ilovepi) Changes Instead of having a platform specific error diagnostic, use a fixed one with more direct context for the error. --- Full diff: https://github.com/llvm/llvm-project/pull/142665.diff 2 Files Affecte

[clang] [clang][AST] Reduce some AST node size. (PR #142585)

2025-06-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross` running on `suse-gary-m68k-cross` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/11010 Here is the relevant piece

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Jan Finis via cfe-commits
@@ -8,470 +8,966 @@ Debugging C++ Coroutines Introduction -For performance and other architectural reasons, the C++ Coroutines feature in -the Clang compiler is implemented in two parts of the compiler. Semantic -analysis is performed in Clang, and Coroutine cons

[clang] [clang] Correct FixIt ranges for unused capture warnings (PR #141148)

2025-06-03 Thread Oliver Hunt via cfe-commits
ojhunt wrote: I don't understand the windows failure (ninja says there was a failure, but I cannot find any failure in the log?) I'm also confused by the documentation failure: it's not telling me what/where the error is coming from. https://github.com/llvm/llvm-project/pull/141148 __

[clang] [clang] Correct FixIt ranges for unused capture warnings (PR #141148)

2025-06-03 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/141148 >From 0db205bb8f6925dd725885395f58a688000c7b8b Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Thu, 22 May 2025 02:38:26 -0700 Subject: [PATCH 1/5] [clang] Correct FixIt ranges for unused capture warnings Fixes

[clang-tools-extra] [clang-doc] Fix brittle check in test (PR #142665)

2025-06-03 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/142665 Instead of having a platform specific error diagnostic, use a fixed one with more direct context for the error. >From 26277ead2a7f476daaae7c7c972549b6f949d850 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue

[clang-tools-extra] [clangd] [Modules] Fixes to correctly handle module dependencies (PR #142090)

2025-06-03 Thread via cfe-commits
fleeting-xx wrote: Ok. I wasn't able to get this on a physical surface PC, but I did spin up a arm64 azure windows VM to see if I could reproduce it. Unfortunately both unit tests that were failing on the build machine passed on my VM. My best guess maybe is a filesystem permission issue? When

[clang] [Clang][Driver] Override complex number calculation method by -fno-fast-math (PR #132680)

2025-06-03 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > This test expects the warning message `warning: overriding > '-fcomplex-arithmetic=basic' option with '-fcomplex-arithmetic=promoted'` for > `clang -ffast-math -ffp-model=fast`. I'm not sure if this test is correct, > but I believe a new variable is necessary to avoid affe

[clang] [clang] Correct FixIt ranges for unused capture warnings (PR #141148)

2025-06-03 Thread Erich Keane via cfe-commits
erichkeane wrote: > I don't understand the windows failure (ninja says there was a failure, but I > cannot find any failure in the log?) > > I'm also confused by the documentation failure: it's not telling me > what/where the error is coming from. Documentation failure says: Warning, treat

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-06-03 Thread via cfe-commits
@@ -12681,6 +12681,11 @@ def warn_noderef_on_non_pointer_or_array : Warning< def warn_noderef_to_dereferenceable_pointer : Warning< "casting to dereferenceable pointer removes 'noderef' attribute">, InGroup; +def warn_cast_discards_cfi_unchecked_callee +: Warning<"impli

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-06-03 Thread via cfe-commits
@@ -5250,6 +5260,7 @@ class FunctionProtoType final FunctionType::ExtInfo ExtInfo; unsigned Variadic : 1; unsigned HasTrailingReturn : 1; +unsigned CFIUncheckedCallee : 1; PiJoules wrote: Done https://github.com/llvm/llvm-project/pull/135836 _

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-06-03 Thread via cfe-commits
https://github.com/PiJoules updated https://github.com/llvm/llvm-project/pull/135836 >From c20935a0af957783389df80f76511ad29fa85077 Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Wed, 9 Apr 2025 14:21:00 -0700 Subject: [PATCH] [clang] Function type attribute to prevent CFI instrumentation

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-03 Thread Amr Hesham via cfe-commits
@@ -0,0 +1,21 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] [clang-doc] add tags to Mustache namespace template (PR #142045)

2025-06-03 Thread Paul Kirth via cfe-commits
ilovepi wrote: > Hi, sorry for the lack response. Unfortunately my father passed away recently > so I was dealing with the logistics. I'm more than happy to deal with any > issues that arises from my previous code @PeterChou1 I'm sorry to hear about your circumstances. That's truly a hard th

[clang] [llvm] [PowerPC] frontend get target feature from backend with cpu name (PR #137670)

2025-06-03 Thread zhijian lin via cfe-commits
https://github.com/diggerlin updated https://github.com/llvm/llvm-project/pull/137670 >From 97f10e6a0fb4c158359e79e24650f8fdf4d23ef2 Mon Sep 17 00:00:00 2001 From: zhijian Date: Fri, 25 Apr 2025 13:09:47 + Subject: [PATCH 1/9] implement getting target features from backend for clang fronte

[clang] [llvm] [HLSL][SPIR-V] Implement vk::ext_builtin_input attribute (PR #138530)

2025-06-03 Thread Justin Bogner via cfe-commits
Nathan =?utf-8?q?Gauƫr?= , Nathan =?utf-8?q?Gauƫr?= , Nathan =?utf-8?q?Gauƫr?= , Nathan =?utf-8?q?Gauƫr?= , Nathan =?utf-8?q?Gauƫr?= , Nathan =?utf-8?q?Gauƫr?= Message-ID: In-Reply-To: @@ -554,6 +554,19 @@ static void initializeBufferFromBinding(CodeGenModule &CGM,

[clang] [llvm] [PowerPC] frontend get target feature from backend with cpu name (PR #137670)

2025-06-03 Thread zhijian lin via cfe-commits
@@ -16,6 +16,7 @@ #include "llvm/ADT/StringMap.h" #include "llvm/ADT/StringRef.h" +#include "llvm/MC/MCSubtargetInfo.h" diggerlin wrote: I addressed your comment , would you help to take a look again? @MaskRay https://github.com/llvm/llvm-project/pull/13767

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-03 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/142483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-03 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: This is a good start, but I thin we'll want some more tests, and probably some unit test coverage. Unittesting is especially nice, since I believe this backend doesn't need any of the asset files, right? As for whether this should follow the pattern of YAM

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-03 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,352 @@ +#include "Generators.h" +#include "llvm/Support/JSON.h" + +using namespace llvm; +using namespace llvm::json; + +static llvm::ExitOnError ExitOnErr; + +namespace clang { +namespace doc { + +class JSONGenerator : public Generator { +public: + static const char *

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-03 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,352 @@ +#include "Generators.h" +#include "llvm/Support/JSON.h" + +using namespace llvm; +using namespace llvm::json; + +static llvm::ExitOnError ExitOnErr; + +namespace clang { +namespace doc { + +class JSONGenerator : public Generator { +public: + static const char *

[clang-tools-extra] [clang-doc] Add test case for #141990 (PR #142209)

2025-06-03 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **Jun 3, 4:36 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/142209). https://github.com/llvm/llvm-project/pull/142209 _

[clang] [Sanitizer][Doc][NFI] Update the doc for prefix:*=sanitize (PR #142659)

2025-06-03 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao updated https://github.com/llvm/llvm-project/pull/142659 >From c3e6f0f64be652259065c4c57b9dec7cc30502d0 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Tue, 3 Jun 2025 19:29:54 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF

[clang] [clang][CGObjC] Sign the v-table pointer in ObjC exception RTTI. (PR #135562)

2025-06-03 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt edited https://github.com/llvm/llvm-project/pull/135562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64TargetParser]Fix reconstructFromParsedFeatures ignoring negative features (PR #142236)

2025-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matthias Braun (MatzeB) Changes The `targetFeatureToExtension` function used by reconstructFromParsedFeatures only found positive `+FEATURE` strings, but not negative `-FEATURE` strings. Extend the function to handle both to fix `reconstruc

[clang] [clang][PAC] Add __builtin_get_vtable_pointer (PR #139790)

2025-06-03 Thread Oliver Hunt via cfe-commits
@@ -3074,6 +3074,39 @@ following way: Query for this feature with ``__has_builtin(__builtin_offsetof)``. +``__builtin_get_vtable_pointer`` + + +``__builtin_get_vtable_pointer`` loads and authenticates the primary vtable +pointer from an instanc

[clang] [clang] Correct FixIt ranges for unused capture warnings (PR #141148)

2025-06-03 Thread Oliver Hunt via cfe-commits
ojhunt wrote: > Documentation failure says: > > Warning, treated as error: > /home/runner/work/llvm-project/llvm-project/clang-build/tools/clang/docs/DiagnosticsReference.rst:18009:Unexpected > indentation. Right, but I don't know how/what is causing the failure as I haven't changed any dia

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-03 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,352 @@ +#include "Generators.h" +#include "llvm/Support/JSON.h" + +using namespace llvm; +using namespace llvm::json; + +static llvm::ExitOnError ExitOnErr; + +namespace clang { +namespace doc { + +class JSONGenerator : public Generator { +public: + static const char *

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-03 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,352 @@ +#include "Generators.h" +#include "llvm/Support/JSON.h" + +using namespace llvm; +using namespace llvm::json; + +static llvm::ExitOnError ExitOnErr; + +namespace clang { +namespace doc { + +class JSONGenerator : public Generator { +public: + static const char *

[clang] [clang-format][NFC] Clean up AnnotatingParser::consumeToken() (PR #142104)

2025-06-03 Thread Jordan Rupprecht via cfe-commits
rupprecht wrote: It looks like this change is not actually NFC. The difference is incredibly minor. Given this C++ snippet: ```c++ namespace f { /*//comment*/}; ``` clang-format used to not touch that. Now, it adds a space near the end: ```c++ namespace f { /*//comment*/ }; ``` Is that expec

[clang] [CIR] Fix missing return value warning in maybePromoteBoolResult (PR #142673)

2025-06-03 Thread Morris Hafner via cfe-commits
https://github.com/mmha created https://github.com/llvm/llvm-project/pull/142673 This is NFC and simply adds an llvm_unreachable >From 5e67287af5e55e3792e359812e539d8375d32f10 Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Tue, 3 Jun 2025 23:19:50 +0200 Subject: [PATCH] [CIR] Fix missing re

[clang] [CIR] Fix missing return value warning in maybePromoteBoolResult (PR #142673)

2025-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Morris Hafner (mmha) Changes This is NFC and simply adds an llvm_unreachable --- Full diff: https://github.com/llvm/llvm-project/pull/142673.diff 1 Files Affected: - (modified) clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp (+1)

[clang] [CIR] Fix missing return value warning in maybePromoteBoolResult (PR #142673)

2025-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Morris Hafner (mmha) Changes This is NFC and simply adds an llvm_unreachable --- Full diff: https://github.com/llvm/llvm-project/pull/142673.diff 1 Files Affected: - (modified) clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp (+1) ``

[clang] [llvm] [NFC][RootSignature] Move RootSignature util functions (PR #142491)

2025-06-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot3` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/11956 Here is the relevant p

[clang] [docs][coroutines] Revamp "Debugging C++ coroutines" (PR #142651)

2025-06-03 Thread Jan Finis via cfe-commits
@@ -8,470 +8,966 @@ Debugging C++ Coroutines Introduction -For performance and other architectural reasons, the C++ Coroutines feature in -the Clang compiler is implemented in two parts of the compiler. Semantic -analysis is performed in Clang, and Coroutine cons

[clang] [llvm] [DirectX] add GEP i8 legalization (PR #142475)

2025-06-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/142475 >From 244b01e43f4c974c682c90d1315c59605da2b289 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Mon, 2 Jun 2025 15:40:22 -0400 Subject: [PATCH 1/5] [DirectX] add GEP i8 legalization The i8 legalization code in

[clang] [llvm] [DirectX] add GEP i8 legalization (PR #142475)

2025-06-03 Thread Deric C. via cfe-commits
https://github.com/Icohedron edited https://github.com/llvm/llvm-project/pull/142475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] add GEP i8 legalization (PR #142475)

2025-06-03 Thread Farzon Lotfi via cfe-commits
@@ -106,3 +106,57 @@ define i32 @all_imm() { %2 = sext i8 %1 to i32 ret i32 %2 } + +define i32 @scalar_i8_geps() { + ; CHECK-LABEL: define i32 @scalar_i8_geps( + ; CHECK-NEXT:[[ALLOCA:%.*]] = alloca i32, align 4 + ; CHECK-NEXT:[[GEP:%.*]] = getelementptr inbounds

[clang] [llvm] [UBSan] Support src:*=sanitize for multiple ignorelists. (PR #141640)

2025-06-03 Thread Shafik Yaghmour via cfe-commits
@@ -44,20 +45,24 @@ class SanitizerSpecialCaseList : public llvm::SpecialCaseList { StringRef Category = StringRef()) const; // Query ignorelisted entries if any bit in Mask matches the entry's section. - // Return 0 if not found. If found, return the line

[clang] [CIR] Fix missing return value warning in maybePromoteBoolResult (PR #142673)

2025-06-03 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. @AmrDeveloper posted a different fix for this here: https://github.com/llvm/llvm-project/pull/142591 I kind of like the change here better because it won't silently return an arbitrary value in release builds, and this really should be

[clang] [clang] Correct FixIt ranges for unused capture warnings (PR #141148)

2025-06-03 Thread Shafik Yaghmour via cfe-commits
@@ -972,6 +972,12 @@ class Sema final : public SemaBase { /// Calls \c Lexer::getLocForEndOfToken() SourceLocation getLocForEndOfToken(SourceLocation Loc, unsigned Offset = 0); + /// Calls \c Lexer::findNextToken() to find the next token, and if the + /// locations of bo

[clang] [CIR][NFS] Fix missing return statement warning (PR #142591)

2025-06-03 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. @mmha also posted a fix for the maybePromoteBoolResult here: https://github.com/llvm/llvm-project/pull/142673 The removal of the dead code below the return in VisitUnaryLNot should be done as it is here, but I have a slight preference f

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-06-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/141369 >From cd8321c18eecd841907969753653548fbe23d76a Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 Subject: [PATCH 1/9] [CIR] Upstream global initialization for ComplexType --

[clang] [CIR][NFS] Fix missing return statement warning (PR #142591)

2025-06-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/142591 >From 0c59770ce43107be9f2c8c832bc8ccff293cecb4 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 3 Jun 2025 14:09:37 +0200 Subject: [PATCH] [CIR][NFS] Fix dead code return statement warning --- clang

<    1   2   3   4   5   >