llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`amdgpu-offload-ubuntu-22-cmake-build-only` running on `rocm-docker-ubu-22`
while building `clang-tools-extra,clang,lldb` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/203/builds
@@ -11762,52 +11762,98 @@ bool
OpenMPAtomicCompareChecker::checkCondUpdateStmt(IfStmt *S,
X = BO->getLHS();
- auto *Cond = dyn_cast(S->getCond());
- if (!Cond) {
-ErrorInfo.Error = ErrorTy::NotABinaryOp;
-ErrorInfo.ErrorLoc = ErrorInfo.NoteLoc = S->getCond()->get
@@ -11762,52 +11762,98 @@ bool
OpenMPAtomicCompareChecker::checkCondUpdateStmt(IfStmt *S,
X = BO->getLHS();
- auto *Cond = dyn_cast(S->getCond());
- if (!Cond) {
-ErrorInfo.Error = ErrorTy::NotABinaryOp;
-ErrorInfo.ErrorLoc = ErrorInfo.NoteLoc = S->getCond()->get
https://github.com/ojhunt created
https://github.com/llvm/llvm-project/pull/141148
Fixes #106445 by using the lexer to find the correct range for the removal
FixIts. Previously the ranges that were generated assuming no unsurprising
formatting, which for the most part works. Being correct in a
ojhunt wrote:
The fix for the core issue was more complex than the easy fix/new contributor
tag implied: https://github.com/llvm/llvm-project/pull/141148
https://github.com/llvm/llvm-project/pull/117953
___
cfe-commits mailing list
cfe-commits@lists
@@ -135,3 +135,53 @@
void f(void) {
}
+
+
+// RUN: not %clang_cl -### --target=i386 -mapx-features=ndd %s 2>&1 |
FileCheck --check-prefix=NON-APX %s
+// RUN: not %clang_cl -### --target=i386 -mapxf %s 2>&1 | FileCheck
--check-prefix=NON-APX %s
+// RUN: %clang_cl -### --targe
jiefwo wrote:
Hi! The patch is approved — is there a committer who could help merge it? This
is my first contribution.
https://github.com/llvm/llvm-project/pull/138894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -6679,8 +6679,13 @@ def mapx_features_EQ : CommaJoined<["-"],
"mapx-features=">, Group,
Values<"egpr,push2pop2,ppx,ndd,ccmp,nf,cf,zu">, Visibility<[ClangOption,
CLOption, FlangOption]>;
def mno_apx_features_EQ : CommaJoined<["-"], "mno-apx-features=">,
Group,
HelpTex
@@ -297,7 +301,8 @@ TEST(IncludeCleaner, GenerateMissingHeaderDiags) {
Findings.UnusedIncludes.clear();
std::vector Diags = issueIncludeCleanerDiagnostics(
AST, TU.Code, Findings, MockFS(),
- {[](llvm::StringRef Header) { return Header.ends_with("buzz.h"); }});
+
@@ -142,6 +143,13 @@ std::vector generateMissingIncludeDiagnostics(
llvm::StringRef HeaderRef{Spelling};
bool Angled = HeaderRef.starts_with("<");
+for (auto Filter : AngledHeaders) {
HighCommander4 wrote:
nit: iterate using `auto &`, the way we d
@@ -262,6 +264,8 @@ TEST(IncludeCleaner, GenerateMissingHeaderDiags) {
TU.Filename = "main.cpp";
TU.AdditionalFiles["a.h"] = guard("#include \"b.h\"");
TU.AdditionalFiles["b.h"] = guard("void b();");
+ TU.AdditionalFiles["a_angled.h"] = guard("#include \"b_angled.h\"");
@@ -306,6 +311,12 @@ TEST(IncludeCleaner, GenerateMissingHeaderDiags) {
withFix({Fix(MainFile.range("insert_b"), "#include \"b.h\"\n",
"#include \"b.h\""),
FixMessage("add all missing includes")})),
+
https://github.com/ilovepi approved this pull request.
LGTM, but would you mind pre-committing the test so its easy to see what's
changing in the output with this patch? I've been trying to get more of that
done when we're changing clang-doc output. Otherwise it's hard to know exactly
what we'
Author: Andy Kaylor
Date: 2025-05-22T15:59:10-07:00
New Revision: c47260efccf10279b120dbfc516264b39ebaa277
URL:
https://github.com/llvm/llvm-project/commit/c47260efccf10279b120dbfc516264b39ebaa277
DIFF:
https://github.com/llvm/llvm-project/commit/c47260efccf10279b120dbfc516264b39ebaa277.diff
L
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/141155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B approved this pull request.
https://github.com/llvm/llvm-project/pull/141143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oliver Hunt (ojhunt)
Changes
Fixes #106445 by using the lexer to find the correct range for the
removal FixIts. Previously the ranges that were generated assuming no
unsurprising formatting, which for the most part works. Being correct in
evelez7 wrote:
> would you mind pre-committing the test so its easy to see what's changing in
> the output with this patch?
Could you explain what this means please? Do you mean reorganizing the PR so
that the first commit is the test and then the second is the code change?
https://github.com
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux`
running on `premerge-linux-1` while building `clang-tools-extra,clang,lldb` at
step 6 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/153/builds/32614
Author: Volodymyr Sapsai
Date: 2025-05-22T18:34:30-07:00
New Revision: 720014f70841f0284d21ef8100c406d6c864ac9c
URL:
https://github.com/llvm/llvm-project/commit/720014f70841f0284d21ef8100c406d6c864ac9c
DIFF:
https://github.com/llvm/llvm-project/commit/720014f70841f0284d21ef8100c406d6c864ac9c.di
vsapsai wrote:
Ok, I'm going to revert the change to help you out. But I'm going to re-land it
in a week or when you are ready, whichever comes first.
There was no indication there is anything wrong with the change or if the issue
is wide-spread. And if a single company relies on an existing s
https://github.com/evelez7 closed
https://github.com/llvm/llvm-project/pull/141168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Erick Velez
Date: 2025-05-23T02:05:52Z
New Revision: 8268794cc5da06dfe911a40e5b20506c54e65b1b
URL:
https://github.com/llvm/llvm-project/commit/8268794cc5da06dfe911a40e5b20506c54e65b1b
DIFF:
https://github.com/llvm/llvm-project/commit/8268794cc5da06dfe911a40e5b20506c54e65b1b.diff
LOG: [
Author: Yuta Saito
Date: 2025-05-23T10:58:28+09:00
New Revision: b79a624cd601723f9e55a7b1bad9fbaa060d803e
URL:
https://github.com/llvm/llvm-project/commit/b79a624cd601723f9e55a7b1bad9fbaa060d803e
DIFF:
https://github.com/llvm/llvm-project/commit/b79a624cd601723f9e55a7b1bad9fbaa060d803e.diff
LO
ilovepi wrote:
stacked PRs are still not as nice as phabricator or gerrit, but Graphite is a
lot more firendly than I found spr, or winging it w/ github PRs. For a
precommit test, it isn't too hard to upload a patch for before and then rebase
the "after" patch after it lands.
https://github.c
https://github.com/ilovepi approved this pull request.
Perfect. LGTM.
https://github.com/llvm/llvm-project/pull/141168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kateinoigakukun closed
https://github.com/llvm/llvm-project/pull/139014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kateinoigakukun wrote:
Let me merge this to unblock further ASan upstreaming work :pray:
https://github.com/llvm/llvm-project/pull/139014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
running on `linaro-lldb-aarch64-ubuntu` while building `clang,llvm` at step 6
"test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/59/builds/18155
Here is the relevant piece o
https://github.com/jakeegan updated
https://github.com/llvm/llvm-project/pull/140850
>From 120423abadbfd63dbb50387fb5ce26ff0f3ff257 Mon Sep 17 00:00:00 2001
From: Jake Egan
Date: Wed, 21 May 2025 01:51:00 -0400
Subject: [PATCH 1/3] Handle triple environment component for target runtime
directo
https://github.com/jakeegan edited
https://github.com/llvm/llvm-project/pull/140850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jakeegan updated
https://github.com/llvm/llvm-project/pull/140850
>From 120423abadbfd63dbb50387fb5ce26ff0f3ff257 Mon Sep 17 00:00:00 2001
From: Jake Egan
Date: Wed, 21 May 2025 01:51:00 -0400
Subject: [PATCH 1/4] Handle triple environment component for target runtime
directo
https://github.com/jakeegan edited
https://github.com/llvm/llvm-project/pull/140850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Finn Plummer
Date: 2025-05-22T19:20:34-07:00
New Revision: 2b64b1566c2b62e46b2e2268c78aab204eccb9a1
URL:
https://github.com/llvm/llvm-project/commit/2b64b1566c2b62e46b2e2268c78aab204eccb9a1
DIFF:
https://github.com/llvm/llvm-project/commit/2b64b1566c2b62e46b2e2268c78aab204eccb9a1.diff
https://github.com/jakeegan ready_for_review
https://github.com/llvm/llvm-project/pull/140850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/140151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Jake Egan (jakeegan)
Changes
Previously, when the triple is `powerpc-ibm-aix-unknown`, the driver fails to
find subdirectory `lib/powerpc-ibm-aix`.
This ensures the correct runtime path is found if the triple has the -unknown
envi
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jake Egan (jakeegan)
Changes
Previously, when the triple is `powerpc-ibm-aix-unknown`, the driver fails to
find subdirectory `lib/powerpc-ibm-aix`.
This ensures the correct runtime path is found if the triple has the -unknown
environment
https://github.com/tgymnich approved this pull request.
https://github.com/llvm/llvm-project/pull/141191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/141188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2025-05-22T23:52:07-07:00
New Revision: 3d028348ce0d6fa531ba7dad8fd38893019dc609
URL:
https://github.com/llvm/llvm-project/commit/3d028348ce0d6fa531ba7dad8fd38893019dc609
DIFF:
https://github.com/llvm/llvm-project/commit/3d028348ce0d6fa531ba7dad8fd38893019dc609.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/141191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/141202
None
>From 9f6342e8d20ebb7a55f77385f57ada832a69e441 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 22 May 2025 23:27:29 -0700
Subject: [PATCH] [clang-format][NFC] FormatTokenLexer.cpp cleanup
---
clang/lib
Author: Kazu Hirata
Date: 2025-05-22T23:50:55-07:00
New Revision: 05674b21fed51a940b93e09b38d1833010f3f694
URL:
https://github.com/llvm/llvm-project/commit/05674b21fed51a940b93e09b38d1833010f3f694
DIFF:
https://github.com/llvm/llvm-project/commit/05674b21fed51a940b93e09b38d1833010f3f694.diff
L
https://github.com/tgymnich approved this pull request.
https://github.com/llvm/llvm-project/pull/141188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
401 - 445 of 445 matches
Mail list logo