[clang] [clang][Driver] Support passing arbitrary args to `-cc1as` with `-Xclangas`. (PR #100714)

2025-04-22 Thread Hubert Tong via cfe-commits
hubert-reinterpretcast wrote: Passing `-integrated-as` does not help because it is used on AIX to control whether object files are generated directly or not (for C/C++ source). > Or should we just outright disable the test on AIX (and perhaps other > affected platforms)? XFAIL would be good.

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/136729 >From 748a7f76bf0188e0a1b72fcd5527a03a5ca2f054 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 22 Apr 2025 12:05:42 -0500 Subject: [PATCH] [OpenMP] Change build of OpenMP device runtime to be a separate

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-22 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/136488 >From e87536be32965114f1ead1b562cfba289d3f32c0 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 21:03:07 +0200 Subject: [PATCH 1/7] [CIR] Upstream initial support for fixed size VectorType

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-22 Thread Amr Hesham via cfe-commits
@@ -637,6 +637,42 @@ ArrayType::getABIAlignment(const ::mlir::DataLayout &dataLayout, return dataLayout.getTypeABIAlignment(getEltType()); } +//===--===// +// VectorType Definitions +//===--

[clang] [CIR] Upstream support for accessing structure members (PR #136383)

2025-04-22 Thread Bruno Cardoso Lopes via cfe-commits
@@ -1310,6 +1310,70 @@ def GetGlobalOp : CIR_Op<"get_global", let hasVerifier = 0; } +//===--===// +// GetMemberOp +//===--===// + +def Get

[clang] [CIR] Introduce type aliases for records (PR #136387)

2025-04-22 Thread Bruno Cardoso Lopes via cfe-commits
bcardosolopes wrote: > I think we should just make them illegal. sounds good to me https://github.com/llvm/llvm-project/pull/136387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for accessing structure members (PR #136383)

2025-04-22 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/136383 >From 5f83632c07d59df162d79e73d361bea1aa64e117 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Fri, 18 Apr 2025 15:02:22 -0700 Subject: [PATCH 1/3] [CIR] Upstream support for accessing structure members Thi

[clang] [Clang][kcfi] Sign extend KCFI typeid rather than zero extend (PR #136734)

2025-04-22 Thread Sami Tolvanen via cfe-commits
samitolvanen wrote: Unfortunately, the `__kcfi_typeid_` values are intentionally zero-extended, so they can be used in relocations with `movl`. With your patch applied: ``` ... LD .tmp_vmlinux1 ld.lld: error: vmlinux.o:(function __cfi___memcpy: .noinstr.text+0x4ac1): relocation R_X86_64_

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/135691 >From 949ec2a683faf53652b21a4c90206befa498bf4e Mon Sep 17 00:00:00 2001 From: Jeremy Drake Date: Mon, 14 Apr 2025 10:37:59 -0700 Subject: [PATCH 1/2] [Clang] [Driver] add a Cygwin ToolChain Add a new Cygwin

[clang-tools-extra] 665914f - [clangd] Improve `BlockEnd` inlayhint presentation (#136106)

2025-04-22 Thread via cfe-commits
Author: Mythreya Date: 2025-04-23T02:36:48-04:00 New Revision: 665914fea1433409015a87fef2837218bcd21460 URL: https://github.com/llvm/llvm-project/commit/665914fea1433409015a87fef2837218bcd21460 DIFF: https://github.com/llvm/llvm-project/commit/665914fea1433409015a87fef2837218bcd21460.diff LOG:

[clang] [llvm] [RISCV] Add Andes N45/NX45 processor definition (PR #136670)

2025-04-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang,llvm` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16478 Here is the relevant piece o

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/136106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ca3a5d3 - [Clang] [Driver] use __cxa_atexit by default on Cygwin. (#135701)

2025-04-22 Thread via cfe-commits
Author: jeremyd2019 Date: 2025-04-23T09:48:08+03:00 New Revision: ca3a5d37ef64668234cbce7236dd640a98e2d687 URL: https://github.com/llvm/llvm-project/commit/ca3a5d37ef64668234cbce7236dd640a98e2d687 DIFF: https://github.com/llvm/llvm-project/commit/ca3a5d37ef64668234cbce7236dd640a98e2d687.diff L

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Looks good, thank you! https://github.com/llvm/llvm-project/pull/136106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/135691 >From 949ec2a683faf53652b21a4c90206befa498bf4e Mon Sep 17 00:00:00 2001 From: Jeremy Drake Date: Mon, 14 Apr 2025 10:37:59 -0700 Subject: [PATCH 1/2] [Clang] [Driver] add a Cygwin ToolChain Add a new Cygwin

[clang] [Clang] [Driver] use __cxa_atexit by default on Cygwin. (PR #135701)

2025-04-22 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/135701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Infer MLIRContext in attr builders when possible (PR #136741)

2025-04-22 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/136741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo commented: What test coverage do we have for targeting cygwin with clang right now? Do we have enough tests to make sure that this is a refactoring, so things work mostly like before, but with better structured code? If not, we should probably add some sort of minim

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread Martin Storsjö via cfe-commits
@@ -180,35 +170,14 @@ bool InitHeaderSearch::AddUnmappedPath(const Twine &Path, IncludeDirGroup Group, return false; } -void InitHeaderSearch::AddMinGWCPlusPlusIncludePaths(StringRef Base, - StringRef Arch, -

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: Adding @MaskRay as the Clang Driver maintainer. https://github.com/llvm/llvm-project/pull/135691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo edited https://github.com/llvm/llvm-project/pull/135691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Constant-evaluate format strings as last resort (PR #135864)

2025-04-22 Thread via cfe-commits
@@ -6331,26 +6321,79 @@ static StringLiteralCheckType checkFormatStringExpr( } } -return SLCT_NotALiteral; +// try to constant-evaluate the string +break; } default: +// try to constant-evaluate the string +break; + } + + const StringLit

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [1/2] (PR #135444)

2025-04-22 Thread via cfe-commits
https://github.com/modiking edited https://github.com/llvm/llvm-project/pull/135444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: Oh, also, what's the tradeoff between having this extend the `Generic_GCC` driver, vs doing a plain from-scratch implementation that extents the `ToolChain` base class like the `MinGW` driver does? I guess that it's a smaller step to just tweak `Generic_GCC`, not requiring all

[clang] [Clang] [Driver] use __cxa_atexit by default on Cygwin. (PR #135701)

2025-04-22 Thread Martin Storsjö via cfe-commits
@@ -7230,7 +7230,9 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, // -fuse-cxa-atexit is default. if (!Args.hasFlag( options::OPT_fuse_cxa_atexit, options::OPT_fno_use_cxa_atexit, - !RawTriple.isOSAIX() && !RawTriple.isOSWindows() && +

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [2/2] (PR #136768)

2025-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: None (modiking) Changes Adds support for new Shared Cluster Memory Address Space (SHARED_CLUSTER, addrspace 7). See https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#distributed-shared-memory for details. Follow-up to http

[clang] [Clang] [Driver] use __cxa_atexit by default on Cygwin. (PR #135701)

2025-04-22 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/135701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread via cfe-commits
@@ -180,35 +170,14 @@ bool InitHeaderSearch::AddUnmappedPath(const Twine &Path, IncludeDirGroup Group, return false; } -void InitHeaderSearch::AddMinGWCPlusPlusIncludePaths(StringRef Base, - StringRef Arch, -

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread via cfe-commits
https://github.com/jeremyd2019 edited https://github.com/llvm/llvm-project/pull/135691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix a crash in constant evaluation of ExtVectorElementExprs (PR #136771)

2025-04-22 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/136771 Handle the case where the base expression is a pointer to a vector type. rdar://149223362 >From c8df1a51efd6349c5905b337059d597d3c1d7146 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 22 Apr 2025 12

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [1/2] (PR #135444)

2025-04-22 Thread via cfe-commits
https://github.com/modiking edited https://github.com/llvm/llvm-project/pull/135444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix a crash in constant evaluation of ExtVectorElementExprs (PR #136771)

2025-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Akira Hatanaka (ahatanak) Changes Handle the case where the base expression is a pointer to a vector type. rdar://149223362 --- Full diff: https://github.com/llvm/llvm-project/pull/136771.diff 2 Files Affected: - (modified) clang/lib/A

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [1/2] (PR #135444)

2025-04-22 Thread via cfe-commits
https://github.com/modiking edited https://github.com/llvm/llvm-project/pull/135444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] allow single element access of vector object to be constant expression (PR #101126)

2025-04-22 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: clang crashes compiling the following code. ``` typedef float float4 __attribute__((ext_vector_type(4))); constexpr float4 v{1,2,3,4}; constexpr const float4 *p = &v; constexpr float f = p->x; ``` I created a PR that fixes the crash: https://github.com/llvm/llvm-project/pull/13

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [2/2] (PR #136768)

2025-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (modiking) Changes Adds support for new Shared Cluster Memory Address Space (SHARED_CLUSTER, addrspace 7). See https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#distributed-shared-memory for details. Follow-up to htt

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread via cfe-commits
jeremyd2019 wrote: To me, the general theory is that Cygwin is more UNIXy than Windowsy, so I based this off of actually the Hurd.h/cpp (as it had pretty limited amounts of special cases). It looks to me like the #74933 PR followed the from-scratch ToolChain idea, and that probably accounts f

[clang] [mlir] [mlir][acc] Use consistent name for device_num operand (PR #136745)

2025-04-22 Thread Erich Keane via cfe-commits
erichkeane wrote: > > Also, we have `getIfCondMutable` in a number of places as well, which is > > now inconsistent with skipping the 'operand'. > > I am not sure I follow - are you saying that for consistency, you think that > the word 'operand' should be included in the name of `ifCond` (or

[clang] [clang][modules] Minor improvements to diagnosing `out of date` errors (PR #136612)

2025-04-22 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: > > What would happen if both A-1.pcm and A-2.pcm are built for the same files > > (e.g., from Sysroot) but have different file names? Not saying it is a > > valid use case to support, just curious what would happen. > > I tried this, where basically `A-1.pcm` is built again but

[clang] Fix a crash in constant evaluation of ExtVectorElementExprs (PR #136771)

2025-04-22 Thread Erich Keane via cfe-commits
@@ -9197,7 +9197,10 @@ bool LValueExprEvaluator::VisitExtVectorElementExpr( if (Success) { Result.setFrom(Info.Ctx, Val); -const auto *VT = E->getBase()->getType()->castAs(); +QualType BaseType = E->getBase()->getType(); +if (E->isArrow()) er

[clang] [WebKit checkers] Treat global const variables as safe (PR #136170)

2025-04-22 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/136170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Minor improvements to diagnosing `out of date` errors (PR #136612)

2025-04-22 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: Does the described test case look like a build system problem? In my understanding at step 4 we should have re-scanned B to know that we need some B'.pcm depending on A-2.pcm. Regardless of the answer I don't want to block the change as it is still an improvement. Just thinking

[clang] [llvm] User/raoanag/refract (PR #136026)

2025-04-22 Thread via cfe-commits
https://github.com/raoanag updated https://github.com/llvm/llvm-project/pull/136026 >From 3221715ed9c06f6ef05414ae79a6e3bc576d4ba8 Mon Sep 17 00:00:00 2001 From: Anagha Rajendra Rao Date: Wed, 16 Apr 2025 11:47:27 -0700 Subject: [PATCH 1/3] Refract implementation --- clang/test/CodeGenHLSL/bu

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread via cfe-commits
jeremyd2019 wrote: > > I don't have experience with llvm's test suite though, but if it's just a > > matter of adding additional cases to existing tests or maybe copying some > > existing tests I might be OK figuring it out. > > Yeah it's usually not that hard to figure out. A couple general p

[clang] 3d04da5 - [NVPTX] Add support for Shared Cluster Memory address space [2/2] (#136768)

2025-04-22 Thread via cfe-commits
Author: modiking Date: 2025-04-22T16:50:45-07:00 New Revision: 3d04da5bc022269b3238b2a84347dce7a7afd51b URL: https://github.com/llvm/llvm-project/commit/3d04da5bc022269b3238b2a84347dce7a7afd51b DIFF: https://github.com/llvm/llvm-project/commit/3d04da5bc022269b3238b2a84347dce7a7afd51b.diff LOG:

[clang] [clang] consistently quote expressions in diagnostics (PR #134769)

2025-04-22 Thread Henrik G. Olsson via cfe-commits
hnrklssn wrote: Right, yeah. Thanks for working on this! We have quite a few diagnostics for bounds safety to help guide users, so good diagnostics are important to us. https://github.com/llvm/llvm-project/pull/134769 ___ cfe-commits mailing list cfe-

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [2/2] (PR #136768)

2025-04-22 Thread via cfe-commits
https://github.com/modiking closed https://github.com/llvm/llvm-project/pull/136768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Rework `hasBooleanRepresentation`. (PR #136038)

2025-04-22 Thread John McCall via cfe-commits
rjmccall wrote: That's fine with me, yeah. https://github.com/llvm/llvm-project/pull/136038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [2/2] (PR #136768)

2025-04-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clangd-ubuntu-tsan` running on `clangd-ubuntu-clang` while building `clang,llvm,mlir` at step 6 "test-build-clangd-clangd-index-server-clangd-in...". Full details are available at: https://lab.llvm.org/buildbot/#/builders/134

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [2/2] (PR #136768)

2025-04-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-runtime-cuda-clang` running on `as-builder-7` while building `clang,llvm,mlir` at step 7 "build-flang-default". Full details are available at: https://lab.llvm.org/buildbot/#/builders/7/builds/13803 Here is the releva

[clang] [HLSL] Use hlsl_device address space for getpointer. (PR #127675)

2025-04-22 Thread Steven Perron via cfe-commits
https://github.com/s-perron updated https://github.com/llvm/llvm-project/pull/127675 >From 2a288bc3528ae63f05551492518cbf500689108d Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Wed, 12 Feb 2025 15:45:32 -0500 Subject: [PATCH 1/6] [HLSL] Use hlsl_device address space for getpointer. We ad

[clang] [clang] Fix a use-after-free in expression evaluation (PR #118480)

2025-04-22 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: @kadircet let's team up tomorrow and poke at what's happening with the smaller reproducer to figure out if this is the right fix? @AaronBallman I was initially concerned that it would be incorrect to consider the compound literal expression a full expression even if it fix

[clang] [Clang] Remove use after move of lambda (PR #136728)

2025-04-22 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik created https://github.com/llvm/llvm-project/pull/136728 Static analysis flagged this use after move. It is undefined behavior and I don't see any possible performance gains here to attempt to do anything else but simply remove it. >From 693a1f38d9a28ef515ccb738bee62

[clang] [Clang] Remove use after move of lambda (PR #136728)

2025-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes Static analysis flagged this use after move. It is undefined behavior and I don't see any possible performance gains here to attempt to do anything else but simply remove it. --- Full diff: https://github

[clang] c05da6e - [OpenACC][CIR] Implement lowering for 'set' clauses

2025-04-22 Thread via cfe-commits
Author: erichkeane Date: 2025-04-22T10:06:28-07:00 New Revision: c05da6e8611e4da7b16729cc2b8d2dc6c77ba4be URL: https://github.com/llvm/llvm-project/commit/c05da6e8611e4da7b16729cc2b8d2dc6c77ba4be DIFF: https://github.com/llvm/llvm-project/commit/c05da6e8611e4da7b16729cc2b8d2dc6c77ba4be.diff LO

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/136729 Summary: Currently we build the OpenMP device runtime as part of the `offload/` project. This is problematic because it has several restrictions when compared to the normal offloading runtime. It can only be buil

[clang] [Clang] Remove use after move of lambda (PR #136728)

2025-04-22 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/136728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a use-after-free in expression evaluation (PR #118480)

2025-04-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @kadircet let's team up tomorrow and poke at what's happening with the > smaller reproducer to figure out if this is the right fix? > > @AaronBallman I was initially concerned that it would be incorrect to > consider the compound literal expression a full expression even

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/136729 >From ee6ca9501a07746c446a106619567d3faff07e98 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 22 Apr 2025 12:05:42 -0500 Subject: [PATCH] [OpenMP] Change build of OpenMP device runtime to be a separate

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: Currently we build the OpenMP device runtime as part of the `offload/` project. This is problematic because it has several restrictions when compared to the normal offloading runtime. It can on

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: Currently we build the OpenMP device runtime as part of the `offload/` project. This is problematic because it has several restrictions when compared to the normal offloading runtime. It can only be b

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread via cfe-commits
jeremyd2019 wrote: I tried to exercise both the -msys and -cygwin directory structures in these tests - I alternated between i686 and x86_64 in the normal and cross basic trees. https://github.com/llvm/llvm-project/pull/135691 ___ cfe-commits mailing

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/135691 >From 949ec2a683faf53652b21a4c90206befa498bf4e Mon Sep 17 00:00:00 2001 From: Jeremy Drake Date: Mon, 14 Apr 2025 10:37:59 -0700 Subject: [PATCH 1/2] [Clang] [Driver] add a Cygwin ToolChain Add a new Cygwin

[clang] 832ca74 - [RISCV] Add Andes N45/NX45 processor definition (#136670)

2025-04-22 Thread via cfe-commits
Author: Jim Lin Date: 2025-04-23T14:16:23+08:00 New Revision: 832ca744f2f25a7a5334f2f04380c84e41f71678 URL: https://github.com/llvm/llvm-project/commit/832ca744f2f25a7a5334f2f04380c84e41f71678 DIFF: https://github.com/llvm/llvm-project/commit/832ca744f2f25a7a5334f2f04380c84e41f71678.diff LOG:

[clang] [llvm] [RISCV] Add Andes N45/NX45 processor definition (PR #136670)

2025-04-22 Thread Jim Lin via cfe-commits
https://github.com/tclin914 closed https://github.com/llvm/llvm-project/pull/136670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM][AArch64] Don't require arm_acle header for universally defined intrinsics (PR #136742)

2025-04-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,c,h -- clang/lib/Headers/arm_acle.h clang/test/CodeGen/

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-04-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: For the new test files, is it possible to precommit them? I think it will be easier to review the delta. https://github.com/llvm/llvm-project/pull/135836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-04-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/135836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-04-22 Thread via cfe-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/123609 >From 210b6d80bcfbbcd216f98199df386280724561e2 Mon Sep 17 00:00:00 2001 From: jofernau Date: Mon, 20 Jan 2025 04:51:26 -0800 Subject: [PATCH 01/12] [TargetVerifier][AMDGPU] Add TargetVerifier. This pass verifies

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [1/2] (PR #135444)

2025-04-22 Thread via cfe-commits
modiking wrote: Thanks for the thorough review! I'm splitting this so that this change only contains the addrspace + new instructions/intrinsics and the follow-up PR https://github.com/llvm/llvm-project/pull/136768 is updating the existing intrinsics. https://github.com/llvm/llvm-project/pull

[clang] [Clang] [Driver] use __cxa_atexit by default on Cygwin. (PR #135701)

2025-04-22 Thread via cfe-commits
https://github.com/jeremyd2019 edited https://github.com/llvm/llvm-project/pull/135701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Constant-evaluate format strings as last resort (PR #135864)

2025-04-22 Thread via cfe-commits
=?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier Message-ID: In-Reply-To: https://github.com/apple-fcloutier updated https://github.com/llvm/llvm-project/pull/135864 >From 7e15ec24e6de96b9828f13f21099446e55831591 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix=20Cloutier?= Date: T

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [2/2] (PR #136768)

2025-04-22 Thread via cfe-commits
https://github.com/modiking edited https://github.com/llvm/llvm-project/pull/136768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Adding an API to create a `CXStringSet` from a Vector of `StringRef`s (PR #136773)

2025-04-22 Thread Jan Svoboda via cfe-commits
@@ -116,6 +117,13 @@ CXStringSet *createSet(const std::vector &Strings) { return Set; } +CXStringSet *createSet(const std::vector &Strings) { + return createSetImpl(Strings); +} + +CXStringSet *createSet(const std::vector &Strings) { + return createSetImpl(Strings); -

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-22 Thread via cfe-commits
jeremyd2019 wrote: > I see that that patch also contains some similar cleanups to > InitHeaderSearch.cpp - do these patches share some common ancestry (e.g. some > cygwin specific clang patchsets that have been floating around somewhere?). No, I wasn't aware of that PR, I noticed that using Ge

[clang] [llvm] Reland "[HLSL][RootSignature] Implement initial parsing of the descriptor table clause params" (PR #136740)

2025-04-22 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt approved this pull request. https://github.com/llvm/llvm-project/pull/136740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d6a68be - [NVPTX] Add support for Shared Cluster Memory address space [1/2] (#135444)

2025-04-22 Thread via cfe-commits
Author: modiking Date: 2025-04-22T15:14:39-07:00 New Revision: d6a68be7af0e1cec95e5fb9442dc1867cbde9f8d URL: https://github.com/llvm/llvm-project/commit/d6a68be7af0e1cec95e5fb9442dc1867cbde9f8d DIFF: https://github.com/llvm/llvm-project/commit/d6a68be7af0e1cec95e5fb9442dc1867cbde9f8d.diff LOG:

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space [1/2] (PR #135444)

2025-04-22 Thread via cfe-commits
https://github.com/modiking closed https://github.com/llvm/llvm-project/pull/135444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add `noalias` to `this` pointer in C++ constructors (PR #136792)

2025-04-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/CodeGen/CodeGenFunction.cpp ``

[clang] [Clang] Add `noalias` to `this` pointer in C++ constructors (PR #136792)

2025-04-22 Thread Guy David via cfe-commits
https://github.com/guy-david edited https://github.com/llvm/llvm-project/pull/136792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add `noalias` to `this` pointer in C++ constructors (PR #136792)

2025-04-22 Thread Guy David via cfe-commits
https://github.com/guy-david created https://github.com/llvm/llvm-project/pull/136792 Note: the patch is probably amending the wrong piece of code, I've tried to add it to `buildThisParam` but hit an assertion because of a missing translation unit context. Clang, unlike GCC, does not transfor

[clang] [Clang] Add `noalias` to `this` pointer in C++ constructors (PR #136792)

2025-04-22 Thread Guy David via cfe-commits
https://github.com/guy-david edited https://github.com/llvm/llvm-project/pull/136792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add `noalias` to `this` pointer in C++ constructors (PR #136792)

2025-04-22 Thread Guy David via cfe-commits
https://github.com/guy-david edited https://github.com/llvm/llvm-project/pull/136792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add `noalias` to `this` pointer in C++ constructors (PR #136792)

2025-04-22 Thread Guy David via cfe-commits
https://github.com/guy-david edited https://github.com/llvm/llvm-project/pull/136792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid diagnosing std::array initializations for modernize-use-designated-initializers (PR #134774)

2025-04-22 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 requested changes to this pull request. exclude std::array don't resolve problem here. It can also happen in user defined class. e.g. https://godbolt.org/z/cn46MT5Mn https://github.com/llvm/llvm-project/pull/134774 ___ c

[clang-tools-extra] [clang-tidy] Avoid diagnosing std::array initializations for modernize-use-designated-initializers (PR #134774)

2025-04-22 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/134774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid diagnosing std::array initializations for modernize-use-designated-initializers (PR #134774)

2025-04-22 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/134774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tide] added `AllowedTypes` option to `readability-qualified-auto` check (PR #136571)

2025-04-22 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/136571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Minor improvements to diagnosing `out of date` errors (PR #136612)

2025-04-22 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/136612 >From 046b60179ee5eddc6db2193406bfc2ef10fda3df Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Mon, 21 Apr 2025 13:20:12 -0700 Subject: [PATCH 1/5] [clang][Modules] Report when` lookupModuleFile` fails and

[clang] [flang] Add IR Profile-Guided Optimization (IR PGO) support to the Flang compiler (PR #136098)

2025-04-22 Thread via cfe-commits
https://github.com/fanju110 updated https://github.com/llvm/llvm-project/pull/136098 >From 9494c9752400e4708dbc8b6a5ca4993ea9565e95 Mon Sep 17 00:00:00 2001 From: fanyikang Date: Thu, 17 Apr 2025 15:17:07 +0800 Subject: [PATCH 1/2] Add support for IR PGO (-fprofile-generate/-fprofile-use=/file

[clang] [llvm] [RISCV] Add Andes N45/NX45 processor definition (PR #136670)

2025-04-22 Thread Jim Lin via cfe-commits
@@ -625,3 +625,33 @@ def RP2350_HAZARD3 : RISCVProcessorModel<"rp2350-hazard3", FeatureStdExtZbkb, FeatureStdExtZcb, FeatureStdExtZcmp]>; + +def ANDES_N

[clang] [llvm] [RISCV] Add Andes N45/NX45 processor definition (PR #136670)

2025-04-22 Thread Jim Lin via cfe-commits
@@ -625,3 +625,33 @@ def RP2350_HAZARD3 : RISCVProcessorModel<"rp2350-hazard3", FeatureStdExtZbkb, FeatureStdExtZcb, FeatureStdExtZcmp]>; + +def ANDES_N

[clang-tools-extra] [clang-tidy] Avoid diagnosing std::array initializations for modernize-use-designated-initializers (PR #134774)

2025-04-22 Thread Congcong Cai via cfe-commits
@@ -209,3 +209,18 @@ struct S15{ S15(S14& d):d{d}{} S14& d; }; + +//Issue #133715 +namespace std { HerrCai0907 wrote: clang-tidy@main will also not give warning for this code. https://github.com/llvm/llvm-project/pull/134774 __

[clang-tools-extra] [clang-tidy] Avoid diagnosing std::array initializations for modernize-use-designated-initializers (PR #134774)

2025-04-22 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/134774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/C++] Fix clang_File_isEqual for in-memory files (PR #135773)

2025-04-22 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: @AaronBallman ping/reminder for a review 🙇 https://github.com/llvm/llvm-project/pull/135773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Andes N45/NX45 processor definition (PR #136670)

2025-04-22 Thread Jim Lin via cfe-commits
https://github.com/tclin914 updated https://github.com/llvm/llvm-project/pull/136670 >From df3a0b2bd9cb31fc8e252e250d3107dd1ac2cc0b Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Tue, 22 Apr 2025 10:12:23 +0800 Subject: [PATCH 1/2] [RISCV] Add Andes N45/NX45 processor definition Andes N45/NX45 a

[clang] [docs] Fix the use of word "dependent" and other typos in the C++ Modules Doc (PR #136719)

2025-04-22 Thread Chuanqi Xu via cfe-commits
@@ -477,21 +476,21 @@ When the ``-fmodules-embed-all-files`` flag are enabled, Clang explicitly emits code into the BMI file, the contents of the BMI file contain a sufficiently verbose representation to reproduce the original source file. -:sup:`1`` Input files: The source

[clang] [docs] Fix the use of word "dependent" and other typos in the C++ Modules Doc (PR #136719)

2025-04-22 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/136719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs] Fix the use of word "dependent" and other typos in the C++ Modules Doc (PR #136719)

2025-04-22 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. I am not a native speaker. So LGTM generally. https://github.com/llvm/llvm-project/pull/136719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang-tools-extra] [clang-tidy] Avoid diagnosing std::array initializations for modernize-use-designated-initializers (PR #134774)

2025-04-22 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 deleted https://github.com/llvm/llvm-project/pull/134774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Enable -fextend-lifetimes at -Og (PR #118026)

2025-04-22 Thread via cfe-commits
gulfemsavrun wrote: We started seeing the following failure, and I bisected it to this commit. ``` [1343/43547](319) CXX host_x64/obj/third_party/protobuf/src/google/protobuf/libprotobuf_lite.generated_message_tctable_lite.cc.o FAILED: [code=1] host_x64/obj/third_party/protobuf/src/google/proto

<    1   2   3   4   >