https://github.com/Sirraide approved this pull request.
https://github.com/llvm/llvm-project/pull/136323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,77 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Werror=unreachable-code-aggressive %s
+
+// Test that analysis-based warnings honor #pragma diagnostic controls. These
+// diagnostics are triggered at the end of a function body, so the pragma needs
+// to be enabled thr
@@ -0,0 +1,77 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Werror=unreachable-code-aggressive %s
+
+// Test that analysis-based warnings honor #pragma diagnostic controls. These
+// diagnostics are triggered at the end of a function body, so the pragma needs
+// to be enabled thr
@@ -1202,6 +1202,30 @@ Clang also allows you to push and pop the current
warning state. This is
particularly useful when writing a header file that will be compiled by
other people, because you don't know what warning flags they build with.
+Note that the following diagnostic
andykaylor wrote:
@xlauko Are you happy with this after the latest update?
https://github.com/llvm/llvm-project/pull/136036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 approved this pull request.
Ok, LGTM as a targeted fix.
https://github.com/llvm/llvm-project/pull/136227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/yxsamliu approved this pull request.
https://github.com/llvm/llvm-project/pull/135979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1202,6 +1202,30 @@ Clang also allows you to push and pop the current
warning state. This is
particularly useful when writing a header file that will be compiled by
other people, because you don't know what warning flags they build with.
+Note that the following diagnostic
a-tarasyuk wrote:
@AaronBallman Should this issue ideally be resolved by CFG rather than the
current AST matcher fix?
https://github.com/llvm/llvm-project/pull/135573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
kpneal wrote:
> I don't see the necessity of using operand bundles. All of the possible
> arguments are metadata strings, not SSA values. Can't we just use metadata
> instead?
Operand bundles are replacing the constrained intrinsics so we can use the
bundles on the hundreds (thousands?) of in
@@ -1049,6 +1049,7 @@ Parser::ParseExternalDeclaration(ParsedAttributes &Attrs,
case tok::kw_extern:
if (getLangOpts().CPlusPlus && NextToken().is(tok::kw_template)) {
+ ProhibitAttributes(Attrs);
erichkeane wrote:
It is prohibited by the grammar f
https://github.com/xlauko created
https://github.com/llvm/llvm-project/pull/136362
None
>From 2c711e7f5365c1fe6a34254f69c6480a469aebe7 Mon Sep 17 00:00:00 2001
From: xlauko
Date: Fri, 18 Apr 2025 21:59:30 +0200
Subject: [PATCH] [CIR] Infer MLIR context in type builders when possible
---
clan
xlauko wrote:
* **#136362** https://app.graphite.dev/github/pr/llvm/llvm-project/136362?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/13636
https://github.com/xlauko closed
https://github.com/llvm/llvm-project/pull/136361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/xlauko edited
https://github.com/llvm/llvm-project/pull/136361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/xlauko ready_for_review
https://github.com/llvm/llvm-project/pull/136362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clangir
Author: Henrich Lauko (xlauko)
Changes
This mirrors incubator changes from https://github.com/llvm/clangir/pull/1570
---
Full diff: https://github.com/llvm/llvm-project/pull/136362.diff
4 Files Affected:
- (modified) clang/include/clang/CIR/D
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Henrich Lauko (xlauko)
Changes
This mirrors incubator changes from https://github.com/llvm/clangir/pull/1570
---
Full diff: https://github.com/llvm/llvm-project/pull/136362.diff
4 Files Affected:
- (modified) clang/include/clang/CIR/Dia
https://github.com/xlauko edited
https://github.com/llvm/llvm-project/pull/136362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/14726
Here is the relevant piece of the build lo
https://github.com/xlauko created
https://github.com/llvm/llvm-project/pull/136366
None
>From 510777f925c25f957567fd874b4474c848b359dc Mon Sep 17 00:00:00 2001
From: xlauko
Date: Fri, 18 Apr 2025 22:34:24 +0200
Subject: [PATCH] [CIR][NFC] Simplify BoolAttr builders
---
.../clang/CIR/Dialect/
xlauko wrote:
* **#136366** https://app.graphite.dev/github/pr/llvm/llvm-project/136366?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/13636
llvmbot wrote:
@llvm/pr-subscribers-clangir
Author: Henrich Lauko (xlauko)
Changes
This mirrors incubator changes from https://github.com/llvm/clangir/pull/1572
---
Full diff: https://github.com/llvm/llvm-project/pull/136366.diff
6 Files Affected:
- (modified) clang/include/clang/CIR/D
@@ -92,16 +92,10 @@ bool Preprocessor::EnterSourceFile(FileID FID,
ConstSearchDirIterator CurDir,
}
Lexer *TheLexer = new Lexer(FID, *InputFile, *this, IsFirstIncludeOfFile);
- if (getPreprocessorOpts().DependencyDirectivesForFile &&
- FID != PredefinesFileID) {
-
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/136073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/136295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-x64-windows-msvc`
running on `windows-gcebot2` while building `clang,llvm` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/63/builds/5194
Here is the relevant piece of the
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Paul Kirth (ilovepi)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136390.diff
1 Files Affected:
- (modified) clang-tools-extra/clang-doc/BitcodeReader.cpp (+3-3)
``diff
diff --git a/clang-tool
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Paul Kirth (ilovepi)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136394.diff
1 Files Affected:
- (modified) clang-tools-extra/clang-doc/Representation.cpp (+1-1)
``diff
diff --git a/clang-too
ilovepi wrote:
### Merge activity
* **Apr 18, 9:05 PM EDT**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/135515).
https://github.com/llvm/llvm-project/pull/135515
Author: Paul Kirth
Date: 2025-04-18T18:08:06-07:00
New Revision: 5c3789811fd5b50df1178e7068efb75c5b359383
URL:
https://github.com/llvm/llvm-project/commit/5c3789811fd5b50df1178e7068efb75c5b359383
DIFF:
https://github.com/llvm/llvm-project/commit/5c3789811fd5b50df1178e7068efb75c5b359383.diff
LO
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/135457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/136391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Paul Kirth
Date: 2025-04-18T18:06:57-07:00
New Revision: 062db99353749ec73a19b030b5553beee59cb0c0
URL:
https://github.com/llvm/llvm-project/commit/062db99353749ec73a19b030b5553beee59cb0c0
DIFF:
https://github.com/llvm/llvm-project/commit/062db99353749ec73a19b030b5553beee59cb0c0.diff
LO
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/135515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
### Merge activity
* **Apr 18, 9:06 PM EDT**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/135457).
https://github.com/llvm/llvm-project/pull/135457
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/112020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -34,21 +34,22 @@ void test_invalid_call_1(int s) {
int some_func2(int a, int b);
void test_invalid_call_2() {
- // CHECK: -RecoveryExpr {{.*}} 'int' contains-errors
+ // CHECK: -RecoveryExpr {{.*}} '' contains-errors
zyn0217 wrote:
We used to call Ac
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/135903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2025-04-18T18:11:56-07:00
New Revision: c64f670255d3fa279f026994da2cd80f3394e0c8
URL:
https://github.com/llvm/llvm-project/commit/c64f670255d3fa279f026994da2cd80f3394e0c8
DIFF:
https://github.com/llvm/llvm-project/commit/c64f670255d3fa279f026994da2cd80f3394e0c8.diff
LOG:
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/136391
>From e5bfab96095a222dfef54fffb6eaf52a3994af80 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Fri, 18 Apr 2025 17:13:37 -0700
Subject: [PATCH] [clang-doc] Prefer static functions for internal APIs
---
clang-t
https://github.com/MaskRay approved this pull request.
LGTM!
(I will have limited internet access between April 20th and May 4th, and my
response time may be delayed..)
https://github.com/llvm/llvm-project/pull/100714
___
cfe-commits mailing list
cf
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/136394
None
>From f90ab6839b75906a2444868c43086c5d6ed759f5 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Fri, 18 Apr 2025 18:01:43 -0700
Subject: [PATCH] [clang-doc][NFC] Use qualified auto
---
clang-tools-extra/c
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/136394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/136390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
* **#136394** https://app.graphite.dev/github/pr/llvm/llvm-project/136394?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1363
Author: Owen Pan
Date: 2025-04-18T18:13:02-07:00
New Revision: 58a5c469d97302bb33a54338cf827a4cbe4e416a
URL:
https://github.com/llvm/llvm-project/commit/58a5c469d97302bb33a54338cf827a4cbe4e416a
DIFF:
https://github.com/llvm/llvm-project/commit/58a5c469d97302bb33a54338cf827a4cbe4e416a.diff
LOG:
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/136281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2025-04-18T18:12:27-07:00
New Revision: ab4c939579fe6ca85d9a1022511635c4e6f83f55
URL:
https://github.com/llvm/llvm-project/commit/ab4c939579fe6ca85d9a1022511635c4e6f83f55
DIFF:
https://github.com/llvm/llvm-project/commit/ab4c939579fe6ca85d9a1022511635c4e6f83f55.diff
LOG:
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/136391
>From b4ab90404dc4011720dbd0d52774f02790143da6 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Fri, 18 Apr 2025 17:13:37 -0700
Subject: [PATCH] [clang-doc] Prefer static functions for internal APIs
Additionally
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
clang-tools-extra/clang-doc/BitcodeReader.cpp
clan
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/136391
>From ec8bd52ba80c206a2de1f3958948dfce038ed9fd Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Fri, 18 Apr 2025 17:13:37 -0700
Subject: [PATCH] [clang-doc] Prefer static functions for internal APIs
Additionally
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/136389
>From cbde7084f9e465fb0053cf4b7d2e6aed52fd249b Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Fri, 18 Apr 2025 17:13:54 -0700
Subject: [PATCH] [clang-doc][NFC] Avoid else after return
---
clang-tools-extra/cl
Author: Alex Rønne Petersen
Date: 2025-04-19T04:09:58+02:00
New Revision: 6311b11595f152a8f4aa02cfa544e72ede66688a
URL:
https://github.com/llvm/llvm-project/commit/6311b11595f152a8f4aa02cfa544e72ede66688a
DIFF:
https://github.com/llvm/llvm-project/commit/6311b11595f152a8f4aa02cfa544e72ede66688a
https://github.com/alexrp closed
https://github.com/llvm/llvm-project/pull/100714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -34,21 +34,22 @@ void test_invalid_call_1(int s) {
int some_func2(int a, int b);
void test_invalid_call_2() {
- // CHECK: -RecoveryExpr {{.*}} 'int' contains-errors
+ // CHECK: -RecoveryExpr {{.*}} '' contains-errors
zyn0217 wrote:
And as for concept
dtcxzyw wrote:
> This change broke a couple of ubsan tests on i686 on Windows (i.e. a 32 bit
> environment):
> https://github.com/mstorsjo/llvm-mingw/actions/runs/14527591706/job/40770945907
>
> The failing tests are
> https://github.com/llvm/llvm-project/blob/llvmorg-20.1.3/compiler-rt/test/
@@ -34,21 +34,22 @@ void test_invalid_call_1(int s) {
int some_func2(int a, int b);
void test_invalid_call_2() {
- // CHECK: -RecoveryExpr {{.*}} 'int' contains-errors
+ // CHECK: -RecoveryExpr {{.*}} '' contains-errors
mizvekov wrote:
If calling ActOnC
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
https://github.com/xlauko closed
https://github.com/llvm/llvm-project/pull/136362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
@@ -456,9 +456,7 @@ mlir::LogicalResult CIRGenFunction::emitForStmt(const
ForStmt &s) {
// scalar type.
condVal = evaluateExprAsBool(s.getCond());
} else {
-cir::BoolType boolTy = cir::BoolType::get(b.getContext());
-co
@@ -692,9 +692,7 @@ mlir::LogicalResult
CIRToLLVMConstantOpLowering::matchAndRewrite(
// during a pass as long as they don't live past the end of the pass.
attr = op.getValue();
} else if (mlir::isa(op.getType())) {
-int value = (op.getValue() ==
-
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
@@ -692,9 +692,7 @@ mlir::LogicalResult
CIRToLLVMConstantOpLowering::matchAndRewrite(
// during a pass as long as they don't live past the end of the pass.
attr = op.getValue();
} else if (mlir::isa(op.getType())) {
-int value = (op.getValue() ==
-
https://github.com/anutosh491 edited
https://github.com/llvm/llvm-project/pull/136404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -202,6 +202,43 @@ class SemaPPCallbacks : public PPCallbacks {
break;
}
}
+ void PragmaDiagnostic(SourceLocation Loc, StringRef Namespace,
+diag::Severity Mapping, StringRef Str) override {
+// If one of the analysis-based diagnostics
@@ -0,0 +1,6 @@
+/// Check that -Xclangas/-Xclangas= are passed to -cc1as.
+// RUN: %clang -### -Xclangas -target-feature -Xclangas=+v5t %s 2>&1 | \
+// RUN: FileCheck -check-prefix=ARGS %s
+// ARGS: -cc1as
+// ARGS: -target-feature
MaskRay wrote:
Use `-SAME:`
@@ -0,0 +1,6 @@
+/// Check that -Xclangas/-Xclangas= are passed to -cc1as.
+// RUN: %clang -### -Xclangas -target-feature -Xclangas=+v5t %s 2>&1 | \
MaskRay wrote:
Also add a `-Werror` to test `Arg->claim();`. I haven't tested, but without
`Arg->claim();` there
@@ -0,0 +1,6 @@
+/// Check that -Xclangas/-Xclangas= are passed to -cc1as.
+// RUN: %clang -### -Xclangas -target-feature -Xclangas=+v5t %s 2>&1 | \
+// RUN: FileCheck -check-prefix=ARGS %s
MaskRay wrote:
unnecessary to use a custom check prefix. Just omit it a
haoNoQ wrote:
> The current patch actually WILL work with it ONLY enabled on the line inside
> of the function, which I think is much more intuitive.
Ooo whoa this is awesome!!
https://github.com/llvm/llvm-project/pull/136323
___
cfe-commits mailing
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/135372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Petr Hosek (petrhosek)
Changes
We aren't distributing any shared libraries so we don't need PIC and using PIE
instead of PIC can improve performance.
---
Full diff: https://github.com/llvm/llvm-project/pull/136376.diff
1 Files Affected:
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/136376
We aren't distributing any shared libraries so we don't need PIC and using PIE
instead of PIC can improve performance.
>From 55816661f262410862b91e8e54e2f2d947af11fb Mon Sep 17 00:00:00 2001
From: Petr Hosek
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`libc-x86_64-debian-dbg-bootstrap-build` running on `libc-x86_64-debian` while
building `clang,llvm` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/200/builds/7666
Here is the r
delcypher wrote:
I had to tweak some minor issues with the diagnostic text that I discovered
when trying to cherry pick this into our fork. I've fixed them and I'm going to
land this now.
https://github.com/llvm/llvm-project/pull/106321
___
cfe-commi
https://github.com/delcypher closed
https://github.com/llvm/llvm-project/pull/106321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win`
running on `as-builder-10` while building `clang,llvm` at step 13
"build-lldb-server-aarch64-lldb".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/197/builds/4212
Here is the
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/136328
>From 0729ae4d4a971905aefc8f1c1ec2ec81a0f149e9 Mon Sep 17 00:00:00 2001
From: Oleksandr Tarasiuk
Date: Fri, 18 Apr 2025 20:09:56 +0300
Subject: [PATCH 1/2] [Clang] disallow use of attributes before extern tem
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -std=c99 -fsyntax-only -pedantic %s 2>&1 | grep 'warning:
this style of line directive is a GNU extension'
MaskRay wrote:
We prefer `FileCheck` to `grep`. FileCheck enables testing the line number, e.g.
```
// CHECK: [[#@LINE
@@ -2268,17 +2268,15 @@ static bool IsStandardConversion(Sema &S, Expr* From,
QualType ToType,
// handling here.
if (ToType->isArrayParameterType()) {
FromType = S.Context.getArrayParameterType(FromType);
- SCS.First = ICK_HLSL_Array_RValue;
} else if (
@@ -0,0 +1,6 @@
+/// Check that -Xclangas/-Xclangas= are passed to -cc1as.
+// RUN: %clang -### -Xclangas -target-feature -Xclangas=+v5t %s 2>&1 | \
alexrp wrote:
Tested locally and you're right!
https://github.com/llvm/llvm-project/pull/100714
_
https://github.com/shafik commented:
I am going to chime in, in support of both Aaron's and Erich's position here.
This does not seem like an extension we want to support.
So given the objections, we need at minimum an RFC and see how that goes. Maybe
during that discussion a more compelling c
https://github.com/spall updated
https://github.com/llvm/llvm-project/pull/134174
>From 5d81a4b7b034dd5999feb6ab37537270d6bae2a8 Mon Sep 17 00:00:00 2001
From: Sarah Spall
Date: Wed, 2 Apr 2025 12:04:18 -0700
Subject: [PATCH 1/2] compare unqualified canonical types and add an hlsl array
rvalue
https://github.com/erichkeane approved this pull request.
Seems reasonable to me, but not the best one to review this.
I question stealing `ty` as the prefix to this instead of `rt` (or something
more specific to records), but I'm not sure I feel particularly strongly. Just
it seems that `t
@@ -456,9 +456,7 @@ mlir::LogicalResult CIRGenFunction::emitForStmt(const
ForStmt &s) {
// scalar type.
condVal = evaluateExprAsBool(s.getCond());
} else {
-cir::BoolType boolTy = cir::BoolType::get(b.getContext());
-co
https://github.com/andykaylor approved this pull request.
This looks good. Thanks for the improvements! I just have a couple of questions.
https://github.com/llvm/llvm-project/pull/136366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
https://github.com/andykaylor edited
https://github.com/llvm/llvm-project/pull/136366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -692,9 +692,7 @@ mlir::LogicalResult
CIRToLLVMConstantOpLowering::matchAndRewrite(
// during a pass as long as they don't live past the end of the pass.
attr = op.getValue();
} else if (mlir::isa(op.getType())) {
-int value = (op.getValue() ==
-
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andy Kaylor (andykaylor)
Changes
This adds ClangIR support for accessing structure members. Access to union
members is deferred to a later change.
---
Patch is 32.62 KiB, truncated to 20.00 KiB below, full version:
https://github.com/ll
https://github.com/andykaylor created
https://github.com/llvm/llvm-project/pull/136383
This adds ClangIR support for accessing structure members. Access to union
members is deferred to a later change.
>From 17800eddb70a74cf3966d64ab7bc5ad5508f8bb0 Mon Sep 17 00:00:00 2001
From: Andy Kaylor
Da
https://github.com/alexrp updated
https://github.com/llvm/llvm-project/pull/100714
From d98b9b4ab5b2d181b76d23b48eb2e93c0bc8afc8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?=
Date: Fri, 26 Jul 2024 09:40:42 +0200
Subject: [PATCH] [clang][Driver] Support passing arbitra
pestctrl wrote:
@efriedma-quic No, I will push this on Monday. Thank you!
https://github.com/llvm/llvm-project/pull/89654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Selim Keles
Date: 2025-04-18T19:42:22-07:00
New Revision: 0c0b5abff7ebedde53ccb84a04dadb00b9b91f2b
URL:
https://github.com/llvm/llvm-project/commit/0c0b5abff7ebedde53ccb84a04dadb00b9b91f2b
DIFF:
https://github.com/llvm/llvm-project/commit/0c0b5abff7ebedde53ccb84a04dadb00b9b91f2b.diff
L
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/135779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136396.diff
1 Files Affected:
- (modified) clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.cpp
(+1-3)
``diff
diff
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/136396
None
>From c3f948665677851851abedfbb6cf11fe88fa4334 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Fri, 18 Apr 2025 10:09:47 -0700
Subject: [PATCH] [clang-tidy] Use llvm::less_second (NFC)
---
clang-
301 - 400 of 574 matches
Mail list logo
