[clang] [llvm] [X86][AVX10] Remove VAES and VPCLMULQDQ feature from AVX10.1 (PR #135489)

2025-04-15 Thread Evgenii Kudriashov via cfe-commits
https://github.com/e-kud approved this pull request. LGTM. For the particular arches, `vaes`, `vpclmulqdq` are inherited from `ICLAdditionalFeatures`. So we shouldn't miss them in the future. https://github.com/llvm/llvm-project/pull/135489 ___ cfe-co

[clang] [clang] Mark some language options as benign. (PR #131569)

2025-04-15 Thread via cfe-commits
cor3ntin wrote: I think this looks fine but I'd like @Bigcheese @erichkeane @AaronBallman to look at it too. https://github.com/llvm/llvm-project/pull/131569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [Clang][Sema]:Fix musttail attribute on a function with not_tail_called attribute has no warning/error (PR #134465)

2025-04-15 Thread Aaron Ballman via cfe-commits
@@ -717,6 +717,12 @@ bool Sema::checkMustTailAttr(const Stmt *St, const Attr &MTA) { return false; } + if (const FunctionDecl *CalleeDecl = CE->getDirectCallee(); + CalleeDecl && CalleeDecl->hasAttr()) { +Diag(St->getBeginLoc(), diag::err_musttail_mismatch) <<

[clang] [RFC] Initial implementation of P2719 (PR #113510)

2025-04-15 Thread Oliver Hunt via cfe-commits
ojhunt wrote: It's even more dumb, but I have this fixed and am writing tests https://github.com/llvm/llvm-project/pull/113510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][llvm] Implement fp8 FMOP4A intrinsics (PR #130127)

2025-04-15 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. The patch looks good to me https://github.com/llvm/llvm-project/pull/130127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [llvm] [NFC] Fix xmipscmov extension name (PR #135647)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Djordje Todorovic (djtodoro) Changes The right name was used in riscv-toolchain-conventions docs. --- Full diff: https://github.com/llvm/llvm-project/pull/135647.diff 15 Files Affected: - (modified) clang/test/Driver/print-supported-ext

[clang] [MS][clang] Revert vector deleting destructors support (PR #135611)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes Finding operator delete[] is still problematic, without it the extension is a security hazard, so reverting until the problem with operator delete[] is figured out. --- Patch is 86.63 KiB, trunc

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-15 Thread Zahira Ammarguellat via cfe-commits
@@ -349,6 +349,17 @@ Improvements to Clang's diagnostics - Now correctly diagnose a tentative definition of an array with static storage duration in pedantic mode in C. (#GH50661) +- ``-Whigher-precisision-for-complex-divison`` no longer incorrectly warns when the divisor i

[clang] [Clang][Sema]:Fix musttail attribute on a function with not_tail_called attribute has no warning/error (PR #134465)

2025-04-15 Thread via cfe-commits
MillePlateaux wrote: @erichkeane @AaronBallman This is my first time participating in an open source project. I would like to ask if you have the same opinion so far. I have revised many versions over and over again. I just hope that the requirements can be clarified. https://github.com/llvm/

[clang] [clang] Fix a use-after-free in expression evaluation (PR #118480)

2025-04-15 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > ping, is this still a problem? > > yes, this is still happening. but I am currently lacking cycles to dig deeper > into expression evaluation to see if this is the right fix given the > reproducer. @VitaNuo was to take a look with some limited capacity, but I > think s

[clang] [Clang] Handle default template arguments for alias CTAD guides (PR #134807)

2025-04-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/134807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Fix new-delete-type-mismatch in ~CodeGenTypes() (PR #135787)

2025-04-15 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [Clang][analyzer] replace Stmt* with ConstCFGElementRef in SymbolConjured (PR #128251)

2025-04-15 Thread Fangyi Zhou via cfe-commits
fangyi-zhou wrote: Sorry I've been a bit busy with other things, just had some time to address the review comments. Please let me know if anything else needs changing https://github.com/llvm/llvm-project/pull/128251 ___ cfe-commits mailing list cfe-co

[clang] [Clang][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -743,6 +759,13 @@ class Sema; Standard.setAllToTypes(T); } +/// A conversion sequence is perfect if +/// it is an identity conversion and erichkeane wrote: your formatting of this comment is a little weird re-newlines. https://github.com

[clang] [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #135808)

2025-04-15 Thread via cfe-commits
https://github.com/cor3ntin reopened https://github.com/llvm/llvm-project/pull/135808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #135808)

2025-04-15 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/135808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -979,6 +1002,22 @@ class Sema; return false; } +// An overload is a perfect match if the conversion +// sequences for each argument are perfect. +bool isPerfectMatch(const ASTContext &Ctx) const { + if (!Viable) +return false; + for (

[clang] [Clang][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

2025-04-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I have a handful of comments that are all nits/minor enough I trust you on, but overall this looks fine. Lets ship it! https://github.com/llvm/llvm-project/pull/133426 ___ cfe-commits mailing

[clang] [Clang][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -1117,16 +1217,27 @@ class Sema; SmallVector Candidates; llvm::SmallPtrSet Functions; -// Allocator for ConversionSequenceLists. We store the first few of these +DeferredTemplateOverloadCandidate *FirstDeferredCandidate; erichkeane wrote: `

[clang] [CodeGen] Fix new-delete-type-mismatch in ~CodeGenTypes() (PR #135787)

2025-04-15 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Do you need to invoke the destructor? https://github.com/llvm/llvm-project/pull/135787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG-CL] ignores Wpadded (PR #134426)

2025-04-15 Thread Eli Friedman via cfe-commits
=?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes ,Theo

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Teresa Johnson via cfe-commits
teresajohnson wrote: > > I assume this will give a duplicate symbol linker error if used > > inappropriately? Any chance of more subtle bugs? > > As far as LTO is concerned I think it can only result in a duplicate symbol > error as the resulting symbols will have external strong linkage. Ther

[clang] [clang][Dependency Scanning] Adding an API to Diagnose Invalid Negative Stat Cache Entries (PR #135703)

2025-04-15 Thread Jan Svoboda via cfe-commits
@@ -108,6 +108,32 @@ DependencyScanningFilesystemSharedCache::getShardForUID( return CacheShards[Hash % NumShards]; } +void DependencyScanningFilesystemSharedCache::diagnoseNegativeStatCachedPaths( +llvm::raw_ostream &OS, llvm::vfs::FileSystem &UnderlyingFS) const { + /

[clang] clang_EvalResult_getAsCXString impl (PR #134551)

2025-04-15 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > `CXString::private_flags` only has 2 bits used. Could we use the rest for the > size? Would it be enough? I'd be a bit uncomfortable with that. It would work, but it means we're never able to add any new private flags in the future. > There's also the possibility to not

[clang] [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #135808)

2025-04-15 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/135808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #135808)

2025-04-15 Thread Matheus Izvekov via cfe-commits
@@ -466,6 +467,29 @@ class FullSourceLoc : public SourceLocation { } }; +/// A simple pair of identifier info and location. +class IdentifierLoc { + SourceLocation Loc; + IdentifierInfo *II = nullptr; + +public: + IdentifierLoc() = default; + IdentifierLoc(SourceLocation

[clang] [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #135808)

2025-04-15 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov commented: Thanks, I like the idea! https://github.com/llvm/llvm-project/pull/135808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #135808)

2025-04-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I REALLY like this. I THINK this ends up being pretty trivial implementation for most of the files, and did a quick overlook on it, but please let another person or two do the scroll through to mkae sure I didnt miss anything. https://

[clang] Split -Wcast-function-type into a separate group (PR #86131)

2025-04-15 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Yes please. :-) And thanks very much. You're welcome, thanks for bringing the issue up and sticking with me until I understood it. :-D I've posted https://github.com/llvm/llvm-project/pull/135798 to backport to 20.x https://github.com/llvm/llvm-project/pull/86131 ___

[clang] clang_EvalResult_getAsCXString impl (PR #134551)

2025-04-15 Thread Damian Andrei via cfe-commits
xTachyon wrote: > What if we add unsigned clang_getCStringLength(CXString); which gets the > length but not the contents? Do we need to package pointer and size together? Where do we store the length, if we can't add a new field to `CXString`, and we can't use `private_flags` to store it? htt

[clang] [ARM, AArch64] Fix passing of structures with aligned base classes (PR #135564)

2025-04-15 Thread Eli Friedman via cfe-commits
@@ -1302,6 +1302,7 @@ ItaniumRecordLayoutBuilder::LayoutBase(const BaseSubobjectInfo *Base) { setSize(std::max(getSize(), Offset + Layout.getSize())); // Remember max struct/class alignment. + UnadjustedAlignment = std::max(UnadjustedAlignment, PreferredBaseAlign); ---

[clang] 4005088 - [clang][depscan] Centralize logic for populating StableDirs, NFC (#135704)

2025-04-15 Thread via cfe-commits
Author: Cyndy Ishida Date: 2025-04-15T09:59:23-07:00 New Revision: 40050888a11a92a2fbf4da5dda5956ca9ecb6b55 URL: https://github.com/llvm/llvm-project/commit/40050888a11a92a2fbf4da5dda5956ca9ecb6b55 DIFF: https://github.com/llvm/llvm-project/commit/40050888a11a92a2fbf4da5dda5956ca9ecb6b55.diff

[clang] [clang][depscan] Centralize logic for populating StableDirs, NFC (PR #135704)

2025-04-15 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/135704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/135552 >From f930508ec33ca9c2f1d0b68e14901bffa10af9da Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Sun, 13 Apr 2025 23:34:21 +0800 Subject: [PATCH] [CIR] cir.call with scalar return type This patch introduces support

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Sirui Mu via cfe-commits
@@ -0,0 +1,89 @@ +//==-- ABIArgInfo.h - Abstract info regarding ABI-specific arguments ---==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [AArch64][clang][llvm] Add structured sparsity outer product (TMOP) intrinsics (PR #135145)

2025-04-15 Thread via cfe-commits
@@ -3107,6 +3107,26 @@ let TargetPrefix = "aarch64" in { } } + class SME_OuterProduct_TMOP_Intrinsic + : DefaultAttrsIntrinsic<[], + [llvm_i32_ty, + llvm_anyvector_ty, + LLVMMatchType<0>, + LLVMMatchType<0>, + llvm_nxv16i8

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-04-15 Thread via cfe-commits
@@ -0,0 +1,35 @@ +// Regression test for https://github.com/llvm/llvm-project/issues/59819 + +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md --check-prefix=MD-MYC

[clang] Silence -Wcast-function-type warnings on idiomatic Windows code (PR #135660)

2025-04-15 Thread via cfe-commits
llvmbot wrote: Failed to cherry-pick: d0e4af8a88dc7a0377677000d0c92104ff215347 https://github.com/llvm/llvm-project/actions/runs/14473318832 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-proje

[clang] [CLANG-CL] ignores Wpadded (PR #134426)

2025-04-15 Thread Devon Loehr via cfe-commits
=?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes ,Theo de Magalhaes , =?utf-8?q?Théo?= De Mag

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Sirui Mu via cfe-commits
@@ -205,13 +205,15 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { // Call operators //======// - cir::CallOp createCallOp(mlir::Location loc, mlir::SymbolRefAttr callee) { -auto op = create(loc

[clang] [CIR] Upstream minimal support for structure types (PR #135105)

2025-04-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16012 Here is the relevant piece of the

[clang] Fixed issue #128882: don't warn if 1st argument to 'getcwd' is NULL (PR #135720)

2025-04-15 Thread Sean McBride via cfe-commits
https://github.com/seanm created https://github.com/llvm/llvm-project/pull/135720 None >From 4ce75d43c62537a7020da0ca737c76e0cca27aca Mon Sep 17 00:00:00 2001 From: Sean McBride Date: Mon, 14 Apr 2025 20:58:24 -0400 Subject: [PATCH] Fixed issue #128882: don't warn if 1st argument to 'getcwd'

[clang] [Clang][Sema]:Fix musttail attribute on a function with not_tail_called attribute has no warning/error (PR #134465)

2025-04-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. This LGTM, are you happy with it @erichkeane? https://github.com/llvm/llvm-project/pull/134465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Erich Keane via cfe-commits
@@ -0,0 +1,89 @@ +//==-- ABIArgInfo.h - Abstract info regarding ABI-specific arguments ---==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Sirui Mu via cfe-commits
@@ -205,13 +205,15 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { // Call operators //======// - cir::CallOp createCallOp(mlir::Location loc, mlir::SymbolRefAttr callee) { -auto op = create(loc

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-04-15 Thread via cfe-commits
https://github.com/ZhongUncle edited https://github.com/llvm/llvm-project/pull/132510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Cleanup and document nvvm.fabs intrinsics, adding f16 support (PR #135644)

2025-04-15 Thread Alex MacLean via cfe-commits
@@ -1034,6 +1034,10 @@ Value *CodeGenFunction::EmitNVPTXBuiltinExpr(unsigned BuiltinID, case NVPTX::BI__nvvm_fmin_xorsign_abs_f16x2: return MakeHalfType(Intrinsic::nvvm_fmin_xorsign_abs_f16x2, BuiltinID, E, *this); + case NVPTX::BI__nvvm_abs_bf16

[clang] 289baf1 - [clang][AST] Handle implicit first argument in CallExpr::getBeginLoc() (#135757)

2025-04-15 Thread via cfe-commits
Author: Nathan Ridge Date: 2025-04-15T12:04:35-04:00 New Revision: 289baf1f42c8b5773271b611cd235d4ab94bb4e8 URL: https://github.com/llvm/llvm-project/commit/289baf1f42c8b5773271b611cd235d4ab94bb4e8 DIFF: https://github.com/llvm/llvm-project/commit/289baf1f42c8b5773271b611cd235d4ab94bb4e8.diff

[clang] [clang][AST] Handle implicit first argument in CallExpr::getBeginLoc() (PR #135757)

2025-04-15 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/135757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add equality comparison operators for File (PR #130383)

2025-04-15 Thread Jannick Kremer via cfe-commits
@@ -16,3 +17,76 @@ def test_file(self): self.assertEqual(str(file), "t.c") self.assertEqual(file.name, "t.c") self.assertEqual(repr(file), "") + +def test_file_eq(self): +path = os.path.join(inputs_dir, "hello.cpp") +header_path = os.

[clang] [Clang] [Driver] use __cxa_atexit by default on Cygwin. (PR #135701)

2025-04-15 Thread via cfe-commits
https://github.com/jeremyd2019 edited https://github.com/llvm/llvm-project/pull/135701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #135808)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: None (yronglin) Changes Currently we have many similiar data structures like: - `std::pair`. - Element type of `ModuleIdPath`. - `IdentifierLocPair`. - `IdentifierLoc`

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Peter Collingbourne via cfe-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/135728 >From 4ddc4d6fcd938b66cce586c18a9e165c6d065121 Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Mon, 14 Apr 2025 19:04:00 -0700 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Peter Collingbourne via cfe-commits
pcc wrote: > Could that be addressed by only allowing this flag under LTO? `-fsanitize=address -flto=thin` would have the same issue (if there is indeed an issue, which I think there probably isn't). > Probably at least add a note to the new documentation for the option that it > will result

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM, pending if Andy has any other followup https://github.com/llvm/llvm-project/pull/135552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-15 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/135552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Teresa Johnson via cfe-commits
teresajohnson wrote: > > I was mostly thinking that detecting and erroring at LTO time would result > > in a clearer error (like at the start of LTO::addModule, where it is > > looking for partially split LTO units, which we do by adding the module > > flag to the index flags). > > I don't th

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Teresa Johnson via cfe-commits
https://github.com/teresajohnson approved this pull request. https://github.com/llvm/llvm-project/pull/135728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-15 Thread Mateusz Mikuła via cfe-commits
mati865 wrote: So this is basically `hack: dynamically resolve G++ include dir` and `hack: add system search paths` from https://github.com/mati865/llvm-project/commits/cygwin-more-fixes/ but done the proper way. It will take a few more changes to get everything working, but this is a good s

[clang] [C23] Implement WG14 N3037 (PR #132939)

2025-04-15 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > So the changes needed to move this patch forward are to only perform the > attribute check when we're checking for a valid redefinition, not type > compatibility in general. A follow-up to improve upon this can do the layout > check when looking for compatibility. Alterna

[clang] [clang][Dependency Scanning] Adding an API to Diagnose Invalid Negative Stat Cache Entries (PR #135703)

2025-04-15 Thread Jan Svoboda via cfe-commits
@@ -108,6 +108,31 @@ DependencyScanningFilesystemSharedCache::getShardForUID( return CacheShards[Hash % NumShards]; } +void DependencyScanningFilesystemSharedCache::diagnoseNegativeStatCachedPaths( +llvm::raw_ostream &OS, llvm::vfs::FileSystem &UnderlyingFS) const { + /

[clang] [CodeGen] Fix new-delete-type-mismatch in ~CodeGenTypes() (PR #135787)

2025-04-15 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/CodeGen/CodeGenTypes.cpp `` Vi

[clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-15 Thread via cfe-commits
eaeltsin wrote: No, the problem seems to be in serialization/deserialization, there must be some mismatch between `ASTStmtWriter::VisitSubstNonTypeTemplateParmExpr` and `ASTStmtReader::VisitSubstNonTypeTemplateParmExpr`. More precisely, I'm seeing that `ASTStmtWriter::VisitSubstNonTypeTemplat

[clang] [CodeGen] Fix new-delete-type-mismatch in ~CodeGenTypes() (PR #135787)

2025-04-15 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Please also make the unused "operator delete" in CGFunctionInfo.h deleted, since it shouldn't have any callers. I think this never actually led to a real issue because of that operator delete... it calls the right deallocation function even if it's technically undefined.

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Peter Collingbourne via cfe-commits
https://github.com/pcc closed https://github.com/llvm/llvm-project/pull/135728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a5aa0c4 - Introduce -funique-source-file-names flag.

2025-04-15 Thread via cfe-commits
Author: Peter Collingbourne Date: 2025-04-15T11:12:05-07:00 New Revision: a5aa0c46c3274eaf25dde4d792a1abd6191cccf9 URL: https://github.com/llvm/llvm-project/commit/a5aa0c46c3274eaf25dde4d792a1abd6191cccf9 DIFF: https://github.com/llvm/llvm-project/commit/a5aa0c46c3274eaf25dde4d792a1abd6191cccf9

[clang] [llvm] [NVPTX] Cleanup and document nvvm.fabs intrinsics, adding f16 support (PR #135644)

2025-04-15 Thread Artem Belevich via cfe-commits
@@ -411,6 +412,13 @@ static Instruction *convertNvvmIntrinsicToLlvm(InstCombiner &IC, } return nullptr; } + case SPC_Fabs: { +if (!II->getType()->isDoubleTy()) + return nullptr; +auto *Fabs = Intrinsic::getOrInsertDeclaration( +II->getModule(),

[clang] [llvm] [NVPTX] Cleanup and document nvvm.fabs intrinsics, adding f16 support (PR #135644)

2025-04-15 Thread Artem Belevich via cfe-commits
@@ -1034,6 +1034,10 @@ Value *CodeGenFunction::EmitNVPTXBuiltinExpr(unsigned BuiltinID, case NVPTX::BI__nvvm_fmin_xorsign_abs_f16x2: return MakeHalfType(Intrinsic::nvvm_fmin_xorsign_abs_f16x2, BuiltinID, E, *this); + case NVPTX::BI__nvvm_abs_bf16

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: Is the "name" in this context the whole path? Or just the filename? I know many projects have files with the same name in different folders (including LLVM itsef). https://github.com/llvm/llvm-project/pull/135728 ___

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Peter Collingbourne via cfe-commits
pcc wrote: > Is the "name" in this context the whole path? Or just the filename? I know > many projects have files with the same name in different folders (including > LLVM itsef). It is the whole path. Let me clarify this in the documentation. https://github.com/llvm/llvm-project/pull/135728

[clang] [Clang] Fix dependent local class instantiation bugs (PR #134038)

2025-04-15 Thread Daniel Thornburgh via cfe-commits
mysterymath wrote: This looks to be the likely culprit for a clang crash in the Fuchsia build: ``` [21173/168418](63) CXX host_x64/obj/src/developer/debug/zxdb/client/libclient.map_setting_store.cc.o FAILED: [code=1] host_x64/obj/src/developer/debug/zxdb/client/libclient.map_setting_store.cc.o

[clang] [llvm] [llvm][clang] Allocate a new stack instead of spawning a new thread to get more stack space (PR #133173)

2025-04-15 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/133173 >From 52b33e2511a2e775e78471fbb2c66ad072369168 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Wed, 26 Mar 2025 14:48:19 -0700 Subject: [PATCH] [llvm][clang] Allocate a new stack instead of spawning a new

[clang] d0c973a - [llvm][clang] Allocate a new stack instead of spawning a new thread to get more stack space (#133173)

2025-04-15 Thread via cfe-commits
Author: Michael Spencer Date: 2025-04-15T11:19:07-07:00 New Revision: d0c973a7a0149db3b71767d4c5a20a31e6a8ed5b URL: https://github.com/llvm/llvm-project/commit/d0c973a7a0149db3b71767d4c5a20a31e6a8ed5b DIFF: https://github.com/llvm/llvm-project/commit/d0c973a7a0149db3b71767d4c5a20a31e6a8ed5b.dif

[clang] [ARM, AArch64] Fix passing of structures with aligned base classes (PR #135564)

2025-04-15 Thread John McCall via cfe-commits
https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/135564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle default template arguments for alias CTAD guides (PR #134807)

2025-04-15 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/134807 >From 3f09d114d6c4c51bd879a19caaf1c73c531cfedd Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 8 Apr 2025 16:16:53 +0800 Subject: [PATCH 1/2] [Clang] Handle default template arguments for alias CTAD guid

[clang] [llvm] [ARM] Adding diagnostics for mcmodel=tiny when used in invalid targets (PR #125643)

2025-04-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. We typically add such incompatibility check in clang/lib/Driver instead of clang/lib/Frontend. (Apologies, I will have limited internet access between April 20th and May 4th, and my response time may be delayed.. Happy if a reg

[clang] [NFC][analyzer] Document configuration options (PR #135169)

2025-04-15 Thread Donát Nagy via cfe-commits
@@ -143,6 +143,32 @@ if (LLVM_ENABLE_SPHINX) gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs ../include/clang/Basic/Diagnostic.td "${docs_targets}") gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs ../include/clang/Driver/ClangOptionDocs.td

[clang] fceb9ce - [clang] consistently quote expressions in diagnostics (#134769)

2025-04-15 Thread via cfe-commits
Author: Matheus Izvekov Date: 2025-04-15T04:18:23-03:00 New Revision: fceb9cecdf6264eb773ee826b72a51a9ec68ec74 URL: https://github.com/llvm/llvm-project/commit/fceb9cecdf6264eb773ee826b72a51a9ec68ec74 DIFF: https://github.com/llvm/llvm-project/commit/fceb9cecdf6264eb773ee826b72a51a9ec68ec74.dif

[clang] [clang] consistently quote expressions in diagnostics (PR #134769)

2025-04-15 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/134769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Handle implicit first argument in CallExpr::getBeginLoc() (PR #135757)

2025-04-15 Thread Nathan Ridge via cfe-commits
@@ -1652,8 +1652,11 @@ SourceLocation CallExpr::getBeginLoc() const { if (!isTypeDependent()) { if (const auto *Method = dyn_cast_if_present(getCalleeDecl()); -Method && Method->isExplicitObjectMemberFunction()) - return getArg(0)->getBeginLoc();

[clang] [NFC][analyzer] Document configuration options (PR #135169)

2025-04-15 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,242 @@ +#!/usr/bin/env python3 +# A tool to automatically generate documentation for the config options of the +# clang static analyzer by reading `AnalyzerOptions.def`. + +import argparse +from collections import namedtuple +from enum import Enum, auto +import re +impo

[clang] [clang][AST] Handle implicit first argument in CallExpr::getBeginLoc() (PR #135757)

2025-04-15 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. Can you add a changelog entry? Otherwise LGTM https://github.com/llvm/llvm-project/pull/135757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [Clang] [Sema] Fix a crash when a `friend` function is redefined as deleted (PR #135679)

2025-04-15 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon approved this pull request. https://github.com/llvm/llvm-project/pull/135679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Fix an identifier hiding a function-like macro definition. (PR #135471)

2025-04-15 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM. The behavior is a bit subtle (always was), but it's good to have this edge-case fixed. https://github.com/llvm/llvm-project/pull/135471 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang][AST] Handle implicit first argument in CallExpr::getBeginLoc() (PR #135757)

2025-04-15 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Added changelog entry. Should we backport this to 20.x? https://github.com/llvm/llvm-project/pull/135757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM][Clang] Make `+nosimd` functional for AArch32 Targets (PR #130623)

2025-04-15 Thread Jack Styles via cfe-commits
https://github.com/Stylie777 closed https://github.com/llvm/llvm-project/pull/130623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Handle implicit first argument in CallExpr::getBeginLoc() (PR #135757)

2025-04-15 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/135757 >From a1569727c432ba67a96de07c899b562fcf349d1e Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 15 Apr 2025 03:40:37 -0400 Subject: [PATCH] [clang][AST] Handle implicit first argument in CallExpr::

[clang] [llvm] [AArch64][clang][llvm] Add structured sparsity outer product (TMOP) intrinsics (PR #135145)

2025-04-15 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/135145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][clang][llvm] Add structured sparsity outer product (TMOP) intrinsics (PR #135145)

2025-04-15 Thread via cfe-commits
@@ -3107,6 +3107,23 @@ let TargetPrefix = "aarch64" in { } } + class SME_OuterProduct_TMOP_Intrinsic + : DefaultAttrsIntrinsic<[], + [llvm_i32_ty, + llvm_anyvector_ty, + LLVMMatchType<0>, + LLVMMatchType<0>, + llvm_nxv16i8

[clang] [llvm] [AArch64][clang][llvm] Add structured sparsity outer product (TMOP) intrinsics (PR #135145)

2025-04-15 Thread via cfe-commits
@@ -0,0 +1,138 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 +; RUN: llc -force-streaming -verify-machineinstrs < %s | FileCheck %s + +target triple = "aarch64-linux" + +define void @tmopa_za32_s8( %zn1, %zn2, %zm, %zk

[clang] [Driver] Teach Barmetal toolchain about GCC installation (PR #121829)

2025-04-15 Thread Petr Hosek via cfe-commits
@@ -110,20 +110,81 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } +static bool hasGCCToolChainAlongSideClang(const Driver &D) { petrhosek wrote: If understand correctly, this should cover t

[clang] [llvm] [AArch64][clang][llvm] Add structured sparsity outer product (TMOP) intrinsics (PR #135145)

2025-04-15 Thread via cfe-commits
@@ -1078,26 +1072,32 @@ let Predicates = [HasSME2p2] in { } // [HasSME2p2] +let Predicates = [HasSME_TMOP] in { + defm FTMOPA_M2ZZZI_HtoS : sme_tmopa_32b<0b11000, ZZ_h_mul_r, ZPR16, nxv8f16, "ftmopa", int_aarch64_sme_tmopa>; CarolineConcatto wrote: nit:

[clang] 1ee8fe8 - [Mips] Fix clang compile error when -march=p5600 with -mmsa (#132679)

2025-04-15 Thread via cfe-commits
Author: yingopq Date: 2025-04-15T17:01:36+08:00 New Revision: 1ee8fe810fab9f660b72585a782a449c8f83d8e6 URL: https://github.com/llvm/llvm-project/commit/1ee8fe810fab9f660b72585a782a449c8f83d8e6 DIFF: https://github.com/llvm/llvm-project/commit/1ee8fe810fab9f660b72585a782a449c8f83d8e6.diff LOG:

[clang] Silence -Wcast-function-type warnings on idiomatic Windows code (PR #135660)

2025-04-15 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM. Or should I say, "Thanks, I hate it". Do you know how likely it is WG14 come up with a good solution for "arbitrary function pointer" ? https://github.com/llvm/llvm-project/pull/135660 ___

[clang] [Mips] Fix clang compile error when -march=p5600 with -mmsa (PR #132679)

2025-04-15 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa closed https://github.com/llvm/llvm-project/pull/132679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-04-15 Thread Ryotaro Kasuga via cfe-commits
https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/135163 >From 79186af3df57357d40ec3b3e4eaf9da978b31ef6 Mon Sep 17 00:00:00 2001 From: Ryotaro Kasuga Date: Fri, 4 Apr 2025 12:32:57 + Subject: [PATCH 1/5] [clang][CodeGen] Fix metadata when vectorization is disab

[clang] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMacro` (PR #133574)

2025-04-15 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM - sorry for the delayed response. Will you need me to merge that for you (once the merge conflict is resolved)? https://github.com/llvm/llvm-project/pull/133574 ___ cfe-commits mailing list

[clang] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-04-15 Thread David Sherwood via cfe-commits
@@ -37,8 +37,8 @@ void test3(int *List, int Length) { List[i] = i * 2; } -// Check that disabling vectorization means a vectorization width of 1, and -// also that vectorization_predicate isn't enabled. +// Check that vectorize is disabled, and also that vectorization_pred

[clang] [llvm] [SYCL] Add clang-linker-wrapper changes to call clang-sycl-linker for SYCL offloads (PR #135683)

2025-04-15 Thread Joseph Huber via cfe-commits
@@ -35,6 +35,7 @@ enum OffloadKind : uint16_t { OFK_OpenMP, OFK_Cuda, OFK_HIP, + OFK_SYCL, jhuber6 wrote: I think we should assign specific values for these and make them powers of two apart so we can use them like a bitfield. Clang does that already.

[clang] [llvm] [ARM] Adding diagnostics for mcmodel=tiny when used in invalid targets (PR #125643)

2025-04-15 Thread via cfe-commits
cor3ntin wrote: This is really not my area of expertise. @AaronBallman Who would be a good reviewer here? https://github.com/llvm/llvm-project/pull/125643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

<    1   2   3   4   5   6   7   >