[clang] Unnamed fields (PR #132427)

2025-03-21 Thread Abhinav Kumar via cfe-commits
https://github.com/kr-2003 created https://github.com/llvm/llvm-project/pull/132427 Fixes #132001 Edit ```isNonUnionUninit``` (caller of ```isPrimitiveUninit```): Add a check before calling ```isPrimitiveUninit``` ```cpp if (isPrimitiveType(T)) { if (I->isUnnamedBitField()) { continue;

[clang] Unnamed fields (PR #132427)

2025-03-21 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [HLSL] Implement the `smoothstep` intrinsic (PR #132288)

2025-03-21 Thread Farzon Lotfi via cfe-commits
@@ -101,6 +101,44 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(unsigned BuiltinID, TheCall->setType(RetTy); break; } + case SPIRV::BI__builtin_spirv_smoothstep: { +if (SemaRef.checkArgCount(TheCall, 3)) + return true; + +ExprResult A = TheCall->getA

[clang] 44573bc - [clang][HeuristicResolver] Default argument heuristic for template parameters (#132465)

2025-03-21 Thread via cfe-commits
Author: Nathan Ridge Date: 2025-03-21T19:15:18-04:00 New Revision: 44573bc1528831b13b17afac158f4860af42570e URL: https://github.com/llvm/llvm-project/commit/44573bc1528831b13b17afac158f4860af42570e DIFF: https://github.com/llvm/llvm-project/commit/44573bc1528831b13b17afac158f4860af42570e.diff

[clang] [clang][HeuristicResolver] Default argument heuristic for template parameters (PR #132465)

2025-03-21 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/132465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][IR] Overload @llvm.thread.pointer to support non-AS0 targets (PR #132489)

2025-03-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir @llvm/pr-subscribers-backend-risc-v Author: Jessica Clarke (jrtc27) Changes Thraed-local globals live, by default, in the default globals address space, which may not be 0, so we need to overload @llvm.thread.pointer to support other address spac

[clang] [llvm] [clang][IR] Overload @llvm.thread.pointer to support non-AS0 targets (PR #132489)

2025-03-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jessica Clarke (jrtc27) Changes Thraed-local globals live, by default, in the default globals address space, which may not be 0, so we need to overload @llvm.thread.pointer to support other address spaces, and use the default globals addres

[clang] [llvm] [HLSL] Implement the `smoothstep` intrinsic (PR #132288)

2025-03-21 Thread Kaitlin Peng via cfe-commits
@@ -0,0 +1,44 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 + +// RUN: %clang_cc1 -O1 -triple spirv-pc-vulkan-compute %s -emit-llvm -o - | FileCheck %s + +typedef float float2 __attribute__((ext_vector_type(2))); +typedef

[clang] [compiler-rt] Reland [Coverage] Fix region termination for GNU statement expressions (PR #132222)

2025-03-21 Thread Justin Cady via cfe-commits
https://github.com/justincady closed https://github.com/llvm/llvm-project/pull/13 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [llvm] Add test to clang-doc, it can test comments in macro. Original issue is #59819. (PR #132360)

2025-03-21 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,32 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md --check-prefix=MD

[clang] [clang-tools-extra] [lldb] [llvm] Add test to clang-doc, it can test comments in macro. Original issue is #59819. (PR #132360)

2025-03-21 Thread via cfe-commits
@@ -0,0 +1,32 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md --check-prefix=MD

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVTTP.*QS (PR #132414)

2025-03-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: Phoebe Wang (phoebewang) Changes Ref: https://cdrdv2.intel.com/v1/dl/getContent/784343 --- Patch is 100.56 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/132414.diff 16 Files Affected: - (

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVTTP.*QS (PR #132414)

2025-03-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: Phoebe Wang (phoebewang) Changes Ref: https://cdrdv2.intel.com/v1/dl/getContent/784343 --- Patch is 100.56 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/132414.diff 16 Files Affected: - (modif

[clang] [llvm] [win][x64] Unwind v2 3/n: Add support for emitting unwind v2 information (equivalent to MSVC /d2epilogunwind) (PR #129142)

2025-03-21 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/129142 >From ac5609c09e6423ab30b77cc9a18d24a33ba16048 Mon Sep 17 00:00:00 2001 From: Daniel Paoliello Date: Thu, 27 Feb 2025 15:08:36 -0800 Subject: [PATCH] [win][x64] Unwind v2 3/n: Add support for emitting unwind

[clang] [llvm] [DataLayout] Introduce sentinel pointer value (PR #131557)

2025-03-21 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/131557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang] Split clang/lib/CodeGen/CGBuiltin.cpp into target-specific files (PR #132252)

2025-03-21 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray closed https://github.com/llvm/llvm-project/pull/132252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer]: fix 'UninitializedObject false positive with unnamed fields' (PR #132457)

2025-03-21 Thread via cfe-commits
https://github.com/YLChenZ created https://github.com/llvm/llvm-project/pull/132457 Fixes #132001: False positives generated by this issue can be avoided by skipping the check on the unnamed bitfield. Here are my test results: ``` Testing Time: 49.22s Total Discovered Tests: 990 Unsupporte

[clang] [clang][analyzer]: fix 'UninitializedObject false positive with unnamed fields' (PR #132457)

2025-03-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (YLChenZ) Changes Fixes #132001: False positives generated by this issue can be avoided by skipping the check on the unnamed bitfield. Here are my test results: ``` Testing Time: 49.22s Total Discovered Tests: 990 Unsupported

[clang] [clang][analyzer]: fix 'UninitializedObject false positive with unnamed fields' (PR #132457)

2025-03-21 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-21 Thread via cfe-commits
https://github.com/metkarpoonam updated https://github.com/llvm/llvm-project/pull/131900 >From 1e34c5428964733f4ae0e924d373b9fda780f370 Mon Sep 17 00:00:00 2001 From: Poonam Vilas Metkar Date: Tue, 18 Mar 2025 11:30:15 -0700 Subject: [PATCH 01/16] Add codegen tests, Sema tests, SPIR-V backend t

[clang] [clang][ExtractAPI] fix a couple crashes when used via libclang (PR #132297)

2025-03-21 Thread via cfe-commits
@@ -175,28 +175,30 @@ class ExtractAPIVisitorBase : public RecursiveASTVisitor { SmallVector getBases(const CXXRecordDecl *Decl) { // FIXME: store AccessSpecifier given by inheritance SmallVector Bases; -for (const auto &BaseSpecifier : Decl->bases()) { - //

[clang] [libc] [llvm] Reapply "[AMDGPU] Use COV6 by default (#118515)" (PR #130963)

2025-03-21 Thread Shilei Tian via cfe-commits
https://github.com/shiltian closed https://github.com/llvm/llvm-project/pull/130963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement the `smoothstep` intrinsic (PR #132288)

2025-03-21 Thread Kaitlin Peng via cfe-commits
@@ -101,6 +101,44 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(unsigned BuiltinID, TheCall->setType(RetTy); break; } + case SPIRV::BI__builtin_spirv_smoothstep: { +if (SemaRef.checkArgCount(TheCall, 3)) + return true; + +ExprResult A = TheCall->getA

[clang] [NFC][clang] Split clang/lib/CodeGen/CGBuiltin.cpp into target-specific files (PR #132252)

2025-03-21 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: The RISCV builtins are generated code; riscv_vector_builtin_cg.inc is 87000 lines. There's an open bug about this: #88368. https://github.com/llvm/llvm-project/pull/132252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/132420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -93,16 +96,20 @@ struct MissingFeatures { static bool stackSaveOp() { return false; } static bool aggValueSlot() { return false; } static bool generateDebugInfo() { return false; } + static bool getFPFeaturesInEffect() { return false; } andykaylor wro

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -232,6 +231,61 @@ LValue CIRGenFunction::emitUnaryOpLValue(const UnaryOperator *e) { llvm_unreachable("Unknown unary operator kind!"); } +LValue CIRGenFunction::emitBinaryOperatorLValue(const BinaryOperator *e) { + // Comma expressions just emit their LHS then their RHS

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -826,6 +826,129 @@ def ForOp : CIR_Op<"for", [LoopOpInterface, NoRegionArguments]> { }]; } +//===--===// +// BinOp +//===--===// + +//

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -93,16 +96,20 @@ struct MissingFeatures { static bool stackSaveOp() { return false; } static bool aggValueSlot() { return false; } static bool generateDebugInfo() { return false; } + static bool getFPFeaturesInEffect() { return false; } + static bool pointerOverflowS

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -558,8 +624,225 @@ class ScalarExprEmitter : public StmtVisitor { return res; } + + BinOpInfo emitBinOps(const BinaryOperator *e, + QualType promotionType = QualType()) { +BinOpInfo result; +result.lhs = cgf.emitPromotedScalarExpr(e->ge

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -570,13 +853,425 @@ mlir::Value CIRGenFunction::emitScalarExpr(const Expr *e) { return ScalarExprEmitter(*this, builder).Visit(const_cast(e)); } -[[maybe_unused]] static bool MustVisitNullValue(const Expr *e) { +mlir::Value CIRGenFunction::emitPromotedScalarExpr(const Ex

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -570,13 +853,425 @@ mlir::Value CIRGenFunction::emitScalarExpr(const Expr *e) { return ScalarExprEmitter(*this, builder).Visit(const_cast(e)); } -[[maybe_unused]] static bool MustVisitNullValue(const Expr *e) { +mlir::Value CIRGenFunction::emitPromotedScalarExpr(const Ex

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -143,6 +147,114 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { return createCast(loc, cir::CastKind::bitcast, src, newTy); } + mlir::Value createBinop(mlir::Value lhs, cir::BinOpKind kind, + const llvm::APInt &rhs) { +return create(

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -558,8 +624,225 @@ class ScalarExprEmitter : public StmtVisitor { return res; } + + BinOpInfo emitBinOps(const BinaryOperator *e, + QualType promotionType = QualType()) { +BinOpInfo result; +result.lhs = cgf.emitPromotedScalarExpr(e->ge

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -143,6 +147,114 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { return createCast(loc, cir::CastKind::bitcast, src, newTy); } + mlir::Value createBinop(mlir::Value lhs, cir::BinOpKind kind, + const llvm::APInt &rhs) { +return create(

[clang] [clang][analyzer] Move 'alpha.core.FixedAddressDereference' out of alpha (PR #132404)

2025-03-21 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/132404 None From ecbda095420a1ec300fd4793600c813acc310475 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Fri, 21 Mar 2025 15:02:38 +0100 Subject: [PATCH] [clang][analyzer] Move 'alpha.core.F

[clang] [clang] Make `HeaderSearchOptions` references const (PR #130825)

2025-03-21 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/130825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Search for compiler-rt libraries in sysroot/lib if not found in the resource directory (PR #132443)

2025-03-21 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
@@ -72,22 +74,126 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy { if (const auto arrayVal = mlir::dyn_cast(attr)) { if (mlir::isa(arrayVal.getElts())) return false; - for (const auto elt : mlir::cast(arrayVal.getElts())) { -if (!isNullVa

[clang] [CIR] Add binary operators (PR #132420)

2025-03-21 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor commented: This is an awful lot to digest in one review. Can you split out the BinOpOverflowOp and pointer arithmetic? https://github.com/llvm/llvm-project/pull/132420 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [Docs] Document freestanding requirements (PR #132232)

2025-03-21 Thread Joseph Huber via cfe-commits
@@ -1073,6 +1073,29 @@ inputs. Here is some example of ``$``-prefixed options: Language and Target-Independent Features +Freestanding Builds +--- +Passing the ``-ffreestanding`` flag causes Clang to build for a freestand

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

2025-03-21 Thread Lyle Dean via cfe-commits
https://github.com/lyledean1 edited https://github.com/llvm/llvm-project/pull/132116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Permit `-Xarch_` to be used with `--offload-arch` (PR #131884)

2025-03-21 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/131884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Unnamed fields (PR #132427)

2025-03-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Abhinav Kumar (kr-2003) Changes Fixes #132001 Edit ```isNonUnionUninit``` (caller of ```isPrimitiveUninit```): Add a check before calling ```isPrimitiveUninit``` ```cpp if (isPrimitiveType(T)) { if (I->isUnnamedBitField()) { contin

[clang] [Clang][CodeGen][UBSan] Add more precise attributes to recoverable ubsan handlers (PR #130990)

2025-03-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Yingwei Zheng (dtcxzyw) Changes This patch adds `memory(argmem: read, inaccessiblemem: readwrite) willreturn` to **recoverable** ubsan handlers in order to unblock some memory/loop optimizations. It prov

[clang] [clang-tools-extra] [lldb] [llvm] [clang-doc] Add regression test for test comments in macros (PR #132360)

2025-03-21 Thread via cfe-commits
https://github.com/ZhongUncle edited https://github.com/llvm/llvm-project/pull/132360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Hlsl asuint16 function (PR #132315)

2025-03-21 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/132315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UnretainedLambdaCapturesChecker] Add the support for protectedSelf (PR #132363)

2025-03-21 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/132363 >From cf415a9cf9933bc4e55d3c8da9b27551b09061fe Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Fri, 21 Mar 2025 02:32:49 -0700 Subject: [PATCH 1/3] [alpha.webkit.UnretainedLambdaCapturesChecker] Add the support

[clang] [Clang] Fix various bugs in alias CTAD transform (PR #132061)

2025-03-21 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM, Thanks. https://github.com/llvm/llvm-project/pull/132061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3757ecf - [HLSL] Add support for SV_GroupIndex in SPIR-V (#130672)

2025-03-21 Thread via cfe-commits
Author: Cassandra Beckley Date: 2025-03-21T14:52:47-04:00 New Revision: 3757ecf5f16c0d9b8cbfc1c9d41965df537d43e6 URL: https://github.com/llvm/llvm-project/commit/3757ecf5f16c0d9b8cbfc1c9d41965df537d43e6 DIFF: https://github.com/llvm/llvm-project/commit/3757ecf5f16c0d9b8cbfc1c9d41965df537d43e6.d

[clang] [Clang][CodeGen] Do not set inbounds flag for struct GEP with null base pointers (PR #130734)

2025-03-21 Thread Eli Friedman via cfe-commits
@@ -42,6 +42,11 @@ Potentially Breaking Changes C/C++ Language Potentially Breaking Changes --- +- Some old-style offsetof idioms like ``((int)(&(((struct S *)0)->field)))`` are treated efriedma-quic wrote: I think it

[clang] [flang] [llvm] [clang] Add isOffloadingTarget function to LangOpts (PR #126956)

2025-03-21 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/126956 >From 044158c176316e6c9f44ce1487ff631c8a0d15c4 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Tue, 4 Mar 2025 11:16:34 -0800 Subject: [PATCH 1/2] [clang] Add isOffloadingTarget function to LangOpts Signed-o

[clang] [clang][analyzer] Ignore unnamed bitfields in UninitializedObject (PR #132427)

2025-03-21 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: Could you add a test case that fails before your patch? https://github.com/llvm/llvm-project/pull/132427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-21 Thread Sumit Agarwal via cfe-commits
@@ -0,0 +1,8 @@ +; RUN: opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-compute %s | FileCheck %s + +define noundef float @dot2add_simple(<2 x half> noundef %a, <2 x half> noundef %b, float %c) { +entry: +; CHECK: call float @dx.op.dot2AddHalf(i32 162, float %c, half %0, h

[clang] [clang-tools-extra] [clang-tidy] Avoid processing declarations in system headers (PR #128150)

2025-03-21 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Btw I found [this commit](https://github.com/llvm/llvm-project/commit/814e7974c64c977960c4913a117bf59af005865b) which seemed to be intended at setting the basis for running clang-tidy on a reduced AST, and where the `ParentMap` class was created. @sam-mccall Perhaps you h

[clang] [llvm] [HLSL] Implement the `smoothstep` intrinsic (PR #132288)

2025-03-21 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng deleted https://github.com/llvm/llvm-project/pull/132288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [BPF] Make -mcpu=v3 as the default (PR #107008)

2025-03-21 Thread via cfe-commits
yonghong-song wrote: > > @yuvald-sweet-security Could you share which kernel you are used for above > > testing? > > I ran this on my host machine which is Windows with WSL, kernel > `6.6.75.1-microsoft-standard-WSL2`. However, I can see similar regressions on > pretty much every testing VM t

[clang] [llvm] [HLSL] Implement the `smoothstep` intrinsic (PR #132288)

2025-03-21 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng updated https://github.com/llvm/llvm-project/pull/132288 >From 0a5da660c5aae053d87d556e59f98c121d916b79 Mon Sep 17 00:00:00 2001 From: kmpeng Date: Tue, 18 Mar 2025 13:25:10 -0700 Subject: [PATCH 1/6] create int_spv_smoothstep intrinsic, create smoothstep lowering & m

[clang] [llvm] [HLSL] Implement the `smoothstep` intrinsic (PR #132288)

2025-03-21 Thread Kaitlin Peng via cfe-commits
@@ -20955,6 +20955,25 @@ Value *CodeGenFunction::EmitSPIRVBuiltinExpr(unsigned BuiltinID, /*ReturnType=*/I->getType(), Intrinsic::spv_reflect, ArrayRef{I, N}, nullptr, "spv.reflect"); } + case SPIRV::BI__builtin_spirv_smoothstep: { +Value *Min = EmitScal

[clang] [llvm] [HLSL] Implement the `smoothstep` intrinsic (PR #132288)

2025-03-21 Thread Kaitlin Peng via cfe-commits
@@ -20955,6 +20955,25 @@ Value *CodeGenFunction::EmitSPIRVBuiltinExpr(unsigned BuiltinID, /*ReturnType=*/I->getType(), Intrinsic::spv_reflect, ArrayRef{I, N}, nullptr, "spv.reflect"); } + case SPIRV::BI__builtin_spirv_smoothstep: { +Value *Min = EmitScal

[clang] [Format] Do not crash on non-null terminated strings (PR #131299)

2025-03-21 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/131299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Format] Do not crash on non-null terminated strings (PR #131299)

2025-03-21 Thread Owen Pan via cfe-commits
@@ -29096,6 +29096,17 @@ TEST_F(FormatTest, BreakBeforeClassName) { "ArenaSafeUniquePtr {};"); } +TEST_F(FormatTest, DoesNotCrashOnNonNullTerminatedStringRefs) { + llvm::StringRef TwoLines = "namespace foo {}\n" owenca wrote: ```suggestion

[clang] [Format] Do not crash on non-null terminated strings (PR #131299)

2025-03-21 Thread Owen Pan via cfe-commits
https://github.com/owenca commented: Can you add a reproducer? https://github.com/llvm/llvm-project/pull/131299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-21 Thread Sumit Agarwal via cfe-commits
https://github.com/sumitsays updated https://github.com/llvm/llvm-project/pull/131237 >From 6d5c4053c90975d64e378e52779dab9c3ffb64cd Mon Sep 17 00:00:00 2001 From: Sumit Agarwal Date: Thu, 13 Mar 2025 16:02:32 -0700 Subject: [PATCH 1/9] dot2add working for dxil without sema check --- clang/in

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-21 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/131900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

2025-03-21 Thread Vlad Serebrennikov via cfe-commits
@@ -10,7 +10,7 @@ import sys from pathlib import Path -kInputsDir = os.path.join(os.path.dirname(__file__), "INPUTS") +k_inputs_dir = os.path.join(os.path.dirname(__file__), "INPUTS") Endilll wrote: Can you also drop `k_` prefix? According to PEP 8, naming co

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

2025-03-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/132378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang] Remove superfluous header files after refactor in #132252 (PR #132495)

2025-03-21 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray updated https://github.com/llvm/llvm-project/pull/132495 >From a55f760ad74fb22ad39c83c5787a9da14224d457 Mon Sep 17 00:00:00 2001 From: Jonathan Thackray Date: Fri, 21 Mar 2025 23:56:42 + Subject: [PATCH] [NFC][clang] Remove superfluous header files after refacto

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-21 Thread Farzon Lotfi via cfe-commits
@@ -4894,7 +4894,7 @@ def HLSLDotProduct : LangBuiltin<"HLSL_LANG"> { def HLSLDot2Add : LangBuiltin<"HLSL_LANG"> { let Spellings = ["__builtin_hlsl_dot2add"]; let Attributes = [NoThrow, Const, CustomTypeChecking]; farzonl wrote: now that you defined the ty

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-21 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/131237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-21 Thread Farzon Lotfi via cfe-commits
@@ -2473,11 +2473,9 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { break; } case Builtin::BI__builtin_hlsl_dot2add: { -// Check number of arguments should be 3 if (SemaRef.checkArgCount(TheCall, 3)) return true; -

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-21 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/131237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-21 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/131237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm:ir] Add support for constant data exceeding 4GiB (PR #126481)

2025-03-21 Thread via cfe-commits
github-actions[bot] wrote: @pzzp Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, yo

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-21 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,36 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify + +float test_too_few_arg() { + return __builtin_hlsl_dot2add(); + // expected-error@-1 {{too few arguments t

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-21 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/131237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVT[,T]PS2I[,U]BS (PR #132426)

2025-03-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-cmake-x86_64-avx512-win` running on `avx512-intel64-win` while building `clang,llvm` at step 4 "cmake stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/81/builds/5509 Here is the releva

[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

2025-03-21 Thread Farzon Lotfi via cfe-commits
farzonl wrote: This looks mostly fine, but the Prototype changes also mean we likely need to change up what you are doing in Sema. As an aside you need to rebase to resolve a merge conflict. https://github.com/llvm/llvm-project/pull/131237 ___ cfe-

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

2025-03-21 Thread Jannick Kremer via cfe-commits
@@ -10,7 +10,7 @@ import sys from pathlib import Path -kInputsDir = os.path.join(os.path.dirname(__file__), "INPUTS") +k_inputs_dir = os.path.join(os.path.dirname(__file__), "INPUTS") DeinAlptraum wrote: Sounds good. I've been wondering the entire time what t

[clang] [NFC][clang] Remove superfluous header files after refactor in #132252 (PR #132495)

2025-03-21 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/132495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Format] Do not crash on non-null terminated strings (PR #131299)

2025-03-21 Thread Owen Pan via cfe-commits
@@ -29096,6 +29096,17 @@ TEST_F(FormatTest, BreakBeforeClassName) { "ArenaSafeUniquePtr {};"); } +TEST_F(FormatTest, DoesNotCrashOnNonNullTerminatedStringRefs) { + llvm::StringRef TwoLines = "namespace foo {}\n" + "namespace bar

[clang] [webkit.RefCntblBaseVirtualDtor] Add support for NoVirtualDestructorBase. (PR #132497)

2025-03-21 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/132497 This PR adds the support for WTF::NoVirtualDestructorBase, which signifies to the checker that the class is exempt from having a virtual destructor. >From a49c213d2ccb82391eb6e550d440ef4e829ecfa8 Mon Sep 17 00:00

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVT[,T]PS2I[,U]BS (PR #132426)

2025-03-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/132426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Expose -m32 and -m64 options (PR #132409)

2025-03-21 Thread Kiran Chandramohan via cfe-commits
@@ -0,0 +1,6 @@ +! Check support of -m32 and -m64. kiranchandramohan wrote: Can the file be renamed to be something specific about the enabled options? https://github.com/llvm/llvm-project/pull/132409 ___ cfe-commits m

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVT2PS2PHX (PR #132397)

2025-03-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: Phoebe Wang (phoebewang) Changes Ref: https://cdrdv2.intel.com/v1/dl/getContent/784343 --- Patch is 22.68 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/132397.diff 14 Files Affected: - (modifi

[clang] [libc] [llvm] Reapply "[AMDGPU] Use COV6 by default (#118515)" (PR #130963)

2025-03-21 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/130963 >From 61eac4e7d7f8604021f67c48384f8c09bedd647f Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 21 Mar 2025 12:16:30 -0400 Subject: [PATCH] Reapply "[AMDGPU] Use COV6 by default (#118515)" This reverts co

[clang] [clang-tools-extra] [clang] NFC: Clear some uses of MemberPointerType::getClass (PR #131965)

2025-03-21 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: hi, this breaks `clang -cc1 -triple x86_64-pc-windows-msvc19.26.0 -fsyntax-only -fms-extensions -fms-compatibility -fms-compatibility-version=19.26 -std=c++17 /tmp/a.ii` [a.ii.txt](https://github.com/user-attachments/files/19375232/a.ii.txt) which breaks stage 2 builds of cla

[clang] [clang-tools-extra] [lldb] [llvm] [clang-doc] Add regression test for test comments in macros (PR #132360)

2025-03-21 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,32 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md --check-prefix=MD

[clang] [llvm] [RISCV] Implement the implications of C extension (PR #132259)

2025-03-21 Thread Sam Elliott via cfe-commits
@@ -378,6 +370,14 @@ def FeatureStdExtZca "part of the C extension, excluding compressed " "floating point loads/stores">; +def FeatureStdExtC +: RISCVExtension<2, 0, "Compressed Instructions", [FeatureStdExtZca]>, + RISCVExte

[clang] [llvm] [RISCV] Implement the implications of C extension (PR #132259)

2025-03-21 Thread Sam Elliott via cfe-commits
https://github.com/lenary edited https://github.com/llvm/llvm-project/pull/132259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Implement the implications of C extension (PR #132259)

2025-03-21 Thread Sam Elliott via cfe-commits
https://github.com/lenary approved this pull request. LGTM, with one comment. https://github.com/llvm/llvm-project/pull/132259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVT[,T]PS2I[,U]BS (PR #132426)

2025-03-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: Phoebe Wang (phoebewang) Changes Ref: https://cdrdv2.intel.com/v1/dl/getContent/784343 --- Patch is 125.69 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/132426.diff 15 Files Affected: - (modif

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisync (Sync Delay) extension (PR #132184)

2025-03-21 Thread Sam Elliott via cfe-commits
https://github.com/lenary approved this pull request. LGTM. Thanks Harsh! https://github.com/llvm/llvm-project/pull/132184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Implement the implications of C extension (PR #132259)

2025-03-21 Thread Craig Topper via cfe-commits
@@ -25,8 +25,8 @@ addi a0, a1, 0 # CHECK: # encoding: [0xe0,0x1f] addi s0, sp, 1020 -# CHECK: .option arch, -c -.option arch, -c +# CHECK: .option arch, -c, -zca +.option arch, -c, -zca topperc wrote: The code for removing a feature doesn't even try to remov

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVT[,T]PS2I[,U]BS (PR #132426)

2025-03-21 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 09feaa9261448e72ce21394613e0a12f84c1b8d9 3d393696f47c30c48a485cf7ac1a0315287f8105 --e

[clang] [clang][CodeComplete] Use HeuristicResolver in getAsRecordDecl() (PR #130473)

2025-03-21 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/130473 >From 66e5ed1f1fcfe5a52d110ae228ddd51bd487ee16 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Sun, 9 Mar 2025 01:36:25 -0500 Subject: [PATCH 1/7] Change the parameter type of resolveTypeToTagDecl() to

[clang] [flang] [llvm] [clang] Add isOffloadingTarget function to LangOpts (PR #126956)

2025-03-21 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/126956 >From 044158c176316e6c9f44ce1487ff631c8a0d15c4 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Tue, 4 Mar 2025 11:16:34 -0800 Subject: [PATCH 1/2] [clang] Add isOffloadingTarget function to LangOpts Signed-o

[clang] [NFC][clang] Split clang/lib/CodeGen/CGBuiltin.cpp into target-specific files (PR #132252)

2025-03-21 Thread Jonathan Thackray via cfe-commits
jthackray wrote: So far I've got approvals, positive comments or thumbs-up emojis from: @jhuber6, @erichkeane, @Sirraide, @vmustya, @MacDue, @arichardson. @s-barannikov and @davemgreen - are you okay if I merge this soon, since `CGBuiltin.cpp` seems to get updated every few days. I've had to

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVTTP.*QS (PR #132414)

2025-03-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/132414 Ref: https://cdrdv2.intel.com/v1/dl/getContent/784343 >From 096e0b112724176f3d4893657580588a021d2224 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Fri, 21 Mar 2025 23:53:15 +0800 Subject: [PATCH] [X86]

[clang] [clang-tools-extra] [lldb] [llvm] Add test to clang-doc, it can test comments in macro. Original issue is #59819. (PR #132360)

2025-03-21 Thread Paul Kirth via cfe-commits
ilovepi wrote: Also, please change the PR title to ``` [clang-doc] Add regression test for test comments in macros ``` The body should contain `Fixes #59819. The underlying problem was fixed in https://reviews.llvm.org/D142560, but this patch adds a proper regression test.` https://github.

<    1   2   3   4   5   >