[clang] clang: Hack around opencl enqueue_block using wrong ABI for aggregrate (PR #130011)

2025-03-06 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/130011 EmitAggExprToLValue started wrapping the temporary alloca in an addrspacecast at some point. We take the direct type from this as the pointer argument for the runtime function type, but this isn't correct. Technic

[clang] clang: Hack around opencl enqueue_block using wrong ABI for aggregrate (PR #130011)

2025-03-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Matt Arsenault (arsenm) Changes EmitAggExprToLValue started wrapping the temporary alloca in an addrspacecast at some point. We take the direct type from this as the pointer argument for the runtime function type, but this isn't cor

[clang] clang: Hack around opencl enqueue_block using wrong ABI for aggregrate (PR #130011)

2025-03-06 Thread Matt Arsenault via cfe-commits
arsenm wrote: * **#130011** https://app.graphite.dev/github/pr/llvm/llvm-project/130011?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/13001

[clang] clang: Hack around opencl enqueue_block using wrong ABI for aggregrate (PR #130011)

2025-03-06 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/130011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Instantiate destructors for initialized members (PR #128866)

2025-03-06 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/128866 >From bb4091d2f9b7062aa83e5bee2ba525478a7dbd0a Mon Sep 17 00:00:00 2001 From: Maurice Heumann Date: Wed, 26 Feb 2025 14:31:47 +0100 Subject: [PATCH 1/8] Instantiate destructors from initialized anonymous union

[clang] [C++20][Modules] Fix incomplete decl chains (PR #129982)

2025-03-06 Thread Chuanqi Xu via cfe-commits
@@ -9180,6 +9180,12 @@ bool Sema::hasAcceptableDefinition(NamedDecl *D, NamedDecl **Suggested, if (!getLangOpts().Modules && !getLangOpts().ModulesLocalVisibility) return true; + // The external source may have additional definitions of this entity that are + // visi

[clang] [llvm] [RISCV] Add Qualcomn uC Xqcili (load large immediates) extension (PR #130012)

2025-03-06 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Sema] Instantiate destructors for initialized members (PR #128866)

2025-03-06 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/128866 >From bb4091d2f9b7062aa83e5bee2ba525478a7dbd0a Mon Sep 17 00:00:00 2001 From: Maurice Heumann Date: Wed, 26 Feb 2025 14:31:47 +0100 Subject: [PATCH 1/7] Instantiate destructors from initialized anonymous union

[libclc] [libclc] Stop installing CLC headers (PR #126908)

2025-03-06 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#130017 https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix mtp (PR #130022)

2025-03-06 Thread via cfe-commits
https://github.com/Zhenhang1213 created https://github.com/llvm/llvm-project/pull/130022 None >From 0db9830f5d5e29288c87e5935df913b99a040d93 Mon Sep 17 00:00:00 2001 From: Austin Date: Thu, 27 Feb 2025 00:11:56 +0800 Subject: [PATCH 1/3] [ARM] Introduce -mtp=auto and make it the default This

[clang] f01e760 - [AArch64][SVE] Improve fixed-length addressing modes. (#129732)

2025-03-06 Thread via cfe-commits
Author: Ricardo Jesus Date: 2025-03-06T09:27:07Z New Revision: f01e760c08365426de95f02dc2c2dc670eb47352 URL: https://github.com/llvm/llvm-project/commit/f01e760c08365426de95f02dc2c2dc670eb47352 DIFF: https://github.com/llvm/llvm-project/commit/f01e760c08365426de95f02dc2c2dc670eb47352.diff LOG:

[clang] [ARM] Using cp15 while mtp =auto and arch is arm_arch6k and support thumb2 (PR #130027)

2025-03-06 Thread via cfe-commits
https://github.com/Zhenhang1213 created https://github.com/llvm/llvm-project/pull/130027 We follow GCC mtp=auto when arch is arm_arch6k and support thumb2 reference:https://reviews.llvm.org/D114116 >From 751ef68cf68739277b8975157b5693fa4bc72abe Mon Sep 17 00:00:00 2001 From: Austin Date: Thu,

[clang] [clang] Improve diagnostics for vector builtins (PR #125673)

2025-03-06 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: ping, thanks https://github.com/llvm/llvm-project/pull/125673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b941d90 - [clang] Pass fp128 indirectly and return in xmm0 on Windows (#115052)

2025-03-06 Thread via cfe-commits
Author: Trevor Gross Date: 2025-03-06T17:31:01+08:00 New Revision: b941d90c4de204631509176fea603762eef795d3 URL: https://github.com/llvm/llvm-project/commit/b941d90c4de204631509176fea603762eef795d3 DIFF: https://github.com/llvm/llvm-project/commit/b941d90c4de204631509176fea603762eef795d3.diff

[clang] [clang] Pass fp128 indirectly and return in xmm0 on Windows (PR #115052)

2025-03-06 Thread via cfe-commits
github-actions[bot] wrote: @tgross35 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang] [ARM] Using cp15 while mtp =auto and arch is arm_arch6k and support thumb2 (PR #130027)

2025-03-06 Thread via cfe-commits
https://github.com/Zhenhang1213 edited https://github.com/llvm/llvm-project/pull/130027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [lldb] [llvm] [mlir] [polly] [IR] Store Triple in Module (NFC) (PR #129868)

2025-03-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang,flang,lldb,llvm,mlir,offload,polly` at step 6 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/bu

[clang] [Clang] use constant evaluation context for constexpr if conditions (PR #123667)

2025-03-06 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/123667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Instantiate destructors for initialized members (PR #128866)

2025-03-06 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/128866 >From bb4091d2f9b7062aa83e5bee2ba525478a7dbd0a Mon Sep 17 00:00:00 2001 From: Maurice Heumann Date: Wed, 26 Feb 2025 14:31:47 +0100 Subject: [PATCH 1/6] Instantiate destructors from initialized anonymous union

[clang] [Feature]: merge host and kernel dependencies for heterogeneous compilation (PR #119513)

2025-03-06 Thread via cfe-commits
https://github.com/zhouronghua updated https://github.com/llvm/llvm-project/pull/119513 >From 084505ded118c741717d54e4e463fe4e293fce41 Mon Sep 17 00:00:00 2001 From: "ronghua.zhou" Date: Fri, 14 Feb 2025 01:04:51 + Subject: [PATCH] [Feature]: support for the BC library file into the compile

[clang] [Sema] Instantiate destructors for initialized members (PR #128866)

2025-03-06 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/128866 >From bb4091d2f9b7062aa83e5bee2ba525478a7dbd0a Mon Sep 17 00:00:00 2001 From: Maurice Heumann Date: Wed, 26 Feb 2025 14:31:47 +0100 Subject: [PATCH 1/9] Instantiate destructors from initialized anonymous union

[clang] [Sema] Instantiate destructors for initialized members (PR #128866)

2025-03-06 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/128866 >From bb4091d2f9b7062aa83e5bee2ba525478a7dbd0a Mon Sep 17 00:00:00 2001 From: Maurice Heumann Date: Wed, 26 Feb 2025 14:31:47 +0100 Subject: [PATCH 01/10] Instantiate destructors from initialized anonymous uni

[clang] [C++20][Modules] Fix incomplete decl chains (PR #129982)

2025-03-06 Thread Michael Park via cfe-commits
https://github.com/mpark edited https://github.com/llvm/llvm-project/pull/129982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add support for missing OpenCL extensions (PR #129777)

2025-03-06 Thread Sven van Haastregt via cfe-commits
svenvh wrote: > When someone passes the `-Xclang -cl-ext=+all`, the compiler should add > defines for all the supported extensions. Indeed; we already have such a list in `opencl-c-base.h` to enable all header-only extensions for the `spir`/`spirv` targets, so it should be easy to make `-cl-e

[clang] [Sema] Instantiate destructors for initialized members (PR #128866)

2025-03-06 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/128866 >From bb4091d2f9b7062aa83e5bee2ba525478a7dbd0a Mon Sep 17 00:00:00 2001 From: Maurice Heumann Date: Wed, 26 Feb 2025 14:31:47 +0100 Subject: [PATCH 1/6] Instantiate destructors from initialized anonymous union

[clang] [llvm] [RISCV] Add Qualcomn uC Xqcili (load large immediates) extension (PR #130012)

2025-03-06 Thread via cfe-commits
https://github.com/u4f3 created https://github.com/llvm/llvm-project/pull/130012 The Xqcili extension includes a two instructions that load large immediates than is available with the base RISC-V ISA. The current spec can be found at: https://github.com/quic/riscv-unified-db/releases/tag/Xqci-

[clang] [clang-format] Fix a bug in wrapping function return type (PR #129374)

2025-03-06 Thread Björn Schäpers via cfe-commits
@@ -5091,8 +5091,10 @@ UnwrappedLineParser::parseMacroCall() { void UnwrappedLineParser::pushToken(FormatToken *Tok) { Line->Tokens.push_back(UnwrappedLineNode(Tok)); if (MustBreakBeforeNextToken) { HazardyKnusperkeks wrote: Good. https://github.com/llvm/

[clang] [ARM] Using cp15 while mtp =auto and arch is arm_arch6k and support thumb2 (PR #130027)

2025-03-06 Thread Peter Smith via cfe-commits
@@ -240,7 +247,7 @@ arm::ReadTPMode arm::getReadTPMode(const Driver &D, const ArgList &Args, D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args); return ReadTPMode::Invalid; } - return (isHardTPSupported(Triple) ? ReadTPMode::TPIDRURO : ReadTPMode::Soft); +

[clang] Fix mtp (PR #130022)

2025-03-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Austin (Zhenhang1213) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/130022.diff 5 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+4) - (modified) clang/include/clang/Driver/Options.td (+1-1) - (modified)

[clang] [Clang] Check for uninitialized use in lambda within CXXOperatorCallExpr (PR #129198)

2025-03-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/129198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reduce memory usage in AST parent map generation by lazily checking if nodes have been seen (PR #129934)

2025-03-06 Thread Erich Keane via cfe-commits
@@ -70,16 +93,37 @@ class ParentMapContext::ParentMap { push_back(Value); } bool contains(const DynTypedNode &Value) { - return Seen.contains(Value); + assert(Value.getMemoizationData()); + bool found = FragileLazySeenCache.contains(&Value); +

[clang] [Sema] Instantiate destructors for initialized members (PR #128866)

2025-03-06 Thread Erich Keane via cfe-commits
@@ -5283,6 +5283,102 @@ Sema::SetDelegatingInitializer(CXXConstructorDecl *Constructor, return false; } +static CXXDestructorDecl *LookupDestructorIfRelevant(Sema &S, + CXXRecordDecl *Class) { + if (Class->isInvalidDecl()

[clang] [clang][test] Fix -DBUILD_SHARED_LIBS build by adding depency on Targ… (PR #130105)

2025-03-06 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/130105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fixed vec_pack_to_short_fp32 in Clang altivec.h (PR #129923)

2025-03-06 Thread John Platts via cfe-commits
johnplatts wrote: I have discovered that there is a bug in the VSX `vec_pack_to_short_fp32(a, b)` intrinsic with GCC on big-endian POWER9 (but not little-endian POWER9), where `vec_pack_to_short_fp32(a, b)` returns `{b[0], b[1], b[2], b[3], a[0], a[1], a[2], a[3]}` instead of the expected `{a[

[clang] [ARM] Using cp15 while mtp =auto and arch is arm_arch6k and support thumb2 (PR #130027)

2025-03-06 Thread Vladi Krapp via cfe-commits
VladiKrapp-Arm wrote: The updated version looks better. I think we need to remove ARMV6T2 from the list, as it does not seem to support the feature. https://developer.arm.com/documentation/ddi0290/g/system-control-coprocessor/system-control-processor-registers/c13--process-id-register?lang=en

[clang] [clang] Implement address sanitizer on AIX (1/3) (PR #129925)

2025-03-06 Thread Jake Egan via cfe-commits
https://github.com/jakeegan edited https://github.com/llvm/llvm-project/pull/129925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 156cdcf - [Assignment Tracking] Replace `undef` debug info with `poison` (#129755)

2025-03-06 Thread via cfe-commits
Author: Pedro Lobo Date: 2025-03-06T12:30:05+01:00 New Revision: 156cdcf2ffc9a5f851e1b340891172462938b5ea URL: https://github.com/llvm/llvm-project/commit/156cdcf2ffc9a5f851e1b340891172462938b5ea DIFF: https://github.com/llvm/llvm-project/commit/156cdcf2ffc9a5f851e1b340891172462938b5ea.diff LO

[clang] [llvm] [Assignment Tracking] Replace `undef` debug info with `poison` (PR #129755)

2025-03-06 Thread Nikita Popov via cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/129755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Change `ASTUnit::getASTContext() const` to return a non-const `ASTContext` (PR #130096)

2025-03-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Boaz Brickner (bricknerb) Changes Also, remove the non-const `ASTUnit::getASTContext()` since it's no longer necessary. This would make it similar to `Decl::getAstContext() const` for a more consistent and flexible API. --- Full diff: ht

[clang] Change `ASTUnit::getASTContext() const` to return a non-const `ASTContext` (PR #130096)

2025-03-06 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb created https://github.com/llvm/llvm-project/pull/130096 Also, remove the non-const `ASTUnit::getASTContext()` since it's no longer necessary. This would make it similar to `Decl::getAstContext() const` for a more consistent and flexible API. >From be1b384568aab7a

[clang-tools-extra] [clang-tidy] Avoid processing declarations in system headers (PR #128150)

2025-03-06 Thread Balazs Benics via cfe-commits
Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: steakhal wrote: > That's a good point. @haoNoQ @Xazax-hun @steakhal Do you see any implications > on this patch when running clang static analyzer via clang-tidy? Any checks > that would stop detecting issues? >

[clang] [Clang] use parameter location for abbreviated function templates (PR #129139)

2025-03-06 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/129139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Instantiate destructors for initialized members (PR #128866)

2025-03-06 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/128866 >From f23cf926c4dbf934971e5f4f8b40105e3b41bb0f Mon Sep 17 00:00:00 2001 From: Maurice Heumann Date: Wed, 26 Feb 2025 14:31:47 +0100 Subject: [PATCH 1/6] Instantiate destructors from initialized anonymous union

[clang-tools-extra] [clangd] Explicitly block until async task completes (PR #130077)

2025-03-06 Thread Ilya Biryukov via cfe-commits
@@ -460,18 +460,24 @@ void ClangdServer::codeComplete(PathRef File, Position Pos, CodeCompleteResult Result = clangd::codeComplete( File, Pos, IP->Preamble, ParseInput, CodeCompleteOpts, SpecFuzzyFind ? &*SpecFuzzyFind : nullptr); +// We don't want `cod

[clang] Reduce memory usage in AST parent map generation by lazily checking if nodes have been seen (PR #129934)

2025-03-06 Thread Aaron Ballman via cfe-commits
@@ -70,16 +94,38 @@ class ParentMapContext::ParentMap { push_back(Value); } bool contains(const DynTypedNode &Value) { - return Seen.contains(Value); + assert(Value.getMemoizationData()); + bool found = FragileLazySeenCache.contains(&Value); +

[clang] Reduce memory usage in AST parent map generation by lazily checking if nodes have been seen (PR #129934)

2025-03-06 Thread Aaron Ballman via cfe-commits
@@ -70,16 +94,38 @@ class ParentMapContext::ParentMap { push_back(Value); } bool contains(const DynTypedNode &Value) { - return Seen.contains(Value); + assert(Value.getMemoizationData()); + bool found = FragileLazySeenCache.contains(&Value); -

[clang] [flang] [lldb] [llvm] [mlir] [polly] [IR] Store Triple in Module (NFC) (PR #129868)

2025-03-06 Thread Nikita Popov via cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/129868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Change `ASTUnit::getASTContext() const` to return a non-const `ASTContext` (PR #130096)

2025-03-06 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > There is no const_cast, or casting away const in any form on this patch, so > how does it weaken const correctness? When a function is marked as `const`, the implication is that calling the function should not lead to an underlying mutation. Given that this function is r

[libclc] [libclc] Reduce bithacking for INF/NAN values (PR #129738)

2025-03-06 Thread Fraser Cormack via cfe-commits
@@ -46,9 +46,7 @@ _CLC_DEF _CLC_OVERLOAD __CLC_GENTYPE __clc_hypot(__CLC_GENTYPE x, __CLC_GENTYPE retval = __clc_sqrt(__clc_mad(fx, fx, fy * fy)) * fx_exp; retval = (ux > PINFBITPATT_SP32 || uy == 0) ? __CLC_AS_GENTYPE(ux) : retval; - retval = (ux == PINFBITPATT_SP32 ||

[clang] Reduce memory usage in AST parent map generation by lazily checking if nodes have been seen (PR #129934)

2025-03-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Just some minor nits from me so far. I think there may be some additional performance benefits we could eek out, but I don't think they need to be done in this patch (or done at all, it's speculative). One is that I noticed `ASTContext::getTraversalSc

[clang] Reduce memory usage in AST parent map generation by lazily checking if nodes have been seen (PR #129934)

2025-03-06 Thread Erich Keane via cfe-commits
erichkeane wrote: > Just some minor nits from me so far. > > I think there may be some additional performance benefits we could eek out, > but I don't think they need to be done in this patch (or done at all, it's > speculative). One is that I noticed `ASTContext::getTraversalScope()` is > re

[clang] Reduce memory usage in AST parent map generation by lazily checking if nodes have been seen (PR #129934)

2025-03-06 Thread Erich Keane via cfe-commits
erichkeane wrote: > > One is that I noticed `ASTContext::getTraversalScope()` is returning a > > vector by copy and that doesn't seem necessary. I noticed this too! I'm actually working on validating a RAC fix for this right now, just to have it return an ArrayRef instead. Both uses of that

[clang] [ARM] Using cp15 while mtp =auto and arch is arm_arch6k and support thumb2 (PR #130027)

2025-03-06 Thread Vladi Krapp via cfe-commits
@@ -208,10 +208,17 @@ bool arm::useAAPCSForMachO(const llvm::Triple &T) { bool arm::isHardTPSupported(const llvm::Triple &Triple) { int Ver = getARMSubArchVersionNumber(Triple); llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Triple.getArchName()); - return Triple.isARM() ||

[clang] 7e5821b - Reapply "[analyzer] Handle [[assume(cond)]] as __builtin_assume(cond)" (#129234)

2025-03-06 Thread via cfe-commits
Author: Balazs Benics Date: 2025-03-06T08:09:09+01:00 New Revision: 7e5821bae80db3f3f0fe0d5f8ce62f79e548eed5 URL: https://github.com/llvm/llvm-project/commit/7e5821bae80db3f3f0fe0d5f8ce62f79e548eed5 DIFF: https://github.com/llvm/llvm-project/commit/7e5821bae80db3f3f0fe0d5f8ce62f79e548eed5.diff

[clang-tools-extra] [clangd] Explicitly block until async task completes (PR #130077)

2025-03-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/130077 We started seeing some use-after-frees starting with https://github.com/llvm/llvm-project/pull/125433. This patch ensures we explicitly block for the async task, if there's one, before destructing `std::future

[clang-tools-extra] [clangd] Explicitly block until async task completes (PR #130077)

2025-03-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: kadir çetinkaya (kadircet) Changes We started seeing some use-after-frees starting with https://github.com/llvm/llvm-project/pull/125433. This patch ensures we explicitly block for the async task, if there's one, before destructing `std:

[clang-tools-extra] [clangd] Explicitly block until async task completes (PR #130077)

2025-03-06 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/130077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [analysis] Software Bill of Mitigations (PR #130103)

2025-03-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matthew Levy (matthewlevy97) Changes The goal of this stack is to provide a metric to audit the deployed mitigations in a binary and where they are enabled at function level granularity. This will enable tracking of where we do and don't

[clang] [clang][dataflow] Add test for crash repro and clean up const accessor handling (PR #129930)

2025-03-06 Thread Jan Voung via cfe-commits
https://github.com/jvoung ready_for_review https://github.com/llvm/llvm-project/pull/129930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 09e0100 - [Clang] use parameter location for abbreviated function templates (#129139)

2025-03-06 Thread via cfe-commits
Author: Oleksandr T. Date: 2025-03-06T15:12:53+02:00 New Revision: 09e010001773d7d7efc0cafe78d3c8899d8bc45d URL: https://github.com/llvm/llvm-project/commit/09e010001773d7d7efc0cafe78d3c8899d8bc45d DIFF: https://github.com/llvm/llvm-project/commit/09e010001773d7d7efc0cafe78d3c8899d8bc45d.diff

[clang] [AMDGPU] Run DL builtin tests for new GFX (PR #130054)

2025-03-06 Thread Mariusz Sikora via cfe-commits
https://github.com/mariusz-sikora-at-amd closed https://github.com/llvm/llvm-project/pull/130054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][LLVM] Implement single-multi vectors MOP4{A/S} (PR #128854)

2025-03-06 Thread via cfe-commits
https://github.com/Lukacma edited https://github.com/llvm/llvm-project/pull/128854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9189d84 - [NFC] Change the return type of `getTraversalScope` to `ArrayRef`

2025-03-06 Thread via cfe-commits
Author: erichkeane Date: 2025-03-06T07:04:34-08:00 New Revision: 9189d84abbfc643db0053200c1c2e16b1e78e8f9 URL: https://github.com/llvm/llvm-project/commit/9189d84abbfc643db0053200c1c2e16b1e78e8f9 DIFF: https://github.com/llvm/llvm-project/commit/9189d84abbfc643db0053200c1c2e16b1e78e8f9.diff LO

[clang] 5bb112f - [NFC][OpenACC] Fix unused variable warning from df1e102e

2025-03-06 Thread via cfe-commits
Author: erichkeane Date: 2025-03-06T07:08:00-08:00 New Revision: 5bb112feaeab99018f7ae2c59620d557f2b958ae URL: https://github.com/llvm/llvm-project/commit/5bb112feaeab99018f7ae2c59620d557f2b958ae DIFF: https://github.com/llvm/llvm-project/commit/5bb112feaeab99018f7ae2c59620d557f2b958ae.diff LO

[clang] [clang] Apply internal buffering to clang diagnostics printing (PR #113440)

2025-03-06 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: @tahonermann thank you for your investigation, and sorry for the delay. > Is it known which platforms are affected by this issue? The issue is reported on Linux with a makefile as a reproducer. I'm not aware if that is the case on Windows. > I think it is worth cleaning this

[clang] [clang][dataflow] Add test for crash repro and clean up const accessor handling (PR #129930)

2025-03-06 Thread Yitzhak Mandelbaum via cfe-commits
@@ -577,57 +580,62 @@ void handleConstMemberCall(const CallExpr *CE, auto &ResultLoc = State.Env.getResultObjectLocation(*CE); copyRecord(cast(Loc), ResultLoc, State.Env); } -return; +return true; } // Cache if the const method returns a referenc

[clang] [AMDGPU] Run DL builtin tests for new GFX (PR #130054)

2025-03-06 Thread Piotr Sobczak via cfe-commits
https://github.com/piotrAMD approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/130054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ARM] Using cp15 while mtp =auto and arch is arm_arch6k and support thumb2 (PR #130027)

2025-03-06 Thread via cfe-commits
@@ -208,10 +208,17 @@ bool arm::useAAPCSForMachO(const llvm::Triple &T) { bool arm::isHardTPSupported(const llvm::Triple &Triple) { int Ver = getARMSubArchVersionNumber(Triple); llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Triple.getArchName()); - return Triple.isARM() ||

[clang] [libcxx] [Clang] Add __builtin_common_reference (PR #121199)

2025-03-06 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/121199 >From 55f9d1e5abf5f217e58988742bd7f375d744beb8 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Fri, 27 Sep 2024 22:11:14 +0200 Subject: [PATCH] [Clang] Add __builtin_common_reference --- clang/docs/Lan

[clang] [clang] Add isOffloadingTarget function to LangOpts (PR #126956)

2025-03-06 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon approved this pull request. I appreciate the generalization, thanks! https://github.com/llvm/llvm-project/pull/126956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [llvm] [Clang][LLVM] Implement single-multi vectors MOP4{A/S} (PR #128854)

2025-03-06 Thread Virginia Cangelosi via cfe-commits
https://github.com/virginia-cangelosi edited https://github.com/llvm/llvm-project/pull/128854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Add test for crash repro and clean up const accessor handling (PR #129930)

2025-03-06 Thread Yitzhak Mandelbaum via cfe-commits
@@ -577,57 +580,62 @@ void handleConstMemberCall(const CallExpr *CE, auto &ResultLoc = State.Env.getResultObjectLocation(*CE); copyRecord(cast(Loc), ResultLoc, State.Env); } -return; +return true; } // Cache if the const method returns a referenc

[clang] [clang] Add isOffloadingTarget function to LangOpts (PR #126956)

2025-03-06 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm commented: The target isn't part of the language, why is it in LangOpts? https://github.com/llvm/llvm-project/pull/126956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [ARM] Using cp15 while mtp =auto and arch is arm_arch6k and support thumb2 (PR #130027)

2025-03-06 Thread via cfe-commits
https://github.com/Zhenhang1213 updated https://github.com/llvm/llvm-project/pull/130027 >From ab10e36766013ef8406ed8a4f7f3e398e04186d2 Mon Sep 17 00:00:00 2001 From: Austin Date: Thu, 6 Mar 2025 17:25:55 +0800 Subject: [PATCH] [ARM] Using cp15 while mtp =auto and arch is arm_arch6k and suppo

[clang] [llvm] [analysis] Software Bill of Mitigations (PR #130103)

2025-03-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Matthew Levy (matthewlevy97) Changes The goal of this stack is to provide a metric to audit the deployed mitigations in a binary and where they are enabled at function level granularity. This will enable tracking of where we do and

[clang-tools-extra] [clang-tidy] Avoid processing declarations in system headers (PR #128150)

2025-03-06 Thread Carlos Galvez via cfe-commits
Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: carlosgalvezp wrote: Thank you for the quick answer! I will then proceed to rebase against latest trunk and merge :) We can look into applying the same change to the static analyzer in a separate patch. https://g

[clang] [clang][dataflow] Add test for crash repro and clean up const accessor handling (PR #129930)

2025-03-06 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/129930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add -Wshift-bool warning to handle shifting of bool (PR #127336)

2025-03-06 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/127336 >From 272385df25b791b50472b92e12157477d021a26f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 15 Feb 2025 18:19:44 +0200 Subject: [PATCH 1/8] [Clang] add -Wshift-bool warning to handle shifting of boo

[clang] [HLSL][SPIR-V] Add hlsl_private address space for HLSL/SPIR-V (PR #122103)

2025-03-06 Thread Nathan Gauër via cfe-commits
@@ -58,6 +58,7 @@ enum class LangAS : unsigned { // HLSL specific address spaces. hlsl_groupshared, + hlsl_private, Keenuts wrote: Hi again! It's been a while, but this now went through an HLSL proposal. https://github.com/llvm/wg-hlsl/commit/4c9e11aa507

[clang] [llvm] [Clang][LLVM] Implement single-multi vectors MOP4{A/S} (PR #128854)

2025-03-06 Thread via cfe-commits
https://github.com/Lukacma commented: Looks good. I would definitely highlight in the PR description the change to SVEEmitter you made though and the reasoning behind it. https://github.com/llvm/llvm-project/pull/128854 ___ cfe-commits mailing list cf

[clang] [llvm] [RISCV] Add Qualcomn uC Xqcili (load large immediates) extension (PR #130012)

2025-03-06 Thread via cfe-commits
https://github.com/u4f3 updated https://github.com/llvm/llvm-project/pull/130012 >From 1abf892d26713b3425b1f1dc0d6834b9bd0aba70 Mon Sep 17 00:00:00 2001 From: u4f3 Date: Wed, 5 Mar 2025 12:59:03 + Subject: [PATCH] [RISCV] Add Qualcomn uC Xqcili (load large immediates) extension The Xqcili

[clang] [flang] [lldb] [llvm] [mlir] [polly] [IR] Store Triple in Module (NFC) (PR #129868)

2025-03-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-nvptx64-nvidia-ubuntu` running on `as-builder-7` while building `clang,flang,lldb,llvm,mlir,offload,polly` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/build

[clang] Change `ASTUnit::getASTContext() const` to return a non-const `ASTContext` (PR #130096)

2025-03-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: This is weakening const correctness, which is the opposite direction of where we should be going IMO. https://github.com/llvm/llvm-project/pull/130096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] Fix amdgpu-arch for dll name on Windows (PR #101350)

2025-03-06 Thread Matt Arsenault via cfe-commits
@@ -31,16 +44,118 @@ typedef hipError_t (*hipGetDeviceCount_t)(int *); typedef hipError_t (*hipDeviceGet_t)(int *, int); typedef hipError_t (*hipGetDeviceProperties_t)(hipDeviceProp_t *, int); -int printGPUsByHIP() { +extern cl::opt Verbose; + #ifdef _WIN32 - constexpr const

[clang] Change `ASTUnit::getASTContext() const` to return a non-const `ASTContext` (PR #130096)

2025-03-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll requested changes to this pull request. I agree with Aaron that this patch doesn't move us towards the direction we generally want. I'd like to see more justification than 2 lines in the description. https://github.com/llvm/llvm-project/pull/130096 __

[clang] [clang] Reject constexpr-unknown values as constant expressions more consistently (PR #129952)

2025-03-06 Thread via cfe-commits
@@ -154,3 +154,26 @@ int g() { static_assert(f(arr) == 5); } } + +namespace GH128409 { + int &ff(); + int &x = ff(); // nointerpreter-note {{declared here}} + constinit int &z = x; // expected-error {{variable does not have a constant initializer}} +

[clang] [clang] Reject constexpr-unknown values as constant expressions more consistently (PR #129952)

2025-03-06 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. I think this makes sense. Presumably we would backport it to 20 https://github.com/llvm/llvm-project/pull/129952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] Change `ASTUnit::getASTContext() const` to return a non-const `ASTContext` (PR #130096)

2025-03-06 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: There is no const_cast, or casting away const in any form on this patch, so how does it weaken const correctness? https://github.com/llvm/llvm-project/pull/130096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [llvm] [Clang][LLVM] Implement single-multi vectors MOP4{A/S} (PR #128854)

2025-03-06 Thread Virginia Cangelosi via cfe-commits
@@ -3835,7 +3866,7 @@ let TargetPrefix = "aarch64" in { def int_aarch64_sme_luti4_lane_zt_x2 : DefaultAttrsIntrinsic<[llvm_anyvector_ty, LLVMMatchType<0>], [llvm_i32_ty, llvm_nxv16i8_ty, llvm_i32_ty], [ImmArg>, ImmArg>, IntrReadMem]>; -

[clang] [clang][dataflow] Add test for crash repro and clean up const accessor handling (PR #129930)

2025-03-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-analysis Author: Jan Voung (jvoung) Changes Add test for https://github.com/llvm/llvm-project/issues/125589 The crash is actually incidentally fixed by https://github.com/llvm/llvm-project/pull/128437 since it added a b

[clang] [llvm] [RISCV] Add Qualcomn uC Xqcili (load large immediates) extension (PR #130012)

2025-03-06 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/130012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Qualcomn uC Xqcili (load large immediates) extension (PR #130012)

2025-03-06 Thread Craig Topper via cfe-commits
@@ -588,6 +590,19 @@ let Predicates = [HasVendorXqcilo, IsRV32] in { def QC_E_SW: QCIRVInstESStore<0b110, 0b11, "qc.e.sw">; } // Predicates = [HasVendorXqcilo, IsRV32] +let Predicates = [HasVendorXqcili, IsRV32] in { +let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in

[clang] [llvm] [RISCV] Add Qualcomn uC Xqcili (load large immediates) extension (PR #130012)

2025-03-06 Thread Craig Topper via cfe-commits
@@ -588,6 +590,19 @@ let Predicates = [HasVendorXqcilo, IsRV32] in { def QC_E_SW: QCIRVInstESStore<0b110, 0b11, "qc.e.sw">; } // Predicates = [HasVendorXqcilo, IsRV32] +let Predicates = [HasVendorXqcili, IsRV32] in { +let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in

[clang] [Clang][OpenCL][AMDGPU] Allow a kernel to call another kernel (PR #115821)

2025-03-06 Thread Matt Arsenault via cfe-commits
arsenm wrote: reverse ping https://github.com/llvm/llvm-project/pull/115821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang: Hack around opencl enqueue_block using wrong ABI for aggregrate (PR #130011)

2025-03-06 Thread Matt Arsenault via cfe-commits
arsenm wrote: > Is this PR intended to match the signature of `__enqueue_kernel_basic` > defined in device library? e.g. Yes > https://github.com/ROCm/llvm-project/blob/amd-staging/amd/device-libs/opencl/src/devenq/enqueue.cl#L172 > > Since ndrange_t is passed by value, it becomes pointer to

[clang] [llvm] [Clang][LLVM] Implement multi-single vectors MOP4{A/S} (PR #129226)

2025-03-06 Thread via cfe-commits
@@ -257,6 +266,17 @@ class SME2_Tile_Movaz_Pat(name # _PSEUDO) $tile, $base, $offset)>; +class SME2_ZA_Tile_TwoVec_Pat +: Pat<(intrinsic imm_ty:$tile, vt:$Zn, vt:$Zm), + (!cast(name # _PSEUDO) $tile, $Zn, $Zm)>; + +class SME2_ZA_Tile_Vec_Multi_Pat L

[clang] clang: Hack around opencl enqueue_block using wrong ABI for aggregrate (PR #130011)

2025-03-06 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. https://github.com/llvm/llvm-project/pull/130011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Fix incomplete decl chains (PR #129982)

2025-03-06 Thread Michael Park via cfe-commits
@@ -9180,6 +9180,12 @@ bool Sema::hasAcceptableDefinition(NamedDecl *D, NamedDecl **Suggested, if (!getLangOpts().Modules && !getLangOpts().ModulesLocalVisibility) return true; + // The external source may have additional definitions of this entity that are + // visi

[libclc] [libclc] Stop installing CLC headers (PR #126908)

2025-03-06 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck milestoned https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Fix incomplete decl chains (PR #129982)

2025-03-06 Thread Michael Park via cfe-commits
@@ -9180,6 +9180,12 @@ bool Sema::hasAcceptableDefinition(NamedDecl *D, NamedDecl **Suggested, if (!getLangOpts().Modules && !getLangOpts().ModulesLocalVisibility) return true; + // The external source may have additional definitions of this entity that are + // visi

  1   2   3   4   >