llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jonathan Schleifer (Midar)
Changes
There was no reason for it to ever be disabled.
---
Full diff: https://github.com/llvm/llvm-project/pull/126382.diff
1 Files Affected:
- (modified) clang/include/clang/Basic/ObjCRuntime.h (+1-1)
```
Midar wrote:
Would @rjmccall be the appropriate reviewer?
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Midar wrote:
Also, would it be possible to get this into 20.1?
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Flandini edited
https://github.com/llvm/llvm-project/pull/125638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Flandini edited
https://github.com/llvm/llvm-project/pull/125638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Midar wrote:
Actually, I realized this needs more work, as GenerateDirectMethodPrologue
needs to be implemented. Moving to draft.
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/Midar converted_to_draft
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Even if a variable is defined in the main file, it could conflict with
another one in a library being linked.
In any case, my understanding is that this is a common C++ practice,
thought I do not see it spelled out explicitly in the coding standards doc:
file scoped global variabl
kidq330 wrote:
@kadircet I ran the script but it seems that my check was one of the few that
did not get updated (see last commit in PR), is this normal?
Here's the cmake command for the build I used:
```
cmake -G Ninja -S llvm -B static -DBUILD_SHARED_LIBS=false
-DLLVM_ENABLE_PROJECTS="clang;
https://github.com/Midar updated
https://github.com/llvm/llvm-project/pull/126382
>From 9b076179061731a647921271e400dbdaea31f60d Mon Sep 17 00:00:00 2001
From: Jonathan Schleifer
Date: Sat, 8 Feb 2025 12:12:21 +0100
Subject: [PATCH] Allow direct dispatch for the ObjFW runtime >= 1.3
---
clang
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
https://github.com/llvm/llvm-project/pull/126378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
https://github.com/llvm/llvm-project/pull/126379
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
https://github.com/llvm/llvm-project/pull/126380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
https://github.com/llvm/llvm-project/pull/126381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar updated
https://github.com/llvm/llvm-project/pull/126382
>From ddc24b92cb8cc629082d0943de0f726a7604241e Mon Sep 17 00:00:00 2001
From: Jonathan Schleifer
Date: Sat, 8 Feb 2025 12:12:21 +0100
Subject: [PATCH] Allow direct dispatch for the ObjFW runtime
---
clang/includ
https://github.com/Midar ready_for_review
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Midar wrote:
Copied the necessary parts from CGObjCMac to just ObjFW, as GNUstep decided to
do it very differently.
Theoretically, the same could be done for the GCC runtime. Should it?
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/126378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2025-02-08T11:35:17-08:00
New Revision: 451007173abaeff7de70d6d7fb0135b7858d093d
URL:
https://github.com/llvm/llvm-project/commit/451007173abaeff7de70d6d7fb0135b7858d093d
DIFF:
https://github.com/llvm/llvm-project/commit/451007173abaeff7de70d6d7fb0135b7858d093d.diff
L
Author: Kazu Hirata
Date: 2025-02-08T11:35:45-08:00
New Revision: 2fee5ef2356b514dda30e89f39125a390c0d928e
URL:
https://github.com/llvm/llvm-project/commit/2fee5ef2356b514dda30e89f39125a390c0d928e
DIFF:
https://github.com/llvm/llvm-project/commit/2fee5ef2356b514dda30e89f39125a390c0d928e.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/126379
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2025-02-08T11:36:05-08:00
New Revision: 7628fcf3d43eb20c292ab0dd25ba3f52dba248a6
URL:
https://github.com/llvm/llvm-project/commit/7628fcf3d43eb20c292ab0dd25ba3f52dba248a6
DIFF:
https://github.com/llvm/llvm-project/commit/7628fcf3d43eb20c292ab0dd25ba3f52dba248a6.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/126380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2025-02-08T11:36:35-08:00
New Revision: cf5947be13e7af67219379e07bc0128f1f1e7f88
URL:
https://github.com/llvm/llvm-project/commit/cf5947be13e7af67219379e07bc0128f1f1e7f88
DIFF:
https://github.com/llvm/llvm-project/commit/cf5947be13e7af67219379e07bc0128f1f1e7f88.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/126381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sharadhr wrote:
Fair point. Added a test. Additionally the CMake repository contains a bigger
battery of tests that also all pass with this PR.
https://github.com/llvm/llvm-project/pull/121046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/126143
>From 1e329fb618197df297b7431acefd89a498fb1083 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Thu, 6 Feb 2025 15:54:19 -0600
Subject: [PATCH] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use
stat
Author: Wael Yehia
Date: 2025-02-08T17:25:07-05:00
New Revision: 8e61aae4a8ce938f42604b10123c3b21d4adc0b8
URL:
https://github.com/llvm/llvm-project/commit/8e61aae4a8ce938f42604b10123c3b21d4adc0b8
DIFF:
https://github.com/llvm/llvm-project/commit/8e61aae4a8ce938f42604b10123c3b21d4adc0b8.diff
LO
w2yehia wrote:
thanks @MaskRay
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross`
running on `suse-gary-m68k-cross` while building `clang` at step 4 "build stage
1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/27/builds/5875
Here is the relevant piece o
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9d5edc9a0dd35049017aad2a9d3f4a4a2746fec9
0b1dde3ae55ad88f7578fa6a171406ca82a172ee --e
@@ -660,17 +672,18 @@ class LineJoiner {
assert(Limit >= L1.Last->TotalLength + 3);
const auto InnerLimit = Limit - L1.Last->TotalLength - 3;
- const auto MergedLines = tryMergeNamespace(I + 1, E, InnerLimit);
+ const auto MergedLines =
+ tryMerg
@@ -688,8 +701,8 @@ class LineJoiner {
if (L2.First->isNot(tok::r_brace) || L2.First->MustBreakBefore)
return 0;
-// If so, merge all three lines.
-return 2;
+// If so, merge all lines.
+return 2 + OpeningBraceLineOffset;
owenca wrote
@@ -628,28 +632,36 @@ class LineJoiner {
unsigned tryMergeNamespace(ArrayRef::const_iterator I,
ArrayRef::const_iterator E,
- unsigned Limit) {
+ unsigned Limit, bool OpenBraceWrapped) {
@@ -628,28 +632,36 @@ class LineJoiner {
unsigned tryMergeNamespace(ArrayRef::const_iterator I,
ArrayRef::const_iterator E,
- unsigned Limit) {
+ unsigned Limit, bool OpenBraceWrapped) {
@@ -367,8 +367,12 @@ class LineJoiner {
if (Style.AllowShortNamespacesOnASingleLine &&
TheLine->First->is(tok::kw_namespace) &&
-TheLine->Last->is(tok::l_brace)) {
- const auto result = tryMergeNamespace(I, E, Limit);
+((Style.BraceWrapping.Aft
@@ -660,17 +672,18 @@ class LineJoiner {
assert(Limit >= L1.Last->TotalLength + 3);
const auto InnerLimit = Limit - L1.Last->TotalLength - 3;
- const auto MergedLines = tryMergeNamespace(I + 1, E, InnerLimit);
+ const auto MergedLines =
+ tryMerg
https://github.com/yonghong-song updated
https://github.com/llvm/llvm-project/pull/125601
>From e0d1f90b24e7b7766bed17710b7072433610725c Mon Sep 17 00:00:00 2001
From: Yonghong Song
Date: Sun, 2 Feb 2025 08:33:47 -0800
Subject: [PATCH 1/2] [RFC][clang][BPF] Make trivial uninit var value to be 0
@@ -628,28 +632,36 @@ class LineJoiner {
unsigned tryMergeNamespace(ArrayRef::const_iterator I,
ArrayRef::const_iterator E,
- unsigned Limit) {
+ unsigned Limit, bool OpenBraceWrapped) {
---
Flandini wrote:
@Xazax-hun, I pushed some more test cases. I can't think of any more tricky
test cases that weren't already covered, but lmk if you see any areas with gaps.
https://github.com/llvm/llvm-project/pull/125638
___
cfe-commits mailing list
yonghong-song wrote:
I just updated a patch to change TrivialAutoVarInitMaxSize to 8 if
TrivialAutoVarInit is set to Zero by clang bpf target. This should mostly solve
the issue for xdp programs.
@eddyz87 suggested to improve middle-end compilation to issue proper warnings.
This is what I ini
https://github.com/yonghong-song updated
https://github.com/llvm/llvm-project/pull/125601
>From e0d1f90b24e7b7766bed17710b7072433610725c Mon Sep 17 00:00:00 2001
From: Yonghong Song
Date: Sun, 2 Feb 2025 08:33:47 -0800
Subject: [PATCH 1/2] [RFC][clang][BPF] Make trivial uninit var value to be 0
Flandini wrote:
> @Xazax-hun, I pushed some more test cases. I can't think of any more tricky
> test cases that weren't already covered, but lmk if you see any areas with
> gaps.
Actually, I will go through the `-Wreturn-stack-address` test cases in sema and
see what I've missed.
https://git
https://github.com/usx95 updated
https://github.com/llvm/llvm-project/pull/124133
>From 52028aeb5acc9a23c21c96d1fe9729031f61a7bc Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Fri, 7 Feb 2025 17:08:56 +
Subject: [PATCH] CFG-based lifetime analysis using existing annotations
---
.../A
https://github.com/usx95 updated
https://github.com/llvm/llvm-project/pull/124133
>From 5f9375e0a9f491952fed8edf1d383e3f6feccdc6 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Fri, 7 Feb 2025 17:08:56 +
Subject: [PATCH] CFG-based lifetime analysis using existing annotations
---
.../A
https://github.com/usx95 updated
https://github.com/llvm/llvm-project/pull/124133
>From c69aef83bfbb219ba07b578d78919a522569a59a Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Fri, 7 Feb 2025 17:08:56 +
Subject: [PATCH] CFG-based lifetime analysis using existing annotations
---
.../A
https://github.com/usx95 updated
https://github.com/llvm/llvm-project/pull/124133
>From 6600371b2948e9c0227a1ef0072a8cdf5c983005 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Fri, 7 Feb 2025 17:08:56 +
Subject: [PATCH] CFG-based lifetime analysis using existing annotations
---
.../A
4ast wrote:
> all buf[64] will be initialized to 0
looks like it's a show stopper. The performance impact of initializing
everything might be felt for XDP.
https://github.com/llvm/llvm-project/pull/125601
___
cfe-commits mailing list
cfe-commits@list
TiborGY wrote:
Is there a reason why this never got merged?
https://github.com/llvm/llvm-project/pull/76350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phoebewang wrote:
> ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️
>
> You can test this locally with the following command:
> View the diff from clang-format here.
> ```diff
> diff --git a/clang/lib/Headers/avx10_2convertintrin.h
> b/clang/lib/Headers/avx10_2convertintrin.
4ast wrote:
I agree with Eduard. I think we should abandon this patch and make
-fsanitize=undefined work.
undef can be mapped to a new bpf_fastcall kfunc no args and void return, so no
extra register pressure and call can be inserted. That kfunc can eventually
abort prog execution and print in
w2yehia wrote:
> LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross`
> running on `suse-gary-m68k-cross` while building `clang` at step 4 "build
> stage 1".
Unrelated or noise. That buildbot had the exact failure few drivers
[earlier](https://lab.llvm.org/buildbot/#/b
https://github.com/hubert-reinterpretcast commented:
@w2yehia, I suggest adding an update to the Release Notes sooner rather than
later:
https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst
https://github.com/llvm/llvm-project/pull/124353
_
yonghong-song wrote:
Okay, I will work on -fsanitize=undefined for bpf then.
https://github.com/llvm/llvm-project/pull/125601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yonghong-song closed
https://github.com/llvm/llvm-project/pull/125601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/76350
From 0a5ae9bfff7597794889c93e4da5789714be3a4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 24 Dec 2023 21:01:32 -0500
Subject: [PATCH] [clang][tidy] Fixed clang-tidy rew
https://github.com/felix642 closed
https://github.com/llvm/llvm-project/pull/76350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/126393
Rewriter would not properly fix files if they were symlinked and using --fix
with clang-tidy would overwrite the symlink with the corrections rather than
the file.
With these changes the Rewriter now properly
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-tools-extra
Author: Félix-Antoine Constantin (felix642)
Changes
Rewriter would not properly fix files if they were symlinked and using --fix
with clang-tidy would overwrite the symlink with the corrections rather than
t
felix642 wrote:
https://github.com/llvm/llvm-project/pull/126393
https://github.com/llvm/llvm-project/pull/76350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eddyz87 wrote:
I looked at the example shared by Yonghong, the change clang does because of
the uninitialized variable access is indeed quite dramatic. It computes a
switch over `undef` and throws away all branches including "default". Basically
throwing away most of the program.
Nevertheless
https://github.com/phoebewang approved this pull request.
Good catch!
https://github.com/llvm/llvm-project/pull/126390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
Probably because I did not tag this PR correctly so no one reviewed it. I'll
close it and reopen it with the proper tag.
https://github.com/llvm/llvm-project/pull/76350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/Flandini updated
https://github.com/llvm/llvm-project/pull/125638
>From 0674909f03703a70c3e259acd0590f50cea4615f Mon Sep 17 00:00:00 2001
From: Michael Flanders
Date: Mon, 27 Jan 2025 11:35:03 -0600
Subject: [PATCH 01/31] wip
---
.../Checkers/StackAddrEscapeChecker.cpp
https://github.com/yonghong-song updated
https://github.com/llvm/llvm-project/pull/125601
>From e0d1f90b24e7b7766bed17710b7072433610725c Mon Sep 17 00:00:00 2001
From: Yonghong Song
Date: Sun, 2 Feb 2025 08:33:47 -0800
Subject: [PATCH 1/2] [RFC][clang][BPF] Make trivial uninit var value to be 0
https://github.com/yonghong-song updated
https://github.com/llvm/llvm-project/pull/125601
>From e0d1f90b24e7b7766bed17710b7072433610725c Mon Sep 17 00:00:00 2001
From: Yonghong Song
Date: Sun, 2 Feb 2025 08:33:47 -0800
Subject: [PATCH 1/2] [RFC][clang][BPF] Make trivial uninit var value to be 0
101 - 170 of 170 matches
Mail list logo
