[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -0,0 +1,50 @@ +// RUN: llvm-mc -triple=aarch64 %s -o - | FileCheck %s --check-prefix=ASM +// RUN: llvm-mc -triple=aarch64 -filetype=obj %s -o - | llvm-readelf --hex-dump=.ARM.attributes - | FileCheck %s --check-prefix=ELF + +// ASM: .aeabi_subsection private_subsection_1,

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -148,13 +150,177 @@ class AArch64TargetAsmStreamer : public AArch64TargetStreamer { OS << "\t.seh_save_any_reg_px\tq" << Reg << ", " << Offset << "\n"; } + void emitAttribute(StringRef VendorName, unsigned Tag, unsigned Value, + std::string Strin

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -7806,6 +7815,261 @@ bool AArch64AsmParser::parseDirectiveSEHSaveAnyReg(SMLoc L, bool Paired, return false; } +bool AArch64AsmParser::parseDirectiveAeabiSubSectionHeader(SMLoc L) { + // Expecting 3 AsmToken::Identifier after '.aeabi_subsection', a name and 2 + // param

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -7806,6 +7815,261 @@ bool AArch64AsmParser::parseDirectiveSEHSaveAnyReg(SMLoc L, bool Paired, return false; } +bool AArch64AsmParser::parseDirectiveAeabiSubSectionHeader(SMLoc L) { + // Expecting 3 AsmToken::Identifier after '.aeabi_subsection', a name and 2 + // param

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -0,0 +1,80 @@ +// RUN: not llvm-mc -triple=aarch64 %s -o %t > %t.out 2>&1 +// RUN: FileCheck --input-file=%t.out --check-prefix=ERR %s + +.aeabi_subsection aeabi_pauthabi, optional, uleb128 +// ERR: error: aeabi_pauthabi must be marked as required +// ERR-NEXT: .aeabi_subsecti

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -0,0 +1,140 @@ +//===-- AArch64BuildAttributes.cpp - AArch64 Build Attributes -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -0,0 +1,88 @@ +//===-- AArch64BuildAttributes.h - AARch64 Build Attributes -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -0,0 +1,140 @@ +//===-- AArch64BuildAttributes.cpp - AArch64 Build Attributes -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -0,0 +1,80 @@ +// RUN: not llvm-mc -triple=aarch64 %s -o %t > %t.out 2>&1 +// RUN: FileCheck --input-file=%t.out --check-prefix=ERR %s + +.aeabi_subsection aeabi_pauthabi, optional, uleb128 +// ERR: error: aeabi_pauthabi must be marked as required +// ERR-NEXT: .aeabi_subsecti

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -0,0 +1,62 @@ +// RUN: not llvm-mc -triple=aarch64 %s -o %t > %t.out 2>&1 +// RUN: FileCheck --input-file=%t.out --check-prefix=ERR %s + +.aeabi_subsection aeabi_pauthabi, required, uleb128 +.aeabi_attribute Tag_Feature_BTI, 1 +// ERR: error: Unknown AArch64 build attribute 'T

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -7806,6 +7815,261 @@ bool AArch64AsmParser::parseDirectiveSEHSaveAnyReg(SMLoc L, bool Paired, return false; } +bool AArch64AsmParser::parseDirectiveAeabiSubSectionHeader(SMLoc L) { + // Expecting 3 AsmToken::Identifier after '.aeabi_subsection', a name and 2 + // param

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -148,13 +150,177 @@ class AArch64TargetAsmStreamer : public AArch64TargetStreamer { OS << "\t.seh_save_any_reg_px\tq" << Reg << ", " << Offset << "\n"; } + void emitAttribute(StringRef VendorName, unsigned Tag, unsigned Value, + std::string Strin

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -7806,6 +7815,261 @@ bool AArch64AsmParser::parseDirectiveSEHSaveAnyReg(SMLoc L, bool Paired, return false; } +bool AArch64AsmParser::parseDirectiveAeabiSubSectionHeader(SMLoc L) { + // Expecting 3 AsmToken::Identifier after '.aeabi_subsection', a name and 2 + // param

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -7806,6 +7815,261 @@ bool AArch64AsmParser::parseDirectiveSEHSaveAnyReg(SMLoc L, bool Paired, return false; } +bool AArch64AsmParser::parseDirectiveAeabiSubSectionHeader(SMLoc L) { + // Expecting 3 AsmToken::Identifier after '.aeabi_subsection', a name and 2 + // param

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -54,6 +54,7 @@ #include "llvm/MC/MCStreamer.h" #include "llvm/MC/MCSymbol.h" #include "llvm/MC/TargetRegistry.h" +#include "llvm/Support/ARMBuildAttributes.h" ostannard wrote: What are we using from `ARMBuildAttributes.h` in this file, and can it be moved

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -151,3 +151,97 @@ llvm::createAArch64ObjectTargetStreamer(MCStreamer &S, MCTargetStreamer *llvm::createAArch64NullTargetStreamer(MCStreamer &S) { return new AArch64TargetStreamer(S); } + +void AArch64TargetStreamer::emitAtributesSubsection( +StringRef VendorName, AArch

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread Oliver Stannard via cfe-commits
@@ -0,0 +1,140 @@ +//===-- AArch64BuildAttributes.cpp - AArch64 Build Attributes -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] Fixed some warn-override tests in SemaCXX (PR #122680)

2025-01-13 Thread via cfe-commits
https://github.com/2LoS updated https://github.com/llvm/llvm-project/pull/122680 >From 3109461716e5e78b23bea7a2eb6aac3d34348612 Mon Sep 17 00:00:00 2001 From: LoS Date: Mon, 13 Jan 2025 11:21:46 +0100 Subject: [PATCH 1/3] Fixed some warn-override tests in SemaCXX --- ...e => warn-inconsistent-

[clang] [Driver] Teach Barmetal toolchain about GCC installation(1/3) (PR #121829)

2025-01-13 Thread Garvit Gupta via cfe-commits
quic-garvgupt wrote: Gentle Ping! https://github.com/llvm/llvm-project/pull/121829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c2979c5 - [Clang] Add release note for pointer overflow optimization change (#122462)

2025-01-13 Thread via cfe-commits
Author: Nikita Popov Date: 2025-01-13T11:24:02+01:00 New Revision: c2979c58d49bf3c7dc892ed9fb49cdca389130ee URL: https://github.com/llvm/llvm-project/commit/c2979c58d49bf3c7dc892ed9fb49cdca389130ee DIFF: https://github.com/llvm/llvm-project/commit/c2979c58d49bf3c7dc892ed9fb49cdca389130ee.diff

[clang] [APINotes] Avoid duplicated attributes for class template instantiations (PR #122516)

2025-01-13 Thread Gábor Horváth via cfe-commits
@@ -19493,7 +19493,11 @@ void Sema::ActOnFields(Scope *S, SourceLocation RecLoc, Decl *EnclosingDecl, CDecl->setIvarRBraceLoc(RBrac); } } - ProcessAPINotes(Record); + + // If this is a class template instantiation, its API Notes attributes were + // added to the

[clang] [APINotes] Avoid duplicated attributes for class template instantiations (PR #122516)

2025-01-13 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun edited https://github.com/llvm/llvm-project/pull/122516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add release note for pointer overflow optimization change (PR #122462)

2025-01-13 Thread Nikita Popov via cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/122462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang] Canonicalize absolute paths in dependency file" (PR #121638)

2025-01-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11591 Here is the r

[clang] 41a94de - [clang] Refactor attr diagnostics to use %select (#122473)

2025-01-13 Thread via cfe-commits
Author: Maksim Ivanov Date: 2025-01-13T13:42:22+01:00 New Revision: 41a94de75caacb979070ec7a010dfe3c4e9f116f URL: https://github.com/llvm/llvm-project/commit/41a94de75caacb979070ec7a010dfe3c4e9f116f DIFF: https://github.com/llvm/llvm-project/commit/41a94de75caacb979070ec7a010dfe3c4e9f116f.diff

[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

2025-01-13 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov closed https://github.com/llvm/llvm-project/pull/122473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer][docs] Migrate 'annotations.html' to RST (PR #122246)

2025-01-13 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus approved this pull request. Shouldn't we leave a stub in the old HTML page that the docs were moved? Or we haven't done that in the past either? I understand (and strongly agree with) you not making any meaningful changes to the docs page you moved. With that said,

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -19,6 +19,8 @@ typedef void *omp_depend_t; void foo() {} void tmainc(){ omp_depend_t obj; + int omp_all_memory; saiislam wrote: Do we need this new variable? https://github.com/llvm/llvm-project/pull/122108

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -69,11 +80,11 @@ void c(); void func() {} // expected-note {{'func' defined here}} -#pragma omp declare target link(func) allocate(a) // expected-error {{function name is not allowed in 'link' clause}} omp45-error {{unexpected 'allocate' clause, only 'to' or 'link' claus

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -1,10 +1,10 @@ -// RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -fopenmp -emit-llvm -o - %s | FileCheck %s -// RUN: %clang_cc1 -fopenmp -triple x86_64-apple-darwin10 -x c++ -std=c++11 -emit-pch -o %t %s -// RUN: %clang_cc1 -fopenmp -triple x86_64-apple-darwin10 -std=

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam edited https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -68,15 +70,15 @@ int fun(int arg) { {} #pragma omp target map(mapper(aa :vv) // expected-error {{use of undeclared identifier 'aa'}} expected-error {{expected ')'}} expected-error {{call to undeclared function 'mapper'}} expected-note

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -4,19 +4,19 @@ // RUN: %clang_cc1 -verify -std=c++11 -fopenmp -ast-print %s -Wno-openmp-mapping -DOMP5 | FileCheck %s --check-prefix=CHECK --check-prefix=OMP50 // RUN: %clang_cc1 -fopenmp -x c++ -std=c++11 -emit-pch -o %t %s -DOMP5 // RUN: %clang_cc1 -fopenmp -std=c++11 -i

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -25,16 +36,16 @@ __thread int t; // expected-note {{defined as threadprivate or thread local}} void f(); #pragma omp end declare target shared(a) // expected-warning {{extra tokens at the end of '#pragma omp end declare target' are ignored}} -#pragma omp declare target ma

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -63,22 +63,22 @@ class VV { // CHECK-NEXT: int add(int a, int b) __attribute__((cold)){ // CHECK-NEXT: return a + b; // CHECK-NEXT: } - #pragma omp declare simd uniform(this, a) linear(val(b): a) + #pragma omp declare simd uniform(this, a) linear(b: a) --

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam edited https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer][docs] Restore/remove orphaned images (PR #122481)

2025-01-13 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/122481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang][DebugInfo] Expand detection of structured bindings to account for std::get free function (PR #122265)

2025-01-13 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/5] [clang][DebugInfo] Expand detection of structured bindings

[clang] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

2025-01-13 Thread Louis Dionne via cfe-commits
ldionne wrote: > > @erichkeane @ldionne should the `libcxx` tests > > ([common_reference.compile.pass.cpp](https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_reference.compile.pass.cpp), > > > > [apply_extended_types.pass.cpp](https

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-13 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: 1 nit, else LGTM once @cor3ntin is happy. https://github.com/llvm/llvm-project/pull/122621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-13 Thread Erich Keane via cfe-commits
@@ -2223,6 +2225,8 @@ def err_destructor_not_member : Error< def err_destructor_cannot_be : Error<"destructor cannot be declared '%0'">; def err_invalid_qualified_destructor : Error< "'%0' qualifier is not allowed on a destructor">; +def err_invalid_destructor_decl : Error< -

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-13 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/122621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5e7d7fb - [AArch64] Fix aarch64-fujitsu-monaka.c test (#122716)

2025-01-13 Thread via cfe-commits
Author: Lukacma Date: 2025-01-13T15:05:47Z New Revision: 5e7d7fb1f0cefbb6f00bcd71867014ce8b71a11e URL: https://github.com/llvm/llvm-project/commit/5e7d7fb1f0cefbb6f00bcd71867014ce8b71a11e DIFF: https://github.com/llvm/llvm-project/commit/5e7d7fb1f0cefbb6f00bcd71867014ce8b71a11e.diff LOG: [AArc

[clang] [AArch64] Fix aarch64-fujitsu-monaka.c test (PR #122716)

2025-01-13 Thread via cfe-commits
https://github.com/Lukacma closed https://github.com/llvm/llvm-project/pull/122716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Multilib] Custom flags YAML parsing" (PR #122722)

2025-01-13 Thread Victor Campos via cfe-commits
https://github.com/vhscampos created https://github.com/llvm/llvm-project/pull/122722 Reverts llvm/llvm-project#110657 It seems that this patch is causing the sanitizer bot to fail. Reverting while I investigate >From ad6c95a7c6e5e8d376225b42a3a71d5663aa7942 Mon Sep 17 00:00:00 2001 From: Vic

[clang] Revert "[Multilib] Custom flags YAML parsing" (PR #122722)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Victor Campos (vhscampos) Changes Reverts llvm/llvm-project#110657 It seems that this patch is causing the sanitizer bot to fail. Reverting while I investigate --- Full diff: https://github.com/llvm/llvm-project/pull/122722.diff

[clang] 7378afd - Revert "[Multilib] Custom flags YAML parsing" (#122722)

2025-01-13 Thread via cfe-commits
Author: Victor Campos Date: 2025-01-13T15:11:40Z New Revision: 7378afd167860083eaaf0d8e411c91a28a6605d6 URL: https://github.com/llvm/llvm-project/commit/7378afd167860083eaaf0d8e411c91a28a6605d6 DIFF: https://github.com/llvm/llvm-project/commit/7378afd167860083eaaf0d8e411c91a28a6605d6.diff LOG:

[clang] Revert "[Multilib] Custom flags YAML parsing" (PR #122722)

2025-01-13 Thread Victor Campos via cfe-commits
https://github.com/vhscampos closed https://github.com/llvm/llvm-project/pull/122722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-13 Thread Erich Keane via cfe-commits
erichkeane wrote: > Oh, I see, you're suggesting we remove the `getStdNamespace` check from this > PR. Yeah, I think that's reasonable. Yep, that is my suggestion, sorry I was insufficiently clear. > But I'd somewhat question whether this PR and warning really has anything to > do with the at

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-13 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/acbd822879f7727127926c25e1b47f5017f962c5 https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-13 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Should this be backported to older supported releases as well? (FWIW, I think > so.) But I am not sure if there is still release there. https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@list

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-13 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#122844 https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-13 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 milestoned https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-13 Thread Richard Smith via cfe-commits
zygoloid wrote: Oh, I see, you're suggesting we remove the `getStdNamespace` check from this PR. Yeah, I think that's reasonable. But I'd somewhat question whether this PR and warning really has anything to do with the attribute names being "reserved" at that point -- we're not checking wheth

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic (PR #118580)

2025-01-13 Thread Steven Perron via cfe-commits
https://github.com/s-perron approved this pull request. https://github.com/llvm/llvm-project/pull/118580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2025-01-13 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: This change isn't needed anymore as it was decided that `noexcept` shouldn't be used to compute discriminators of function and member function pointers (see https://github.com/llvm/llvm-project/issues/106487#issuecomment-2440364300). https://github.com/llvm/llvm-project/pull/10

[clang] [clang-tools-extra] [NFC] Add implicit cast kinds for function pointer conversions (PR #110048)

2025-01-13 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: This change isn't needed anymore as it was decided that noexcept shouldn't be used to compute discriminators of function and member function pointers (see https://github.com/llvm/llvm-project/issues/106487#issuecomment-2440364300). https://github.com/llvm/llvm-project/pull/1100

[clang] [Sema] Note member decl when initializer list default constructs member (PR #121854)

2025-01-13 Thread Brian Foley via cfe-commits
https://github.com/bpfoley updated https://github.com/llvm/llvm-project/pull/121854 >From 10acf5fd8346d872e5f3110c03cea944f9062375 Mon Sep 17 00:00:00 2001 From: Brian Foley Date: Thu, 5 Dec 2024 14:35:25 -0800 Subject: [PATCH] [Sema] Note member decl when initializer list default constructs m

[clang] [Sema] Note member decl when initializer list default constructs member (PR #121854)

2025-01-13 Thread Brian Foley via cfe-commits
https://github.com/bpfoley updated https://github.com/llvm/llvm-project/pull/121854 >From 72ffbe4ef6b4f8fe6fa31fef7fd3f5c961495c9f Mon Sep 17 00:00:00 2001 From: Brian Foley Date: Thu, 5 Dec 2024 14:35:25 -0800 Subject: [PATCH] [Sema] Note member decl when initializer list default constructs m

[clang] [llvm] [sanitizer][NFCI] Add Options parameter to LowerAllowCheckPass (PR #122765)

2025-01-13 Thread Thurston Dang via cfe-commits
@@ -20,13 +20,22 @@ namespace llvm { +struct LowerAllowCheckOptions { + std::vector placeholder; // TODO: cutoffs thurstond wrote: Done https://github.com/llvm/llvm-project/pull/122765 ___ cfe-commits mailing lis

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-13 Thread Ben Boeckel via cfe-commits
mathstuf wrote: Should this be backported to older supported releases as well? (FWIW, I think so.) https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [llvm] [sanitizer][NFCI] Add Options parameter to LowerAllowCheckPass (PR #122765)

2025-01-13 Thread Thurston Dang via cfe-commits
https://github.com/thurstond updated https://github.com/llvm/llvm-project/pull/122765 >From 6c244a083b458637f35149547270ba25675ca417 Mon Sep 17 00:00:00 2001 From: Thurston Dang Date: Mon, 13 Jan 2025 18:38:14 + Subject: [PATCH 1/3] [sanitizer][NFCI] Add Options to LowerAllowCheckPass This

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-01-13 Thread Scott Constable via cfe-commits
scottconstable wrote: > > maurer: I think their point is that even if you are not changing the hash > > scheme, you are proposing breaking compatibility of the identifier with > > existing code. Since we don't want to do this many times, if we are > > breaking compatibility with existing code,

[clang] [llvm] [sanitizer][NFCI] Add Options parameter to LowerAllowCheckPass (PR #122765)

2025-01-13 Thread Thurston Dang via cfe-commits
@@ -20,13 +20,22 @@ namespace llvm { +struct LowerAllowCheckOptions { thurstond wrote: Done https://github.com/llvm/llvm-project/pull/122765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [clang] Do not allow unorderable features in [[gnu::target{,_clones}]] (PR #98426)

2025-01-13 Thread Dan Klishch via cfe-commits
https://github.com/DanShaders updated https://github.com/llvm/llvm-project/pull/98426 >From 723205411efe18dbe8bb154839525b59963b1638 Mon Sep 17 00:00:00 2001 From: Dan Klishch Date: Wed, 10 Jul 2024 23:39:42 -0400 Subject: [PATCH 1/2] [clang] Do not allow unorderable features in [[gnu::target{

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-13 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/122621 >From b2c656afdf99eff52d019b68fcbbc6ce4bbdd7d3 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 12 Jan 2025 00:51:47 +0200 Subject: [PATCH 1/8] [Clang] disallow the use of asterisks preceding constructo

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-13 Thread Farzon Lotfi via cfe-commits
@@ -1,33 +1,44 @@ -; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s farzonl wrote: changed line endings from crlf to lf. https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2025-01-13 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/109056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2025-01-13 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM, please update release note https://github.com/llvm/llvm-project/pull/120055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [clang-tools-extra] [NFC] Add implicit cast kinds for function pointer conversions (PR #110048)

2025-01-13 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/110048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2025-01-13 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: I meant to close https://github.com/llvm/llvm-project/pull/110048. https://github.com/llvm/llvm-project/pull/109056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2025-01-13 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak reopened https://github.com/llvm/llvm-project/pull/109056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/118568 >From b43a2602025bdacea06ced5171904fb5d765de9f Mon Sep 17 00:00:00 2001 From: chomosuke Date: Tue, 3 Dec 2024 07:10:33 + Subject: [PATCH 1/3] fixed removeFunctionArgs don't remove comma --- .../clang-tid

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Richard Li via cfe-commits
https://github.com/chomosuke edited https://github.com/llvm/llvm-project/pull/118568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/limits.h: Avoid including limits.h twice (PR #120526)

2025-01-13 Thread YunQiang Su via cfe-commits
wzssyqa wrote: You are right. My patch only fix the first problem: making a unit test of glibc happy. The failure test case of glibc is: * check-local-headers See: https://github.com/llvm/llvm-project/pull/120673 also. https://github.com/llvm/llvm-project/pull/120526 __

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2025-01-13 Thread Owen Pan via cfe-commits
@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122653)

2025-01-13 Thread Nikita Popov via cfe-commits
nikic wrote: > Literal migration would result in dyn_cast_if_present (see the definition of > PointerUnion::dyn_cast), but this patch uses dyn_cast because we expect > Prototype.P to be nonnull. This comment doesn't seem to match the PR :) https://github.com/llvm/llvm-project/pull/122653

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122651)

2025-01-13 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/122651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analysis] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122652)

2025-01-13 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/122652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b270525 - [clang][ASTImporter] Not using primary context in lookup table (#118466)

2025-01-13 Thread via cfe-commits
Author: Balázs Kéri Date: 2025-01-13T09:46:45+01:00 New Revision: b270525f730be6e7196667925f5a9bfa153262e9 URL: https://github.com/llvm/llvm-project/commit/b270525f730be6e7196667925f5a9bfa153262e9 DIFF: https://github.com/llvm/llvm-project/commit/b270525f730be6e7196667925f5a9bfa153262e9.diff L

[clang] [clang][ASTImporter] Not using primary context in lookup table (PR #118466)

2025-01-13 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/118466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2025-01-13 Thread Owen Pan via cfe-commits
owenca wrote: Why doesn't it break before the `>` for the example (a.cc) below? ```cpp template class C { void f() {} }; ``` Command line: ``` clang-format -style='{BreakBeforeTemplateCloser: Multiline, ColumnLimit: 26}' a.cc ``` https://github.com/llvm/llvm-project/pull/118046 _

[clang] [clang-tools-extra] Remove `StringLiteral` in favor of `StringRef` (PR #122366)

2025-01-13 Thread James Henderson via cfe-commits
jh7370 wrote: > > > Do we care about performance on MSVC ? > > > > > > Just responding to this point (although I accept it's moot in the current > > context): yes we care about performance when building with MSVC - our > > downstream toolchain is hosted on Windows. I'm sure we're not the only

[clang] [llvm] [RISCV] Add Qualcomm uC Xqciint (Interrupts) extension (PR #122256)

2025-01-13 Thread via cfe-commits
https://github.com/hchandel updated https://github.com/llvm/llvm-project/pull/122256 >From 0ab75584047081661a858e96f5525e557ada69e6 Mon Sep 17 00:00:00 2001 From: Harsh Chandel Date: Wed, 8 Jan 2025 18:08:48 +0530 Subject: [PATCH 1/5] [RISCV] Add Qualcomm uC Xqciint (Interrupts) extension This

[clang] [clang][ASTImporter] Not using primary context in lookup table (PR #118466)

2025-01-13 Thread LLVM Continuous Integration via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org

[clang] [clang-format] Fix greatergreater (PR #122282)

2025-01-13 Thread via cfe-commits
https://github.com/andergnet updated https://github.com/llvm/llvm-project/pull/122282 >From e2780f01d47518bb61a5c01c9ad4d9daddb5044a Mon Sep 17 00:00:00 2001 From: W123011 Date: Thu, 9 Jan 2025 15:04:26 +0100 Subject: [PATCH 1/4] Fix >> behavior on continuation intenter --- clang/lib/Format/C

[clang] Fixed some warn-override tests in SemaCXX (PR #122680)

2025-01-13 Thread via cfe-commits
https://github.com/2LoS updated https://github.com/llvm/llvm-project/pull/122680 >From 3109461716e5e78b23bea7a2eb6aac3d34348612 Mon Sep 17 00:00:00 2001 From: LoS Date: Mon, 13 Jan 2025 11:21:46 +0100 Subject: [PATCH 1/2] Fixed some warn-override tests in SemaCXX --- ...e => warn-inconsistent-

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-13 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > A special handling for `PreferredName` looks slightly add-hoc to me. What I > thought is to delay the deserialization of `attributes` after the > deserialization of the declaration. If this is too optimistic, I am wondering > if we can delay reading of some sorts of attr

[clang] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

2025-01-13 Thread Erich Keane via cfe-commits
erichkeane wrote: > @erichkeane @ldionne should the `libcxx` tests > ([common_reference.compile.pass.cpp](https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_reference.compile.pass.cpp), > > [apply_extended_types.pass.cpp](https://gi

[clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support AMDGPU's generic target (PR #122629)

2025-01-13 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/122629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Fix aarch64-fujitsu-monaka.c test (PR #122716)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: None (Lukacma) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122716.diff 8 Files Affected: - (modified) clang/test/CodeGen/AArch64/fp8-intrinsics/acle_sve2_fp8_fdot.c (+6-6) - (mod

[clang] [llvm] [AArch64] Fix aarch64-fujitsu-monaka.c test (PR #122716)

2025-01-13 Thread via cfe-commits
https://github.com/Lukacma created https://github.com/llvm/llvm-project/pull/122716 None >From e3bc40234f8bd4c70d8822aadc6f42b6f738afba Mon Sep 17 00:00:00 2001 From: Marian Lukac Date: Thu, 9 Jan 2025 14:40:45 + Subject: [PATCH 1/2] [AArch64] Change feature dependencies of fp8 features -

[clang] [llvm] [AArch64] Fix aarch64-fujitsu-monaka.c test (PR #122716)

2025-01-13 Thread via cfe-commits
https://github.com/Lukacma updated https://github.com/llvm/llvm-project/pull/122716 >From e3bc40234f8bd4c70d8822aadc6f42b6f738afba Mon Sep 17 00:00:00 2001 From: Marian Lukac Date: Thu, 9 Jan 2025 14:40:45 + Subject: [PATCH 1/2] [AArch64] Change feature dependencies of fp8 features --- ..

[clang] [llvm] [AArch64] Fix aarch64-fujitsu-monaka.c test (PR #122716)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: None (Lukacma) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122716.diff 8 Files Affected: - (modified) clang/test/CodeGen/AArch64/fp8-intrinsics/acle_sve2_fp8_fdot.c (+6-6) - (modified) clang/test/CodeGe

[clang] [AArch64] Fix aarch64-fujitsu-monaka.c test (PR #122716)

2025-01-13 Thread via cfe-commits
https://github.com/Lukacma updated https://github.com/llvm/llvm-project/pull/122716 >From d1e1953d45be8fcc2d3665821a8ad43011d01c9d Mon Sep 17 00:00:00 2001 From: Marian Lukac Date: Mon, 13 Jan 2025 14:43:15 + Subject: [PATCH] [AArch64] Fix aarch64-fujitsu-monaka.c test --- .../Driver/prin

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-01-13 Thread Erich Keane via cfe-commits
@@ -179,6 +179,8 @@ def err_opencl_unknown_type_specifier : Error< def warn_unknown_attribute_ignored : Warning< "unknown attribute %0 ignored">, InGroup; +def ext_unknown_attribute_ignored : Extension< + "unknown attribute %0 ignored">, InGroup; erichkeane

[clang] [BoundsSafety][Sema] Allow counted_by and counted_by_or_null on pointers where the pointee type is incomplete but potentially completable (PR #106321)

2025-01-13 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/106321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-01-13 Thread Hans Wennborg via cfe-commits
zmodem wrote: Confirmed Chromium on Windows builds with this patch. https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

2025-01-13 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/114240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

2025-01-13 Thread via cfe-commits
@@ -2551,18 +2551,7 @@ void Sema::MergeTypedefNameDecl(Scope *S, TypedefNameDecl *New, // Make the old tag definition visible. makeMergedDefinitionVisible(Hidden); - // If this was an unscoped enumeration, yank all of its enumerators - // out of the scop

  1   2   3   4   5   >