[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2025-01-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/119974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] a536444 - [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (#119974)

2025-01-12 Thread via cfe-commits
Author: Barnabás Pőcze Date: 2025-01-12T10:07:52+01:00 New Revision: a536bd0dbbd60e83ee6cf11adabd72f4df54 URL: https://github.com/llvm/llvm-project/commit/a536bd0dbbd60e83ee6cf11adabd72f4df54 DIFF: https://github.com/llvm/llvm-project/commit/a536bd0dbbd60e83ee6cf11adabd72f4df54.diff

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2025-01-12 Thread via cfe-commits
github-actions[bot] wrote: @pobrn Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, y

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2025-01-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/119974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2025-01-12 Thread Owen Pan via cfe-commits
@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-12 Thread via cfe-commits
github-actions[bot] wrote: @Sharjeel-Khan Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[clang] fdfe7e7 - [Driver] Error when using msan on Android (#122540)

2025-01-12 Thread via cfe-commits
Author: Sharjeel Khan Date: 2025-01-12T17:36:00+08:00 New Revision: fdfe7e7fabc85ed7293ca6f5f234d41812644584 URL: https://github.com/llvm/llvm-project/commit/fdfe7e7fabc85ed7293ca6f5f234d41812644584 DIFF: https://github.com/llvm/llvm-project/commit/fdfe7e7fabc85ed7293ca6f5f234d41812644584.diff

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-12 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab approved this pull request. https://github.com/llvm/llvm-project/pull/122540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-12 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab closed https://github.com/llvm/llvm-project/pull/122540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix uefi target for aarch64 & x86_64 (PR #120632)

2025-01-12 Thread Roland McGrath via cfe-commits
@@ -713,8 +713,8 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public X86TargetInfo { X86_64TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts) : X86TargetInfo(Triple, Opts) { const bool IsX32 = getTriple().isX32(); -bool IsWinCOFF = -

[clang] [Clang][Sema] Do not perform type conversion before computing result type of `x ? : y` in C++ (PR #108837)

2025-01-12 Thread Yanzuo Liu via cfe-commits
@@ -0,0 +1,19 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s zwuis wrote: > I think this test should go in `clang/test/Sema/conditional-expr.c` and we > should add a section of the GNU extension there. > > I am also a bit concerned that we don't hav

[clang-tools-extra] 8ebc35f - [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (#102299)

2025-01-12 Thread via cfe-commits
Author: MichelleCDjunaidi Date: 2025-01-12T11:04:40+01:00 New Revision: 8ebc35f8d041f097a2b973b455dc3533420af6bf URL: https://github.com/llvm/llvm-project/commit/8ebc35f8d041f097a2b973b455dc3533420af6bf DIFF: https://github.com/llvm/llvm-project/commit/8ebc35f8d041f097a2b973b455dc3533420af6bf.d

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2025-01-12 Thread via cfe-commits
github-actions[bot] wrote: @MichelleCDjunaidi Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem wit

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2025-01-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/102299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Do not perform type conversion before calculating result type of `x ? : y` in C++ (PR #108837)

2025-01-12 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/108837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Do not perform type conversion before computing result type of `x ? : y` in C++ (PR #108837)

2025-01-12 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/108837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls` running on `linaro-g3-03` while building `clang` at step 6 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/4702 Here is the relevant piece of the bui

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2025-01-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls-2stage` running on `linaro-g3-02` while building `clang-tools-extra` at step 11 "build stage 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/4/builds/4559 Here is the releva

[clang] [Clang][Sema] Do not perform type conversion before computing result type of `x ? : y` in C++ (PR #108837)

2025-01-12 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/108837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Do not perform type conversion before computing result type of `x ? : y` in C++ (PR #108837)

2025-01-12 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis updated https://github.com/llvm/llvm-project/pull/108837 >From 7e5f88c322852939ae68c65f6adf4a5d2973d095 Mon Sep 17 00:00:00 2001 From: Yanzuo Liu Date: Mon, 16 Sep 2024 21:50:11 +0800 Subject: [PATCH 1/3] Fix computing result type of conditional operand --- clang/docs

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

2025-01-12 Thread via cfe-commits
@@ -774,7 +774,15 @@ std::string PredefinedExpr::ComputeName(PredefinedIdentKind IK, const FunctionDecl *Decl = FD; if (const FunctionDecl* Pattern = FD->getTemplateInstantiationPattern()) Decl = Pattern; -const FunctionType *AFT = Decl->getType()->getAs(); +

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

2025-01-12 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/122611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

2025-01-12 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM (but i reworded the comment slightly) https://github.com/llvm/llvm-project/pull/122611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread via cfe-commits
@@ -10757,6 +10757,17 @@ static void checkMethodTypeQualifiers(Sema &S, Declarator &D, unsigned DiagID) { } } +static void checkMethodPointerType(Sema &S, Declarator &D, unsigned DiagID) { + if (D.getNumTypeObjects() > 0) { +DeclaratorChunk &Chunk = D.getTypeObject(D.g

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-12 Thread via cfe-commits
dodicidodici wrote: > This check sounds a bit strange. Is this issue common in real-world projects, > do we have some data? It's the first time I've heard of it. Why would people > deviate from the standard signature for move constructors? It's anecdotal, but I've encountered it in a few place

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2025-01-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-arm64-windows-msvc` running on `linaro-armv8-windows-msvc-04` while building `clang-tools-extra` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/4099 Here

[clang] [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler target (PR #122627)

2025-01-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/122627 >From 71bad77117ef0dedbe6c28ff578470d8266108a6 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Sat, 11 Jan 2025 21:24:53 -0500 Subject: [PATCH] [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler

[clang] [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler target (PR #122627)

2025-01-12 Thread Shilei Tian via cfe-commits
shiltian wrote: ### Merge activity * **Jan 12, 10:49 AM EST**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/122627). https://github.com/llvm/llvm-project/pull/122627 __

[clang] 0d352b2 - [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler target (#122627)

2025-01-12 Thread via cfe-commits
Author: Shilei Tian Date: 2025-01-12T10:51:12-05:00 New Revision: 0d352b2ea767e043b47d78bfdbd6820356628314 URL: https://github.com/llvm/llvm-project/commit/0d352b2ea767e043b47d78bfdbd6820356628314 DIFF: https://github.com/llvm/llvm-project/commit/0d352b2ea767e043b47d78bfdbd6820356628314.diff L

[clang] [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler target (PR #122627)

2025-01-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian closed https://github.com/llvm/llvm-project/pull/122627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support generic target (PR #122629)

2025-01-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/122629 >From b1dbe4f558fe282968af1ac33d58d74d3238d8d5 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Sun, 12 Jan 2025 10:48:56 -0500 Subject: [PATCH] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to suppo

[clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support generic target (PR #122629)

2025-01-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/122629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support generic target (PR #122629)

2025-01-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/122629 >From c58bbd1edcc295a03d68a311a16080550c6aea96 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Sun, 12 Jan 2025 10:48:56 -0500 Subject: [PATCH] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to suppo

[clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support generic target (PR #122629)

2025-01-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/122629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support AMDGPU's generic target (PR #122629)

2025-01-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/122629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Do not perform type conversion before computing result type of `x ? : y` in C++ (PR #108837)

2025-01-12 Thread Yanzuo Liu via cfe-commits
@@ -0,0 +1,19 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s -fexperimental-new-constant-interpreter zwuis wrote: > Should run with BOTH constexpr interpreters. Sorry I don't understand the mea

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

2025-01-12 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/122611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d080f78 - [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (#122611)

2025-01-12 Thread via cfe-commits
Author: TilakChad Date: 2025-01-12T15:42:04+01:00 New Revision: d080f78772acf9de4961b89062c02fdd5f82186a URL: https://github.com/llvm/llvm-project/commit/d080f78772acf9de4961b89062c02fdd5f82186a DIFF: https://github.com/llvm/llvm-project/commit/d080f78772acf9de4961b89062c02fdd5f82186a.diff LOG

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

2025-01-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/5591 Here is the releva

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

2025-01-12 Thread via cfe-commits
TilakChad wrote: > LGTM. > Do you need me to merge that for you? Thanks. https://github.com/llvm/llvm-project/pull/122611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-12 Thread via cfe-commits
@@ -0,0 +1,33 @@ +//===--- ExplicitMoveConstructorCheck.h - clang-tidy *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-12 Thread via cfe-commits
@@ -0,0 +1,73 @@ +//===--- ExplicitMoveConstructorCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-12 Thread via cfe-commits
@@ -0,0 +1,33 @@ +.. title:: clang-tidy - performance-explicit-move-constructor + +performance-explicit-move-constructor += + +Checks for classes that define an explicit move constructor and a copy EugeneZelenko wrote: Please s

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/122621 >From b2c656afdf99eff52d019b68fcbbc6ce4bbdd7d3 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 12 Jan 2025 00:51:47 +0200 Subject: [PATCH 1/2] [Clang] disallow the use of asterisks preceding constructo

[clang] [Clang][Sema] Do not perform type conversion before computing result type of `x ? : y` in C++ (PR #108837)

2025-01-12 Thread Yanzuo Liu via cfe-commits
@@ -8785,14 +8785,11 @@ ExprResult Sema::ActOnConditionalOp(SourceLocation QuestionLoc, commonExpr = result.get(); } // We usually want to apply unary conversions *before* saving, except -// in the special case of a C++ l-value conditional. -if (!(getLang

[clang] [Clang][Sema] Do not perform type conversion before computing result type of `x ? : y` in C++ (PR #108837)

2025-01-12 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/108837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Do not perform type conversion before computing result type of `x ? : y` in C++ (PR #108837)

2025-01-12 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis updated https://github.com/llvm/llvm-project/pull/108837 >From 7e5f88c322852939ae68c65f6adf4a5d2973d095 Mon Sep 17 00:00:00 2001 From: Yanzuo Liu Date: Mon, 16 Sep 2024 21:50:11 +0800 Subject: [PATCH 1/3] Fix computing result type of conditional operand --- clang/docs

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

2025-01-12 Thread via cfe-commits
https://github.com/TilakChad updated https://github.com/llvm/llvm-project/pull/122611 >From 4e5935f6631f0f0cd828559ec29ed931bc0333d3 Mon Sep 17 00:00:00 2001 From: Tilak Chad Date: Sun, 12 Jan 2025 00:03:32 +0545 Subject: [PATCH 1/2] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG_

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-12 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: I prefer to make it in bugprone and warn for all kinds of incorrect signatures for these special functions. what do you think.@5chmidti @carlosgalvezp @PiotrZSL https://github.com/llvm/llvm-project/pull/122599 ___ cfe-commits mail

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread Oleksandr T. via cfe-commits
@@ -10757,6 +10757,17 @@ static void checkMethodTypeQualifiers(Sema &S, Declarator &D, unsigned DiagID) { } } +static void checkMethodPointerType(Sema &S, Declarator &D, unsigned DiagID) { + if (D.getNumTypeObjects() > 0) { +DeclaratorChunk &Chunk = D.getTypeObject(D.g

[clang] [Clang][Sema] Do not perform type conversion before computing result type of `x ? : y` in C++ (PR #108837)

2025-01-12 Thread Yanzuo Liu via cfe-commits
zwuis wrote: > I'm also concerned about the constexpr support being 'FIXME', it seems that > this should just 'work' unless something odd is happening. Sorry I forgot the restriction of constexpr function in C++11. Fixed. https://github.com/llvm/llvm-project/pull/108837 ___

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread via cfe-commits
@@ -10757,6 +10757,17 @@ static void checkMethodTypeQualifiers(Sema &S, Declarator &D, unsigned DiagID) { } } +static void checkMethodPointerType(Sema &S, Declarator &D, unsigned DiagID) { + if (D.getNumTypeObjects() > 0) { +DeclaratorChunk &Chunk = D.getTypeObject(D.g

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

2025-01-12 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM. Do you need me to merge that for you? https://github.com/llvm/llvm-project/pull/122611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread Oleksandr T. via cfe-commits
@@ -10757,6 +10757,17 @@ static void checkMethodTypeQualifiers(Sema &S, Declarator &D, unsigned DiagID) { } } +static void checkMethodPointerType(Sema &S, Declarator &D, unsigned DiagID) { + if (D.getNumTypeObjects() > 0) { +DeclaratorChunk &Chunk = D.getTypeObject(D.g

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

2025-01-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vla-2stage` running on `linaro-g3-01` while building `clang` at step 11 "build stage 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/41/builds/4476 Here is the relevant piece of

[clang] [llvm] [AArch64] Change feature dependencies of fp8 features (PR #122280)

2025-01-12 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. https://github.com/llvm/llvm-project/pull/122280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][LLVM][AArch64]Add new feature SSVE-BitPerm (PR #121947)

2025-01-12 Thread via cfe-commits
@@ -86,10 +87,11 @@ // CHECK-NEXT: sve-aes2FEAT_SVE_AES2 Enable Armv9.6-A SVE multi-vector AES and multi-vector quadword polynomial multiply instructions // CHECK-NEXT: sve-b16b16 FEAT_SVE_B16B16

[clang] [llvm] [Clang][LLVM][AArch64]Add new feature SSVE-BitPerm (PR #121947)

2025-01-12 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/121947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] codegen support for masked combined construct masked taskloop simd (PR #121916)

2025-01-12 Thread CHANDRA GHALE via cfe-commits
https://github.com/chandraghale updated https://github.com/llvm/llvm-project/pull/121916 >From 7d03bd61553690f22c03b52ef2bda8a09938e7a1 Mon Sep 17 00:00:00 2001 From: Chandra Ghale Date: Tue, 7 Jan 2025 05:09:21 -0600 Subject: [PATCH] codegen support for masked combined construct masked taskloo

[clang] 1d2eea9 - [OpenMP] codegen support for masked combined construct masked taskloop simd (#121916)

2025-01-12 Thread via cfe-commits
Author: CHANDRA GHALE Date: 2025-01-12T23:38:00+05:30 New Revision: 1d2eea962ac9724350f025f4c70808d42a435289 URL: https://github.com/llvm/llvm-project/commit/1d2eea962ac9724350f025f4c70808d42a435289 DIFF: https://github.com/llvm/llvm-project/commit/1d2eea962ac9724350f025f4c70808d42a435289.diff

[clang] [OpenMP] codegen support for masked combined construct masked taskloop simd (PR #121916)

2025-01-12 Thread CHANDRA GHALE via cfe-commits
https://github.com/chandraghale closed https://github.com/llvm/llvm-project/pull/121916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][LLVM][AArch64]Add new feature SSVE-BitPerm (PR #121947)

2025-01-12 Thread via cfe-commits
CarolineConcatto wrote: > On top of comments I left I think we should also add new runlines to both > assembly tests for individual instructions, to check that we produce correct > assembly when ssve-bitperm feature is used. https://github.com/llvm/llvm-project/pull/121947 __

[clang] [OpenMP] codegen support for masked combined construct masked taskloop simd (PR #121916)

2025-01-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/10325 Here is th

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls-2stage` running on `linaro-g3-02` while building `clang` at step 11 "build stage 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/4/builds/4570 Here is the relevant piece of

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122651)

2025-01-12 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/122651 Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Literal migration

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for the fix. Please add a more detailed summary, the title feels sufficient to describe the problem but you should outline the solution in the summary, at least briefly. e.g. adding `checkMethodPointerType` which will called during to verify

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread Shafik Yaghmour via cfe-commits
@@ -96,3 +96,13 @@ namespace PR38286 { template struct C; // expected-note {{non-type declaration found}} template C::~C() {} // expected-error {{identifier 'C' after '~' in destructor name does not name a type}} } + +namespace GH121706 { +struct S { + *S(); // expected-

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/122621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-12 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: A special handling for `PreferredName` looks slightly add-hoc to me. What I thought is to delay the deserialization of `attributes` after the deserialization of the declaration. If this is too optimistic, I am wondering if we can delay reading of some s

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-12 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,34 @@ +// RUN: %check_clang_tidy %s performance-explicit-move-constructor %t + +class NotReported1 {}; + +class NotReported2 { +public: + NotReported2(NotReported2&&) = default; + NotReported2(const NotReported2&) = default; +}; + +class NotReported3 { +public: + exp

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-12 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,73 @@ +//===--- ExplicitMoveConstructorCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/122599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL commented: To be honest, best would be flag calls to copy constructors that take rvalue where move constructor exists. In such case it would found actual performance issues. But still this kind of check is fine. https://github.com/llvm/llvm-project/pull/122599

[clang] [Clang][MIPS] Create correct linker arguments for Windows toolchains (PR #121041)

2025-01-12 Thread Hervé Poussineau via cfe-commits
hpoussin wrote: Ping https://github.com/llvm/llvm-project/pull/121041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-12 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] acbd822 - Fix print module manifest file for macos (#122370)

2025-01-12 Thread via cfe-commits
Author: Bill Hoffman Date: 2025-01-13T10:20:20+08:00 New Revision: acbd822879f7727127926c25e1b47f5017f962c5 URL: https://github.com/llvm/llvm-project/commit/acbd822879f7727127926c25e1b47f5017f962c5 DIFF: https://github.com/llvm/llvm-project/commit/acbd822879f7727127926c25e1b47f5017f962c5.diff

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-12 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-12 Thread via cfe-commits
github-actions[bot] wrote: @billhoffman Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-01-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-12 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: Do we need to update `buildModuleFile` in `clang-tools-extra/clangd/ModulesBuilder.cpp` to update the commands to build the module interfaces? https://github.com/llvm/llvm-project/pull/122606 ___ cfe-commits m

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-12 Thread Chuanqi Xu via cfe-commits
@@ -9,6 +9,7 @@ /// FIXME: Skip testing on windows temporarily due to the different escaping /// code mode. +#include "llvm/ADT/StringRef.h" ChuanqiXu9 wrote: Move the include after the `#ifndef` https://github.com/llvm/llvm-project/pull/122606 _

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-12 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/122606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][Clang] Add support for __arm_agnostic("sme_za_state") (PR #121788)

2025-01-12 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm updated https://github.com/llvm/llvm-project/pull/121788 >From 4e2166f1c19246e3fb5074da466d151070b5606c Mon Sep 17 00:00:00 2001 From: Sander de Smalen Date: Mon, 9 Sep 2024 15:20:26 +0100 Subject: [PATCH 1/4] [AArch64][Clang] Add support for __arm_agnostic("sm

[clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support AMDGPU's generic target (PR #122629)

2025-01-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/122629 >From 2fdbbac7ca1dcb5b6a0ad28f9fedabf24c634465 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Sun, 12 Jan 2025 15:58:32 -0500 Subject: [PATCH] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to suppo

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/10935 Here is the relevant

[clang] 6f558e0 - [OpenMP] codegen support for masked combined construct masked taskloop (#121914)

2025-01-12 Thread via cfe-commits
Author: CHANDRA GHALE Date: 2025-01-13T11:42:13+05:30 New Revision: 6f558e0e124012fd00927d6d42545649bd7e0dcd URL: https://github.com/llvm/llvm-project/commit/6f558e0e124012fd00927d6d42545649bd7e0dcd DIFF: https://github.com/llvm/llvm-project/commit/6f558e0e124012fd00927d6d42545649bd7e0dcd.diff

[clang] [OpenMP] codegen support for masked combined construct masked taskloop (PR #121914)

2025-01-12 Thread CHANDRA GHALE via cfe-commits
https://github.com/chandraghale closed https://github.com/llvm/llvm-project/pull/121914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-12 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: > > This check sounds a bit strange. Is this issue common in real-world > > projects, do we have some data? It's the first time I've heard of it. Why > > would people deviate from the standard signature for move constructors? > > It's anecdotal, but I've encountered it in a

[clang] [OpenMP] codegen support for masked combined construct masked taskloop simd (PR #121916)

2025-01-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls` running on `linaro-g3-01` while building `clang` at step 5 "cmake stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/4710 Here is the relevant piece of the bui

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread Oleksandr T. via cfe-commits
@@ -10757,6 +10757,17 @@ static void checkMethodTypeQualifiers(Sema &S, Declarator &D, unsigned DiagID) { } } +static void checkMethodPointerType(Sema &S, Declarator &D, unsigned DiagID) { + if (D.getNumTypeObjects() > 0) { +DeclaratorChunk &Chunk = D.getTypeObject(D.g

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/122621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2025-01-12 Thread via cfe-commits
https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001 From: Leijurv Date: Fri, 29 Nov 2024 21:54:36 -0600 Subject: [PATCH 1/8] [clang-format] Add BreakBeforeTemplateClose option --- clang/doc

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2025-01-12 Thread via cfe-commits
@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2025-01-12 Thread Hana Dusíková via cfe-commits
hanickadot wrote: I pushed new design, will update PR's description soon, but now I need to finish proposal's wording. https://github.com/llvm/llvm-project/pull/111861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] 5c0aa31 - -ftime-report: Move FrontendTimer closer to TimeTraceScope

2025-01-12 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2025-01-12T13:17:49-08:00 New Revision: 5c0aa31c3cb448065f12ede53e4dd54a9a98f650 URL: https://github.com/llvm/llvm-project/commit/5c0aa31c3cb448065f12ede53e4dd54a9a98f650 DIFF: https://github.com/llvm/llvm-project/commit/5c0aa31c3cb448065f12ede53e4dd54a9a98f650.diff

[clang] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--fmodule-output` (PR #121046)

2025-01-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4f4e2abb1a5ff1225d32410fd02b732d077aa056 ff22639d751a38e633a5b2e4fe42586d81b36499 --e

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-12 Thread via cfe-commits
@@ -10757,6 +10757,17 @@ static void checkMethodTypeQualifiers(Sema &S, Declarator &D, unsigned DiagID) { } } +static void checkMethodPointerType(Sema &S, Declarator &D, unsigned DiagID) { + if (D.getNumTypeObjects() > 0) { +DeclaratorChunk &Chunk = D.getTypeObject(D.g

[clang] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--fmodule-output` (PR #121046)

2025-01-12 Thread Sharadh Rajaraman via cfe-commits
https://github.com/sharadhr updated https://github.com/llvm/llvm-project/pull/121046 >From 3a84b5906330c4f6308e10c50381f06956c27e2d Mon Sep 17 00:00:00 2001 From: Sharadh Rajaraman Date: Tue, 24 Dec 2024 09:32:21 + Subject: [PATCH 1/4] Accept /Fo and -Fo in `-fmodule-output` when running u

[clang] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--fmodule-output` (PR #121046)

2025-01-12 Thread Sharadh Rajaraman via cfe-commits
https://github.com/sharadhr updated https://github.com/llvm/llvm-project/pull/121046 >From 3a84b5906330c4f6308e10c50381f06956c27e2d Mon Sep 17 00:00:00 2001 From: Sharadh Rajaraman Date: Tue, 24 Dec 2024 09:32:21 + Subject: [PATCH 1/5] Accept /Fo and -Fo in `-fmodule-output` when running u

[clang] [flang] [lld] [Flang] Don't use FortranDecimal for runtime (PR #121997)

2025-01-12 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur updated https://github.com/llvm/llvm-project/pull/121997 >From a08aa48fb4955f9d16c6172580505c100076b5d4 Mon Sep 17 00:00:00 2001 From: Michael Kruse Date: Tue, 7 Jan 2025 17:05:39 +0100 Subject: [PATCH 1/4] Join FortranDecimal into FortranCommon --- clang/lib/Dri

  1   2   >