https://github.com/jayfoad commented:
No objections, just a couple of ideas for improvements. I have no idea if
`ParentMap` lookups are on any kind of hot path.
https://github.com/llvm/llvm-project/pull/121736
___
cfe-commits mailing list
cfe-commits@
https://github.com/jayfoad edited
https://github.com/llvm/llvm-project/pull/121736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -34,13 +34,13 @@ static void BuildParentMap(MapTy& M, Stmt* S,
case Stmt::PseudoObjectExprClass: {
PseudoObjectExpr *POE = cast(S);
-if (OVMode == OV_Opaque && M[POE->getSyntacticForm()])
+if (OVMode == OV_Opaque && M.contains(POE->getSyntacticForm()))
---
@@ -78,7 +78,7 @@ static void BuildParentMap(MapTy& M, Stmt* S,
// The right thing to do is to give the OpaqueValueExpr its syntactic
// parent, then not reassign that when traversing the semantic expressions.
OpaqueValueExpr *OVE = cast(S);
-if (OVMode == OV_Tr
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/121738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: David Spickett
Date: 2025-01-06T09:16:26Z
New Revision: efd929efa589d863611473b99c3249c9d0f3f5ed
URL:
https://github.com/llvm/llvm-project/commit/efd929efa589d863611473b99c3249c9d0f3f5ed
DIFF:
https://github.com/llvm/llvm-project/commit/efd929efa589d863611473b99c3249c9d0f3f5ed.diff
LOG
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: CHANDRA GHALE (chandraghale)
Changes
Added codegen support for combined masked constructs Parallel masked taskloop.
Added implementation for EmitOMPParallelMaskedTaskLoopDirective.
---
Full diff: https://github.com/llvm/llvm-project/pull/
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: CHANDRA GHALE (chandraghale)
Changes
Added codegen support for combined masked constructs Parallel masked taskloop.
Added implementation for EmitOMPParallelMaskedTaskLoopDirective.
---
Full diff: https://github.com/llvm/llvm-proje
https://github.com/chandraghale created
https://github.com/llvm/llvm-project/pull/121741
Added codegen support for combined masked constructs Parallel masked taskloop.
Added implementation for EmitOMPParallelMaskedTaskLoopDirective.
>From 0c790fc2768d58634e0455adf9f797a2456a7335 Mon Sep 17 00:
Author: Owen Pan
Date: 2025-01-06T01:46:17-08:00
New Revision: 9e4774b934a26489e0e3ae60def3aefb5c73edd3
URL:
https://github.com/llvm/llvm-project/commit/9e4774b934a26489e0e3ae60def3aefb5c73edd3
DIFF:
https://github.com/llvm/llvm-project/commit/9e4774b934a26489e0e3ae60def3aefb5c73edd3.diff
LOG:
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/121681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue edited
https://github.com/llvm/llvm-project/pull/121338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve2-vla`
running on `linaro-g4-01` while building `libclc,llvm` at step 7 "ninja check
1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/198/builds/865
Here is the relevant piece of
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/121614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alejandro-alvarez-sonarsource wrote:
> Out of curiosity (not a blocking issue), why do you want this feature for
> C++20 modules?
Sanitizers, linters and indexers have to deal with code using non supported C++
language features or extensions. This is also true for C++20 modules. While
conceiv
ChuanqiXu9 wrote:
@Sirraide hi are you still working on this? We observed similar issue recently.
https://github.com/llvm/llvm-project/pull/110381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
@@ -100,7 +103,7 @@ Parser::DeclGroupPtrTy
Parser::ParseNamespace(DeclaratorContext Context,
} while (MoreToParse);
};
- ReadAttributes();
+ ReadAttributes(/*TrailingAttrs*/ false);
cor3ntin wrote:
Yep, that seems reasonable
https://github.com/llvm/
ChuanqiXu9 wrote:
> > Out of curiosity (not a blocking issue), why do you want this feature for
> > C++20 modules?
>
> Sanitizers, linters and indexers have to deal with code using non supported
> C++ language features or extensions. This is also true for C++20 modules.
> While conceivably on
https://github.com/chandraghale created
https://github.com/llvm/llvm-project/pull/121746
Added codegen support for combined masked constructs `Parallel masked taskloop
simd`.
Added implementation for `EmitOMPParallelMaskedTaskLoopSimdDirective`.
>From 81f9c8f7eb18c0469b3c42db5150384cb57baef8 M
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: CHANDRA GHALE (chandraghale)
Changes
Added codegen support for combined masked constructs `Parallel masked taskloop
simd`.
Added implementation for `EmitOMPParallelMaskedTaskLoopSimdDirective`.
---
Full diff: https://github.com/llvm/llvm-
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: CHANDRA GHALE (chandraghale)
Changes
Added codegen support for combined masked constructs `Parallel masked taskloop
simd`.
Added implementation for `EmitOMPParallelMaskedTaskLoopSimdDirective`.
---
Full diff: https://github.com/ll
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Arseniy Zaostrovnykh (necto)
Changes
Generalize the SymbolIDs used for SymbolData to all SymExprs and use these IDs
for comparison SymbolRef keys in various containers, such as ConstraintMap.
These IDs are superior to raw pointer values b
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Arseniy Zaostrovnykh (necto)
Changes
Generalize the SymbolIDs used for SymbolData to all SymExprs and use these IDs
for comparison SymbolRef keys in various containers, such as ConstraintMap.
These IDs are superior to ra
https://github.com/necto created
https://github.com/llvm/llvm-project/pull/121749
Generalize the SymbolIDs used for SymbolData to all SymExprs and use these IDs
for comparison SymbolRef keys in various containers, such as ConstraintMap.
These IDs are superior to raw pointer values because they
necto wrote:
@steakhal I've fixed the buildbot error ensued after
https://github.com/llvm/llvm-project/pull/121551 was merged
https://github.com/llvm/llvm-project/pull/121749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/Discookie updated
https://github.com/llvm/llvm-project/pull/117165
>From e90ab99dde0945d103959fa73ea2d31852f753e7 Mon Sep 17 00:00:00 2001
From: Viktor
Date: Thu, 21 Nov 2024 14:33:24 +
Subject: [PATCH 1/4] [clang-tidy] Add C++ member function support to
user-defined bug
alejandro-alvarez-sonarsource wrote:
> You hope the linter doesn't give up `some.cc` if `mod` contains some errors?
> If yes, that makes sense to me.
Precisely.
> But why Sanitizers? IIRC, they should only work if the project compiles. Or
> are you saying the static analyzer?
Sorry, my mind
paulhuggett wrote:
> I guess I must of broke build for the MSVC MSBuild/vcxproj CMake generator
(Thanks for the reply, and apologies for the slow response.) I've spent time
trying to properly understand the flow through the add_clang_library and
add_llvm_library. As far as I can tell, the impl
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/121681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -6092,9 +6092,10 @@ void ASTWriter::WriteDeclUpdatesBlocks(ASTContext
&Context,
// An updated body is emitted last, so that the reader doesn't need
// to skip over the lazy body to reach statements f
@@ -6227,8 +6227,10 @@ void ASTWriter::WriteDeclUpdatesBlocks(ASTContext
&Context,
// Add a trailing update record, if any. These must go last because we
// lazily load their attached statement.
if (!GeneratingReducedBMI || !CanElideDeclDef(D)) {
- if (HasUpda
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/121550
From fe4adf2f95aeb72436eead3567767c8c539811c3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Fri, 3 Jan 2025 08:58:23 +0100
Subject: [PATCH 1/2] [c
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -6092,9 +6092,10 @@ void ASTWriter::WriteDeclUpdatesBlocks(ASTContext
&Context,
// An updated body is emitted last, so that the reader doesn't need
// to skip over the lazy body to reach statements f
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -6092,9 +6092,10 @@ void ASTWriter::WriteDeclUpdatesBlocks(ASTContext
&Context,
// An updated body is emitted last, so that the reader doesn't need
// to skip over the lazy body to reach statements f
@@ -49,6 +49,8 @@ class ABIInfo {
CodeGen::CodeGenTypes &CGT;
llvm::CallingConv::ID RuntimeCC;
+ unsigned getTargetDefaultAS() const;
arsenm wrote:
I don't really like this as a helper, it's not really expressing any new target
concept. It's still just
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=
Message-ID:
In-Reply-To:
https://github.com/ChuanqiXu9 approved this pull request.
LGTM with nits
https://github.com/llvm/llvm-project/pull/121550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/120239
>From f7041f5f6f0127f335bedf081f648e769007a827 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 17 Dec 2024 15:35:27 +0100
Subject: [PATCH 1/2] [analyzer] Retry UNDEF Z3 queries at most
"crosscheck-with
@@ -21,9 +21,12 @@ ABIArgInfo DefaultABIInfo::classifyArgumentType(QualType Ty)
const {
// Records with non-trivial destructors/copy-constructors should not be
// passed by value.
if (CGCXXABI::RecordArgABI RAA = getRecordArgABI(Ty, getCXXABI()))
- return getN
@@ -814,7 +816,10 @@ static ABIArgInfo classifyType(CodeGenModule &CGM,
CanQualType type,
auto &layout = CGM.getContext().getASTRecordLayout(record);
if (mustPassRecordIndirectly(CGM, record))
- return ABIArgInfo::getIndirect(layout.getAlignment(), /*byval*/ fals
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/121550
From fe4adf2f95aeb72436eead3567767c8c539811c3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Fri, 3 Jan 2025 08:58:23 +0100
Subject: [PATCH 1/3] [c
@@ -77,16 +80,33 @@ void
Z3CrosscheckVisitor::finalizeVisitor(BugReporterContext &BRC,
RefutationSolver->addConstraint(SMTConstraints);
}
- // And check for satisfiability
- llvm::TimeRecord Start = llvm::TimeRecord::getCurrentTime(/*Start=*/true);
- std::optional Is
https://github.com/ssahasra created
https://github.com/llvm/llvm-project/pull/121736
The implementation of ParentMap assumes that the key is absent if it is mapped
to nullptr. This breaks when trying to store a tuple as the value type. Remove
this assumption by explicit uses of `contains()` an
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sameer Sahasrabuddhe (ssahasra)
Changes
The implementation of ParentMap assumes that the key is absent if it is mapped
to nullptr. This breaks when trying to store a tuple as the value type. Remove
this assumption by explicit uses of `con
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/121550
From fe4adf2f95aeb72436eead3567767c8c539811c3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Fri, 3 Jan 2025 08:58:23 +0100
Subject: [PATCH 1/4] [c
@@ -6092,9 +6092,10 @@ void ASTWriter::WriteDeclUpdatesBlocks(ASTContext
&Context,
// An updated body is emitted last, so that the reader doesn't need
// to skip over the lazy body to reach statements for other records.
- if (Kind == UPD_CXX_ADDED_FUNCTION_DE
https://github.com/ssahasra edited
https://github.com/llvm/llvm-project/pull/121736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2025-01-06T12:58:15+03:00
New Revision: 3c5f2698b02ae3cec13551226f083984ab41f0f3
URL:
https://github.com/llvm/llvm-project/commit/3c5f2698b02ae3cec13551226f083984ab41f0f3
DIFF:
https://github.com/llvm/llvm-project/commit/3c5f2698b02ae3cec13551226f083984ab41f0f3.
https://github.com/sdesmalen-arm approved this pull request.
LGTM as well. +1 on @MacDue's suggestion to add an extra test to
sme-inline-callees-streaming-attrs.c as well.
https://github.com/llvm/llvm-project/pull/121338
___
cfe-commits mailing list
c
mati865 wrote:
I'd be fine with closing this PR and #10148 if that is the preferred solution.
https://github.com/llvm/llvm-project/pull/121442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
MacDue wrote:
> > LGTM 👍 You could maybe add a test to
> > `clang/test/CodeGen/AArch64/sme-inline-callees-streaming-attrs.c` too
> > (which tests `flatten`/`always_inline` statements).
>
> Thanks for approving the changes! I did already add some tests to
> sme-inline-callees-streaming-attrs.c
kmclaughlin-arm wrote:
> LGTM 👍 You could maybe add a test to
> `clang/test/CodeGen/AArch64/sme-inline-callees-streaming-attrs.c` too (which
> tests `flatten`/`always_inline` statements).
Thanks for approving the changes!
I did already add some tests to sme-inline-callees-streaming-attrs.c usi
https://github.com/hchandel updated
https://github.com/llvm/llvm-project/pull/121752
>From 9a4f77a07df6aa926b121b2ac1e9c251fe39b3af Mon Sep 17 00:00:00 2001
From: Harsh Chandel
Date: Fri, 3 Jan 2025 18:02:09 +0530
Subject: [PATCH 1/3] [RISCV] Add Qualcomm uC Xqcicm (Conditional Move)
extension
AmrDeveloper wrote:
> Thanks! The update looks good, I have one more minor suggestion for a change
> which I'll just go ahead and make before merging.
Thank you
https://github.com/llvm/llvm-project/pull/121656
___
cfe-commits mailing list
cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Benjamin Maxwell (MacDue)
Changes
This will allow vectorizing these calls (after a few more patches). This should
not change the codegen for targets that enable the use of AA during the codegen
(in `TargetSubtargetInfo::useAA()`).
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Benjamin Maxwell (MacDue)
Changes
This will allow vectorizing these calls (after a few more patches). This should
not change the codegen for targets that enable the use of AA during the codegen
(in `TargetSubtargetInfo::useAA()`). This in
sharadhr wrote:
The Linux tests that failed nearly instantaneously seem to have failed because
of a CI permissions issue and are hence irrelevant. There are more critical
Windows/macOS failures that have to do with PCHs when running with `clang-cl`,
and I shall investigate them.
https://gith
fhahn wrote:
Would be good to also update the documentation for the builtins the clarify the
behavior.
https://github.com/llvm/llvm-project/pull/119423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
AmrDeveloper wrote:
@HighCommander4
We can also create a new matcher for `dependentNameType` so we can use it like
`dependentNameType(hasDependentType(builtinType()))`, which is similar to
Complex and Array types.
If confirmed I can work on it too :D
Thank you
https://github.com/llvm/llvm-
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/121759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1389,6 +1389,68 @@ Query for this attribute with
``__has_attribute(overloadable)``.
}];
}
+def OwnershipDocs : Documentation {
+ let Heading = "ownership_holds, ownership_returns, ownership_takes (Clang "
+"Static Analyzer)";
+ let Category = DocCatFun
https://github.com/NagyDonat approved this pull request.
LGTM, thanks for adding this documentation!
I added an inline suggestion that -- hopefully -- clarifies the differences
between held and taken memory areas; but the original is also completely OK.
Feel free to ignore or tweak my suggesti
@@ -41,6 +42,141 @@ namespace cwg202 { // cwg202: 3.1
template struct X;
}
+namespace cwg203 { // cwg203: 3.0
+namespace ex1 {
+struct B {
+ int i;
+};
+struct D1 : B {};
+struct D2 : B {};
+
+int(D1::*pmD1) = &D2::i;
+} // namespace ex1
+
+#if __cplusplus >= 202002L
+names
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/121687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM modulo comments
But I wonder how much we want to focus on testing these NAD core issues that
are merely feature requests
https://github.com/llvm/llvm-project/pull/121687
___
cfe-commits mai
@@ -41,6 +42,141 @@ namespace cwg202 { // cwg202: 3.1
template struct X;
}
+namespace cwg203 { // cwg203: 3.0
+namespace ex1 {
+struct B {
+ int i;
+};
+struct D1 : B {};
+struct D2 : B {};
+
+int(D1::*pmD1) = &D2::i;
+} // namespace ex1
+
+#if __cplusplus >= 202002L
+names
@@ -41,6 +42,141 @@ namespace cwg202 { // cwg202: 3.1
template struct X;
}
+namespace cwg203 { // cwg203: 3.0
+namespace ex1 {
+struct B {
+ int i;
+};
+struct D1 : B {};
+struct D2 : B {};
+
+int(D1::*pmD1) = &D2::i;
+} // namespace ex1
+
+#if __cplusplus >= 202002L
+names
https://github.com/MacDue created
https://github.com/llvm/llvm-project/pull/121763
This will allow vectorizing these calls (after a few more patches). This should
not change the codegen for targets that enable the use of AA during the codegen
(in `TargetSubtargetInfo::useAA()`). This includes
@@ -49,6 +49,8 @@ class ABIInfo {
CodeGen::CodeGenTypes &CGT;
llvm::CallingConv::ID RuntimeCC;
+ unsigned getTargetDefaultAS() const;
AlexVlx wrote:
Sure, but I couldn't quite figure out any other convenient, accessible,
non-intrusive place to stash thi
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux`
running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/66/builds/8274
Here is the relevant piece of the b
jhuber6 wrote:
I discussed this with @t-tye, he said it's correct but wants @Pierre-vh to sign
off on it.
https://github.com/llvm/llvm-project/pull/120095
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
Author: cor3ntin
Date: 2025-01-06T14:48:50+01:00
New Revision: 3f7905733820851bc4f65cb4af693c3101cbf20d
URL:
https://github.com/llvm/llvm-project/commit/3f7905733820851bc4f65cb4af693c3101cbf20d
DIFF:
https://github.com/llvm/llvm-project/commit/3f7905733820851bc4f65cb4af693c3101cbf20d.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/121333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
501 - 572 of 572 matches
Mail list logo
