[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Balazs Benics via cfe-commits
@@ -1389,6 +1389,68 @@ Query for this attribute with ``__has_attribute(overloadable)``. }]; } +def OwnershipDocs : Documentation { + let Heading = "ownership_holds, ownership_returns, ownership_takes (Clang " +"Static Analyzer)"; + let Category = DocCatFun

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. Looks pretty good. Thanks for the docs. That's always a nice way to start a year. https://github.com/llvm/llvm-project/pull/121759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/121759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Balazs Benics via cfe-commits
@@ -1389,6 +1389,68 @@ Query for this attribute with ``__has_attribute(overloadable)``. }]; } +def OwnershipDocs : Documentation { + let Heading = "ownership_holds, ownership_returns, ownership_takes (Clang " +"Static Analyzer)"; + let Category = DocCatFun

[clang-tools-extra] [Fixes] Added option to readability-implicit-bool-conversion check to allow implicit conversion *to bool* (PR #121761)

2025-01-06 Thread via cfe-commits
https://github.com/4m4n-x-B4w4ne edited https://github.com/llvm/llvm-project/pull/121761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make passing incomplete types to builtin type-traits a non-sfinae-friendly error (PR #121333)

2025-01-06 Thread via cfe-commits
cor3ntin wrote: I confirmed this was the intent with LWG https://github.com/llvm/llvm-project/pull/121333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make passing incomplete types to builtin type-traits a non-sfinae-friendly error (PR #121333)

2025-01-06 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/121333 >From 8298d9815c4f7f53e6f086260a7ea341ba75b9ad Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 30 Dec 2024 12:31:23 +0100 Subject: [PATCH] [Clang] Make passing incomplete types to builtin type-traits

[clang] 0d5c072 - [HLSL] Adding Flatten and Branch if attributes (#116331)

2025-01-06 Thread via cfe-commits
Author: joaosaffran Date: 2025-01-06T10:27:02-08:00 New Revision: 0d5c07285f79a2135730c919c7e7b8e2bd9118e7 URL: https://github.com/llvm/llvm-project/commit/0d5c07285f79a2135730c919c7e7b8e2bd9118e7 DIFF: https://github.com/llvm/llvm-project/commit/0d5c07285f79a2135730c919c7e7b8e2bd9118e7.diff L

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2025-01-06 Thread via cfe-commits
https://github.com/joaosaffran closed https://github.com/llvm/llvm-project/pull/116331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-06 Thread Greg Roth via cfe-commits
@@ -33,6 +41,21 @@ constexpr enable_if_t bit_cast(T F) { return __builtin_bit_cast(U, F); } +template +constexpr enable_if_t::value || is_same::value, T> +length_impl(T X) { + return __builtin_elementwise_abs(X); +} + +template +enable_if_t::value || is_same::value, T> +

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-06 Thread Greg Roth via cfe-commits
https://github.com/pow2clk edited https://github.com/llvm/llvm-project/pull/121611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-06 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/121611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix implicit integer conversion for opaque enums declared in class templates (PR #121039)

2025-01-06 Thread via cfe-commits
=?utf-8?q?André?= Brand Message-ID: In-Reply-To: thebrandre wrote: @erichkeane I am not sure what you mean. As I pointed out earlier, the examples @cor3ntin brought up actually conform to the standard as in [[temp.spec.general]](https://wg21.link/temp.spec#temp.inst-3): > The implicit insta

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-06 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/121611 >From 7044e856bcd89de7318f7f4970c53beb0fc4 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Tue, 17 Dec 2024 18:30:23 -0500 Subject: [PATCH 1/3] [HLSL] Move length intrinsic to the header --- clang/includ

[clang] [RISCV] Teach Barmetal toolchain about GCC installation(1/3) (PR #121821)

2025-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Garvit Gupta (quic-garvgupt) Changes This patch introduces the baretmetal toolchain object about GCC Installation. Currently, if `--gcc-installation` ot `--gcc-install-dir` options are passed on commandline, then sysroot will be formed fr

[clang] [llvm] Handle leading underscores in update_cc_test_checks.py (PR #121800)

2025-01-06 Thread Alexander Richardson via cfe-commits
arichardson wrote: Could you give me an example of such an architecture? Isn't it a bug that clang reports an incorrect mangled name? Also please add a test for this (ideally pre-committing one that fails before and passes with this change). https://github.com/llvm/llvm-project/pull/121800 ___

[clang] [llvm] Handle leading underscores in update_cc_test_checks.py (PR #121800)

2025-01-06 Thread Alexander Richardson via cfe-commits
@@ -650,6 +655,16 @@ def get_triple_from_march(march): print("Cannot find a triple. Assume 'x86'", file=sys.stderr) return "x86" +def get_global_underscores(raw_tool_output): +m = DATA_LAYOUT_RE.search(raw_tool_output) +if not m: +return False +data

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

2025-01-06 Thread David Pagan via cfe-commits
https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/121814 The 'align' modifier is now accepted in the 'allocate' clause. Added LIT tests covering codegen, PCH, template handling, and serialization for 'align' modifier. Added support for align-modifier to release note

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-06 Thread Thurston Dang via cfe-commits
https://github.com/thurstond updated https://github.com/llvm/llvm-project/pull/121619 >From ca1fabc5ea75af0acdd1969c0ad505e04103e1c9 Mon Sep 17 00:00:00 2001 From: Thurston Dang Date: Sat, 4 Jan 2025 02:53:00 + Subject: [PATCH 1/3] [sanitizer] Parse weighted sanitizer args and -fno-sanitiz

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

2025-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: David Pagan (ddpagan) Changes The 'align' modifier is now accepted in the 'allocate' clause. Added LIT tests covering codegen, PCH, template handling, and serialization for 'align' modifier. Added support for align-modifier to release no

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

2025-01-06 Thread David Pagan via cfe-commits
ddpagan wrote: NOTE: OpenMP Support doc will be updated as well in a subsequent patch. https://github.com/llvm/llvm-project/pull/121814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-06 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/121611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-06 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > Thanks for the description. I would find some justification useful even if it > just repeats the reasoning we've established for all such changes. @pow2clk added a justification. https://github.com/llvm/llvm-project/pull/121611 ___ c

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-06 Thread Chris B via cfe-commits
https://github.com/llvm-beanz commented: I don't love the way you re-wrote clang/test/CodeGenHLSL/builtins/length.hlsl. I'm not a huge fan of the `update_cc_test_checks` workflow, and (as I commented elsewhere) I really don't like tests that depend on optimizations. I'm okay with removing the

[clang] [Clang] Add float type support to __builtin_reduce_add and __builtin_reduce_multipy (PR #120367)

2025-01-06 Thread Csanád Hajdú via cfe-commits
Il-Capitano wrote: Just to clarify: `@llvm.vector.reduce.fadd` does sequential reduction by default, so I don't see a point in doing that manually in the frontend. Your previous implementation had the same behaviour. The inconsistency with the sequential approach is that Clang defines the `__

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-06 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/121611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Arm] Regenerate tests (NFC) (PR #121801)

2025-01-06 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/121801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][SPIRV] Translate `amdgpu_flat_work_group_size` into `reqd_work_group_size`. (PR #116820)

2025-01-06 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/116820 >From c5efdd24c0c889e26e3b00865780970ca5ed1f4c Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 19 Nov 2024 14:55:25 + Subject: [PATCH 1/3] Translate `amdgpu_flat_work_group_size` into `reqd_work_group_

[clang] [OpenMP] codegen support for masked combined construct parallel masked taskloop (PR #121741)

2025-01-06 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert approved this pull request. Looks like the old master directive implementation. https://github.com/llvm/llvm-project/pull/121741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [clang] Fix implicit integer conversion for opaque enums declared in class templates (PR #121039)

2025-01-06 Thread Erich Keane via cfe-commits
=?utf-8?q?André?= Brand Message-ID: In-Reply-To: erichkeane wrote: > @erichkeane I am not sure what you mean. As I pointed out earlier, the > examples @cor3ntin brought up actually conform to the standard as in > [[temp.spec.general]](https://wg21.link/temp.spec#temp.inst-3): > > > The impl

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-06 Thread Farzon Lotfi via cfe-commits
@@ -33,6 +41,21 @@ constexpr enable_if_t bit_cast(T F) { return __builtin_bit_cast(U, F); } +template +constexpr enable_if_t::value || is_same::value, T> +length_impl(T X) { + return __builtin_elementwise_abs(X); +} + +template +enable_if_t::value || is_same::value, T> +

[clang] 21c785d - [OpenACC] Implement 'set' construct sema

2025-01-06 Thread via cfe-commits
Author: erichkeane Date: 2025-01-06T11:03:18-08:00 New Revision: 21c785d7bd84df0b9176d48e7c3e74c914aae05a URL: https://github.com/llvm/llvm-project/commit/21c785d7bd84df0b9176d48e7c3e74c914aae05a DIFF: https://github.com/llvm/llvm-project/commit/21c785d7bd84df0b9176d48e7c3e74c914aae05a.diff LO

[clang] ff24e9a - [OpenACC] Implement 'default_async' sema

2025-01-06 Thread via cfe-commits
Author: erichkeane Date: 2025-01-06T11:03:18-08:00 New Revision: ff24e9a19e3db330dd6412aac9d1d6c0b416697f URL: https://github.com/llvm/llvm-project/commit/ff24e9a19e3db330dd6412aac9d1d6c0b416697f DIFF: https://github.com/llvm/llvm-project/commit/ff24e9a19e3db330dd6412aac9d1d6c0b416697f.diff LO

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

2025-01-06 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: Update OpenMPSupport.rst https://github.com/llvm/llvm-project/pull/121814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][AArch64][clang] Emit fmv-features metadata in LLVM IR. (PR #118544)

2025-01-06 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/118544 >From e028f19f1b4154e44c61e371ae5feeb522085338 Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Tue, 3 Dec 2024 20:22:37 + Subject: [PATCH 1/2] [FMV][AArch64][clang] Emit fmv-features metadata in

[clang] [HLSL] Fix debug info generation for RWBuffer types (PR #119041)

2025-01-06 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/119041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Michael Toguchi (mdtoguchi) Changes The following commit: https://github.com/llvm/llvm-project/commit/d00f65c6acd9f0e1ddae83391f55eb9d232d2f9e Caused sanitizer build issues and also a test issue when using %clang_cl. Address these

[clang] Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread Michael Toguchi via cfe-commits
https://github.com/mdtoguchi created https://github.com/llvm/llvm-project/pull/121822 The following commit: https://github.com/llvm/llvm-project/commit/d00f65c6acd9f0e1ddae83391f55eb9d232d2f9e Caused sanitizer build issues and also a test issue when using %clang_cl. Address these problems.

[clang] Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Toguchi (mdtoguchi) Changes The following commit: https://github.com/llvm/llvm-project/commit/d00f65c6acd9f0e1ddae83391f55eb9d232d2f9e Caused sanitizer build issues and also a test issue when using %clang_cl. Address these proble

[clang] [RISCV] Teach Barmetal toolchain about GCC installation(1/3) (PR #121821)

2025-01-06 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt created https://github.com/llvm/llvm-project/pull/121821 This patch introduces the baretmetal toolchain object about GCC Installation. Currently, if `--gcc-installation` ot `--gcc-install-dir` options are passed on commandline, then sysroot will be formed from

[clang] [RISCV] Teach Barmetal toolchain about GCC installation(1/3) (PR #121821)

2025-01-06 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt closed https://github.com/llvm/llvm-project/pull/121821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr atomic builtins (__c11_atomic_OP and __atomic_OP) (PR #98756)

2025-01-06 Thread Hana Dusíková via cfe-commits
hanickadot wrote: It's broken after rebase, fixing it now... https://github.com/llvm/llvm-project/pull/98756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #117268)

2025-01-06 Thread Michael Toguchi via cfe-commits
mdtoguchi wrote: I have posted a fix to address the sanitizer builds and build warning: https://github.com/llvm/llvm-project/pull/121822 https://github.com/llvm/llvm-project/pull/117268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread via cfe-commits
=?utf-8?q?Kristóf?= Umann , =?utf-8?q?Kristóf?= Umann , =?utf-8?q?Kristóf?= Umann Message-ID: In-Reply-To: @@ -1389,6 +1389,81 @@ Query for this attribute with ``__has_attribute(overloadable)``. }]; } +def OwnershipDocs : Documentation { + let Heading = "ownership_holds

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread via cfe-commits
=?utf-8?q?Krist=C3=B3f?= Umann , =?utf-8?q?Krist=C3=B3f?= Umann , =?utf-8?q?Krist=C3=B3f?= Umann Message-ID: In-Reply-To: https://github.com/isuckatcs approved this pull request. https://github.com/llvm/llvm-project/pull/121759 ___ cfe-commits maili

[clang] 3f93625 - [HLSL] Fix debug info generation for RWBuffer types (#119041)

2025-01-06 Thread via cfe-commits
Author: joaosaffran Date: 2025-01-06T11:01:49-08:00 New Revision: 3f936251d280d039d0a227247afd6884163e8a9a URL: https://github.com/llvm/llvm-project/commit/3f936251d280d039d0a227247afd6884163e8a9a DIFF: https://github.com/llvm/llvm-project/commit/3f936251d280d039d0a227247afd6884163e8a9a.diff L

[clang] [HLSL] Fix debug info generation for RWBuffer types (PR #119041)

2025-01-06 Thread via cfe-commits
https://github.com/joaosaffran closed https://github.com/llvm/llvm-project/pull/119041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr atomic builtins (__c11_atomic_OP and __atomic_OP) (PR #98756)

2025-01-06 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/98756 From bfb43ab80b0272e60c8b43bcd14533ee68a11f13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Mon, 6 Jan 2025 20:40:01 +0100 Subject: [PATCH] [clang] implement P3309 atomic builtin

[clang] [RISCV] Teach Barmetal toolchain about GCC installation(1/3) (PR #121829)

2025-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Garvit Gupta (quic-garvgupt) Changes This patch introduces the baretmetal toolchain object about GCC Installation. Currently, if `--gcc-installation` ot `--gcc-install-dir` options are passed on commandline

[clang] [RISCV] Teach Barmetal toolchain about GCC installation(1/3) (PR #121829)

2025-01-06 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt ready_for_review https://github.com/llvm/llvm-project/pull/121829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][NFC] Rework Timer.cpp globals to ensure valid lifetimes (PR #121663)

2025-01-06 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu commented: Thanks for working on this. I have a couple of questions about inconsistent casing. Other than that, this looks reasonable to me. But I don't have a great deal of experience with this part of LLVM, so please wait for other reviewers. https://github.co

[clang] [llvm] [llvm][NFC] Rework Timer.cpp globals to ensure valid lifetimes (PR #121663)

2025-01-06 Thread Tarun Prabhu via cfe-commits
@@ -284,18 +250,22 @@ NamedRegionTimer::NamedRegionTimer(StringRef Name, StringRef Description, /// ctor/dtor and is protected by the TimerLock lock. static TimerGroup *TimerGroupList = nullptr; -TimerGroup::TimerGroup(StringRef Name, StringRef Description) - : Name(Name.beg

[clang] [llvm] [llvm][NFC] Rework Timer.cpp globals to ensure valid lifetimes (PR #121663)

2025-01-06 Thread Tarun Prabhu via cfe-commits
@@ -38,63 +38,40 @@ using namespace llvm; -// This ugly hack is brought to you courtesy of constructor/destructor ordering -// being unspecified by C++. Basically the problem is that a Statistic object -// gets destroyed, which ends up calling 'GetLibSupportInfoOutputFile()'

[clang] [Sema] Note member decl when initializer list default constructs member (PR #121854)

2025-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brian Foley (bpfoley) Changes Recently I had a scenario where I had: 1. A class C with many members m_1...m_n of the same type T 2. T's default constructor was deleted 3. I accidentally omitted an explicitly constructed member in the initia

[clang] [Sema] Note member decl when initializer list default constructs member (PR #121854)

2025-01-06 Thread Brian Foley via cfe-commits
https://github.com/bpfoley created https://github.com/llvm/llvm-project/pull/121854 Recently I had a scenario where I had: 1. A class C with many members m_1...m_n of the same type T 2. T's default constructor was deleted 3. I accidentally omitted an explicitly constructed member in the initiali

[clang] [Sema] Note member decl when initializer list default constructs member (PR #121854)

2025-01-06 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] fix uefi target for aarch64 & x86_64 (PR #120632)

2025-01-06 Thread via cfe-commits
https://github.com/Prabhuk approved this pull request. https://github.com/llvm/llvm-project/pull/120632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Do not serialize function definitions without a body (PR #121550)

2025-01-06 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource updated https://github.com/llvm/llvm-project/pull/121550 From fe4adf2f95aeb72436eead3567767c8c539811c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?= Date: Fri, 3 Jan 2025 08:58:23 +0100 Subject: [PATCH 1/5] [c

[clang] [clang] Do not serialize function definitions without a body (PR #121550)

2025-01-06 Thread Alejandro Álvarez Ayllón via cfe-commits
@@ -6092,9 +6092,10 @@ void ASTWriter::WriteDeclUpdatesBlocks(ASTContext &Context, // An updated body is emitted last, so that the reader doesn't need // to skip over the lazy body to reach statements for other records. - if (Kind == UPD_CXX_ADDED_FUNCTION_DE

[clang] [analyzer] Retry UNDEF Z3 queries at most "crosscheck-with-z3-retries-on-timeout" times (PR #120239)

2025-01-06 Thread Balazs Benics via cfe-commits
steakhal wrote: > I'm a bit surprised by the idea of using multiple attempts instead of a > single run with a larger timeout -- intuitively we're wasting the already > performed calculations if we are impatient and abort+restart the calculations > after each short timeout (instead of allocatin

[clang] [analyzer] Retry UNDEF Z3 queries at most "crosscheck-with-z3-retries-on-timeout" times (PR #120239)

2025-01-06 Thread Balazs Benics via cfe-commits
@@ -213,6 +215,15 @@ ANALYZER_OPTION( "400'000 should on average make Z3 queries run for up to 100ms on modern " "hardware. Set 0 for unlimited.", 0) +ANALYZER_OPTION( +unsigned, Z3CrosscheckRetriesOnTimeout, +"crosscheck-with-z3-retries-on-timeout", +"Set

[clang] [clang][NFC] clean up the handling of convergence control tokens (PR #121738)

2025-01-06 Thread Sameer Sahasrabuddhe via cfe-commits
https://github.com/ssahasra created https://github.com/llvm/llvm-project/pull/121738 None >From e1611a9dbfe7a8239b93b84fa7682e68dc727f0f Mon Sep 17 00:00:00 2001 From: Sameer Sahasrabuddhe Date: Mon, 6 Jan 2025 14:01:49 +0530 Subject: [PATCH] [clang][NFC] clean up the handling of convergence c

[clang] [clang] Do not serialize function definitions without a body (PR #121550)

2025-01-06 Thread Chuanqi Xu via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?=, Alejandro =?utf-8?q?Álvarez_Ayllón?=, Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: @@ -6092,12 +6092,14 @@ void ASTWriter::WriteDeclUpdatesBlocks(ASTContext &Context, // An updated body is emitted last, so that the r

[clang] 648e256 - Reapply "[clang][analyzer] Stable order for SymbolRef-keyed containers" (#121749)

2025-01-06 Thread via cfe-commits
Author: Arseniy Zaostrovnykh Date: 2025-01-06T12:45:31+01:00 New Revision: 648e256e541d6421eca72df733f888787485bda8 URL: https://github.com/llvm/llvm-project/commit/648e256e541d6421eca72df733f888787485bda8 DIFF: https://github.com/llvm/llvm-project/commit/648e256e541d6421eca72df733f888787485bda

[clang] Reapply "[clang][analyzer] Stable order for SymbolRef-keyed containers" (PR #121749)

2025-01-06 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/121749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add -fuse-lipo option (PR #121231)

2025-01-06 Thread via cfe-commits
Andarwinux wrote: It is better to add a CLANG_DEFAULT_LIPO cmake option to match the CLANG_DEFAULT_LINKER for -fuse-ld. https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [llvm] [HLSL][RootSignature] Implement parsing of `RootFlags` (PR #121799)

2025-01-06 Thread Chris B via cfe-commits
@@ -0,0 +1,139 @@ +#include "clang/Sema/ParseHLSLRootSignature.h" + +namespace llvm { +namespace hlsl { +namespace root_signature { + +// TODO: Hook up with Sema to properly report semantic/validation errors +bool Parser::ReportError() { return true; } + +bool Parser::ParseRootFla

[clang] [llvm] [HLSL][RootSignature] Implement parsing of `RootFlags` (PR #121799)

2025-01-06 Thread Chris B via cfe-commits
https://github.com/llvm-beanz commented: Is there a reason that you're just operating on a StringRef buffer instead of building out a proper tokenizer and parser? It seems to me like root signature parsing probably warrants full lexer and parser that operates on tokens rather than just section

[clang] [llvm] [HLSL][RootSignature] Implement parsing of `RootFlags` (PR #121799)

2025-01-06 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/121799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add -fuse-lipo option (PR #121231)

2025-01-06 Thread Ashley Hauck via cfe-commits
khyperia wrote: > It is better to add a CLANG_DEFAULT_LIPO cmake option to match the > CLANG_DEFAULT_LINKER for -fuse-ld. Sure, that's a possibility, but in my opinion can be done in a future PR. There's a lot of additional features that can be done in the future: - CLANG_DEFAULT_LIPO cmake o

[clang] [llvm] [llvm][NFC] Rework Timer.cpp globals to ensure valid lifetimes (PR #121663)

2025-01-06 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu edited https://github.com/llvm/llvm-project/pull/121663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Teach Barmetal toolchain about GCC installation(1/3) (PR #121829)

2025-01-06 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt edited https://github.com/llvm/llvm-project/pull/121829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-06 Thread Jason Rice via cfe-commits
@@ -951,28 +959,130 @@ Sema::ActOnDecompositionDeclarator(Scope *S, Declarator &D, return New; } +namespace { +// CheckBindingsCount +// - Checks the arity of the structured bindings +// - Creates the resolved pack expr if there is +//one +bool CheckBindingsCount(Sema

[clang] [clang][dataflow] Use smart pointer caching in unchecked optional accessor (PR #120249)

2025-01-06 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/120249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Use smart pointer caching in unchecked optional accessor (PR #120249)

2025-01-06 Thread Yitzhak Mandelbaum via cfe-commits
@@ -58,6 +63,106 @@ ast_matchers::StatementMatcher isSmartPointerLikeOperatorArrow(); ast_matchers::StatementMatcher isSmartPointerLikeValueMethodCall(); ast_matchers::StatementMatcher isSmartPointerLikeGetMethodCall(); +// Common transfer functions. + +/// Returns the "canon

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2025-01-06 Thread Henry Jiang via cfe-commits
mustartt wrote: Hi @joaosaffran I believe this patch is causing an build error in `clang-ppc64le-rhel` build bot. https://lab.llvm.org/buildbot/#/builders/145/builds/4252 ``` FAILED: tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenFunction.cpp.o ccache /home/docker/llvm-extern

[clang] [Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread Paul Kirth via cfe-commits
@@ -32,7 +31,7 @@ void SYCLInstallationDetector::addSYCLIncludeArgs( // Unsupported options for SYCL device compilation. static ArrayRef getUnsupportedOpts() { - return { + static std::vector UnsupportedOpts = { ilovepi wrote: Hmm, I was thinking that you'd

[clang] [llvm] [AsmParser] Revamp how floating-point literals in LLVM IR. (PR #121838)

2025-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-backend-hexagon Author: Joshua Cranmer (jcranmer-intel) Changes This adds support for the following kinds of formats: * Hexadecimal literals like 0x1.fp13 * Special values +inf/-inf, +qnan/-qnan * NaN values with payloads l

[clang] [llvm] [AsmParser] Revamp how floating-point literals in LLVM IR. (PR #121838)

2025-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joshua Cranmer (jcranmer-intel) Changes This adds support for the following kinds of formats: * Hexadecimal literals like 0x1.fp13 * Special values +inf/-inf, +qnan/-qnan * NaN values with payloads like +nan(0x1) Additionally, the floating

[clang] [Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka requested changes to this pull request. Does not compile I'll update and merge. https://github.com/llvm/llvm-project/pull/121822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann edited https://github.com/llvm/llvm-project/pull/121822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AsmParser] Revamp how floating-point literals in LLVM IR. (PR #121838)

2025-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Joshua Cranmer (jcranmer-intel) Changes This adds support for the following kinds of formats: * Hexadecimal literals like 0x1.fp13 * Special values +inf/-inf, +qnan/-qnan * NaN values with payloads like +nan(0x1) Additionally, the

[clang] [llvm] [AsmParser] Revamp how floating-point literals in LLVM IR. (PR #121838)

2025-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Joshua Cranmer (jcranmer-intel) Changes This adds support for the following kinds of formats: * Hexadecimal literals like 0x1.fp13 * Special values +inf/-inf, +qnan/-qnan * NaN values with payloads like +nan(0x1) Additionally, th

[clang] [Clang] __has_builtin should return false for aux triple builtins (PR #121839)

2025-01-06 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/121839 Currently, `__has_builtin` will return true when passed a builtin that is only supported on the aux target. I found this when `__has_builtin` was called with an X86 builtin but the current target was SPIR-V. I

[clang] Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann approved this pull request. The changes look good to me! https://github.com/llvm/llvm-project/pull/121822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AsmParser] Revamp how floating-point literals in LLVM IR. (PR #121838)

2025-01-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff be21bd9bbf3bc906f9b98ac3de1fc88a4a8ac4b4 69fce1904ae71a792575c735c22efcc5d65907d7 --e

[clang] [Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/121822 >From 92796278b87c5713a0cf16119009c07f87568df5 Mon Sep 17 00:00:00 2001 From: Michael D Toguchi Date: Mon, 6 Jan 2025 11:42:12 -0800 Subject: [PATCH 1/4] Driver][SYCL] Address sanitizer and test issue The fo

[clang] [Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/121822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread Michael Toguchi via cfe-commits
mdtoguchi wrote: Thanks @vitalybuka, makes sense to use the literal type here. https://github.com/llvm/llvm-project/pull/121822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] __has_builtin should return false for aux triple builtins (PR #121839)

2025-01-06 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: Is it possible that we could just skip generating the builtin IDs at all for the aux target? Or does that break something. https://github.com/llvm/llvm-project/pull/121839 ___ cfe-commits mailing list cfe-commits@

[clang] [Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread Michael Toguchi via cfe-commits
@@ -17,8 +17,7 @@ using namespace llvm::opt; SYCLInstallationDetector::SYCLInstallationDetector( const Driver &D, const llvm::Triple &HostTriple, -const llvm::opt::ArgList &Args) -: D(D) {} +const llvm::opt::ArgList &Args) {} mdtoguchi wrote:

[clang] ec58ad6 - [Driver][SYCL] Address sanitizer and test issue (#121822)

2025-01-06 Thread via cfe-commits
Author: Michael Toguchi Date: 2025-01-06T13:39:31-08:00 New Revision: ec58ad6149fb8813521973d8ba9690276e282373 URL: https://github.com/llvm/llvm-project/commit/ec58ad6149fb8813521973d8ba9690276e282373 DIFF: https://github.com/llvm/llvm-project/commit/ec58ad6149fb8813521973d8ba9690276e282373.dif

[clang] [Clang] __has_builtin should return false for aux triple builtins (PR #121839)

2025-01-06 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Ah, I see how it is. And it probably worked in the NVPTX / AMDGCN case because we had valid code paths. This is definitely something that should be fixed, because it makes no sense to say a builtin is available if you can't even use it. Though offloading languages do tend to hat

[clang] [Driver][SYCL] Address sanitizer and test issue (PR #121822)

2025-01-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/121822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME] Add diagnostics to CheckConstexprFunctionDefinition (PR #121777)

2025-01-06 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/121777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2025-01-06 Thread via cfe-commits
joaosaffran wrote: Sorry about that @mustartt, will fix it and send a PR in a few minutes https://github.com/llvm/llvm-project/pull/116331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2025-01-06 Thread Henry Jiang via cfe-commits
mustartt wrote: Thanks! Not a problem, there were another earlier scyl related failure so the bots didn't pick this one up. https://github.com/llvm/llvm-project/pull/116331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-06 Thread Thurston Dang via cfe-commits
https://github.com/thurstond updated https://github.com/llvm/llvm-project/pull/121619 >From ca1fabc5ea75af0acdd1969c0ad505e04103e1c9 Mon Sep 17 00:00:00 2001 From: Thurston Dang Date: Sat, 4 Jan 2025 02:53:00 + Subject: [PATCH 1/4] [sanitizer] Parse weighted sanitizer args and -fno-sanitiz

[clang] [clang] Fix implicit integer conversion for opaque enums declared in class templates (PR #121039)

2025-01-06 Thread via cfe-commits
=?utf-8?q?André?= Brand Message-ID: In-Reply-To: cor3ntin wrote: We usually try to diagnose issues as soon as possible, so i still believe there are improvements to be made here. That being said, I'm happy to approve the PR as it is now. That being said, it is missing a changelog entry in

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-06 Thread Vitaly Buka via cfe-commits
@@ -186,10 +188,24 @@ struct SanitizerSet { /// Returns a non-zero SanitizerMask, or \c 0 if \p Value is not known. SanitizerMask parseSanitizerValue(StringRef Value, bool AllowGroups); +/// Parse a single weighted value (e.g., 'undefined=0.05') from a -fsanitize= or +/// -fn

<    1   2   3   4   5   6   >