[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-01-03 Thread Erich Keane via cfe-commits
@@ -166,7 +166,8 @@ getScopeFromNormalizedScopeName(StringRef ScopeName) { .Case("hlsl", AttributeCommonInfo::Scope::HLSL) .Case("msvc", AttributeCommonInfo::Scope::MSVC) .Case("omp", AttributeCommonInfo::Scope::OMP) - .Case("riscv", AttributeCommonInfo::

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From 409dd1184f1c4ff9f11e2d715b6e4a496c70c7e4 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH 1/2] [libclc] Add Maintainers.md for libclc --- libclc/Ma

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-01-03 Thread Erich Keane via cfe-commits
@@ -179,6 +179,8 @@ def err_opencl_unknown_type_specifier : Error< def warn_unknown_attribute_ignored : Warning< "unknown attribute %0 ignored">, InGroup; +def ext_unknown_attribute_ignored : Extension< + "unknown attribute %0 ignored">, InGroup; erichkeane

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: Updated to list @frasercrmck and @tstellar for libclc. Tell me if that works for now, perhaps you can sort out any additions later. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

2025-01-03 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I have a bit of a concern that the template cases are going to be REALLY noisy, but we can deal with restricting individual use cases to a separate warning-group in the future if need-be. https://github.com/llvm/llvm-project/pull/121419

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread via cfe-commits
@@ -,12 +,57 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #117268)

2025-01-03 Thread Michael Toguchi via cfe-commits
@@ -630,6 +630,11 @@ void toolchains::MinGW::AddHIPIncludeArgs(const ArgList &DriverArgs, RocmInstallation->AddHIPIncludeArgs(DriverArgs, CC1Args); } +void toolchains::MinGW::addSYCLIncludeArgs(const ArgList &DriverArgs, + ArgString

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
@@ -,12 +,57 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] [compiler-rt] ohos: make configure fail if LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is OFF (PR #121575)

2025-01-03 Thread Peng Huang via cfe-commits
https://github.com/phuang created https://github.com/llvm/llvm-project/pull/121575 OHOS driver doesn't support old runtime libraries layout, so make cmake configure report error if LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is OFF. [Driver][OHOS] Fix lld link issue The link error is becasue clang rt

[clang] [compiler-rt] ohos: make configure fail if LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is OFF (PR #121575)

2025-01-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Peng Huang (phuang) Changes OHOS driver doesn't support old runtime libraries layout, so make cmake configure report error if LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is OFF. [Driver][OHOS] Fix lld link issue The link error is becasue c

[clang] [clang][NFC][docs] Fix typo in LanguageExtensions (PR #121576)

2025-01-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fabian Ritter (ritter-x2a) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/121576.diff 1 Files Affected: - (modified) clang/docs/LanguageExtensions.rst (+1-1) ``diff diff --git a/clang/docs/LanguageExtension

[clang] [clang][NFC][docs] Fix typo in LanguageExtensions (PR #121576)

2025-01-03 Thread Fabian Ritter via cfe-commits
https://github.com/ritter-x2a created https://github.com/llvm/llvm-project/pull/121576 None >From 67b8039fcd54adc2a599fcf6aa3f62ed8b348f3c Mon Sep 17 00:00:00 2001 From: Fabian Ritter Date: Fri, 3 Jan 2025 09:43:35 -0500 Subject: [PATCH] [clang][NFC][docs] Fix typo in LanguageExtensions ---

[clang] Reapply "[Driver][OHOS] Fix lld link issue for OHOS (#118192)" (PR #120159)

2025-01-03 Thread Peng Huang via cfe-commits
phuang wrote: I created a new [PR](!https://github.com/llvm/llvm-project/pull/121575) , PTAL. Thanks https://github.com/llvm/llvm-project/pull/120159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [compiler-rt] [Driver][OHOS] Fix lld link issue (PR #121575)

2025-01-03 Thread Peng Huang via cfe-commits
https://github.com/phuang edited https://github.com/llvm/llvm-project/pull/121575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [Driver][OHOS] Fix lld link issue (PR #121575)

2025-01-03 Thread Peng Huang via cfe-commits
https://github.com/phuang edited https://github.com/llvm/llvm-project/pull/121575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix unexpanded packs in NTTP type constraints (PR #121296)

2025-01-03 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/121296 >From 102e031cae56c130f48f08bcb316b6f451facf49 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 29 Dec 2024 23:13:52 +0800 Subject: [PATCH 1/5] [Clang] Diagnose unexpanded packs for NTTP type constraints

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
@@ -6089,16 +6090,16 @@ bool TreeTransform::TransformFunctionTypeParams( const FunctionProtoType::ExtParameterInfo *ParamInfos, SmallVectorImpl &OutParamTypes, SmallVectorImpl *PVars, -Sema::ExtParameterInfoBuilder &PInfos, -unsigned *LastParamTransformed)

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2025-01-03 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/102040 >From 88208fd5fa392e9f5701d7548d0dcd24f8274709 Mon Sep 17 00:00:00 2001 From: higher-performance Date: Mon, 5 Aug 2024 15:04:19 -0400 Subject: [PATCH 01/13] Add Clang attribute to ensure that fields a

[clang] 119fc72 - NFC, explicitly specify the -fopenmp lib in spirv-openmp-toolchain.c test

2025-01-03 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2025-01-03T14:16:47+01:00 New Revision: 119fc720a19e047fee59d7f7446c911b158563e0 URL: https://github.com/llvm/llvm-project/commit/119fc720a19e047fee59d7f7446c911b158563e0 DIFF: https://github.com/llvm/llvm-project/commit/119fc720a19e047fee59d7f7446c911b158563e0.diff LO

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-03 Thread Djordje Todorovic via cfe-commits
@@ -4963,6 +4963,10 @@ def msave_restore : Flag<["-"], "msave-restore">, Group, def mno_save_restore : Flag<["-"], "mno-save-restore">, Group, HelpText<"Disable using library calls for save and restore">; } // let Flags = [TargetSpecific] +def mload_store_pairs : Flag<["-"]

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2025-01-03 Thread via cfe-commits
higher-performance wrote: Looks like the tests finally all pass with my last fix. Could we merge? :) Happy new year! https://github.com/llvm/llvm-project/pull/102040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-01-03 Thread Erich Keane via cfe-commits
@@ -179,6 +179,8 @@ def err_opencl_unknown_type_specifier : Error< def warn_unknown_attribute_ignored : Warning< "unknown attribute %0 ignored">, InGroup; +def ext_unknown_attribute_ignored : Extension< + "unknown attribute %0 ignored">, InGroup; erichkeane

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
@@ -687,4 +711,35 @@ class SymbolVisitor { } // namespace clang +// Override the default definition that would use pointer values of SymbolRefs +// to order them, which is unstable due to ASLR. +// Use the SymbolID instead which reflect the order in which the symbols were +//

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
@@ -687,4 +711,35 @@ class SymbolVisitor { } // namespace clang +// Override the default definition that would use pointer values of SymbolRefs +// to order them, which is unstable due to ASLR. +// Use the SymbolID instead which reflect the order in which the symbols were +//

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
@@ -687,4 +711,35 @@ class SymbolVisitor { } // namespace clang +// Override the default definition that would use pointer values of SymbolRefs +// to order them, which is unstable due to ASLR. +// Use the SymbolID instead which reflect the order in which the symbols were +//

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
https://github.com/necto updated https://github.com/llvm/llvm-project/pull/121551 >From 115814c2776b6acc8f4a08ec696a3cb27a7c0ebd Mon Sep 17 00:00:00 2001 From: Arseniy Zaostrovnykh Date: Thu, 2 Jan 2025 09:58:53 +0100 Subject: [PATCH 1/5] Add SymbolID to every SymExpr, not just SymbolData ---

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
necto wrote: > By the way, what fraction of the results is perturbed (replaced with other > random results) when this commit is activated? Did you run any "without this > commit vs with this commit" comparisons? The difference is around 5-10 appearing/disappearing issues, and 50-100 issues wi

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
@@ -56,6 +68,8 @@ class SymExpr : public llvm::FoldingSetNode { Kind getKind() const { return K; } + SymbolID getSymbolID() const { return Sym; } necto wrote: Documented in 355c588f4469 az/order-by-symref-id [NFC] A doc comment explaining the SymExpr::ge

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
https://github.com/necto updated https://github.com/llvm/llvm-project/pull/121551 >From 115814c2776b6acc8f4a08ec696a3cb27a7c0ebd Mon Sep 17 00:00:00 2001 From: Arseniy Zaostrovnykh Date: Thu, 2 Jan 2025 09:58:53 +0100 Subject: [PATCH 1/4] Add SymbolID to every SymExpr, not just SymbolData ---

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread Jason Rice via cfe-commits
@@ -805,7 +805,6 @@ Sema::InstantiatingTemplate::InstantiatingTemplate( SemaRef, CodeSynthesisContext::BuildingDeductionGuides, PointOfInstantiation, InstantiationRange, Entity) {} - ricejasonf wrote: Sorry, `git clang-format` keeps modify

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-03 Thread Jon Roelofs via cfe-commits
jroelofs wrote: IIUC `__MACH__` means "the kernel is Mach, and we're going to be loaded by dyld", and `apple-none-macho` targets is _not_ that. > as Swift expects all MachO targets to have that defined. can you elaborate on that expectation? https://github.com/llvm/llvm-project/pull/120507 __

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread Jason Rice via cfe-commits
@@ -15991,6 +15991,13 @@ TreeTransform::TransformFunctionParmPackExpr(FunctionParmPackExpr *E) { return E; } +template +ExprResult TreeTransform::TransformResolvedUnexpandedPackExpr( +ResolvedUnexpandedPackExpr *E) { + // Default behavior is to do nothing with this tr

[clang] [Clang][ASTMatcher] Add `dependentTemplateSpecializationType` AST mat… (PR #121435)

2025-01-03 Thread via cfe-commits
github-actions[bot] wrote: @caokefan Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang] [Clang][ASTMatcher] Add `dependentTemplateSpecializationType` AST mat… (PR #121435)

2025-01-03 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/121435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d85b22e - [Clang][ASTMatcher] Add `dependentTemplateSpecializationType` matcher (#121435)

2025-01-03 Thread via cfe-commits
Author: kefan cao Date: 2025-01-03T16:32:02-05:00 New Revision: d85b22ed5dbb794835fd4b5166d5bb79ad9e09f2 URL: https://github.com/llvm/llvm-project/commit/d85b22ed5dbb794835fd4b5166d5bb79ad9e09f2 DIFF: https://github.com/llvm/llvm-project/commit/d85b22ed5dbb794835fd4b5166d5bb79ad9e09f2.diff LOG

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Tony Tye via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] Deprecate order file instrumentation (PR #121514)

2025-01-03 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg closed https://github.com/llvm/llvm-project/pull/121514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 432a871 - Deprecate order file instrumentation (#121514)

2025-01-03 Thread via cfe-commits
Author: Ellis Hoag Date: 2025-01-03T11:23:35-08:00 New Revision: 432a871ba8f6a62272a7ef1162305328b0de7802 URL: https://github.com/llvm/llvm-project/commit/432a871ba8f6a62272a7ef1162305328b0de7802 DIFF: https://github.com/llvm/llvm-project/commit/432a871ba8f6a62272a7ef1162305328b0de7802.diff LO

[clang-tools-extra] [clang-tidy] New option `CompilationArgsToRemoveRegex` to remove arguments from the command line (PR #111453)

2025-01-03 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 closed https://github.com/llvm/llvm-project/pull/111453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] Add Target Builtins using Distance ext as an example (PR #121598)

2025-01-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/121598 - Update pr labeler so new SPIRV files get properly labeled. - Add distance target builtin to BuiltinsSPIRV.td. - Update TargetBuiltins.h to account for spirv builtins. - Update clang basic CMakeLists.txt to buil

[clang] [llvm] [SPIRV] Add Target Builtins using Distance ext as an example (PR #121598)

2025-01-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Farzon Lotfi (farzonl) Changes - Update pr labeler so new SPIRV files get properly labeled. - Add distance target builtin to BuiltinsSPIRV.td. - Update TargetBuiltins.h to account for spirv builtins. - Update clang basic CMakeLists.txt to b

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Tony Tye via cfe-commits
https://github.com/t-tye edited https://github.com/llvm/llvm-project/pull/120095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread Jason Rice via cfe-commits
@@ -951,28 +959,130 @@ Sema::ActOnDecompositionDeclarator(Scope *S, Declarator &D, return New; } +namespace { +// CheckBindingsCount +// - Checks the arity of the structured bindings +// - Creates the resolved pack expr if there is +//one +bool CheckBindingsCount(Sema

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread Jason Rice via cfe-commits
https://github.com/ricejasonf edited https://github.com/llvm/llvm-project/pull/121417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/121611 None >From 2de0c4911dfbc67b9492eb4f13bcd162e79c3d37 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Tue, 17 Dec 2024 18:30:23 -0500 Subject: [PATCH 1/2] [HLSL] Move length intrinsic to the header --- clang/

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Farzon Lotfi (farzonl) Changes --- Patch is 29.73 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/121611.diff 14 Files Affected: - (modified) clang/include/clang/Basic/Builtins.td (-6) - (m

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a106ad0f1d0f74fde3591149c63f3e94ec780fef 74ad2ec542078c61064a103e1ea3154057489ccb --e

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread Farzon Lotfi via cfe-commits
@@ -33,6 +41,23 @@ constexpr enable_if_t bit_cast(T F) { return __builtin_bit_cast(U, F); } +template +constexpr enable_if_t::value || is_same::value, T> +length_impl(T X) { + return __builtin_elementwise_abs(X); +} + +template +enable_if_t::value || is_same::value, T> +

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread Farzon Lotfi via cfe-commits
@@ -1,73 +1,151 @@ -// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ -// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ -// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ -// RUN: --check-prefixes=CHECK,NATIVE_HALF -// RUN: %clang_cc1 -

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-03 Thread Shafik Yaghmour via cfe-commits
@@ -33,23 +33,22 @@ Two goo __attribute__((init_priority(2,3))) ( 5, 6 ); // expected-error {{'init_ Two coo[2] __attribute__((init_priority(100))); #if !defined(SYSTEM) - // expected-error@-2 {{'init_priority' attribute requires integer constant between 101 and 65535 incl

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/121611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/121611 >From 2de0c4911dfbc67b9492eb4f13bcd162e79c3d37 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Tue, 17 Dec 2024 18:30:23 -0500 Subject: [PATCH 1/2] [HLSL] Move length intrinsic to the header --- clang/includ

[clang] [clang] Do not serialize function definitions without a body (PR #121550)

2025-01-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Alejandro Álvarez Ayllón (alejandro-alvarez-sonarsource) Changes An instantiated templated function definition may not have a body due to parsing errors inside the templated function. When serializing, an assert is triggered insid

[clang] [clang] Do not serialize function definitions without a body (PR #121550)

2025-01-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alejandro Álvarez Ayllón (alejandro-alvarez-sonarsource) Changes An instantiated templated function definition may not have a body due to parsing errors inside the templated function. When serializing, an assert is triggered inside `ASTRe

[clang] [llvm] [RISCV] Add support of Sdext, Sdtrig extentions (PR #120936)

2025-01-03 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/120936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Do not serialize function definitions without a body (PR #121550)

2025-01-03 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource created https://github.com/llvm/llvm-project/pull/121550 An instantiated templated function definition may not have a body due to parsing errors inside the templated function. When serializing, an assert is triggered inside `ASTRecordWriter::Add

[clang] [clang] Implement __attribute__((format_matches)) (PR #116708)

2025-01-03 Thread via cfe-commits
=?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier Message-ID: In-Reply-To: @@ -595,6 +595,97 @@ ArgType::matchesType(ASTContext &C, QualType argTy) const { llvm_unreachable("Invalid ArgType Kind!"); } +static analyze_format_string::ArgType::MatchKind +integerTypeMat

[clang] [clang] Implement __attribute__((format_matches)) (PR #116708)

2025-01-03 Thread via cfe-commits
=?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier Message-ID: In-Reply-To: apple-fcloutier wrote: I lost commit access during the purge, so either you or @ahatanak will need to press the button for me once we feel good about the change. As a result, there should be no concern that I mi

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread Justin Bogner via cfe-commits
@@ -13,6 +13,14 @@ namespace hlsl { namespace __detail { +template struct is_same { + static const bool value = false; +}; + +template struct is_same { + static const bool value = true; +}; bogner wrote: These seem fine, but we should make sure we're bei

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread Justin Bogner via cfe-commits
@@ -33,6 +41,21 @@ constexpr enable_if_t bit_cast(T F) { return __builtin_bit_cast(U, F); } +template +constexpr enable_if_t::value || is_same::value, T> +length_impl(T X) { + return __builtin_elementwise_abs(X); +} + +template +enable_if_t::value || is_same::value, T> +

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/121611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] disallow attributes after namespace identifier (PR #121614)

2025-01-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/121614 Fixes #121407 >From b8f6ffc0a98a0d3ac55fba4e6ee680f1edea4571 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 4 Jan 2025 02:24:26 +0200 Subject: [PATCH] [Clang] disallow attributes after namespace ident

[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

2025-01-03 Thread Justin Bogner via cfe-commits
@@ -33,6 +41,23 @@ constexpr enable_if_t bit_cast(T F) { return __builtin_bit_cast(U, F); } +template +constexpr enable_if_t::value || is_same::value, T> +length_impl(T X) { + return __builtin_elementwise_abs(X); +} + +template +enable_if_t::value || is_same::value, T> +

[clang] [Clang] disallow attributes after namespace identifier (PR #121614)

2025-01-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #121407 --- Full diff: https://github.com/llvm/llvm-project/pull/121614.diff 4 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modified) clang/include/clang/Basic/DiagnosticParse

[clang] [llvm] [SPIRV] Add Target Builtins using Distance ext as an example (PR #121598)

2025-01-03 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,59 @@ +//===- SemaSPIRV.cpp - Semantic Analysis for SPIRV constructs +//---===// bogner wrote: same here https://github.com/llvm/llvm-project/pull/121598 ___ cfe-commits mailing list cfe-commits@

[clang] [llvm] [SPIRV] Add Target Builtins using Distance ext as an example (PR #121598)

2025-01-03 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. The boilerplate all looks correct to me. https://github.com/llvm/llvm-project/pull/121598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [llvm] [SPIRV] Add Target Builtins using Distance ext as an example (PR #121598)

2025-01-03 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,29 @@ +//===- SemaSPIRV.h - Semantic Analysis for SPIRV constructs +//-===// bogner wrote: clang-format went wrong here https://github.com/llvm/llvm-project/pull/121598 ___ cfe-commits mailin

[clang] [llvm] [SPIRV] Add Target Builtins using Distance ext as an example (PR #121598)

2025-01-03 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/121598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/121521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Justin Bogner via cfe-commits
https://github.com/bogner commented: This basically LGTM but th SV_GroupID.ll test could use a fair amount of cleanup https://github.com/llvm/llvm-project/pull/121521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,82 @@ +; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val %} + +; This file generated from the following command: +; clang -cc1 -t

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Tony Tye via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Joseph Huber via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Tony Tye via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #117268)

2025-01-03 Thread Michael Toguchi via cfe-commits
https://github.com/mdtoguchi updated https://github.com/llvm/llvm-project/pull/117268 >From 3fdc74687dbf6da831a1c27995d9d7fef3a2a51f Mon Sep 17 00:00:00 2001 From: Michael Toguchi Date: Fri, 15 Nov 2024 05:14:21 -0700 Subject: [PATCH 01/10] Reland - [Driver][SYCL] Add initial SYCL offload comp

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-03 Thread via cfe-commits
https://github.com/el-ev updated https://github.com/llvm/llvm-project/pull/121577 >From 5551c179d4b1ed0f41885fc96fa4844c9b0435b5 Mon Sep 17 00:00:00 2001 From: Iris Shi <0...@owo.li> Date: Fri, 3 Jan 2025 23:00:14 +0800 Subject: [PATCH 1/4] fix gnu::init_priority behavior --- clang/include/cla

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Joseph Huber via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Joseph Huber via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Tony Tye via cfe-commits
https://github.com/t-tye edited https://github.com/llvm/llvm-project/pull/120095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Tony Tye via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [llvm] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2025-01-03 Thread M. Zeeshan Siddiqui via cfe-commits
@@ -5565,6 +5565,15 @@ float APFloat::convertToFloat() const { return Temp.getIEEE().convertToFloat(); } +/// Returns true if the semantics can represent all of the values that the other +/// semantics can represent. +/// +/// \param Sem - type float semantics -

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Tony Tye via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [llvm] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2025-01-03 Thread M. Zeeshan Siddiqui via cfe-commits
codemzs wrote: Hi @shafik , it looks like you’re the designated reviewer for C++ standards. Would you mind taking a look at this PR? It has already been through several iterations with @tahonermann, and we’d really appreciate your feedback. Thanks! https://github.com/llvm/llvm-project/pull/785

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Joseph Huber via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread Jason Rice via cfe-commits
https://github.com/ricejasonf updated https://github.com/llvm/llvm-project/pull/121417 >From 3c81c5bd989f26331917f1401becc1cfa7f4a454 Mon Sep 17 00:00:00 2001 From: Jason Rice Date: Thu, 22 Jul 2021 16:46:33 -0700 Subject: [PATCH 1/4] [Clang][P1061] stuctured binding packs --- clang/include/c

[clang-tools-extra] [clang-tidy] Improved readability redundant casting with enums (PR #111424)

2025-01-03 Thread Félix-Antoine Constantin via cfe-commits
felix642 wrote: Closing this PR since I no longer think this is an option that we need. https://github.com/llvm/llvm-project/pull/111424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved readability redundant casting with enums (PR #111424)

2025-01-03 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 closed https://github.com/llvm/llvm-project/pull/111424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-03 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > > > as Swift expects all MachO targets to have that defined. > > > > > > can you elaborate on that expectation? > > [shims/Visibility.h](https://github.com/swiftlang/swift/blob/main/stdlib/public/SwiftShims/swift/shims/Visibility.h#L137) > uses `__MACH__` to figure

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-03 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > > as Swift expects all MachO targets to have that defined. > > can you elaborate on that expectation? [shims/Visibility.h](https://github.com/swiftlang/swift/blob/main/stdlib/public/SwiftShims/swift/shims/Visibility.h#L137) uses `__MACH__` to figure out how to config

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Zhengxing li via cfe-commits
@@ -0,0 +1,82 @@ +; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val %} + +; This file generated from the following command: +; clang -cc1 -t

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Tony Tye via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread Jason Rice via cfe-commits
https://github.com/ricejasonf updated https://github.com/llvm/llvm-project/pull/121417 >From 3c81c5bd989f26331917f1401becc1cfa7f4a454 Mon Sep 17 00:00:00 2001 From: Jason Rice Date: Thu, 22 Jul 2021 16:46:33 -0700 Subject: [PATCH 1/5] [Clang][P1061] stuctured binding packs --- clang/include/c

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Zhengxing li via cfe-commits
https://github.com/lizhengxing updated https://github.com/llvm/llvm-project/pull/121521 >From 21114c408baaa9309e3370d46a4ee196cc4f714a Mon Sep 17 00:00:00 2001 From: Zhengxing Li Date: Thu, 2 Jan 2025 12:30:18 -0800 Subject: [PATCH 1/2] [HLSL][SPIR-V] implement SV_GroupID semantic lowering The

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Zhengxing li via cfe-commits
@@ -0,0 +1,82 @@ +; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val %} + +; This file generated from the following command: +; clang -cc1 -t

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2025-01-03 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/120055 >From 8b2dc9adf4fae2065823e5beb3a1cd851686913c Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Mon, 16 Dec 2024 08:24:14 +0100 Subject: [PATCH 1/8] [clang-tidy] Add readability-string-view-substr check

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2025-01-03 Thread Denis Mikhailov via cfe-commits
denzor200 wrote: > Wouldn't that be a runtime check, and thus not something clang-tidy can do > without significant data flow analysis effort? I'm not experienced enough in clang-tidy internals, but I believe it will not be a serious challenge to check for having `assert(sp.use_count() == 1)`

[clang] [clang-cl] [Sema] Support MSVC non-const lvalue to user-defined temporary reference (PR #99833)

2025-01-03 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/99833 >From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Fri, 21 Jun 2024 20:37:40 -0700 Subject: [PATCH 01/26] Support MSVC lvalue to temporary reference binding --- clang/

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
https://github.com/necto edited https://github.com/llvm/llvm-project/pull/121551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Stabilize path-constraint order by using alloc IDs (PR #121347)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
@@ -427,8 +434,8 @@ class BinarySymExprImpl : public BinarySymExpr { public: BinarySymExprImpl(LHSTYPE lhs, BinaryOperator::Opcode op, RHSTYPE rhs, -QualType t) - : BinarySymExpr(ClassKind, op, t), LHS(lhs), RHS(rhs) { +QualType t

[clang] [clang][analyzer] Stabilize path-constraint order by using alloc IDs (PR #121347)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
@@ -401,7 +401,22 @@ class RangeSet { friend class Factory; }; -using ConstraintMap = llvm::ImmutableMap; +struct ConstraintKVInfo : llvm::ImutKeyValueInfo { + static inline bool isEqual(key_type_ref L, key_type_ref R) { +return L->getAllocID() == R->getAllocID(); + }

  1   2   3   >