github-actions[bot] wrote:
@paparodeo Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a buil
ldionne wrote:
Ah, I didn't realize this was only required for much older compilers. In that
case, indeed we don't support GCC 8 so we probably don't want to merge this.
https://github.com/llvm/llvm-project/pull/117491
___
cfe-commits mailing list
cfe
Zentrik wrote:
Based on https://github.com/WAVM/WAVM/pull/266#issue-583580780 and
https://en.cppreference.com/w/cpp/types/integer#Notes this might have been
fixed in glibc 2.18.
https://github.com/llvm/llvm-project/pull/117491
___
cfe-commits mailin
https://github.com/vinay-deshmukh updated
https://github.com/llvm/llvm-project/pull/116462
>From daddb9e13db6ca8373dc7298d17aa36a03014aeb Mon Sep 17 00:00:00 2001
From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com>
Date: Fri, 15 Nov 2024 07:37:17 -0500
Subject: [PATCH 1/9] [a
https://github.com/momchil-velikov created
https://github.com/llvm/llvm-project/pull/118125
None
>From 3a9643e6c2d61eae2e23df42c19b1410d4a5fcc5 Mon Sep 17 00:00:00 2001
From: Momchil Velikov
Date: Thu, 21 Nov 2024 11:21:29 +
Subject: [PATCH 1/3] FP8 CVT/CVTL
---
clang/include/clang/Basic
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Momchil Velikov (momchil-velikov)
Changes
---
Patch is 33.78 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/118124.diff
9 Files Affected:
- (modified) clang/include/clang/Basic/arm_sve.td (
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Momchil Velikov (momchil-velikov)
Changes
---
Patch is 33.78 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/118124.diff
9 Files Affected:
- (modified) clang/include/clang/Basic/ar
https://github.com/momchil-velikov created
https://github.com/llvm/llvm-project/pull/118123
None
>From 3a9643e6c2d61eae2e23df42c19b1410d4a5fcc5 Mon Sep 17 00:00:00 2001
From: Momchil Velikov
Date: Thu, 21 Nov 2024 11:21:29 +
Subject: [PATCH] FP8 CVT/CVTL
---
clang/include/clang/Basic/arm
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-backend-aarch64
Author: Momchil Velikov (momchil-velikov)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/118123.diff
7 Files Affected:
- (modified) clang/include/clang/Basic/arm_sve.td (+10)
- (added) cl
llvmbot wrote:
@llvm/pr-subscribers-llvm-ir
Author: Momchil Velikov (momchil-velikov)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/118123.diff
7 Files Affected:
- (modified) clang/include/clang/Basic/arm_sve.td (+10)
- (added) clang/test/CodeGen/AArch64/fp8-intrin
@@ -4129,10 +4130,8 @@ void Driver::handleArguments(Compilation &C,
DerivedArgList &Args,
}
}
- // If we are linking, claim any options which are obviously only used for
- // compilation.
- // FIXME: Understand why the last Phase List length is used here.
- if (Fina
giordano wrote:
Based on
https://github.com/JuliaPackaging/Yggdrasil/pull/9861/files#diff-812a6db0df5a0d42010930d41a801e33e89c6064172903e5aacb88a7c704def2R7
this came up with gcc 10
https://github.com/llvm/llvm-project/pull/117491
___
cfe-commits mai
Author: Brian Cain
Date: 2024-11-29T16:42:44-06:00
New Revision: 2dc0de753b6df83e35f3d98e0e6a26c95e3399c0
URL:
https://github.com/llvm/llvm-project/commit/2dc0de753b6df83e35f3d98e0e6a26c95e3399c0
DIFF:
https://github.com/llvm/llvm-project/commit/2dc0de753b6df83e35f3d98e0e6a26c95e3399c0.diff
LO
https://github.com/androm3da closed
https://github.com/llvm/llvm-project/pull/117338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Haojian Wu
Date: 2024-11-29T23:48:09+01:00
New Revision: 52690db47da36a739ee506d3b3a7457fb918dc1e
URL:
https://github.com/llvm/llvm-project/commit/52690db47da36a739ee506d3b3a7457fb918dc1e
DIFF:
https://github.com/llvm/llvm-project/commit/52690db47da36a739ee506d3b3a7457fb918dc1e.diff
LO
https://github.com/hokein closed
https://github.com/llvm/llvm-project/pull/118088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
topperc wrote:
> LGTM.
>
>
>
> I note Craig has questions about the spec, we will ensure those are relayed
> to the spec authors, but they don't relate to encoding/assembling problems,
> so I'm not sure if they should block landing this.
I don't consider my questions blocking. I just didn't
Author: Qizhi Hu
Date: 2024-11-30T08:29:28+08:00
New Revision: 04ab599363eacc156e11238da9343c1d9d90db56
URL:
https://github.com/llvm/llvm-project/commit/04ab599363eacc156e11238da9343c1d9d90db56
DIFF:
https://github.com/llvm/llvm-project/commit/04ab599363eacc156e11238da9343c1d9d90db56.diff
LOG:
https://github.com/jcsxky closed
https://github.com/llvm/llvm-project/pull/117734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
charan-003 wrote:
hi @cor3ntin made necessary updates to ParseExprCXX.cpp, but now ten tests are
failing. Could you kindly provide on how to debug them? What are the main areas
in ParseExprCXX.cpp that I should concentrate on while debugging these kinds of
problems?
https://github.com/llvm/ll
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/leijurv edited
https://github.com/llvm/llvm-project/pull/118046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/leijurv edited
https://github.com/llvm/llvm-project/pull/118046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/leijurv edited
https://github.com/llvm/llvm-project/pull/118046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/leijurv edited
https://github.com/llvm/llvm-project/pull/118046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/leijurv edited
https://github.com/llvm/llvm-project/pull/118046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From b9886635c250fe765bf35c6b0e785f55b0749d52 Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Thu, 28 Nov 2024 21:44:50 -0600
Subject: [PATCH 01/10] BreakBeforeTemplateClose
---
clang/docs/ClangFormatStyleOption
@@ -1250,6 +1273,7 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) {
if (!ContainsError)
ContainsError = loadConfigFiles();
bool HasConfigFile = !ContainsError && (CfgOptions.get() != nullptr);
+ bool HasConfigLinkerIn = !ContainsError && (CfgLinkerInputs.ge
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From b9886635c250fe765bf35c6b0e785f55b0749d52 Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Thu, 28 Nov 2024 21:44:50 -0600
Subject: [PATCH 1/9] BreakBeforeTemplateClose
---
clang/docs/ClangFormatStyleOptions.
@@ -1250,6 +1273,7 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) {
if (!ContainsError)
ContainsError = loadConfigFiles();
bool HasConfigFile = !ContainsError && (CfgOptions.get() != nullptr);
+ bool HasConfigLinkerIn = !ContainsError && (CfgLinkerInputs.ge
@@ -82,3 +82,35 @@
// CHECK-TWO-CONFIGS: -isysroot
// CHECK-TWO-CONFIGS-SAME: /opt/data
// CHECK-TWO-CONFIGS-SAME: -Wall
+
+//--- The linker input flags should be moved to the end of input list and
appear only when linking.
+// RUN: %clang --target=aarch64-unknown-linux-gnu --
@@ -1834,6 +1834,14 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions
&Opts, ArgList &Args,
Opts.setInlining(CodeGenOptions::NormalInlining);
}
+ // If we have specified -Og and have not explicitly set
-fno-extend-lifetimes,
+ // then default to -fextend-li
https://github.com/MaskRay requested changes to this pull request.
.
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From 79b3767b39d6d5d5c21bb461fb619651fb2443c5 Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:54:36 -0600
Subject: [PATCH] [clang-format] Add BreakBeforeTemplateClose option
---
clang/docs/Cl
https://github.com/leijurv edited
https://github.com/llvm/llvm-project/pull/118046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
maurer wrote:
I'm not sure I buy the argument that cross-arity functions are significantly
more exploitable than same-arity mismatches.
Restating your argument to make sure I've understood it correctly: When an
attacker swaps in a function pointer of higher arity, a dead variable (or even
a l
Author: Fangrui Song
Date: 2024-11-29T21:03:38-08:00
New Revision: 691e55643daa3470ff19b02a55e3e2503d2de0c9
URL:
https://github.com/llvm/llvm-project/commit/691e55643daa3470ff19b02a55e3e2503d2de0c9
DIFF:
https://github.com/llvm/llvm-project/commit/691e55643daa3470ff19b02a55e3e2503d2de0c9.diff
https://github.com/MaskRay requested changes to this pull request.
Using unique_ptr for `Args` is good, but I am not sure about shared_ptr for
TranslatedArgs. There is no shared_ptr usage in clangDriver and we want to keep
avoiding it.
https://github.com/llvm/llvm-project/pull/116406
_
https://github.com/leijurv edited
https://github.com/llvm/llvm-project/pull/118046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
> As a reviewer that means we have to download the review, rebuild the rst then
> check it. I don't quite understand the problem we are trying to solve here?
> Given that the python script unpacks the Format.h and makes the rst I would
> prefer to see the finished rst as part of
erichkeane wrote:
Hmmm... See the comment on the issue. I'll have to look more closely, but this
very well might be the incorrect change. This perhaps needs a revert.
https://github.com/llvm/llvm-project/pull/117450
___
cfe-commits mailing list
cfe-co
MaskRay wrote:
As I'm not a Windows developer, I defer to other reviewers' expertise on MSVC's
PGO/LTO feature.
However, to be honest, I'm unsure about the value of porting the strings given
the large feature differences between Clang and MSVC on PGO and LTO.
`clang -flto -c` output is LLVM bi
@@ -77,6 +77,12 @@ static unsigned char dosProgram[] = {
static_assert(sizeof(dosProgram) % 8 == 0,
"DOSProgram size must be multiple of 8");
+static char ltcg[] = "LTCG";
MaskRay wrote:
`constexpr char ...[]`
constexpr/const make this internal
MaskRay wrote:
(I am not familiar with macOS and I'll defer the decision to Apple folks.
I agree with James that this PR might break users.
You probably want a different way to handle default sysroot in homebrew.
)
https://github.com/llvm/llvm-project/pull/115993
___
=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To:
MaskRay wrote:
> I think the regex solution might be brittle/not clean from a user
> perspective, with potential for a small amount of maintenance. Instead, I
> would also suggest a flag to error, warn, or silence these, defaulting
https://github.com/chouzz updated
https://github.com/llvm/llvm-project/pull/113669
>From 02124e4cfd7dbc395d4974c7561d5f110980aaa5 Mon Sep 17 00:00:00 2001
From: chouzz
Date: Fri, 25 Oct 2024 17:42:04 +0800
Subject: [PATCH 1/5] [clangd] Support symbolTags for document symbol
---
clang-tools-ex
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From de78cfbdefd90ce2427b552c941c613f93c9fd9a Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:35:06 -0600
Subject: [PATCH] BreakBeforeTemplateClose
---
clang/docs/ClangFormatStyleOptions.rst
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From de78cfbdefd90ce2427b552c941c613f93c9fd9a Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:35:06 -0600
Subject: [PATCH] BreakBeforeTemplateClose
---
clang/docs/ClangFormatStyleOptions.rst
https://github.com/leijurv edited
https://github.com/llvm/llvm-project/pull/118046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From 217f80766d1eeeab4195f5d79cfed79c06657166 Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:54:36 -0600
Subject: [PATCH] BreakBeforeTemplateClose
---
clang/docs/ClangFormatStyleOptions.rst
https://github.com/leijurv ready_for_review
https://github.com/llvm/llvm-project/pull/118046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,30 @@
+/// Check that we generate fake uses only when -fextend-lifetimes is set and we
+/// are not setting optnone, or when we have optimizations set to -Og and we
have
+/// not passed -fno-extend-lifetimes.
+// RUN: %clang_cc1 -emit-llvm -disable-llvm-passes -O0 -fex
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: leijurv (leijurv)
Changes
In clang-format, multiline templates have the `>` on the same line as the
last parameter:
```c++
template<
typename Foo,
typename Bar,
typename Baz>
void foo() {
```
I would like to add an opt
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From 4df01e5c4b5a5b4872c9d4f28c5bdce60ad79b84 Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:54:36 -0600
Subject: [PATCH] [clang-format] Add BreakBeforeTemplateClose option
---
clang/docs/Cl
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/118154
This patch adds a lit test to clang format to ensure that the
ClangFormatStyleOptions doc page has been updated appropriately. The test just
runs the automatic update script and diffs the outputs to ensu
boomanaiden154 wrote:
> Whenever I review a pull request that has edited Format.h, I always fetch the
> PR and run the python script to ensure that the generated rst file matches
> the one in git. I don't think there's a way around that.
Thinking about this a bit more, I think we can probably
https://github.com/lenary approved this pull request.
LGTM.
I note Craig has questions about the spec, we will ensure those are relayed to
the spec authors, but they don't relate to encoding/assembling problems, so I'm
not sure if they should block landing this.
https://github.com/llvm/llvm-p
@@ -50,20 +50,30 @@ using TypeSpec = std::string;
namespace {
class SVEType {
- bool Float, Signed, Immediate, Void, Constant, Pointer, BFloat, MFloat;
- bool DefaultType, IsScalable, Predicate, PredicatePattern, PrefetchOp,
- Svcount;
+
+ enum TypeKind {
+Void,
+
@@ -336,6 +336,40 @@ Improvements to Clang's diagnostics
local variables passed to function calls using the ``[[clang::musttail]]``
attribute.
+- The Thread Safety Analysis (#GH110523) now supports passing scoped
capabilities into functions:
+ an attribute on the scoped
https://github.com/aaronpuchert commented:
@AaronBallman, please also have a look at the Release Note.
https://github.com/llvm/llvm-project/pull/110523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -336,6 +336,40 @@ Improvements to Clang's diagnostics
local variables passed to function calls using the ``[[clang::musttail]]``
attribute.
+- The Thread Safety Analysis (#GH110523) now supports passing scoped
capabilities into functions:
+ an attribute on the scoped
@@ -336,6 +336,40 @@ Improvements to Clang's diagnostics
local variables passed to function calls using the ``[[clang::musttail]]``
attribute.
+- The Thread Safety Analysis (#GH110523) now supports passing scoped
capabilities into functions:
+ an attribute on the scoped
https://github.com/aaronpuchert edited
https://github.com/llvm/llvm-project/pull/110523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vabridgers
Date: 2024-11-29T17:38:59-06:00
New Revision: 8ac2b77a11c9db9879557ce1c26e38628e1ef45f
URL:
https://github.com/llvm/llvm-project/commit/8ac2b77a11c9db9879557ce1c26e38628e1ef45f
DIFF:
https://github.com/llvm/llvm-project/commit/8ac2b77a11c9db9879557ce1c26e38628e1ef45f.diff
LO
https://github.com/vabridgers closed
https://github.com/llvm/llvm-project/pull/114715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1898,6 +1882,56 @@ static Instruction *foldSelectICmpEq(SelectInst &SI,
ICmpInst *ICI,
return nullptr;
}
+/// Fold `X Pred C2 ? X BOp C1 : C2 BOp C1` to `min/max(X, C2) BOp C1`.
+/// This allows for better canonicalization.
+static Value *foldSelectWithConstOpToBinOp(IC
https://github.com/veera-sivarajan updated
https://github.com/llvm/llvm-project/pull/116888
>From 77c2b799a067270ba23dde2cd3b7324c9c26b362 Mon Sep 17 00:00:00 2001
From: Veera
Date: Thu, 28 Nov 2024 18:07:30 +
Subject: [PATCH 1/2] Add Test
---
.../InstCombine/canonicalize-const-to-bop.ll
https://github.com/dtcxzyw approved this pull request.
LGTM. Thank you!
Please wait for additional approval from other reviewers :)
https://github.com/llvm/llvm-project/pull/116888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From b9886635c250fe765bf35c6b0e785f55b0749d52 Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Thu, 28 Nov 2024 21:44:50 -0600
Subject: [PATCH 1/6] BreakBeforeTemplateClose
---
clang/docs/ClangFormatStyleOptions.
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From b9886635c250fe765bf35c6b0e785f55b0749d52 Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Thu, 28 Nov 2024 21:44:50 -0600
Subject: [PATCH 1/8] BreakBeforeTemplateClose
---
clang/docs/ClangFormatStyleOptions.
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From b9886635c250fe765bf35c6b0e785f55b0749d52 Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Thu, 28 Nov 2024 21:44:50 -0600
Subject: [PATCH 1/7] BreakBeforeTemplateClose
---
clang/docs/ClangFormatStyleOptions.
@@ -82,3 +82,35 @@
// CHECK-TWO-CONFIGS: -isysroot
// CHECK-TWO-CONFIGS-SAME: /opt/data
// CHECK-TWO-CONFIGS-SAME: -Wall
+
+//--- The linker input flags should be moved to the end of input list and
appear only when linking.
+// RUN: %clang --target=aarch64-unknown-linux-gnu --
@@ -82,3 +82,35 @@
// CHECK-TWO-CONFIGS: -isysroot
// CHECK-TWO-CONFIGS-SAME: /opt/data
// CHECK-TWO-CONFIGS-SAME: -Wall
+
+//--- The linker input flags should be moved to the end of input list and
appear only when linking.
+// RUN: %clang --target=aarch64-unknown-linux-gnu --
chouzz wrote:
@travkin79
Are you using the latesed commit? It works in my local clangd with given
example.
```
I[11:05:17.623] --> reply:textDocument/documentSymbol(11) 3 ms
V[11:05:17.624] >>> {"id":11,"jsonrpc":"2.0","result":[{"detail":"const
int","kind":13,"name":"g_var","range":{"end":{"c
@@ -1062,6 +1062,16 @@ bool Driver::readConfigFile(StringRef FileName,
for (Arg *A : *NewOptions)
A->claim();
+ std::unique_ptr NewLinkerIns =
std::make_unique();
MaskRay wrote:
`auto` since RHS makes the type clear.
https://github.com/llvm/llvm-proj
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/115375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -84,9 +84,15 @@
/// Check -Xopenmp-target triggers error when an option requiring arguments is
passed to it.
// RUN: not %clang -### -no-canonical-prefixes -fopenmp=libomp
-fopenmp-targets=powerpc64le-ibm-linux-gnu -Xopenmp-target -Xopenmp-target
-mcpu=pwr8 %s 2>&1 \
-
201 - 278 of 278 matches
Mail list logo
