[clang] ed1d90c - [clang][NFC] simplify the unset check in `ParseLabeledStatement` (#117430)

2024-11-23 Thread via cfe-commits
Author: Congcong Cai Date: 2024-11-24T10:59:41+08:00 New Revision: ed1d90ca11b1834e667e17255ba2ecf6fe305e8c URL: https://github.com/llvm/llvm-project/commit/ed1d90ca11b1834e667e17255ba2ecf6fe305e8c DIFF: https://github.com/llvm/llvm-project/commit/ed1d90ca11b1834e667e17255ba2ecf6fe305e8c.diff

[clang] [clang][NFC] simplify the unset check in `ParseLabeledStatement` (PR #117430)

2024-11-23 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/117430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 68a48ec - [clang][analysis][NFC]place the comment to correct position (#117467)

2024-11-23 Thread via cfe-commits
Author: Congcong Cai Date: 2024-11-24T14:45:59+08:00 New Revision: 68a48ec90fb6609b964addcc99a55d16eee884a0 URL: https://github.com/llvm/llvm-project/commit/68a48ec90fb6609b964addcc99a55d16eee884a0 DIFF: https://github.com/llvm/llvm-project/commit/68a48ec90fb6609b964addcc99a55d16eee884a0.diff

[clang] [clang][analysis][NFC]place the comment to correct position (PR #117467)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/117467.diff 1 Files Affected: - (modified) clang/lib/Analysis/ExprMutationAnalyzer.cpp (+1-1) ``diff diff --git a/clang/lib/Analysis

[clang] [clang][analysis][NFC]place the comment to correct position (PR #117467)

2024-11-23 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/117467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SanitizerCoverage] Add gated tracing callbacks support to trace-cmp (PR #113227)

2024-11-23 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/113227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analysis][NFC]place the comment to correct position (PR #117467)

2024-11-23 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/117467 None >From adfb09e1b3fa69ce0f9a8350fe74c0781d1f7b78 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sun, 24 Nov 2024 14:45:15 +0800 Subject: [PATCH] [clang][analysis][NFC]place the comment to correct posi

[clang] [AST] Migrate away from PointerUnion::{is, get} (NFC) (PR #117469)

2024-11-23 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/117469 Note that PointerUnion::{is,get} have been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast I'm not touching

[clang] [AST] Migrate away from PointerUnion::{is, get} (NFC) (PR #117469)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::{is,get} have been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast I'm n

[clang] 14b9ca3 - [Sema] Fix a warning

2024-11-23 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-11-23T10:29:11-08:00 New Revision: 14b9ca3f38494bbd03709188b6e73c06ab84cd15 URL: https://github.com/llvm/llvm-project/commit/14b9ca3f38494bbd03709188b6e73c06ab84cd15 DIFF: https://github.com/llvm/llvm-project/commit/14b9ca3f38494bbd03709188b6e73c06ab84cd15.diff L

[clang] [llvm] Revert "[HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (#114148)" (PR #117448)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-directx Author: Helena Kotas (hekota) Changes This reverts commit 94bde8cdc39ff7e9c59ee0cd5edda882955242aa. --- Patch is 44.64 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/117448.diff 14 Files Af

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

2024-11-23 Thread Mészáros Gergely via cfe-commits
Maetveis wrote: Thanks! I added @AaronBallman, as a reviewer just to make sure I didn't miss anything, as I don't consider myself an expert when it comes to frontend. @AaronBallman I think you can merge if everything looks okay, I'm pretty sure @whiteio does not have commit rights. https://gi

[clang] [llvm] Revert "[HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (#114148)" (PR #117448)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: Helena Kotas (hekota) Changes This reverts commit 94bde8cdc39ff7e9c59ee0cd5edda882955242aa. --- Patch is 44.64 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/117448.diff 14 Files Affected:

[clang] [llvm] Revert "[HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (#114148)" (PR #117448)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Helena Kotas (hekota) Changes This reverts commit 94bde8cdc39ff7e9c59ee0cd5edda882955242aa. --- Patch is 44.64 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/117448.diff 14 Files Affe

[clang] [llvm] Revert "[HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (#114148)" (PR #117448)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Helena Kotas (hekota) Changes This reverts commit 94bde8cdc39ff7e9c59ee0cd5edda882955242aa. --- Patch is 44.64 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/117448.diff 14 Files Affected: -

[clang] [llvm] Revert "[HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (#114148)" (PR #117448)

2024-11-23 Thread Helena Kotas via cfe-commits
https://github.com/hekota created https://github.com/llvm/llvm-project/pull/117448 This reverts commit 94bde8cdc39ff7e9c59ee0cd5edda882955242aa. >From 4edec79a02e7d32fe16e257f6151669a2f009d85 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Sat, 23 Nov 2024 11:43:29 -0800 Subject: [PATCH] Rev

[clang] dc4c8de - Revert "[HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (#114148)" (#117448)

2024-11-23 Thread via cfe-commits
Author: Helena Kotas Date: 2024-11-23T12:02:07-08:00 New Revision: dc4c8de179ff2237378bd42a2b650fad2f7b1940 URL: https://github.com/llvm/llvm-project/commit/dc4c8de179ff2237378bd42a2b650fad2f7b1940 DIFF: https://github.com/llvm/llvm-project/commit/dc4c8de179ff2237378bd42a2b650fad2f7b1940.diff

[clang] [llvm] Revert "[HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (#114148)" (PR #117448)

2024-11-23 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/117448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-11-23 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 2b526821d4e70f3ea83f95d25f804d9fbcf82612 Mon Sep 17 00:00:00 2001 From: cqwrteur <100043421+trcrsi...@users.noreply.github.com> Date: Sat, 1 Jun 2024 02:55:50 -0400 Subject: [PATCH] [libunwind][libcxx][lib

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-23 Thread via cfe-commits
https://github.com/xtexChooser created https://github.com/llvm/llvm-project/pull/117458 This fixes #117438. If paths in dependency file are not absoulte, make (or ninja) will canonicalize them. While their canonicalization does not involves symbolic links expansion (for IO performance concern

[clang] [clang][NFC] simplify the unset check in `ParseLabeledStatement` (PR #117430)

2024-11-23 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 10 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/9048 Here is the r

[clang] Revert "[AIX] Fix AIX BuildBot failure as AIX linker doesn't support version script." (PR #117444)

2024-11-23 Thread Daniel Chen via cfe-commits
https://github.com/DanielCChen approved this pull request. LGTM. Thanks for reverting it. https://github.com/llvm/llvm-project/pull/117444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-11-23 Thread Alexander Richardson via cfe-commits
arichardson wrote: Could you address the raised issues instead of constantly updating the branch? This wastes CI resources and spams everyone subscribed to this PR. Please feel free to reopen it once you have addressed the issues. https://github.com/llvm/llvm-project/pull/79667 ___

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-23 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 3a9de0b6c2b3f8283080cd1f051fca5577116e59 Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-11-23 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson closed https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: xtex (xtexChooser) Changes This fixes #117438. If paths in dependency file are not absoulte, make (or ninja) will canonicalize them. While their canonicalization does not involves symbolic links expansion (for IO performance concerns), l

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-23 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-23 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From eb468c6e56ca906925d5ebd1a13cc510d86754d5 Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-11-23 Thread Scott Constable via cfe-commits
scottconstable wrote: > > > > @phoebewang and @lvwr I also noticed that there is this code in LLVM: > > > > https://github.com/llvm/llvm-project/blob/9ba6672b9f0e82a1f6d4100dc832c84447ea545c/llvm/lib/Transforms/Utils/ModuleUtils.cpp#L202-L214 > > > > > > > > . As far as I can tell, this code is

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-11-23 Thread Scott Constable via cfe-commits
@@ -208,10 +209,34 @@ void llvm::setKCFIType(Module &M, Function &F, StringRef MangledType) { std::string Type = MangledType.str(); if (M.getModuleFlag("cfi-normalize-integers")) Type += ".normalized"; + + uint32_t OutHash = static_cast(llvm::xxHash64(Type)); + auto

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-11-23 Thread Scott Constable via cfe-commits
https://github.com/scottconstable updated https://github.com/llvm/llvm-project/pull/117121 >From b787d6d7a9c0904c5e47e32556103b8a5220a7d1 Mon Sep 17 00:00:00 2001 From: Scott D Constable Date: Tue, 19 Nov 2024 15:51:05 -0800 Subject: [PATCH] Enhance KCFI type IDs with a 3-bit arity indicator.

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-11-23 Thread Scott Constable via cfe-commits
@@ -208,10 +209,34 @@ void llvm::setKCFIType(Module &M, Function &F, StringRef MangledType) { std::string Type = MangledType.str(); if (M.getModuleFlag("cfi-normalize-integers")) Type += ".normalized"; + + uint32_t OutHash = static_cast(llvm::xxHash64(Type)); + auto

[clang] [llvm] [InstCombine] Fold `X > C2 ? X + C1 : C2 + C1` to `max(X, C2) + C1` (PR #116888)

2024-11-23 Thread via cfe-commits
https://github.com/veera-sivarajan updated https://github.com/llvm/llvm-project/pull/116888 >From 4fe3c73cdfd89eb08b9491774e08fa5d3d48d26b Mon Sep 17 00:00:00 2001 From: Veera Date: Thu, 21 Nov 2024 20:55:55 + Subject: [PATCH 1/2] Add Test --- .../InstCombine/canonicalize-const-to-bop.ll

[clang] [llvm] [InstCombine] Fold `X > C2 ? X + C1 : C2 + C1` to `max(X, C2) + C1` (PR #116888)

2024-11-23 Thread via cfe-commits
veera-sivarajan wrote: > The more idiomatic way to handle this is to have something like if > (match(FalseVal, m_Constant())) { std::swap(TrueVal, FalseVal); Pred = > ICmpInst::getInversePredicate(Pred); } and then you no longer have to deal > with which operand the constant is in. Thank you

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-23 Thread via cfe-commits
vabridgers wrote: Ping! Any more comments on this change? Thanks https://github.com/llvm/llvm-project/pull/114715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] prevent errors for deduction guides using deduced type aliases (PR #117450)

2024-11-23 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/117450 Fixes #54909 >From 5212f12874a859a9f7b6c662402aa2171006d011 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 24 Nov 2024 00:19:06 +0200 Subject: [PATCH] [Clang] prevent errors for deduction guides using

[clang] [Clang] prevent errors for deduction guides using deduced type aliases (PR #117450)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #54909 --- Full diff: https://github.com/llvm/llvm-project/pull/117450.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modified) clang/lib/Sema/SemaDeclCXX.cpp (+5-1) - (

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-11-23 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 2b526821d4e70f3ea83f95d25f804d9fbcf82612 Mon Sep 17 00:00:00 2001 From: cqwrteur <100043421+trcrsi...@users.noreply.github.com> Date: Sat, 1 Jun 2024 02:55:50 -0400 Subject: [PATCH] [libunwind][libcxx][lib

[libunwind] [libunwind] Fix compilation for the x32 ABI. (PR #116608)

2024-11-23 Thread Alex Rønne Petersen via cfe-commits
https://github.com/alexrp updated https://github.com/llvm/llvm-project/pull/116608 From dfcfbd6b9fbcd92326192677ba8e73d195719300 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?= Date: Mon, 18 Nov 2024 13:12:30 +0100 Subject: [PATCH] [libunwind] Fix compilation for the x32

[clang] [llvm] [LoongArch] Support LA V1.1 feature ld-seq-sa that don't generate dbar 0x700. (PR #116762)

2024-11-23 Thread Yingwei Zheng via cfe-commits
@@ -2011,8 +2011,9 @@ const StringMap sys::getHostCPUFeatures() { const StringMap sys::getHostCPUFeatures() { unsigned long hwcap = getauxval(AT_HWCAP); bool HasFPU = hwcap & (1UL << 3); // HWCAP_LOONGARCH_FPU - uint32_t cpucfg2 = 0x2; + const uint32_t cpucfg2 = 0x2, cpuc

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-11-23 Thread Phoebe Wang via cfe-commits
@@ -208,10 +209,34 @@ void llvm::setKCFIType(Module &M, Function &F, StringRef MangledType) { std::string Type = MangledType.str(); if (M.getModuleFlag("cfi-normalize-integers")) Type += ".normalized"; + + uint32_t OutHash = static_cast(llvm::xxHash64(Type)); + auto

[clang] Add an off-by-default warning to complain about MSVC bitfield padding (PR #117428)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oliver Hunt (ojhunt) Changes This just adds a warning for bitfields placed next to other bitfields where the underlying type has different storage. Under the MS struct bitfield packing ABI such bitfields are not packed. --- Full diff: ht

[clang] [RFC] Initial implementation of P2719 (PR #113510)

2024-11-23 Thread Oliver Hunt via cfe-commits
ojhunt wrote: This has been tentatively approved C++26 - CWG didn't have time to look at it this week but EWG and SG23 have approved it. I did spend some time discussing semantics with a couple of folk in EWG and CWG and the feedback was fairly strongly on the side of "the operator delete used

[clang] [libcxx] [Clang] Add __is_invocable_r and __is_nothrow_invocable_r (PR #81213)

2024-11-23 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/81213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] aa2d084 - [clang-format][NFC] Reformat testcases added in 0ff8b7916050

2024-11-23 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-11-23T06:31:14-08:00 New Revision: aa2d084f9a68f041a42e4df84e11d769a7be34a6 URL: https://github.com/llvm/llvm-project/commit/aa2d084f9a68f041a42e4df84e11d769a7be34a6 DIFF: https://github.com/llvm/llvm-project/commit/aa2d084f9a68f041a42e4df84e11d769a7be34a6.diff LOG:

[clang] Add an off-by-default warning to complain about MSVC bitfield padding (PR #117428)

2024-11-23 Thread Oliver Hunt via cfe-commits
ojhunt wrote: Oh, my goal for this warning is to have us turn it on in the llvm+clang builds, so we can then move away from endless use of unsigned bitfields and just use enums as nature intended :D (cc @AaronBallman ) https://github.com/llvm/llvm-project/pull/117428 __

[clang] [clang-format] Stop crashing on slightly off Verilog module headers (PR #116000)

2024-11-23 Thread Owen Pan via cfe-commits
@@ -2598,6 +2598,20 @@ TEST_F(TokenAnnotatorTest, UnderstandsVerilogOperators) { Tokens = Annotate("x = '{\"\"};"); ASSERT_EQ(Tokens.size(), 8u) << Tokens; EXPECT_TOKEN(Tokens[4], tok::string_literal, TT_Unknown); + + // Module headers. + Tokens = Annotate("module x();\

[clang] [clang-format] Stop crashing on slightly off Verilog module headers (PR #116000)

2024-11-23 Thread Owen Pan via cfe-commits
@@ -2598,6 +2598,20 @@ TEST_F(TokenAnnotatorTest, UnderstandsVerilogOperators) { Tokens = Annotate("x = '{\"\"};"); ASSERT_EQ(Tokens.size(), 8u) << Tokens; EXPECT_TOKEN(Tokens[4], tok::string_literal, TT_Unknown); + + // Module headers. + Tokens = Annotate("module x();\

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

2024-11-23 Thread Chris White via cfe-commits
https://github.com/whiteio updated https://github.com/llvm/llvm-project/pull/116871 >From ad14635ab12eb81a841db885962c95911722e4f2 Mon Sep 17 00:00:00 2001 From: Chris White Date: Tue, 19 Nov 2024 20:06:28 + Subject: [PATCH 1/3] [Clang] Fix -Wunused-private-field false negative with defaul

[clang] [clang][AArch64] Avoid a crash when a non-reserved register is used (PR #117419)

2024-11-23 Thread Daniel Kiss via cfe-commits
@@ -232,13 +232,23 @@ bool AArch64TargetInfo::validateTarget(DiagnosticsEngine &Diags) const { bool AArch64TargetInfo::validateGlobalRegisterVariable( StringRef RegName, unsigned RegSize, bool &HasSizeMismatch) const { - if ((RegName == "sp") || RegName.starts_with("x"))

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

2024-11-23 Thread Chris White via cfe-commits
whiteio wrote: Thanks for that @Maetveis! I've updated the release notes. https://github.com/llvm/llvm-project/pull/116871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2024-11-23 Thread via cfe-commits
https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/117437 Clang now support the following: - Extending lifetime of object bound to reference members of aggregates, that are created from default member initializer. - Rebuild all sub-expressions in CXXDefaultArgExpr an

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: None (yronglin) Changes Clang now support the following: - Extending lifetime of object bound to reference members of aggregates, that are created from default member initializer. - Rebuild all sub-expressions in CXXDefaultArgExpr

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (yronglin) Changes Clang now support the following: - Extending lifetime of object bound to reference members of aggregates, that are created from default member initializer. - Rebuild all sub-expressions in CXXDefaultArgExpr and CXX

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2024-11-23 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff aa2d084f9a68f041a42e4df84e11d769a7be34a6 75b4765da0b4ebb008781b393181c5b080be2578 --e

[clang] 3a31427 - [Clang] Add C++26 approved in the Poland WG21 meeting

2024-11-23 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2024-11-23T10:05:48+01:00 New Revision: 3a31427224d4fa49d7ef737b21f6027dc4928ecf URL: https://github.com/llvm/llvm-project/commit/3a31427224d4fa49d7ef737b21f6027dc4928ecf DIFF: https://github.com/llvm/llvm-project/commit/3a31427224d4fa49d7ef737b21f6027dc4928ecf.diff

[clang] [llvm] [ARM] Emit an error when the hard-float ABI is enabled but can't be used. (PR #111334)

2024-11-23 Thread Chris Copeland via cfe-commits
@@ -16,7 +16,7 @@ // RUN: %clang --target=arm-none-eabi -mcpu=cortex-m33 -mfloat-abi=hard -O1 %s -flto=thin -c -o %t.call_thin.bc -DCALL_LIB // RUN: %clang --target=arm-none-eabi -mcpu=cortex-m33 -mfloat-abi=hard -O1 %s -flto=thin -c -o %t.define_thin.bc -DDEFINE_LIB -// RUN

[clang] [llvm] [ARM] Emit an error when the hard-float ABI is enabled but can't be used. (PR #111334)

2024-11-23 Thread Chris Copeland via cfe-commits
https://github.com/chrisnc edited https://github.com/llvm/llvm-project/pull/111334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Emit an error when the hard-float ABI is enabled but can't be used. (PR #111334)

2024-11-23 Thread Chris Copeland via cfe-commits
https://github.com/chrisnc edited https://github.com/llvm/llvm-project/pull/111334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] simplify the unset check in `ParseLabeledStatement` (PR #117430)

2024-11-23 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. https://github.com/llvm/llvm-project/pull/117430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AIX] Fix AIX BuildBot failure as AIX linker doesn't support version script. (PR #117342)

2024-11-23 Thread Xing Xue via cfe-commits
@@ -48,11 +48,13 @@ add_clang_library(clang-cpp ${_OBJECTS} LINK_LIBS ${_DEPS}) +# AIX linker does not support version script +if (NOT ${CMAKE_SYSTEM_NAME} MATCHES "AIX") + configure_file(simple_version_script.map.in simple

[clang] Revert "[AIX] Fix AIX BuildBot failure as AIX linker doesn't support version script." (PR #117444)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Xing Xue (xingxue-ibm) Changes Commit https://github.com/llvm/llvm-project/commit/eaa0a21d21962280dc2c03a09152510f6162a576 has fixed the build problem already so the change in llvm/llvm-project#117342 does not make sense any more. I am re

[clang] Revert "[AIX] Fix AIX BuildBot failure as AIX linker doesn't support version script." (PR #117444)

2024-11-23 Thread Xing Xue via cfe-commits
https://github.com/xingxue-ibm created https://github.com/llvm/llvm-project/pull/117444 Commit https://github.com/llvm/llvm-project/commit/eaa0a21d21962280dc2c03a09152510f6162a576 has fixed the build problem already so the change in llvm/llvm-project#117342 does not make sense any more. I am

[clang] [HLSL] Add ByteAddressBuffer definition to HLSLExternalSemaSource #113477 (PR #116699)

2024-11-23 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/116699 >From 7210fcc7de181be6cad451ce1e885498c90c55fe Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Sat, 9 Nov 2024 01:34:16 + Subject: [PATCH 01/13] adding definition --- clang/lib/Sema/HLSLExternalSemaS

[clang] [HLSL] Add ByteAddressBuffer definition to HLSLExternalSemaSource #113477 (PR #116699)

2024-11-23 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/116699 >From 7210fcc7de181be6cad451ce1e885498c90c55fe Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Sat, 9 Nov 2024 01:34:16 + Subject: [PATCH 01/13] adding definition --- clang/lib/Sema/HLSLExternalSemaS

[clang] 94bde8c - [HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (#114148)

2024-11-23 Thread via cfe-commits
Author: Helena Kotas Date: 2024-11-23T09:33:38-08:00 New Revision: 94bde8cdc39ff7e9c59ee0cd5edda882955242aa URL: https://github.com/llvm/llvm-project/commit/94bde8cdc39ff7e9c59ee0cd5edda882955242aa DIFF: https://github.com/llvm/llvm-project/commit/94bde8cdc39ff7e9c59ee0cd5edda882955242aa.diff

[clang] [llvm] [HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (PR #114148)

2024-11-23 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/114148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Fixed the value of BOOL_WIDTH (PR #117364)

2024-11-23 Thread Jens Gustedt via cfe-commits
@@ -1103,7 +1103,15 @@ static void InitializePredefinedMacros(const TargetInfo &TI, assert(TI.getCharWidth() == 8 && "Only support 8-bit char so far"); Builder.defineMacro("__CHAR_BIT__", Twine(TI.getCharWidth())); - Builder.defineMacro("__BOOL_WIDTH__", Twine(TI.getBool

[clang] [llvm] Codegen changes for strict modifier with grainsize/num_tasks of taskloop construct (PR #117196)

2024-11-23 Thread CHANDRA GHALE via cfe-commits
@@ -7831,10 +7831,14 @@ void CodeGenFunction::EmitOMPTaskLoopBasedDirective(const OMPLoopDirective &S) { // grainsize clause Data.Schedule.setInt(/*IntVal=*/false); Data.Schedule.setPointer(EmitScalarExpr(Clause->getGrainsize())); +Data.HasModifier = +(

[clang] [clang][NFC] simplify the check for `ParseLabeledStatement` (PR #117430)

2024-11-23 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/117430 `!isInvalid && !isUsable -> !isInvalid && !(!isInvalid && !isUnset) -> isUnset` It is more simple to understand. >From 61d17293801b552b40e78bc1277cea1c83741e56 Mon Sep 17 00:00:00 2001 From: Congcong Cai D

[clang] [clang][NFC] simplify the unset check in `ParseLabeledStatement` (PR #117430)

2024-11-23 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/117430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Enable -Wmissing-prototypes (PR #116261)

2024-11-23 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/116261 >From e6f36baf39d1c3e2d90c3343c49771ccf1ca976c Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Thu, 14 Nov 2024 18:30:39 +0100 Subject: [PATCH] [libc++] Enable -Wmissing-prototypes --- libcxx/src/charc

[clang] [clang][NFC] simplify the unset check in `ParseLabeledStatement` (PR #117430)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Congcong Cai (HerrCai0907) Changes `!isInvalid && !isUsable -> !isInvalid && !(!isInvalid && !isUnset) -> isUnset` It is more simple to understand. --- Full diff: https://github.com/llvm/llvm-project/pull/117430.diff 1 Files Affected:

[clang-tools-extra] Rename CODE_OWNERS -> Maintainers (PR #114544)

2024-11-23 Thread via cfe-commits
https://github.com/PeterChou1 approved this pull request. https://github.com/llvm/llvm-project/pull/114544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-23 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/116033 >From 23b4bcdf52041aad1c5581e0f7dc01028770a154 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Wed, 13 Nov 2024 12:52:36 +0100 Subject: [PATCH 01/12] [clang-tidy] Enhance modernize-use-starts-ends-with

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-11-23 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > > > @phoebewang and @lvwr I also noticed that there is this code in LLVM: > > > https://github.com/llvm/llvm-project/blob/9ba6672b9f0e82a1f6d4100dc832c84447ea545c/llvm/lib/Transforms/Utils/ModuleUtils.cpp#L202-L214 > > > > > > . As far as I can tell, this code is not triggere

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-11-23 Thread Phoebe Wang via cfe-commits
@@ -208,10 +209,34 @@ void llvm::setKCFIType(Module &M, Function &F, StringRef MangledType) { std::string Type = MangledType.str(); if (M.getModuleFlag("cfi-normalize-integers")) Type += ".normalized"; + + uint32_t OutHash = static_cast(llvm::xxHash64(Type)); + auto

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-11-23 Thread Phoebe Wang via cfe-commits
@@ -208,10 +209,34 @@ void llvm::setKCFIType(Module &M, Function &F, StringRef MangledType) { std::string Type = MangledType.str(); if (M.getModuleFlag("cfi-normalize-integers")) Type += ".normalized"; + + uint32_t OutHash = static_cast(llvm::xxHash64(Type)); + auto

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-11-23 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > > > Second, this scheme reduces the expected number of hash collisions within > > > each arity, compared against the expected number of collisions > > > (0.01383765) for the 32-bit hashing scheme that includes all arities. The > > > table below shows the expected number of

[clang] Add an off-by-default warning to complain about MSVC bitfield padding (PR #117428)

2024-11-23 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/117428 This just adds a warning for bitfields placed next to other bitfields where the underlying type has different storage. Under the MS struct bitfield packing ABI such bitfields are not packed. >From 3e25d7ef2e223