https://github.com/nicovank commented:
This feels very intrusive, a lot should be able to be re-used from things
already used in the matcher. I expect something like this would be sufficient:
```cpp
Finder->addMatcher(
cxxOperatorCallExpr(
hasAnyOperatorName("==", "!="),
has
EugeneZelenko wrote:
Please change pull request title.
https://github.com/llvm/llvm-project/pull/116033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm edited
https://github.com/llvm/llvm-project/pull/112842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/labrinea created
https://github.com/llvm/llvm-project/pull/116257
Currently we have code with target hooks in CodeGenModule shared between X86
and AArch64 for sorting MultiVersionResolverOptions. Those are used when
generating IFunc resolvers for FMV. The RISCV target has di
@@ -8732,6 +8732,18 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) {
}
}
+ // zero sized static arrays are not allowed in HIP device functions
+ if (getLangOpts().HIP &&
+ DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {
Author: Matt Arsenault
Date: 2024-11-14T08:37:53-08:00
New Revision: 03730cdd3d10c5270fe436777a37d50b0838a3bf
URL:
https://github.com/llvm/llvm-project/commit/03730cdd3d10c5270fe436777a37d50b0838a3bf
DIFF:
https://github.com/llvm/llvm-project/commit/03730cdd3d10c5270fe436777a37d50b0838a3bf.diff
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
@llvm/pr-subscribers-backend-aarch64
@llvm/pr-subscribers-clang
Author: Alexandros Lamprineas (labrinea)
Changes
Currently we have code with target hooks in CodeGenModule shared between X86
and AArch64 for sorting MultiVersionResolverOpti
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b96c24b8613036749e7ba28f0c7a837115ae9f91
eb6fea771b0824fef979e5eef26718ecbc8c7f56 --e
@@ -8732,6 +8732,18 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) {
}
}
+ // zero sized static arrays are not allowed in HIP device functions
+ if (getLangOpts().HIP &&
+ DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/115921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -fsyntax-only -Wdangling -Wdangling-field
-Wreturn-stack-address -verify %s
+// RUN: %clang_cc1 --std=c++20 -fsyntax-only -Wdangling -Wdangling-field
-Wreturn-stack-address -verify %s
usx95 wrote:
I think this should be fine.
Author: SpencerAbson
Date: 2024-11-14T11:04:04Z
New Revision: 748b028540de67000345dfb3454ccd011ace4bb5
URL:
https://github.com/llvm/llvm-project/commit/748b028540de67000345dfb3454ccd011ace4bb5
DIFF:
https://github.com/llvm/llvm-project/commit/748b028540de67000345dfb3454ccd011ace4bb5.diff
LOG:
https://github.com/SpencerAbson closed
https://github.com/llvm/llvm-project/pull/116026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/115921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lenary updated
https://github.com/llvm/llvm-project/pull/112983
>From 0b98a56337d3210e82cac0f509eb7d3d547083f9 Mon Sep 17 00:00:00 2001
From: Sam Elliott
Date: Tue, 22 Oct 2024 12:37:48 -0700
Subject: [PATCH 1/3] [RISCV] GPR Pairs for Inline Asm using `Pr`
This patch adds su
@@ -31,45 +31,45 @@ define @test_extq_i32 ( %zn, @test_extq_i64 ( %zn, %zm) {
; CHECK-LABEL: test_extq_i64:
; CHECK: // %bb.0:
-; CHECK-NEXT:extq z0.b, z0.b, z1.b, #3
+; CHECK-NEXT:extq z0.b, z0.b, z1.b, #8
; CHECK-NEXT:ret
- %res = call @llvm.aarch64.sve
@@ -3040,6 +3040,11 @@ bool Sema::checkTargetVersionAttr(SourceLocation
LiteralLoc, Decl *D,
enum FirstParam { Unsupported };
enum SecondParam { None };
enum ThirdParam { Target, TargetClones, TargetVersion };
+
+ if (!Context.getTargetInfo().getTriple().isRISCV() &&
+
https://github.com/SpencerAbson edited
https://github.com/llvm/llvm-project/pull/115340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SpencerAbson edited
https://github.com/llvm/llvm-project/pull/115340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SpencerAbson edited
https://github.com/llvm/llvm-project/pull/115340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SpencerAbson edited
https://github.com/llvm/llvm-project/pull/115340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM, no need for a release note. Thank you for the cleanup!
https://github.com/llvm/llvm-project/pull/116120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -793,3 +793,108 @@ void test13() {
}
} // namespace GH100526
+
+namespace lifetime_capture_by {
+struct S {
+ const int *x;
+ void captureInt(const int&x [[clang::lifetime_capture_by(this)]]) { this->x
= &x; }
+ void captureSV(std::string_view sv [[clang::lifetime_captu
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/116225
>From 68086287a41c534704cdbc88027f61090b0540ea Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Thu, 14 Nov 2024 14:
https://github.com/bricknerb created
https://github.com/llvm/llvm-project/pull/116226
None
>From 35c1a01df73a52acda55bb4a162fdbddd03c764d Mon Sep 17 00:00:00 2001
From: Boaz Brickner
Date: Thu, 14 Nov 2024 14:27:33 +0100
Subject: [PATCH] [clang] [NFC] Merge two ifs to a single one
---
clang/
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Balazs Benics (steakhal)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/116225.diff
2 Files Affected:
- (modi
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Boaz Brickner (bricknerb)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/116226.diff
1 Files Affected:
- (modified) clang/lib/Sema/SemaCUDA.cpp (+3-3)
``diff
diff --git a/clang/lib/Sema/SemaCUDA.cpp b/clang
@@ -2609,9 +2611,42 @@ RegionBindingsRef
RegionStoreManager::bindVector(RegionBindingsConstRef B,
return NewB;
}
+std::optional
+RegionStoreManager::getUniqueDefaultBinding(Store S,
+const MemRegion *BaseR) const {
+ assert(BaseR
https://github.com/AaronBallman approved this pull request.
https://github.com/llvm/llvm-project/pull/115144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3229,6 +3231,52 @@ void Sema::CheckArgAlignment(SourceLocation Loc,
NamedDecl *FDecl,
<< ParamName << (FDecl != nullptr) << FDecl;
}
+void Sema::checkLifetimeCaptureBy(FunctionDecl *FD, bool IsMemberFunction,
+ const Expr *ThisArg,
@@ -0,0 +1,37 @@
+// RUN: %clang_analyze_cc1 %s \
+// RUN: -analyzer-checker=debug.ExprInspection \
+// RUN: -verify
steakhal wrote:
I think you need to pin the target triple as in the test you have an assumption
about the size of int, as the upperbound of a
https://github.com/phoebewang closed
https://github.com/llvm/llvm-project/pull/116181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
4048c64306e23b622443bbe7293057a9b07a13bb...68086287a41c534704cdbc88027f61090b0540ea
clang
Author: Daniel Kiss
Date: 2024-11-14T14:45:15+01:00
New Revision: 3f40ad7ba83ecf6f374039191ae7ceeb1f5fe831
URL:
https://github.com/llvm/llvm-project/commit/3f40ad7ba83ecf6f374039191ae7ceeb1f5fe831
DIFF:
https://github.com/llvm/llvm-project/commit/3f40ad7ba83ecf6f374039191ae7ceeb1f5fe831.diff
L
https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/111962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1420,9 +1446,18 @@ static void checkExprLifetimeImpl(Sema &SemaRef,
? IndirectLocalPathEntry::LifetimeBoundCall
: IndirectLocalPathEntry::GslPointerAssignment,
Init});
+ } else if (LK == LK_LifetimeCapture) {
bricknerb wr
@@ -793,3 +806,202 @@ void test13() {
}
} // namespace GH100526
+
+namespace lifetime_capture_by {
+struct X {
+ const int *x;
+ void captureInt(const int& x [[clang::lifetime_capture_by(this)]]) { this->x
= &x; }
+ void captureSV(std::string_view sv [[clang::lifetime_capt
@@ -249,7 +254,7 @@ static void
visitLocalsRetainedByReferenceBinding(IndirectLocalPath &Path,
LocalVisitor Visit);
template static bool isRecordWithAttr(QualType Type) {
- if (auto *RD = Type->getAsCXXRecordDecl())
+ if (a
https://github.com/bricknerb commented:
Please request another review after comments are addressed.
https://github.com/llvm/llvm-project/pull/115921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running
on `hip-vega20-0` while building `llvm-project,clang,llvm` at step 3 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/123/builds/9384
Here is the relevant piece of
phoebewang wrote:
Yes, thanks for pointing out! Unfortunately, I met network problem when
committing the fix to GH. @MalaySanghi could you commit a fix instead?
https://github.com/llvm/llvm-project/pull/116181
___
cf
@@ -793,3 +793,108 @@ void test13() {
}
} // namespace GH100526
+
+namespace lifetime_capture_by {
+struct S {
+ const int *x;
+ void captureInt(const int&x [[clang::lifetime_capture_by(this)]]) { this->x
= &x; }
+ void captureSV(std::string_view sv [[clang::lifetime_captu
phoebewang wrote:
The network is recovered, fixed by
https://github.com/llvm/llvm-project/commit/9e1faa834173f57344a12b1a0a2f90b8e903c7bd
https://github.com/llvm/llvm-project/pull/116181
___
cfe-commits mailing list
@@ -2609,9 +2611,42 @@ RegionBindingsRef
RegionStoreManager::bindVector(RegionBindingsConstRef B,
return NewB;
}
+std::optional
+RegionStoreManager::getUniqueDefaultBinding(Store S,
+const MemRegion *BaseR) const {
+ assert(BaseR
https://github.com/bricknerb edited
https://github.com/llvm/llvm-project/pull/115921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2609,9 +2611,42 @@ RegionBindingsRef
RegionStoreManager::bindVector(RegionBindingsConstRef B,
return NewB;
}
+std::optional
+RegionStoreManager::getUniqueDefaultBinding(Store S,
+const MemRegion *BaseR) const {
+ assert(BaseR
s-barannikov wrote:
Stray change?
https://github.com/llvm/llvm-project/pull/116181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Edd Dawson
Date: 2024-11-14T13:46:23Z
New Revision: 9685681aa47561c9941bb70aa84a09c55c7db824
URL:
https://github.com/llvm/llvm-project/commit/9685681aa47561c9941bb70aa84a09c55c7db824
DIFF:
https://github.com/llvm/llvm-project/commit/9685681aa47561c9941bb70aa84a09c55c7db824.diff
LOG: [P
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/115916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
I see your point, but I'm still not convinced.
Anyways, that's partially beyond this PR. What we have here I can completely
agree with. I just have the feeling it solved one particular case, and not a
class of bugs - which is fine.
https://github.com/llvm/llvm-project/pull/1155
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while
building `clang,llvm` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/144/builds/11
@@ -6405,7 +6424,12 @@ const ToolChain &Driver::getToolChain(const ArgList
&Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC =
+ llvm::any_of(Inputs,
+
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
When filling out the type locations for a declarator, we handled atomic types
and we handled noderef types, but we didn't handle atomic noderef types.
Fixes #116124
---
Full diff: https://github.com/l
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/116237
When filling out the type locations for a declarator, we handled atomic types
and we handled noderef types, but we didn't handle atomic noderef types.
Fixes #116124
>From c46fabd4d9bd1dd8061c5500693a31cde
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 402efa733c64bd20b54dbc5b7057868cbb938d07
c46fabd4d9bd1dd8061c5500693a31cde2382b8c --e
@@ -1875,13 +1873,17 @@ Instruction *InstCombinerImpl::visitFPTrunc(FPTruncInst
&FPT) {
// fptrunc (select Cond, (fpext X), Y --> select Cond, X, (fptrunc Y)
Value *NarrowY = Builder.CreateFPTrunc(Y, Ty);
Value *Sel = Builder.CreateSelect(Cond, X, NarrowY, "n
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/116237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2609,9 +2611,42 @@ RegionBindingsRef
RegionStoreManager::bindVector(RegionBindingsConstRef B,
return NewB;
}
+std::optional
+RegionStoreManager::getUniqueDefaultBinding(Store S,
+const MemRegion *BaseR) const {
+ assert(BaseR
@@ -2609,9 +2611,42 @@ RegionBindingsRef
RegionStoreManager::bindVector(RegionBindingsConstRef B,
return NewB;
}
+std::optional
+RegionStoreManager::getUniqueDefaultBinding(Store S,
+const MemRegion *BaseR) const {
+ assert(BaseR
https://github.com/NagyDonat approved this pull request.
LGTM, clean little patch, I don't have anything to say here.
https://github.com/llvm/llvm-project/pull/115918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
301 - 361 of 361 matches
Mail list logo
