llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
The other functions like this are also const.
---
Full diff: https://github.com/llvm/llvm-project/pull/114777.diff
2 Files Affected:
- (modified) clang/lib/AST/ByteCode/Floating.h (+1-1)
- (modified) clan
Author: Timm Baeder
Date: 2024-11-04T14:00:24+01:00
New Revision: fb30208d1e4c2c1ba34c331f6f90a99552d2df97
URL:
https://github.com/llvm/llvm-project/commit/fb30208d1e4c2c1ba34c331f6f90a99552d2df97
DIFF:
https://github.com/llvm/llvm-project/commit/fb30208d1e4c2c1ba34c331f6f90a99552d2df97.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/114777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -43,7 +43,7 @@ module third {}
// CHECK-NEXT: "command-line": [
// CHECK-NEXT: "-cc1",
// CHECK:
"-fmodule-map-file=[[PREFIX]]/second/second/module.modulemap"
-// CHECK-NOT:
"-fmodule-map-file=[[PREFIX]]/second/second/sub.modulemap"
+//
https://github.com/pashu123 approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/114795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -316,36 +294,205 @@ llvm::Error buildModuleFile(llvm::StringRef ModuleName,
if (Clang->getDiagnostics().hasErrorOccurred())
return llvm::createStringError("Compilation failed");
- BuiltModuleFiles.addModuleFile(ModuleName, Inputs.CompileCommand.Output);
- return llv
@@ -122,7 +122,6 @@ class SpecialCaseList {
// Returns zero if no match is found.
unsigned match(StringRef Query) const;
- private:
StringMap> Globs;
kadircet wrote:
these are members of `SpecialCaseList::Matcher`. `WarningsSpecialCaseList` is
@@ -17,6 +17,7 @@ template
T tmain(T argc) {
static T a;
#pragma omp flush
+#pragma omp flush seq_cst
kiranchandramohan wrote:
We need a CHECK line corresponding to this new entry.
https://github.com/llvm/llvm-project/pull/114072
__
Author: Timm Baeder
Date: 2024-11-04T15:10:10+01:00
New Revision: 2588b8be5624f721c56f44fd2a69f7327de8c0c1
URL:
https://github.com/llvm/llvm-project/commit/2588b8be5624f721c56f44fd2a69f7327de8c0c1
DIFF:
https://github.com/llvm/llvm-project/commit/2588b8be5624f721c56f44fd2a69f7327de8c0c1.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/114776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kiranchandramohan edited
https://github.com/llvm/llvm-project/pull/114072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -28,6 +29,7 @@ T tmain(T argc) {
int main() {
static int a;
#pragma omp flush
+#pragma omp flush seq_cst
kiranchandramohan wrote:
We need a CHECK line corresponding to this new entry.
https://github.com/llvm/llvm-project/pull/114072
_
https://github.com/kiranchandramohan commented:
Thanks for this patch. Could you update the title/summary of the patch to say
that seq_cst is allowed in Flush since OpenMP 5.1. Also, might make sense to
say why no other changes in Lowering to IR is required.
Could you add a test in flang/test/
alexey-bataev wrote:
Also, would be good to update clang WhatsNew and OpenMP status docs to reflect
support for the new functionality
https://github.com/llvm/llvm-project/pull/114072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
JOE1994 wrote:
gentle ping
https://github.com/llvm/llvm-project/pull/113331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,13 @@
+// This test checks if Window PE file compiled with -flto option contains a
magic
+// string "LTCG" to indicate LTO compilation.
+
+// REQUIRES: system-windows
+
+// RUN: %clang --target=x86_64-pc-windows-msvc -flto -fuse-ld=lld %s -o %t.exe
mi
nikic wrote:
Please land the remaining removals separately.
https://github.com/llvm/llvm-project/pull/113331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/113331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/113331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun edited
https://github.com/llvm/llvm-project/pull/114044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun commented:
Overall, this approach looks promising to me. Some nits inline.
https://github.com/llvm/llvm-project/pull/114044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -1093,6 +1093,87 @@ static bool pathOnlyHandlesGslPointer(const
IndirectLocalPath &Path) {
}
return false;
}
+// Result of analyzing the Path for GSLPointer.
+enum AnalysisResult {
Xazax-hun wrote:
Nit: not sure what is the current policy about `enum c
@@ -1093,6 +1093,87 @@ static bool pathOnlyHandlesGslPointer(const
IndirectLocalPath &Path) {
}
return false;
}
+// Result of analyzing the Path for GSLPointer.
+enum AnalysisResult {
+ // Path does not correspond to a GSLPointer.
+ NotGSLPointer,
+
+ // A relevant case
@@ -1093,6 +1093,87 @@ static bool pathOnlyHandlesGslPointer(const
IndirectLocalPath &Path) {
}
return false;
}
+// Result of analyzing the Path for GSLPointer.
Xazax-hun wrote:
Nit: maybe we want some line breaks here for better separation.
https://gith
https://github.com/vhscampos updated
https://github.com/llvm/llvm-project/pull/110657
>From e194bdad39ea7f719e1a133eca94f9ce6ef3e881 Mon Sep 17 00:00:00 2001
From: Victor Campos
Date: Thu, 26 Sep 2024 14:43:18 +0100
Subject: [PATCH 1/2] [Multilib] Custom flags YAML parsing
This patch adds supp
https://github.com/NagyDonat commented:
Thanks for implementing this cleanup commit!
I like that you ported the tests from the old checker to the tidy checks.
However, as these test files are very large, perhaps it would be better to put
these moved tests into stand-alone files instead of addi
https://github.com/kadircet requested changes to this pull request.
thanks a lot for this patch!
I am not sure if this is a "good" fix-it for C++ ecosystem. As it'll make
suppression way easier. Today people needs to decide whether a suppression is
warranted, and explain it in a comment. at th
@@ -1165,6 +1188,23 @@ void Writer::createMiscChunks() {
llvm::TimeTraceScope timeScope("Misc chunks");
Configuration *config = &ctx.config;
+ auto searchForPgoMagicSection = [this](char sectionName[]) {
+for (auto *obj : ctx.objFileInstances) {
+ for (auto &chun
sebastiankreutzer wrote:
@MaskRay Thanks! Would you mind pushing the commit? I don't have write access.
https://github.com/llvm/llvm-project/pull/114431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
Author: Xi Ruoyao
Date: 2024-11-04T17:52:52+08:00
New Revision: 4f740f9d77cd038c8e55195fa189748e58ea6476
URL:
https://github.com/llvm/llvm-project/commit/4f740f9d77cd038c8e55195fa189748e58ea6476
DIFF:
https://github.com/llvm/llvm-project/commit/4f740f9d77cd038c8e55195fa189748e58ea6476.diff
LOG
https://github.com/SixWeining closed
https://github.com/llvm/llvm-project/pull/114513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/labrinea edited
https://github.com/llvm/llvm-project/pull/114387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/114776
Only fixed-size, non-bitfield integral fields for now.
>From d0d198a55f7925143c34719c1393d004cd95b967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Sat, 2 Nov 2024 01:53:28 +0100
Subject:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
Only fixed-size, non-bitfield integral fields for now.
---
Full diff: https://github.com/llvm/llvm-project/pull/114776.diff
6 Files Affected:
- (modified) clang/lib/AST/ByteCode/Compiler.cpp (+2-4)
- (mod
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/114777
The other functions like this are also const.
>From c64f8e5f8019fd83fd4a5d02c5ac29047b377354 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Mon, 4 Nov 2024 12:49:19 +0100
Subject: [PATCH] [
https://github.com/sam-mccall created
https://github.com/llvm/llvm-project/pull/114778
This is relevant after b24650e814e55d90acfc40acf045456c98f32b9c where
the selected template decl can be anything, even apparently a friend
declaration in some cases.
>From 58baaccd4849fee2f8f1966de62660cb4c5
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sam McCall (sam-mccall)
Changes
This is relevant after b24650e814e55d90acfc40acf045456c98f32b9c where
the selected template decl can be anything, even apparently a friend
declaration in some cases.
---
Full diff: https://github.com/llvm/l
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Author: Jay Foad (jayfoad)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/114795.diff
22 Files Affected:
- (modified) clang/test/Analysis/malloc.c (+1-1)
- (modified) lld/test/Unit/lit.cfg.py (+1-1)
- (modified) l
llvmbot wrote:
@llvm/pr-subscribers-lld
Author: Jay Foad (jayfoad)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/114795.diff
22 Files Affected:
- (modified) clang/test/Analysis/malloc.c (+1-1)
- (modified) lld/test/Unit/lit.cfg.py (+1-1)
- (modified) llvm/docs/His
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
@llvm/pr-subscribers-backend-amdgpu
Author: Jay Foad (jayfoad)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/114795.diff
22 Files Affected:
- (modified) clang/test/Analysis/malloc.c (+1-1)
- (modified) lld/test/Un
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jay Foad (jayfoad)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/114795.diff
22 Files Affected:
- (modified) clang/test/Analysis/malloc.c (+1-1)
- (modified) lld/test/Unit/lit.cfg.py (+1-1)
- (modified) llvm/docs/H
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/114795
None
>From bcb149170d1eaf0a177deee63a9dc289dd55892b Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Mon, 4 Nov 2024 13:46:28 +
Subject: [PATCH] [llvm-project] Fix typo "propogate"
---
clang/test/Analysis/ma
chomosuke wrote:
Thank you for the prompt review!!
I am currently working on something else now but I'll address this PR asap once
I'm done with that :>.
https://github.com/llvm/llvm-project/pull/114661
___
cfe-commits mailing list
cfe-commits@list
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/114424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chomosuke converted_to_draft
https://github.com/llvm/llvm-project/pull/114661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/CoTinker approved this pull request.
https://github.com/llvm/llvm-project/pull/114795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vadim D.
Date: 2024-11-04T14:55:38+01:00
New Revision: c0ce44e8fc03882641f270539265b20dba0fffdd
URL:
https://github.com/llvm/llvm-project/commit/c0ce44e8fc03882641f270539265b20dba0fffdd
DIFF:
https://github.com/llvm/llvm-project/commit/c0ce44e8fc03882641f270539265b20dba0fffdd.diff
LOG:
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/113612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -464,6 +464,8 @@ Improvements to Clang's diagnostics
- Clang now diagnoses ``[[deprecated]]`` attribute usage on local variables
(#GH90073).
+- Clang now diagnoses misused reasoned ``delete("reason")`` warnings only in
pedantic mode. (#GH109311).
AaronBa
https://github.com/svenvh created
https://github.com/llvm/llvm-project/pull/114824
In addition to the invocation case that is already diagnosed, also diagnose
when a block reference appears on either side of a ternary selection operator.
>From 386b891dce07f37d3b886008f42160e7224f6e4c Mon Sep 1
https://github.com/dougsonos updated
https://github.com/llvm/llvm-project/pull/114266
>From 6a8a3f21eb23b8b7d63bd8b0fb6e2e85ff1951df Mon Sep 17 00:00:00 2001
From: Doug Wyatt
Date: Wed, 30 Oct 2024 09:53:58 -0700
Subject: [PATCH 1/3] [clang] SemaFunctionEffects: When verifying a function,
igno
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/114825
None
>From fcc54305a0a953f0d5ecc41d3e411172c17c8c6d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Mon, 4 Nov 2024 16:18:52 +0100
Subject: [PATCH] [clang][bytecode] Support bitcasting into
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/114774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sven van Haastregt (svenvh)
Changes
In addition to the invocation case that is already diagnosed, also diagnose
when a block reference appears on either side of a ternary selection operator.
---
Full diff: https://github.com/llvm/llvm-pro
https://github.com/statham-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/110657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/svenvh edited
https://github.com/llvm/llvm-project/pull/114824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13,246 +13,40 @@
#include "IncrementalParser.h"
#include "clang/AST/DeclContextInternals.h"
-#include "clang/CodeGen/BackendUtil.h"
-#include "clang/CodeGen/CodeGenAction.h"
-#include "clang/CodeGen/ModuleBuilder.h"
#include "clang/Frontend/CompilerInstance.h"
-#include "
ldionne wrote:
@petrhosek I'm curious to know what you think of this design.
https://github.com/llvm/llvm-project/pull/112978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frasercrmck closed
https://github.com/llvm/llvm-project/pull/114774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Thank you for working on this!
https://github.com/llvm/llvm-project/pull/114713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b74e588e1f460eb48ceb1a30cf8ac870b7537dcc
b810ae2996e7ac66ee877a1434d3a309335c9600 --e
Author: Fraser Cormack
Date: 2024-11-04T16:35:14Z
New Revision: 293c78ba0a93cb03238a909c96dcd399e685f575
URL:
https://github.com/llvm/llvm-project/commit/293c78ba0a93cb03238a909c96dcd399e685f575
DIFF:
https://github.com/llvm/llvm-project/commit/293c78ba0a93cb03238a909c96dcd399e685f575.diff
LOG
501 - 562 of 562 matches
Mail list logo
