arsenm wrote:
> > I fixed an apparent missing test dependency in
> > [1ac6ef5](https://github.com/llvm/llvm-project/commit/1ac6ef5af28b72e534496a9833a2b75a2aba66cc)
> > and this commit removed the llvm-mc dependency
>
> I probably should've remembered to include removing that in this patch.
I
vgvassilev wrote:
Unless there is more discussion or comments worth addressing I'd propose to
merge this PR in the next day or two as it is a bottleneck for a few others in
the pipeline.
https://github.com/llvm/llvm-project/pull/108276
___
cfe-commit
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/112155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2024-10-14T06:53:49-07:00
New Revision: c765b5eda778ab30e9944c8c9606fa8ba5295792
URL:
https://github.com/llvm/llvm-project/commit/c765b5eda778ab30e9944c8c9606fa8ba5295792
DIFF:
https://github.com/llvm/llvm-project/commit/c765b5eda778ab30e9944c8c9606fa8ba5295792.diff
L
Author: Kazu Hirata
Date: 2024-10-14T06:54:32-07:00
New Revision: 4459a9b6436d9443944da9a086bd42724334afa0
URL:
https://github.com/llvm/llvm-project/commit/4459a9b6436d9443944da9a086bd42724334afa0
DIFF:
https://github.com/llvm/llvm-project/commit/4459a9b6436d9443944da9a086bd42724334afa0.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/112156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,67 @@
+//===-- clang/Support/Compiler.h - Compiler abstraction support -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/112218
9ad72df55cb74b29193270c28f6974d2af8e0b71 added split of _BitInt constants when
required. Before folding back, check that the constant exists.
>From 60cda89e05cdd922ec762d8be6142936442fb505 Mon Sep 17 00:00:00
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Mariya Podchishchaeva (Fznamznon)
Changes
9ad72df55cb74b29193270c28f6974d2af8e0b71 added split of _BitInt constants when
required. Before folding back, check that the constant exists.
---
Full diff: https://github.com/llvm/llvm-pr
https://github.com/bc-lee updated
https://github.com/llvm/llvm-project/pull/111375
>From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001
From: Byoungchan Lee
Date: Mon, 7 Oct 2024 22:19:38 +0900
Subject: [PATCH 1/9] [clang-include-cleaner] Fix incorrect directory issue for
wr
bc-lee wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/111375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
> Could you dive a little deeper why this change is necessary? E.g. does the
> most recent redecl have some properties that the canonical declaration (which
> would be the first one) does not?
@ilya-biryukov When instantiating a template from a member template that was
expli
@@ -348,6 +348,12 @@ bool CheckConstant(InterpState &S, CodePtr OpPC, const
Descriptor *Desc) {
if (D->isConstexpr())
return true;
+ if (const auto *VD = dyn_cast_if_present(S.EvaluatingDecl);
yronglin wrote:
It's to follow the logic in
https://githu
Author: Tarun Prabhu
Date: 2024-10-14T08:44:24-06:00
New Revision: 839344f025fb7eff529735873f327330618b2ebb
URL:
https://github.com/llvm/llvm-project/commit/839344f025fb7eff529735873f327330618b2ebb
DIFF:
https://github.com/llvm/llvm-project/commit/839344f025fb7eff529735873f327330618b2ebb.diff
https://github.com/tarunprabhu closed
https://github.com/llvm/llvm-project/pull/110132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@AlbertHuang-CPU Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with
Author: Albert Huang
Date: 2024-10-14T15:48:12+01:00
New Revision: aa2c0f35a102b5afc128e19ccb2b9402026c531f
URL:
https://github.com/llvm/llvm-project/commit/aa2c0f35a102b5afc128e19ccb2b9402026c531f
DIFF:
https://github.com/llvm/llvm-project/commit/aa2c0f35a102b5afc128e19ccb2b9402026c531f.diff
https://github.com/davemgreen closed
https://github.com/llvm/llvm-project/pull/110085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davemgreen wrote:
> Hi David, rebase done. Could you help to merge?
Thanks - it looks like the errors were unrelated - something that was broken on
trunk earlier. Please yell if it does look like something is going wrong.
https://github.com/llvm/llvm-project/pull/110085
___
pskrgag wrote:
> Make the check recognize the syscalls and consider them annotated.
I guess, this may confuse checker more, since not all syscalls actually consume
handles. I will try and share my results =) Thanks!
https://github.com/llvm/llvm-project/pull/111588
https://github.com/sunfishcode updated
https://github.com/llvm/llvm-project/pull/112035
>From 8db1c6225cb938433f57414594cc3accae39f03c Mon Sep 17 00:00:00 2001
From: Dan Gohman
Date: Fri, 11 Oct 2024 04:30:32 -0700
Subject: [PATCH 1/5] [WebAssembly] Define a new "Trail1" CPU
First, define some
@@ -23,4 +23,17 @@ void nb4() [[clang::nonblocking]] {
}
@catch (...) { // expected-warning {{function with 'nonblocking'
attribute must not throw or catch exceptions}}
}
+ @finally { // expected-warning {{function with 'nonblocking' attribute
must
https://github.com/Sirraide approved this pull request.
LGTM
Using just ‘ObjC messaging’ seems fine to me—though admittedly, I also don’t
know much about Objective C.
https://github.com/llvm/llvm-project/pull/112148
___
cfe-commits mailing list
cfe-c
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/112148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: c8ef
Date: 2024-10-15T00:09:36+08:00
New Revision: ab6ec7ab149ea2c627ed2814c11be33a92171153
URL:
https://github.com/llvm/llvm-project/commit/ab6ec7ab149ea2c627ed2814c11be33a92171153
DIFF:
https://github.com/llvm/llvm-project/commit/ab6ec7ab149ea2c627ed2814c11be33a92171153.diff
LOG: [cl
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/112206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Erich Keane
Date: 2024-10-14T09:08:24-07:00
New Revision: cf456ed2a45821d8e4bc1b62959be3330e00db95
URL:
https://github.com/llvm/llvm-project/commit/cf456ed2a45821d8e4bc1b62959be3330e00db95
DIFF:
https://github.com/llvm/llvm-project/commit/cf456ed2a45821d8e4bc1b62959be3330e00db95.diff
L
https://github.com/c8ef closed https://github.com/llvm/llvm-project/pull/112129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Gábor?= Spaits ,Gabor Spaits
,
=?utf-8?q?Gábor?= Spaits ,
=?utf-8?q?Gábor?= Spaits
Message-ID:
In-Reply-To:
@@ -357,10 +357,13 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II,
SourceLocation NameLoc,
return nullptr;
}
- // FIXME: LookupNestedNa
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH 01/11] Use tag name lookup for class names
This PR would fix #16855
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building
`clang` at step 7 "Add check check-offload".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/30/builds/8206
Here is the relevan
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/110206
>From bf2a9fe2d755adc8dfdd43418e15c35cf912edca Mon Sep 17 00:00:00 2001
From: Thomas Fransham
Date: Thu, 26 Sep 2024 21:23:50 +0100
Subject: [PATCH] [Clang][ASTMatchers] Add visibility macros to variables
de
https://github.com/keith updated
https://github.com/llvm/llvm-project/pull/112112
>From b74b4fec46c871c5981422a7779fdf39c215487c Mon Sep 17 00:00:00 2001
From: Keith Smiley
Date: Sat, 12 Oct 2024 13:38:36 -0700
Subject: [PATCH 1/2] [clang-tidy][readability-identifier-naming] Support
namespace
@@ -357,10 +357,13 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II,
SourceLocation NameLoc,
return nullptr;
}
- // FIXME: LookupNestedNameSpecifierName isn't the right kind of
- // lookup for class-names.
- LookupNameKind Kind = isClassName ? LookupNestedN
keith wrote:
added!
https://github.com/llvm/llvm-project/pull/112112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/keith updated
https://github.com/llvm/llvm-project/pull/112112
>From b74b4fec46c871c5981422a7779fdf39c215487c Mon Sep 17 00:00:00 2001
From: Keith Smiley
Date: Sat, 12 Oct 2024 13:38:36 -0700
Subject: [PATCH 1/3] [clang-tidy][readability-identifier-naming] Support
namespace
https://github.com/keith updated
https://github.com/llvm/llvm-project/pull/112112
>From b74b4fec46c871c5981422a7779fdf39c215487c Mon Sep 17 00:00:00 2001
From: Keith Smiley
Date: Sat, 12 Oct 2024 13:38:36 -0700
Subject: [PATCH 1/4] [clang-tidy][readability-identifier-naming] Support
namespace
https://github.com/spaits edited
https://github.com/llvm/llvm-project/pull/112166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Keith Smiley
Date: 2024-10-14T09:24:42-07:00
New Revision: 39ac8b25cdca230509078d575d46c538bdf90e18
URL:
https://github.com/llvm/llvm-project/commit/39ac8b25cdca230509078d575d46c538bdf90e18
DIFF:
https://github.com/llvm/llvm-project/commit/39ac8b25cdca230509078d575d46c538bdf90e18.diff
https://github.com/keith closed https://github.com/llvm/llvm-project/pull/112106
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3437,8 +3447,8 @@ StringRef BuiltinType::getName(const PrintingPolicy
&Policy) const {
case Id: \
return #ExtType;
#include "clang/Basic/OpenCLExtensionTypes.def"
-#define SVE_TYPE(Name, Id, SingletonId) \
- case Id: \
+#define SVE_TYPE(Name, Id, SingletonId)
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/109362
>From 12b2bd669a46590247e5bd6ac8c76dc61529f331 Mon Sep 17 00:00:00 2001
From: Thomas Fransham
Date: Mon, 8 Jul 2024 01:48:46 +0100
Subject: [PATCH 1/2] [Clang][TableGen] Add explicit symbol visibility macros
@@ -10057,15 +10057,18 @@ void ASTReader::finishPendingActions() {
// For a function defined inline within a class template, force the
// canonical definition to be the one inside the canonical definition of
// the template. This ensures that we instantiate fr
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/109024
>From beef0d9f53f05c31041677101577929281e908b1 Mon Sep 17 00:00:00 2001
From: Thomas Fransham
Date: Wed, 28 Aug 2024 16:08:52 +0100
Subject: [PATCH 1/7] Update llvm::Registry to work for LLVM shared library
https://github.com/CarolineConcatto updated
https://github.com/llvm/llvm-project/pull/101644
>From 7134302c7e1054021af36a207dbfd0c40c9e8c51 Mon Sep 17 00:00:00 2001
From: Caroline Concatto
Date: Fri, 2 Aug 2024 08:47:18 +
Subject: [PATCH 1/3] [CLANG]Add Scalable vectors for mfloat8_t
This
@@ -69,7 +69,7 @@
#ifndef SVE_VECTOR_TYPE_BFLOAT
#define SVE_VECTOR_TYPE_BFLOAT(Name, MangledName, Id, SingletonId, NumEls,
ElBits, NF) \
- SVE_VECTOR_TYPE_DETAILS(Name, MangledName, Id, SingletonId, NumEls, ElBits,
NF, false, false, true)
+ SVE_VECTOR_TYPE_DETAILS(Name, M
@@ -454,6 +458,8 @@ std::string SVEType::builtin_str() const {
else if (isBFloat()) {
assert(ElementBitwidth == 16 && "Not a valid BFloat.");
S += "y";
+ } else if (isMFloat()) {
+S += "m";
CarolineConcatto wrote:
Done
https://github.com/llvm/l
@@ -4419,6 +4419,13 @@ QualType ASTContext::getScalableVectorType(QualType
EltTy, unsigned NumElts,
EltTySize == ElBits && NumElts == (NumEls * NF) && NumFields == 1) {
\
return SingletonId;
\
}
+#define
https://github.com/keith closed https://github.com/llvm/llvm-project/pull/112112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
petrhosek wrote:
> > > @petrhosek Can someone explain why the clang executable in these tests is
> > > called `llvm` on the Fuchsia bots?
> >
> >
> > We enable the
> > [`LLVM_TOOL_LLVM_DRIVER_BUILD`](https://github.com/llvm/llvm-project/blob/48deb3568eb2452ff385b04b8f71c34121f47387/clang/cmak
shafik wrote:
This crash is due to this set of changes:
https://github.com/llvm/llvm-project/issues/11
https://github.com/llvm/llvm-project/pull/78041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -3141,6 +3148,10 @@ def warn_attribute_ignored_no_calls_in_stmt: Warning<
"statement">,
InGroup;
+def warn_attribute_needs_aggregate : Warning<
higher-performance wrote:
@AaronBallman would you mind taking another look at this PR? We've addressed
all
https://github.com/rjmccall approved this pull request.
https://github.com/llvm/llvm-project/pull/112218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
> It should be `llvm clang`. I'm looking into this right now because this
> change broke all our builders. I think that
> `clang/lib/Driver/ToolChains/HIPUtility.cpp` doesn't correctly support
> `LLVM_TOOL_LLVM_DRIVER_BUILD`.
The variable used here is initialized via `argv[0]`
5chmidti wrote:
This feature works as intended, it is only for filtering out diagnosed issues,
not for skipping the analysis in those files. See #52959 for the feature you
are looking for. TLDR: clang-tidy currently does not skip the analysis in
(system) header files, `exclude-header-filter` i
https://github.com/mizvekov approved this pull request.
https://github.com/llvm/llvm-project/pull/112177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Yuta Saito
Date: 2024-10-15T02:41:43+09:00
New Revision: d4efc3e097f40afbe8ae275150f49bb08fc04572
URL:
https://github.com/llvm/llvm-project/commit/d4efc3e097f40afbe8ae275150f49bb08fc04572
DIFF:
https://github.com/llvm/llvm-project/commit/d4efc3e097f40afbe8ae275150f49bb08fc04572.diff
LO
https://github.com/kateinoigakukun closed
https://github.com/llvm/llvm-project/pull/111332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7f1b465c6ae476e59dc90652d58fc648932d23b1
aee63aee2c275d20596e9637905573815c01adee --e
https://github.com/mjklemm approved this pull request.
LGTM, I think this simplifies using the compiler a bit when it comes to OpenMP
and more complex `atomic` regions.
https://github.com/llvm/llvm-project/pull/112202
___
cfe-commits mailing list
cfe-
https://github.com/Artem-B updated
https://github.com/llvm/llvm-project/pull/112028
>From 5dac14aab180fd965d996b47cf983b8c462fe703 Mon Sep 17 00:00:00 2001
From: Sergey Kozub
Date: Tue, 2 Jul 2024 02:44:56 -0700
Subject: [PATCH 1/2] [CUDA] Add support for CUDA-12.6 and sm_100
---
clang/docs/R
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/112156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/112155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -44,7 +44,7 @@ unsigned char _InterlockedCompareExchange128_rel(__int64
volatile *_Destination,
__int64 *_ComparandResult);
#endif
-#ifdef __x86_64__
+#ifdef __x86_64__ && !defined(__arm64ec__)
FreddyLeaf wr
https://github.com/owenca commented:
Please update the release notes.
https://github.com/llvm/llvm-project/pull/106145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -32,6 +32,26 @@ bool isRecordLBrace(const FormatToken &Tok) {
TT_StructLBrace, TT_UnionLBrace);
}
+bool LineStartsNamespaceScope(const AnnotatedLine *Line,
+ const AnnotatedLine *PreviousLine,
+
@@ -28104,6 +28104,242 @@ TEST_F(FormatTest, BreakBinaryOperations) {
Style);
}
+TEST_F(FormatTest, WrapNamespaceBodyWithEmptyLinesNever) {
+ auto Style = getLLVMStyle();
+ Style.FixNamespaceComments = false;
+
+ // Empty namespace.
+ verifyFormat("namespace
@@ -28104,6 +28104,242 @@ TEST_F(FormatTest, BreakBinaryOperations) {
Style);
}
+TEST_F(FormatTest, WrapNamespaceBodyWithEmptyLinesNever) {
+ auto Style = getLLVMStyle();
+ Style.FixNamespaceComments = false;
+
+ // Empty namespace.
+ verifyFormat("namespace
@@ -28104,6 +28104,242 @@ TEST_F(FormatTest, BreakBinaryOperations) {
Style);
}
+TEST_F(FormatTest, WrapNamespaceBodyWithEmptyLinesNever) {
+ auto Style = getLLVMStyle();
+ Style.FixNamespaceComments = false;
+
+ // Empty namespace.
+ verifyFormat("namespace
@@ -28104,6 +28104,242 @@ TEST_F(FormatTest, BreakBinaryOperations) {
Style);
}
+TEST_F(FormatTest, WrapNamespaceBodyWithEmptyLinesNever) {
+ auto Style = getLLVMStyle();
+ Style.FixNamespaceComments = false;
+
owenca wrote:
```suggestion
S
@@ -28104,6 +28104,242 @@ TEST_F(FormatTest, BreakBinaryOperations) {
Style);
}
+TEST_F(FormatTest, WrapNamespaceBodyWithEmptyLinesNever) {
+ auto Style = getLLVMStyle();
+ Style.FixNamespaceComments = false;
+
+ // Empty namespace.
+ verifyFormat("namespace
@@ -1493,6 +1513,28 @@ static auto computeNewlines(const AnnotatedLine &Line,
Newlines = 1;
}
+ // Modify empty lines after "{" that opens namespace scope.
+ if (Style.WrapNamespaceBodyWithEmptyLines != FormatStyle::WNBWELS_Leave &&
+ LineStartsNamespaceScope(&Lin
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/106145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wzssyqa updated
https://github.com/llvm/llvm-project/pull/96281
>From 98e909e0eff233c2ee3c5e7f3094e35004326bd0 Mon Sep 17 00:00:00 2001
From: YunQiang Su
Date: Fri, 21 Jun 2024 14:28:42 +0800
Subject: [PATCH 01/12] Clang: Support minimumnum and maximumnum intrinsics
We just
https://github.com/NagyDonat approved this pull request.
LGTM, this clarifiction is useful. I feel that these tests are very slightly
too verbose, but if you already wrote them, then we might as well keep them.
https://github.com/llvm/llvm-project/pull/112019
___
@@ -192,13 +201,13 @@ GetAffectingModuleMaps(const Preprocessor &PP, Module
*RootModule) {
// The containing module map is affecting, because it's being pointed
// into by Module::DefinitionLoc.
- if (auto FE = MM.getContainingModuleMapFile(Mod))
-Mod
ilya-biryukov wrote:
> looks good to me.
Thanks!
> Please leave some time to @jansvoboda11
Will do, @jansvoboda11 PTAL when you have a spare minute.
https://github.com/llvm/llvm-project/pull/112015
___
cfe-commits mailing list
cfe-commits@lists.llvm
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/112177
>From 0a147d305d0b8839a95692612f45c0d4258c5a01 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 14 Oct 2024 17:42:17 +0800
Subject: [PATCH] [Clang] Fix a DeclContext mismatch when parsing nested lambda
pa
c8ef wrote:
You can directly view it from the Clang AST on Godbolt. For this patch, I don't
believe additional tests are necessary.
https://github.com/llvm/llvm-project/pull/112129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
@@ -0,0 +1,29 @@
+// RUN: %clang_cc1 %s -emit-llvm -o - -Wstack-exhausted
ilya-biryukov wrote:
Maybe add a mention that we cannot `-verify` the warning because it's
platform-specific (Windows does not fire it), but we still want to make sure
the compiler can ha
@@ -0,0 +1,1013 @@
+// RUN: %clang_cc1 %s -emit-llvm -o - -Wstack-exhausted -verify
+
+class AClass {
+public:
+ AClass() {}
+ AClass &foo() { return *this; }
+};
+
+void test_bar() {
+ AClass a;
+ // expected-warning@* {{stack nearly exhausted; compilation time may suffer,
a
cor3ntin wrote:
I'm still concerned that the test is going to be super flaky - I would remove
it and mention the issue this fixes by adding a comment where
runWithSufficientStackSpace is called
https://github.com/llvm/llvm-project/pull/111701
___
cfe
https://github.com/ilya-biryukov requested changes to this pull request.
Marking with "request changes" to ask removing the test per @cor3ntin's comments
https://github.com/llvm/llvm-project/pull/111701
___
cfe-commits mailing list
cfe-commits@lists.ll
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/112033
>From 411744a7a98081f03f0b9e928924dd8ef178a609 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Fri, 11 Oct 2024 14:51:46 -0400
Subject: [PATCH 1/3] [C2y] Add test coverage for N3298
This paper adds 'i'
philnik777 wrote:
> You can directly view it from the Clang AST on Godbolt. For this patch, I
> don't believe additional tests are necessary.
>
>
Any bugfix should contain a regression test. Here you could simply check that
`__has_constexpr_builtin` is true for these builtins, since that is
ilya-biryukov wrote:
Looking through the patch, I think the `getTemplateInstantiationPattern` is
what's really changed here.
https://github.com/llvm/llvm-project/pull/111852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
jurahul wrote:
> We have downstream code that used `getDeclaration` and now we have changed to
> `getOrInsertDeclaration` for all places. My understanding from reading the
> thread is that `getOrInsertDelcaration` will stay and a new `findDeclaration`
> will be added temporarily, and it will e
https://github.com/tarunprabhu updated
https://github.com/llvm/llvm-project/pull/110132
>From 61b13cf54de802351e785f50df77adc30d5e7695 Mon Sep 17 00:00:00 2001
From: Tarun Prabhu
Date: Mon, 12 Aug 2024 14:32:08 -0600
Subject: [PATCH] [clang][flang][mlir] Support -frecord-command-line option
Ad
https://github.com/tarunprabhu updated
https://github.com/llvm/llvm-project/pull/109165
>From 3b926fce8dbf42577adf54e80d3383a85b170e91 Mon Sep 17 00:00:00 2001
From: Tarun Prabhu
Date: Wed, 18 Sep 2024 09:49:26 -0600
Subject: [PATCH 1/5] [clang][flang] Support -time in both clang and flang
The
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/112126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
Implementation seems reasonable to me, a couple of nits (and please make more
detailed asserts for everything!), though I haven't paid attention to these
reviews in long enough someone else should take a look.
https://github.com/llvm/llvm-project/pull/1
@@ -6400,6 +6403,67 @@ bool Compiler::emitDestruction(const Descriptor
*Desc,
return this->emitRecordDestruction(Desc->ElemRecord, Loc);
}
+// This function is constexpr if and only if To, From, and the types of
+// all subobjects of To and From are types T such that...
+
@@ -81,6 +81,14 @@ class Boolean final {
Boolean truncate(unsigned TruncBits) const { return *this; }
+ static Boolean bitcastFromMemory(const std::byte *Buff, unsigned BitWidth) {
+assert(BitWidth == 8);
erichkeane wrote:
Perhaps a `//FIXME: ` here.
@@ -6400,6 +6403,67 @@ bool Compiler::emitDestruction(const Descriptor
*Desc,
return this->emitRecordDestruction(Desc->ElemRecord, Loc);
}
+// This function is constexpr if and only if To, From, and the types of
+// all subobjects of To and From are types T such that...
+
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/112033
>From 411744a7a98081f03f0b9e928924dd8ef178a609 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Fri, 11 Oct 2024 14:51:46 -0400
Subject: [PATCH 1/3] [C2y] Add test coverage for N3298
This paper adds 'i'
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/112185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2024-10-14T15:11:39+02:00
New Revision: 4c78c8cc2184125f86f9df194e1820b0da3158fa
URL:
https://github.com/llvm/llvm-project/commit/4c78c8cc2184125f86f9df194e1820b0da3158fa
DIFF:
https://github.com/llvm/llvm-project/commit/4c78c8cc2184125f86f9df194e1820b0da3158fa.diff
L
@@ -305,8 +307,46 @@ int main(int argc, const char **argv) {
}
}
- clang::tooling::ClangTool Tool(OptionsParser->getCompilations(),
- OptionsParser->getSourcePathList());
+ auto VFS = llvm::vfs::getRealFileSystem();
+ auto &CDB = Option
https://github.com/kadircet approved this pull request.
thanks for bearing with me, LGTM!
https://github.com/llvm/llvm-project/pull/111375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
301 - 400 of 579 matches
Mail list logo
