[clang] Clang tooling generated visibility macros for Clang (PR #109702)

2024-10-14 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > Processing just header is also much faster than a full build and I think it > would only have to run on changed headers and source files for a PR. Any ideas how to implement that check? If we have a draft implementation we can check with the the ci folks how to deploy it...

[clang] Reapply "[clang][CodeGen] Zero init unspecified fields in initializers in C" (#109898) (PR #110051)

2024-10-14 Thread via cfe-commits
https://github.com/yabinc closed https://github.com/llvm/llvm-project/pull/110051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-14 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/111975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang: Remove requires system-linux from some driver tests (PR #111976)

2024-10-14 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/111976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5b330a7 - clang: Fix hipstdpar test relying on default target (#111975)

2024-10-14 Thread via cfe-commits
Author: Matt Arsenault Date: 2024-10-15T09:45:53+04:00 New Revision: 5b330a72a027fb557704a543010fa9656d547023 URL: https://github.com/llvm/llvm-project/commit/5b330a72a027fb557704a543010fa9656d547023 DIFF: https://github.com/llvm/llvm-project/commit/5b330a72a027fb557704a543010fa9656d547023.diff

[clang] clang/AMDGPU: Set noalias.addrspace metadata on atomicrmw (PR #102462)

2024-10-14 Thread Matt Arsenault via cfe-commits
arsenm wrote: ping https://github.com/llvm/llvm-project/pull/102462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix a typo (PR #112283)

2024-10-14 Thread via cfe-commits
github-actions[bot] wrote: @thevar1able Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang-tools-extra] 57d109c - [clang-tidy][NFC] Fix a typo (#112283)

2024-10-14 Thread via cfe-commits
Author: Konstantin Bogdanov Date: 2024-10-15T07:53:08+02:00 New Revision: 57d109c4c93c8cf2d7ff9e5877a48152ed7a617a URL: https://github.com/llvm/llvm-project/commit/57d109c4c93c8cf2d7ff9e5877a48152ed7a617a DIFF: https://github.com/llvm/llvm-project/commit/57d109c4c93c8cf2d7ff9e5877a48152ed7a617a

[clang-tools-extra] [clang-tidy] Fix a typo (PR #112283)

2024-10-14 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/112283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix a typo (PR #112283)

2024-10-14 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Thank you for the contribution! I've added [NFC] (non functional change) to the commit message title. https://github.com/llvm/llvm-project/pull/112283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-14 Thread David Green via cfe-commits
@@ -1159,7 +1159,9 @@ class ARMOperand : public MCParsedAsmOperand { if (!isImm()) return false; const MCConstantExpr *CE = dyn_cast(getImm()); if (!CE) return false; davemgreen wrote: Can this check that CE->getActiveBits() > 32? https://github.c

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-14 Thread Boaz Brickner via cfe-commits
@@ -1383,6 +1394,15 @@ static void checkExprLifetimeImpl(Sema &SemaRef, << nextPathEntryRange(Path, I + 1, L); break; } + + case IndirectLocalPathEntry::DefaultArg: { +const auto *DAE = cast(Elem.E); +SemaRef.Diag(DAE->getParam()->

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-14 Thread Boaz Brickner via cfe-commits
@@ -107,6 +107,39 @@ namespace std { using std::operator""s; using std::operator""sv; +namespace default_args { + using IntArray = int[]; bricknerb wrote: Is this helpful if this is only used once? https://github.com/llvm/llvm-project/pull/112047 __

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-14 Thread Boaz Brickner via cfe-commits
@@ -107,6 +107,39 @@ namespace std { using std::operator""s; using std::operator""sv; +namespace default_args { + using IntArray = int[]; + const int *defaultparam1(const int &def1 [[clang::lifetimebound]] = 0); // #def1 + const int &defaultparam_array([[clang::lifetimebou

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-14 Thread Boaz Brickner via cfe-commits
@@ -107,6 +107,39 @@ namespace std { using std::operator""s; using std::operator""sv; +namespace default_args { + using IntArray = int[]; + const int *defaultparam1(const int &def1 [[clang::lifetimebound]] = 0); // #def1 + const int &defaultparam_array([[clang::lifetimebou

[clang] 51d0e40 - [clang][bytecode] Fix __builtin_convertvector with float-cast (#112238)

2024-10-14 Thread via cfe-commits
Author: Timm Baeder Date: 2024-10-15T07:49:55+02:00 New Revision: 51d0e40c2ee1ab25f408f22e82ef4e16d6fb3103 URL: https://github.com/llvm/llvm-project/commit/51d0e40c2ee1ab25f408f22e82ef4e16d6fb3103 DIFF: https://github.com/llvm/llvm-project/commit/51d0e40c2ee1ab25f408f22e82ef4e16d6fb3103.diff L

[clang] [clang][bytecode] Fix __builtin_convertvector with float-cast (PR #112238)

2024-10-14 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/112238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix templated array size calculation. (PR #96464)

2024-10-14 Thread via cfe-commits
github-actions[bot] wrote: @awson Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, y

[clang] [clang] When checking for covariant return types, make sure the pointers or references are to *classes* (PR #111856)

2024-10-14 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb updated https://github.com/llvm/llvm-project/pull/111856 >From 786d31e2657964e578cd1fdf2006b0fb3b19fab6 Mon Sep 17 00:00:00 2001 From: Boaz Brickner Date: Thu, 10 Oct 2024 15:15:23 + Subject: [PATCH 1/5] [clang] When checking for covariant return types, make su

[clang] [Clang][Sema] Fix templated array size calculation. (PR #96464)

2024-10-14 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/96464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 37bd788 - [Clang][Sema] Fix templated array size calculation. (#96464)

2024-10-14 Thread via cfe-commits
Author: awson Date: 2024-10-15T07:52:02+02:00 New Revision: 37bd788138e1f18d5e327de28a6940da57cdcde8 URL: https://github.com/llvm/llvm-project/commit/37bd788138e1f18d5e327de28a6940da57cdcde8 DIFF: https://github.com/llvm/llvm-project/commit/37bd788138e1f18d5e327de28a6940da57cdcde8.diff LOG: [C

[clang] [flang] [flang] Link to libatomic with openmp and rtlib=libgcc (PR #112202)

2024-10-14 Thread via cfe-commits
https://github.com/NimishMishra approved this pull request. LGTM! Thanks for this. The Windows CI failure seems to be in `Driver/atomic.f90`. Do we disable this test on Windows (if there is a way to do so)? https://github.com/llvm/llvm-project/pull/112202 __

[clang] Fieldregion descript name (PR #112313)

2024-10-14 Thread via cfe-commits
https://github.com/T-Gruber created https://github.com/llvm/llvm-project/pull/112313 The current implementation of MemRegion::getDescriptiveName fails for FieldRegions whose SuperRegion is an ElementRegion. As outlined below: ```Cpp struct val_struct { int val; }; extern struct val_struct val_s

[clang] Fieldregion descript name (PR #112313)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: None (T-Gruber) Changes The current implementation of MemRegion::getDescriptiveName fails for FieldRegions whose SuperRegion is an ElementRegion. As outlined below: ```Cpp struct val_struct { int val; }; extern struct val

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-14 Thread Boaz Brickner via cfe-commits
@@ -1370,7 +1381,7 @@ static void checkExprLifetimeImpl(Sema &SemaRef, break; } - case IndirectLocalPathEntry::LambdaCaptureInit: + case IndirectLocalPathEntry::LambdaCaptureInit: { bricknerb wrote: Revert this change as it seems unrel

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-14 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb deleted https://github.com/llvm/llvm-project/pull/112047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-14 Thread Boaz Brickner via cfe-commits
@@ -1370,7 +1381,7 @@ static void checkExprLifetimeImpl(Sema &SemaRef, break; } - case IndirectLocalPathEntry::LambdaCaptureInit: + case IndirectLocalPathEntry::LambdaCaptureInit: { bricknerb wrote: Revert this change as it is unrelate

[clang] [Clang][TableGen] Use const pointer for various `Init` pointers. (PR #112318)

2024-10-14 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/112318 None >From a9ded784183d3df06434814af9e0ca32d9ef907f Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Mon, 14 Oct 2024 22:56:07 -0700 Subject: [PATCH] [Clang][TableGen] Use const pointer for various `Init` poin

[clang] [Clang][TableGen] NeonEmitter (PR #112317)

2024-10-14 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/112317 None >From 6dfa15a4c498855bc8bfe363671b7ee17d55d980 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Mon, 14 Oct 2024 23:12:24 -0700 Subject: [PATCH] [Clang][TableGen] NeonEmitter --- clang/utils/TableGen/Neo

[clang] [llvm] Add ifunc support for Windows on AArch64. (PR #111962)

2024-10-14 Thread Daniel Kiss via cfe-commits
@@ -0,0 +1,65 @@ +// RUN: %clang_cc1 -triple aarch64-pc-windows-msvc -emit-llvm -o - %s | FileCheck %s DanielKristofKiss wrote: So far, but other targets could be added here later without too much change to the test. https://github.com/llvm/llvm-project/pull/1

[clang] [Clang][TableGen] NeonEmitter (PR #112317)

2024-10-14 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/112317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use const pointers for various Init objects in NeonEmitter (PR #112317)

2024-10-14 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/112317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-10-14 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/108786 >From c2be824d5935b57a87a7ccf618ee4eecf55b4e3a Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 17 Sep 2024 21:47:45 -0400 Subject: [PATCH] [IR] Introduce `T` to `DataLayout` to represent flat address spa

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/112248 Summary: Currently, we want to use the OpenCL attributes to indicate the address space. Languages like SYCL, OpenMP, HIP, and CUDA allow their address space qualifiers to be implicitly converted to generic, as do

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-webassembly @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: Currently, we want to use the OpenCL attributes to indicate the address space. Languages like SYCL, OpenMP, HIP, and CUDA allow their address space qualifiers

[clang] [Headers] [ARM64EC] Fix extra tokens inside intrin0.h preprocessor directive (PR #112066)

2024-10-14 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 closed https://github.com/llvm/llvm-project/pull/112066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9bf68c2 - [Headers] [ARM64EC] Fix extra tokens inside intrin0.h preprocessor directive (#112066)

2024-10-14 Thread via cfe-commits
Author: Max Winkler Date: 2024-10-14T12:22:25-07:00 New Revision: 9bf68c2400e8966511332dfbf5c0f05e8a3300fa URL: https://github.com/llvm/llvm-project/commit/9bf68c2400e8966511332dfbf5c0f05e8a3300fa DIFF: https://github.com/llvm/llvm-project/commit/9bf68c2400e8966511332dfbf5c0f05e8a3300fa.diff L

[clang] [lld] [llvm] [mlir] [IR] Introduce `U` to `DataLayout` to represent undesirable address space if a target has it (PR #108786)

2024-10-14 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/108786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e052c4c - [NFC] [MTE] Use aarch64-linux-android34 for globals test (#112050)

2024-10-14 Thread via cfe-commits
Author: Florian Mayer Date: 2024-10-14T12:31:49-07:00 New Revision: e052c4c2b9a051fb9fd6a4bc25dc48ed9e1c6a69 URL: https://github.com/llvm/llvm-project/commit/e052c4c2b9a051fb9fd6a4bc25dc48ed9e1c6a69 DIFF: https://github.com/llvm/llvm-project/commit/e052c4c2b9a051fb9fd6a4bc25dc48ed9e1c6a69.diff

[clang] [NFC] [MTE] Use aarch64-linux-android34 for globals test (PR #112050)

2024-10-14 Thread Florian Mayer via cfe-commits
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/112050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] When checking for covariant return types, make sure the pointers or references are to *classes* (PR #111856)

2024-10-14 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Track function template instantiation from definition (PR #112241)

2024-10-14 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/112241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang][CodeGen] Zero init unspecified fields in initializers in C" (#109898) (PR #110051)

2024-10-14 Thread Eli Friedman via cfe-commits
@@ -1774,6 +1795,54 @@ void AggExprEmitter::VisitCXXParenListOrInitListExpr( } } } + if (ZeroInitPadding) { +uint64_t TotalSize = CGF.getContext().toBits( +Dest.getPreferredSize(CGF.getContext(), DestLV.getType())); +DoZeroInitPadding(PaddingStart,

[clang] Reapply "[clang][CodeGen] Zero init unspecified fields in initializers in C" (#109898) (PR #110051)

2024-10-14 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/110051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang][CodeGen] Zero init unspecified fields in initializers in C" (#109898) (PR #110051)

2024-10-14 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/110051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for aligning BlockComments in declarations (PR #109497)

2024-10-14 Thread via cfe-commits
JessehMSFT wrote: Friendly ping @mydeveloperday https://github.com/llvm/llvm-project/pull/109497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Suport LLVM Driver (PR #112249)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Petr Hosek (petrhosek) Changes This addresses an issue introduced in #112041. --- Full diff: https://github.com/llvm/llvm-project/pull/112249.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/HIPUtility.cpp (+7-6)

[clang] [HIP] Suport LLVM Driver (PR #112249)

2024-10-14 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/112249 This addresses an issue introduced in #112041. >From 8f2e6b76edf09812cfb9a26b13ebcadf711f8b8e Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Mon, 14 Oct 2024 18:49:29 + Subject: [PATCH] [HIP] Suport LLVM

[clang] [lld] [llvm] [mlir] [IR] Introduce `U` to `DataLayout` to represent undesirable address space if a target has it (PR #108786)

2024-10-14 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/108786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Arvind Sudarsanam via cfe-commits
asudarsa wrote: Good point. I will create them inside the test case. I was trying to 'mimic' device library file usage. I suppose it's overkill. Thanks. https://github.com/llvm/llvm-project/pull/112245 ___ cfe-commit

[clang] 66723a0 - [HIP] Suport LLVM Driver (#112249)

2024-10-14 Thread via cfe-commits
Author: Petr Hosek Date: 2024-10-14T12:43:38-07:00 New Revision: 66723a07d8c5e83329a37766c4cccfc4dbe6bb67 URL: https://github.com/llvm/llvm-project/commit/66723a07d8c5e83329a37766c4cccfc4dbe6bb67 DIFF: https://github.com/llvm/llvm-project/commit/66723a07d8c5e83329a37766c4cccfc4dbe6bb67.diff LO

[clang] [HIP] Suport LLVM Driver (PR #112249)

2024-10-14 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/112249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Suport LLVM Driver (PR #112249)

2024-10-14 Thread Petr Hosek via cfe-commits
@@ -466,7 +467,7 @@ void HIP::constructGenerateObjFileFromHIPFatBinary( "-o", Output.getFilename(), "-x", "assembler", ObjinFile, "-c"}; - const char *Clang = Args.MakeArgString(C.getDriver().ClangE

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Arvind Sudarsanam via cfe-commits
@@ -95,7 +95,19 @@ void SPIRV::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("-o"); CmdArgs.push_back(Output.getFilename()); + // Use of --sycl-link will call the clang-sycl-link-wrapper instead of + // the default linker (spirv-link). + i

[clang] [llvm] Add ifunc support for Windows on AArch64. (PR #111962)

2024-10-14 Thread Martin Storsjö via cfe-commits
@@ -1505,6 +1505,10 @@ class TargetInfo : public TransferrableTargetInfo, bool supportsIFunc() const { if (getTriple().isOSBinFormatMachO()) return true; +if (getTriple().isOSWindows() && getTriple().isAArch64()) + return true; +if (getTriple().getArch(

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I think the default AS is expected to be losslessly converted to other AS but > not the other way around, though I understand it is not clearly stated in > LangRef or other places and a lot of code just assumes it can. All the other language address spaces (cuda, OpenMP, sycl)

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c4131cb56c9de616442525b1f02162eb470df1f8 f173e127c135f88ea37aef26010583078063c202 --e

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
https://github.com/ronlieb approved this pull request. https://github.com/llvm/llvm-project/pull/112274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread Yuta Saito via cfe-commits
kateinoigakukun wrote: Sorry, I opened a build fix PR here https://github.com/llvm/llvm-project/pull/112275 https://github.com/llvm/llvm-project/pull/112274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [Clang] Fix a DeclContext mismatch when parsing nested lambda parameters (PR #112177)

2024-10-14 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/112177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3733b0c - [Clang] Fix a DeclContext mismatch when parsing nested lambda parameters (#112177)

2024-10-14 Thread via cfe-commits
Author: Younan Zhang Date: 2024-10-15T12:52:31+08:00 New Revision: 3733b0cff314e1427b1a905e6e7438b536f9a96d URL: https://github.com/llvm/llvm-project/commit/3733b0cff314e1427b1a905e6e7438b536f9a96d DIFF: https://github.com/llvm/llvm-project/commit/3733b0cff314e1427b1a905e6e7438b536f9a96d.diff

[clang] [Clang][Sema] Fix templated array size calculation. (PR #96464)

2024-10-14 Thread via cfe-commits
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464 >From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001 From: awson Date: Mon, 24 Jun 2024 10:34:51 +0300 Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early. --- clang/lib/Se

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Matt Arsenault via cfe-commits
arsenm wrote: > I'm thinking we could have a language option like > `-fimplicit-default-addrspace-cast` that allows all conversions to default. > Then if we want users to be aware that this even exists we could suggest it > in the error message if it would fix it. > > I do understand that the

[clang] [clang] LazyOffsetPtr: Use native pointer width (PR #111995)

2024-10-14 Thread Sam James via cfe-commits
thesamesam wrote: cc @glaubitz (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113341) https://github.com/llvm/llvm-project/pull/111995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-10-14 Thread via cfe-commits
=?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Po

[clang-tools-extra] [clang-tidy] [docs] Replace _not_ in reserved-identifier.rst with *not* (PR #112162)

2024-10-14 Thread Nick Riasanovsky via cfe-commits
https://github.com/njriasan updated https://github.com/llvm/llvm-project/pull/112162 >From e5a70cb2f9d744716e376ec0939645a7b0365ead Mon Sep 17 00:00:00 2001 From: Nicholas Riasanovsky Date: Mon, 14 Oct 2024 01:42:39 -0400 Subject: [PATCH] Replace _not_ in reserved-identifier.rst from the clang-

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Testing like that is fine, it's just that you can do `clang_cc1 -emit-llvm %s -o %t.bc` or something. https://github.com/llvm/llvm-project/pull/112245 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-14 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH] [Clang] fix range calculation for conditionals with throw expr

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
https://github.com/dpalermo closed https://github.com/llvm/llvm-project/pull/112274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
dpalermo wrote: > Sorry, I opened a build fix PR here #112275 Thanks for the fix! Closing revert. https://github.com/llvm/llvm-project/pull/112274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [lld] [llvm] [WebAssembly] Enable nontrapping-fptoint and bulk-memory by default. (PR #112049)

2024-10-14 Thread Sam Clegg via cfe-commits
@@ -2,7 +2,7 @@ ; RUN: llvm-as -o %t.o %s ; RUN: llvm-as -o %t2.o %S/Inputs/libcall-archive.ll ; RUN: llvm-ar rcs %t.a %t2.o -; RUN: wasm-ld -o %t %t.o %t.a +; RUN: wasm-ld -mllvm -mattr=-bulk-memory -o %t %t.o %t.a sbc100 wrote: Why is this needed? Should th

[clang-tools-extra] Add option to exclude headers from clang-tidy analysis (PR #91400)

2024-10-14 Thread SwanBai Lei27 via cfe-commits
Baiyi27 wrote: > This feature works as intended, it is only for filtering out diagnosed > issues, not for skipping the analysis in those files. See #52959 for the > feature you are looking for. TLDR: clang-tidy currently does not skip the > analysis in (system) header files, `exclude-header-fi

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-10-14 Thread Chuanqi Xu via cfe-commits
@@ -192,13 +201,13 @@ GetAffectingModuleMaps(const Preprocessor &PP, Module *RootModule) { // The containing module map is affecting, because it's being pointed // into by Module::DefinitionLoc. - if (auto FE = MM.getContainingModuleMapFile(Mod)) -Mod

[clang] ee64684 - Revert "[clang-format] Correctly annotate */& in if condition with braced init (#109505)"

2024-10-14 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-10-14T19:29:44-07:00 New Revision: ee6468494e08651ec7f534781693408f34a74753 URL: https://github.com/llvm/llvm-project/commit/ee6468494e08651ec7f534781693408f34a74753 DIFF: https://github.com/llvm/llvm-project/commit/ee6468494e08651ec7f534781693408f34a74753.diff LOG:

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-14 Thread Chuanqi Xu via cfe-commits
@@ -10057,15 +10057,18 @@ void ASTReader::finishPendingActions() { // For a function defined inline within a class template, force the // canonical definition to be the one inside the canonical definition of // the template. This ensures that we instantiate fr

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Alexey Bader via cfe-commits
@@ -721,7 +721,9 @@ class Qualifiers { // to implicitly cast into the default address space. (A == LangAS::Default && (B == LangAS::cuda_constant || B == LangAS::cuda_device || - B == LangAS::cuda_shared)); + B == LangAS

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Arvind Sudarsanam via cfe-commits
asudarsa wrote: Hi @jhuber6 Thanks much for providing your feedback. I will address all your comments in an upcoming commit. Sincerely https://github.com/llvm/llvm-project/pull/112245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [Headers] [ARM64EC] Fix extra tokens inside intrin0.h preprocessor directive (PR #112066)

2024-10-14 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: /cherry-pick 9bf68c2400e8966511332dfbf5c0f05e8a3300fa https://github.com/llvm/llvm-project/pull/112066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers] [ARM64EC] Fix extra tokens inside intrin0.h preprocessor directive (PR #112066)

2024-10-14 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic milestoned https://github.com/llvm/llvm-project/pull/112066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix a DeclContext mismatch when parsing nested lambda parameters (PR #112177)

2024-10-14 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/112177 >From 78657277495bbd1f82faef655c49320a4315272f Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 14 Oct 2024 17:42:17 +0800 Subject: [PATCH 1/4] [Clang] Fix a DeclContext mismatch when parsing nested lambd

[clang] [Clang] Instantiate Typedefs referenced by type alias deduction guides (PR #111804)

2024-10-14 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 milestoned https://github.com/llvm/llvm-project/pull/111804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Instantiate Typedefs referenced by type alias deduction guides (PR #111804)

2024-10-14 Thread Younan Zhang via cfe-commits
zyn0217 wrote: I'll go ahead and backport it - this bug was first introduced by sugar preservation on CTAD guides included in the 19.x cycle. /backport 0bc02b999a https://github.com/llvm/llvm-project/pull/111804 ___ cfe-commits mailing list cfe-commi

[clang] [Clang][Sema] Fix templated array size calculation. (PR #96464)

2024-10-14 Thread via cfe-commits
awson wrote: > If you have approvals you don't have to wait for other reviewers unless they > have made a comment that required a change and you them to confirm the fix or > they explicitly blocked the review. I believe I have no write access to the repo. Could you, please, merge this? @cor3

[clang] [lld] [Driver] Default enable LoongArch linker relaxation (PR #111488)

2024-10-14 Thread via cfe-commits
https://github.com/ywgrit edited https://github.com/llvm/llvm-project/pull/111488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix a typo (PR #112283)

2024-10-14 Thread Konstantin Bogdanov via cfe-commits
https://github.com/thevar1able updated https://github.com/llvm/llvm-project/pull/112283 >From c9db5830f95727601900aa9a87c0970ecfbf5c76 Mon Sep 17 00:00:00 2001 From: Konstantin Bogdanov Date: Tue, 15 Oct 2024 03:06:46 +0200 Subject: [PATCH] Fix a typo --- .../CrtpConstructorAccessibilityCheck

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > I think the default AS is expected to be losslessly converted to other AS but > not the other way around, though I understand it is not clearly stated in > LangRef or other places and a lot of code just assumes it can. I don't think this expectation is thoroughly encoded anywh

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Running into an observable situation where this is a concern means that > either you've messed around with (non C/C++) attributes, or are linking in > something exciting. Neither of which constitutes valid C/C++, and I'm leaning > towards saying shouldn't be allowed to silentl

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > > Running into an observable situation where this is a concern means that > > either you've messed around with (non C/C++) attributes, or are linking in > > something exciting. Neither of which constitutes valid C/C++, and I'm > > leaning towards saying shouldn't be allowed to

[clang] [flang] [flang][Driver] Add support for -f[no-]wrapv and -f[no]-strict-overflow in the frontend (PR #110061)

2024-10-14 Thread Yusuke MINATO via cfe-commits
yus3710-fj wrote: Gentle ping @MaskRay. https://github.com/llvm/llvm-project/pull/110061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-14 Thread Yitzhak Mandelbaum via cfe-commits
@@ -28,12 +28,24 @@ #include "clang/Analysis/FlowSensitive/MatchSwitch.h" #include "clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h" #include "clang/Analysis/FlowSensitive/WatchedLiteralsSolver.h" +#include "clang/Support/Compiler.h" #include "llvm/ADT/STLExtras.h"

[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-14 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand requested changes to this pull request. https://github.com/llvm/llvm-project/pull/108051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MTE] Apply alignment / size in AsmPrinter rather than IR (PR #111918)

2024-10-14 Thread Florian Mayer via cfe-commits
https://github.com/fmayer ready_for_review https://github.com/llvm/llvm-project/pull/111918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MTE] Apply alignment / size in AsmPrinter rather than IR (PR #111918)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-backend-aarch64 Author: Florian Mayer (fmayer) Changes This greatly simplifies the code, and makes sure no optimizations are applied that assume the bigger alignment or size, which could be incorrect if we link together

[clang] [llvm] [MTE] Apply alignment / size in AsmPrinter rather than IR (PR #111918)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Florian Mayer (fmayer) Changes This greatly simplifies the code, and makes sure no optimizations are applied that assume the bigger alignment or size, which could be incorrect if we link together with non-instrumented code. --- Full diff:

[clang] [clang-tools-extra] [clangd] Update clangDaemonTweaks to set symbol visibility macros (PR #112304)

2024-10-14 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod created https://github.com/llvm/llvm-project/pull/112304 Update clangDaemonTweaks cmake target to set explicit symbol visibility macros to correct mode for windows. This will fix linker duplicate symbols errors from clangDaemonTweaks exporting clang symbols instead of

[clang] [clang-tools-extra] [clangd] Update clangDaemonTweaks to set symbol visibility macros (PR #112304)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Thomas Fransham (fsfod) Changes Update clangDaemonTweaks cmake target to set explicit symbol visibility macros to correct mode for windows. This will fix linker duplicate symbols errors from clangDaemonTweaks exporting clang symbols inste

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-10-14 Thread Jiaxun Yang via cfe-commits
=?utf-8?q?Herv=C3=A9?= Poussineau , =?utf-8?q?Herv=C3=A9?= Poussineau , =?utf-8?q?Herv=C3=A9?= Poussineau , =?utf-8?q?Herv=C3=A9?= Poussineau , =?utf-8?q?Herv=C3=A9?= Poussineau , =?utf-8?q?Herv=C3=A9?= Poussineau , =?utf-8?q?Herv=C3=A9?= Poussineau , =?utf-8?q?Herv=C3=A9?= Poussineau , =?utf-8?q?H

[clang] [Clang][Driver][AArch64] Add support for aarch64-amazon-linux triple (PR #109263)

2024-10-14 Thread Peter Waller via cfe-commits
peterwaller-arm wrote: OK, Thanks for the input all. I'm abandoning this change, I'm not following up for the time being if someone is able to fix this. Part of the problem is that it's not clear what a clean/correct cmake check would be to determine the triple. My current thinking is that cma

[clang] [Clang][Driver][AArch64] Add support for aarch64-amazon-linux triple (PR #109263)

2024-10-14 Thread Peter Waller via cfe-commits
https://github.com/peterwaller-arm closed https://github.com/llvm/llvm-project/pull/109263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [WebAssembly] Enable nontrapping-fptoint and bulk-memory by default. (PR #112049)

2024-10-14 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode updated https://github.com/llvm/llvm-project/pull/112049 >From 95ad4b292a442b56149ef7f2731671f9bd5c56c1 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Fri, 11 Oct 2024 13:31:13 -0700 Subject: [PATCH 1/3] [WebAssembly] Enable nontrapping-fptoint and bulk-memory b

<    1   2   3   4   5   6   >