@@ -5616,6 +5616,10 @@ class TargetLowering : public TargetLoweringBase {
return true;
}
+protected:
+ // Simple interface for targets without a Module dependency
arichardson wrote:
There probably aren't that many overrides here? Maybe easiest to just
https://github.com/cjappl approved this pull request.
LGTM.
Will let a little time pass to let Sirraide chime in, because this section of
the code isn't my forte. If you want this merged ASAP @dougsonos and you feel
confident in it, ping me and I can merge.
https://github.com/llvm/llvm-proje
https://github.com/lanza updated
https://github.com/llvm/llvm-project/pull/111417
>From 68b7427f371db198a1dc69c36c39192f2f9ab6a9 Mon Sep 17 00:00:00 2001
From: Nathan Lanza
Date: Mon, 7 Oct 2024 18:27:46 +
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/111035
>From e8d355c9cd165e0a255bbbfb5b0126cf7b1461a6 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Wed, 2 Oct 2024 12:56:43 -0500
Subject: [PATCH 1/7] initial work for pragma export & _Export keyword
---
clang/in
https://github.com/keith-packard updated
https://github.com/llvm/llvm-project/pull/110928
>From ad3d5b03886aa7939d67aef10e31734db7c43834 Mon Sep 17 00:00:00 2001
From: Keith Packard
Date: Sun, 6 Oct 2024 23:19:30 -0700
Subject: [PATCH 1/5] [CodeGen] Provide Module to useLoadStackGuardNode
Use
gburgessiv wrote:
Hey Damyan, GH suggested you as a reviewer for this. Would you be able to TAL?
Happy to find someone else if not :)
https://github.com/llvm/llvm-project/pull/111439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
@@ -5616,6 +5616,10 @@ class TargetLowering : public TargetLoweringBase {
return true;
}
+protected:
+ // Simple interface for targets without a Module dependency
keith-packard wrote:
Yup, that makes things look cleaner. Good idea.
https://github.com/
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/111453
When using clang-tidy from a compilation database, some options might not be
recognized by clang if the compilation database was generated for another
compiler. This forces the user to add conditional code in
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Félix-Antoine Constantin (felix642)
Changes
When using clang-tidy from a compilation database, some options might not be
recognized by clang if the compilation database was generated for another
compiler. This forces the user
https://github.com/keith-packard updated
https://github.com/llvm/llvm-project/pull/111235
>From 08ed820b2bc6235998e47c49eb3029b7945b5fec Mon Sep 17 00:00:00 2001
From: Keith Packard
Date: Fri, 4 Oct 2024 21:06:37 -0700
Subject: [PATCH 1/2] [libunwind] Support aarch64 without FPU
Skip save/rest
https://github.com/JessehMSFT updated
https://github.com/llvm/llvm-project/pull/109497
>From 38333491868dfad9c84719d9dd8fd872a2aa7584 Mon Sep 17 00:00:00 2001
From: Jesse Harvey
Date: Fri, 20 Sep 2024 16:40:35 -0700
Subject: [PATCH 1/2] Add support for aligning BlockComments in declarations
--
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/108614
>From 1bbb7e5291bb59d95d8b308a90620a4d70e35152 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 13 Sep 2024 08:51:00 -0700
Subject: [PATCH 1/5] [CGData][ThinLTO] Global Outlining with Two-CodeGen
Round
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/111010
>From 70089645ec5cf62b491a56df96ec46f4328fbc11 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 3 Oct 2024 11:43:51 -0700
Subject: [PATCH 1/8] [HLSL] Implement `WaveReadLaneAt` intrinsic
- create a cl
Author: Owen Pan
Date: 2024-10-07T19:10:24-07:00
New Revision: 4b6e41b61e2edea2f80de3639e589301fe7c896c
URL:
https://github.com/llvm/llvm-project/commit/4b6e41b61e2edea2f80de3639e589301fe7c896c
DIFF:
https://github.com/llvm/llvm-project/commit/4b6e41b61e2edea2f80de3639e589301fe7c896c.diff
LOG:
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/111229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-10-07T19:12:47-07:00
New Revision: 65688274b14f5d0e7dabbbaf9f3fd135646ef1d1
URL:
https://github.com/llvm/llvm-project/commit/65688274b14f5d0e7dabbbaf9f3fd135646ef1d1
DIFF:
https://github.com/llvm/llvm-project/commit/65688274b14f5d0e7dabbbaf9f3fd135646ef1d1.diff
LOG:
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/111285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,32 @@
+// RUN: rm -fR %t
+// RUN: split-file %s %t
+// RUN: cd %t
+// RUN: %clang_cc1 -verify -std=c++20 -fskip-odr-check-in-gmf
-emit-header-unit -xc++-user-header bz0.h
+// RUN: %clang_cc1 -verify -std=c++20 -fskip-odr-check-in-gmf
-emit-header-unit -xc++-user-heade
@@ -2527,7 +2527,7 @@ class BitsUnpacker {
inline bool shouldSkipCheckingODR(const Decl *D) {
return D->getASTContext().getLangOpts().SkipODRCheckInGMF &&
- D->isFromGlobalModule();
+ (D->isFromGlobalModule() || !D->isInNamedModule());
Chuanq
https://github.com/ChuanqiXu9 approved this pull request.
Thanks.
The underlying issue worths more investigating. But giving we don't have enough
developers on modules and RV, maybe this is the best thing we can do now.
https://github.com/llvm/llvm-project/pull/111360
_
https://github.com/ChuanqiXu9 commented:
I'll leave this to @cor3ntin
https://github.com/llvm/llvm-project/pull/110496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #111346.
---
Full diff: https://github.com/llvm/llvm-project/pull/111465.diff
2 Files Affected:
- (modified) clang/lib/Format/TokenAnnotator.cpp (+4)
- (modified) clang/unittests/Format/FormatTest
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/111465
Fixes #111346.
>From 9d9405d55fbaeea13d80bb394402fee2f0ef34ca Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 7 Oct 2024 19:34:16 -0700
Subject: [PATCH] [clang-format] Insert a space between l_paren and
ref-
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d1335fb86466221b0499db5fc8f158f1f64d9542
c241379b66fc4bb9d640403efc7e86b609a7200c --e
https://github.com/peilin-ye edited
https://github.com/llvm/llvm-project/pull/108636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/keith-packard updated
https://github.com/llvm/llvm-project/pull/110928
>From ad3d5b03886aa7939d67aef10e31734db7c43834 Mon Sep 17 00:00:00 2001
From: Keith Packard
Date: Sun, 6 Oct 2024 23:19:30 -0700
Subject: [PATCH 1/5] [CodeGen] Provide Module to useLoadStackGuardNode
Use
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/110446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1631,13 +1631,39 @@ static bool allLookupResultsAreTheSame(const
DeclContext::lookup_result &R) {
static NamedDecl* getLambdaCallOperatorHelper(const CXXRecordDecl &RD) {
if (!RD.isLambda()) return nullptr;
DeclarationName Name =
-RD.getASTContext().DeclarationName
https://github.com/ChuanqiXu9 approved this pull request.
Thanks. LGTM with nits.
https://github.com/llvm/llvm-project/pull/110446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1631,13 +1631,39 @@ static bool allLookupResultsAreTheSame(const
DeclContext::lookup_result &R) {
static NamedDecl* getLambdaCallOperatorHelper(const CXXRecordDecl &RD) {
if (!RD.isLambda()) return nullptr;
DeclarationName Name =
-RD.getASTContext().DeclarationName
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
@llvm/pr-subscribers-clang
Author: Brandon Wu (4vtomat)
Changes
It's illegal if the index is 64 bits and is zero-extend to 32 bits.
---
Full diff: https://github.com/llvm/llvm-project/pull/111466.diff
1 Files Affected:
- (modified) cl
topperc wrote:
test?
https://github.com/llvm/llvm-project/pull/111466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/4vtomat created
https://github.com/llvm/llvm-project/pull/111466
It's illegal if the index is 64 bits and is zero-extend to 32 bits.
>From 6e11ffa9585cf189382501d44915f211abd4be46 Mon Sep 17 00:00:00 2001
From: Brandon Wu
Date: Mon, 7 Oct 2024 19:33:41 -0700
Subject: [PATCH
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/111467
None
>From fd6654f61025f4dc5b38a02d5c4ec3b52fe2c726 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Mon, 7 Oct 2024 07:04:14 -0700
Subject: [PATCH] [Basic] Avoid repeated hash lookups (NFC)
---
clang/
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/111469
None
>From 63f32da83241327082af3baa57f59480d9825e47 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Mon, 7 Oct 2024 07:06:16 -0700
Subject: [PATCH] [Tooling] Avoid repeated hash lookups (NFC)
---
clan
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/111469.diff
1 Files Affected:
- (modified) clang/lib/Tooling/Inclusions/HeaderIncludes.cpp (+3-6)
``diff
diff --git a/clang/lib/To
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/111468
None
>From 9bc29851603347edbc4324ccbdb4fef47a1c2626 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Mon, 7 Oct 2024 07:06:51 -0700
Subject: [PATCH] [Driver] Avoid repeated hash lookups (NFC)
---
clang
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/111468.diff
1 Files Affected:
- (modified) clang/lib/Driver/MultilibBuilder.cpp (+2-4)
``diff
diff --git a/clang/lib/Driver/Multil
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/111467.diff
1 Files Affected:
- (modified) clang/include/clang/Basic/PlistSupport.h (+4-7)
``diff
diff --git a/clang/include/clang
https://github.com/kateinoigakukun updated
https://github.com/llvm/llvm-project/pull/111332
>From 605e1ad180c9f75fd59d8b783ae2041cbaf34e50 Mon Sep 17 00:00:00 2001
From: Yuta Saito
Date: Sat, 5 Oct 2024 16:54:57 +
Subject: [PATCH 1/9] [compiler-rt][profile] Add initial support for
WebAssem
https://github.com/4vtomat updated
https://github.com/llvm/llvm-project/pull/111466
>From cd79ab5782175de38adfa6b171270766d2544204 Mon Sep 17 00:00:00 2001
From: Brandon Wu
Date: Mon, 7 Oct 2024 19:33:41 -0700
Subject: [PATCH] [clang][RISCV] Make the index of riscv_tuple_extract and
riscv_tupl
4vtomat wrote:
> test?
Added!
https://github.com/llvm/llvm-project/pull/111466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/111472
>From 4936acf06c30c1e9a3a300ec712845a4c56d5cd0 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 7 Oct 2024 23:08:44 -0400
Subject: [PATCH] [clang-tidy][performance-move-const-arg] Fix crash when
ar
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/111472
>From 4936acf06c30c1e9a3a300ec712845a4c56d5cd0 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 7 Oct 2024 23:08:44 -0400
Subject: [PATCH] [clang-tidy][performance-move-const-arg] Fix crash when
ar
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Nicolas van Kempen (nicovank)
Changes
Fix #111450.
When the argument type is forward-declared and there is no definition,
`hasMoveConstructor` triggers the assert here:
https://github.com/llvm-project/llvm-project/blob/7f65377880ce6
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Nicolas van Kempen (nicovank)
Changes
Fix #111450.
When the argument type is forward-declared and there is no definition,
`hasMoveConstructor` triggers the assert here:
https://github.com/llvm-project/llvm-project/blob/7f6537
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/111472
Fix #111450.
When the argument type is forward-declared and there is no definition,
`hasMoveConstructor` triggers the assert here:
https://github.com/llvm-project/llvm-project/blob/7f65377880ce6a0e5eaa4cb2591
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/111472
>From a321d32fd8f2d2ee2c760f7530dd5d9c6e7d4f00 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 7 Oct 2024 23:16:19 -0400
Subject: [PATCH] [clang-tidy][performance-move-const-arg] Fix crash when
ar
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/111472
>From a321d32fd8f2d2ee2c760f7530dd5d9c6e7d4f00 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 7 Oct 2024 23:16:19 -0400
Subject: [PATCH] [clang-tidy][performance-move-const-arg] Fix crash when
ar
https://github.com/Prabhuk created
https://github.com/llvm/llvm-project/pull/111473
UEFI toolchain predefines clean up. Introducing new __PECOFF__ predefine
for targets that produce PE COFF binaries. Updating UEFI header includes
to not include system include directories.
>From c241379b66fc4bb
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Brandon Wu (4vtomat)
Changes
Indexed segment load/store intrinsics don't have SEW information encoded
in the name, so we need to get the information from its pointer type
argument at runtime.
---
Patch is 38.46 MiB, truncated to
https://github.com/wangpc-pp approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/111466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nathanchance wrote:
With [my series to fix
`arch/powerpc`](https://git.kernel.org/pub/scm/linux/kernel/git/nathan/linux.git/log/?h=b4/powerpc-fix-stackprotector-test-clang)
for this implementation applied to Linux, `CONFIG_HAVE_STACKPROTECTOR` is
properly set and the Linux kernel dump test mod
keith-packard wrote:
btw, I'm testing this using Linux from
https://git.kernel.org/pub/scm/linux/kernel/git/nathan/linux.git/log/?h=b4/powerpc-fix-stackprotector-test-clang
https://github.com/llvm/llvm-project/pull/110928
___
cfe-commits mailing list
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/111010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tahonermann updated
https://github.com/llvm/llvm-project/pull/111389
>From 3c4a2b8a52d3f1c730df88a308dece21a67834ef Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Fri, 4 Oct 2024 11:10:32 -0700
Subject: [PATCH 1/2] [SYCL] The sycl_kernel_entry_point attribute.
The `sycl_
@@ -451,6 +452,18 @@ void SharedFile::parse() {
}
}
+/// Returns the alignment for a custom section. This is used to concatenate
+/// custom sections with the same name into a single custom section.
sbc100 wrote:
We don't use the /// style comment anywhere
https://github.com/sbc100 commented:
lld changes lgtm
https://github.com/llvm/llvm-project/pull/111332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sbc100 edited
https://github.com/llvm/llvm-project/pull/111332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson approved this pull request.
This LGTM but would be good to have someone who actually knows PPC to also
review it.
https://github.com/llvm/llvm-project/pull/110928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
@@ -1095,6 +1095,8 @@ class StructAccessBase
return Visit(E->getBase());
}
const Expr *VisitCastExpr(const CastExpr *E) {
+if (E->getCastKind() == CK_LValueToRValue)
+ return E;
bwendling wrote:
It might be a good sanity check, though I think
https://github.com/bwendling created
https://github.com/llvm/llvm-project/pull/111448
Ensure we have the correct RecordDecl before returning the Expr we're looking
for.
>From 1936cd507a38d3085fa13016fb40a9a7df35a821 Mon Sep 17 00:00:00 2001
From: Bill Wendling
Date: Mon, 7 Oct 2024 15:25:47 -
https://github.com/trcrsired updated
https://github.com/llvm/llvm-project/pull/79667
>From 2b526821d4e70f3ea83f95d25f804d9fbcf82612 Mon Sep 17 00:00:00 2001
From: cqwrteur <100043421+trcrsi...@users.noreply.github.com>
Date: Sat, 1 Jun 2024 02:55:50 -0400
Subject: [PATCH] [libunwind][libcxx][lib
@@ -0,0 +1,345 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
UTC_ARGS: --version 5
+; RUN: llc -mtriple=armv7a-none-eabi %s -o - | FileCheck %s
+
+declare i32 @many_args_callee(i32 %0, i32 %1, i32 %2, i32 %3, i32 %4, i32 %5)
+
+define i32 @many
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Bill Wendling (bwendling)
Changes
Ensure we have the correct RecordDecl before returning the Expr we're looking
for.
---
Full diff: https://github.com/llvm/llvm-project/pull/111448.diff
1 Files Affected:
- (modified) clang/lib/
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Bill Wendling (bwendling)
Changes
Ensure we have the correct RecordDecl before returning the Expr we're looking
for.
---
Full diff: https://github.com/llvm/llvm-project/pull/111448.diff
1 Files Affected:
- (modified) clang/lib/CodeGen/
@@ -1095,6 +1095,8 @@ class StructAccessBase
return Visit(E->getBase());
}
const Expr *VisitCastExpr(const CastExpr *E) {
+if (E->getCastKind() == CK_LValueToRValue)
+ return E;
bwendling wrote:
See https://github.com/llvm/llvm-project/pull/11
https://github.com/efriedma-quic approved this pull request.
LGTM
(I can't come up with a case where it actually fails off the top of my head,
but for the sake of consistency, it probably makes sense.)
https://github.com/llvm/llvm-project/pull/111448
___
@@ -852,34 +852,50 @@ void TypePrinter::printExtVectorAfter(const ExtVectorType
*T, raw_ostream &OS) {
void TypePrinter::printConstantMatrixBefore(const ConstantMatrixType *T,
raw_ostream &OS) {
+ if (Policy.UseHLSLTypes)
+OS <
stewartsmith wrote:
It's been a few years (and I've spent more time in 16bit x86 than powerpc for a
while), but I'm pretty sure this looks good.
While the POWER ISA may be lacking vowels, the lack of `r` denoting registers
in the test llvm test suite is (at least for me) doing it on hard mode
Author: Bill Wendling
Date: 2024-10-07T22:53:00Z
New Revision: 39ac121309f5c270c8fdc97c45a845542dd78681
URL:
https://github.com/llvm/llvm-project/commit/39ac121309f5c270c8fdc97c45a845542dd78681
DIFF:
https://github.com/llvm/llvm-project/commit/39ac121309f5c270c8fdc97c45a845542dd78681.diff
LOG:
https://github.com/bwendling closed
https://github.com/llvm/llvm-project/pull/111448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,15 +10,13 @@
//
//===--===//
+// clang-format off
arichardson wrote:
Why is this needed? Adding another newline should avoid the reordering.
Alternatively, config.h should include st
Author: Matheus Izvekov
Date: 2024-10-07T16:46:27-03:00
New Revision: 017b504b462ce7d4938f704a1f10118ead347d3d
URL:
https://github.com/llvm/llvm-project/commit/017b504b462ce7d4938f704a1f10118ead347d3d
DIFF:
https://github.com/llvm/llvm-project/commit/017b504b462ce7d4938f704a1f10118ead347d3d.dif
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/111267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dkolsen-pgi approved this pull request.
I am not familiar with how clang-tidy works. (I expect that will have to
change and I should start using it.) So I can't meaningfully review this.
https://github.com/llvm/llvm-project/pull/111417
_
@@ -4690,8 +4690,9 @@ void CodeGenFunction::EmitCallArg(CallArgList &args,
const Expr *E,
return emitWritebackArg(*this, args, CRE);
}
- assert(type->isReferenceType() == E->isGLValue() &&
- "reference binding to unmaterialized r-value!");
+ assert(type->isArr
@@ -5811,9 +5811,12 @@ LValue CodeGenFunction::EmitBinaryOperatorLValue(const
BinaryOperator *E) {
// This function implements trivial copy assignment for HLSL's
// assignable constant arrays.
LValue CodeGenFunction::EmitHLSLArrayAssignLValue(const BinaryOperator *E) {
- LVal
https://github.com/arsenm edited
https://github.com/llvm/llvm-project/pull/102462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-clang-tidy
Author: Félix-Antoine Constantin (felix642)
Changes
Fixed false negatives with readability-redundant-casting when the underlying
types are the same and the option IgnoreTypeAliases is set to true.
Fixes
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/111424
Fixed false negatives with readability-redundant-casting when the underlying
types are the same and the option IgnoreTypeAlias is set to true.
Fixes #37
From 310315a294b9fa0f1c08ab242221950c0c3cd0a5 Mon S
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/111424
From 9c28fc517238c157a20307bcb5fd39201d0edc9d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Mon, 7 Oct 2024 15:27:36 -0400
Subject: [PATCH] [clang-tidy] Improved readability
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/111424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 971b579bc6669a0898e47d6702c4b99cb757bb26
9c28fc517238c157a20307bcb5fd39201d0edc9d --e
@@ -1956,6 +1956,26 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned
BuiltinID, CallExpr *TheCall) {
return true;
break;
}
+ case Builtin::BI__builtin_hlsl_wave_read_lane_at: {
+if (SemaRef.checkArgCount(TheCall, 2))
+ return true;
+
+// Ensure ind
@@ -2015,6 +2015,13 @@ _HLSL_AVAILABILITY(shadermodel, 6.0)
_HLSL_BUILTIN_ALIAS(__builtin_hlsl_wave_is_first_lane)
__attribute__((convergent)) bool WaveIsFirstLane();
+// \brief Returns the value of the expression for the given lane index within
+// the specified wave.
+templa
@@ -18835,6 +18835,24 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
Intrinsic::ID ID = CGM.getHLSLRuntime().getWaveIsFirstLaneIntrinsic();
return EmitRuntimeCall(Intrinsic::getDeclaration(&CGM.getModule(), ID));
}
+ case Builtin::BI__builtin_hlsl_wave_read_l
@@ -3830,6 +3830,16 @@ QualType ASTContext::getDecayedType(QualType T) const {
return getDecayedType(T, Decayed);
}
+QualType ASTContext::getConstantArrayFromArrayParameterType(QualType Ty) const
{
+ if (Ty->isConstantArrayType() && !Ty->isArrayParameterType())
+return
@@ -18835,6 +18835,24 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
Intrinsic::ID ID = CGM.getHLSLRuntime().getWaveIsFirstLaneIntrinsic();
return EmitRuntimeCall(Intrinsic::getDeclaration(&CGM.getModule(), ID));
}
+ case Builtin::BI__builtin_hlsl_wave_read_l
@@ -2015,6 +2015,13 @@ _HLSL_AVAILABILITY(shadermodel, 6.0)
_HLSL_BUILTIN_ALIAS(__builtin_hlsl_wave_is_first_lane)
__attribute__((convergent)) bool WaveIsFirstLane();
+// \brief Returns the value of the expression for the given lane index within
+// the specified wave.
+templa
MrSidims wrote:
> with vanilla upstream, please see
You mean the translator, right? I don't think that SPIR-V backend should follow
its practices especially when we could do better.
> At a glance, it seems like an issue around handling vec3s, which are odd,
> but, probably; the BE should prob
@@ -2015,6 +2015,13 @@ _HLSL_AVAILABILITY(shadermodel, 6.0)
_HLSL_BUILTIN_ALIAS(__builtin_hlsl_wave_is_first_lane)
__attribute__((convergent)) bool WaveIsFirstLane();
+// \brief Returns the value of the expression for the given lane index within
+// the specified wave.
+templa
https://github.com/ashvardanian created
https://github.com/llvm/llvm-project/pull/111435
This patch adds support for detecting the `AVX512VP2INTERSECT` ISA extension.
It's useful for Intel Tiger Lake mobile CPUs and any Zen 5 AMD CPUs.
No functional changes yet, just defining the feature flag.
https://github.com/serge-sans-paille created
https://github.com/llvm/llvm-project/pull/111434
This implements a warning that's similar to what GCC does in that context: both
memcpy and memset require their first and second operand to be trivially
copyable, let's warn if that's not the case.
>
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (serge-sans-paille)
Changes
This implements a warning that's similar to what GCC does in that context: both
memcpy and memset require their first and second operand to be trivially
copyable, let's warn if that's not the case.
---
Fu
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ash Vardanian (ashvardanian)
Changes
This patch adds support for detecting the `AVX512VP2INTERSECT` ISA extension.
It's useful for Intel Tiger Lake mobile CPUs and any Zen 5 AMD CPUs.
No functional changes yet, just defining the feature fla
@@ -434,6 +434,15 @@ struct AAAMDAttributesFunction : public AAAMDAttributes {
indicatePessimisticFixpoint();
return;
}
+
+for (Instruction &I : instructions(F)) {
+ if (isa(I) &&
jwanggit86 wrote:
This test has been added.
https://gi
https://github.com/gburgessiv created
https://github.com/llvm/llvm-project/pull/111439
At present, `__builtin_available` is really restrictive with its use. Overall,
this seems like a good thing, since the analyses behind it are not very
expensive.
That said, it's very straightforward to supp
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: George Burgess IV (gburgessiv)
Changes
At present, `__builtin_available` is really restrictive with its use. Overall,
this seems like a good thing, since the analyses behind it are not very
expensive.
That said, it's very straightforward
301 - 400 of 461 matches
Mail list logo
