[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-07 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/111010 >From 70089645ec5cf62b491a56df96ec46f4328fbc11 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Thu, 3 Oct 2024 11:43:51 -0700 Subject: [PATCH 1/6] [HLSL] Implement `WaveReadLaneAt` intrinsic - create a cl

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -455,6 +455,64 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLKernelEntryPointDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +The ``sycl_kernel_entry_point`` attribute specifies that a function defini

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -14296,6 +14296,31 @@ void ASTContext::getFunctionFeatureMap(llvm::StringMap &FeatureMap, } } +static SYCLKernelInfo BuildSYCLKernelInfo(ASTContext &Context, + CanQualType KernelNameType, +

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -455,6 +455,64 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLKernelEntryPointDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +The ``sycl_kernel_entry_point`` attribute specifies that a function defini

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -455,6 +455,64 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLKernelEntryPointDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +The ``sycl_kernel_entry_point`` attribute specifies that a function defini

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -455,6 +455,64 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLKernelEntryPointDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +The ``sycl_kernel_entry_point`` attribute specifies that a function defini

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -14296,6 +14296,31 @@ void ASTContext::getFunctionFeatureMap(llvm::StringMap &FeatureMap, } } +static SYCLKernelInfo BuildSYCLKernelInfo(ASTContext &Context, + CanQualType KernelNameType, +

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -455,6 +455,64 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLKernelEntryPointDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +The ``sycl_kernel_entry_point`` attribute specifies that a function defini

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -455,6 +455,64 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLKernelEntryPointDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +The ``sycl_kernel_entry_point`` attribute specifies that a function defini

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -0,0 +1,137 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -std=c++17 -fsyntax-only -fsycl-is-device -verify %s erichkeane wrote: I don't think I see tests for all of the things in your documented list. https://github.com/llvm/llvm-project/pull/111389 _

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -14296,6 +14296,31 @@ void ASTContext::getFunctionFeatureMap(llvm::StringMap &FeatureMap, } } +static SYCLKernelInfo BuildSYCLKernelInfo(ASTContext &Context, + CanQualType KernelNameType, +

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -198,3 +198,12 @@ void SemaSYCL::handleKernelAttr(Decl *D, const ParsedAttr &AL) { handleSimpleAttribute(*this, D, AL); } + +void SemaSYCL::handleKernelEntryPointAttr(Decl *D, const ParsedAttr &AL) { + ParsedType PT = AL.getTypeArg(); + TypeSourceInfo *TSI = nullptr; +

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -455,6 +455,64 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLKernelEntryPointDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +The ``sycl_kernel_entry_point`` attribute specifies that a function defini

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-07 Thread Farzon Lotfi via cfe-commits
@@ -83,6 +83,7 @@ def int_dx_umad : DefaultAttrsIntrinsic<[llvm_anyint_ty], [LLVMMatchType<0>, LLV def int_dx_normalize : DefaultAttrsIntrinsic<[LLVMMatchType<0>], [llvm_anyfloat_ty], [IntrNoMem]>; def int_dx_rsqrt : DefaultAttrsIntrinsic<[llvm_anyfloat_ty], [LLVMMatchType<0

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-07 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/111010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix std::tm etc. mangling on Solaris (PR #106353)

2024-10-07 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/106353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Emit an error when the hard-float ABI is enabled but can't be used. (PR #111334)

2024-10-07 Thread Chris Copeland via cfe-commits
chrisnc wrote: Among those options, my preference would be to remove the clang warning and add the LLVM error so that other frontends can benefit from this checking, as well as the LLVM tools themselves. The LLVM test failures reveal a few places where this issue seems to be ignored. https://

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-07 Thread Finn Plummer via cfe-commits
@@ -18835,6 +18835,22 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { Intrinsic::ID ID = CGM.getHLSLRuntime().getWaveIsFirstLaneIntrinsic(); return EmitRuntimeCall(Intrinsic::getDeclaration(&CGM.getModule(), ID)); } + case Builtin::BI__builtin_hlsl_wave_read_l

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features ssbs and ssbs2. (PR #110297)

2024-10-07 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm approved this pull request. https://github.com/llvm/llvm-project/pull/110297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Remove the concept from the DeclContext if the definition is invalid (PR #111179)

2024-10-07 Thread via cfe-commits
@@ -337,6 +343,8 @@ Parser::ParseConceptDefinition(const ParsedTemplateInfo &TemplateInfo, ExprResult ConstraintExprResult = Actions.CorrectDelayedTyposInExpr(ParseConstraintExpression()); if (ConstraintExprResult.isInvalid()) { +if (AddedToScope) ---

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-07 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @vient I think we can, yes https://github.com/llvm/llvm-project/pull/110496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-07 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/110239 >From 84946607fc58927b1b44da2b70566abca041bbfb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 27 Sep 2024 10:19:19 + Subject: [PATCH 1/5] [clang][Sema] Bad register variable type error should

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: > This is still missing a release note, and adding the source range too would > be nice. Both done. https://github.com/llvm/llvm-project/pull/110239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-07 Thread Younan Zhang via cfe-commits
zyn0217 wrote: #79 aims for a different case (and that is a follow-up for @cor3ntin's recursive concept patch, which is not yet merged into 19, I think), while this one is related to a serialization bug that has persisted for some time. https://github.com/llvm/llvm-project/pull/110496

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-07 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/110239 >From 84946607fc58927b1b44da2b70566abca041bbfb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 27 Sep 2024 10:19:19 + Subject: [PATCH 1/4] [clang][Sema] Bad register variable type error should

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-07 Thread Florian Albrechtskirchinger via cfe-commits
falbrechtskirchinger wrote: @zyn0217 #79 has fixed this crash as well. Should I strip this PR down to the unit test, or does it still make sense to you, to keep the changes? > Will this be backported to 19.x afterwards? I was also going to ask, though, it's now a question about #79. h

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-07 Thread via cfe-commits
cor3ntin wrote: Is that change still necessary at all after https://github.com/llvm/llvm-project/pull/79 ? https://github.com/llvm/llvm-project/pull/110496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-07 Thread via cfe-commits
@@ -2674,7 +2674,7 @@ void ASTDeclReader::VisitTemplateTypeParmDecl(TemplateTypeParmDecl *D) { D->setDeclaredWithTypename(Record.readInt()); - if (D->hasTypeConstraint()) { + if (Record.readBool() && D->hasTypeConstraint()) { cor3ntin wrote: Can you put

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-07 Thread via cfe-commits
@@ -1899,7 +1899,7 @@ void ASTDeclWriter::VisitTemplateTypeParmDecl(TemplateTypeParmDecl *D) { Record.push_back(D->wasDeclaredWithTypename()); const TypeConstraint *TC = D->getTypeConstraint(); - assert((bool)TC == D->hasTypeConstraint()); + Record.push_back(/*TypeConst

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-07 Thread Florian Albrechtskirchinger via cfe-commits
falbrechtskirchinger wrote: > So yes, this one is still necessary - it should occur with an > assertion-enabled build when compiling a header containing an invalid concept > decl. Not in my testing. https://github.com/llvm/llvm-project/pull/110496 ___

[clang-tools-extra] [clang-include-cleaner] Fix incorrect directory issue for writing files (PR #111375)

2024-10-07 Thread Byoungchan Lee via cfe-commits
https://github.com/bc-lee created https://github.com/llvm/llvm-project/pull/111375 If the current working directory of `clang-include-cleaner` differs from the directory of the input files specified in the compilation database, it doesn't adjust the input file paths properly. As a result, `cla

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

2024-10-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110761 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH 01/10] [Clang] omit parentheses in fold expressions with a singl

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -1511,8 +1511,11 @@ static bool IsOverloadOrOverrideImpl(Sema &SemaRef, FunctionDecl *New, auto NewObjectType = New->getFunctionObjectParameterReferenceType(); auto OldObjectType = Old->getFunctionObjectParameterReferenceType(); - if (NewObjectType.isConst

[clang-tools-extra] [clang-include-cleaner] Fix incorrect directory issue for writing files (PR #111375)

2024-10-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Byoungchan Lee (bc-lee) Changes If the current working directory of `clang-include-cleaner` differs from the directory of the input files specified in the compilation database, it doesn't adjust the input file paths properly.

[clang] [clang] Don't lose track of explicit specializations of member functi… (PR #111267)

2024-10-07 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/111267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-07 Thread Florian Albrechtskirchinger via cfe-commits
@@ -1899,7 +1899,7 @@ void ASTDeclWriter::VisitTemplateTypeParmDecl(TemplateTypeParmDecl *D) { Record.push_back(D->wasDeclaredWithTypename()); const TypeConstraint *TC = D->getTypeConstraint(); - assert((bool)TC == D->hasTypeConstraint()); + Record.push_back(/*TypeConst

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-07 Thread Florian Albrechtskirchinger via cfe-commits
@@ -2674,7 +2674,7 @@ void ASTDeclReader::VisitTemplateTypeParmDecl(TemplateTypeParmDecl *D) { D->setDeclaredWithTypename(Record.readInt()); - if (D->hasTypeConstraint()) { + if (Record.readBool() && D->hasTypeConstraint()) { falbrechtskirchinger wrote:

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

2024-10-07 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/110761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Support simplified triple versions for config files (PR #111387)

2024-10-07 Thread Bo Anderson via cfe-commits
https://github.com/Bo98 edited https://github.com/llvm/llvm-project/pull/111387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] aa65636 - [clang][x86] Update AVX1 intrinsic tests for both C/C++

2024-10-07 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-10-07T15:57:21+01:00 New Revision: aa656366ce9a693fce6a4f16090d250a8059df46 URL: https://github.com/llvm/llvm-project/commit/aa656366ce9a693fce6a4f16090d250a8059df46 DIFF: https://github.com/llvm/llvm-project/commit/aa656366ce9a693fce6a4f16090d250a8059df46.diff

[clang] f71d621 - [clang][x86] Update F16C intrinsic tests for both C/C++ and 32/64-bit targets

2024-10-07 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-10-07T15:57:22+01:00 New Revision: f71d62178d9c97ac650a8454403d71cbc8fd8c9d URL: https://github.com/llvm/llvm-project/commit/f71d62178d9c97ac650a8454403d71cbc8fd8c9d DIFF: https://github.com/llvm/llvm-project/commit/f71d62178d9c97ac650a8454403d71cbc8fd8c9d.diff

[clang] aa4d948 - [clang][x86] Update FMA/FMA4 intrinsic tests for both C/C++ and 32/64-bit targets

2024-10-07 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-10-07T15:57:22+01:00 New Revision: aa4d94839e6bb30389deb3339fb0d0e4aa8baa4e URL: https://github.com/llvm/llvm-project/commit/aa4d94839e6bb30389deb3339fb0d0e4aa8baa4e DIFF: https://github.com/llvm/llvm-project/commit/aa4d94839e6bb30389deb3339fb0d0e4aa8baa4e.diff

[clang] f15fe73 - [clang][x86] Update AVX2 intrinsic tests for both C/C++

2024-10-07 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-10-07T15:57:22+01:00 New Revision: f15fe73d234a3c41f9cb905106517a89bab3add4 URL: https://github.com/llvm/llvm-project/commit/f15fe73d234a3c41f9cb905106517a89bab3add4 DIFF: https://github.com/llvm/llvm-project/commit/f15fe73d234a3c41f9cb905106517a89bab3add4.diff

[clang] 8565213 - [clang] Code owners -> Maintainers transition (#108997)

2024-10-07 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-10-07T11:00:54-04:00 New Revision: 8565213f2f9991d83d2b1353f00f35e2b34d9d12 URL: https://github.com/llvm/llvm-project/commit/8565213f2f9991d83d2b1353f00f35e2b34d9d12 DIFF: https://github.com/llvm/llvm-project/commit/8565213f2f9991d83d2b1353f00f35e2b34d9d12.diff

[clang] [clang] Code owners -> Maintainers transition (PR #108997)

2024-10-07 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/108997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4b4ea6d84bddb5e7b3f144d18630390755e8f7b6 3c4a2b8a52d3f1c730df88a308dece21a67834ef --e

[clang] [clang][Driver] Support simplified triple versions for config files (PR #111387)

2024-10-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Bo Anderson (Bo98) Changes Currently, the config file system loads the full target triple, e.g. `arm64-apple-darwin23.6.0.cfg`. This is however not very useful as this is a moving target. In the case of macOS, that target moves every 2 m

[clang] [clang][Driver] Support simplified triple versions for config files (PR #111387)

2024-10-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Bo Anderson (Bo98) Changes Currently, the config file system loads the full target triple, e.g. `arm64-apple-darwin23.6.0.cfg`. This is however not very useful as this is a moving target. In the case of macOS, that target moves ev

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann created https://github.com/llvm/llvm-project/pull/111389 The `sycl_kernel_entry_point` attribute is used to declare a function that defines a pattern for an offload kernel to be emitted. The attribute requires a single type argument that specifies the type used a

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Tom Honermann (tahonermann) Changes The `sycl_kernel_entry_point` attribute is used to declare a function that defines a pattern for an offload kernel to be emitted. The attribute requires a single type argument that specifies the

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Honermann (tahonermann) Changes The `sycl_kernel_entry_point` attribute is used to declare a function that defines a pattern for an offload kernel to be emitted. The attribute requires a single type argument that specifies the type us

[clang] [llvm] [ARM] Emit an error when the hard-float ABI is enabled but can't be used. (PR #111334)

2024-10-07 Thread Peter Smith via cfe-commits
smithp35 wrote: Whatever we choose to do I think clang and llvm should be consistent. There's no point in clang giving a warning if llvm is going to give an error. I can see two positions most clearly: * clang gives an error message for an eabihf target (or -mfloat-abi=hard). This is what GCC

[clang] [WIP][clang] Fix std::tm etc. mangling on Solaris (PR #106353)

2024-10-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth updated https://github.com/llvm/llvm-project/pull/106353 >From 646c6ad032fe9c15faee03246496958f7592ea75 Mon Sep 17 00:00:00 2001 From: Rainer Orth Date: Wed, 28 Aug 2024 11:24:29 +0200 Subject: [PATCH 1/3] [WIP][clang] Fix std::tm etc. mangling on Solaris Recently, Sol

[clang] [Clang][Driver] Improve config file handling on Darwin (PR #111306)

2024-10-07 Thread Carlo Cabrera via cfe-commits
carlocab wrote: #111387 is a better approach to this. https://github.com/llvm/llvm-project/pull/111306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix std::tm etc. mangling on Solaris (PR #106353)

2024-10-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth edited https://github.com/llvm/llvm-project/pull/106353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Improve config file handling on Darwin (PR #111306)

2024-10-07 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab closed https://github.com/llvm/llvm-project/pull/111306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix crash when casting the result of a malformed fptr call (PR #111390)

2024-10-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes Ideally, we wouldn't workaround our current cast-modeling, but the experimental "support-symbolic-integer-casts" is not finished so we need to live with our current modeling. Ideally, we

[clang] [analyzer] Fix crash when casting the result of a malformed fptr call (PR #111390)

2024-10-07 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/111390 Ideally, we wouldn't workaround our current cast-modeling, but the experimental "support-symbolic-integer-casts" is not finished so we need to live with our current modeling. Ideally, we could probably bind `

[clang] [clang] Fix std::tm etc. mangling on Solaris (PR #106353)

2024-10-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth edited https://github.com/llvm/llvm-project/pull/106353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-07 Thread Tom Honermann via cfe-commits
tahonermann wrote: This is the first in a series of PRs to provide core language support for SYCL-aware host and device compilation and support for SYCL library implementations. The following links present a preliminary set of changes for future PRs that depend on this one. Some of these need

[clang] [llvm] [clang][LLVM Demangler] Add an assertion that validates that all mang… (PR #111391)

2024-10-07 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo created https://github.com/llvm/llvm-project/pull/111391 …led names produced by `clang` can be demangled by LLVM demangler. Introduce the above assertion behind the `-fno-demangling-failures` flag to prevent unintended breakages. >From 9c16570650e487e63ec887d61be478

[clang] [llvm] [clang][LLVM Demangler] Add an assertion that validates that all mang… (PR #111391)

2024-10-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Viktoriia Bakalova (VitaNuo) Changes …led names produced by `clang` can be demangled by LLVM demangler. Introduce the above assertion behind the `-fno-demangling-failures` flag to prevent unintended breakages. --- Full diff: https://gith

[clang] [llvm] [clang][LLVM Demangler] Add an assertion that validates that all mang… (PR #111391)

2024-10-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4b3ba64ba71c06b6bc9db347a66a7316f5edbcc4 9c16570650e487e63ec887d61be478ecad5402c2 --e

[clang] [Clang] Implement CWG 2628 "Implicit deduction guides should propagate constraints" (PR #111143)

2024-10-07 Thread Younan Zhang via cfe-commits
@@ -478,3 +478,166 @@ A a{.f1 = {1}}; // CHECK-NEXT: `-DeclRefExpr {{.+}} 'int' NonTypeTemplateParm {{.+}} 'N' 'int' } // namespace GH83368 + +namespace GH60777 { + +template constexpr bool True() { return true; } + +template + requires(sizeof(T) == 4) +struct A { +

[clang] [AST] Avoid repeated hash lookups (NFC) (PR #111327)

2024-10-07 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/111327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4c9c2d6 - [AST] Avoid repeated hash lookups (NFC) (#111327)

2024-10-07 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-10-07T06:55:56-07:00 New Revision: 4c9c2d6082740b4ddda1ecfdc33702e4cbd3444d URL: https://github.com/llvm/llvm-project/commit/4c9c2d6082740b4ddda1ecfdc33702e4cbd3444d DIFF: https://github.com/llvm/llvm-project/commit/4c9c2d6082740b4ddda1ecfdc33702e4cbd3444d.diff L

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

2024-10-07 Thread Oleksandr T. via cfe-commits
@@ -20224,6 +20224,8 @@ void Sema::DiagnoseEqualityWithExtraParens(ParenExpr *ParenE) { return; Expr *E = ParenE->IgnoreParens(); + if (ParenE->isProducedByFoldExpansion() && ParenE->getSubExpr() == E) +return; a-tarasyuk wrote: @erichkeane thanks

[clang] [Clang] Implement CWG 2628 "Implicit deduction guides should propagate constraints" (PR #111143)

2024-10-07 Thread Erich Keane via cfe-commits
@@ -478,3 +478,166 @@ A a{.f1 = {1}}; // CHECK-NEXT: `-DeclRefExpr {{.+}} 'int' NonTypeTemplateParm {{.+}} 'N' 'int' } // namespace GH83368 + +namespace GH60777 { + +template constexpr bool True() { return true; } + +template + requires(sizeof(T) == 4) +struct A { +

[clang] [clang][analyzer] Introduce modeling for threading related checkers (PR #109636)

2024-10-07 Thread Endre Fülöp via cfe-commits
gamesh411 wrote: > Usually its hard to see how the implementation changes if anyways all the > surrounding code moves. For such changes, if the change is large (like in > this case, its a 2k+ diff), it feels better to review the individual commits > instead of everything all at once. If we do

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck commented: Thanks for doing this! I've had something like this at the back of my mind for a while. https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck edited https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[clang] 40f0f7b - [FMV][AArch64] Unify features ssbs and ssbs2. (#110297)

2024-10-07 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-10-07T15:00:08+01:00 New Revision: 40f0f7b4ec3eea4827fa3e54153ff722b5842ea1 URL: https://github.com/llvm/llvm-project/commit/40f0f7b4ec3eea4827fa3e54153ff722b5842ea1 DIFF: https://github.com/llvm/llvm-project/commit/40f0f7b4ec3eea4827fa3e54153ff722b5842e

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features ssbs and ssbs2. (PR #110297)

2024-10-07 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/110297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Remove mention of BSD license in readme (PR #111371)

2024-10-07 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck approved this pull request. https://github.com/llvm/llvm-project/pull/111371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] CWG2398: improve overload resolution backwards compat (PR #107350)

2024-10-07 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/107350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce MutexModeling checker (PR #111381)

2024-10-07 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 created https://github.com/llvm/llvm-project/pull/111381 This patch introduces the basic structure for the MutexModeling checker. It adds the checker definition, creates the MutexModeling.cpp file, supporting header files, and updates the necessary build files. The

[clang] Introduce MutexModeling checker (PR #111381)

2024-10-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Endre Fülöp (gamesh411) Changes This patch introduces the basic structure for the MutexModeling checker. It adds the checker definition, creates the MutexModeling.cpp file, supporting header fi

[clang] [llvm] [PowerPC][ISelLowering] Support -mstack-protector-guard=tls (PR #110928)

2024-10-07 Thread Keith Packard via cfe-commits
https://github.com/keith-packard updated https://github.com/llvm/llvm-project/pull/110928 >From 6fc295312f31915cb691fb612a290fa245e5f9f6 Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Sun, 6 Oct 2024 23:19:30 -0700 Subject: [PATCH 1/5] [CodeGen] Provide Module to useLoadStackGuardNode Use

[clang] Enable matrices in HLSL (PR #111415)

2024-10-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Greg Roth (pow2clk) Changes HLSL needs matrix support. This allows matrices when the target language is HLSL and defines a matrix template alias that allows the short forms of matrix types to be defined in typedefs in a default header. Ma

[clang] [llvm] [PowerPC][ISelLowering] Support -mstack-protector-guard=tls (PR #110928)

2024-10-07 Thread Keith Packard via cfe-commits
keith-packard wrote: Ok, I think this is a lot closer now -- I'm using the non-deprecated mechanism for generating the canary load instruction, although that required reworking the guard function API a bit. https://github.com/llvm/llvm-project/pull/110928 __

[clang] Enable matrices in HLSL (PR #111415)

2024-10-07 Thread Greg Roth via cfe-commits
@@ -852,34 +852,50 @@ void TypePrinter::printExtVectorAfter(const ExtVectorType *T, raw_ostream &OS) { void TypePrinter::printConstantMatrixBefore(const ConstantMatrixType *T, raw_ostream &OS) { + if (Policy.UseHLSLTypes) +OS <

[clang] 41b09c5 - [Clang] omit parentheses in fold expressions with a single expansion (#110761)

2024-10-07 Thread via cfe-commits
Author: Oleksandr T. Date: 2024-10-07T20:14:46+02:00 New Revision: 41b09c5346324fc0fd2642f3df216a246f9fb98b URL: https://github.com/llvm/llvm-project/commit/41b09c5346324fc0fd2642f3df216a246f9fb98b DIFF: https://github.com/llvm/llvm-project/commit/41b09c5346324fc0fd2642f3df216a246f9fb98b.diff

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

2024-10-07 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/110761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SanitizerCoverage] Add an option to gate the invocation of the tracing callbacks (PR #108328)

2024-10-07 Thread Julian Lettner via cfe-commits
https://github.com/yln approved this pull request. LGTM, looks harmless enough. Please ping again for review and wait a few more days before merging to give other reviewers another chance to chime in. In the follow-up PR that expands support for this to trace-cmp, does it make sense to docume

[clang] Effect analysis: correctly detect `(x ? a : b)` as nonblocking when a and b are (PR #111224)

2024-10-07 Thread Doug Wyatt via cfe-commits
dougsonos wrote: @cjappl @Sirraide would appreciate what I hope will be a quick review on a small fix. https://github.com/llvm/llvm-project/pull/111224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang-tools-extra] [clang-tidy] Fix incorrect command-line option in docs (PR #111405)

2024-10-07 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp approved this pull request. Thanks for the fix! https://github.com/llvm/llvm-project/pull/111405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add .clang-tidy files for ClangIR specific coding style rules (PR #111417)

2024-10-07 Thread Nathan Lanza via cfe-commits
https://github.com/lanza created https://github.com/llvm/llvm-project/pull/111417 https://llvm.github.io/clangir/GettingStarted/coding-guideline.html >From 68b7427f371db198a1dc69c36c39192f2f9ab6a9 Mon Sep 17 00:00:00 2001 From: Nathan Lanza Date: Mon, 7 Oct 2024 18:27:46 + Subject: [PATCH

[clang] [CIR] Add .clang-tidy files for ClangIR specific coding style rules (PR #111417)

2024-10-07 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I don't have a good idea of what the whole list should BE, but htis seems reasonable to me. https://github.com/llvm/llvm-project/pull/111417 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2024-10-07 Thread Eli Friedman via cfe-commits
@@ -1906,6 +1906,36 @@ class Sema final : public SemaBase { ActOnPragmaMSFunction(SourceLocation Loc, const llvm::SmallVectorImpl &NoBuiltins); + /// A label from a C++ #pragma export, for a symbol that we + /// haven't seen the declaration for yet.

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2024-10-07 Thread Eli Friedman via cfe-commits
@@ -1273,6 +1273,168 @@ void Sema::AddImplicitMSFunctionNoBuiltinAttr(FunctionDecl *FD) { FD->addAttr(NoBuiltinAttr::CreateImplicit(Context, V.data(), V.size())); } +static bool typeListMatches(FunctionDecl *FD, +const clang::Sema::SymbolLabel

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2024-10-07 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,5 @@ +// REQUIRES: systemz-registered-target efriedma-quic wrote: Do these tests actually require systemz-registered-target? https://github.com/llvm/llvm-project/pull/111035 ___ cfe-commits mailing list cfe-

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2024-10-07 Thread Eli Friedman via cfe-commits
@@ -5087,6 +5087,19 @@ Decl *Sema::ParsedFreeStandingDeclSpec(Scope *S, AccessSpecifier AS, assert(EllipsisLoc.isInvalid() && "Friend ellipsis but not friend-specified?"); + if (DS.isExportSpecified()) { +VisibilityAttr *existingAttr = TagD->getAttr(); +if

[clang-tools-extra] adbc37d - [clang-tidy] Fix incorrect command-line option in docs (#111405)

2024-10-07 Thread via cfe-commits
Author: hill Date: 2024-10-07T20:37:00+02:00 New Revision: adbc37d999b5949779830ffa7dbff54cb78862cb URL: https://github.com/llvm/llvm-project/commit/adbc37d999b5949779830ffa7dbff54cb78862cb DIFF: https://github.com/llvm/llvm-project/commit/adbc37d999b5949779830ffa7dbff54cb78862cb.diff LOG: [cl

[clang-tools-extra] [clang-tidy] Fix incorrect command-line option in docs (PR #111405)

2024-10-07 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/111405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2024-10-07 Thread Eli Friedman via cfe-commits
@@ -1906,6 +1906,36 @@ class Sema final : public SemaBase { ActOnPragmaMSFunction(SourceLocation Loc, const llvm::SmallVectorImpl &NoBuiltins); + /// A label from a C++ #pragma export, for a symbol that we + /// haven't seen the declaration for yet.

[clang-tools-extra] [clang-tidy] Fix incorrect command-line option in docs (PR #111405)

2024-10-07 Thread via cfe-commits
github-actions[bot] wrote: @float3 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

<    1   2   3   4   5   >