[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #111090)

2024-10-04 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/111090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix noexecpt mismatch of friend declaration (PR #102267)

2024-10-04 Thread via cfe-commits
@@ -4698,7 +4698,22 @@ void Sema::InstantiateExceptionSpec(SourceLocation PointOfInstantiation, // Enter the scope of this instantiation. We don't use // PushDeclContext because we don't have a scope. Sema::ContextRAII savedContext(*this, Decl); + + FunctionDecl *Source

[clang] [clang-format] Annotate ::operator as FunctionDeclarationName (PR #111115)

2024-10-04 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/15 Fix #111011 >From 41a0257541c8c9b26fd0cc8e392abc0b27d1084e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 4 Oct 2024 01:17:13 -0700 Subject: [PATCH] [clang-format] Annotate ::operator as FunctionDeclarationN

[clang] [MSVC] work-around for compile time issue 102513 (PR #110986)

2024-10-04 Thread Timm Baeder via cfe-commits
tbaederr wrote: Generally LGTM. https://github.com/llvm/llvm-project/pull/110986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Check initialization and argument passing in FixedAddressChecker (PR #110977)

2024-10-04 Thread Balázs Kéri via cfe-commits
balazske wrote: I was thinking about using `check::Location` in this checker. The real problem is when the fixed address is used (to store or load), not if it is assigned to a pointer. (Or a fixed address becomes escaped.) Or both cases (with the current checks) can be used, but then multiple

[clang] [Clang][Parser] Remove the concept from the DeclContext if the definition is invalid (PR #111179)

2024-10-04 Thread Shafik Yaghmour via cfe-commits
@@ -337,6 +343,8 @@ Parser::ParseConceptDefinition(const ParsedTemplateInfo &TemplateInfo, ExprResult ConstraintExprResult = Actions.CorrectDelayedTyposInExpr(ParseConstraintExpression()); if (ConstraintExprResult.isInvalid()) { +if (AddedToScope) ---

[clang] [Clang] Fix __builtin_dynamic_object_size off by 4 (PR #111015)

2024-10-04 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: The point of __counted_by is precisely to supplement the normal standard rules: specifically, if you have counted_by, the size of the flexible array is precisely the size specified by the attribute. Not whatever size is implied by the access. Otherwise, it would be illeg

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-10-04 Thread Brad Richardson via cfe-commits
@@ -787,6 +787,9 @@ void Flang::ConstructJob(Compilation &C, const JobAction &JA, if (Args.hasArg(options::OPT_fopenmp_force_usm)) CmdArgs.push_back("-fopenmp-force-usm"); + // TODO: OpenMP support isn't "done" yet, so for now we warn that it + // is e

[clang] Turn `-Wdeprecated-literal-operator` on by default (PR #111027)

2024-10-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/111027 >From 21dc8df292d85b7f48f75ea2a707be6c4971e2f9 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Thu, 3 Oct 2024 09:41:08 -0700 Subject: [PATCH 1/2] Turn Wdeprecated-literal-operator on by default It would be

[clang] 2997a67 - [Sema] Avoid repeated hash lookups (NFC) (#111090)

2024-10-04 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-10-04T07:37:11-07:00 New Revision: 2997a67172e0f3752f9f25210d86ba6fa65e63e7 URL: https://github.com/llvm/llvm-project/commit/2997a67172e0f3752f9f25210d86ba6fa65e63e7 DIFF: https://github.com/llvm/llvm-project/commit/2997a67172e0f3752f9f25210d86ba6fa65e63e7.diff L

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-04 Thread Finn Plummer via cfe-commits
@@ -2653,6 +2653,21 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register ResVReg, .addUse(GR.getSPIRVTypeID(ResType)) .addUse(GR.getOrCreateConstInt(3, I, IntTy, TII)); } + case Intrinsic::spv_wave_read_lane_at: { +assert(I.getNumOperands() == 4);

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-10-04 Thread Matin Raayai via cfe-commits
matinraayai wrote: I dug up the commit that introduced `LLVMTargetMachine`: https://github.com/llvm/llvm-project/commit/12e97307a10bbac6bf9e6733833b84faf06dee88. It dates back to before when the MC layer was created. It seems the motivation was to allow a hypothetical target to generate code u

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-04 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Can you also add the previous regressing case to the test? Thanks https://github.com/llvm/llvm-project/pull/106585#issuecomment-2368947247 https://github.com/llvm/llvm-project/pull/73 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] Add z/OS customization file (PR #111182)

2024-10-04 Thread Sean Perry via cfe-commits
https://github.com/perry-ca created https://github.com/llvm/llvm-project/pull/82 On z/OS, the location of the system libraries and side decks (aka equivalent to libc, etc) are not in a predefined location. The system does have a default location but sysadmins can change this and frequentl

[clang] Add z/OS customization file (PR #111182)

2024-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sean Perry (perry-ca) Changes On z/OS, the location of the system libraries and side decks (aka equivalent to libc, etc) are not in a predefined location. The system does have a default location but sysadmins can change this and frequent

[clang] Add z/OS customization file (PR #111182)

2024-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Sean Perry (perry-ca) Changes On z/OS, the location of the system libraries and side decks (aka equivalent to libc, etc) are not in a predefined location. The system does have a default location but sysadmins can change this and f

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-04 Thread Matheus Izvekov via cfe-commits
@@ -4159,7 +4159,7 @@ FunctionTemplateDecl *FunctionDecl::getPrimaryTemplate() const { if (FunctionTemplateSpecializationInfo *Info = TemplateOrSpecialization .dyn_cast()) { -return Info->getTemplate(); +return Info->getTemplate()->getMostRecentDe

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-04 Thread Erich Keane via cfe-commits
@@ -4159,7 +4159,7 @@ FunctionTemplateDecl *FunctionDecl::getPrimaryTemplate() const { if (FunctionTemplateSpecializationInfo *Info = TemplateOrSpecialization .dyn_cast()) { -return Info->getTemplate(); +return Info->getTemplate()->getMostRecentDe

[clang] [Clang][Parser] Remove the concept from the DeclContext if the definition is invalid (PR #111179)

2024-10-04 Thread Younan Zhang via cfe-commits
@@ -1151,3 +1151,17 @@ int test() { } } + +namespace GH109780 { + +template +concept Concept; // expected-error {{expected '='}} + +bool val = Concept; // expected-error {{use of undeclared identifier 'Concept'}} zyn0217 wrote: It could be improved as to th

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-04 Thread Steven Perron via cfe-commits
@@ -0,0 +1,28 @@ +; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv32v1.3-vulkan-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val %} + +; Test lowering to spir-v backend + +; CHECK-DAG: %[[#uint

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-10-04 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: > `-emit-pch -o "%t.pch" %t/From/../From/B.h` > `'could not find file > 'D:\llvm-project\build\tools\clang\test\VFS\Output\remap-to-fake.c.tmp\From\..\From\B.h'` Isn't that the same issue I mentioned, that it doesn't appear to work for the main PCH input file? If you remov

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features ssbs and ssbs2. (PR #110297)

2024-10-04 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/110297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Turn `-Wdeprecated-literal-operator` on by default (PR #111027)

2024-10-04 Thread Vlad Serebrennikov via cfe-commits
@@ -99,6 +99,20 @@ C++ Specific Potentially Breaking Changes // Was error, now evaluates to false. constexpr bool b = f() == g(); +- The warning ``-Wdeprecated-literal-operator`` is now on by default, as this is + something that WG21 has shown interest in removing fr

[clang] Turn `-Wdeprecated-literal-operator` on by default (PR #111027)

2024-10-04 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: I'm happy that we stop issuing diagnostics that contradict each other. https://github.com/llvm/llvm-project/pull/111027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-04 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/111010 >From 70089645ec5cf62b491a56df96ec46f4328fbc11 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Thu, 3 Oct 2024 11:43:51 -0700 Subject: [PATCH 1/3] [HLSL] Implement `WaveReadLaneAt` intrinsic - create a cl

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-04 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/111010 >From 70089645ec5cf62b491a56df96ec46f4328fbc11 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Thu, 3 Oct 2024 11:43:51 -0700 Subject: [PATCH 1/3] [HLSL] Implement `WaveReadLaneAt` intrinsic - create a cl

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-04 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/73 >From 51f84ce80ddda9e12591f263a24a19238fc69cb8 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 23 Sep 2024 10:51:21 -0400 Subject: [PATCH 1/2] Reapply "[Clang][Sema] Refactor collection of multi

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: Krystian Stasiowski (sdkrystian) Changes Reapplies #106585, fixing an issue where non-dependent names of member templates appearing prior to that member template being explicitly specialized for an impli

[clang] [clang-tools-extra] [RecursiveASTVisitor] Skip implicit instantiations. (PR #110899)

2024-10-04 Thread via cfe-commits
@@ -2069,22 +2069,24 @@ bool RecursiveASTVisitor::TraverseTemplateArgumentLocsHelper( #define DEF_TRAVERSE_TMPL_SPEC_DECL(TMPLDECLKIND, DECLKIND) \ DEF_TRAVERSE_DECL(TMPLDECLKIND##TemplateSpecializationDecl, { \ +auto TSK = D->getTemp

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-04 Thread Erich Keane via cfe-commits
erichkeane wrote: Can you point out the diff from the last review? It isn't clear. https://github.com/llvm/llvm-project/pull/73 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [RecursiveASTVisitor] Skip implicit instantiations. (PR #110899)

2024-10-04 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/110899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-04 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @erichkeane All changes made since the last review are in dfa5179f07b5a85c1daafd93b9f1d4bed9b4e27b https://github.com/llvm/llvm-project/pull/73 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang-tools-extra] [clang-tidy] Make `P +- BS / sizeof(*P)` opt-outable in `bugprone-sizeof-expression` (PR #111178)

2024-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (whisperity) Changes In some cases and for projects that deal with a lot of low-level buffers, a pattern often emerges that an array and its full size, not in the number of **elements** but in **bytes**, are known with no

[clang-tools-extra] [clang-tidy] Make `P +- BS / sizeof(*P)` opt-outable in `bugprone-sizeof-expression` (PR #111178)

2024-10-04 Thread via cfe-commits
https://github.com/whisperity created https://github.com/llvm/llvm-project/pull/78 In some cases and for projects that deal with a lot of low-level buffers, a pattern often emerges that an array and its full size, not in the number of **elements** but in **bytes**, are known with no syntax

[clang-tools-extra] [clang-tidy] Make `P +- BS / sizeof(*P)` opt-outable in `bugprone-sizeof-expression` (PR #111178)

2024-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: None (whisperity) Changes In some cases and for projects that deal with a lot of low-level buffers, a pattern often emerges that an array and its full size, not in the number of **elements** but in **bytes**, are known with no syntax

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/73 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Make `P +- BS / sizeof(*P)` opt-outable in `bugprone-sizeof-expression` (PR #111178)

2024-10-04 Thread via cfe-commits
whisperity wrote: **CC @douzzer**, who could not be added as a reviewer. https://github.com/llvm/llvm-project/pull/78 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Remove the concept from the DeclContext if the definition is invalid (PR #111179)

2024-10-04 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/79 Since #103867, the nullness of the concept declaration has been turned to represent a state in which the concept definition is being parsed and used for self-reference checking. However, that PR missed a case

[clang] [Clang] [Sema] Don't crash on unexpanded pack in invalid block literal (PR #110762)

2024-10-04 Thread via cfe-commits
Sirraide wrote: > I am not sure i understand that. > > Imo the issue is that `DiagnoseUnexpandedParameterPacks` (where we set > `LambdaScopeInfo::ContainsUnexpandedParameterPack` does not account for > blocks - and probably should. > > Ideally > > * DiagnoseUnexpandedParameterPacks would hand

[clang] [Clang][Parser] Remove the concept from the DeclContext if the definition is invalid (PR #111179)

2024-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes Since #103867, the nullness of the concept declaration has been turned to represent a state in which the concept definition is being parsed and used for self-reference checking. However, that PR missed a ca

[clang] 6a8fcb0 - [TableGen] Avoid repeated hash lookups (NFC) (#111089)

2024-10-04 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-10-04T07:37:31-07:00 New Revision: 6a8fcb0fa899af0b65caa3605fbed359189bed2f URL: https://github.com/llvm/llvm-project/commit/6a8fcb0fa899af0b65caa3605fbed359189bed2f DIFF: https://github.com/llvm/llvm-project/commit/6a8fcb0fa899af0b65caa3605fbed359189bed2f.diff L

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #111090)

2024-10-04 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/111090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TableGen] Avoid repeated hash lookups (NFC) (PR #111089)

2024-10-04 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/111089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c7895f0 - [DependencyScanning] Avoid repeated hash lookups (NFC) (#111088)

2024-10-04 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-10-04T07:37:54-07:00 New Revision: c7895f0d72ef3797fff6f687fd696e9a70911703 URL: https://github.com/llvm/llvm-project/commit/c7895f0d72ef3797fff6f687fd696e9a70911703 DIFF: https://github.com/llvm/llvm-project/commit/c7895f0d72ef3797fff6f687fd696e9a70911703.diff L

[clang] [DependencyScanning] Avoid repeated hash lookups (NFC) (PR #111088)

2024-10-04 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/111088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-10-04 Thread Andrzej Warzyński via cfe-commits
@@ -339,11 +335,11 @@ just added using your new frontend option. ## CMake Support As of [#7246](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7246) -(and soon to be released CMake 3.24.0), `cmake` can detect `flang-new` as a +(CMake 3.28.0), `cmake` can detect `flang

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-04 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @zyn0217 I have quite a few test cases I'll be adding soon https://github.com/llvm/llvm-project/pull/73 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [IR] Allow fast math flags on calls with homogeneous FP struct types (PR #110506)

2024-10-04 Thread Benjamin Maxwell via cfe-commits
MacDue wrote: It looks like this crash is not unique to struct types, I can reproduce it with array types too (which have been allowed for some time). https://github.com/llvm/llvm-project/pull/110506 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [analyzer] use `invalidateRegions()` in `VisitGCCAsmStmt` (PR #109838)

2024-10-04 Thread Pavel Skripkin via cfe-commits
@@ -40,7 +42,19 @@ void testInlineAsmMemcpyUninit(void) { int a[10], b[10] = {}, c; MyMemcpy(&a[1], &b[1], sizeof(b) - sizeof(b[1])); -c = a[0]; // expected-warning{{Assigned value is garbage or undefined}} +c = a[0]; // FIXME: should be warning about uninitiali

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic for spirv backend (PR #111010)

2024-10-04 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,40 @@ +// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \ +// RUN: dxil-pc-shadermodel6.3-compute %s -emit-llvm -disable-llvm-passes -o - | \ +// RUN: FileCheck %s --check-prefixes=CHECK,CHECK-DXIL +// RUN: %clang_cc1 -std=hlsl2021 -fincl

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-04 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 41c8d09b23b2328e727df83f022aaeb21b5e539e Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] [Clang] Implement CWG 2628 "Implicit deduction guides should propagate constraints" (PR #111143)

2024-10-04 Thread via cfe-commits
@@ -446,10 +450,46 @@ struct ConvertConstructorToDeductionGuideTransform { return nullptr; TypeSourceInfo *NewTInfo = TLB.getTypeSourceInfo(SemaRef.Context, NewType); +// At this point, the function parameters are already 'instantiated' in the +// current sco

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-10-04 Thread Balazs Benics via cfe-commits
steakhal wrote: FYI this PR likely caused a crash, reported in #47. https://github.com/llvm/llvm-project/pull/102602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement CWG 2628 "Implicit deduction guides should propagate constraints" (PR #111143)

2024-10-04 Thread Younan Zhang via cfe-commits
@@ -446,10 +450,46 @@ struct ConvertConstructorToDeductionGuideTransform { return nullptr; TypeSourceInfo *NewTInfo = TLB.getTypeSourceInfo(SemaRef.Context, NewType); +// At this point, the function parameters are already 'instantiated' in the +// current sco

[clang] d205191 - [MSVC] work-around for compile time issue 102513 (#110986)

2024-10-04 Thread via cfe-commits
Author: bd1976bris Date: 2024-10-04T14:59:41+01:00 New Revision: d2051919bb42087ebde2a8bdcd5b2676ad16d8eb URL: https://github.com/llvm/llvm-project/commit/d2051919bb42087ebde2a8bdcd5b2676ad16d8eb DIFF: https://github.com/llvm/llvm-project/commit/d2051919bb42087ebde2a8bdcd5b2676ad16d8eb.diff LO

[clang] [MSVC] work-around for compile time issue 102513 (PR #110986)

2024-10-04 Thread via cfe-commits
https://github.com/bd1976bris closed https://github.com/llvm/llvm-project/pull/110986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RFC][C++20][Modules] Relax ODR check in unnamed modules (PR #111160)

2024-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dmitry Polukhin (dmpolukhin) Changes Summary: Option `-fskip-odr-check-in-gmf` is set by default and I think it is what most of C++ developers want. But in header units, Clang ODR checking is too strict, making them hard to use, as seen i

[clang] [RFC][C++20][Modules] Relax ODR check in unnamed modules (PR #111160)

2024-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Dmitry Polukhin (dmpolukhin) Changes Summary: Option `-fskip-odr-check-in-gmf` is set by default and I think it is what most of C++ developers want. But in header units, Clang ODR checking is too strict, making them hard to use, a

[clang] [RFC][C++20][Modules] Relax ODR check in unnamed modules (PR #111160)

2024-10-04 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin created https://github.com/llvm/llvm-project/pull/60 Summary: Option `-fskip-odr-check-in-gmf` is set by default and I think it is what most of C++ developers want. But in header units, Clang ODR checking is too strict, making them hard to use, as seen in the

[clang] [clang][bytecode] Change isArrayElement() for narrowed composite arrays (PR #111110)

2024-10-04 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/10 Make isArrayElement() return true here, so we can know that such a pointer is in fact an array element and handle it properly in toAPValue(). >From d9ca4e19a4f5f9f17f941661782f20055ba1c6fe Mon Sep 17 00:00:00

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-04 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: Hmm, so this is causing problems: ```c++ namespace DoubleLockBug { class Foo { public: Mutex mu_; int a GUARDED_BY(m

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features ssbs and ssbs2. (PR #110297)

2024-10-04 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: Ping https://github.com/llvm/llvm-project/pull/110297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-04 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67520 >From 1c117257921fc1c246fbb9f51e3c95

[clang] [analyzer] use `invalidateRegions()` in `VisitGCCAsmStmt` (PR #109838)

2024-10-04 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/109838 >From dbec0e8368157684f9efc63a556037ba31d5f2ea Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Tue, 24 Sep 2024 20:18:30 +0300 Subject: [PATCH 1/3] clang/csa: use invalidateRegions() in VisitGCCAsmStmt ---

[clang] [flang] [flang][Driver] Add support for -f[no-]wrapv and -f[no]-strict-overflow in the frontend (PR #110061)

2024-10-04 Thread Yusuke MINATO via cfe-commits
https://github.com/yus3710-fj updated https://github.com/llvm/llvm-project/pull/110061 >From aea2cfa4b1d812dc84cb1609f93cc2ec2bcd33b4 Mon Sep 17 00:00:00 2001 From: Yusuke MINATO Date: Wed, 18 Sep 2024 21:12:43 +0900 Subject: [PATCH 1/2] [flang][Driver] Add support for -f[no-]wrapv and -f[no]-

[clang] [clang][bytecode] Change isArrayElement() for narrowed composite arrays (PR #111110)

2024-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Make isArrayElement() return true here, so we can know that such a pointer is in fact an array element and handle it properly in toAPValue(). --- Full diff: https://github.com/llvm/llvm-project/pull/10.d

[clang] [clang][bytecode] Change isArrayElement() for narrowed composite arrays (PR #111110)

2024-10-04 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/10 >From 2a2f13453a467ff4afbc9976a673cacb11b4eace Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 4 Oct 2024 08:37:16 +0200 Subject: [PATCH] [clang][bytecode] Change isArrayElement() for na

[clang] [flang] [flang][Driver] Add support for -f[no-]wrapv and -f[no]-strict-overflow in the frontend (PR #110061)

2024-10-04 Thread Yusuke MINATO via cfe-commits
@@ -866,6 +866,17 @@ void Flang::ConstructJob(Compilation &C, const JobAction &JA, } } + // -fno-strict-overflow implies -fwrapv if it isn't disabled, but + // -fstrict-overflow won't turn off an explicitly enabled -fwrapv. + if (Arg *A = Args.getLastArg(options::OPT

[clang] [flang] [flang][Driver] Add support for -f[no-]wrapv and -f[no]-strict-overflow in the frontend (PR #110061)

2024-10-04 Thread Yusuke MINATO via cfe-commits
@@ -0,0 +1,10 @@ +! Test for correct forwarding of integer overflow flags from the compiler driver +! to the frontend driver + +! RUN: %flang -### -fno-strict-overflow %s 2>&1 | FileCheck %s --check-prefixes CHECK,INDUCED yus3710-fj wrote: As you mentioned, the

[clang-tools-extra] 992e754 - Fix MSVC "not all control paths return a value" warning. NFC.

2024-10-04 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-10-04T09:54:13+01:00 New Revision: 992e75403f417d46ce9015147ff49d67009e736c URL: https://github.com/llvm/llvm-project/commit/992e75403f417d46ce9015147ff49d67009e736c DIFF: https://github.com/llvm/llvm-project/commit/992e75403f417d46ce9015147ff49d67009e736c.diff

[clang] [clang][analyzer] Check initialization and argument passing in FixedAddressChecker (PR #110977)

2024-10-04 Thread Balázs Kéri via cfe-commits
balazske wrote: When `check::Location` is used it looks better to extend the `DereferenceChecker` with this new check that looks simple to add to it (it uses `check::Bind` too, probably this finds the cases when location does not work). Only difficulty is that this is a non-fatal error. https

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-04 Thread Budimir Aranđelović via cfe-commits
@@ -5335,6 +5335,217 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// This function is called only if function call is not inside template body. +// TODO: Add call

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-10-04 Thread Brad Richardson via cfe-commits
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH 1/5] [flang][driver] rename flang-new to flang --

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-10-04 Thread Brad Richardson via cfe-commits
@@ -339,11 +335,11 @@ just added using your new frontend option. ## CMake Support As of [#7246](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7246) -(and soon to be released CMake 3.24.0), `cmake` can detect `flang-new` as a +(and soon to be released CMake 3.24.0), `

[clang] [Clang][Sema] fix noexecpt mismatch of friend declaration (PR #102267)

2024-10-04 Thread Younan Zhang via cfe-commits
@@ -4698,7 +4698,22 @@ void Sema::InstantiateExceptionSpec(SourceLocation PointOfInstantiation, // Enter the scope of this instantiation. We don't use // PushDeclContext because we don't have a scope. Sema::ContextRAII savedContext(*this, Decl); + + FunctionDecl *Source

[clang] [Clang] Add "extend lifetime" flags and release note (PR #110000)

2024-10-04 Thread Stephen Tozer via cfe-commits
SLTozer wrote: > The release note doesn't say: Does `-fextend-lifetimes` imply > `-fextend-this-pointer`? They're implemented as independent toggles but the > effect isn't really independent IIRC. I wonder (years after it was originally > implemented downstream, I know) whether we'd be better

[clang] [Clang] Implement CWG 2628 "Implicit deduction guides should propagate constraints" (PR #111143)

2024-10-04 Thread Erich Keane via cfe-commits
@@ -446,10 +450,46 @@ struct ConvertConstructorToDeductionGuideTransform { return nullptr; TypeSourceInfo *NewTInfo = TLB.getTypeSourceInfo(SemaRef.Context, NewType); +// At this point, the function parameters are already 'instantiated' in the +// current sco

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-10-04 Thread Matin Raayai via cfe-commits
@@ -1162,6 +1165,7 @@ void EmitAssemblyHelper::RunCodegenPipeline( // does not work with the codegen pipeline. // FIXME: make the new PM work with the codegen pipeline. legacy::PassManager CodeGenPasses; + std::unique_ptr MMI; matinraayai wrote: I'll ch

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic for spirv backend (PR #111010)

2024-10-04 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts edited https://github.com/llvm/llvm-project/pull/111010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic for spirv backend (PR #111010)

2024-10-04 Thread Nathan Gauër via cfe-commits
@@ -2653,6 +2653,21 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register ResVReg, .addUse(GR.getSPIRVTypeID(ResType)) .addUse(GR.getOrCreateConstInt(3, I, IntTy, TII)); } + case Intrinsic::spv_wave_read_lane_at: { +assert(I.getNumOperands() == 4);

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic for spirv backend (PR #111010)

2024-10-04 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts commented: Thanks for this! Some minor changes, otherwise looks good 😊 https://github.com/llvm/llvm-project/pull/111010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] d0756ca - [ARM][AArch64] Introduce the Armv9.6-A architecture version (#110825)

2024-10-04 Thread via cfe-commits
Author: Jonathan Thackray Date: 2024-10-04T10:12:41+01:00 New Revision: d0756caedcf067860240bf31e8f9d371ba706757 URL: https://github.com/llvm/llvm-project/commit/d0756caedcf067860240bf31e8f9d371ba706757 DIFF: https://github.com/llvm/llvm-project/commit/d0756caedcf067860240bf31e8f9d371ba706757.d

[clang] [llvm] [ARM][AArch64] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-04 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray closed https://github.com/llvm/llvm-project/pull/110825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Print more static_assert exprs (PR #74852)

2024-10-04 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/74852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM][AArch64] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-04 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang,llvm` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/4916 Here is the relevant piece of the buil

[clang] [flang] [flang][driver] Make -stdlib= option visible to flang and silently ignored by it (PR #110598)

2024-10-04 Thread Michael Kruse via cfe-commits
Meinersbur wrote: >From the summary? > This has created a nowhere to go situation, the only remaining option is to > make the -stdlib flag visible to flang and silently ignored. Can you clarify? I think it is not ignored, otherwise the test would fail since it requires linking to the `` imple

[clang] [clang][analyzer] Check initialization and argument passing in FixedAddressChecker (PR #110977)

2024-10-04 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > I was thinking about using `check::Location` in this checker. The real > problem is when the fixed address is used (to store or load), not if it is > assigned to a pointer. (Or a fixed address becomes escaped.) I agree that a checker that activates when a fixed address is _d

[clang] 3c98d8c - [OpenACC] Implement 'tile' loop count/tightly nested loop requirement (#111038)

2024-10-04 Thread via cfe-commits
Author: Erich Keane Date: 2024-10-04T06:03:43-07:00 New Revision: 3c98d8c14612699444ac906729c9b2872190c938 URL: https://github.com/llvm/llvm-project/commit/3c98d8c14612699444ac906729c9b2872190c938 DIFF: https://github.com/llvm/llvm-project/commit/3c98d8c14612699444ac906729c9b2872190c938.diff L

[clang] [OpenACC] Implement 'tile' loop count/tightly nested loop requirement (PR #111038)

2024-10-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/111038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix noexecpt mismatch of friend declaration (PR #102267)

2024-10-04 Thread Younan Zhang via cfe-commits
@@ -4698,7 +4698,22 @@ void Sema::InstantiateExceptionSpec(SourceLocation PointOfInstantiation, // Enter the scope of this instantiation. We don't use // PushDeclContext because we don't have a scope. Sema::ContextRAII savedContext(*this, Decl); + + FunctionDecl *Source

[clang] [Clang] Automatically enable `-fconvergent-functions` on GPU targets (PR #111076)

2024-10-04 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > -fno-convergent-functions to opt-out if you want to test broken behavior. > > You may legitimately know there are no convergent functions in the TU. We > also have the noconvergent source attribute now for this Think it would be useful to put that on functions in the wrapper

[clang] 8d661fd - [analyzer] use `invalidateRegions()` in `VisitGCCAsmStmt` (#109838)

2024-10-04 Thread via cfe-commits
Author: Pavel Skripkin Date: 2024-10-04T16:12:29+03:00 New Revision: 8d661fd9fd50fe4be9a9d5a8cc8f52f23925e7f6 URL: https://github.com/llvm/llvm-project/commit/8d661fd9fd50fe4be9a9d5a8cc8f52f23925e7f6 DIFF: https://github.com/llvm/llvm-project/commit/8d661fd9fd50fe4be9a9d5a8cc8f52f23925e7f6.diff

[clang] [analyzer] use `invalidateRegions()` in `VisitGCCAsmStmt` (PR #109838)

2024-10-04 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag closed https://github.com/llvm/llvm-project/pull/109838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Automatically enable `-fconvergent-functions` on GPU targets (PR #111076)

2024-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/111076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Automatically enable `-fconvergent-functions` on GPU targets (PR #111076)

2024-10-04 Thread Matt Arsenault via cfe-commits
arsenm wrote: > Think it would be useful to put that on functions in the wrapper headers that > definitely aren't convergent? E.g. getting a thread id. You could, but it's trivially inferable in those cases anyway https://github.com/llvm/llvm-project/pull/111076

[clang] [Clang][Sema] fix noexecpt mismatch of friend declaration (PR #102267)

2024-10-04 Thread Krystian Stasiowski via cfe-commits
@@ -4698,7 +4698,22 @@ void Sema::InstantiateExceptionSpec(SourceLocation PointOfInstantiation, // Enter the scope of this instantiation. We don't use // PushDeclContext because we don't have a scope. Sema::ContextRAII savedContext(*this, Decl); + + FunctionDecl *Source

[clang] [flang] [llvm] [openmp] [Clang][OpenMP] Add permutation clause (PR #92030)

2024-10-04 Thread Michael Kruse via cfe-commits
Meinersbur wrote: @alexey-bataev Could you have another look? https://github.com/llvm/llvm-project/pull/92030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [lldb] [llvm] [NFC] Rename Option parsing related files from OptXYZ -> OptionXYZ (PR #110692)

2024-10-04 Thread Rahul Joshi via cfe-commits
jurahul wrote: @JDevlieghere @cyndyishida @topperc gentle ping. It's mostly mechanical. https://github.com/llvm/llvm-project/pull/110692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [IR] Allow fast math flags on calls with homogeneous FP struct types (PR #110506)

2024-10-04 Thread Benjamin Maxwell via cfe-commits
MacDue wrote: > Hi, > > I bisected a crash to this patch. I can't share the C reproducer but it's > instcombine that crashes and a reduced reproducer for that is > ```opt -passes=instcombine bbi-99792.ll -o /dev/null``` > > [bbi-99792.ll.gz](https://github.com/user-attachments/files/17253640/b

[clang] [flang] [flang][driver] Make -stdlib= option visible to flang and silently ignored by it (PR #110598)

2024-10-04 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: We should avoid dummy flags like this - they are usually an indication of a larger issue. I don't want to block this and, as @Meinersbur points out, there are some "inherited issues" to consider too. However, I'd like to identify the right long-term solution here. If poss

  1   2   3   4   >